Merge branch 'master' of git+ssh://galak@master.kernel.org/pub/scm/linux/kernel/git/galak/powerpc

3 files changed, 13 insertions, 7 deletions

diff --git a/sound/core/control_compat.c b/sound/core/control_compat.c
index 418c6d4e5d..a529b62972 100644
--- a/sound/core/control_compat.c
+++ b/sound/core/control_compat.c
@@ -167,7 +167,7 @@ static int get_ctl_type(struct snd_card *card, struct snd_ctl_elem_id *id,
                         int *countp)
 {
         struct snd_kcontrol *kctl;
-        struct snd_ctl_elem_info info;
+        struct snd_ctl_elem_info *info;
         int err;
 
         down_read(&card->controls_rwsem);
@@ -176,13 +176,19 @@ static int get_ctl_type(struct snd_card *card, struct snd_ctl_elem_id *id,
                 up_read(&card->controls_rwsem);
                 return -ENXIO;
         }
-        info.id = *id;
-        err = kctl->info(kctl, &info);
+        info = kzalloc(sizeof(*info), GFP_KERNEL);
+        if (info == NULL) {
+                up_read(&card->controls_rwsem);
+                return -ENOMEM;
+        }
+        info->id = *id;
+        err = kctl->info(kctl, info);
         up_read(&card->controls_rwsem);
         if (err >= 0) {
-                err = info.type;
-                *countp = info.count;
+                err = info->type;
+                *countp = info->count;
         }
+        kfree(info);
         return err;
 }
 
diff --git a/sound/drivers/opl3/opl3_oss.c b/sound/drivers/opl3/opl3_oss.c
index 31f1f2e25a..0345ae6476 100644
--- a/sound/drivers/opl3/opl3_oss.c
+++ b/sound/drivers/opl3/opl3_oss.c
@@ -146,7 +146,7 @@ void snd_opl3_init_seq_oss(struct snd_opl3 *opl3, char *name)
 void snd_opl3_free_seq_oss(struct snd_opl3 *opl3)
 {
         if (opl3->oss_seq_dev) {
-                snd_device_free(opl3->card, opl3->oss_seq_dev);
+                /* The instance should have been released in prior */
                 opl3->oss_seq_dev = NULL;
         }
 }
diff --git a/sound/isa/cs423x/cs4236.c b/sound/isa/cs423x/cs4236.c
index 4fa4310405..99a42138be 100644
--- a/sound/isa/cs423x/cs4236.c
+++ b/sound/isa/cs423x/cs4236.c
@@ -414,7 +414,7 @@ static int __devinit snd_card_cs423x_pnpc(int dev, struct snd_card_cs4236 *acard
         }
         /* MPU initialization */
         if (acard->mpu && mpu_port[dev] > 0) {
-                if (snd_cs423x_pnp_init_mpu(dev, acard->ctrl, cfg) < 0)
+                if (snd_cs423x_pnp_init_mpu(dev, acard->mpu, cfg) < 0)
                         goto error;
         }
         kfree(cfg);