diff options
author | Jean Delvare <khali@linux-fr.org> | 2007-03-06 05:45:12 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-05-02 22:02:35 -0400 |
commit | 6473d160b4aba8023bcf38519a5989694dfd51a7 (patch) | |
tree | 5a3fe32ecc3d846b9de00ad5ba726314ca79f15b /sound | |
parent | a9dfd281a7e12f6d9b53b5a28649b3a3c76a70e6 (diff) |
PCI: Cleanup the includes of <linux/pci.h>
I noticed that many source files include <linux/pci.h> while they do
not appear to need it. Here is an attempt to clean it all up.
In order to find all possibly affected files, I searched for all
files including <linux/pci.h> but without any other occurence of "pci"
or "PCI". I removed the include statement from all of these, then I
compiled an allmodconfig kernel on both i386 and x86_64 and fixed the
false positives manually.
My tests covered 66% of the affected files, so there could be false
positives remaining. Untested files are:
arch/alpha/kernel/err_common.c
arch/alpha/kernel/err_ev6.c
arch/alpha/kernel/err_ev7.c
arch/ia64/sn/kernel/huberror.c
arch/ia64/sn/kernel/xpnet.c
arch/m68knommu/kernel/dma.c
arch/mips/lib/iomap.c
arch/powerpc/platforms/pseries/ras.c
arch/ppc/8260_io/enet.c
arch/ppc/8260_io/fcc_enet.c
arch/ppc/8xx_io/enet.c
arch/ppc/syslib/ppc4xx_sgdma.c
arch/sh64/mach-cayman/iomap.c
arch/xtensa/kernel/xtensa_ksyms.c
arch/xtensa/platform-iss/setup.c
drivers/i2c/busses/i2c-at91.c
drivers/i2c/busses/i2c-mpc.c
drivers/media/video/saa711x.c
drivers/misc/hdpuftrs/hdpu_cpustate.c
drivers/misc/hdpuftrs/hdpu_nexus.c
drivers/net/au1000_eth.c
drivers/net/fec_8xx/fec_main.c
drivers/net/fec_8xx/fec_mii.c
drivers/net/fs_enet/fs_enet-main.c
drivers/net/fs_enet/mac-fcc.c
drivers/net/fs_enet/mac-fec.c
drivers/net/fs_enet/mac-scc.c
drivers/net/fs_enet/mii-bitbang.c
drivers/net/fs_enet/mii-fec.c
drivers/net/ibm_emac/ibm_emac_core.c
drivers/net/lasi_82596.c
drivers/parisc/hppb.c
drivers/sbus/sbus.c
drivers/video/g364fb.c
drivers/video/platinumfb.c
drivers/video/stifb.c
drivers/video/valkyriefb.c
include/asm-arm/arch-ixp4xx/dma.h
sound/oss/au1550_ac97.c
I would welcome test reports for these files. I am fine with removing
the untested files from the patch if the general opinion is that these
changes aren't safe. The tested part would still be nice to have.
Note that this patch depends on another header fixup patch I submitted
to LKML yesterday:
[PATCH] scatterlist.h needs types.h
http://lkml.org/lkml/2007/3/01/141
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Badari Pulavarty <pbadari@us.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'sound')
-rw-r--r-- | sound/core/init.c | 1 | ||||
-rw-r--r-- | sound/oss/au1550_ac97.c | 1 | ||||
-rw-r--r-- | sound/oss/soundcard.c | 1 | ||||
-rw-r--r-- | sound/pci/ca0106/ca0106_mixer.c | 2 | ||||
-rw-r--r-- | sound/pci/ca0106/ca0106_proc.c | 2 | ||||
-rw-r--r-- | sound/pci/cs46xx/dsp_spos.c | 1 | ||||
-rw-r--r-- | sound/pci/cs46xx/dsp_spos_scb_lib.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/hda_generic.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/hda_proc.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_atihdmi.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_si3054.c | 1 | ||||
-rw-r--r-- | sound/pci/hda/patch_via.c | 1 |
12 files changed, 3 insertions, 11 deletions
diff --git a/sound/core/init.c b/sound/core/init.c index 4a431e3ea3..f2fe357371 100644 --- a/sound/core/init.c +++ b/sound/core/init.c | |||
@@ -26,7 +26,6 @@ | |||
26 | #include <linux/slab.h> | 26 | #include <linux/slab.h> |
27 | #include <linux/time.h> | 27 | #include <linux/time.h> |
28 | #include <linux/ctype.h> | 28 | #include <linux/ctype.h> |
29 | #include <linux/pci.h> | ||
30 | #include <linux/pm.h> | 29 | #include <linux/pm.h> |
31 | 30 | ||
32 | #include <sound/core.h> | 31 | #include <sound/core.h> |
diff --git a/sound/oss/au1550_ac97.c b/sound/oss/au1550_ac97.c index a339f0c0d5..23018a7c06 100644 --- a/sound/oss/au1550_ac97.c +++ b/sound/oss/au1550_ac97.c | |||
@@ -47,7 +47,6 @@ | |||
47 | #include <linux/interrupt.h> | 47 | #include <linux/interrupt.h> |
48 | #include <linux/kernel.h> | 48 | #include <linux/kernel.h> |
49 | #include <linux/poll.h> | 49 | #include <linux/poll.h> |
50 | #include <linux/pci.h> | ||
51 | #include <linux/bitops.h> | 50 | #include <linux/bitops.h> |
52 | #include <linux/spinlock.h> | 51 | #include <linux/spinlock.h> |
53 | #include <linux/smp_lock.h> | 52 | #include <linux/smp_lock.h> |
diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c index dcd8d6d2f5..a9c23b2502 100644 --- a/sound/oss/soundcard.c +++ b/sound/oss/soundcard.c | |||
@@ -44,6 +44,7 @@ | |||
44 | #include <linux/smp_lock.h> | 44 | #include <linux/smp_lock.h> |
45 | #include <linux/module.h> | 45 | #include <linux/module.h> |
46 | #include <linux/mm.h> | 46 | #include <linux/mm.h> |
47 | #include <linux/device.h> | ||
47 | 48 | ||
48 | /* | 49 | /* |
49 | * This ought to be moved into include/asm/dma.h | 50 | * This ought to be moved into include/asm/dma.h |
diff --git a/sound/pci/ca0106/ca0106_mixer.c b/sound/pci/ca0106/ca0106_mixer.c index b913a1fb8c..9c3a9c8d1d 100644 --- a/sound/pci/ca0106/ca0106_mixer.c +++ b/sound/pci/ca0106/ca0106_mixer.c | |||
@@ -62,7 +62,6 @@ | |||
62 | #include <linux/delay.h> | 62 | #include <linux/delay.h> |
63 | #include <linux/init.h> | 63 | #include <linux/init.h> |
64 | #include <linux/interrupt.h> | 64 | #include <linux/interrupt.h> |
65 | #include <linux/pci.h> | ||
66 | #include <linux/slab.h> | 65 | #include <linux/slab.h> |
67 | #include <linux/moduleparam.h> | 66 | #include <linux/moduleparam.h> |
68 | #include <sound/core.h> | 67 | #include <sound/core.h> |
@@ -71,6 +70,7 @@ | |||
71 | #include <sound/ac97_codec.h> | 70 | #include <sound/ac97_codec.h> |
72 | #include <sound/info.h> | 71 | #include <sound/info.h> |
73 | #include <sound/tlv.h> | 72 | #include <sound/tlv.h> |
73 | #include <asm/io.h> | ||
74 | 74 | ||
75 | #include "ca0106.h" | 75 | #include "ca0106.h" |
76 | 76 | ||
diff --git a/sound/pci/ca0106/ca0106_proc.c b/sound/pci/ca0106/ca0106_proc.c index 75ca421eb3..ae80f51d8c 100644 --- a/sound/pci/ca0106/ca0106_proc.c +++ b/sound/pci/ca0106/ca0106_proc.c | |||
@@ -64,7 +64,6 @@ | |||
64 | #include <linux/delay.h> | 64 | #include <linux/delay.h> |
65 | #include <linux/init.h> | 65 | #include <linux/init.h> |
66 | #include <linux/interrupt.h> | 66 | #include <linux/interrupt.h> |
67 | #include <linux/pci.h> | ||
68 | #include <linux/slab.h> | 67 | #include <linux/slab.h> |
69 | #include <linux/moduleparam.h> | 68 | #include <linux/moduleparam.h> |
70 | #include <sound/core.h> | 69 | #include <sound/core.h> |
@@ -73,6 +72,7 @@ | |||
73 | #include <sound/ac97_codec.h> | 72 | #include <sound/ac97_codec.h> |
74 | #include <sound/info.h> | 73 | #include <sound/info.h> |
75 | #include <sound/asoundef.h> | 74 | #include <sound/asoundef.h> |
75 | #include <asm/io.h> | ||
76 | 76 | ||
77 | #include "ca0106.h" | 77 | #include "ca0106.h" |
78 | 78 | ||
diff --git a/sound/pci/cs46xx/dsp_spos.c b/sound/pci/cs46xx/dsp_spos.c index 89c402770a..336e77e260 100644 --- a/sound/pci/cs46xx/dsp_spos.c +++ b/sound/pci/cs46xx/dsp_spos.c | |||
@@ -23,7 +23,6 @@ | |||
23 | #include <sound/driver.h> | 23 | #include <sound/driver.h> |
24 | #include <asm/io.h> | 24 | #include <asm/io.h> |
25 | #include <linux/delay.h> | 25 | #include <linux/delay.h> |
26 | #include <linux/pci.h> | ||
27 | #include <linux/pm.h> | 26 | #include <linux/pm.h> |
28 | #include <linux/init.h> | 27 | #include <linux/init.h> |
29 | #include <linux/slab.h> | 28 | #include <linux/slab.h> |
diff --git a/sound/pci/cs46xx/dsp_spos_scb_lib.c b/sound/pci/cs46xx/dsp_spos_scb_lib.c index 343f51d531..57e357de15 100644 --- a/sound/pci/cs46xx/dsp_spos_scb_lib.c +++ b/sound/pci/cs46xx/dsp_spos_scb_lib.c | |||
@@ -24,7 +24,6 @@ | |||
24 | #include <sound/driver.h> | 24 | #include <sound/driver.h> |
25 | #include <asm/io.h> | 25 | #include <asm/io.h> |
26 | #include <linux/delay.h> | 26 | #include <linux/delay.h> |
27 | #include <linux/pci.h> | ||
28 | #include <linux/pm.h> | 27 | #include <linux/pm.h> |
29 | #include <linux/init.h> | 28 | #include <linux/init.h> |
30 | #include <linux/slab.h> | 29 | #include <linux/slab.h> |
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index 1589d2f291..1e5ff0cd37 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c | |||
@@ -23,7 +23,6 @@ | |||
23 | #include <sound/driver.h> | 23 | #include <sound/driver.h> |
24 | #include <linux/init.h> | 24 | #include <linux/init.h> |
25 | #include <linux/slab.h> | 25 | #include <linux/slab.h> |
26 | #include <linux/pci.h> | ||
27 | #include <sound/core.h> | 26 | #include <sound/core.h> |
28 | #include "hda_codec.h" | 27 | #include "hda_codec.h" |
29 | #include "hda_local.h" | 28 | #include "hda_local.h" |
diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c index 17df4d0fe1..e313e685f1 100644 --- a/sound/pci/hda/hda_proc.c +++ b/sound/pci/hda/hda_proc.c | |||
@@ -23,7 +23,6 @@ | |||
23 | 23 | ||
24 | #include <sound/driver.h> | 24 | #include <sound/driver.h> |
25 | #include <linux/init.h> | 25 | #include <linux/init.h> |
26 | #include <linux/pci.h> | ||
27 | #include <sound/core.h> | 26 | #include <sound/core.h> |
28 | #include "hda_codec.h" | 27 | #include "hda_codec.h" |
29 | #include "hda_local.h" | 28 | #include "hda_local.h" |
diff --git a/sound/pci/hda/patch_atihdmi.c b/sound/pci/hda/patch_atihdmi.c index 7333f275de..831469d3a9 100644 --- a/sound/pci/hda/patch_atihdmi.c +++ b/sound/pci/hda/patch_atihdmi.c | |||
@@ -25,7 +25,6 @@ | |||
25 | #include <linux/init.h> | 25 | #include <linux/init.h> |
26 | #include <linux/delay.h> | 26 | #include <linux/delay.h> |
27 | #include <linux/slab.h> | 27 | #include <linux/slab.h> |
28 | #include <linux/pci.h> | ||
29 | #include <sound/core.h> | 28 | #include <sound/core.h> |
30 | #include "hda_codec.h" | 29 | #include "hda_codec.h" |
31 | #include "hda_local.h" | 30 | #include "hda_local.h" |
diff --git a/sound/pci/hda/patch_si3054.c b/sound/pci/hda/patch_si3054.c index ed5e45e359..6fcda9bcf0 100644 --- a/sound/pci/hda/patch_si3054.c +++ b/sound/pci/hda/patch_si3054.c | |||
@@ -26,7 +26,6 @@ | |||
26 | #include <linux/init.h> | 26 | #include <linux/init.h> |
27 | #include <linux/delay.h> | 27 | #include <linux/delay.h> |
28 | #include <linux/slab.h> | 28 | #include <linux/slab.h> |
29 | #include <linux/pci.h> | ||
30 | #include <sound/core.h> | 29 | #include <sound/core.h> |
31 | #include "hda_codec.h" | 30 | #include "hda_codec.h" |
32 | #include "hda_local.h" | 31 | #include "hda_local.h" |
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c index 4c839b0317..2b11ac8689 100644 --- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c | |||
@@ -35,7 +35,6 @@ | |||
35 | #include <linux/init.h> | 35 | #include <linux/init.h> |
36 | #include <linux/delay.h> | 36 | #include <linux/delay.h> |
37 | #include <linux/slab.h> | 37 | #include <linux/slab.h> |
38 | #include <linux/pci.h> | ||
39 | #include <sound/core.h> | 38 | #include <sound/core.h> |
40 | #include "hda_codec.h" | 39 | #include "hda_codec.h" |
41 | #include "hda_local.h" | 40 | #include "hda_local.h" |