aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/sched_global_edf.c
diff options
context:
space:
mode:
authorBjoern B. Brandenburg <bbb@cs.unc.edu>2007-10-27 15:47:22 -0400
committerBjoern B. Brandenburg <bbb@cs.unc.edu>2007-10-27 15:47:22 -0400
commita4d08351aacc56e79b03c85fc9bbcb03567309fa (patch)
tree8f15cd5c23a86c72c7376c3da8248e4850629b7f /kernel/sched_global_edf.c
parent2e4b97e2e722699fe2ce2699714887eac0ff84cc (diff)
cleanup: tidy up code before release2007.2
This gets rid of quite a few FIXMEs and TODOs, as well as some cruft.
Diffstat (limited to 'kernel/sched_global_edf.c')
-rw-r--r--kernel/sched_global_edf.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/kernel/sched_global_edf.c b/kernel/sched_global_edf.c
index 6e3928b7df..4b36bc5a48 100644
--- a/kernel/sched_global_edf.c
+++ b/kernel/sched_global_edf.c
@@ -64,7 +64,6 @@ static void adjust_cpu_queue(int exec_rt, jiffie_t deadline)
64 entry->executes_realtime = exec_rt; 64 entry->executes_realtime = exec_rt;
65 entry->cur_deadline = deadline; 65 entry->cur_deadline = deadline;
66 66
67 /* TODO: move instead of del+reinsert */
68 list_del(&entry->list); 67 list_del(&entry->list);
69 /* if we do not execute real-time jobs we just move 68 /* if we do not execute real-time jobs we just move
70 * to the end of the queue 69 * to the end of the queue
@@ -94,10 +93,6 @@ static void adjust_cpu_queue(int exec_rt, jiffie_t deadline)
94 * kick the next if necessary, and so on. The caller is responsible for making 93 * kick the next if necessary, and so on. The caller is responsible for making
95 * sure that it is not the last entry or that a reschedule is not necessary. 94 * sure that it is not the last entry or that a reschedule is not necessary.
96 * 95 *
97 * TODO: This function is probably way too trigger happy. It should only send
98 * IPIs if the other CPU is not going to reschedule anyway. But that is
99 * hard to detect reliably. Too many schedules will hurt performance
100 * but do not cause incorrect schedules.
101 */ 96 */
102static int gedf_check_resched(rt_domain_t *edf) 97static int gedf_check_resched(rt_domain_t *edf)
103{ 98{
@@ -336,9 +331,6 @@ static void gedf_wake_up_task(struct task_struct *task)
336 } 331 }
337 else if (task->time_slice) { 332 else if (task->time_slice) {
338 /* came back in time before deadline 333 /* came back in time before deadline
339 * TODO: clip budget to fit into period, otherwise it could
340 * cause a deadline overrun in the next period, i.e.
341 * over allocation in the next period.
342 */ 334 */
343 set_rt_flags(task, RT_F_RUNNING); 335 set_rt_flags(task, RT_F_RUNNING);
344 add_ready(&gedf, task); 336 add_ready(&gedf, task);
@@ -356,8 +348,6 @@ static void gedf_task_blocks(struct task_struct *t)
356 * it is running, and when it is not running it is not in any 348 * it is running, and when it is not running it is not in any
357 * queue anyway. 349 * queue anyway.
358 * 350 *
359 * TODO: Check whether the assumption is correct for SIGKILL and
360 * SIGSTOP.
361 */ 351 */
362 TRACE("task %d blocks with budget=%d\n", t->pid, t->time_slice); 352 TRACE("task %d blocks with budget=%d\n", t->pid, t->time_slice);
363 BUG_ON(t->rt_list.next != LIST_POISON1); 353 BUG_ON(t->rt_list.next != LIST_POISON1);
@@ -433,7 +423,6 @@ static sched_plugin_t s_plugin __cacheline_aligned_in_smp = {
433 .prepare_task = gedf_prepare_task,\ 423 .prepare_task = gedf_prepare_task,\
434 .sleep_next_period = edf_sleep_next_period,\ 424 .sleep_next_period = edf_sleep_next_period,\
435 .tear_down = gedf_tear_down,\ 425 .tear_down = gedf_tear_down,\
436 .shutdown_hook = 0,\
437 .schedule = gedf_schedule,\ 426 .schedule = gedf_schedule,\
438 .finish_switch = gedf_finish_switch,\ 427 .finish_switch = gedf_finish_switch,\
439 .mode_change = gedf_mode_change,\ 428 .mode_change = gedf_mode_change,\
@@ -538,7 +527,6 @@ static int gedf_np_check_resched(rt_domain_t *edf)
538 .prepare_task = gedf_prepare_task,\ 527 .prepare_task = gedf_prepare_task,\
539 .sleep_next_period = edf_sleep_next_period,\ 528 .sleep_next_period = edf_sleep_next_period,\
540 .tear_down = gedf_tear_down,\ 529 .tear_down = gedf_tear_down,\
541 .shutdown_hook = 0,\
542 .schedule = gedf_schedule,\ 530 .schedule = gedf_schedule,\
543 .finish_switch = gedf_finish_switch,\ 531 .finish_switch = gedf_finish_switch,\
544 .mode_change = gedf_mode_change,\ 532 .mode_change = gedf_mode_change,\