diff options
author | David Woodhouse <dwmw2@infradead.org> | 2007-07-23 05:20:10 -0400 |
---|---|---|
committer | David Woodhouse <dwmw2@infradead.org> | 2007-07-23 05:20:10 -0400 |
commit | 39fe5434cb9de5da40510028b17b96bc4eb312b3 (patch) | |
tree | 7a02a317b9ad57da51ca99887c119e779ccf3f13 /fs/dlm | |
parent | 0fc72b81d3111d114ab378935b1cf07680ca1289 (diff) | |
parent | f695baf2df9e0413d3521661070103711545207a (diff) |
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6
Diffstat (limited to 'fs/dlm')
-rw-r--r-- | fs/dlm/config.c | 20 | ||||
-rw-r--r-- | fs/dlm/lowcomms.c | 2 | ||||
-rw-r--r-- | fs/dlm/memory.c | 14 |
3 files changed, 11 insertions, 25 deletions
diff --git a/fs/dlm/config.c b/fs/dlm/config.c index 5069b2cb5a..2f8e3c81bc 100644 --- a/fs/dlm/config.c +++ b/fs/dlm/config.c | |||
@@ -133,14 +133,6 @@ static ssize_t cluster_set(struct cluster *cl, unsigned int *cl_field, | |||
133 | return len; | 133 | return len; |
134 | } | 134 | } |
135 | 135 | ||
136 | #define __CONFIGFS_ATTR(_name,_mode,_read,_write) { \ | ||
137 | .attr = { .ca_name = __stringify(_name), \ | ||
138 | .ca_mode = _mode, \ | ||
139 | .ca_owner = THIS_MODULE }, \ | ||
140 | .show = _read, \ | ||
141 | .store = _write, \ | ||
142 | } | ||
143 | |||
144 | #define CLUSTER_ATTR(name, check_zero) \ | 136 | #define CLUSTER_ATTR(name, check_zero) \ |
145 | static ssize_t name##_write(struct cluster *cl, const char *buf, size_t len) \ | 137 | static ssize_t name##_write(struct cluster *cl, const char *buf, size_t len) \ |
146 | { \ | 138 | { \ |
@@ -615,7 +607,7 @@ static struct clusters clusters_root = { | |||
615 | int dlm_config_init(void) | 607 | int dlm_config_init(void) |
616 | { | 608 | { |
617 | config_group_init(&clusters_root.subsys.su_group); | 609 | config_group_init(&clusters_root.subsys.su_group); |
618 | init_MUTEX(&clusters_root.subsys.su_sem); | 610 | mutex_init(&clusters_root.subsys.su_mutex); |
619 | return configfs_register_subsystem(&clusters_root.subsys); | 611 | return configfs_register_subsystem(&clusters_root.subsys); |
620 | } | 612 | } |
621 | 613 | ||
@@ -759,9 +751,9 @@ static struct space *get_space(char *name) | |||
759 | if (!space_list) | 751 | if (!space_list) |
760 | return NULL; | 752 | return NULL; |
761 | 753 | ||
762 | down(&space_list->cg_subsys->su_sem); | 754 | mutex_lock(&space_list->cg_subsys->su_mutex); |
763 | i = config_group_find_obj(space_list, name); | 755 | i = config_group_find_item(space_list, name); |
764 | up(&space_list->cg_subsys->su_sem); | 756 | mutex_unlock(&space_list->cg_subsys->su_mutex); |
765 | 757 | ||
766 | return to_space(i); | 758 | return to_space(i); |
767 | } | 759 | } |
@@ -780,7 +772,7 @@ static struct comm *get_comm(int nodeid, struct sockaddr_storage *addr) | |||
780 | if (!comm_list) | 772 | if (!comm_list) |
781 | return NULL; | 773 | return NULL; |
782 | 774 | ||
783 | down(&clusters_root.subsys.su_sem); | 775 | mutex_lock(&clusters_root.subsys.su_mutex); |
784 | 776 | ||
785 | list_for_each_entry(i, &comm_list->cg_children, ci_entry) { | 777 | list_for_each_entry(i, &comm_list->cg_children, ci_entry) { |
786 | cm = to_comm(i); | 778 | cm = to_comm(i); |
@@ -800,7 +792,7 @@ static struct comm *get_comm(int nodeid, struct sockaddr_storage *addr) | |||
800 | break; | 792 | break; |
801 | } | 793 | } |
802 | } | 794 | } |
803 | up(&clusters_root.subsys.su_sem); | 795 | mutex_unlock(&clusters_root.subsys.su_mutex); |
804 | 796 | ||
805 | if (!found) | 797 | if (!found) |
806 | cm = NULL; | 798 | cm = NULL; |
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 0553a6158d..dd362739d2 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c | |||
@@ -1449,7 +1449,7 @@ int dlm_lowcomms_start(void) | |||
1449 | error = -ENOMEM; | 1449 | error = -ENOMEM; |
1450 | con_cache = kmem_cache_create("dlm_conn", sizeof(struct connection), | 1450 | con_cache = kmem_cache_create("dlm_conn", sizeof(struct connection), |
1451 | __alignof__(struct connection), 0, | 1451 | __alignof__(struct connection), 0, |
1452 | NULL, NULL); | 1452 | NULL); |
1453 | if (!con_cache) | 1453 | if (!con_cache) |
1454 | goto out; | 1454 | goto out; |
1455 | 1455 | ||
diff --git a/fs/dlm/memory.c b/fs/dlm/memory.c index f858fef6e4..ecf0e5cb20 100644 --- a/fs/dlm/memory.c +++ b/fs/dlm/memory.c | |||
@@ -23,7 +23,7 @@ int dlm_memory_init(void) | |||
23 | int ret = 0; | 23 | int ret = 0; |
24 | 24 | ||
25 | lkb_cache = kmem_cache_create("dlm_lkb", sizeof(struct dlm_lkb), | 25 | lkb_cache = kmem_cache_create("dlm_lkb", sizeof(struct dlm_lkb), |
26 | __alignof__(struct dlm_lkb), 0, NULL, NULL); | 26 | __alignof__(struct dlm_lkb), 0, NULL); |
27 | if (!lkb_cache) | 27 | if (!lkb_cache) |
28 | ret = -ENOMEM; | 28 | ret = -ENOMEM; |
29 | return ret; | 29 | return ret; |
@@ -39,9 +39,7 @@ char *allocate_lvb(struct dlm_ls *ls) | |||
39 | { | 39 | { |
40 | char *p; | 40 | char *p; |
41 | 41 | ||
42 | p = kmalloc(ls->ls_lvblen, GFP_KERNEL); | 42 | p = kzalloc(ls->ls_lvblen, GFP_KERNEL); |
43 | if (p) | ||
44 | memset(p, 0, ls->ls_lvblen); | ||
45 | return p; | 43 | return p; |
46 | } | 44 | } |
47 | 45 | ||
@@ -59,9 +57,7 @@ struct dlm_rsb *allocate_rsb(struct dlm_ls *ls, int namelen) | |||
59 | 57 | ||
60 | DLM_ASSERT(namelen <= DLM_RESNAME_MAXLEN,); | 58 | DLM_ASSERT(namelen <= DLM_RESNAME_MAXLEN,); |
61 | 59 | ||
62 | r = kmalloc(sizeof(*r) + namelen, GFP_KERNEL); | 60 | r = kzalloc(sizeof(*r) + namelen, GFP_KERNEL); |
63 | if (r) | ||
64 | memset(r, 0, sizeof(*r) + namelen); | ||
65 | return r; | 61 | return r; |
66 | } | 62 | } |
67 | 63 | ||
@@ -101,9 +97,7 @@ struct dlm_direntry *allocate_direntry(struct dlm_ls *ls, int namelen) | |||
101 | DLM_ASSERT(namelen <= DLM_RESNAME_MAXLEN, | 97 | DLM_ASSERT(namelen <= DLM_RESNAME_MAXLEN, |
102 | printk("namelen = %d\n", namelen);); | 98 | printk("namelen = %d\n", namelen);); |
103 | 99 | ||
104 | de = kmalloc(sizeof(*de) + namelen, GFP_KERNEL); | 100 | de = kzalloc(sizeof(*de) + namelen, GFP_KERNEL); |
105 | if (de) | ||
106 | memset(de, 0, sizeof(*de) + namelen); | ||
107 | return de; | 101 | return de; |
108 | } | 102 | } |
109 | 103 | ||