diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-01-25 16:17:09 -0500 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-01-25 16:17:09 -0500 |
commit | 46f26c362d5109459f04f99e93fc0413d88516c8 (patch) | |
tree | 85587fec4a44c7bd6bdef3244edc8237821ab7c6 /drivers/ide/ide-io.c | |
parent | d3bb03438c58b2a00f07a59175d4156a9952d825 (diff) |
ide: fix registers loading order for WIN_SMART in execute_drive_cmd()
Fix registers loading order for REQ_TYPE_ATA_CMD request with WIN_SMART
command in execute_drive_cmd() (load IDE_FEATURE_REG and IDE_SECTOR_REG
before loading IDE_LCYL_REG and IDE_HCYL_REG).
It shouldn't affect anything (just a usual paranoia to separate changes
which change the way in which hardware is accessed from code cleanups).
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-io.c')
-rw-r--r-- | drivers/ide/ide-io.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index 4ea8419fee..c616c9fb48 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c | |||
@@ -932,10 +932,10 @@ static ide_startstop_t execute_drive_cmd (ide_drive_t *drive, | |||
932 | printk("xx=0x%02x\n", args[3]); | 932 | printk("xx=0x%02x\n", args[3]); |
933 | #endif | 933 | #endif |
934 | if (args[0] == WIN_SMART) { | 934 | if (args[0] == WIN_SMART) { |
935 | hwif->OUTB(0x4f, IDE_LCYL_REG); | ||
936 | hwif->OUTB(0xc2, IDE_HCYL_REG); | ||
937 | hwif->OUTB(args[2],IDE_FEATURE_REG); | 935 | hwif->OUTB(args[2],IDE_FEATURE_REG); |
938 | hwif->OUTB(args[1],IDE_SECTOR_REG); | 936 | hwif->OUTB(args[1],IDE_SECTOR_REG); |
937 | hwif->OUTB(0x4f, IDE_LCYL_REG); | ||
938 | hwif->OUTB(0xc2, IDE_HCYL_REG); | ||
939 | ide_cmd(drive, args[0], args[3], &drive_cmd_intr); | 939 | ide_cmd(drive, args[0], args[3], &drive_cmd_intr); |
940 | return ide_started; | 940 | return ide_started; |
941 | } | 941 | } |