diff options
| author | Christoph Hellwig <hch@lst.de> | 2007-10-17 02:26:13 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:42:47 -0400 |
| commit | 04fc8bbcf5eb25fa2aec290b302a9878dde20168 (patch) | |
| tree | 4c650a7d30d921e519f51b74f1dc591cf93e7b0b | |
| parent | 4029a9177fb4a3410211d091505a7f8d03a7b15d (diff) | |
kill DECLARE_MUTEX_LOCKED
DECLARE_MUTEX_LOCKED was used for semaphores used as completions and we've
got rid of them. Well, except for one in libusual that the maintainer
explicitly wants to keep as semaphore. So convert that useage to an
explicit sema_init and kill of DECLARE_MUTEX_LOCKED so that new code is
reminded to use a completion.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: "Satyam Sharma" <satyam.sharma@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/usb/storage/libusual.c | 4 | ||||
| -rw-r--r-- | include/asm-alpha/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-arm/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-avr32/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-blackfin/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-cris/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-frv/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-h8300/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-ia64/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-m32r/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-m68k/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-m68knommu/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-mips/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-parisc/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-powerpc/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-s390/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-sh/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-sh64/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-sparc/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-sparc64/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-v850/semaphore.h | 1 | ||||
| -rw-r--r-- | include/asm-x86/semaphore_32.h | 1 | ||||
| -rw-r--r-- | include/asm-x86/semaphore_64.h | 1 | ||||
| -rw-r--r-- | include/asm-xtensa/semaphore.h | 1 |
24 files changed, 3 insertions, 24 deletions
diff --git a/drivers/usb/storage/libusual.c b/drivers/usb/storage/libusual.c index 06d1107dbd..55b952084f 100644 --- a/drivers/usb/storage/libusual.c +++ b/drivers/usb/storage/libusual.c | |||
| @@ -30,7 +30,7 @@ static atomic_t usu_bias = ATOMIC_INIT(USB_US_DEFAULT_BIAS); | |||
| 30 | #define BIAS_NAME_SIZE (sizeof("usb-storage")) | 30 | #define BIAS_NAME_SIZE (sizeof("usb-storage")) |
| 31 | static const char *bias_names[3] = { "none", "usb-storage", "ub" }; | 31 | static const char *bias_names[3] = { "none", "usb-storage", "ub" }; |
| 32 | 32 | ||
| 33 | static DECLARE_MUTEX_LOCKED(usu_init_notify); | 33 | static struct semaphore usu_init_notify; |
| 34 | static DECLARE_COMPLETION(usu_end_notify); | 34 | static DECLARE_COMPLETION(usu_end_notify); |
| 35 | static atomic_t total_threads = ATOMIC_INIT(0); | 35 | static atomic_t total_threads = ATOMIC_INIT(0); |
| 36 | 36 | ||
| @@ -204,6 +204,8 @@ static int __init usb_usual_init(void) | |||
| 204 | { | 204 | { |
| 205 | int rc; | 205 | int rc; |
| 206 | 206 | ||
| 207 | sema_init(&usu_init_notify, 0); | ||
| 208 | |||
| 207 | rc = usb_register(&usu_driver); | 209 | rc = usb_register(&usu_driver); |
| 208 | up(&usu_init_notify); | 210 | up(&usu_init_notify); |
| 209 | return rc; | 211 | return rc; |
diff --git a/include/asm-alpha/semaphore.h b/include/asm-alpha/semaphore.h index 1a6295f2c2..f1e9278a9f 100644 --- a/include/asm-alpha/semaphore.h +++ b/include/asm-alpha/semaphore.h | |||
| @@ -30,7 +30,6 @@ struct semaphore { | |||
| 30 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) | 30 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) |
| 31 | 31 | ||
| 32 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 32 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 33 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 34 | 33 | ||
| 35 | static inline void sema_init(struct semaphore *sem, int val) | 34 | static inline void sema_init(struct semaphore *sem, int val) |
| 36 | { | 35 | { |
diff --git a/include/asm-arm/semaphore.h b/include/asm-arm/semaphore.h index d5dc624f45..1c8b441f89 100644 --- a/include/asm-arm/semaphore.h +++ b/include/asm-arm/semaphore.h | |||
| @@ -28,7 +28,6 @@ struct semaphore { | |||
| 28 | struct semaphore name = __SEMAPHORE_INIT(name,count) | 28 | struct semaphore name = __SEMAPHORE_INIT(name,count) |
| 29 | 29 | ||
| 30 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 30 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 31 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 32 | 31 | ||
| 33 | static inline void sema_init(struct semaphore *sem, int val) | 32 | static inline void sema_init(struct semaphore *sem, int val) |
| 34 | { | 33 | { |
diff --git a/include/asm-avr32/semaphore.h b/include/asm-avr32/semaphore.h index ef99ddccc1..feaf1d4533 100644 --- a/include/asm-avr32/semaphore.h +++ b/include/asm-avr32/semaphore.h | |||
| @@ -36,7 +36,6 @@ struct semaphore { | |||
| 36 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) | 36 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) |
| 37 | 37 | ||
| 38 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 38 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 39 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 40 | 39 | ||
| 41 | static inline void sema_init (struct semaphore *sem, int val) | 40 | static inline void sema_init (struct semaphore *sem, int val) |
| 42 | { | 41 | { |
diff --git a/include/asm-blackfin/semaphore.h b/include/asm-blackfin/semaphore.h index 94c04d7ab2..533f90fb2e 100644 --- a/include/asm-blackfin/semaphore.h +++ b/include/asm-blackfin/semaphore.h | |||
| @@ -35,7 +35,6 @@ struct semaphore { | |||
| 35 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) | 35 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) |
| 36 | 36 | ||
| 37 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 37 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 38 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 39 | 38 | ||
| 40 | static inline void sema_init(struct semaphore *sem, int val) | 39 | static inline void sema_init(struct semaphore *sem, int val) |
| 41 | { | 40 | { |
diff --git a/include/asm-cris/semaphore.h b/include/asm-cris/semaphore.h index 53f548b791..31a4ac4481 100644 --- a/include/asm-cris/semaphore.h +++ b/include/asm-cris/semaphore.h | |||
| @@ -35,7 +35,6 @@ struct semaphore { | |||
| 35 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) | 35 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) |
| 36 | 36 | ||
| 37 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 37 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 38 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 39 | 38 | ||
| 40 | static inline void sema_init(struct semaphore *sem, int val) | 39 | static inline void sema_init(struct semaphore *sem, int val) |
| 41 | { | 40 | { |
diff --git a/include/asm-frv/semaphore.h b/include/asm-frv/semaphore.h index 09586528e0..d7aaa1911a 100644 --- a/include/asm-frv/semaphore.h +++ b/include/asm-frv/semaphore.h | |||
| @@ -49,7 +49,6 @@ struct semaphore { | |||
| 49 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) | 49 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) |
| 50 | 50 | ||
| 51 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 51 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 52 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 53 | 52 | ||
| 54 | static inline void sema_init (struct semaphore *sem, int val) | 53 | static inline void sema_init (struct semaphore *sem, int val) |
| 55 | { | 54 | { |
diff --git a/include/asm-h8300/semaphore.h b/include/asm-h8300/semaphore.h index 81bae2a991..f3ffff83ff 100644 --- a/include/asm-h8300/semaphore.h +++ b/include/asm-h8300/semaphore.h | |||
| @@ -39,7 +39,6 @@ struct semaphore { | |||
| 39 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) | 39 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) |
| 40 | 40 | ||
| 41 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 41 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 42 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 43 | 42 | ||
| 44 | static inline void sema_init (struct semaphore *sem, int val) | 43 | static inline void sema_init (struct semaphore *sem, int val) |
| 45 | { | 44 | { |
diff --git a/include/asm-ia64/semaphore.h b/include/asm-ia64/semaphore.h index f483eeb95d..d8393d1128 100644 --- a/include/asm-ia64/semaphore.h +++ b/include/asm-ia64/semaphore.h | |||
| @@ -28,7 +28,6 @@ struct semaphore { | |||
| 28 | struct semaphore name = __SEMAPHORE_INITIALIZER(name, count) | 28 | struct semaphore name = __SEMAPHORE_INITIALIZER(name, count) |
| 29 | 29 | ||
| 30 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name, 1) | 30 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name, 1) |
| 31 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name, 0) | ||
| 32 | 31 | ||
| 33 | static inline void | 32 | static inline void |
| 34 | sema_init (struct semaphore *sem, int val) | 33 | sema_init (struct semaphore *sem, int val) |
diff --git a/include/asm-m32r/semaphore.h b/include/asm-m32r/semaphore.h index 41e45d7b87..b5bf95a6f2 100644 --- a/include/asm-m32r/semaphore.h +++ b/include/asm-m32r/semaphore.h | |||
| @@ -35,7 +35,6 @@ struct semaphore { | |||
| 35 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) | 35 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) |
| 36 | 36 | ||
| 37 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 37 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 38 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 39 | 38 | ||
| 40 | static inline void sema_init (struct semaphore *sem, int val) | 39 | static inline void sema_init (struct semaphore *sem, int val) |
| 41 | { | 40 | { |
diff --git a/include/asm-m68k/semaphore.h b/include/asm-m68k/semaphore.h index fd4c7cc3d3..64d6b119bb 100644 --- a/include/asm-m68k/semaphore.h +++ b/include/asm-m68k/semaphore.h | |||
| @@ -40,7 +40,6 @@ struct semaphore { | |||
| 40 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) | 40 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) |
| 41 | 41 | ||
| 42 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 42 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 43 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 44 | 43 | ||
| 45 | static inline void sema_init(struct semaphore *sem, int val) | 44 | static inline void sema_init(struct semaphore *sem, int val) |
| 46 | { | 45 | { |
diff --git a/include/asm-m68knommu/semaphore.h b/include/asm-m68knommu/semaphore.h index 5cc1fdd86f..5779eb6c06 100644 --- a/include/asm-m68knommu/semaphore.h +++ b/include/asm-m68knommu/semaphore.h | |||
| @@ -39,7 +39,6 @@ struct semaphore { | |||
| 39 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) | 39 | struct semaphore name = __SEMAPHORE_INITIALIZER(name,count) |
| 40 | 40 | ||
| 41 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) | 41 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name,1) |
| 42 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name,0) | ||
| 43 | 42 | ||
| 44 | static inline void sema_init (struct semaphore *sem, int val) | 43 | static inline void sema_init (struct semaphore *sem, int val) |
| 45 | { | 44 | { |
diff --git a/include/asm-mips/semaphore.h b/include/asm-mips/semaphore.h index 080daa77f8..fdf8042b78 100644 --- a/include/asm-mips/semaphore.h +++ b/include/asm-mips/semaphore.h | |||
| @@ -49,7 +49,6 @@ struct semaphore { | |||
| 49 | struct semaphore name = __SEMAPHORE_INITIALIZER(name, count) | 49 | struct semaphore name = __SEMAPHORE_INITIALIZER(name, count) |
| 50 | 50 | ||
| 51 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name, 1) | 51 | #define DECLARE_MUTEX(name) __DECLARE_SEMAPHORE_GENERIC(name, 1) |
| 52 | #define DECLARE_MUTEX_LOCKED(name) __DECLARE_SEMAPHORE_GENERIC(name, 0) | ||
| 53 | 52 | ||
| 54 | |||
