5 files changed, 160 insertions, 14 deletions

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 46dd4c2a41ce..dad64926170f 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -162,6 +162,8 @@ void perf_evsel__init(struct perf_evsel *evsel,
         evsel->idx         = idx;
         evsel->attr        = *attr;
         evsel->leader      = evsel;
+        evsel->unit        = "";
+        evsel->scale       = 1.0;
         INIT_LIST_HEAD(&evsel->node);
         hists__init(&evsel->hists);
         evsel->sample_size = __perf_evsel__sample_size(attr->sample_type);
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index 1ea7c92e6e33..8120eeb86ac1 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -68,6 +68,8 @@ struct perf_evsel {
         u32                     ids;
         struct hists            hists;
         char                    *name;
+        double                  scale;
+        const char              *unit;
         struct event_format     *tp_format;
         union {
                 void            *priv;
@@ -138,6 +140,7 @@ extern const char *perf_evsel__sw_names[PERF_COUNT_SW_MAX];
 int __perf_evsel__hw_cache_type_op_res_name(u8 type, u8 op, u8 result,
                                             char *bf, size_t size);
 const char *perf_evsel__name(struct perf_evsel *evsel);
+
 const char *perf_evsel__group_name(struct perf_evsel *evsel);
 int perf_evsel__group_desc(struct perf_evsel *evsel, char *buf, size_t size);
 
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 6de6f89c2a61..969cb8f0d88d 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -269,9 +269,10 @@ const char *event_type(int type)
 
 
 
-static int __add_event(struct list_head *list, int *idx,
-                       struct perf_event_attr *attr,
-                       char *name, struct cpu_map *cpus)
+static struct perf_evsel *
+__add_event(struct list_head *list, int *idx,
+            struct perf_event_attr *attr,
+            char *name, struct cpu_map *cpus)
 {
         struct perf_evsel *evsel;
 
@@ -279,19 +280,19 @@ static int __add_event(struct list_head *list, int *idx,
 
         evsel = perf_evsel__new_idx(attr, (*idx)++);
         if (!evsel)
-                return -ENOMEM;
+                return NULL;
 
         evsel->cpus = cpus;
         if (name)
                 evsel->name = strdup(name);
         list_add_tail(&evsel->node, list);
-        return 0;
+        return evsel;
 }
 
 static int add_event(struct list_head *list, int *idx,
                      struct perf_event_attr *attr, char *name)
 {
-        return __add_event(list, idx, attr, name, NULL);
+        return __add_event(list, idx, attr, name, NULL) ? 0 : -ENOMEM;
 }
 
 static int parse_aliases(char *str, const char *names[][PERF_EVSEL__MAX_ALIASES], int size)
@@ -633,6 +634,9 @@ int parse_events_add_pmu(struct list_head *list, int *idx,
 {
         struct perf_event_attr attr;
         struct perf_pmu *pmu;
+        struct perf_evsel *evsel;
+        char *unit;
+        double scale;
 
         pmu = perf_pmu__find(name);
         if (!pmu)
@@ -640,7 +644,7 @@ int parse_events_add_pmu(struct list_head *list, int *idx,
 
         memset(&attr, 0, sizeof(attr));
 
-        if (perf_pmu__check_alias(pmu, head_config))
+        if (perf_pmu__check_alias(pmu, head_config, &unit, &scale))
                 return -EINVAL;
 
         /*
@@ -652,8 +656,14 @@ int parse_events_add_pmu(struct list_head *list, int *idx,
         if (perf_pmu__config(pmu, &attr, head_config))
                 return -EINVAL;
 
-        return __add_event(list, idx, &attr, pmu_event_name(head_config),
-                           pmu->cpus);
+        evsel = __add_event(list, idx, &attr, pmu_event_name(head_config),
+                            pmu->cpus);
+        if (evsel) {
+                evsel->unit = unit;
+                evsel->scale = scale;
+        }
+
+        return evsel ? 0 : -ENOMEM;
 }
 
 int parse_events__modifier_group(struct list_head *list,
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index c232d8dd410b..56fc10a5e288 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -1,19 +1,23 @@
 #include <linux/list.h>
 #include <sys/types.h>
-#include <sys/stat.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <dirent.h>
 #include "fs.h"
+#include <locale.h>
 #include "util.h"
 #include "pmu.h"
 #include "parse-events.h"
 #include "cpumap.h"
 
+#define UNIT_MAX_LEN    31 /* max length for event unit name */
+
 struct perf_pmu_alias {
         char *name;
         struct list_head terms;
         struct list_head list;
+        char unit[UNIT_MAX_LEN+1];
+        double scale;
 };
 
 struct perf_pmu_format {
@@ -94,7 +98,80 @@ static int pmu_format(const char *name, struct list_head *format)
         return 0;
 }
 
-static int perf_pmu__new_alias(struct list_head *list, char *name, FILE *file)
+static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char *name)
+{
+        struct stat st;
+        ssize_t sret;
+        char scale[128];
+        int fd, ret = -1;
+        char path[PATH_MAX];
+        char *lc;
+
+        snprintf(path, PATH_MAX, "%s/%s.scale", dir, name);
+
+        fd = open(path, O_RDONLY);
+        if (fd == -1)
+                return -1;
+
+        if (fstat(fd, &st) < 0)
+                goto error;
+
+        sret = read(fd, scale, sizeof(scale)-1);
+        if (sret < 0)
+                goto error;
+
+        scale[sret] = '\0';
+        /*
+         * save current locale
+         */
+        lc = setlocale(LC_NUMERIC, NULL);
+
+        /*
+         * force to C locale to ensure kernel
+         * scale string is converted correctly.
+         * kernel uses default C locale.
+         */
+        setlocale(LC_NUMERIC, "C");
+
+        alias->scale = strtod(scale, NULL);
+
+        /* restore locale */
+        setlocale(LC_NUMERIC, lc);
+
+        ret = 0;
+error:
+        close(fd);
+        return ret;
+}
+
+static int perf_pmu__parse_unit(struct perf_pmu_alias *alias, char *dir, char *name)
+{
+        char path[PATH_MAX];
+        ssize_t sret;
+        int fd;
+
+        snprintf(path, PATH_MAX, "%s/%s.unit", dir, name);
+
+        fd = open(path, O_RDONLY);
+        if (fd == -1)
+                return -1;
+
+                sret = read(fd, alias->unit, UNIT_MAX_LEN);
+        if (sret < 0)
+                goto error;
+
+        close(fd);
+
+        alias->unit[sret] = '\0';
+
+        return 0;
+error:
+        close(fd);
+        alias->unit[0] = '\0';
+        return -1;
+}
+
+static int perf_pmu__new_alias(struct list_head *list, char *dir, char *name, FILE *file)
 {
         struct perf_pmu_alias *alias;
         char buf[256];
@@ -110,6 +187,9 @@ static int perf_pmu__new_alias(struct list_head *list, char *name, FILE *file)
                 return -ENOMEM;
 
         INIT_LIST_HEAD(&alias->terms);
+        alias->scale = 1.0;
+        alias->unit[0] = '\0';
+
         ret = parse_events_terms(&alias->terms, buf);
         if (ret) {
                 free(alias);
@@ -117,7 +197,14 @@ static int perf_pmu__new_alias(struct list_head *list, char *name, FILE *file)
         }
 
         alias->name = strdup(name);
+        /*
+         * load unit name and scale if available
+         */
+        perf_pmu__parse_unit(alias, dir, name);
+        perf_pmu__parse_scale(alias, dir, name);
+
         list_add_tail(&alias->list, list);
+
         return 0;
 }
 
@@ -129,6 +216,7 @@ static int pmu_aliases_parse(char *dir, struct list_head *head)
 {
         struct dirent *evt_ent;
         DIR *event_dir;
+        size_t len;
         int ret = 0;
 
         event_dir = opendir(dir);
@@ -143,13 +231,24 @@ static int pmu_aliases_parse(char *dir, struct list_head *head)
                 if (!strcmp(name, ".") || !strcmp(name, ".."))
                         continue;
 
+                /*
+                 * skip .unit and .scale info files
+                 * parsed in perf_pmu__new_alias()
+                 */
+                len = strlen(name);
+                if (len > 5 && !strcmp(name + len - 5, ".unit"))
+                        continue;
+                if (len > 6 && !strcmp(name + len - 6, ".scale"))
+                        continue;
+
                 snprintf(path, PATH_MAX, "%s/%s", dir, name);
 
                 ret = -EINVAL;
                 file = fopen(path, "r");
                 if (!file)
                         break;
-                ret = perf_pmu__new_alias(head, name, file);
+
+                ret = perf_pmu__new_alias(head, dir, name, file);
                 fclose(file);
         }
 
@@ -508,16 +607,42 @@ static struct perf_pmu_alias *pmu_find_alias(struct perf_pmu *pmu,
         return NULL;
 }
 
+
+static int check_unit_scale(struct perf_pmu_alias *alias,
+                            char **unit, double *scale)
+{
+        /*
+         * Only one term in event definition can
+         * define unit and scale, fail if there's
+         * more than one.
+         */
+        if ((*unit && alias->unit) ||
+            (*scale && alias->scale))
+                return -EINVAL;
+
+        if (alias->unit)
+                *unit = alias->unit;
+
+        if (alias->scale)
+                *scale = alias->scale;
+
+        return 0;
+}
+
 /*
  * Find alias in the terms list and replace it with the terms
  * defined for the alias
  */
-int perf_pmu__check_alias(struct perf_pmu *pmu, struct list_head *head_terms)
+int perf_pmu__check_alias(struct perf_pmu *pmu, struct list_head *head_terms,
+                          char **unit, double *scale)
 {
         struct parse_events_term *term, *h;
         struct perf_pmu_alias *alias;
         int ret;
 
+        *unit   = NULL;
+        *scale  = 0;
+
         list_for_each_entry_safe(term, h, head_terms, list) {
                 alias = pmu_find_alias(pmu, term);
                 if (!alias)
@@ -525,6 +650,11 @@ int perf_pmu__check_alias(struct perf_pmu *pmu, struct list_head *head_terms)
                 ret = pmu_alias_terms(alias, &term->list);
                 if (ret)
                         return ret;
+
+                ret = check_unit_scale(alias, unit, scale);
+                if (ret)
+                        return ret;
+
                 list_del(&term->list);
                 free(term);
         }
diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
index 1179b26f244a..9183380e2038 100644
--- a/tools/perf/util/pmu.h
+++ b/tools/perf/util/pmu.h
@@ -28,7 +28,8 @@ int perf_pmu__config(struct perf_pmu *pmu, struct perf_event_attr *attr,
 int perf_pmu__config_terms(struct list_head *formats,
                            struct perf_event_attr *attr,
                            struct list_head *head_terms);
-int perf_pmu__check_alias(struct perf_pmu *pmu, struct list_head *head_terms);
+int perf_pmu__check_alias(struct perf_pmu *pmu, struct list_head *head_terms,
+                          char **unit, double *scale);
 struct list_head *perf_pmu__alias(struct perf_pmu *pmu,
                                   struct list_head *head_terms);
 int perf_pmu_wrap(void);