6 files changed, 23 insertions, 15 deletions

diff --git a/sound/usb/caiaq/input.c b/sound/usb/caiaq/input.c
index 4432ef7a70a9..a213813487bd 100644
--- a/sound/usb/caiaq/input.c
+++ b/sound/usb/caiaq/input.c
@@ -30,7 +30,7 @@ static unsigned short keycode_ak1[] =  { KEY_C, KEY_B, KEY_A };
 static unsigned short keycode_rk2[] =  { KEY_1, KEY_2, KEY_3, KEY_4,
                                          KEY_5, KEY_6, KEY_7 };
 static unsigned short keycode_rk3[] =  { KEY_1, KEY_2, KEY_3, KEY_4,
-                                         KEY_5, KEY_6, KEY_7, KEY_5, KEY_6 };
+                                         KEY_5, KEY_6, KEY_7, KEY_8, KEY_9 };
 
 static unsigned short keycode_kore[] = {
         KEY_FN_F1,      /* "menu"               */
diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
index 7c0d21ecd821..7d46e482375d 100644
--- a/sound/usb/endpoint.c
+++ b/sound/usb/endpoint.c
@@ -352,7 +352,7 @@ int snd_usb_parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no)
                         continue;
                 }
                 if (((protocol == UAC_VERSION_1) && (fmt->bLength < 8)) ||
-                    ((protocol == UAC_VERSION_2) && (fmt->bLength != 6))) {
+                    ((protocol == UAC_VERSION_2) && (fmt->bLength < 6))) {
                         snd_printk(KERN_ERR "%d:%u:%d : invalid UAC_FORMAT_TYPE desc\n",
                                    dev->devnum, iface_no, altno);
                         continue;
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index c22fa76e363a..c04d7c71ac88 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -1191,6 +1191,11 @@ static int parse_audio_feature_unit(struct mixer_build *state, int unitid, void
 
         if (state->mixer->protocol == UAC_VERSION_1) {
                 csize = hdr->bControlSize;
+                if (!csize) {
+                        snd_printdd(KERN_ERR "usbaudio: unit %u: "
+                                    "invalid bControlSize == 0\n", unitid);
+                        return -EINVAL;
+                }
                 channels = (hdr->bLength - 7) / csize - 1;
                 bmaControls = hdr->bmaControls;
         } else {
@@ -1934,15 +1939,13 @@ static int snd_usb_mixer_controls(struct usb_mixer_interface *mixer)
         struct mixer_build state;
         int err;
         const struct usbmix_ctl_map *map;
-        struct usb_host_interface *hostif;
         void *p;
 
-        hostif = mixer->chip->ctrl_intf;
         memset(&state, 0, sizeof(state));
         state.chip = mixer->chip;
         state.mixer = mixer;
-        state.buffer = hostif->extra;
-        state.buflen = hostif->extralen;
+        state.buffer = mixer->hostif->extra;
+        state.buflen = mixer->hostif->extralen;
 
         /* check the mapping table */
         for (map = usbmix_ctl_maps; map->id; map++) {
@@ -1955,7 +1958,8 @@ static int snd_usb_mixer_controls(struct usb_mixer_interface *mixer)
         }
 
         p = NULL;
-        while ((p = snd_usb_find_csint_desc(hostif->extra, hostif->extralen, p, UAC_OUTPUT_TERMINAL)) != NULL) {
+        while ((p = snd_usb_find_csint_desc(mixer->hostif->extra, mixer->hostif->extralen,
+                                            p, UAC_OUTPUT_TERMINAL)) != NULL) {
                 if (mixer->protocol == UAC_VERSION_1) {
                         struct uac1_output_terminal_descriptor *desc = p;
 
@@ -2162,17 +2166,15 @@ int snd_usb_mixer_activate(struct usb_mixer_interface *mixer)
 /* create the handler for the optional status interrupt endpoint */
 static int snd_usb_mixer_status_create(struct usb_mixer_interface *mixer)
 {
-        struct usb_host_interface *hostif;
         struct usb_endpoint_descriptor *ep;
         void *transfer_buffer;
         int buffer_length;
         unsigned int epnum;
 
-        hostif = mixer->chip->ctrl_intf;
         /* we need one interrupt input endpoint */
-        if (get_iface_desc(hostif)->bNumEndpoints < 1)
+        if (get_iface_desc(mixer->hostif)->bNumEndpoints < 1)
                 return 0;
-        ep = get_endpoint(hostif, 0);
+        ep = get_endpoint(mixer->hostif, 0);
         if (!usb_endpoint_dir_in(ep) || !usb_endpoint_xfer_int(ep))
                 return 0;
 
@@ -2202,7 +2204,6 @@ int snd_usb_create_mixer(struct snd_usb_audio *chip, int ctrlif,
         };
         struct usb_mixer_interface *mixer;
         struct snd_info_entry *entry;
-        struct usb_host_interface *host_iface;
         int err;
 
         strcpy(chip->card->mixername, "USB Mixer");
@@ -2219,8 +2220,8 @@ int snd_usb_create_mixer(struct snd_usb_audio *chip, int ctrlif,
                 return -ENOMEM;
         }
 
-        host_iface = &usb_ifnum_to_if(chip->dev, ctrlif)->altsetting[0];
-        switch (get_iface_desc(host_iface)->bInterfaceProtocol) {
+        mixer->hostif = &usb_ifnum_to_if(chip->dev, ctrlif)->altsetting[0];
+        switch (get_iface_desc(mixer->hostif)->bInterfaceProtocol) {
         case UAC_VERSION_1:
         default:
                 mixer->protocol = UAC_VERSION_1;
diff --git a/sound/usb/mixer.h b/sound/usb/mixer.h
index ae1a14dcfe82..81b2d8a32fb0 100644
--- a/sound/usb/mixer.h
+++ b/sound/usb/mixer.h
@@ -3,6 +3,7 @@
 
 struct usb_mixer_interface {
         struct snd_usb_audio *chip;
+        struct usb_host_interface *hostif;
         struct list_head list;
         unsigned int ignore_ctl_error;
         struct urb *urb;
diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index dba0b7f11c54..4d4f86552a23 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -2417,6 +2417,12 @@ YAMAHA_DEVICE(0x7010, "UB99"),
         .idProduct = 0x1020,
 },
 
+/* KeithMcMillen Stringport */
+{
+        USB_DEVICE(0x1f38, 0x0001),
+        .bInterfaceClass = USB_CLASS_AUDIO,
+},
+
 /* Miditech devices */
 {
         USB_DEVICE(0x4752, 0x0011),
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 77762c99afbe..81e07d842581 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -426,7 +426,7 @@ static int snd_usb_cm106_boot_quirk(struct usb_device *dev)
  */
 static int snd_usb_cm6206_boot_quirk(struct usb_device *dev)
 {
-        int err, reg;
+        int err  = 0, reg;
         int val[] = {0x2004, 0x3000, 0xf800, 0x143f, 0x0000, 0x3000};
 
         for (reg = 0; reg < ARRAY_SIZE(val); reg++) {