1 files changed, 111 insertions, 90 deletions

diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
index 302f69a8ac22..3b269fa226bd 100644
--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -91,8 +91,6 @@ static int wm8994_retune_mobile_base[] = {
         WM8994_AIF2_EQ_GAINS_1,
 };
 
-static void wm8958_default_micdet(u16 status, void *data);
-
 static const struct wm8958_micd_rate micdet_rates[] = {
         { 32768,       true,  1, 4 },
         { 32768,       false, 1, 1 },
@@ -116,9 +114,6 @@ static void wm8958_micd_set_rate(struct snd_soc_codec *codec)
         const struct wm8958_micd_rate *rates;
         int num_rates;
 
-        if (wm8994->jack_cb != wm8958_default_micdet)
-                return;
-
         idle = !wm8994->jack_mic;
 
         sysclk = snd_soc_read(codec, WM8994_CLOCKING_1);
@@ -740,7 +735,7 @@ static void wm1811_jackdet_set_mode(struct snd_soc_codec *codec, u16 mode)
 {
         struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
 
-        if (!wm8994->jackdet || !wm8994->jack_cb)
+        if (!wm8994->jackdet || !wm8994->micdet[0].jack)
                 return;
 
         if (wm8994->active_refcount)
@@ -3405,38 +3400,80 @@ static irqreturn_t wm8994_mic_irq(int irq, void *data)
         return IRQ_HANDLED;
 }
 
-/* Default microphone detection handler for WM8958 - the user can
- * override this if they wish.
- */
-static void wm8958_default_micdet(u16 status, void *data)
+static void wm1811_micd_stop(struct snd_soc_codec *codec)
+{
+        struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
+
+        if (!wm8994->jackdet)
+                return;
+
+        mutex_lock(&wm8994->accdet_lock);
+
+        snd_soc_update_bits(codec, WM8958_MIC_DETECT_1, WM8958_MICD_ENA, 0);
+
+        wm1811_jackdet_set_mode(codec, WM1811_JACKDET_MODE_JACK);
+
+        mutex_unlock(&wm8994->accdet_lock);
+
+        if (wm8994->wm8994->pdata.jd_ext_cap)
+                snd_soc_dapm_disable_pin(&codec->dapm,
+                                         "MICBIAS2");
+}
+
+static void wm8958_button_det(struct snd_soc_codec *codec, u16 status)
 {
-        struct snd_soc_codec *codec = data;
         struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
         int report;
 
-        dev_dbg(codec->dev, "MICDET %x\n", status);
+        report = 0;
+        if (status & 0x4)
+                report |= SND_JACK_BTN_0;
+
+        if (status & 0x8)
+                report |= SND_JACK_BTN_1;
+
+        if (status & 0x10)
+                report |= SND_JACK_BTN_2;
+
+        if (status & 0x20)
+                report |= SND_JACK_BTN_3;
+
+        if (status & 0x40)
+                report |= SND_JACK_BTN_4;
+
+        if (status & 0x80)
+                report |= SND_JACK_BTN_5;
+
+        snd_soc_jack_report(wm8994->micdet[0].jack, report,
+                            wm8994->btn_mask);
+}
+
+static void wm8958_mic_id(void *data, u16 status)
+{
+        struct snd_soc_codec *codec = data;
+        struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
 
         /* Either nothing present or just starting detection */
         if (!(status & WM8958_MICD_STS)) {
-                if (!wm8994->jackdet) {
-                        /* If nothing present then clear our statuses */
-                        dev_dbg(codec->dev, "Detected open circuit\n");
-                        wm8994->jack_mic = false;
-                        wm8994->mic_detecting = true;
+                /* If nothing present then clear our statuses */
+                dev_dbg(codec->dev, "Detected open circuit\n");
+                wm8994->jack_mic = false;
+                wm8994->mic_detecting = true;
 
-                        wm8958_micd_set_rate(codec);
+                wm1811_micd_stop(codec);
 
-                        snd_soc_jack_report(wm8994->micdet[0].jack, 0,
-                                            wm8994->btn_mask |
-                                            SND_JACK_HEADSET);
-                }
+                wm8958_micd_set_rate(codec);
+
+                snd_soc_jack_report(wm8994->micdet[0].jack, 0,
+                                    wm8994->btn_mask |
+                                    SND_JACK_HEADSET);
                 return;
         }
 
         /* If the measurement is showing a high impedence we've got a
          * microphone.
          */
-        if (wm8994->mic_detecting && (status & 0x600)) {
+        if (status & 0x600) {
                 dev_dbg(codec->dev, "Detected microphone\n");
 
                 wm8994->mic_detecting = false;
@@ -3449,57 +3486,18 @@ static void wm8958_default_micdet(u16 status, void *data)
         }
 
 
-        if (wm8994->mic_detecting && status & 0xfc) {
+        if (status & 0xfc) {
                 dev_dbg(codec->dev, "Detected headphone\n");
                 wm8994->mic_detecting = false;
 
                 wm8958_micd_set_rate(codec);
 
                 /* If we have jackdet that will detect removal */
-                if (wm8994->jackdet) {
-                        mutex_lock(&wm8994->accdet_lock);
-
-                        snd_soc_update_bits(codec, WM8958_MIC_DETECT_1,
-                                            WM8958_MICD_ENA, 0);
-
-                        wm1811_jackdet_set_mode(codec,
-                                                WM1811_JACKDET_MODE_JACK);
-
-                        mutex_unlock(&wm8994->accdet_lock);
-
-                        if (wm8994->wm8994->pdata.jd_ext_cap)
-                                snd_soc_dapm_disable_pin(&codec->dapm,
-                                                         "MICBIAS2");
-                }
+                wm1811_micd_stop(codec);
 
                 snd_soc_jack_report(wm8994->micdet[0].jack, SND_JACK_HEADPHONE,
                                     SND_JACK_HEADSET);
         }
-
-        /* Report short circuit as a button */
-        if (wm8994->jack_mic) {
-                report = 0;
-                if (status & 0x4)
-                        report |= SND_JACK_BTN_0;
-
-                if (status & 0x8)
-                        report |= SND_JACK_BTN_1;
-
-                if (status & 0x10)
-                        report |= SND_JACK_BTN_2;
-
-                if (status & 0x20)
-                        report |= SND_JACK_BTN_3;
-
-                if (status & 0x40)
-                        report |= SND_JACK_BTN_4;
-
-                if (status & 0x80)
-                        report |= SND_JACK_BTN_5;
-
-                snd_soc_jack_report(wm8994->micdet[0].jack, report,
-                                    wm8994->btn_mask);
-        }
 }
 
 /* Deferred mic detection to allow for extra settling time */
@@ -3523,15 +3521,20 @@ static void wm1811_mic_work(struct work_struct *work)
 
         dev_dbg(codec->dev, "Starting mic detection\n");
 
-        /*
-         * Start off measument of microphone impedence to find out
-         * what's actually there.
-         */
-        wm8994->mic_detecting = true;
-        wm1811_jackdet_set_mode(codec, WM1811_JACKDET_MODE_MIC);
+        /* Use a user-supplied callback if we have one */
+        if (wm8994->micd_cb) {
+                wm8994->micd_cb(wm8994->micd_cb_data);
+        } else {
+                /*
+                 * Start off measument of microphone impedence to find out
+                 * what's actually there.
+                 */
+                wm8994->mic_detecting = true;
+                wm1811_jackdet_set_mode(codec, WM1811_JACKDET_MODE_MIC);
 
-        snd_soc_update_bits(codec, WM8958_MIC_DETECT_1,
-                            WM8958_MICD_ENA, WM8958_MICD_ENA);
+                snd_soc_update_bits(codec, WM8958_MIC_DETECT_1,
+                                    WM8958_MICD_ENA, WM8958_MICD_ENA);
+        }
 
         mutex_unlock(&wm8994->accdet_lock);
 
@@ -3643,7 +3646,8 @@ static void wm1811_jackdet_bootstrap(struct work_struct *work)
  * detection algorithm.
  */
 int wm8958_mic_detect(struct snd_soc_codec *codec, struct snd_soc_jack *jack,
-                      wm8958_micdet_cb cb, void *cb_data)
+                      wm1811_micdet_cb det_cb, void *det_cb_data,
+                      wm1811_mic_id_cb id_cb, void *id_cb_data)
 {
         struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
         struct wm8994 *control = wm8994->wm8994;
@@ -3658,21 +3662,26 @@ int wm8958_mic_detect(struct snd_soc_codec *codec, struct snd_soc_jack *jack,
         }
 
         if (jack) {
-                if (!cb) {
-                        dev_dbg(codec->dev, "Using default micdet callback\n");
-                        cb = wm8958_default_micdet;
-                        cb_data = codec;
-                }
-
                 snd_soc_dapm_force_enable_pin(&codec->dapm, "CLK_SYS");
                 snd_soc_dapm_sync(&codec->dapm);
 
                 wm8994->micdet[0].jack = jack;
-                wm8994->jack_cb = cb;
-                wm8994->jack_cb_data = cb_data;
 
-                wm8994->mic_detecting = true;
-                wm8994->jack_mic = false;
+                if (det_cb) {
+                        wm8994->micd_cb = det_cb;
+                        wm8994->micd_cb_data = det_cb_data;
+                } else {
+                        wm8994->mic_detecting = true;
+                        wm8994->jack_mic = false;
+                }
+
+                if (id_cb) {
+                        wm8994->mic_id_cb = id_cb;
+                        wm8994->mic_id_cb_data = id_cb_data;
+                } else {
+                        wm8994->mic_id_cb = wm8958_mic_id;
+                        wm8994->mic_id_cb_data = codec;
+                }
 
                 wm8958_micd_set_rate(codec);
 
@@ -3772,10 +3781,22 @@ static irqreturn_t wm8958_mic_irq(int irq, void *data)
         trace_snd_soc_jack_irq(dev_name(codec->dev));
 #endif
 
-        if (wm8994->jack_cb)
-                wm8994->jack_cb(reg, wm8994->jack_cb_data);
+        /* Avoid a transient report when the accessory is being removed */
+        if (wm8994->jackdet) {
+                reg = snd_soc_read(codec, WM1811_JACKDET_CTRL);
+                if (reg < 0) {
+                        dev_err(codec->dev, "Failed to read jack status: %d\n",
+                                reg);
+                } else if (!(reg & WM1811_JACKDET_LVL)) {
+                        dev_dbg(codec->dev, "Ignoring removed jack\n");
+                        return IRQ_HANDLED;
+                }
+        }
+
+        if (wm8994->mic_detecting)
+                wm8994->mic_id_cb(wm8994->mic_id_cb_data, reg);
         else
-                dev_warn(codec->dev, "Accessory detection with no callback\n");
+                wm8958_button_det(codec, reg);
 
 out:
         pm_runtime_put(codec->dev);
@@ -4266,7 +4287,7 @@ static struct snd_soc_codec_driver soc_codec_dev_wm8994 = {
         .set_bias_level = wm8994_set_bias_level,
 };
 
-static int __devinit wm8994_probe(struct platform_device *pdev)
+static int wm8994_probe(struct platform_device *pdev)
 {
         struct wm8994_priv *wm8994;
 
@@ -4282,7 +4303,7 @@ static int __devinit wm8994_probe(struct platform_device *pdev)
                         wm8994_dai, ARRAY_SIZE(wm8994_dai));
 }
 
-static int __devexit wm8994_remove(struct platform_device *pdev)
+static int wm8994_remove(struct platform_device *pdev)
 {
         snd_soc_unregister_codec(&pdev->dev);
         return 0;
@@ -4306,7 +4327,7 @@ static int wm8994_resume(struct device *dev)
 {
         struct wm8994_priv *wm8994 = dev_get_drvdata(dev);
 
-        if (wm8994->jackdet && wm8994->jack_cb)
+        if (wm8994->jackdet && wm8994->jackdet_mode)
                 regmap_update_bits(wm8994->wm8994->regmap, WM8994_ANTIPOP_2,
                                    WM1811_JACKDET_MODE_MASK,
                                    WM1811_JACKDET_MODE_AUDIO);
@@ -4326,7 +4347,7 @@ static struct platform_driver wm8994_codec_driver = {
                 .pm = &wm8994_pm_ops,
         },
         .probe = wm8994_probe,
-        .remove = __devexit_p(wm8994_remove),
+        .remove = wm8994_remove,
 };
 
 module_platform_driver(wm8994_codec_driver);