1 files changed, 71 insertions, 124 deletions

diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c
index f0e00fd4b435..7859bdcc93db 100644
--- a/sound/soc/codecs/tlv320aic26.c
+++ b/sound/soc/codecs/tlv320aic26.c
@@ -18,8 +18,6 @@
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
-#include <sound/soc-dapm.h>
-#include <sound/soc-of-simple.h>
 #include <sound/initval.h>
 
 #include "tlv320aic26.h"
@@ -32,7 +30,6 @@ MODULE_LICENSE("GPL");
 struct aic26 {
         struct spi_device *spi;
         struct snd_soc_codec codec;
-        u16 reg_cache[AIC26_NUM_REGS];  /* shadow registers */
         int master;
         int datfm;
         int mclk;
@@ -130,8 +127,7 @@ static int aic26_hw_params(struct snd_pcm_substream *substream,
                            struct snd_soc_dai *dai)
 {
         struct snd_soc_pcm_runtime *rtd = substream->private_data;
-        struct snd_soc_device *socdev = rtd->socdev;
-        struct snd_soc_codec *codec = socdev->card->codec;
+        struct snd_soc_codec *codec = rtd->codec;
         struct aic26 *aic26 = snd_soc_codec_get_drvdata(codec);
         int fsref, divisor, wlen, pval, jval, dval, qval;
         u16 reg;
@@ -165,10 +161,18 @@ static int aic26_hw_params(struct snd_pcm_substream *substream,
                 dev_dbg(&aic26->spi->dev, "bad format\n"); return -EINVAL;
         }
 
-        /* Configure PLL */
+        /**
+         * Configure PLL
+         * fsref = (mclk * PLLM) / 2048
+         * where PLLM = J.DDDD (DDDD register ranges from 0 to 9999, decimal)
+         */
         pval = 1;
-        jval = (fsref == 44100) ? 7 : 8;
-        dval = (fsref == 44100) ? 5264 : 1920;
+        /* compute J portion of multiplier */
+        jval = fsref / (aic26->mclk / 2048);
+        /* compute fractional DDDD component of multiplier */
+        dval = fsref - (jval * (aic26->mclk / 2048));
+        dval = (10000 * dval) / (aic26->mclk / 2048);
+        dev_dbg(&aic26->spi->dev, "Setting PLLM to %d.%04d\n", jval, dval);
         qval = 0;
         reg = 0x8000 | qval << 11 | pval << 8 | jval << 2;
         aic26_reg_write(codec, AIC26_REG_PLL_PROG1, reg);
@@ -278,8 +282,8 @@ static struct snd_soc_dai_ops aic26_dai_ops = {
         .set_fmt        = aic26_set_fmt,
 };
 
-struct snd_soc_dai aic26_dai = {
-        .name = "tlv320aic26",
+static struct snd_soc_dai_driver aic26_dai = {
+        .name = "tlv320aic26-hifi",
         .playback = {
                 .stream_name = "Playback",
                 .channels_min = 2,
@@ -296,7 +300,6 @@ struct snd_soc_dai aic26_dai = {
         },
         .ops = &aic26_dai_ops,
 };
-EXPORT_SYMBOL_GPL(aic26_dai);
 
 /* ---------------------------------------------------------------------
  * ALSA controls
@@ -319,61 +322,6 @@ static const struct snd_kcontrol_new aic26_snd_controls[] = {
 };
 
 /* ---------------------------------------------------------------------
- * SoC CODEC portion of driver: probe and release routines
- */
-static int aic26_probe(struct platform_device *pdev)
-{
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec;
-        struct aic26 *aic26;
-        int ret, err;
-
-        dev_info(&pdev->dev, "Probing AIC26 SoC CODEC driver\n");
-        dev_dbg(&pdev->dev, "socdev=%p\n", socdev);
-        dev_dbg(&pdev->dev, "codec_data=%p\n", socdev->codec_data);
-
-        /* Fetch the relevant aic26 private data here (it's already been
-         * stored in the .codec pointer) */
-        aic26 = socdev->codec_data;
-        if (aic26 == NULL) {
-                dev_err(&pdev->dev, "aic26: missing codec pointer\n");
-                return -ENODEV;
-        }
-        codec = &aic26->codec;
-        socdev->card->codec = codec;
-
-        dev_dbg(&pdev->dev, "Registering PCMs, dev=%p, socdev->dev=%p\n",
-                &pdev->dev, socdev->dev);
-        /* register pcms */
-        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
-        if (ret < 0) {
-                dev_err(&pdev->dev, "aic26: failed to create pcms\n");
-                return -ENODEV;
-        }
-
-        /* register controls */
-        dev_dbg(&pdev->dev, "Registering controls\n");
-        err = snd_soc_add_controls(codec, aic26_snd_controls,
-                        ARRAY_SIZE(aic26_snd_controls));
-        WARN_ON(err < 0);
-
-        return 0;
-}
-
-static int aic26_remove(struct platform_device *pdev)
-{
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        snd_soc_free_pcms(socdev);
-        return 0;
-}
-
-struct snd_soc_codec_device aic26_soc_codec_dev = {
-        .probe = aic26_probe,
-        .remove = aic26_remove,
-};
-EXPORT_SYMBOL_GPL(aic26_soc_codec_dev);
-
-/* ---------------------------------------------------------------------
  * SPI device portion of driver: sysfs files for debugging
  */
 
@@ -409,13 +357,61 @@ static ssize_t aic26_keyclick_set(struct device *dev,
 static DEVICE_ATTR(keyclick, 0644, aic26_keyclick_show, aic26_keyclick_set);
 
 /* ---------------------------------------------------------------------
+ * SoC CODEC portion of driver: probe and release routines
+ */
+static int aic26_probe(struct snd_soc_codec *codec)
+{
+        int ret, err, i, reg;
+
+        dev_info(codec->dev, "Probing AIC26 SoC CODEC driver\n");
+
+        /* Reset the codec to power on defaults */
+        aic26_reg_write(codec, AIC26_REG_RESET, 0xBB00);
+
+        /* Power up CODEC */
+        aic26_reg_write(codec, AIC26_REG_POWER_CTRL, 0);
+
+        /* Audio Control 3 (master mode, fsref rate) */
+        reg = aic26_reg_read(codec, AIC26_REG_AUDIO_CTRL3);
+        reg &= ~0xf800;
+        reg |= 0x0800; /* set master mode */
+        aic26_reg_write(codec, AIC26_REG_AUDIO_CTRL3, reg);
+
+        /* Fill register cache */
+        for (i = 0; i < codec->driver->reg_cache_size; i++)
+                aic26_reg_read(codec, i);
+
+        /* Register the sysfs files for debugging */
+        /* Create SysFS files */
+        ret = device_create_file(codec->dev, &dev_attr_keyclick);
+        if (ret)
+                dev_info(codec->dev, "error creating sysfs files\n");
+
+        /* register controls */
+        dev_dbg(codec->dev, "Registering controls\n");
+        err = snd_soc_add_controls(codec, aic26_snd_controls,
+                        ARRAY_SIZE(aic26_snd_controls));
+        WARN_ON(err < 0);
+
+        return 0;
+}
+
+static struct snd_soc_codec_driver aic26_soc_codec_dev = {
+        .probe = aic26_probe,
+        .read = aic26_reg_read,
+        .write = aic26_reg_write,
+        .reg_cache_size = AIC26_NUM_REGS,
+        .reg_word_size = sizeof(u16),
+};
+
+/* ---------------------------------------------------------------------
  * SPI device portion of driver: probe and release routines and SPI
  *                               driver registration.
  */
 static int aic26_spi_probe(struct spi_device *spi)
 {
         struct aic26 *aic26;
-        int ret, i, reg;
+        int ret;
 
         dev_dbg(&spi->dev, "probing tlv320aic26 spi device\n");
 
@@ -427,59 +423,13 @@ static int aic26_spi_probe(struct spi_device *spi)
         /* Initialize the driver data */
         aic26->spi = spi;
         dev_set_drvdata(&spi->dev, aic26);
-
-        /* Setup what we can in the codec structure so that the register
-         * access functions will work as expected.  More will be filled
-         * out when it is probed by the SoC CODEC part of this driver */
-        snd_soc_codec_set_drvdata(&aic26->codec, aic26);
-        aic26->codec.name = "aic26";
-        aic26->codec.owner = THIS_MODULE;
-        aic26->codec.dai = &aic26_dai;
-        aic26->codec.num_dai = 1;
-        aic26->codec.read = aic26_reg_read;
-        aic26->codec.write = aic26_reg_write;
         aic26->master = 1;
-        mutex_init(&aic26->codec.mutex);
-        INIT_LIST_HEAD(&aic26->codec.dapm_widgets);
-        INIT_LIST_HEAD(&aic26->codec.dapm_paths);
-        aic26->codec.reg_cache_size = AIC26_NUM_REGS;
-        aic26->codec.reg_cache = aic26->reg_cache;
-
-        aic26_dai.dev = &spi->dev;
-        ret = snd_soc_register_dai(&aic26_dai);
-        if (ret != 0) {
-                dev_err(&spi->dev, "Failed to register DAI: %d\n", ret);
-                kfree(aic26);
-                return ret;
-        }
-
-        /* Reset the codec to power on defaults */
-        aic26_reg_write(&aic26->codec, AIC26_REG_RESET, 0xBB00);
-
-        /* Power up CODEC */
-        aic26_reg_write(&aic26->codec, AIC26_REG_POWER_CTRL, 0);
-
-        /* Audio Control 3 (master mode, fsref rate) */
-        reg = aic26_reg_read(&aic26->codec, AIC26_REG_AUDIO_CTRL3);
-        reg &= ~0xf800;
-        reg |= 0x0800; /* set master mode */
-        aic26_reg_write(&aic26->codec, AIC26_REG_AUDIO_CTRL3, reg);
 
-        /* Fill register cache */
-        for (i = 0; i < ARRAY_SIZE(aic26->reg_cache); i++)
-                aic26_reg_read(&aic26->codec, i);
-
-        /* Register the sysfs files for debugging */
-        /* Create SysFS files */
-        ret = device_create_file(&spi->dev, &dev_attr_keyclick);
-        if (ret)
-                dev_info(&spi->dev, "error creating sysfs files\n");
-
-#if defined(CONFIG_SND_SOC_OF_SIMPLE)
-        /* Tell the of_soc helper about this codec */
-        of_snd_soc_register_codec(&aic26_soc_codec_dev, aic26, &aic26_dai,
-                                  spi->dev.archdata.of_node);
-#endif
+        ret = snd_soc_register_codec(&spi->dev,
+                        &aic26_soc_codec_dev, &aic26_dai, 1);
+        if (ret < 0)
+                kfree(aic26);
+        return ret;
 
         dev_dbg(&spi->dev, "SPI device initialized\n");
         return 0;
@@ -487,17 +437,14 @@ static int aic26_spi_probe(struct spi_device *spi)
 
 static int aic26_spi_remove(struct spi_device *spi)
 {
-        struct aic26 *aic26 = dev_get_drvdata(&spi->dev);
-
-        snd_soc_unregister_dai(&aic26_dai);
-        kfree(aic26);
-
+        snd_soc_unregister_codec(&spi->dev);
+        kfree(spi_get_drvdata(spi));
         return 0;
 }
 
 static struct spi_driver aic26_spi = {
         .driver = {
-                .name = "tlv320aic26",
+                .name = "tlv320aic26-codec",
                 .owner = THIS_MODULE,
         },
         .probe = aic26_spi_probe,