diff options
Diffstat (limited to 'sound/pci/emu10k1/io.c')
-rw-r--r-- | sound/pci/emu10k1/io.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/sound/pci/emu10k1/io.c b/sound/pci/emu10k1/io.c index e4fba49fee4a..706b4f0c6806 100644 --- a/sound/pci/emu10k1/io.c +++ b/sound/pci/emu10k1/io.c | |||
@@ -71,11 +71,8 @@ void snd_emu10k1_ptr_write(struct snd_emu10k1 *emu, unsigned int reg, unsigned i | |||
71 | unsigned long flags; | 71 | unsigned long flags; |
72 | unsigned int mask; | 72 | unsigned int mask; |
73 | 73 | ||
74 | if (!emu) { | 74 | if (snd_BUG_ON(!emu)) |
75 | snd_printk(KERN_ERR "ptr_write: emu is null!\n"); | ||
76 | dump_stack(); | ||
77 | return; | 75 | return; |
78 | } | ||
79 | mask = emu->audigy ? A_PTR_ADDRESS_MASK : PTR_ADDRESS_MASK; | 76 | mask = emu->audigy ? A_PTR_ADDRESS_MASK : PTR_ADDRESS_MASK; |
80 | regptr = ((reg << 16) & mask) | (chn & PTR_CHANNELNUM_MASK); | 77 | regptr = ((reg << 16) & mask) | (chn & PTR_CHANNELNUM_MASK); |
81 | 78 | ||
@@ -199,7 +196,7 @@ int snd_emu10k1_i2c_write(struct snd_emu10k1 *emu, | |||
199 | int err = 0; | 196 | int err = 0; |
200 | 197 | ||
201 | if ((reg > 0x7f) || (value > 0x1ff)) { | 198 | if ((reg > 0x7f) || (value > 0x1ff)) { |
202 | snd_printk(KERN_ERR "i2c_write: invalid values.\n"); | 199 | dev_err(emu->card->dev, "i2c_write: invalid values.\n"); |
203 | return -EINVAL; | 200 | return -EINVAL; |
204 | } | 201 | } |
205 | 202 | ||
@@ -227,7 +224,7 @@ int snd_emu10k1_i2c_write(struct snd_emu10k1 *emu, | |||
227 | break; | 224 | break; |
228 | 225 | ||
229 | if (timeout > 1000) { | 226 | if (timeout > 1000) { |
230 | snd_printk(KERN_WARNING | 227 | dev_warn(emu->card->dev, |
231 | "emu10k1:I2C:timeout status=0x%x\n", | 228 | "emu10k1:I2C:timeout status=0x%x\n", |
232 | status); | 229 | status); |
233 | break; | 230 | break; |
@@ -239,8 +236,8 @@ int snd_emu10k1_i2c_write(struct snd_emu10k1 *emu, | |||
239 | } | 236 | } |
240 | 237 | ||
241 | if (retry == 10) { | 238 | if (retry == 10) { |
242 | snd_printk(KERN_ERR "Writing to ADC failed!\n"); | 239 | dev_err(emu->card->dev, "Writing to ADC failed!\n"); |
243 | snd_printk(KERN_ERR "status=0x%x, reg=%d, value=%d\n", | 240 | dev_err(emu->card->dev, "status=0x%x, reg=%d, value=%d\n", |
244 | status, reg, value); | 241 | status, reg, value); |
245 | /* dump_stack(); */ | 242 | /* dump_stack(); */ |
246 | err = -EINVAL; | 243 | err = -EINVAL; |