aboutsummaryrefslogtreecommitdiffstats
path: root/sound/pci/asihpi/hpidspcd.c
diff options
context:
space:
mode:
Diffstat (limited to 'sound/pci/asihpi/hpidspcd.c')
-rw-r--r--sound/pci/asihpi/hpidspcd.c22
1 files changed, 9 insertions, 13 deletions
diff --git a/sound/pci/asihpi/hpidspcd.c b/sound/pci/asihpi/hpidspcd.c
index 456a758f04f6..ac9163770013 100644
--- a/sound/pci/asihpi/hpidspcd.c
+++ b/sound/pci/asihpi/hpidspcd.c
@@ -49,14 +49,12 @@ short hpi_dsp_code_open(u32 adapter, void *os_data, struct dsp_code *dsp_code,
49 err = request_firmware(&firmware, fw_name, &dev->dev); 49 err = request_firmware(&firmware, fw_name, &dev->dev);
50 50
51 if (err || !firmware) { 51 if (err || !firmware) {
52 dev_printk(KERN_ERR, &dev->dev, 52 dev_err(&dev->dev, "%d, request_firmware failed for %s\n",
53 "%d, request_firmware failed for %s\n", err, 53 err, fw_name);
54 fw_name);
55 goto error1; 54 goto error1;
56 } 55 }
57 if (firmware->size < sizeof(header)) { 56 if (firmware->size < sizeof(header)) {
58 dev_printk(KERN_ERR, &dev->dev, "Header size too small %s\n", 57 dev_err(&dev->dev, "Header size too small %s\n", fw_name);
59 fw_name);
60 goto error2; 58 goto error2;
61 } 59 }
62 memcpy(&header, firmware->data, sizeof(header)); 60 memcpy(&header, firmware->data, sizeof(header));
@@ -64,7 +62,7 @@ short hpi_dsp_code_open(u32 adapter, void *os_data, struct dsp_code *dsp_code,
64 if ((header.type != 0x45444F43) || /* "CODE" */ 62 if ((header.type != 0x45444F43) || /* "CODE" */
65 (header.adapter != adapter) 63 (header.adapter != adapter)
66 || (header.size != firmware->size)) { 64 || (header.size != firmware->size)) {
67 dev_printk(KERN_ERR, &dev->dev, 65 dev_err(&dev->dev,
68 "Invalid firmware header size %d != file %zd\n", 66 "Invalid firmware header size %d != file %zd\n",
69 header.size, firmware->size); 67 header.size, firmware->size);
70 goto error2; 68 goto error2;
@@ -72,17 +70,15 @@ short hpi_dsp_code_open(u32 adapter, void *os_data, struct dsp_code *dsp_code,
72 70
73 if ((header.version >> 9) != (HPI_VER >> 9)) { 71 if ((header.version >> 9) != (HPI_VER >> 9)) {
74 /* Consider even and subsequent odd minor versions to be compatible */ 72 /* Consider even and subsequent odd minor versions to be compatible */
75 dev_printk(KERN_ERR, &dev->dev, 73 dev_err(&dev->dev, "Incompatible firmware version DSP image %X != Driver %X\n",
76 "Incompatible firmware version " 74 header.version, HPI_VER);
77 "DSP image %X != Driver %X\n", header.version,
78 HPI_VER);
79 goto error2; 75 goto error2;
80 } 76 }
81 77
82 if (header.version != HPI_VER) { 78 if (header.version != HPI_VER) {
83 dev_printk(KERN_INFO, &dev->dev, 79 dev_info(&dev->dev,
84 "Firmware: release version mismatch DSP image %X != Driver %X\n", 80 "Firmware: release version mismatch DSP image %X != Driver %X\n",
85 header.version, HPI_VER); 81 header.version, HPI_VER);
86 } 82 }
87 83
88 HPI_DEBUG_LOG(DEBUG, "dsp code %s opened\n", fw_name); 84 HPI_DEBUG_LOG(DEBUG, "dsp code %s opened\n", fw_name);