5 files changed, 50 insertions, 50 deletions

diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c
index e35fd5779a9d..ae0df549fac7 100644
--- a/sound/drivers/dummy.c
+++ b/sound/drivers/dummy.c
@@ -675,10 +675,8 @@ static int __init alsa_card_dummy_init(void)
                         continue;
                 device = platform_device_register_simple(SND_DUMMY_DRIVER,
                                                          i, NULL, 0);
-                if (IS_ERR(device)) {
-                        err = PTR_ERR(device);
-                        goto errout;
-                }
+                if (IS_ERR(device))
+                        continue;
                 devices[i] = device;
                 cards++;
         }
@@ -686,14 +684,10 @@ static int __init alsa_card_dummy_init(void)
 #ifdef MODULE
                 printk(KERN_ERR "Dummy soundcard not found or device busy\n");
 #endif
-                err = -ENODEV;
-                goto errout;
+                snd_dummy_unregister_all();
+                return -ENODEV;
         }
         return 0;
-
- errout:
-        snd_dummy_unregister_all();
-        return err;
 }
 
 static void __exit alsa_card_dummy_exit(void)
diff --git a/sound/drivers/mpu401/mpu401.c b/sound/drivers/mpu401/mpu401.c
index 9ea3059a7064..77b06009735d 100644
--- a/sound/drivers/mpu401/mpu401.c
+++ b/sound/drivers/mpu401/mpu401.c
@@ -151,7 +151,7 @@ static struct pnp_device_id snd_mpu401_pnpids[] = {
 
 MODULE_DEVICE_TABLE(pnp, snd_mpu401_pnpids);
 
-static int __init snd_mpu401_pnp(int dev, struct pnp_dev *device,
+static int __devinit snd_mpu401_pnp(int dev, struct pnp_dev *device,
                                  const struct pnp_device_id *id)
 {
         if (!pnp_port_valid(device, 0) ||
@@ -251,10 +251,8 @@ static int __init alsa_card_mpu401_init(void)
 #endif
                 device = platform_device_register_simple(SND_MPU401_DRIVER,
                                                          i, NULL, 0);
-                if (IS_ERR(device)) {
-                        err = PTR_ERR(device);
-                        goto errout;
-                }
+                if (IS_ERR(device))
+                        continue;
                 platform_devices[i] = device;
                 snd_mpu401_devices++;
         }
@@ -266,14 +264,10 @@ static int __init alsa_card_mpu401_init(void)
 #ifdef MODULE
                 printk(KERN_ERR "MPU-401 device not found or device busy\n");
 #endif
-                err = -ENODEV;
-                goto errout;
+                snd_mpu401_unregister_all();
+                return -ENODEV;
         }
         return 0;
-
- errout:
-        snd_mpu401_unregister_all();
-        return err;
 }
 
 static void __exit alsa_card_mpu401_exit(void)
diff --git a/sound/drivers/mpu401/mpu401_uart.c b/sound/drivers/mpu401/mpu401_uart.c
index 8687ae3c66b8..b49a45cbf67a 100644
--- a/sound/drivers/mpu401/mpu401_uart.c
+++ b/sound/drivers/mpu401/mpu401_uart.c
@@ -183,7 +183,8 @@ static void snd_mpu401_uart_remove_timer (struct snd_mpu401 *mpu, int input)
 
  */
 
-static void snd_mpu401_uart_cmd(struct snd_mpu401 * mpu, unsigned char cmd, int ack)
+static int snd_mpu401_uart_cmd(struct snd_mpu401 * mpu, unsigned char cmd,
+                int ack)
 {
         unsigned long flags;
         int timeout, ok;
@@ -218,9 +219,11 @@ static void snd_mpu401_uart_cmd(struct snd_mpu401 * mpu, unsigned char cmd, int
                 ok = 1;
         }
         spin_unlock_irqrestore(&mpu->input_lock, flags);
-        if (! ok)
+        if (!ok) {
                 snd_printk("cmd: 0x%x failed at 0x%lx (status = 0x%x, data = 0x%x)\n", cmd, mpu->port, mpu->read(mpu, MPU401C(mpu)), mpu->read(mpu, MPU401D(mpu)));
-        // snd_printk("cmd: 0x%x at 0x%lx (status = 0x%x, data = 0x%x)\n", cmd, mpu->port, mpu->read(mpu, MPU401C(mpu)), mpu->read(mpu, MPU401D(mpu)));
+                return 1;
+        }
+        return 0;
 }
 
 /*
@@ -235,12 +238,19 @@ static int snd_mpu401_uart_input_open(struct snd_rawmidi_substream *substream)
         if (mpu->open_input && (err = mpu->open_input(mpu)) < 0)
                 return err;
         if (! test_bit(MPU401_MODE_BIT_OUTPUT, &mpu->mode)) {
-                snd_mpu401_uart_cmd(mpu, MPU401_RESET, 1);
-                snd_mpu401_uart_cmd(mpu, MPU401_ENTER_UART, 1);
+                if (snd_mpu401_uart_cmd(mpu, MPU401_RESET, 1))
+                        goto error_out;
+                if (snd_mpu401_uart_cmd(mpu, MPU401_ENTER_UART, 1))
+                        goto error_out;
         }
         mpu->substream_input = substream;
         set_bit(MPU401_MODE_BIT_INPUT, &mpu->mode);
         return 0;
+
+error_out:
+        if (mpu->open_input && mpu->close_input)
+                mpu->close_input(mpu);
+        return -EIO;
 }
 
 static int snd_mpu401_uart_output_open(struct snd_rawmidi_substream *substream)
@@ -252,39 +262,52 @@ static int snd_mpu401_uart_output_open(struct snd_rawmidi_substream *substream)
         if (mpu->open_output && (err = mpu->open_output(mpu)) < 0)
                 return err;
         if (! test_bit(MPU401_MODE_BIT_INPUT, &mpu->mode)) {
-                snd_mpu401_uart_cmd(mpu, MPU401_RESET, 1);
-                snd_mpu401_uart_cmd(mpu, MPU401_ENTER_UART, 1);
+                if (snd_mpu401_uart_cmd(mpu, MPU401_RESET, 1))
+                        goto error_out;
+                if (snd_mpu401_uart_cmd(mpu, MPU401_ENTER_UART, 1))
+                        goto error_out;
         }
         mpu->substream_output = substream;
         set_bit(MPU401_MODE_BIT_OUTPUT, &mpu->mode);
         return 0;
+
+error_out:
+        if (mpu->open_output && mpu->close_output)
+                mpu->close_output(mpu);
+        return -EIO;
 }
 
 static int snd_mpu401_uart_input_close(struct snd_rawmidi_substream *substream)
 {
         struct snd_mpu401 *mpu;
+        int err = 0;
 
         mpu = substream->rmidi->private_data;
         clear_bit(MPU401_MODE_BIT_INPUT, &mpu->mode);
         mpu->substream_input = NULL;
         if (! test_bit(MPU401_MODE_BIT_OUTPUT, &mpu->mode))
-                snd_mpu401_uart_cmd(mpu, MPU401_RESET, 0);
+                err = snd_mpu401_uart_cmd(mpu, MPU401_RESET, 0);
         if (mpu->close_input)
                 mpu->close_input(mpu);
+        if (err)
+                return -EIO;
         return 0;
 }
 
 static int snd_mpu401_uart_output_close(struct snd_rawmidi_substream *substream)
 {
         struct snd_mpu401 *mpu;
+        int err = 0;
 
         mpu = substream->rmidi->private_data;
         clear_bit(MPU401_MODE_BIT_OUTPUT, &mpu->mode);
         mpu->substream_output = NULL;
         if (! test_bit(MPU401_MODE_BIT_INPUT, &mpu->mode))
-                snd_mpu401_uart_cmd(mpu, MPU401_RESET, 0);
+                err = snd_mpu401_uart_cmd(mpu, MPU401_RESET, 0);
         if (mpu->close_output)
                 mpu->close_output(mpu);
+        if (err)
+                return -EIO;
         return 0;
 }
 
@@ -316,6 +339,7 @@ static void snd_mpu401_uart_input_trigger(struct snd_rawmidi_substream *substrea
                         snd_mpu401_uart_remove_timer(mpu, 1);
                 clear_bit(MPU401_MODE_BIT_INPUT_TRIGGER, &mpu->mode);
         }
+
 }
 
 /*
diff --git a/sound/drivers/serial-u16550.c b/sound/drivers/serial-u16550.c
index 1a7fbefe4740..c01b4c5118b9 100644
--- a/sound/drivers/serial-u16550.c
+++ b/sound/drivers/serial-u16550.c
@@ -996,10 +996,8 @@ static int __init alsa_card_serial_init(void)
                         continue;
                 device = platform_device_register_simple(SND_SERIAL_DRIVER,
                                                          i, NULL, 0);
-                if (IS_ERR(device)) {
-                        err = PTR_ERR(device);
-                        goto errout;
-                }
+                if (IS_ERR(device))
+                        continue;
                 devices[i] = device;
                 cards++;
         }
@@ -1007,14 +1005,10 @@ static int __init alsa_card_serial_init(void)
 #ifdef MODULE
                 printk(KERN_ERR "serial midi soundcard not found or device busy\n");
 #endif
-                err = -ENODEV;
-                goto errout;
+                snd_serial_unregister_all();
+                return -ENODEV;
         }
         return 0;
-
- errout:
-        snd_serial_unregister_all();
-        return err;
 }
 
 static void __exit alsa_card_serial_exit(void)
diff --git a/sound/drivers/virmidi.c b/sound/drivers/virmidi.c
index a3ee306239c9..26eb2499d442 100644
--- a/sound/drivers/virmidi.c
+++ b/sound/drivers/virmidi.c
@@ -169,10 +169,8 @@ static int __init alsa_card_virmidi_init(void)
                         continue;
                 device = platform_device_register_simple(SND_VIRMIDI_DRIVER,
                                                          i, NULL, 0);
-                if (IS_ERR(device)) {
-                        err = PTR_ERR(device);
-                        goto errout;
-                }
+                if (IS_ERR(device))
+                        continue;
                 devices[i] = device;
                 cards++;
         }
@@ -180,14 +178,10 @@ static int __init alsa_card_virmidi_init(void)
 #ifdef MODULE
                 printk(KERN_ERR "Card-VirMIDI soundcard not found or device busy\n");
 #endif
-                err = -ENODEV;
-                goto errout;
+                snd_virmidi_unregister_all();
+                return -ENODEV;
         }
         return 0;
-
- errout:
-        snd_virmidi_unregister_all();
-        return err;
 }
 
 static void __exit alsa_card_virmidi_exit(void)