1 files changed, 55 insertions, 4 deletions

diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
index 1f8b305449db..a796c95fe8a0 100644
--- a/scripts/kconfig/symbol.c
+++ b/scripts/kconfig/symbol.c
@@ -350,16 +350,18 @@ void sym_calc_value(struct symbol *sym)
                                 }
                         }
                 calc_newval:
-#if 0
                         if (sym->dir_dep.tri == no && sym->rev_dep.tri != no) {
+                                struct expr *e;
+                                e = expr_simplify_unmet_dep(sym->rev_dep.expr,
+                                    sym->dir_dep.expr);
                                 fprintf(stderr, "warning: (");
-                                expr_fprint(sym->rev_dep.expr, stderr);
+                                expr_fprint(e, stderr);
                                 fprintf(stderr, ") selects %s which has unmet direct dependencies (",
                                         sym->name);
                                 expr_fprint(sym->dir_dep.expr, stderr);
                                 fprintf(stderr, ")\n");
+                                expr_free(e);
                         }
-#endif
                         newval.tri = EXPR_OR(newval.tri, sym->rev_dep.tri);
                 }
                 if (newval.tri == mod && sym_get_type(sym) == S_BOOLEAN)
@@ -688,7 +690,7 @@ const char *sym_get_string_default(struct symbol *sym)
                 switch (sym->type) {
                 case S_BOOLEAN:
                 case S_TRISTATE:
-                        /* The visibility imay limit the value from yes => mod */
+                        /* The visibility may limit the value from yes => mod */
                         val = EXPR_AND(expr_calc_value(prop->expr), prop->visible.tri);
                         break;
                 default:
@@ -842,6 +844,55 @@ struct symbol *sym_find(const char *name)
         return symbol;
 }
 
+/*
+ * Expand symbol's names embedded in the string given in argument. Symbols'
+ * name to be expanded shall be prefixed by a '$'. Unknown symbol expands to
+ * the empty string.
+ */
+const char *sym_expand_string_value(const char *in)
+{
+        const char *src;
+        char *res;
+        size_t reslen;
+
+        reslen = strlen(in) + 1;
+        res = malloc(reslen);
+        res[0] = '\0';
+
+        while ((src = strchr(in, '$'))) {
+                char *p, name[SYMBOL_MAXLENGTH];
+                const char *symval = "";
+                struct symbol *sym;
+                size_t newlen;
+
+                strncat(res, in, src - in);
+                src++;
+
+                p = name;
+                while (isalnum(*src) || *src == '_')
+                        *p++ = *src++;
+                *p = '\0';
+
+                sym = sym_find(name);
+                if (sym != NULL) {
+                        sym_calc_value(sym);
+                        symval = sym_get_string_value(sym);
+                }
+
+                newlen = strlen(res) + strlen(symval) + strlen(src) + 1;
+                if (newlen > reslen) {
+                        reslen = newlen;
+                        res = realloc(res, reslen);
+                }
+
+                strcat(res, symval);
+                in = src;
+        }
+        strcat(res, in);
+
+        return res;
+}
+
 struct symbol **sym_re_search(const char *pattern)
 {
         struct symbol *sym, **sym_arr = NULL;