7 files changed, 59 insertions, 37 deletions

diff --git a/scripts/kconfig/lxdialog/checklist.c b/scripts/kconfig/lxdialog/checklist.c
index a2eb80fbc896..3b15c08ec1fa 100644
--- a/scripts/kconfig/lxdialog/checklist.c
+++ b/scripts/kconfig/lxdialog/checklist.c
@@ -132,16 +132,16 @@ int dialog_checklist(const char *title, const char *prompt, int height,
         }
 
 do_resize:
-        if (getmaxy(stdscr) < (height + 6))
+        if (getmaxy(stdscr) < (height + CHECKLIST_HEIGTH_MIN))
                 return -ERRDISPLAYTOOSMALL;
-        if (getmaxx(stdscr) < (width + 6))
+        if (getmaxx(stdscr) < (width + CHECKLIST_WIDTH_MIN))
                 return -ERRDISPLAYTOOSMALL;
 
         max_choice = MIN(list_height, item_count());
 
         /* center dialog box on screen */
-        x = (COLS - width) / 2;
-        y = (LINES - height) / 2;
+        x = (getmaxx(stdscr) - width) / 2;
+        y = (getmaxy(stdscr) - height) / 2;
 
         draw_shadow(stdscr, y, x, height, width);
 
diff --git a/scripts/kconfig/lxdialog/dialog.h b/scripts/kconfig/lxdialog/dialog.h
index 1099337079b6..b4343d384926 100644
--- a/scripts/kconfig/lxdialog/dialog.h
+++ b/scripts/kconfig/lxdialog/dialog.h
@@ -200,6 +200,20 @@ int item_is_tag(char tag);
 int on_key_esc(WINDOW *win);
 int on_key_resize(void);
 
+/* minimum (re)size values */
+#define CHECKLIST_HEIGTH_MIN 6  /* For dialog_checklist() */
+#define CHECKLIST_WIDTH_MIN 6
+#define INPUTBOX_HEIGTH_MIN 2   /* For dialog_inputbox() */
+#define INPUTBOX_WIDTH_MIN 2
+#define MENUBOX_HEIGTH_MIN 15   /* For dialog_menu() */
+#define MENUBOX_WIDTH_MIN 65
+#define TEXTBOX_HEIGTH_MIN 8    /* For dialog_textbox() */
+#define TEXTBOX_WIDTH_MIN 8
+#define YESNO_HEIGTH_MIN 4      /* For dialog_yesno() */
+#define YESNO_WIDTH_MIN 4
+#define WINDOW_HEIGTH_MIN 19    /* For init_dialog() */
+#define WINDOW_WIDTH_MIN 80
+
 int init_dialog(const char *backtitle);
 void set_dialog_backtitle(const char *backtitle);
 void set_dialog_subtitles(struct subtitle_list *subtitles);
diff --git a/scripts/kconfig/lxdialog/inputbox.c b/scripts/kconfig/lxdialog/inputbox.c
index 21404a04d7c3..447a582198c9 100644
--- a/scripts/kconfig/lxdialog/inputbox.c
+++ b/scripts/kconfig/lxdialog/inputbox.c
@@ -56,14 +56,14 @@ int dialog_inputbox(const char *title, const char *prompt, int height, int width
                 strcpy(instr, init);
 
 do_resize:
-        if (getmaxy(stdscr) <= (height - 2))
+        if (getmaxy(stdscr) <= (height - INPUTBOX_HEIGTH_MIN))
                 return -ERRDISPLAYTOOSMALL;
-        if (getmaxx(stdscr) <= (width - 2))
+        if (getmaxx(stdscr) <= (width - INPUTBOX_WIDTH_MIN))
                 return -ERRDISPLAYTOOSMALL;
 
         /* center dialog box on screen */
-        x = (COLS - width) / 2;
-        y = (LINES - height) / 2;
+        x = (getmaxx(stdscr) - width) / 2;
+        y = (getmaxy(stdscr) - height) / 2;
 
         draw_shadow(stdscr, y, x, height, width);
 
diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
index 38cd69c5660e..c93de0b2faca 100644
--- a/scripts/kconfig/lxdialog/menubox.c
+++ b/scripts/kconfig/lxdialog/menubox.c
@@ -193,7 +193,7 @@ int dialog_menu(const char *title, const char *prompt,
 do_resize:
         height = getmaxy(stdscr);
         width = getmaxx(stdscr);
-        if (height < 15 || width < 65)
+        if (height < MENUBOX_HEIGTH_MIN || width < MENUBOX_WIDTH_MIN)
                 return -ERRDISPLAYTOOSMALL;
 
         height -= 4;
@@ -203,8 +203,8 @@ do_resize:
         max_choice = MIN(menu_height, item_count());
 
         /* center dialog box on screen */
-        x = (COLS - width) / 2;
-        y = (LINES - height) / 2;
+        x = (getmaxx(stdscr) - width) / 2;
+        y = (getmaxy(stdscr) - height) / 2;
 
         draw_shadow(stdscr, y, x, height, width);
 
diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c
index a48bb93e0907..1773319b95e7 100644
--- a/scripts/kconfig/lxdialog/textbox.c
+++ b/scripts/kconfig/lxdialog/textbox.c
@@ -80,7 +80,7 @@ int dialog_textbox(const char *title, char *tbuf, int initial_height,
 
 do_resize:
         getmaxyx(stdscr, height, width);
-        if (height < 8 || width < 8)
+        if (height < TEXTBOX_HEIGTH_MIN || width < TEXTBOX_WIDTH_MIN)
                 return -ERRDISPLAYTOOSMALL;
         if (initial_height != 0)
                 height = initial_height;
@@ -98,8 +98,8 @@ do_resize:
                         width = 0;
 
         /* center dialog box on screen */
-        x = (COLS - width) / 2;
-        y = (LINES - height) / 2;
+        x = (getmaxx(stdscr) - width) / 2;
+        y = (getmaxy(stdscr) - height) / 2;
 
         draw_shadow(stdscr, y, x, height, width);
 
diff --git a/scripts/kconfig/lxdialog/util.c b/scripts/kconfig/lxdialog/util.c
index a0e97c299410..58a8289dd650 100644
--- a/scripts/kconfig/lxdialog/util.c
+++ b/scripts/kconfig/lxdialog/util.c
@@ -254,7 +254,12 @@ void attr_clear(WINDOW * win, int height, int width, chtype attr)
 
 void dialog_clear(void)
 {
-        attr_clear(stdscr, LINES, COLS, dlg.screen.atr);
+        int lines, columns;
+
+        lines = getmaxy(stdscr);
+        columns = getmaxx(stdscr);
+
+        attr_clear(stdscr, lines, columns, dlg.screen.atr);
         /* Display background title if it exists ... - SLH */
         if (dlg.backtitle != NULL) {
                 int i, len = 0, skip = 0;
@@ -269,10 +274,10 @@ void dialog_clear(void)
                 }
 
                 wmove(stdscr, 1, 1);
-                if (len > COLS - 2) {
+                if (len > columns - 2) {
                         const char *ellipsis = "[...] ";
                         waddstr(stdscr, ellipsis);
-                        skip = len - (COLS - 2 - strlen(ellipsis));
+                        skip = len - (columns - 2 - strlen(ellipsis));
                 }
 
                 for (pos = dlg.subtitles; pos != NULL; pos = pos->next) {
@@ -298,7 +303,7 @@ void dialog_clear(void)
                                 skip--;
                 }
 
-                for (i = len + 1; i < COLS - 1; i++)
+                for (i = len + 1; i < columns - 1; i++)
                         waddch(stdscr, ACS_HLINE);
         }
         wnoutrefresh(stdscr);
@@ -317,7 +322,7 @@ int init_dialog(const char *backtitle)
         getyx(stdscr, saved_y, saved_x);
 
         getmaxyx(stdscr, height, width);
-        if (height < 19 || width < 80) {
+        if (height < WINDOW_HEIGTH_MIN || width < WINDOW_WIDTH_MIN) {
                 endwin();
                 return -ERRDISPLAYTOOSMALL;
         }
@@ -371,27 +376,19 @@ void print_title(WINDOW *dialog, const char *title, int width)
 /*
  * Print a string of text in a window, automatically wrap around to the
  * next line if the string is too long to fit on one line. Newline
- * characters '\n' are replaced by spaces.  We start on a new line
+ * characters '\n' are propperly processed.  We start on a new line
  * if there is no room for at least 4 nonblanks following a double-space.
  */
 void print_autowrap(WINDOW * win, const char *prompt, int width, int y, int x)
 {
         int newl, cur_x, cur_y;
-        int i, prompt_len, room, wlen;
-        char tempstr[MAX_LEN + 1], *word, *sp, *sp2;
+        int prompt_len, room, wlen;
+        char tempstr[MAX_LEN + 1], *word, *sp, *sp2, *newline_separator = 0;
 
         strcpy(tempstr, prompt);
 
         prompt_len = strlen(tempstr);
 
-        /*
-         * Remove newlines
-         */
-        for (i = 0; i < prompt_len; i++) {
-                if (tempstr[i] == '\n')
-                        tempstr[i] = ' ';
-        }
-
         if (prompt_len <= width - x * 2) {      /* If prompt is short */
                 wmove(win, y, (width - prompt_len) / 2);
                 waddstr(win, tempstr);
@@ -401,7 +398,10 @@ void print_autowrap(WINDOW * win, const char *prompt, int width, int y, int x)
                 newl = 1;
                 word = tempstr;
                 while (word && *word) {
-                        sp = strchr(word, ' ');
+                        sp = strpbrk(word, "\n ");
+                        if (sp && *sp == '\n')
+                                newline_separator = sp;
+
                         if (sp)
                                 *sp++ = 0;
 
@@ -413,7 +413,7 @@ void print_autowrap(WINDOW * win, const char *prompt, int width, int y, int x)
                         if (wlen > room ||
                             (newl && wlen < 4 && sp
                              && wlen + 1 + strlen(sp) > room
-                             && (!(sp2 = strchr(sp, ' '))
+                             && (!(sp2 = strpbrk(sp, "\n "))
                                  || wlen + 1 + (sp2 - sp) > room))) {
                                 cur_y++;
                                 cur_x = x;
@@ -421,7 +421,15 @@ void print_autowrap(WINDOW * win, const char *prompt, int width, int y, int x)
                         wmove(win, cur_y, cur_x);
                         waddstr(win, word);
                         getyx(win, cur_y, cur_x);
-                        cur_x++;
+
+                        /* Move to the next line if the word separator was a newline */
+                        if (newline_separator) {
+                                cur_y++;
+                                cur_x = x;
+                                newline_separator = 0;
+                        } else
+                                cur_x++;
+
                         if (sp && *sp == ' ') {
                                 cur_x++;        /* double space */
                                 while (*++sp == ' ') ;
diff --git a/scripts/kconfig/lxdialog/yesno.c b/scripts/kconfig/lxdialog/yesno.c
index 4e6e8090c20b..676fb2f824a3 100644
--- a/scripts/kconfig/lxdialog/yesno.c
+++ b/scripts/kconfig/lxdialog/yesno.c
@@ -45,14 +45,14 @@ int dialog_yesno(const char *title, const char *prompt, int height, int width)
         WINDOW *dialog;
 
 do_resize:
-        if (getmaxy(stdscr) < (height + 4))
+        if (getmaxy(stdscr) < (height + YESNO_HEIGTH_MIN))
                 return -ERRDISPLAYTOOSMALL;
-        if (getmaxx(stdscr) < (width + 4))
+        if (getmaxx(stdscr) < (width + YESNO_WIDTH_MIN))
                 return -ERRDISPLAYTOOSMALL;
 
         /* center dialog box on screen */
-        x = (COLS - width) / 2;
-        y = (LINES - height) / 2;
+        x = (getmaxx(stdscr) - width) / 2;
+        y = (getmaxy(stdscr) - height) / 2;
 
         draw_shadow(stdscr, y, x, height, width);