diff options
Diffstat (limited to 'scripts/checkpatch.pl')
| -rwxr-xr-x | scripts/checkpatch.pl | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d8670810db65..b0aa2c680593 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
| @@ -210,10 +210,10 @@ our $typeTypedefs = qr{(?x: | |||
| 210 | 210 | ||
| 211 | our $logFunctions = qr{(?x: | 211 | our $logFunctions = qr{(?x: |
| 212 | printk| | 212 | printk| |
| 213 | pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)| | 213 | [a-z]+_(emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)| |
| 214 | (dev|netdev|netif)_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)| | ||
| 215 | WARN| | 214 | WARN| |
| 216 | panic | 215 | panic| |
| 216 | MODULE_[A-Z_]+ | ||
| 217 | )}; | 217 | )}; |
| 218 | 218 | ||
| 219 | our @typeList = ( | 219 | our @typeList = ( |
| @@ -1462,7 +1462,7 @@ sub process { | |||
| 1462 | #80 column limit | 1462 | #80 column limit |
| 1463 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && | 1463 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && |
| 1464 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && | 1464 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && |
| 1465 | !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ || | 1465 | !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ || |
| 1466 | $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) && | 1466 | $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) && |
| 1467 | $length > 80) | 1467 | $length > 80) |
| 1468 | { | 1468 | { |
| @@ -1943,6 +1943,11 @@ sub process { | |||
| 1943 | WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr); | 1943 | WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr); |
| 1944 | } | 1944 | } |
| 1945 | 1945 | ||
| 1946 | # check for uses of printk_ratelimit | ||
| 1947 | if ($line =~ /\bprintk_ratelimit\s*\(/) { | ||
| 1948 | WARN("Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr); | ||
| 1949 | } | ||
| 1950 | |||
| 1946 | # printk should use KERN_* levels. Note that follow on printk's on the | 1951 | # printk should use KERN_* levels. Note that follow on printk's on the |
| 1947 | # same line do not need a level, so we use the current block context | 1952 | # same line do not need a level, so we use the current block context |
| 1948 | # to try and find and validate the current printk. In summary the current | 1953 | # to try and find and validate the current printk. In summary the current |
| @@ -2748,6 +2753,11 @@ sub process { | |||
| 2748 | WARN("sizeof(& should be avoided\n" . $herecurr); | 2753 | WARN("sizeof(& should be avoided\n" . $herecurr); |
| 2749 | } | 2754 | } |
| 2750 | 2755 | ||
| 2756 | # check for line continuations in quoted strings with odd counts of " | ||
| 2757 | if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) { | ||
| 2758 | WARN("Avoid line continuations in quoted strings\n" . $herecurr); | ||
| 2759 | } | ||
| 2760 | |||
| 2751 | # check for new externs in .c files. | 2761 | # check for new externs in .c files. |
| 2752 | if ($realfile =~ /\.c$/ && defined $stat && | 2762 | if ($realfile =~ /\.c$/ && defined $stat && |
| 2753 | $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) | 2763 | $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) |
