1 files changed, 104 insertions, 5 deletions

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3257d3d96767..bd88f11b0953 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -145,11 +145,14 @@ our $Sparse	= qr{
                         __kprobes|
                         __ref
                 }x;
+
+# Notes to $Attribute:
+# We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
 our $Attribute  = qr{
                         const|
                         __read_mostly|
                         __kprobes|
-                        __(?:mem|cpu|dev|)(?:initdata|init)|
+                        __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
                         ____cacheline_aligned|
                         ____cacheline_aligned_in_smp|
                         ____cacheline_internodealigned_in_smp|
@@ -189,6 +192,14 @@ our $typeTypedefs = qr{(?x:
         atomic_t
 )};
 
+our $logFunctions = qr{(?x:
+        printk|
+        pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)|
+        dev_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)|
+        WARN|
+        panic
+)};
+
 our @typeList = (
         qr{void},
         qr{(?:unsigned\s+)?char},
@@ -1371,18 +1382,38 @@ sub process {
                         ERROR("trailing whitespace\n" . $herevet);
                 }
 
+# check for Kconfig help text having a real description
+                if ($realfile =~ /Kconfig/ &&
+                    $line =~ /\+?\s*(---)?help(---)?$/) {
+                        my $length = 0;
+                        for (my $l = $linenr; defined($lines[$l]); $l++) {
+                                my $f = $lines[$l];
+                                $f =~ s/#.*//;
+                                $f =~ s/^\s+//;
+                                next if ($f =~ /^$/);
+                                last if ($f =~ /^\s*config\s/);
+                                $length++;
+                        }
+                        WARN("please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($length < 4);
+                }
+
 # check we are in a valid source file if not then ignore this hunk
                 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
 
 #80 column limit
                 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
                     $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
-                    $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
+                    $line !~ /^\+\s*$logFunctions\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
                     $length > 80)
                 {
                         WARN("line over 80 characters\n" . $herecurr);
                 }
 
+# check for spaces before a quoted newline
+                if ($rawline =~ /^.*\".*\s\\n/) {
+                        WARN("unnecessary whitespace before a quoted newline\n" . $herecurr);
+                }
+
 # check for adding lines without a newline.
                 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
                         WARN("adding a line without newline at end of file\n" . $herecurr);
@@ -1411,6 +1442,12 @@ sub process {
                         ERROR("code indent should use tabs where possible\n" . $herevet);
                 }
 
+# check for space before tabs.
+                if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
+                        my $herevet = "$here\n" . cat_vet($rawline) . "\n";
+                        WARN("please, no space before tabs\n" . $herevet);
+                }
+
 # check we are in a valid C source file if not then ignore this hunk
                 next if ($realfile !~ /\.(h|c)$/);
 
@@ -2182,8 +2219,10 @@ sub process {
                                 # Find out how long the conditional actually is.
                                 my @newlines = ($c =~ /\n/gs);
                                 my $cond_lines = 1 + $#newlines;
+                                my $stat_real = '';
 
-                                my $stat_real = raw_line($linenr, $cond_lines);
+                                $stat_real = raw_line($linenr, $cond_lines)
+                                                        . "\n" if ($cond_lines);
                                 if (defined($stat_real) && $cond_lines > 1) {
                                         $stat_real = "[...]\n$stat_real";
                                 }
@@ -2348,6 +2387,8 @@ sub process {
                                 DECLARE_PER_CPU|
                                 DEFINE_PER_CPU|
                                 __typeof__\(|
+                                union|
+                                struct|
                                 \.$Ident\s*=\s*|
                                 ^\"|\"$
                         }x;
@@ -2560,6 +2601,11 @@ sub process {
                         CHK("architecture specific defines should be avoided\n" .  $herecurr);
                 }
 
+# Check that the storage class is at the beginning of a declaration
+                if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
+                        WARN("storage class should be at the beginning of the declaration\n" . $herecurr)
+                }
+
 # check the location of the inline attribute, that it is between
 # storage class and type.
                 if ($line =~ /\b$Type\s+$Inline\b/ ||
@@ -2572,6 +2618,11 @@ sub process {
                         WARN("plain inline is preferred over $1\n" . $herecurr);
                 }
 
+# check for sizeof(&)
+                if ($line =~ /\bsizeof\s*\(\s*\&/) {
+                        WARN("sizeof(& should be avoided\n" . $herecurr);
+                }
+
 # check for new externs in .c files.
                 if ($realfile =~ /\.c$/ && defined $stat &&
                     $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
@@ -2625,6 +2676,7 @@ sub process {
 # check for semaphores used as mutexes
                 if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) {
                         WARN("consider using a completion\n" . $herecurr);
+
                 }
 # recommend strict_strto* over simple_strto*
                 if ($line =~ /\bsimple_(strto.*?)\s*\(/) {
@@ -2634,9 +2686,46 @@ sub process {
                 if ($line =~ /^.\s*__initcall\s*\(/) {
                         WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
                 }
-# check for struct file_operations, ensure they are const.
+# check for various ops structs, ensure they are const.
+                my $struct_ops = qr{acpi_dock_ops|
+                                address_space_operations|
+                                backlight_ops|
+                                block_device_operations|
+                                dentry_operations|
+                                dev_pm_ops|
+                                dma_map_ops|
+                                extent_io_ops|
+                                file_lock_operations|
+                                file_operations|
+                                hv_ops|
+                                ide_dma_ops|
+                                intel_dvo_dev_ops|
+                                item_operations|
+                                iwl_ops|
+                                kgdb_arch|
+                                kgdb_io|
+                                kset_uevent_ops|
+                                lock_manager_operations|
+                                microcode_ops|
+                                mtrr_ops|
+                                neigh_ops|
+                                nlmsvc_binding|
+                                pci_raw_ops|
+                                pipe_buf_operations|
+                                platform_hibernation_ops|
+                                platform_suspend_ops|
+                                proto_ops|
+                                rpc_pipe_ops|
+                                seq_operations|
+                                snd_ac97_build_ops|
+                                soc_pcmcia_socket_ops|
+                                stacktrace_ops|
+                                sysfs_ops|
+                                tty_operations|
+                                usb_mon_operations|
+                                wd_ops}x;
                 if ($line !~ /\bconst\b/ &&
-                    $line =~ /\bstruct\s+(file_operations|seq_operations)\b/) {
+                    $line =~ /\bstruct\s+($struct_ops)\b/) {
                         WARN("struct $1 should normally be const\n" .
                                 $herecurr);
                 }
@@ -2672,6 +2761,16 @@ sub process {
                                 WARN("use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
                         }
                 }
+
+# check for lockdep_set_novalidate_class
+                if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
+                    $line =~ /__lockdep_no_validate__\s*\)/ ) {
+                        if ($realfile !~ m@^kernel/lockdep@ &&
+                            $realfile !~ m@^include/linux/lockdep@ &&
+                            $realfile !~ m@^drivers/base/core@) {
+                                ERROR("lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
+                        }
+                }
         }
 
         # If we have no input at all, then there is nothing to report on