1 files changed, 88 insertions, 62 deletions

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f18750e3bd6c..4d2c7dfdaabd 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -33,6 +33,7 @@ my %ignore_type = ();
 my @ignore = ();
 my $help = 0;
 my $configuration_file = ".checkpatch.conf";
+my $max_line_length = 80;
 
 sub help {
         my ($exitcode) = @_;
@@ -51,6 +52,7 @@ Options:
   -f, --file                 treat FILE as regular source file
   --subjective, --strict     enable more subjective tests
   --ignore TYPE(,TYPE2...)   ignore various comma separated message types
+  --max-line-length=n        set the maximum line length, if exceeded, warn
   --show-types               show the message "types" in the output
   --root=PATH                PATH to the kernel tree root
   --no-summary               suppress the per-file summary
@@ -107,6 +109,7 @@ GetOptions(
         'strict!'       => \$check,
         'ignore=s'      => \@ignore,
         'show-types!'   => \$show_types,
+        'max-line-length=i' => \$max_line_length,
         'root=s'        => \$root,
         'summary!'      => \$summary,
         'mailback!'     => \$mailback,
@@ -227,7 +230,11 @@ our $Inline	= qr{inline|__always_inline|noinline};
 our $Member     = qr{->$Ident|\.$Ident|\[[^]]*\]};
 our $Lval       = qr{$Ident(?:$Member)*};
 
-our $Constant   = qr{(?i:(?:[0-9]+|0x[0-9a-f]+)[ul]*)};
+our $Float_hex  = qr{(?i:0x[0-9a-f]+p-?[0-9]+[fl]?)};
+our $Float_dec  = qr{(?i:((?:[0-9]+\.[0-9]*|[0-9]*\.[0-9]+)(?:e-?[0-9]+)?[fl]?))};
+our $Float_int  = qr{(?i:[0-9]+e-?[0-9]+[fl]?)};
+our $Float      = qr{$Float_hex|$Float_dec|$Float_int};
+our $Constant   = qr{(?:$Float|(?i:(?:0x[0-9a-f]+|[0-9]+)[ul]*))};
 our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
 our $Compare    = qr{<=|>=|==|!=|<|>};
 our $Operators  = qr{
@@ -352,27 +359,6 @@ sub deparenthesize {
 
 $chk_signoff = 0 if ($file);
 
-my @dep_includes = ();
-my @dep_functions = ();
-my $removal = "Documentation/feature-removal-schedule.txt";
-if ($tree && -f "$root/$removal") {
-        open(my $REMOVE, '<', "$root/$removal") ||
-                                die "$P: $removal: open failed - $!\n";
-        while (<$REMOVE>) {
-                if (/^Check:\s+(.*\S)/) {
-                        for my $entry (split(/[, ]+/, $1)) {
-                                if ($entry =~ m@include/(.*)@) {
-                                        push(@dep_includes, $1);
-
-                                } elsif ($entry !~ m@/@) {
-                                        push(@dep_functions, $entry);
-                                }
-                        }
-                }
-        }
-        close($REMOVE);
-}
-
 my @rawlines = ();
 my @lines = ();
 my $vname;
@@ -1412,6 +1398,8 @@ sub process {
         my %suppress_export;
         my $suppress_statement = 0;
 
+        my %camelcase = ();
+
         # Pre-scan the patch sanitizing the lines.
         # Pre-scan the patch looking for any __setup documentation.
         #
@@ -1757,6 +1745,13 @@ sub process {
                         #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
                 }
 
+# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
+                if ($realfile =~ /Kconfig/ &&
+                    $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
+                        WARN("CONFIG_EXPERIMENTAL",
+                             "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
+                }
+
                 if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
                     ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
                         my $flag = $1;
@@ -1774,15 +1769,15 @@ sub process {
 # check we are in a valid source file if not then ignore this hunk
                 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
 
-#80 column limit
+#line length limit
                 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
                     $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
                     !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
                     $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
-                    $length > 80)
+                    $length > $max_line_length)
                 {
                         WARN("LONG_LINE",
-                             "line over 80 characters\n" . $herecurr);
+                             "line over $max_line_length characters\n" . $herecurr);
                 }
 
 # Check for user-visible strings broken across lines, which breaks the ability
@@ -1912,6 +1907,12 @@ sub process {
 # check we are in a valid C source file if not then ignore this hunk
                 next if ($realfile !~ /\.(h|c)$/);
 
+# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
+                if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
+                        WARN("CONFIG_EXPERIMENTAL",
+                             "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
+                }
+
 # check for RCS/CVS revision markers
                 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
                         WARN("CVS_KEYWORD",
@@ -2225,8 +2226,11 @@ sub process {
                         my $path = $1;
                         if ($path =~ m{//}) {
                                 ERROR("MALFORMED_INCLUDE",
-                                      "malformed #include filename\n" .
-                                        $herecurr);
+                                      "malformed #include filename\n" . $herecurr);
+                        }
+                        if ($path =~ "^uapi/" && $realfile =~ m@\binclude/uapi/@) {
+                                ERROR("UAPI_INCLUDE",
+                                      "No #include in ...include/uapi/... should use a uapi/ path prefix\n" . $herecurr);
                         }
                 }
 
@@ -2906,12 +2910,17 @@ sub process {
                         }
                 }
 
-#studly caps, commented out until figure out how to distinguish between use of existing and adding new
-#               if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
-#                   print "No studly caps, use _\n";
-#                   print "$herecurr";
-#                   $clean = 0;
-#               }
+#CamelCase
+                while ($line =~ m{($Constant|$Lval)}g) {
+                        my $var = $1;
+                        if ($var !~ /$Constant/ &&
+                            $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
+                            !defined $camelcase{$var}) {
+                                $camelcase{$var} = 1;
+                                WARN("CAMELCASE",
+                                     "Avoid CamelCase: <$var>\n" . $herecurr);
+                        }
+                }
 
 #no spaces allowed after \ in define
                 if ($line=~/\#\s*define.*\\\s$/) {
@@ -3013,6 +3022,17 @@ sub process {
                                               "Macros with complex values should be enclosed in parenthesis\n" . "$herectx");
                                 }
                         }
+
+# check for line continuations outside of #defines, preprocessor #, and asm
+
+                } else {
+                        if ($prevline !~ /^..*\\$/ &&
+                            $line !~ /^\+\s*\#.*\\$/ &&         # preprocessor
+                            $line !~ /^\+.*\b(__asm__|asm)\b.*\\$/ &&   # asm
+                            $line =~ /^\+.*\\$/) {
+                                WARN("LINE_CONTINUATIONS",
+                                     "Avoid unnecessary line continuations\n" . $herecurr);
+                        }
                 }
 
 # do {} while (0) macro tests:
@@ -3183,20 +3203,14 @@ sub process {
                         }
                 }
 
-# don't include deprecated include files (uses RAW line)
-                for my $inc (@dep_includes) {
-                        if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
-                                ERROR("DEPRECATED_INCLUDE",
-                                      "Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
-                        }
+# check for unnecessary blank lines around braces
+                if (($line =~ /^..*}\s*$/ && $prevline =~ /^.\s*$/)) {
+                        CHK("BRACES",
+                            "Blank lines aren't necessary before a close brace '}'\n" . $hereprev);
                 }
-
-# don't use deprecated functions
-                for my $func (@dep_functions) {
-                        if ($line =~ /\b$func\b/) {
-                                ERROR("DEPRECATED_FUNCTION",
-                                      "Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
-                        }
+                if (($line =~ /^.\s*$/ && $prevline =~ /^..*{\s*$/)) {
+                        CHK("BRACES",
+                            "Blank lines aren't necessary after an open brace '{'\n" . $hereprev);
                 }
 
 # no volatiles please
@@ -3213,20 +3227,12 @@ sub process {
                                 $herecurr);
                 }
 
-# check for needless kfree() checks
-                if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
-                        my $expr = $1;
-                        if ($line =~ /\bkfree\(\Q$expr\E\);/) {
-                                WARN("NEEDLESS_KFREE",
-                                     "kfree(NULL) is safe this check is probably not required\n" . $hereprev);
-                        }
-                }
-# check for needless usb_free_urb() checks
-                if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
-                        my $expr = $1;
-                        if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
-                                WARN("NEEDLESS_USB_FREE_URB",
-                                     "usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
+# check for needless "if (<foo>) fn(<foo>)" uses
+                if ($prevline =~ /\bif\s*\(\s*($Lval)\s*\)/) {
+                        my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;';
+                        if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
+                                WARN('NEEDLESS_IF',
+                                     "$1(NULL) is safe this check is probably not required\n" . $hereprev);
                         }
                 }
 
@@ -3344,6 +3350,12 @@ sub process {
                              "Avoid line continuations in quoted strings\n" . $herecurr);
                 }
 
+# check for struct spinlock declarations
+                if ($line =~ /^.\s*\bstruct\s+spinlock\s+\w+\s*;/) {
+                        WARN("USE_SPINLOCK_T",
+                             "struct spinlock should be spinlock_t\n" . $herecurr);
+                }
+
 # Check for misused memsets
                 if ($^V && $^V ge 5.10.0 &&
                     defined $stat &&
@@ -3450,8 +3462,22 @@ sub process {
 
 # check for multiple semicolons
                 if ($line =~ /;\s*;\s*$/) {
-                    WARN("ONE_SEMICOLON",
-                         "Statements terminations use 1 semicolon\n" . $herecurr);
+                        WARN("ONE_SEMICOLON",
+                             "Statements terminations use 1 semicolon\n" . $herecurr);
+                }
+
+# check for switch/default statements without a break;
+                if ($^V && $^V ge 5.10.0 &&
+                    defined $stat &&
+                    $stat =~ /^\+[$;\s]*(?:case[$;\s]+\w+[$;\s]*:[$;\s]*|)*[$;\s]*\bdefault[$;\s]*:[$;\s]*;/g) {
+                        my $ctx = '';
+                        my $herectx = $here . "\n";
+                        my $cnt = statement_rawlines($stat);
+                        for (my $n = 0; $n < $cnt; $n++) {
+                                $herectx .= raw_line($linenr, $n) . "\n";
+                        }
+                        WARN("DEFAULT_NO_BREAK",
+                             "switch default: should use break\n" . $herectx);
                 }
 
 # check for gcc specific __FUNCTION__