diff options
Diffstat (limited to 'net/tipc')
| -rw-r--r-- | net/tipc/core.c | 7 | ||||
| -rw-r--r-- | net/tipc/handler.c | 11 | ||||
| -rw-r--r-- | net/tipc/socket.c | 6 |
3 files changed, 12 insertions, 12 deletions
diff --git a/net/tipc/core.c b/net/tipc/core.c index fd4eeeaa972a..c6d3f75a9e1b 100644 --- a/net/tipc/core.c +++ b/net/tipc/core.c | |||
| @@ -113,7 +113,6 @@ err: | |||
| 113 | static void tipc_core_stop(void) | 113 | static void tipc_core_stop(void) |
| 114 | { | 114 | { |
| 115 | tipc_netlink_stop(); | 115 | tipc_netlink_stop(); |
| 116 | tipc_handler_stop(); | ||
| 117 | tipc_cfg_stop(); | 116 | tipc_cfg_stop(); |
| 118 | tipc_subscr_stop(); | 117 | tipc_subscr_stop(); |
| 119 | tipc_nametbl_stop(); | 118 | tipc_nametbl_stop(); |
| @@ -146,9 +145,10 @@ static int tipc_core_start(void) | |||
| 146 | res = tipc_subscr_start(); | 145 | res = tipc_subscr_start(); |
| 147 | if (!res) | 146 | if (!res) |
| 148 | res = tipc_cfg_init(); | 147 | res = tipc_cfg_init(); |
| 149 | if (res) | 148 | if (res) { |
| 149 | tipc_handler_stop(); | ||
| 150 | tipc_core_stop(); | 150 | tipc_core_stop(); |
| 151 | 151 | } | |
| 152 | return res; | 152 | return res; |
| 153 | } | 153 | } |
| 154 | 154 | ||
| @@ -178,6 +178,7 @@ static int __init tipc_init(void) | |||
| 178 | 178 | ||
| 179 | static void __exit tipc_exit(void) | 179 | static void __exit tipc_exit(void) |
| 180 | { | 180 | { |
| 181 | tipc_handler_stop(); | ||
| 181 | tipc_core_stop_net(); | 182 | tipc_core_stop_net(); |
| 182 | tipc_core_stop(); | 183 | tipc_core_stop(); |
| 183 | pr_info("Deactivated\n"); | 184 | pr_info("Deactivated\n"); |
diff --git a/net/tipc/handler.c b/net/tipc/handler.c index b36f0fcd9bdf..e4bc8a296744 100644 --- a/net/tipc/handler.c +++ b/net/tipc/handler.c | |||
| @@ -56,12 +56,13 @@ unsigned int tipc_k_signal(Handler routine, unsigned long argument) | |||
| 56 | { | 56 | { |
| 57 | struct queue_item *item; | 57 | struct queue_item *item; |
| 58 | 58 | ||
| 59 | spin_lock_bh(&qitem_lock); | ||
| 59 | if (!handler_enabled) { | 60 | if (!handler_enabled) { |
| 60 | pr_err("Signal request ignored by handler\n"); | 61 | pr_err("Signal request ignored by handler\n"); |
| 62 | spin_unlock_bh(&qitem_lock); | ||
| 61 | return -ENOPROTOOPT; | 63 | return -ENOPROTOOPT; |
| 62 | } | 64 | } |
| 63 | 65 | ||
| 64 | spin_lock_bh(&qitem_lock); | ||
| 65 | item = kmem_cache_alloc(tipc_queue_item_cache, GFP_ATOMIC); | 66 | item = kmem_cache_alloc(tipc_queue_item_cache, GFP_ATOMIC); |
| 66 | if (!item) { | 67 | if (!item) { |
| 67 | pr_err("Signal queue out of memory\n"); | 68 | pr_err("Signal queue out of memory\n"); |
| @@ -112,10 +113,14 @@ void tipc_handler_stop(void) | |||
| 112 | struct list_head *l, *n; | 113 | struct list_head *l, *n; |
| 113 | struct queue_item *item; | 114 | struct queue_item *item; |
| 114 | 115 | ||
| 115 | if (!handler_enabled) | 116 | spin_lock_bh(&qitem_lock); |
| 117 | if (!handler_enabled) { | ||
| 118 | spin_unlock_bh(&qitem_lock); | ||
| 116 | return; | 119 | return; |
| 117 | 120 | } | |
| 118 | handler_enabled = 0; | 121 | handler_enabled = 0; |
| 122 | spin_unlock_bh(&qitem_lock); | ||
| 123 | |||
| 119 | tasklet_kill(&tipc_tasklet); | 124 | tasklet_kill(&tipc_tasklet); |
| 120 | 125 | ||
| 121 | spin_lock_bh(&qitem_lock); | 126 | spin_lock_bh(&qitem_lock); |
diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 3906527259d1..3b61851bb927 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c | |||
| @@ -980,9 +980,6 @@ static int recv_msg(struct kiocb *iocb, struct socket *sock, | |||
| 980 | goto exit; | 980 | goto exit; |
| 981 | } | 981 | } |
| 982 | 982 | ||
| 983 | /* will be updated in set_orig_addr() if needed */ | ||
| 984 | m->msg_namelen = 0; | ||
| 985 | |||
| 986 | timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); | 983 | timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); |
| 987 | restart: | 984 | restart: |
| 988 | 985 | ||
| @@ -1091,9 +1088,6 @@ static int recv_stream(struct kiocb *iocb, struct socket *sock, | |||
| 1091 | goto exit; | 1088 | goto exit; |
| 1092 | } | 1089 | } |
| 1093 | 1090 | ||
| 1094 | /* will be updated in set_orig_addr() if needed */ | ||
| 1095 | m->msg_namelen = 0; | ||
| 1096 | |||
| 1097 | target = sock_rcvlowat(sk, flags & MSG_WAITALL, buf_len); | 1091 | target = sock_rcvlowat(sk, flags & MSG_WAITALL, buf_len); |
| 1098 | timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); | 1092 | timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); |
| 1099 | 1093 | ||
