diff options
Diffstat (limited to 'net/sctp/output.c')
-rw-r--r-- | net/sctp/output.c | 22 |
1 files changed, 13 insertions, 9 deletions
diff --git a/net/sctp/output.c b/net/sctp/output.c index 84b5b370b09d..931371633464 100644 --- a/net/sctp/output.c +++ b/net/sctp/output.c | |||
@@ -108,7 +108,7 @@ struct sctp_packet *sctp_packet_init(struct sctp_packet *packet, | |||
108 | packet->transport = transport; | 108 | packet->transport = transport; |
109 | packet->source_port = sport; | 109 | packet->source_port = sport; |
110 | packet->destination_port = dport; | 110 | packet->destination_port = dport; |
111 | skb_queue_head_init(&packet->chunks); | 111 | INIT_LIST_HEAD(&packet->chunk_list); |
112 | if (asoc) { | 112 | if (asoc) { |
113 | struct sctp_sock *sp = sctp_sk(asoc->base.sk); | 113 | struct sctp_sock *sp = sctp_sk(asoc->base.sk); |
114 | overhead = sp->pf->af->net_header_len; | 114 | overhead = sp->pf->af->net_header_len; |
@@ -129,12 +129,14 @@ struct sctp_packet *sctp_packet_init(struct sctp_packet *packet, | |||
129 | /* Free a packet. */ | 129 | /* Free a packet. */ |
130 | void sctp_packet_free(struct sctp_packet *packet) | 130 | void sctp_packet_free(struct sctp_packet *packet) |
131 | { | 131 | { |
132 | struct sctp_chunk *chunk; | 132 | struct sctp_chunk *chunk, *tmp; |
133 | 133 | ||
134 | SCTP_DEBUG_PRINTK("%s: packet:%p\n", __FUNCTION__, packet); | 134 | SCTP_DEBUG_PRINTK("%s: packet:%p\n", __FUNCTION__, packet); |
135 | 135 | ||
136 | while ((chunk = (struct sctp_chunk *)__skb_dequeue(&packet->chunks)) != NULL) | 136 | list_for_each_entry_safe(chunk, tmp, &packet->chunk_list, list) { |
137 | list_del_init(&chunk->list); | ||
137 | sctp_chunk_free(chunk); | 138 | sctp_chunk_free(chunk); |
139 | } | ||
138 | 140 | ||
139 | if (packet->malloced) | 141 | if (packet->malloced) |
140 | kfree(packet); | 142 | kfree(packet); |
@@ -276,7 +278,7 @@ append: | |||
276 | packet->has_sack = 1; | 278 | packet->has_sack = 1; |
277 | 279 | ||
278 | /* It is OK to send this chunk. */ | 280 | /* It is OK to send this chunk. */ |
279 | __skb_queue_tail(&packet->chunks, (struct sk_buff *)chunk); | 281 | list_add_tail(&chunk->list, &packet->chunk_list); |
280 | packet->size += chunk_len; | 282 | packet->size += chunk_len; |
281 | chunk->transport = packet->transport; | 283 | chunk->transport = packet->transport; |
282 | finish: | 284 | finish: |
@@ -295,7 +297,7 @@ int sctp_packet_transmit(struct sctp_packet *packet) | |||
295 | struct sctphdr *sh; | 297 | struct sctphdr *sh; |
296 | __u32 crc32; | 298 | __u32 crc32; |
297 | struct sk_buff *nskb; | 299 | struct sk_buff *nskb; |
298 | struct sctp_chunk *chunk; | 300 | struct sctp_chunk *chunk, *tmp; |
299 | struct sock *sk; | 301 | struct sock *sk; |
300 | int err = 0; | 302 | int err = 0; |
301 | int padding; /* How much padding do we need? */ | 303 | int padding; /* How much padding do we need? */ |
@@ -305,11 +307,11 @@ int sctp_packet_transmit(struct sctp_packet *packet) | |||
305 | SCTP_DEBUG_PRINTK("%s: packet:%p\n", __FUNCTION__, packet); | 307 | SCTP_DEBUG_PRINTK("%s: packet:%p\n", __FUNCTION__, packet); |
306 | 308 | ||
307 | /* Do NOT generate a chunkless packet. */ | 309 | /* Do NOT generate a chunkless packet. */ |
308 | chunk = (struct sctp_chunk *)skb_peek(&packet->chunks); | 310 | if (list_empty(&packet->chunk_list)) |
309 | if (unlikely(!chunk)) | ||
310 | return err; | 311 | return err; |
311 | 312 | ||
312 | /* Set up convenience variables... */ | 313 | /* Set up convenience variables... */ |
314 | chunk = list_entry(packet->chunk_list.next, struct sctp_chunk, list); | ||
313 | sk = chunk->skb->sk; | 315 | sk = chunk->skb->sk; |
314 | 316 | ||
315 | /* Allocate the new skb. */ | 317 | /* Allocate the new skb. */ |
@@ -370,7 +372,8 @@ int sctp_packet_transmit(struct sctp_packet *packet) | |||
370 | * [This whole comment explains WORD_ROUND() below.] | 372 | * [This whole comment explains WORD_ROUND() below.] |
371 | */ | 373 | */ |
372 | SCTP_DEBUG_PRINTK("***sctp_transmit_packet***\n"); | 374 | SCTP_DEBUG_PRINTK("***sctp_transmit_packet***\n"); |
373 | while ((chunk = (struct sctp_chunk *)__skb_dequeue(&packet->chunks)) != NULL) { | 375 | list_for_each_entry_safe(chunk, tmp, &packet->chunk_list, list) { |
376 | list_del_init(&chunk->list); | ||
374 | if (sctp_chunk_is_data(chunk)) { | 377 | if (sctp_chunk_is_data(chunk)) { |
375 | 378 | ||
376 | if (!chunk->has_tsn) { | 379 | if (!chunk->has_tsn) { |
@@ -511,7 +514,8 @@ err: | |||
511 | * will get resent or dropped later. | 514 | * will get resent or dropped later. |
512 | */ | 515 | */ |
513 | 516 | ||
514 | while ((chunk = (struct sctp_chunk *)__skb_dequeue(&packet->chunks)) != NULL) { | 517 | list_for_each_entry_safe(chunk, tmp, &packet->chunk_list, list) { |
518 | list_del_init(&chunk->list); | ||
515 | if (!sctp_chunk_is_data(chunk)) | 519 | if (!sctp_chunk_is_data(chunk)) |
516 | sctp_chunk_free(chunk); | 520 | sctp_chunk_free(chunk); |
517 | } | 521 | } |