diff options
Diffstat (limited to 'net/irda/irlap_frame.c')
-rw-r--r-- | net/irda/irlap_frame.c | 30 |
1 files changed, 14 insertions, 16 deletions
diff --git a/net/irda/irlap_frame.c b/net/irda/irlap_frame.c index a37998c6273d..90ef03658a74 100644 --- a/net/irda/irlap_frame.c +++ b/net/irda/irlap_frame.c | |||
@@ -421,7 +421,7 @@ static void irlap_recv_discovery_xid_rsp(struct irlap_cb *self, | |||
421 | IRDA_ASSERT(self->magic == LAP_MAGIC, return;); | 421 | IRDA_ASSERT(self->magic == LAP_MAGIC, return;); |
422 | 422 | ||
423 | if (!pskb_may_pull(skb, sizeof(struct xid_frame))) { | 423 | if (!pskb_may_pull(skb, sizeof(struct xid_frame))) { |
424 | IRDA_ERROR("%s: frame too short!\n", __func__); | 424 | net_err_ratelimited("%s: frame too short!\n", __func__); |
425 | return; | 425 | return; |
426 | } | 426 | } |
427 | 427 | ||
@@ -438,7 +438,7 @@ static void irlap_recv_discovery_xid_rsp(struct irlap_cb *self, | |||
438 | } | 438 | } |
439 | 439 | ||
440 | if ((discovery = kzalloc(sizeof(discovery_t), GFP_ATOMIC)) == NULL) { | 440 | if ((discovery = kzalloc(sizeof(discovery_t), GFP_ATOMIC)) == NULL) { |
441 | IRDA_WARNING("%s: kmalloc failed!\n", __func__); | 441 | net_warn_ratelimited("%s: kmalloc failed!\n", __func__); |
442 | return; | 442 | return; |
443 | } | 443 | } |
444 | 444 | ||
@@ -492,7 +492,7 @@ static void irlap_recv_discovery_xid_cmd(struct irlap_cb *self, | |||
492 | char *text; | 492 | char *text; |
493 | 493 | ||
494 | if (!pskb_may_pull(skb, sizeof(struct xid_frame))) { | 494 | if (!pskb_may_pull(skb, sizeof(struct xid_frame))) { |
495 | IRDA_ERROR("%s: frame too short!\n", __func__); | 495 | net_err_ratelimited("%s: frame too short!\n", __func__); |
496 | return; | 496 | return; |
497 | } | 497 | } |
498 | 498 | ||
@@ -536,8 +536,8 @@ static void irlap_recv_discovery_xid_cmd(struct irlap_cb *self, | |||
536 | /* Check if things are sane at this point... */ | 536 | /* Check if things are sane at this point... */ |
537 | if((discovery_info == NULL) || | 537 | if((discovery_info == NULL) || |
538 | !pskb_may_pull(skb, 3)) { | 538 | !pskb_may_pull(skb, 3)) { |
539 | IRDA_ERROR("%s: discovery frame too short!\n", | 539 | net_err_ratelimited("%s: discovery frame too short!\n", |
540 | __func__); | 540 | __func__); |
541 | return; | 541 | return; |
542 | } | 542 | } |
543 | 543 | ||
@@ -545,10 +545,8 @@ static void irlap_recv_discovery_xid_cmd(struct irlap_cb *self, | |||
545 | * We now have some discovery info to deliver! | 545 | * We now have some discovery info to deliver! |
546 | */ | 546 | */ |
547 | discovery = kzalloc(sizeof(discovery_t), GFP_ATOMIC); | 547 | discovery = kzalloc(sizeof(discovery_t), GFP_ATOMIC); |
548 | if (!discovery) { | 548 | if (!discovery) |
549 | IRDA_WARNING("%s: unable to malloc!\n", __func__); | ||
550 | return; | 549 | return; |
551 | } | ||
552 | 550 | ||
553 | discovery->data.daddr = info->daddr; | 551 | discovery->data.daddr = info->daddr; |
554 | discovery->data.saddr = self->saddr; | 552 | discovery->data.saddr = self->saddr; |
@@ -1170,7 +1168,7 @@ static void irlap_recv_frmr_frame(struct irlap_cb *self, struct sk_buff *skb, | |||
1170 | IRDA_ASSERT(info != NULL, return;); | 1168 | IRDA_ASSERT(info != NULL, return;); |
1171 | 1169 | ||
1172 | if (!pskb_may_pull(skb, 4)) { | 1170 | if (!pskb_may_pull(skb, 4)) { |
1173 | IRDA_ERROR("%s: frame too short!\n", __func__); | 1171 | net_err_ratelimited("%s: frame too short!\n", __func__); |
1174 | return; | 1172 | return; |
1175 | } | 1173 | } |
1176 | 1174 | ||
@@ -1259,7 +1257,7 @@ static void irlap_recv_test_frame(struct irlap_cb *self, struct sk_buff *skb, | |||
1259 | IRDA_DEBUG(2, "%s()\n", __func__); | 1257 | IRDA_DEBUG(2, "%s()\n", __func__); |
1260 | 1258 | ||
1261 | if (!pskb_may_pull(skb, sizeof(*frame))) { | 1259 | if (!pskb_may_pull(skb, sizeof(*frame))) { |
1262 | IRDA_ERROR("%s: frame too short!\n", __func__); | 1260 | net_err_ratelimited("%s: frame too short!\n", __func__); |
1263 | return; | 1261 | return; |
1264 | } | 1262 | } |
1265 | frame = (struct test_frame *) skb->data; | 1263 | frame = (struct test_frame *) skb->data; |
@@ -1328,13 +1326,13 @@ int irlap_driver_rcv(struct sk_buff *skb, struct net_device *dev, | |||
1328 | * share and non linear skbs. This should never happen, so | 1326 | * share and non linear skbs. This should never happen, so |
1329 | * we don't need to be clever about it. Jean II */ | 1327 | * we don't need to be clever about it. Jean II */ |
1330 | if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) { | 1328 | if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) { |
1331 | IRDA_ERROR("%s: can't clone shared skb!\n", __func__); | 1329 | net_err_ratelimited("%s: can't clone shared skb!\n", __func__); |
1332 | goto err; | 1330 | goto err; |
1333 | } | 1331 | } |
1334 | 1332 | ||
1335 | /* Check if frame is large enough for parsing */ | 1333 | /* Check if frame is large enough for parsing */ |
1336 | if (!pskb_may_pull(skb, 2)) { | 1334 | if (!pskb_may_pull(skb, 2)) { |
1337 | IRDA_ERROR("%s: frame too short!\n", __func__); | 1335 | net_err_ratelimited("%s: frame too short!\n", __func__); |
1338 | goto err; | 1336 | goto err; |
1339 | } | 1337 | } |
1340 | 1338 | ||
@@ -1383,8 +1381,8 @@ int irlap_driver_rcv(struct sk_buff *skb, struct net_device *dev, | |||
1383 | irlap_recv_srej_frame(self, skb, &info, command); | 1381 | irlap_recv_srej_frame(self, skb, &info, command); |
1384 | break; | 1382 | break; |
1385 | default: | 1383 | default: |
1386 | IRDA_WARNING("%s: Unknown S-frame %02x received!\n", | 1384 | net_warn_ratelimited("%s: Unknown S-frame %02x received!\n", |
1387 | __func__, info.control); | 1385 | __func__, info.control); |
1388 | break; | 1386 | break; |
1389 | } | 1387 | } |
1390 | goto out; | 1388 | goto out; |
@@ -1421,8 +1419,8 @@ int irlap_driver_rcv(struct sk_buff *skb, struct net_device *dev, | |||
1421 | irlap_recv_ui_frame(self, skb, &info); | 1419 | irlap_recv_ui_frame(self, skb, &info); |
1422 | break; | 1420 | break; |
1423 | default: | 1421 | default: |
1424 | IRDA_WARNING("%s: Unknown frame %02x received!\n", | 1422 | net_warn_ratelimited("%s: Unknown frame %02x received!\n", |
1425 | __func__, info.control); | 1423 | __func__, info.control); |
1426 | break; | 1424 | break; |
1427 | } | 1425 | } |
1428 | out: | 1426 | out: |