1 files changed, 231 insertions, 192 deletions

diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 6585ea6d1182..74544bc6fdec 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -93,7 +93,7 @@
 
 struct dn_rt_hash_bucket
 {
-        struct dn_route *chain;
+        struct dn_route __rcu *chain;
         spinlock_t lock;
 };
 
@@ -110,6 +110,9 @@ static unsigned long dn_rt_deadline;
 
 static int dn_dst_gc(struct dst_ops *ops);
 static struct dst_entry *dn_dst_check(struct dst_entry *, __u32);
+static unsigned int dn_dst_default_advmss(const struct dst_entry *dst);
+static unsigned int dn_dst_default_mtu(const struct dst_entry *dst);
+static void dn_dst_destroy(struct dst_entry *);
 static struct dst_entry *dn_dst_negative_advice(struct dst_entry *);
 static void dn_dst_link_failure(struct sk_buff *);
 static void dn_dst_update_pmtu(struct dst_entry *dst, u32 mtu);
@@ -129,12 +132,20 @@ static struct dst_ops dn_dst_ops = {
         .gc_thresh =            128,
         .gc =                   dn_dst_gc,
         .check =                dn_dst_check,
+        .default_advmss =       dn_dst_default_advmss,
+        .default_mtu =          dn_dst_default_mtu,
+        .cow_metrics =          dst_cow_metrics_generic,
+        .destroy =              dn_dst_destroy,
         .negative_advice =      dn_dst_negative_advice,
         .link_failure =         dn_dst_link_failure,
         .update_pmtu =          dn_dst_update_pmtu,
-        .entries =              ATOMIC_INIT(0),
 };
 
+static void dn_dst_destroy(struct dst_entry *dst)
+{
+        dst_destroy_metrics_generic(dst);
+}
+
 static __inline__ unsigned dn_hash(__le16 src, __le16 dst)
 {
         __u16 tmp = (__u16 __force)(src ^ dst);
@@ -158,15 +169,17 @@ static inline void dnrt_drop(struct dn_route *rt)
 static void dn_dst_check_expire(unsigned long dummy)
 {
         int i;
-        struct dn_route *rt, **rtp;
+        struct dn_route *rt;
+        struct dn_route __rcu **rtp;
         unsigned long now = jiffies;
         unsigned long expire = 120 * HZ;
 
-        for(i = 0; i <= dn_rt_hash_mask; i++) {
+        for (i = 0; i <= dn_rt_hash_mask; i++) {
                 rtp = &dn_rt_hash_table[i].chain;
 
                 spin_lock(&dn_rt_hash_table[i].lock);
-                while((rt=*rtp) != NULL) {
+                while ((rt = rcu_dereference_protected(*rtp,
+                                                lockdep_is_held(&dn_rt_hash_table[i].lock))) != NULL) {
                         if (atomic_read(&rt->dst.__refcnt) ||
                                         (now - rt->dst.lastuse) < expire) {
                                 rtp = &rt->dst.dn_next;
@@ -187,17 +200,19 @@ static void dn_dst_check_expire(unsigned long dummy)
 
 static int dn_dst_gc(struct dst_ops *ops)
 {
-        struct dn_route *rt, **rtp;
+        struct dn_route *rt;
+        struct dn_route __rcu **rtp;
         int i;
         unsigned long now = jiffies;
         unsigned long expire = 10 * HZ;
 
-        for(i = 0; i <= dn_rt_hash_mask; i++) {
+        for (i = 0; i <= dn_rt_hash_mask; i++) {
 
                 spin_lock_bh(&dn_rt_hash_table[i].lock);
                 rtp = &dn_rt_hash_table[i].chain;
 
-                while((rt=*rtp) != NULL) {
+                while ((rt = rcu_dereference_protected(*rtp,
+                                                lockdep_is_held(&dn_rt_hash_table[i].lock))) != NULL) {
                         if (atomic_read(&rt->dst.__refcnt) ||
                                         (now - rt->dst.lastuse) < expire) {
                                 rtp = &rt->dst.dn_next;
@@ -228,7 +243,7 @@ static void dn_dst_update_pmtu(struct dst_entry *dst, u32 mtu)
 {
         u32 min_mtu = 230;
         struct dn_dev *dn = dst->neighbour ?
-                            (struct dn_dev *)dst->neighbour->dev->dn_ptr : NULL;
+                            rcu_dereference_raw(dst->neighbour->dev->dn_ptr) : NULL;
 
         if (dn && dn->use_long == 0)
                 min_mtu -= 6;
@@ -237,13 +252,14 @@ static void dn_dst_update_pmtu(struct dst_entry *dst, u32 mtu)
 
         if (dst_metric(dst, RTAX_MTU) > mtu && mtu >= min_mtu) {
                 if (!(dst_metric_locked(dst, RTAX_MTU))) {
-                        dst->metrics[RTAX_MTU-1] = mtu;
+                        dst_metric_set(dst, RTAX_MTU, mtu);
                         dst_set_expires(dst, dn_rt_mtu_expires);
                 }
                 if (!(dst_metric_locked(dst, RTAX_ADVMSS))) {
                         u32 mss = mtu - DN_MAX_NSP_DATA_HEADER;
-                        if (dst_metric(dst, RTAX_ADVMSS) > mss)
-                                dst->metrics[RTAX_ADVMSS-1] = mss;
+                        u32 existing_mss = dst_metric_raw(dst, RTAX_ADVMSS);
+                        if (!existing_mss || existing_mss > mss)
+                                dst_metric_set(dst, RTAX_ADVMSS, mss);
                 }
         }
 }
@@ -266,26 +282,28 @@ static void dn_dst_link_failure(struct sk_buff *skb)
 {
 }
 
-static inline int compare_keys(struct flowi *fl1, struct flowi *fl2)
+static inline int compare_keys(struct flowidn *fl1, struct flowidn *fl2)
 {
-        return ((fl1->nl_u.dn_u.daddr ^ fl2->nl_u.dn_u.daddr) |
-                (fl1->nl_u.dn_u.saddr ^ fl2->nl_u.dn_u.saddr) |
-                (fl1->mark ^ fl2->mark) |
-                (fl1->nl_u.dn_u.scope ^ fl2->nl_u.dn_u.scope) |
-                (fl1->oif ^ fl2->oif) |
-                (fl1->iif ^ fl2->iif)) == 0;
+        return ((fl1->daddr ^ fl2->daddr) |
+                (fl1->saddr ^ fl2->saddr) |
+                (fl1->flowidn_mark ^ fl2->flowidn_mark) |
+                (fl1->flowidn_scope ^ fl2->flowidn_scope) |
+                (fl1->flowidn_oif ^ fl2->flowidn_oif) |
+                (fl1->flowidn_iif ^ fl2->flowidn_iif)) == 0;
 }
 
 static int dn_insert_route(struct dn_route *rt, unsigned hash, struct dn_route **rp)
 {
-        struct dn_route *rth, **rthp;
+        struct dn_route *rth;
+        struct dn_route __rcu **rthp;
         unsigned long now = jiffies;
 
         rthp = &dn_rt_hash_table[hash].chain;
 
         spin_lock_bh(&dn_rt_hash_table[hash].lock);
-        while((rth = *rthp) != NULL) {
-                if (compare_keys(&rth->fl, &rt->fl)) {
+        while ((rth = rcu_dereference_protected(*rthp,
+                                                lockdep_is_held(&dn_rt_hash_table[hash].lock))) != NULL) {
+                if (compare_keys(&rth->fld, &rt->fld)) {
                         /* Put it first */
                         *rthp = rth->dst.dn_next;
                         rcu_assign_pointer(rth->dst.dn_next,
@@ -316,15 +334,15 @@ static void dn_run_flush(unsigned long dummy)
         int i;
         struct dn_route *rt, *next;
 
-        for(i = 0; i < dn_rt_hash_mask; i++) {
+        for (i = 0; i < dn_rt_hash_mask; i++) {
                 spin_lock_bh(&dn_rt_hash_table[i].lock);
 
-                if ((rt = xchg(&dn_rt_hash_table[i].chain, NULL)) == NULL)
+                if ((rt = xchg((struct dn_route **)&dn_rt_hash_table[i].chain, NULL)) == NULL)
                         goto nothing_to_declare;
 
-                for(; rt; rt=next) {
-                        next = rt->dst.dn_next;
-                        rt->dst.dn_next = NULL;
+                for(; rt; rt = next) {
+                        next = rcu_dereference_raw(rt->dst.dn_next);
+                        RCU_INIT_POINTER(rt->dst.dn_next, NULL);
                         dst_free((struct dst_entry *)rt);
                 }
 
@@ -459,15 +477,16 @@ static int dn_return_long(struct sk_buff *skb)
  */
 static int dn_route_rx_packet(struct sk_buff *skb)
 {
-        struct dn_skb_cb *cb = DN_SKB_CB(skb);
+        struct dn_skb_cb *cb;
         int err;
 
         if ((err = dn_route_input(skb)) == 0)
                 return dst_input(skb);
 
+        cb = DN_SKB_CB(skb);
         if (decnet_debug_level & 4) {
                 char *devname = skb->dev ? skb->dev->name : "???";
-                struct dn_skb_cb *cb = DN_SKB_CB(skb);
+
                 printk(KERN_DEBUG
                         "DECnet: dn_route_rx_packet: rt_flags=0x%02x dev=%s len=%d src=0x%04hx dst=0x%04hx err=%d type=%d\n",
                         (int)cb->rt_flags, devname, skb->len,
@@ -574,7 +593,7 @@ int dn_route_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type
         struct dn_skb_cb *cb;
         unsigned char flags = 0;
         __u16 len = le16_to_cpu(*(__le16 *)skb->data);
-        struct dn_dev *dn = (struct dn_dev *)dev->dn_ptr;
+        struct dn_dev *dn = rcu_dereference(dev->dn_ptr);
         unsigned char padlen = 0;
 
         if (!net_eq(dev_net(dev), &init_net))
@@ -729,7 +748,7 @@ static int dn_forward(struct sk_buff *skb)
 {
         struct dn_skb_cb *cb = DN_SKB_CB(skb);
         struct dst_entry *dst = skb_dst(skb);
-        struct dn_dev *dn_db = dst->dev->dn_ptr;
+        struct dn_dev *dn_db = rcu_dereference(dst->dev->dn_ptr);
         struct dn_route *rt;
         struct neighbour *neigh = dst->neighbour;
         int header_len;
@@ -789,19 +808,28 @@ static int dn_rt_bug(struct sk_buff *skb)
         return NET_RX_DROP;
 }
 
+static unsigned int dn_dst_default_advmss(const struct dst_entry *dst)
+{
+        return dn_mss_from_pmtu(dst->dev, dst_mtu(dst));
+}
+
+static unsigned int dn_dst_default_mtu(const struct dst_entry *dst)
+{
+        return dst->dev->mtu;
+}
+
 static int dn_rt_set_next_hop(struct dn_route *rt, struct dn_fib_res *res)
 {
         struct dn_fib_info *fi = res->fi;
         struct net_device *dev = rt->dst.dev;
+        unsigned int mss_metric;
         struct neighbour *n;
-        unsigned mss;
 
         if (fi) {
                 if (DN_FIB_RES_GW(*res) &&
                     DN_FIB_RES_NH(*res).nh_scope == RT_SCOPE_LINK)
                         rt->rt_gateway = DN_FIB_RES_GW(*res);
-                memcpy(rt->dst.metrics, fi->fib_metrics,
-                       sizeof(rt->dst.metrics));
+                dst_init_metrics(&rt->dst, fi->fib_metrics, true);
         }
         rt->rt_type = res->type;
 
@@ -812,13 +840,14 @@ static int dn_rt_set_next_hop(struct dn_route *rt, struct dn_fib_res *res)
                 rt->dst.neighbour = n;
         }
 
-        if (dst_metric(&rt->dst, RTAX_MTU) == 0 ||
-            dst_metric(&rt->dst, RTAX_MTU) > rt->dst.dev->mtu)
-                rt->dst.metrics[RTAX_MTU-1] = rt->dst.dev->mtu;
-        mss = dn_mss_from_pmtu(dev, dst_mtu(&rt->dst));
-        if (dst_metric(&rt->dst, RTAX_ADVMSS) == 0 ||
-            dst_metric(&rt->dst, RTAX_ADVMSS) > mss)
-                rt->dst.metrics[RTAX_ADVMSS-1] = mss;
+        if (dst_metric(&rt->dst, RTAX_MTU) > rt->dst.dev->mtu)
+                dst_metric_set(&rt->dst, RTAX_MTU, rt->dst.dev->mtu);
+        mss_metric = dst_metric_raw(&rt->dst, RTAX_ADVMSS);
+        if (mss_metric) {
+                unsigned int mss = dn_mss_from_pmtu(dev, dst_mtu(&rt->dst));
+                if (mss_metric > mss)
+                        dst_metric_set(&rt->dst, RTAX_ADVMSS, mss);
+        }
         return 0;
 }
 
@@ -836,13 +865,16 @@ static inline int dn_match_addr(__le16 addr1, __le16 addr2)
 static __le16 dnet_select_source(const struct net_device *dev, __le16 daddr, int scope)
 {
         __le16 saddr = 0;
-        struct dn_dev *dn_db = dev->dn_ptr;
+        struct dn_dev *dn_db;
         struct dn_ifaddr *ifa;
         int best_match = 0;
         int ret;
 
-        read_lock(&dev_base_lock);
-        for(ifa = dn_db->ifa_list; ifa; ifa = ifa->ifa_next) {
+        rcu_read_lock();
+        dn_db = rcu_dereference(dev->dn_ptr);
+        for (ifa = rcu_dereference(dn_db->ifa_list);
+             ifa != NULL;
+             ifa = rcu_dereference(ifa->ifa_next)) {
                 if (ifa->ifa_scope > scope)
                         continue;
                 if (!daddr) {
@@ -855,7 +887,7 @@ static __le16 dnet_select_source(const struct net_device *dev, __le16 daddr, int
                 if (best_match == 0)
                         saddr = ifa->ifa_local;
         }
-        read_unlock(&dev_base_lock);
+        rcu_read_unlock();
 
         return saddr;
 }
@@ -871,16 +903,16 @@ static inline __le16 dn_fib_rules_map_destination(__le16 daddr, struct dn_fib_re
         return (daddr&~mask)|res->fi->fib_nh->nh_gw;
 }
 
-static int dn_route_output_slow(struct dst_entry **pprt, const struct flowi *oldflp, int try_hard)
+static int dn_route_output_slow(struct dst_entry **pprt, const struct flowidn *oldflp, int try_hard)
 {
-        struct flowi fl = { .nl_u = { .dn_u =
-                                      { .daddr = oldflp->fld_dst,
-                                        .saddr = oldflp->fld_src,
-                                        .scope = RT_SCOPE_UNIVERSE,
-                                     } },
-                            .mark = oldflp->mark,
-                            .iif = init_net.loopback_dev->ifindex,
-                            .oif = oldflp->oif };
+        struct flowidn fld = {
+                .daddr = oldflp->daddr,
+                .saddr = oldflp->saddr,
+                .flowidn_scope = RT_SCOPE_UNIVERSE,
+                .flowidn_mark = oldflp->flowidn_mark,
+                .flowidn_iif = init_net.loopback_dev->ifindex,
+                .flowidn_oif = oldflp->flowidn_oif,
+        };
         struct dn_route *rt = NULL;
         struct net_device *dev_out = NULL, *dev;
         struct neighbour *neigh = NULL;
@@ -894,13 +926,14 @@ static int dn_route_output_slow(struct dst_entry **pprt, const struct flowi *old
         if (decnet_debug_level & 16)
                 printk(KERN_DEBUG
                        "dn_route_output_slow: dst=%04x src=%04x mark=%d"
-                       " iif=%d oif=%d\n", le16_to_cpu(oldflp->fld_dst),
-                       le16_to_cpu(oldflp->fld_src),
-                       oldflp->mark, init_net.loopback_dev->ifindex, oldflp->oif);
+                       " iif=%d oif=%d\n", le16_to_cpu(oldflp->daddr),
+                       le16_to_cpu(oldflp->saddr),
+                       oldflp->flowidn_mark, init_net.loopback_dev->ifindex,
+                       oldflp->flowidn_oif);
 
         /* If we have an output interface, verify its a DECnet device */
-        if (oldflp->oif) {
-                dev_out = dev_get_by_index(&init_net, oldflp->oif);
+        if (oldflp->flowidn_oif) {
+                dev_out = dev_get_by_index(&init_net, oldflp->flowidn_oif);
                 err = -ENODEV;
                 if (dev_out && dev_out->dn_ptr == NULL) {
                         dev_put(dev_out);
@@ -911,11 +944,11 @@ static int dn_route_output_slow(struct dst_entry **pprt, const struct flowi *old
         }
 
         /* If we have a source address, verify that its a local address */
-        if (oldflp->fld_src) {
+        if (oldflp->saddr) {
                 err = -EADDRNOTAVAIL;
 
                 if (dev_out) {
-                        if (dn_dev_islocal(dev_out, oldflp->fld_src))
+                        if (dn_dev_islocal(dev_out, oldflp->saddr))
                                 goto source_ok;
                         dev_put(dev_out);
                         goto out;
@@ -924,11 +957,11 @@ static int dn_route_output_slow(struct dst_entry **pprt, const struct flowi *old
                 for_each_netdev_rcu(&init_net, dev) {
                         if (!dev->dn_ptr)
                                 continue;
-                        if (!dn_dev_islocal(dev, oldflp->fld_src))
+                        if (!dn_dev_islocal(dev, oldflp->saddr))
                                 continue;
                         if ((dev->flags & IFF_LOOPBACK) &&
-                            oldflp->fld_dst &&
-                            !dn_dev_islocal(dev, oldflp->fld_dst))
+                            oldflp->daddr &&
+                            !dn_dev_islocal(dev, oldflp->daddr))
                                 continue;
 
                         dev_out = dev;
@@ -943,22 +976,22 @@ source_ok:
         }
 
         /* No destination? Assume its local */
-        if (!fl.fld_dst) {
-                fl.fld_dst = fl.fld_src;
+        if (!fld.daddr) {
+                fld.daddr = fld.saddr;
 
                 err = -EADDRNOTAVAIL;
                 if (dev_out)
                         dev_put(dev_out);
                 dev_out = init_net.loopback_dev;
                 dev_hold(dev_out);
-                if (!fl.fld_dst) {
-                        fl.fld_dst =
-                        fl.fld_src = dnet_select_source(dev_out, 0,
+                if (!fld.daddr) {
+                        fld.daddr =
+                        fld.saddr = dnet_select_source(dev_out, 0,
                                                        RT_SCOPE_HOST);
-                        if (!fl.fld_dst)
+                        if (!fld.daddr)
                                 goto out;
                 }
-                fl.oif = init_net.loopback_dev->ifindex;
+                fld.flowidn_oif = init_net.loopback_dev->ifindex;
                 res.type = RTN_LOCAL;
                 goto make_route;
         }
@@ -967,8 +1000,8 @@ source_ok:
                 printk(KERN_DEBUG
                        "dn_route_output_slow: initial checks complete."
                        " dst=%o4x src=%04x oif=%d try_hard=%d\n",
-                       le16_to_cpu(fl.fld_dst), le16_to_cpu(fl.fld_src),
-                       fl.oif, try_hard);
+                       le16_to_cpu(fld.daddr), le16_to_cpu(fld.saddr),
+                       fld.flowidn_oif, try_hard);
 
         /*
          * N.B. If the kernel is compiled without router support then
@@ -976,7 +1009,7 @@ source_ok:
          * will always be executed.
          */
         err = -ESRCH;
-        if (try_hard || (err = dn_fib_lookup(&fl, &res)) != 0) {
+        if (try_hard || (err = dn_fib_lookup(&fld, &res)) != 0) {
                 struct dn_dev *dn_db;
                 if (err != -ESRCH)
                         goto out;
@@ -991,19 +1024,19 @@ source_ok:
                  * here
                  */
                 if (!try_hard) {
-                        neigh = neigh_lookup_nodev(&dn_neigh_table, &init_net, &fl.fld_dst);
+                        neigh = neigh_lookup_nodev(&dn_neigh_table, &init_net, &fld.daddr);
                         if (neigh) {
-                                if ((oldflp->oif &&
-                                    (neigh->dev->ifindex != oldflp->oif)) ||
-                                    (oldflp->fld_src &&
+                                if ((oldflp->flowidn_oif &&
+                                    (neigh->dev->ifindex != oldflp->flowidn_oif)) ||
+                                    (oldflp->saddr &&
                                     (!dn_dev_islocal(neigh->dev,
-                                                      oldflp->fld_src)))) {
+                                                     oldflp->saddr)))) {
                                         neigh_release(neigh);
                                         neigh = NULL;
                                 } else {
                                         if (dev_out)
                                                 dev_put(dev_out);
-                                        if (dn_dev_islocal(neigh->dev, fl.fld_dst)) {
+                                        if (dn_dev_islocal(neigh->dev, fld.daddr)) {
                                                 dev_out = init_net.loopback_dev;
                                                 res.type = RTN_LOCAL;
                                         } else {
@@ -1021,9 +1054,9 @@ source_ok:
                 err = -ENODEV;
                 if (dev_out == NULL)
                         goto out;
-                dn_db = dev_out->dn_ptr;
+                dn_db = rcu_dereference_raw(dev_out->dn_ptr);
                 /* Possible improvement - check all devices for local addr */
-                if (dn_dev_islocal(dev_out, fl.fld_dst)) {
+                if (dn_dev_islocal(dev_out, fld.daddr)) {
                         dev_put(dev_out);
                         dev_out = init_net.loopback_dev;
                         dev_hold(dev_out);
@@ -1039,16 +1072,16 @@ select_source:
                 if (neigh)
                         gateway = ((struct dn_neigh *)neigh)->addr;
                 if (gateway == 0)
-                        gateway = fl.fld_dst;
-                if (fl.fld_src == 0) {
-                        fl.fld_src = dnet_select_source(dev_out, gateway,
-                                                         res.type == RTN_LOCAL ?
-                                                         RT_SCOPE_HOST :
-                                                         RT_SCOPE_LINK);
-                        if (fl.fld_src == 0 && res.type != RTN_LOCAL)
+                        gateway = fld.daddr;
+                if (fld.saddr == 0) {
+                        fld.saddr = dnet_select_source(dev_out, gateway,
+                                                       res.type == RTN_LOCAL ?
+                                                       RT_SCOPE_HOST :
+                                                       RT_SCOPE_LINK);
+                        if (fld.saddr == 0 && res.type != RTN_LOCAL)
                                 goto e_addr;
                 }
-                fl.oif = dev_out->ifindex;
+                fld.flowidn_oif = dev_out->ifindex;
                 goto make_route;
         }
         free_res = 1;
@@ -1057,64 +1090,60 @@ select_source:
                 goto e_inval;
 
         if (res.type == RTN_LOCAL) {
-                if (!fl.fld_src)
-                        fl.fld_src = fl.fld_dst;
+                if (!fld.saddr)
+                        fld.saddr = fld.daddr;
                 if (dev_out)
                         dev_put(dev_out);
                 dev_out = init_net.loopback_dev;
                 dev_hold(dev_out);
-                fl.oif = dev_out->ifindex;
+                fld.flowidn_oif = dev_out->ifindex;
                 if (res.fi)
                         dn_fib_info_put(res.fi);
                 res.fi = NULL;
                 goto make_route;
         }
 
-        if (res.fi->fib_nhs > 1 && fl.oif == 0)
-                dn_fib_select_multipath(&fl, &res);
+        if (res.fi->fib_nhs > 1 && fld.flowidn_oif == 0)
+                dn_fib_select_multipath(&fld, &res);
 
         /*
          * We could add some logic to deal with default routes here and
          * get rid of some of the special casing above.
          */
 
-        if (!fl.fld_src)
-                fl.fld_src = DN_FIB_RES_PREFSRC(res);
+        if (!fld.saddr)
+                fld.saddr = DN_FIB_RES_PREFSRC(res);
 
         if (dev_out)
                 dev_put(dev_out);
         dev_out = DN_FIB_RES_DEV(res);
         dev_hold(dev_out);
-        fl.oif = dev_out->ifindex;
+        fld.flowidn_oif = dev_out->ifindex;
         gateway = DN_FIB_RES_GW(res);
 
 make_route:
         if (dev_out->flags & IFF_LOOPBACK)
                 flags |= RTCF_LOCAL;
 
-        rt = dst_alloc(&dn_dst_ops);
+        rt = dst_alloc(&dn_dst_ops, dev_out, 1, 0, DST_HOST);
         if (rt == NULL)
                 goto e_nobufs;
 
-        atomic_set(&rt->dst.__refcnt, 1);
-        rt->dst.flags   = DST_HOST;
+        memset(&rt->fld, 0, sizeof(rt->fld));
+        rt->fld.saddr        = oldflp->saddr;
+        rt->fld.daddr        = oldflp->daddr;
+        rt->fld.flowidn_oif  = oldflp->flowidn_oif;
+        rt->fld.flowidn_iif  = 0;
+        rt->fld.flowidn_mark = oldflp->flowidn_mark;
 
-        rt->fl.fld_src    = oldflp->fld_src;
-        rt->fl.fld_dst    = oldflp->fld_dst;
-        rt->fl.oif        = oldflp->oif;
-        rt->fl.iif        = 0;
-        rt->fl.mark       = oldflp->mark;
+        rt->rt_saddr      = fld.saddr;
+        rt->rt_daddr      = fld.daddr;
+        rt->rt_gateway    = gateway ? gateway : fld.daddr;
+        rt->rt_local_src  = fld.saddr;
 
-        rt->rt_saddr      = fl.fld_src;
-        rt->rt_daddr      = fl.fld_dst;
-        rt->rt_gateway    = gateway ? gateway : fl.fld_dst;
-        rt->rt_local_src  = fl.fld_src;
+        rt->rt_dst_map    = fld.daddr;
+        rt->rt_src_map    = fld.saddr;
 
-        rt->rt_dst_map    = fl.fld_dst;
-        rt->rt_src_map    = fl.fld_src;
-
-        rt->dst.dev = dev_out;
-        dev_hold(dev_out);
         rt->dst.neighbour = neigh;
         neigh = NULL;
 
@@ -1129,7 +1158,7 @@ make_route:
         if (err)
                 goto e_neighbour;
 
-        hash = dn_hash(rt->fl.fld_src, rt->fl.fld_dst);
+        hash = dn_hash(rt->fld.saddr, rt->fld.daddr);
         dn_insert_route(rt, hash, (struct dn_route **)pprt);
 
 done:
@@ -1160,20 +1189,20 @@ e_neighbour:
 /*
  * N.B. The flags may be moved into the flowi at some future stage.
  */
-static int __dn_route_output_key(struct dst_entry **pprt, const struct flowi *flp, int flags)
+static int __dn_route_output_key(struct dst_entry **pprt, const struct flowidn *flp, int flags)
 {
-        unsigned hash = dn_hash(flp->fld_src, flp->fld_dst);
+        unsigned hash = dn_hash(flp->saddr, flp->daddr);
         struct dn_route *rt = NULL;
 
         if (!(flags & MSG_TRYHARD)) {
                 rcu_read_lock_bh();
                 for (rt = rcu_dereference_bh(dn_rt_hash_table[hash].chain); rt;
                         rt = rcu_dereference_bh(rt->dst.dn_next)) {
-                        if ((flp->fld_dst == rt->fl.fld_dst) &&
-                            (flp->fld_src == rt->fl.fld_src) &&
-                            (flp->mark == rt->fl.mark) &&
-                            (rt->fl.iif == 0) &&
-                            (rt->fl.oif == flp->oif)) {
+                        if ((flp->daddr == rt->fld.daddr) &&
+                            (flp->saddr == rt->fld.saddr) &&
+                            (flp->flowidn_mark == rt->fld.flowidn_mark) &&
+                            dn_is_output_route(rt) &&
+                            (rt->fld.flowidn_oif == flp->flowidn_oif)) {
                                 dst_use(&rt->dst, jiffies);
                                 rcu_read_unlock_bh();
                                 *pprt = &rt->dst;
@@ -1186,25 +1215,36 @@ static int __dn_route_output_key(struct dst_entry **pprt, const struct flowi *fl
         return dn_route_output_slow(pprt, flp, flags);
 }
 
-static int dn_route_output_key(struct dst_entry **pprt, struct flowi *flp, int flags)
+static int dn_route_output_key(struct dst_entry **pprt, struct flowidn *flp, int flags)
 {
         int err;
 
         err = __dn_route_output_key(pprt, flp, flags);
-        if (err == 0 && flp->proto) {
-                err = xfrm_lookup(&init_net, pprt, flp, NULL, 0);
+        if (err == 0 && flp->flowidn_proto) {
+                *pprt = xfrm_lookup(&init_net, *pprt,
+                                    flowidn_to_flowi(flp), NULL, 0);
+                if (IS_ERR(*pprt)) {
+                        err = PTR_ERR(*pprt);
+                        *pprt = NULL;
+                }
         }
         return err;
 }
 
-int dn_route_output_sock(struct dst_entry **pprt, struct flowi *fl, struct sock *sk, int flags)
+int dn_route_output_sock(struct dst_entry **pprt, struct flowidn *fl, struct sock *sk, int flags)
 {
         int err;
 
         err = __dn_route_output_key(pprt, fl, flags & MSG_TRYHARD);
-        if (err == 0 && fl->proto) {
-                err = xfrm_lookup(&init_net, pprt, fl, sk,
-                                 (flags & MSG_DONTWAIT) ? 0 : XFRM_LOOKUP_WAIT);
+        if (err == 0 && fl->flowidn_proto) {
+                if (!(flags & MSG_DONTWAIT))
+                        fl->flowidn_flags |= FLOWI_FLAG_CAN_SLEEP;
+                *pprt = xfrm_lookup(&init_net, *pprt,
+                                    flowidn_to_flowi(fl), sk, 0);
+                if (IS_ERR(*pprt)) {
+                        err = PTR_ERR(*pprt);
+                        *pprt = NULL;
+                }
         }
         return err;
 }
@@ -1221,24 +1261,24 @@ static int dn_route_input_slow(struct sk_buff *skb)
         int flags = 0;
         __le16 gateway = 0;
         __le16 local_src = 0;
-        struct flowi fl = { .nl_u = { .dn_u =
-                                     { .daddr = cb->dst,
-                                       .saddr = cb->src,
-                                       .scope = RT_SCOPE_UNIVERSE,
-                                    } },
-                            .mark = skb->mark,
-                            .iif = skb->dev->ifindex };
+        struct flowidn fld = {
+                .daddr = cb->dst,
+                .saddr = cb->src,
+                .flowidn_scope = RT_SCOPE_UNIVERSE,
+                .flowidn_mark = skb->mark,
+                .flowidn_iif = skb->dev->ifindex,
+        };
         struct dn_fib_res res = { .fi = NULL, .type = RTN_UNREACHABLE };
         int err = -EINVAL;
         int free_res = 0;
 
         dev_hold(in_dev);
 
-        if ((dn_db = in_dev->dn_ptr) == NULL)
+        if ((dn_db = rcu_dereference(in_dev->dn_ptr)) == NULL)
                 goto out;
 
         /* Zero source addresses are not allowed */
-        if (fl.fld_src == 0)
+        if (fld.saddr == 0)
                 goto out;
 
         /*
@@ -1252,7 +1292,7 @@ static int dn_route_input_slow(struct sk_buff *skb)
         if (dn_dev_islocal(in_dev, cb->src))
                 goto out;
 
-        err = dn_fib_lookup(&fl, &res);
+        err = dn_fib_lookup(&fld, &res);
         if (err) {
                 if (err != -ESRCH)
                         goto out;
@@ -1264,7 +1304,7 @@ static int dn_route_input_slow(struct sk_buff *skb)
 
                 res.type = RTN_LOCAL;
         } else {
-                __le16 src_map = fl.fld_src;
+                __le16 src_map = fld.saddr;
                 free_res = 1;
 
                 out_dev = DN_FIB_RES_DEV(res);
@@ -1277,22 +1317,22 @@ static int dn_route_input_slow(struct sk_buff *skb)
                 dev_hold(out_dev);
 
                 if (res.r)
-                        src_map = fl.fld_src; /* no NAT support for now */
+                        src_map = fld.saddr; /* no NAT support for now */
 
                 gateway = DN_FIB_RES_GW(res);
                 if (res.type == RTN_NAT) {
-                        fl.fld_dst = dn_fib_rules_map_destination(fl.fld_dst, &res);
+                        fld.daddr = dn_fib_rules_map_destination(fld.daddr, &res);
                         dn_fib_res_put(&res);
                         free_res = 0;
-                        if (dn_fib_lookup(&fl, &res))
+                        if (dn_fib_lookup(&fld, &res))
                                 goto e_inval;
                         free_res = 1;
                         if (res.type != RTN_UNICAST)
                                 goto e_inval;
                         flags |= RTCF_DNAT;
-                        gateway = fl.fld_dst;
+                        gateway = fld.daddr;
                 }
-                fl.fld_src = src_map;
+                fld.saddr = src_map;
         }
 
         switch(res.type) {
@@ -1306,8 +1346,8 @@ static int dn_route_input_slow(struct sk_buff *skb)
                 if (dn_db->parms.forwarding == 0)
                         goto e_inval;
 
-                if (res.fi->fib_nhs > 1 && fl.oif == 0)
-                        dn_fib_select_multipath(&fl, &res);
+                if (res.fi->fib_nhs > 1 && fld.flowidn_oif == 0)
+                        dn_fib_select_multipath(&fld, &res);
 
                 /*
                  * Check for out_dev == in_dev. We use the RTCF_DOREDIRECT
@@ -1325,8 +1365,8 @@ static int dn_route_input_slow(struct sk_buff *skb)
                 break;
         case RTN_LOCAL:
                 flags |= RTCF_LOCAL;
-                fl.fld_src = cb->dst;
-                fl.fld_dst = cb->src;
+                fld.saddr = cb->dst;
+                fld.daddr = cb->src;
 
                 /* Routing tables gave us a gateway */
                 if (gateway)
@@ -1355,29 +1395,28 @@ static int dn_route_input_slow(struct sk_buff *skb)
         }
 
 make_route:
-        rt = dst_alloc(&dn_dst_ops);
+        rt = dst_alloc(&dn_dst_ops, out_dev, 0, 0, DST_HOST);
         if (rt == NULL)
                 goto e_nobufs;
 
-        rt->rt_saddr      = fl.fld_src;
-        rt->rt_daddr      = fl.fld_dst;
-        rt->rt_gateway    = fl.fld_dst;
+        memset(&rt->fld, 0, sizeof(rt->fld));
+        rt->rt_saddr      = fld.saddr;
+        rt->rt_daddr      = fld.daddr;
+        rt->rt_gateway    = fld.daddr;
         if (gateway)
                 rt->rt_gateway = gateway;
         rt->rt_local_src  = local_src ? local_src : rt->rt_saddr;
 
-        rt->rt_dst_map    = fl.fld_dst;
-        rt->rt_src_map    = fl.fld_src;
+        rt->rt_dst_map    = fld.daddr;
+        rt->rt_src_map    = fld.saddr;
 
-        rt->fl.fld_src    = cb->src;
-        rt->fl.fld_dst    = cb->dst;
-        rt->fl.oif        = 0;
-        rt->fl.iif        = in_dev->ifindex;
-        rt->fl.mark       = fl.mark;
+        rt->fld.saddr        = cb->src;
+        rt->fld.daddr        = cb->dst;
+        rt->fld.flowidn_oif  = 0;
+        rt->fld.flowidn_iif  = in_dev->ifindex;
+        rt->fld.flowidn_mark = fld.flowidn_mark;
 
-        rt->dst.flags = DST_HOST;
         rt->dst.neighbour = neigh;
-        rt->dst.dev = out_dev;
         rt->dst.lastuse = jiffies;
         rt->dst.output = dn_rt_bug;
         switch(res.type) {
@@ -1396,14 +1435,12 @@ make_route:
                         rt->dst.input = dst_discard;
         }
         rt->rt_flags = flags;
-        if (rt->dst.dev)
-                dev_hold(rt->dst.dev);
 
         err = dn_rt_set_next_hop(rt, &res);
         if (err)
                 goto e_neighbour;
 
-        hash = dn_hash(rt->fl.fld_src, rt->fl.fld_dst);
+        hash = dn_hash(rt->fld.saddr, rt->fld.daddr);
         dn_insert_route(rt, hash, &rt);
         skb_dst_set(skb, &rt->dst);
 
@@ -1443,11 +1480,11 @@ static int dn_route_input(struct sk_buff *skb)
         rcu_read_lock();
         for(rt = rcu_dereference(dn_rt_hash_table[hash].chain); rt != NULL;
             rt = rcu_dereference(rt->dst.dn_next)) {
-                if ((rt->fl.fld_src == cb->src) &&
-                    (rt->fl.fld_dst == cb->dst) &&
-                    (rt->fl.oif == 0) &&
-                    (rt->fl.mark == skb->mark) &&
-                    (rt->fl.iif == cb->iif)) {
+                if ((rt->fld.saddr == cb->src) &&
+                    (rt->fld.daddr == cb->dst) &&
+                    (rt->fld.flowidn_oif == 0) &&
+                    (rt->fld.flowidn_mark == skb->mark) &&
+                    (rt->fld.flowidn_iif == cb->iif)) {
                         dst_use(&rt->dst, jiffies);
                         rcu_read_unlock();
                         skb_dst_set(skb, (struct dst_entry *)rt);
@@ -1483,9 +1520,9 @@ static int dn_rt_fill_info(struct sk_buff *skb, u32 pid, u32 seq,
         if (rt->rt_flags & RTCF_NOTIFY)
                 r->rtm_flags |= RTM_F_NOTIFY;
         RTA_PUT(skb, RTA_DST, 2, &rt->rt_daddr);
-        if (rt->fl.fld_src) {
+        if (rt->fld.saddr) {
                 r->rtm_src_len = 16;
-                RTA_PUT(skb, RTA_SRC, 2, &rt->fl.fld_src);
+                RTA_PUT(skb, RTA_SRC, 2, &rt->fld.saddr);
         }
         if (rt->dst.dev)
                 RTA_PUT(skb, RTA_OIF, sizeof(int), &rt->dst.dev->ifindex);
@@ -1497,14 +1534,14 @@ static int dn_rt_fill_info(struct sk_buff *skb, u32 pid, u32 seq,
         RTA_PUT(skb, RTA_PREFSRC, 2, &rt->rt_local_src);
         if (rt->rt_daddr != rt->rt_gateway)
                 RTA_PUT(skb, RTA_GATEWAY, 2, &rt->rt_gateway);
-        if (rtnetlink_put_metrics(skb, rt->dst.metrics) < 0)
+        if (rtnetlink_put_metrics(skb, dst_metrics_ptr(&rt->dst)) < 0)
                 goto rtattr_failure;
         expires = rt->dst.expires ? rt->dst.expires - jiffies : 0;
         if (rtnl_put_cacheinfo(skb, &rt->dst, 0, 0, 0, expires,
                                rt->dst.error) < 0)
                 goto rtattr_failure;
-        if (rt->fl.iif)
-                RTA_PUT(skb, RTA_IIF, sizeof(int), &rt->fl.iif);
+        if (dn_is_input_route(rt))
+                RTA_PUT(skb, RTA_IIF, sizeof(int), &rt->fld.flowidn_iif);
 
         nlh->nlmsg_len = skb_tail_pointer(skb) - b;
         return skb->len;
@@ -1527,13 +1564,13 @@ static int dn_cache_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh, void
         struct dn_skb_cb *cb;
         int err;
         struct sk_buff *skb;
-        struct flowi fl;
+        struct flowidn fld;
 
         if (!net_eq(net, &init_net))
                 return -EINVAL;
 
-        memset(&fl, 0, sizeof(fl));
-        fl.proto = DNPROTO_NSP;
+        memset(&fld, 0, sizeof(fld));
+        fld.flowidn_proto = DNPROTO_NSP;
 
         skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
         if (skb == NULL)
@@ -1542,15 +1579,15 @@ static int dn_cache_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh, void
         cb = DN_SKB_CB(skb);
 
         if (rta[RTA_SRC-1])
-                memcpy(&fl.fld_src, RTA_DATA(rta[RTA_SRC-1]), 2);
+                memcpy(&fld.saddr, RTA_DATA(rta[RTA_SRC-1]), 2);
         if (rta[RTA_DST-1])
-                memcpy(&fl.fld_dst, RTA_DATA(rta[RTA_DST-1]), 2);
+                memcpy(&fld.daddr, RTA_DATA(rta[RTA_DST-1]), 2);
         if (rta[RTA_IIF-1])
-                memcpy(&fl.iif, RTA_DATA(rta[RTA_IIF-1]), sizeof(int));
+                memcpy(&fld.flowidn_iif, RTA_DATA(rta[RTA_IIF-1]), sizeof(int));
 
-        if (fl.iif) {
+        if (fld.flowidn_iif) {
                 struct net_device *dev;
-                if ((dev = dev_get_by_index(&init_net, fl.iif)) == NULL) {
+                if ((dev = dev_get_by_index(&init_net, fld.flowidn_iif)) == NULL) {
                         kfree_skb(skb);
                         return -ENODEV;
                 }
@@ -1561,8 +1598,8 @@ static int dn_cache_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh, void
                 }
                 skb->protocol = htons(ETH_P_DNA_RT);
                 skb->dev = dev;
-                cb->src = fl.fld_src;
-                cb->dst = fl.fld_dst;
+                cb->src = fld.saddr;
+                cb->dst = fld.daddr;
                 local_bh_disable();
                 err = dn_route_input(skb);
                 local_bh_enable();
@@ -1574,8 +1611,8 @@ static int dn_cache_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh, void
                 int oif = 0;
                 if (rta[RTA_OIF - 1])
                         memcpy(&oif, RTA_DATA(rta[RTA_OIF - 1]), sizeof(int));
-                fl.oif = oif;
-                err = dn_route_output_key((struct dst_entry **)&rt, &fl, 0);
+                fld.flowidn_oif = oif;
+                err = dn_route_output_key((struct dst_entry **)&rt, &fld, 0);
         }
 
         if (skb->dev)
@@ -1678,15 +1715,15 @@ static struct dn_route *dn_rt_cache_get_next(struct seq_file *seq, struct dn_rou
 {
         struct dn_rt_cache_iter_state *s = seq->private;
 
-        rt = rt->dst.dn_next;
-        while(!rt) {
+        rt = rcu_dereference_bh(rt->dst.dn_next);
+        while (!rt) {
                 rcu_read_unlock_bh();
                 if (--s->bucket < 0)
                         break;
                 rcu_read_lock_bh();
-                rt = dn_rt_hash_table[s->bucket].chain;
+                rt = rcu_dereference_bh(dn_rt_hash_table[s->bucket].chain);
         }
-        return rcu_dereference_bh(rt);
+        return rt;
 }
 
 static void *dn_rt_cache_seq_start(struct seq_file *seq, loff_t *pos)
@@ -1758,6 +1795,7 @@ void __init dn_route_init(void)
         dn_dst_ops.kmem_cachep =
                 kmem_cache_create("dn_dst_cache", sizeof(struct dn_route), 0,
                                   SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL);
+        dst_entries_init(&dn_dst_ops);
         setup_timer(&dn_route_timer, dn_dst_check_expire, 0);
         dn_route_timer.expires = jiffies + decnet_dst_gc_interval * HZ;
         add_timer(&dn_route_timer);
@@ -1816,5 +1854,6 @@ void __exit dn_route_cleanup(void)
         dn_run_flush(0);
 
         proc_net_remove(&init_net, "decnet_cache");
+        dst_entries_destroy(&dn_dst_ops);
 }