1 files changed, 12 insertions, 19 deletions

diff --git a/net/dccp/ccid.c b/net/dccp/ccid.c
index f3e9ba1cfd01..36479ca61e03 100644
--- a/net/dccp/ccid.c
+++ b/net/dccp/ccid.c
@@ -11,6 +11,8 @@
  *      published by the Free Software Foundation.
  */
 
+#include <linux/slab.h>
+
 #include "ccid.h"
 #include "ccids/lib/tfrc.h"
 
@@ -63,48 +65,37 @@ int ccid_getsockopt_builtin_ccids(struct sock *sk, int len,
         u8 *ccid_array, array_len;
         int err = 0;
 
-        if (len < ARRAY_SIZE(ccids))
-                return -EINVAL;
-
         if (ccid_get_builtin_ccids(&ccid_array, &array_len))
                 return -ENOBUFS;
 
-        if (put_user(array_len, optlen) ||
-            copy_to_user(optval, ccid_array, array_len))
+        if (put_user(array_len, optlen))
+                err = -EFAULT;
+        else if (len > 0 && copy_to_user(optval, ccid_array,
+                                         len > array_len ? array_len : len))
                 err = -EFAULT;
 
         kfree(ccid_array);
         return err;
 }
 
-static struct kmem_cache *ccid_kmem_cache_create(int obj_size, const char *fmt,...)
+static struct kmem_cache *ccid_kmem_cache_create(int obj_size, char *slab_name_fmt, const char *fmt,...)
 {
         struct kmem_cache *slab;
-        char slab_name_fmt[32], *slab_name;
         va_list args;
 
         va_start(args, fmt);
-        vsnprintf(slab_name_fmt, sizeof(slab_name_fmt), fmt, args);
+        vsnprintf(slab_name_fmt, CCID_SLAB_NAME_LENGTH, fmt, args);
         va_end(args);
 
-        slab_name = kstrdup(slab_name_fmt, GFP_KERNEL);
-        if (slab_name == NULL)
-                return NULL;
-        slab = kmem_cache_create(slab_name, sizeof(struct ccid) + obj_size, 0,
+        slab = kmem_cache_create(slab_name_fmt, sizeof(struct ccid) + obj_size, 0,
                                  SLAB_HWCACHE_ALIGN, NULL);
-        if (slab == NULL)
-                kfree(slab_name);
         return slab;
 }
 
 static void ccid_kmem_cache_destroy(struct kmem_cache *slab)
 {
-        if (slab != NULL) {
-                const char *name = kmem_cache_name(slab);
-
+        if (slab != NULL)
                 kmem_cache_destroy(slab);
-                kfree(name);
-        }
 }
 
 static int ccid_activate(struct ccid_operations *ccid_ops)
@@ -113,6 +104,7 @@ static int ccid_activate(struct ccid_operations *ccid_ops)
 
         ccid_ops->ccid_hc_rx_slab =
                         ccid_kmem_cache_create(ccid_ops->ccid_hc_rx_obj_size,
+                                               ccid_ops->ccid_hc_rx_slab_name,
                                                "ccid%u_hc_rx_sock",
                                                ccid_ops->ccid_id);
         if (ccid_ops->ccid_hc_rx_slab == NULL)
@@ -120,6 +112,7 @@ static int ccid_activate(struct ccid_operations *ccid_ops)
 
         ccid_ops->ccid_hc_tx_slab =
                         ccid_kmem_cache_create(ccid_ops->ccid_hc_tx_obj_size,
+                                               ccid_ops->ccid_hc_tx_slab_name,
                                                "ccid%u_hc_tx_sock",
                                                ccid_ops->ccid_id);
         if (ccid_ops->ccid_hc_tx_slab == NULL)