diff options
Diffstat (limited to 'kernel/cpu.c')
-rw-r--r-- | kernel/cpu.c | 33 |
1 files changed, 20 insertions, 13 deletions
diff --git a/kernel/cpu.c b/kernel/cpu.c index a343bde710b1..81e2a388a0f6 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c | |||
@@ -274,21 +274,28 @@ void clear_tasks_mm_cpumask(int cpu) | |||
274 | rcu_read_unlock(); | 274 | rcu_read_unlock(); |
275 | } | 275 | } |
276 | 276 | ||
277 | static inline void check_for_tasks(int cpu) | 277 | static inline void check_for_tasks(int dead_cpu) |
278 | { | 278 | { |
279 | struct task_struct *p; | 279 | struct task_struct *g, *p; |
280 | cputime_t utime, stime; | ||
281 | 280 | ||
282 | write_lock_irq(&tasklist_lock); | 281 | read_lock_irq(&tasklist_lock); |
283 | for_each_process(p) { | 282 | do_each_thread(g, p) { |
284 | task_cputime(p, &utime, &stime); | 283 | if (!p->on_rq) |
285 | if (task_cpu(p) == cpu && p->state == TASK_RUNNING && | 284 | continue; |
286 | (utime || stime)) | 285 | /* |
287 | pr_warn("Task %s (pid = %d) is on cpu %d (state = %ld, flags = %x)\n", | 286 | * We do the check with unlocked task_rq(p)->lock. |
288 | p->comm, task_pid_nr(p), cpu, | 287 | * Order the reading to do not warn about a task, |
289 | p->state, p->flags); | 288 | * which was running on this cpu in the past, and |
290 | } | 289 | * it's just been woken on another cpu. |
291 | write_unlock_irq(&tasklist_lock); | 290 | */ |
291 | rmb(); | ||
292 | if (task_cpu(p) != dead_cpu) | ||
293 | continue; | ||
294 | |||
295 | pr_warn("Task %s (pid=%d) is on cpu %d (state=%ld, flags=%x)\n", | ||
296 | p->comm, task_pid_nr(p), dead_cpu, p->state, p->flags); | ||
297 | } while_each_thread(g, p); | ||
298 | read_unlock_irq(&tasklist_lock); | ||
292 | } | 299 | } |
293 | 300 | ||
294 | struct take_cpu_down_param { | 301 | struct take_cpu_down_param { |