7 files changed, 92 insertions, 76 deletions

diff --git a/include/asm-generic/atomic.h b/include/asm-generic/atomic.h
index e53347fbf1da..fd57b8477fab 100644
--- a/include/asm-generic/atomic.h
+++ b/include/asm-generic/atomic.h
@@ -43,6 +43,7 @@
  */
 #define atomic_set(v, i) (((v)->counter) = (i))
 
+#include <linux/irqflags.h>
 #include <asm/system.h>
 
 /**
@@ -57,7 +58,7 @@ static inline int atomic_add_return(int i, atomic_t *v)
         unsigned long flags;
         int temp;
 
-        raw_local_irq_save(flags); /* Don't trace it in a irqsoff handler */
+        raw_local_irq_save(flags); /* Don't trace it in an irqsoff handler */
         temp = v->counter;
         temp += i;
         v->counter = temp;
@@ -78,7 +79,7 @@ static inline int atomic_sub_return(int i, atomic_t *v)
         unsigned long flags;
         int temp;
 
-        raw_local_irq_save(flags); /* Don't trace it in a irqsoff handler */
+        raw_local_irq_save(flags); /* Don't trace it in an irqsoff handler */
         temp = v->counter;
         temp -= i;
         v->counter = temp;
diff --git a/include/asm-generic/cmpxchg-local.h b/include/asm-generic/cmpxchg-local.h
index b2ba2fc8829a..2533fddd34a6 100644
--- a/include/asm-generic/cmpxchg-local.h
+++ b/include/asm-generic/cmpxchg-local.h
@@ -2,6 +2,7 @@
 #define __ASM_GENERIC_CMPXCHG_LOCAL_H
 
 #include <linux/types.h>
+#include <linux/irqflags.h>
 
 extern unsigned long wrong_size_cmpxchg(volatile void *ptr);
 
diff --git a/include/asm-generic/irqflags.h b/include/asm-generic/irqflags.h
index 9aebf618275a..1f40d0024cf3 100644
--- a/include/asm-generic/irqflags.h
+++ b/include/asm-generic/irqflags.h
@@ -5,68 +5,62 @@
  * All architectures should implement at least the first two functions,
  * usually inline assembly will be the best way.
  */
-#ifndef RAW_IRQ_DISABLED
-#define RAW_IRQ_DISABLED 0
-#define RAW_IRQ_ENABLED 1
+#ifndef ARCH_IRQ_DISABLED
+#define ARCH_IRQ_DISABLED 0
+#define ARCH_IRQ_ENABLED 1
 #endif
 
 /* read interrupt enabled status */
-#ifndef __raw_local_save_flags
-unsigned long __raw_local_save_flags(void);
+#ifndef arch_local_save_flags
+unsigned long arch_local_save_flags(void);
 #endif
 
 /* set interrupt enabled status */
-#ifndef raw_local_irq_restore
-void raw_local_irq_restore(unsigned long flags);
+#ifndef arch_local_irq_restore
+void arch_local_irq_restore(unsigned long flags);
 #endif
 
 /* get status and disable interrupts */
-#ifndef __raw_local_irq_save
-static inline unsigned long __raw_local_irq_save(void)
+#ifndef arch_local_irq_save
+static inline unsigned long arch_local_irq_save(void)
 {
         unsigned long flags;
-        flags = __raw_local_save_flags();
-        raw_local_irq_restore(RAW_IRQ_DISABLED);
+        flags = arch_local_save_flags();
+        arch_local_irq_restore(ARCH_IRQ_DISABLED);
         return flags;
 }
 #endif
 
 /* test flags */
-#ifndef raw_irqs_disabled_flags
-static inline int raw_irqs_disabled_flags(unsigned long flags)
+#ifndef arch_irqs_disabled_flags
+static inline int arch_irqs_disabled_flags(unsigned long flags)
 {
-        return flags == RAW_IRQ_DISABLED;
+        return flags == ARCH_IRQ_DISABLED;
 }
 #endif
 
 /* unconditionally enable interrupts */
-#ifndef raw_local_irq_enable
-static inline void raw_local_irq_enable(void)
+#ifndef arch_local_irq_enable
+static inline void arch_local_irq_enable(void)
 {
-        raw_local_irq_restore(RAW_IRQ_ENABLED);
+        arch_local_irq_restore(ARCH_IRQ_ENABLED);
 }
 #endif
 
 /* unconditionally disable interrupts */
-#ifndef raw_local_irq_disable
-static inline void raw_local_irq_disable(void)
+#ifndef arch_local_irq_disable
+static inline void arch_local_irq_disable(void)
 {
-        raw_local_irq_restore(RAW_IRQ_DISABLED);
+        arch_local_irq_restore(ARCH_IRQ_DISABLED);
 }
 #endif
 
 /* test hardware interrupt enable bit */
-#ifndef raw_irqs_disabled
-static inline int raw_irqs_disabled(void)
+#ifndef arch_irqs_disabled
+static inline int arch_irqs_disabled(void)
 {
-        return raw_irqs_disabled_flags(__raw_local_save_flags());
+        return arch_irqs_disabled_flags(arch_local_save_flags());
 }
 #endif
 
-#define raw_local_save_flags(flags) \
-        do { (flags) = __raw_local_save_flags(); } while (0)
-
-#define raw_local_irq_save(flags) \
-        do { (flags) = __raw_local_irq_save(); } while (0)
-
 #endif /* __ASM_GENERIC_IRQFLAGS_H */
diff --git a/include/linux/hardirq.h b/include/linux/hardirq.h
index 96c323ac44df..8a389b608ce3 100644
--- a/include/linux/hardirq.h
+++ b/include/linux/hardirq.h
@@ -8,7 +8,6 @@
 #include <linux/lockdep.h>
 #include <linux/ftrace_irq.h>
 #include <asm/hardirq.h>
-#include <asm/system.h>
 
 /*
  * We put the hardirq and softirq counter into the preemption
diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
index 006bf45eae30..d176d658fe25 100644
--- a/include/linux/irqflags.h
+++ b/include/linux/irqflags.h
@@ -12,6 +12,7 @@
 #define _LINUX_TRACE_IRQFLAGS_H
 
 #include <linux/typecheck.h>
+#include <asm/irqflags.h>
 
 #ifdef CONFIG_TRACE_IRQFLAGS
   extern void trace_softirqs_on(unsigned long ip);
@@ -52,17 +53,45 @@
 # define start_critical_timings() do { } while (0)
 #endif
 
-#ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT
-
-#include <asm/irqflags.h>
+/*
+ * Wrap the arch provided IRQ routines to provide appropriate checks.
+ */
+#define raw_local_irq_disable()         arch_local_irq_disable()
+#define raw_local_irq_enable()          arch_local_irq_enable()
+#define raw_local_irq_save(flags)                       \
+        do {                                            \
+                typecheck(unsigned long, flags);        \
+                flags = arch_local_irq_save();          \
+        } while (0)
+#define raw_local_irq_restore(flags)                    \
+        do {                                            \
+                typecheck(unsigned long, flags);        \
+                arch_local_irq_restore(flags);          \
+        } while (0)
+#define raw_local_save_flags(flags)                     \
+        do {                                            \
+                typecheck(unsigned long, flags);        \
+                flags = arch_local_save_flags();        \
+        } while (0)
+#define raw_irqs_disabled_flags(flags)                  \
+        ({                                              \
+                typecheck(unsigned long, flags);        \
+                arch_irqs_disabled_flags(flags);        \
+        })
+#define raw_irqs_disabled()             (arch_irqs_disabled())
+#define raw_safe_halt()                 arch_safe_halt()
 
+/*
+ * The local_irq_*() APIs are equal to the raw_local_irq*()
+ * if !TRACE_IRQFLAGS.
+ */
+#ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT
 #define local_irq_enable() \
         do { trace_hardirqs_on(); raw_local_irq_enable(); } while (0)
 #define local_irq_disable() \
         do { raw_local_irq_disable(); trace_hardirqs_off(); } while (0)
 #define local_irq_save(flags)                           \
         do {                                            \
-                typecheck(unsigned long, flags);        \
                 raw_local_irq_save(flags);              \
                 trace_hardirqs_off();                   \
         } while (0)
@@ -70,7 +99,6 @@
 
 #define local_irq_restore(flags)                        \
         do {                                            \
-                typecheck(unsigned long, flags);        \
                 if (raw_irqs_disabled_flags(flags)) {   \
                         raw_local_irq_restore(flags);   \
                         trace_hardirqs_off();           \
@@ -79,51 +107,44 @@
                         raw_local_irq_restore(flags);   \
                 }                                       \
         } while (0)
-#else /* !CONFIG_TRACE_IRQFLAGS_SUPPORT */
-/*
- * The local_irq_*() APIs are equal to the raw_local_irq*()
- * if !TRACE_IRQFLAGS.
- */
-# define raw_local_irq_disable()        local_irq_disable()
-# define raw_local_irq_enable()         local_irq_enable()
-# define raw_local_irq_save(flags)                      \
-        do {                                            \
-                typecheck(unsigned long, flags);        \
-                local_irq_save(flags);                  \
-        } while (0)
-# define raw_local_irq_restore(flags)                   \
+#define local_save_flags(flags)                         \
         do {                                            \
-                typecheck(unsigned long, flags);        \
-                local_irq_restore(flags);               \
+                raw_local_save_flags(flags);            \
         } while (0)
-#endif /* CONFIG_TRACE_IRQFLAGS_SUPPORT */
 
-#ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT
-#define safe_halt()                                             \
-        do {                                                    \
-                trace_hardirqs_on();                            \
-                raw_safe_halt();                                \
-        } while (0)
+#define irqs_disabled_flags(flags)                      \
+        ({                                              \
+                raw_irqs_disabled_flags(flags);         \
+        })
 
-#define local_save_flags(flags)                         \
-        do {                                            \
-                typecheck(unsigned long, flags);        \
-                raw_local_save_flags(flags);            \
+#define irqs_disabled()                                 \
+        ({                                              \
+                unsigned long _flags;                   \
+                raw_local_save_flags(_flags);           \
+                raw_irqs_disabled_flags(_flags);        \
+        })
+
+#define safe_halt()                             \
+        do {                                    \
+                trace_hardirqs_on();            \
+                raw_safe_halt();                \
         } while (0)
 
-#define irqs_disabled()                                         \
-({                                                              \
-        unsigned long _flags;                                   \
-                                                                \
-        raw_local_save_flags(_flags);                           \
-        raw_irqs_disabled_flags(_flags);                        \
-})
 
-#define irqs_disabled_flags(flags)              \
-({                                              \
-        typecheck(unsigned long, flags);        \
-        raw_irqs_disabled_flags(flags);         \
-})
+#else /* !CONFIG_TRACE_IRQFLAGS_SUPPORT */
+
+#define local_irq_enable()      do { raw_local_irq_enable(); } while (0)
+#define local_irq_disable()     do { raw_local_irq_disable(); } while (0)
+#define local_irq_save(flags)                                   \
+        do {                                                    \
+                raw_local_irq_save(flags);                      \
+        } while (0)
+#define local_irq_restore(flags) do { raw_local_irq_restore(flags); } while (0)
+#define local_save_flags(flags) do { raw_local_save_flags(flags); } while (0)
+#define irqs_disabled()         (raw_irqs_disabled())
+#define irqs_disabled_flags(flags) (raw_irqs_disabled_flags(flags))
+#define safe_halt()             do { raw_safe_halt(); } while (0)
+
 #endif /* CONFIG_TRACE_IRQFLAGS_SUPPORT */
 
 #endif
diff --git a/include/linux/list.h b/include/linux/list.h
index d167b5d7c0ac..88a000617d77 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -5,7 +5,6 @@
 #include <linux/stddef.h>
 #include <linux/poison.h>
 #include <linux/prefetch.h>
-#include <asm/system.h>
 
 /*
  * Simple doubly linked list implementation.
diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
index f8854655860e..80e535897de6 100644
--- a/include/linux/spinlock.h
+++ b/include/linux/spinlock.h
@@ -50,6 +50,7 @@
 #include <linux/preempt.h>
 #include <linux/linkage.h>
 #include <linux/compiler.h>
+#include <linux/irqflags.h>
 #include <linux/thread_info.h>
 #include <linux/kernel.h>
 #include <linux/stringify.h>