1 files changed, 12 insertions, 3 deletions

diff --git a/include/trace/events/module.h b/include/trace/events/module.h
index c7bb2f0482fe..21a546d27c0c 100644
--- a/include/trace/events/module.h
+++ b/include/trace/events/module.h
@@ -1,5 +1,15 @@
+/*
+ * Because linux/module.h has tracepoints in the header, and ftrace.h
+ * eventually includes this file, define_trace.h includes linux/module.h
+ * But we do not want the module.h to override the TRACE_SYSTEM macro
+ * variable that define_trace.h is processing, so we only set it
+ * when module events are being processed, which would happen when
+ * CREATE_TRACE_POINTS is defined.
+ */
+#ifdef CREATE_TRACE_POINTS
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM module
+#endif
 
 #if !defined(_TRACE_MODULE_H) || defined(TRACE_HEADER_MULTI_READ)
 #define _TRACE_MODULE_H
@@ -98,14 +108,14 @@ TRACE_EVENT(module_request,
         TP_ARGS(name, wait, ip),
 
         TP_STRUCT__entry(
-                __field(        bool,           wait            )
                 __field(        unsigned long,  ip              )
+                __field(        bool,           wait            )
                 __string(       name,           name            )
         ),
 
         TP_fast_assign(
-                __entry->wait   = wait;
                 __entry->ip     = ip;
+                __entry->wait   = wait;
                 __assign_str(name, name);
         ),
 
@@ -119,4 +129,3 @@ TRACE_EVENT(module_request,
 
 /* This part must be outside protection */
 #include <trace/define_trace.h>
-