1 files changed, 13 insertions, 14 deletions

diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index 1aaf915656f3..873d5be7926c 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -425,9 +425,9 @@ struct ip_vs_protocol {
 
         const char *(*state_name)(int state);
 
-        int (*state_transition)(struct ip_vs_conn *cp, int direction,
-                                const struct sk_buff *skb,
-                                struct ip_vs_proto_data *pd);
+        void (*state_transition)(struct ip_vs_conn *cp, int direction,
+                                 const struct sk_buff *skb,
+                                 struct ip_vs_proto_data *pd);
 
         int (*register_app)(struct net *net, struct ip_vs_app *inc);
 
@@ -900,6 +900,7 @@ struct netns_ipvs {
         volatile int            sync_state;
         volatile int            master_syncid;
         volatile int            backup_syncid;
+        struct mutex            sync_mutex;
         /* multicast interface name */
         char                    master_mcast_ifn[IP_VS_IFNAME_MAXLEN];
         char                    backup_mcast_ifn[IP_VS_IFNAME_MAXLEN];
@@ -1125,17 +1126,16 @@ int unregister_ip_vs_pe(struct ip_vs_pe *pe);
 struct ip_vs_pe *ip_vs_pe_getbyname(const char *name);
 struct ip_vs_pe *__ip_vs_pe_getbyname(const char *pe_name);
 
-static inline void ip_vs_pe_get(const struct ip_vs_pe *pe)
-{
-        if (pe && pe->module)
+/*
+ * Use a #define to avoid all of module.h just for these trivial ops
+ */
+#define ip_vs_pe_get(pe)                        \
+        if (pe && pe->module)                   \
                 __module_get(pe->module);
-}
 
-static inline void ip_vs_pe_put(const struct ip_vs_pe *pe)
-{
-        if (pe && pe->module)
+#define ip_vs_pe_put(pe)                        \
+        if (pe && pe->module)                   \
                 module_put(pe->module);
-}
 
 /*
  *      IPVS protocol functions (from ip_vs_proto.c)
@@ -1377,7 +1377,7 @@ static inline int ip_vs_conntrack_enabled(struct netns_ipvs *ipvs)
 
 extern void ip_vs_update_conntrack(struct sk_buff *skb, struct ip_vs_conn *cp,
                                    int outin);
-extern int ip_vs_confirm_conntrack(struct sk_buff *skb, struct ip_vs_conn *cp);
+extern int ip_vs_confirm_conntrack(struct sk_buff *skb);
 extern void ip_vs_nfct_expect_related(struct sk_buff *skb, struct nf_conn *ct,
                                       struct ip_vs_conn *cp, u_int8_t proto,
                                       const __be16 port, int from_rs);
@@ -1395,8 +1395,7 @@ static inline void ip_vs_update_conntrack(struct sk_buff *skb,
 {
 }
 
-static inline int ip_vs_confirm_conntrack(struct sk_buff *skb,
-                                          struct ip_vs_conn *cp)
+static inline int ip_vs_confirm_conntrack(struct sk_buff *skb)
 {
         return NF_ACCEPT;
 }