3 files changed, 22 insertions, 10 deletions

diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 2520a6e241dc..7d10f962aa13 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -3,10 +3,18 @@
 
 #include <linux/compiler.h>
 
+#ifdef CONFIG_GENERIC_BUG
+#define BUGFLAG_WARNING         (1 << 0)
+#define BUGFLAG_TAINT(taint)    (BUGFLAG_WARNING | ((taint) << 8))
+#define BUG_GET_TAINT(bug)      ((bug)->flags >> 8)
+#endif
+
+#ifndef __ASSEMBLY__
+#include <linux/kernel.h>
+
 #ifdef CONFIG_BUG
 
 #ifdef CONFIG_GENERIC_BUG
-#ifndef __ASSEMBLY__
 struct bug_entry {
 #ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS
         unsigned long   bug_addr;
@@ -23,12 +31,6 @@ struct bug_entry {
 #endif
         unsigned short  flags;
 };
-#endif          /* __ASSEMBLY__ */
-
-#define BUGFLAG_WARNING         (1 << 0)
-#define BUGFLAG_TAINT(taint)    (BUGFLAG_WARNING | ((taint) << 8))
-#define BUG_GET_TAINT(bug)      ((bug)->flags >> 8)
-
 #endif  /* CONFIG_GENERIC_BUG */
 
 /*
@@ -60,7 +62,6 @@ struct bug_entry {
  * to provide better diagnostics.
  */
 #ifndef __WARN_TAINT
-#ifndef __ASSEMBLY__
 extern __printf(3, 4)
 void warn_slowpath_fmt(const char *file, const int line,
                        const char *fmt, ...);
@@ -69,7 +70,6 @@ void warn_slowpath_fmt_taint(const char *file, const int line, unsigned taint,
                              const char *fmt, ...);
 extern void warn_slowpath_null(const char *file, const int line);
 #define WANT_WARN_ON_SLOWPATH
-#endif
 #define __WARN()                warn_slowpath_null(__FILE__, __LINE__)
 #define __WARN_printf(arg...)   warn_slowpath_fmt(__FILE__, __LINE__, arg)
 #define __WARN_printf_taint(taint, arg...)                              \
@@ -202,4 +202,6 @@ extern void warn_slowpath_null(const char *file, const int line);
 # define WARN_ON_SMP(x)                 ({0;})
 #endif
 
+#endif /* __ASSEMBLY__ */
+
 #endif
diff --git a/include/asm-generic/dma-contiguous.h b/include/asm-generic/dma-contiguous.h
index c544356b374b..294b1e755ab2 100644
--- a/include/asm-generic/dma-contiguous.h
+++ b/include/asm-generic/dma-contiguous.h
@@ -18,7 +18,7 @@ static inline void dev_set_cma_area(struct device *dev, struct cma *cma)
 {
         if (dev)
                 dev->cma_area = cma;
-        if (!dev || !dma_contiguous_default_area)
+        if (!dev && !dma_contiguous_default_area)
                 dma_contiguous_default_area = cma;
 }
 
diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
index 6f2b45a9b6bc..ff4947b7a976 100644
--- a/include/asm-generic/pgtable.h
+++ b/include/asm-generic/pgtable.h
@@ -484,6 +484,16 @@ static inline int pmd_none_or_trans_huge_or_clear_bad(pmd_t *pmd)
         /*
          * The barrier will stabilize the pmdval in a register or on
          * the stack so that it will stop changing under the code.
+         *
+         * When CONFIG_TRANSPARENT_HUGEPAGE=y on x86 32bit PAE,
+         * pmd_read_atomic is allowed to return a not atomic pmdval
+         * (for example pointing to an hugepage that has never been
+         * mapped in the pmd). The below checks will only care about
+         * the low part of the pmd with 32bit PAE x86 anyway, with the
+         * exception of pmd_none(). So the important thing is that if
+         * the low part of the pmd is found null, the high part will
+         * be also null or the pmd_none() check below would be
+         * confused.
          */
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
         barrier();