8 files changed, 84 insertions, 114 deletions

diff --git a/fs/reiserfs/do_balan.c b/fs/reiserfs/do_balan.c
index f85c5cf4934c..7ee4208793b6 100644
--- a/fs/reiserfs/do_balan.c
+++ b/fs/reiserfs/do_balan.c
@@ -283,7 +283,7 @@ static int balance_leaf(struct tree_balance *tb, struct item_head *ih,	/* item h
                 return balance_leaf_when_delete(tb, flag);
 
         zeros_num = 0;
-        if (flag == M_INSERT && body == 0)
+        if (flag == M_INSERT && !body)
                 zeros_num = ih_item_len(ih);
 
         pos_in_item = tb->tb_path->pos_in_item;
@@ -1728,7 +1728,7 @@ struct buffer_head *get_FEB(struct tree_balance *tb)
         struct buffer_info bi;
 
         for (i = 0; i < MAX_FEB_SIZE; i++)
-                if (tb->FEB[i] != 0)
+                if (tb->FEB[i] != NULL)
                         break;
 
         if (i == MAX_FEB_SIZE)
@@ -1827,7 +1827,7 @@ int get_left_neighbor_position(struct tree_balance *tb, int h)
 {
         int Sh_position = PATH_H_POSITION(tb->tb_path, h + 1);
 
-        RFALSE(PATH_H_PPARENT(tb->tb_path, h) == 0 || tb->FL[h] == 0,
+        RFALSE(PATH_H_PPARENT(tb->tb_path, h) == NULL || tb->FL[h] == NULL,
                "vs-12325: FL[%d](%p) or F[%d](%p) does not exist",
                h, tb->FL[h], h, PATH_H_PPARENT(tb->tb_path, h));
 
@@ -1841,7 +1841,7 @@ int get_right_neighbor_position(struct tree_balance *tb, int h)
 {
         int Sh_position = PATH_H_POSITION(tb->tb_path, h + 1);
 
-        RFALSE(PATH_H_PPARENT(tb->tb_path, h) == 0 || tb->FR[h] == 0,
+        RFALSE(PATH_H_PPARENT(tb->tb_path, h) == NULL || tb->FR[h] == NULL,
                "vs-12330: F[%d](%p) or FR[%d](%p) does not exist",
                h, PATH_H_PPARENT(tb->tb_path, h), h, tb->FR[h]);
 
diff --git a/fs/reiserfs/fix_node.c b/fs/reiserfs/fix_node.c
index 0ee35c6c9b72..07d05e0842b7 100644
--- a/fs/reiserfs/fix_node.c
+++ b/fs/reiserfs/fix_node.c
@@ -153,7 +153,7 @@ static void create_virtual_node(struct tree_balance *tb, int h)
         if (vn->vn_mode == M_INSERT) {
                 struct virtual_item *vi = vn->vn_vi + vn->vn_affected_item_num;
 
-                RFALSE(vn->vn_ins_ih == 0,
+                RFALSE(vn->vn_ins_ih == NULL,
                        "vs-8040: item header of inserted item is not specified");
                 vi->vi_item_len = tb->insert_size[0];
                 vi->vi_ih = vn->vn_ins_ih;
@@ -857,7 +857,8 @@ static int get_lfree(struct tree_balance *tb, int h)
         struct buffer_head *l, *f;
         int order;
 
-        if ((f = PATH_H_PPARENT(tb->tb_path, h)) == 0 || (l = tb->FL[h]) == 0)
+        if ((f = PATH_H_PPARENT(tb->tb_path, h)) == NULL ||
+            (l = tb->FL[h]) == NULL)
                 return 0;
 
         if (f == l)
@@ -878,7 +879,8 @@ static int get_rfree(struct tree_balance *tb, int h)
         struct buffer_head *r, *f;
         int order;
 
-        if ((f = PATH_H_PPARENT(tb->tb_path, h)) == 0 || (r = tb->FR[h]) == 0)
+        if ((f = PATH_H_PPARENT(tb->tb_path, h)) == NULL ||
+            (r = tb->FR[h]) == NULL)
                 return 0;
 
         if (f == r)
diff --git a/fs/reiserfs/ioctl.c b/fs/reiserfs/ioctl.c
index e0f0f098a523..74363a7aacbc 100644
--- a/fs/reiserfs/ioctl.c
+++ b/fs/reiserfs/ioctl.c
@@ -4,6 +4,7 @@
 
 #include <linux/capability.h>
 #include <linux/fs.h>
+#include <linux/mount.h>
 #include <linux/reiserfs_fs.h>
 #include <linux/time.h>
 #include <asm/uaccess.h>
@@ -25,6 +26,7 @@ int reiserfs_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
                    unsigned long arg)
 {
         unsigned int flags;
+        int err = 0;
 
         switch (cmd) {
         case REISERFS_IOC_UNPACK:
@@ -48,50 +50,67 @@ int reiserfs_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
                         if (!reiserfs_attrs(inode->i_sb))
                                 return -ENOTTY;
 
-                        if (IS_RDONLY(inode))
-                                return -EROFS;
+                        err = mnt_want_write(filp->f_path.mnt);
+                        if (err)
+                                return err;
 
-                        if (!is_owner_or_cap(inode))
-                                return -EPERM;
-
-                        if (get_user(flags, (int __user *)arg))
-                                return -EFAULT;
-
-                        /* Is it quota file? Do not allow user to mess with it. */
-                        if (IS_NOQUOTA(inode))
-                                return -EPERM;
+                        if (!is_owner_or_cap(inode)) {
+                                err = -EPERM;
+                                goto setflags_out;
+                        }
+                        if (get_user(flags, (int __user *)arg)) {
+                                err = -EFAULT;
+                                goto setflags_out;
+                        }
+                        /*
+                         * Is it quota file? Do not allow user to mess with it
+                         */
+                        if (IS_NOQUOTA(inode)) {
+                                err = -EPERM;
+                                goto setflags_out;
+                        }
                         if (((flags ^ REISERFS_I(inode)->
                               i_attrs) & (REISERFS_IMMUTABLE_FL |
                                           REISERFS_APPEND_FL))
-                            && !capable(CAP_LINUX_IMMUTABLE))
-                                return -EPERM;
-
+                            && !capable(CAP_LINUX_IMMUTABLE)) {
+                                err = -EPERM;
+                                goto setflags_out;
+                        }
                         if ((flags & REISERFS_NOTAIL_FL) &&
                             S_ISREG(inode->i_mode)) {
                                 int result;
 
                                 result = reiserfs_unpack(inode, filp);
-                                if (result)
-                                        return result;
+                                if (result) {
+                                        err = result;
+                                        goto setflags_out;
+                                }
                         }
                         sd_attrs_to_i_attrs(flags, inode);
                         REISERFS_I(inode)->i_attrs = flags;
                         inode->i_ctime = CURRENT_TIME_SEC;
                         mark_inode_dirty(inode);
-                        return 0;
+setflags_out:
+                        mnt_drop_write(filp->f_path.mnt);
+                        return err;
                 }
         case REISERFS_IOC_GETVERSION:
                 return put_user(inode->i_generation, (int __user *)arg);
         case REISERFS_IOC_SETVERSION:
                 if (!is_owner_or_cap(inode))
                         return -EPERM;
-                if (IS_RDONLY(inode))
-                        return -EROFS;
-                if (get_user(inode->i_generation, (int __user *)arg))
-                        return -EFAULT;
+                err = mnt_want_write(filp->f_path.mnt);
+                if (err)
+                        return err;
+                if (get_user(inode->i_generation, (int __user *)arg)) {
+                        err = -EFAULT;
+                        goto setversion_out;
+                }
                 inode->i_ctime = CURRENT_TIME_SEC;
                 mark_inode_dirty(inode);
-                return 0;
+setversion_out:
+                mnt_drop_write(filp->f_path.mnt);
+                return err;
         default:
                 return -ENOTTY;
         }
diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
index bb05a3e51b93..060eb3f598e7 100644
--- a/fs/reiserfs/journal.c
+++ b/fs/reiserfs/journal.c
@@ -38,7 +38,7 @@
 #include <asm/system.h>
 
 #include <linux/time.h>
-#include <asm/semaphore.h>
+#include <linux/semaphore.h>
 
 #include <linux/vmalloc.h>
 #include <linux/reiserfs_fs.h>
diff --git a/fs/reiserfs/lbalance.c b/fs/reiserfs/lbalance.c
index 281f8061ac58..6de060a6aa7f 100644
--- a/fs/reiserfs/lbalance.c
+++ b/fs/reiserfs/lbalance.c
@@ -626,7 +626,7 @@ static void leaf_define_dest_src_infos(int shift_mode, struct tree_balance *tb,
                                "vs-10250: leaf_define_dest_src_infos: shift type is unknown (%d)",
                                shift_mode);
         }
-        RFALSE(src_bi->bi_bh == 0 || dest_bi->bi_bh == 0,
+        RFALSE(!src_bi->bi_bh || !dest_bi->bi_bh,
                "vs-10260: mode==%d, source (%p) or dest (%p) buffer is initialized incorrectly",
                shift_mode, src_bi->bi_bh, dest_bi->bi_bh);
 }
diff --git a/fs/reiserfs/namei.c b/fs/reiserfs/namei.c
index b378eea332ca..8867533cb727 100644
--- a/fs/reiserfs/namei.c
+++ b/fs/reiserfs/namei.c
@@ -452,7 +452,7 @@ static int reiserfs_add_entry(struct reiserfs_transaction_handle *th,
         buflen = DEH_SIZE + ROUND_UP(namelen);
         if (buflen > sizeof(small_buf)) {
                 buffer = kmalloc(buflen, GFP_NOFS);
-                if (buffer == 0)
+                if (!buffer)
                         return -ENOMEM;
         } else
                 buffer = small_buf;
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index 6841452e0dea..393cc22c1717 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -2031,7 +2031,7 @@ static int reiserfs_quota_on(struct super_block *sb, int type, int format_id,
                 return -EXDEV;
         }
         /* We must not pack tails for quota files on reiserfs for quota IO to work */
-        if (!REISERFS_I(nd.path.dentry->d_inode)->i_flags & i_nopack_mask) {
+        if (!(REISERFS_I(nd.path.dentry->d_inode)->i_flags & i_nopack_mask)) {
                 reiserfs_warning(sb,
                                  "reiserfs: Quota file must have tail packing disabled.");
                 path_put(&nd.path);
diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
index eba037b3338f..d7c4935c1034 100644
--- a/fs/reiserfs/xattr.c
+++ b/fs/reiserfs/xattr.c
@@ -44,7 +44,6 @@
 #include <net/checksum.h>
 #include <linux/smp_lock.h>
 #include <linux/stat.h>
-#include <asm/semaphore.h>
 
 #define FL_READONLY 128
 #define FL_DIR_SEM_HELD 256
@@ -191,28 +190,11 @@ static struct dentry *get_xa_file_dentry(const struct inode *inode,
         dput(xadir);
         if (err)
                 xafile = ERR_PTR(err);
-        return xafile;
-}
-
-/* Opens a file pointer to the attribute associated with inode */
-static struct file *open_xa_file(const struct inode *inode, const char *name,
-                                 int flags)
-{
-        struct dentry *xafile;
-        struct file *fp;
-
-        xafile = get_xa_file_dentry(inode, name, flags);
-        if (IS_ERR(xafile))
-                return ERR_PTR(PTR_ERR(xafile));
         else if (!xafile->d_inode) {
                 dput(xafile);
-                return ERR_PTR(-ENODATA);
+                xafile = ERR_PTR(-ENODATA);
         }
-
-        fp = dentry_open(xafile, NULL, O_RDWR);
-        /* dentry_open dputs the dentry if it fails */
-
-        return fp;
+        return xafile;
 }
 
 /*
@@ -228,9 +210,8 @@ static struct file *open_xa_file(const struct inode *inode, const char *name,
  * we're called with i_mutex held, so there are no worries about the directory
  * changing underneath us.
  */
-static int __xattr_readdir(struct file *filp, void *dirent, filldir_t filldir)
+static int __xattr_readdir(struct inode *inode, void *dirent, filldir_t filldir)
 {
-        struct inode *inode = filp->f_path.dentry->d_inode;
         struct cpu_key pos_key; /* key of current position in the directory (key of directory entry) */
         INITIALIZE_PATH(path_to_entry);
         struct buffer_head *bh;
@@ -374,23 +355,16 @@ static int __xattr_readdir(struct file *filp, void *dirent, filldir_t filldir)
  *
  */
 static
-int xattr_readdir(struct file *file, filldir_t filler, void *buf)
+int xattr_readdir(struct inode *inode, filldir_t filler, void *buf)
 {
-        struct inode *inode = file->f_path.dentry->d_inode;
-        int res = -ENOTDIR;
-        if (!file->f_op || !file->f_op->readdir)
-                goto out;
+        int res = -ENOENT;
         mutex_lock_nested(&inode->i_mutex, I_MUTEX_XATTR);
-//        down(&inode->i_zombie);
-        res = -ENOENT;
         if (!IS_DEADDIR(inode)) {
                 lock_kernel();
-                res = __xattr_readdir(file, buf, filler);
+                res = __xattr_readdir(inode, buf, filler);
                 unlock_kernel();
         }
-//        up(&inode->i_zombie);
         mutex_unlock(&inode->i_mutex);
-      out:
         return res;
 }
 
@@ -442,7 +416,7 @@ reiserfs_xattr_set(struct inode *inode, const char *name, const void *buffer,
                    size_t buffer_size, int flags)
 {
         int err = 0;
-        struct file *fp;
+        struct dentry *dentry;
         struct page *page;
         char *data;
         struct address_space *mapping;
@@ -460,18 +434,18 @@ reiserfs_xattr_set(struct inode *inode, const char *name, const void *buffer,
                 xahash = xattr_hash(buffer, buffer_size);
 
       open_file:
-        fp = open_xa_file(inode, name, flags);
-        if (IS_ERR(fp)) {
-                err = PTR_ERR(fp);
+        dentry = get_xa_file_dentry(inode, name, flags);
+        if (IS_ERR(dentry)) {
+                err = PTR_ERR(dentry);
                 goto out;
         }
 
-        xinode = fp->f_path.dentry->d_inode;
+        xinode = dentry->d_inode;
         REISERFS_I(inode)->i_flags |= i_has_xattr_dir;
 
         /* we need to copy it off.. */
         if (xinode->i_nlink > 1) {
-                fput(fp);
+                dput(dentry);
                 err = reiserfs_xattr_del(inode, name);
                 if (err < 0)
                         goto out;
@@ -485,7 +459,7 @@ reiserfs_xattr_set(struct inode *inode, const char *name, const void *buffer,
         newattrs.ia_size = buffer_size;
         newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME;
         mutex_lock_nested(&xinode->i_mutex, I_MUTEX_XATTR);
-        err = notify_change(fp->f_path.dentry, &newattrs);
+        err = notify_change(dentry, &newattrs);
         if (err)
                 goto out_filp;
 
@@ -518,15 +492,14 @@ reiserfs_xattr_set(struct inode *inode, const char *name, const void *buffer,
                         rxh->h_hash = cpu_to_le32(xahash);
                 }
 
-                err = reiserfs_prepare_write(fp, page, page_offset,
+                err = reiserfs_prepare_write(NULL, page, page_offset,
                                             page_offset + chunk + skip);
                 if (!err) {
                         if (buffer)
                                 memcpy(data + skip, buffer + buffer_pos, chunk);
-                        err =
-                            reiserfs_commit_write(fp, page, page_offset,
-                                                  page_offset + chunk +
-                                                  skip);
+                        err = reiserfs_commit_write(NULL, page, page_offset,
+                                                    page_offset + chunk +
+                                                    skip);
                 }
                 unlock_page(page);
                 reiserfs_put_page(page);
@@ -548,7 +521,7 @@ reiserfs_xattr_set(struct inode *inode, const char *name, const void *buffer,
 
       out_filp:
         mutex_unlock(&xinode->i_mutex);
-        fput(fp);
+        dput(dentry);
 
       out:
         return err;
@@ -562,7 +535,7 @@ reiserfs_xattr_get(const struct inode *inode, const char *name, void *buffer,
                    size_t buffer_size)
 {
         ssize_t err = 0;
-        struct file *fp;
+        struct dentry *dentry;
         size_t isize;
         size_t file_pos = 0;
         size_t buffer_pos = 0;
@@ -578,13 +551,13 @@ reiserfs_xattr_get(const struct inode *inode, const char *name, void *buffer,
         if (get_inode_sd_version(inode) == STAT_DATA_V1)
                 return -EOPNOTSUPP;
 
-        fp = open_xa_file(inode, name, FL_READONLY);
-        if (IS_ERR(fp)) {
-                err = PTR_ERR(fp);
+        dentry = get_xa_file_dentry(inode, name, FL_READONLY);
+        if (IS_ERR(dentry)) {
+                err = PTR_ERR(dentry);
                 goto out;
         }
 
-        xinode = fp->f_path.dentry->d_inode;
+        xinode = dentry->d_inode;
         isize = xinode->i_size;
         REISERFS_I(inode)->i_flags |= i_has_xattr_dir;
 
@@ -652,7 +625,7 @@ reiserfs_xattr_get(const struct inode *inode, const char *name, void *buffer,
         }
 
       out_dput:
-        fput(fp);
+        dput(dentry);
 
       out:
         return err;
@@ -742,7 +715,6 @@ reiserfs_delete_xattrs_filler(void *buf, const char *name, int namelen,
 /* This is called w/ inode->i_mutex downed */
 int reiserfs_delete_xattrs(struct inode *inode)
 {
-        struct file *fp;
         struct dentry *dir, *root;
         int err = 0;
 
@@ -763,15 +735,8 @@ int reiserfs_delete_xattrs(struct inode *inode)
                 return 0;
         }
 
-        fp = dentry_open(dir, NULL, O_RDWR);
-        if (IS_ERR(fp)) {
-                err = PTR_ERR(fp);
-                /* dentry_open dputs the dentry if it fails */
-                goto out;
-        }
-
         lock_kernel();
-        err = xattr_readdir(fp, reiserfs_delete_xattrs_filler, dir);
+        err = xattr_readdir(dir->d_inode, reiserfs_delete_xattrs_filler, dir);
         if (err) {
                 unlock_kernel();
                 goto out_dir;
@@ -791,7 +756,7 @@ int reiserfs_delete_xattrs(struct inode *inode)
         unlock_kernel();
 
       out_dir:
-        fput(fp);
+        dput(dir);
 
       out:
         if (!err)
@@ -833,7 +798,6 @@ reiserfs_chown_xattrs_filler(void *buf, const char *name, int namelen,
 
 int reiserfs_chown_xattrs(struct inode *inode, struct iattr *attrs)
 {
-        struct file *fp;
         struct dentry *dir;
         int err = 0;
         struct reiserfs_chown_buf buf;
@@ -857,13 +821,6 @@ int reiserfs_chown_xattrs(struct inode *inode, struct iattr *attrs)
                 goto out;
         }
 
-        fp = dentry_open(dir, NULL, O_RDWR);
-        if (IS_ERR(fp)) {
-                err = PTR_ERR(fp);
-                /* dentry_open dputs the dentry if it fails */
-                goto out;
-        }
-
         lock_kernel();
 
         attrs->ia_valid &= (ATTR_UID | ATTR_GID | ATTR_CTIME);
@@ -871,7 +828,7 @@ int reiserfs_chown_xattrs(struct inode *inode, struct iattr *attrs)
         buf.attrs = attrs;
         buf.inode = inode;
 
-        err = xattr_readdir(fp, reiserfs_chown_xattrs_filler, &buf);
+        err = xattr_readdir(dir->d_inode, reiserfs_chown_xattrs_filler, &buf);
         if (err) {
                 unlock_kernel();
                 goto out_dir;
@@ -881,7 +838,7 @@ int reiserfs_chown_xattrs(struct inode *inode, struct iattr *attrs)
         unlock_kernel();
 
       out_dir:
-        fput(fp);
+        dput(dir);
 
       out:
         attrs->ia_valid = ia_valid;
@@ -1029,7 +986,6 @@ reiserfs_listxattr_filler(void *buf, const char *name, int namelen,
  */
 ssize_t reiserfs_listxattr(struct dentry * dentry, char *buffer, size_t size)
 {
-        struct file *fp;
         struct dentry *dir;
         int err = 0;
         struct reiserfs_listxattr_buf buf;
@@ -1052,13 +1008,6 @@ ssize_t reiserfs_listxattr(struct dentry * dentry, char *buffer, size_t size)
                 goto out;
         }
 
-        fp = dentry_open(dir, NULL, O_RDWR);
-        if (IS_ERR(fp)) {
-                err = PTR_ERR(fp);
-                /* dentry_open dputs the dentry if it fails */
-                goto out;
-        }
-
         buf.r_buf = buffer;
         buf.r_size = buffer ? size : 0;
         buf.r_pos = 0;
@@ -1066,7 +1015,7 @@ ssize_t reiserfs_listxattr(struct dentry * dentry, char *buffer, size_t size)
 
         REISERFS_I(dentry->d_inode)->i_flags |= i_has_xattr_dir;
 
-        err = xattr_readdir(fp, reiserfs_listxattr_filler, &buf);
+        err = xattr_readdir(dir->d_inode, reiserfs_listxattr_filler, &buf);
         if (err)
                 goto out_dir;
 
@@ -1076,7 +1025,7 @@ ssize_t reiserfs_listxattr(struct dentry * dentry, char *buffer, size_t size)
                 err = buf.r_pos;
 
       out_dir:
-        fput(fp);
+        dput(dir);
 
       out:
         reiserfs_read_unlock_xattr_i(dentry->d_inode);