123 files changed, 5467 insertions, 1992 deletions

diff --git a/drivers/acpi/acpica/hwvalid.c b/drivers/acpi/acpica/hwvalid.c
index bd3c937b0ac0..7737afb157c3 100644
--- a/drivers/acpi/acpica/hwvalid.c
+++ b/drivers/acpi/acpica/hwvalid.c
@@ -90,7 +90,6 @@ static const struct acpi_port_info acpi_protected_ports[] = {
         {"PIT2", 0x0048, 0x004B, ACPI_OSI_WIN_XP},
         {"RTC", 0x0070, 0x0071, ACPI_OSI_WIN_XP},
         {"CMOS", 0x0074, 0x0076, ACPI_OSI_WIN_XP},
-        {"DMA1", 0x0081, 0x0083, ACPI_OSI_WIN_XP},
         {"DMA1L", 0x0087, 0x0087, ACPI_OSI_WIN_XP},
         {"DMA2", 0x0089, 0x008B, ACPI_OSI_WIN_XP},
         {"DMA2L", 0x008F, 0x008F, ACPI_OSI_WIN_XP},
diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c
index 05dfdc96802e..d0d550d22a6d 100644
--- a/drivers/acpi/proc.c
+++ b/drivers/acpi/proc.c
@@ -343,9 +343,6 @@ acpi_system_write_alarm(struct file *file,
 }
 #endif                          /* HAVE_ACPI_LEGACY_ALARM */
 
-extern struct list_head acpi_wakeup_device_list;
-extern spinlock_t acpi_device_lock;
-
 static int
 acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset)
 {
@@ -353,7 +350,7 @@ acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset)
 
         seq_printf(seq, "Device\tS-state\t  Status   Sysfs node\n");
 
-        spin_lock(&acpi_device_lock);
+        mutex_lock(&acpi_device_lock);
         list_for_each_safe(node, next, &acpi_wakeup_device_list) {
                 struct acpi_device *dev =
                     container_of(node, struct acpi_device, wakeup_list);
@@ -361,7 +358,6 @@ acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset)
 
                 if (!dev->wakeup.flags.valid)
                         continue;
-                spin_unlock(&acpi_device_lock);
 
                 ldev = acpi_get_physical_device(dev->handle);
                 seq_printf(seq, "%s\t  S%d\t%c%-8s  ",
@@ -376,9 +372,8 @@ acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset)
                 seq_printf(seq, "\n");
                 put_device(ldev);
 
-                spin_lock(&acpi_device_lock);
         }
-        spin_unlock(&acpi_device_lock);
+        mutex_unlock(&acpi_device_lock);
         return 0;
 }
 
@@ -409,7 +404,7 @@ acpi_system_write_wakeup_device(struct file *file,
         strbuf[len] = '\0';
         sscanf(strbuf, "%s", str);
 
-        spin_lock(&acpi_device_lock);
+        mutex_lock(&acpi_device_lock);
         list_for_each_safe(node, next, &acpi_wakeup_device_list) {
                 struct acpi_device *dev =
                     container_of(node, struct acpi_device, wakeup_list);
@@ -446,7 +441,7 @@ acpi_system_write_wakeup_device(struct file *file,
                         }
                 }
         }
-        spin_unlock(&acpi_device_lock);
+        mutex_unlock(&acpi_device_lock);
         return count;
 }
 
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 4e6e758bd397..6fe121434ffb 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -145,6 +145,9 @@ static void acpi_timer_check_state(int state, struct acpi_processor *pr,
         struct acpi_processor_power *pwr = &pr->power;
         u8 type = local_apic_timer_c2_ok ? ACPI_STATE_C3 : ACPI_STATE_C2;
 
+        if (cpu_has(&cpu_data(pr->id), X86_FEATURE_ARAT))
+                return;
+
         /*
          * Check, if one of the previous states already marked the lapic
          * unstable
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 20c23c049207..8ff510b91d88 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -24,7 +24,7 @@ extern struct acpi_device *acpi_root;
 
 static LIST_HEAD(acpi_device_list);
 static LIST_HEAD(acpi_bus_id_list);
-DEFINE_SPINLOCK(acpi_device_lock);
+DEFINE_MUTEX(acpi_device_lock);
 LIST_HEAD(acpi_wakeup_device_list);
 
 struct acpi_device_bus_id{
@@ -491,7 +491,6 @@ static int acpi_device_register(struct acpi_device *device,
          */
         INIT_LIST_HEAD(&device->children);
         INIT_LIST_HEAD(&device->node);
-        INIT_LIST_HEAD(&device->g_list);
         INIT_LIST_HEAD(&device->wakeup_list);
 
         new_bus_id = kzalloc(sizeof(struct acpi_device_bus_id), GFP_KERNEL);
@@ -500,7 +499,7 @@ static int acpi_device_register(struct acpi_device *device,
                 return -ENOMEM;
         }
 
-        spin_lock(&acpi_device_lock);
+        mutex_lock(&acpi_device_lock);
         /*
          * Find suitable bus_id and instance number in acpi_bus_id_list
          * If failed, create one and link it into acpi_bus_id_list
@@ -521,14 +520,12 @@ static int acpi_device_register(struct acpi_device *device,
         }
         dev_set_name(&device->dev, "%s:%02x", acpi_device_bus_id->bus_id, acpi_device_bus_id->instance_no);
 
-        if (device->parent) {
+        if (device->parent)
                 list_add_tail(&device->node, &device->parent->children);
-                list_add_tail(&device->g_list, &device->parent->g_list);
-        } else
-                list_add_tail(&device->g_list, &acpi_device_list);
+
         if (device->wakeup.flags.valid)
                 list_add_tail(&device->wakeup_list, &acpi_wakeup_device_list);
-        spin_unlock(&acpi_device_lock);
+        mutex_unlock(&acpi_device_lock);
 
         if (device->parent)
                 device->dev.parent = &parent->dev;
@@ -549,28 +546,22 @@ static int acpi_device_register(struct acpi_device *device,
         device->removal_type = ACPI_BUS_REMOVAL_NORMAL;
         return 0;
   end:
-        spin_lock(&acpi_device_lock);
-        if (device->parent) {
+        mutex_lock(&acpi_device_lock);
+        if (device->parent)
                 list_del(&device->node);
-                list_del(&device->g_list);
-        } else
-                list_del(&device->g_list);
         list_del(&device->wakeup_list);
-        spin_unlock(&acpi_device_lock);
+        mutex_unlock(&acpi_device_lock);
         return result;
 }
 
 static void acpi_device_unregister(struct acpi_device *device, int type)
 {
-        spin_lock(&acpi_device_lock);
-        if (device->parent) {
+        mutex_lock(&acpi_device_lock);
+        if (device->parent)
                 list_del(&device->node);
-                list_del(&device->g_list);
-        } else
-                list_del(&device->g_list);
 
         list_del(&device->wakeup_list);
-        spin_unlock(&acpi_device_lock);
+        mutex_unlock(&acpi_device_lock);
 
         acpi_detach_data(device->handle, acpi_bus_data_handler);
 
diff --git a/drivers/acpi/sleep.h b/drivers/acpi/sleep.h
index cfaf8f5b0a14..8a8f3b3382a6 100644
--- a/drivers/acpi/sleep.h
+++ b/drivers/acpi/sleep.h
@@ -5,3 +5,6 @@ extern int acpi_suspend (u32 state);
 extern void acpi_enable_wakeup_device_prep(u8 sleep_state);
 extern void acpi_enable_wakeup_device(u8 sleep_state);
 extern void acpi_disable_wakeup_device(u8 sleep_state);
+
+extern struct list_head acpi_wakeup_device_list;
+extern struct mutex acpi_device_lock;
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index e8c143caf0fd..9cd15e8c8932 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -98,6 +98,7 @@ MODULE_PARM_DESC(psv, "Disable or override all passive trip points.");
 static int acpi_thermal_add(struct acpi_device *device);
 static int acpi_thermal_remove(struct acpi_device *device, int type);
 static int acpi_thermal_resume(struct acpi_device *device);
+static void acpi_thermal_notify(struct acpi_device *device, u32 event);
 static int acpi_thermal_state_open_fs(struct inode *inode, struct file *file);
 static int acpi_thermal_temp_open_fs(struct inode *inode, struct file *file);
 static int acpi_thermal_trip_open_fs(struct inode *inode, struct file *file);
@@ -123,6 +124,7 @@ static struct acpi_driver acpi_thermal_driver = {
                 .add = acpi_thermal_add,
                 .remove = acpi_thermal_remove,
                 .resume = acpi_thermal_resume,
+                .notify = acpi_thermal_notify,
                 },
 };
 
@@ -192,6 +194,7 @@ struct acpi_thermal {
         struct acpi_handle_list devices;
         struct thermal_zone_device *thermal_zone;
         int tz_enabled;
+        int kelvin_offset;
         struct mutex lock;
 };
 
@@ -581,7 +584,7 @@ static void acpi_thermal_check(void *data)
 }
 
 /* sys I/F for generic thermal sysfs support */
-#define KELVIN_TO_MILLICELSIUS(t) (t * 100 - 273200)
+#define KELVIN_TO_MILLICELSIUS(t, off) (((t) - (off)) * 100)
 
 static int thermal_get_temp(struct thermal_zone_device *thermal,
                             unsigned long *temp)
@@ -596,7 +599,7 @@ static int thermal_get_temp(struct thermal_zone_device *thermal,
         if (result)
                 return result;
 
-        *temp = KELVIN_TO_MILLICELSIUS(tz->temperature);
+        *temp = KELVIN_TO_MILLICELSIUS(tz->temperature, tz->kelvin_offset);
         return 0;
 }
 
@@ -702,7 +705,8 @@ static int thermal_get_trip_temp(struct thermal_zone_device *thermal,
         if (tz->trips.critical.flags.valid) {
                 if (!trip) {
                         *temp = KELVIN_TO_MILLICELSIUS(
-                                tz->trips.critical.temperature);
+                                tz->trips.critical.temperature,
+                                tz->kelvin_offset);
                         return 0;
                 }
                 trip--;
@@ -711,7 +715,8 @@ static int thermal_get_trip_temp(struct thermal_zone_device *thermal,
         if (tz->trips.hot.flags.valid) {
                 if (!trip) {
                         *temp = KELVIN_TO_MILLICELSIUS(
-                                tz->trips.hot.temperature);
+                                tz->trips.hot.temperature,
+                                tz->kelvin_offset);
                         return 0;
                 }
                 trip--;
@@ -720,7 +725,8 @@ static int thermal_get_trip_temp(struct thermal_zone_device *thermal,
         if (tz->trips.passive.flags.valid) {
                 if (!trip) {
                         *temp = KELVIN_TO_MILLICELSIUS(
-                                tz->trips.passive.temperature);
+                                tz->trips.passive.temperature,
+                                tz->kelvin_offset);
                         return 0;
                 }
                 trip--;
@@ -730,7 +736,8 @@ static int thermal_get_trip_temp(struct thermal_zone_device *thermal,
                 tz->trips.active[i].flags.valid; i++) {
                 if (!trip) {
                         *temp = KELVIN_TO_MILLICELSIUS(
-                                tz->trips.active[i].temperature);
+                                tz->trips.active[i].temperature,
+                                tz->kelvin_offset);
                         return 0;
                 }
                 trip--;
@@ -745,7 +752,8 @@ static int thermal_get_crit_temp(struct thermal_zone_device *thermal,
 
         if (tz->trips.critical.flags.valid) {
                 *temperature = KELVIN_TO_MILLICELSIUS(
-                                tz->trips.critical.temperature);
+                                tz->trips.critical.temperature,
+                                tz->kelvin_offset);
                 return 0;
         } else
                 return -EINVAL;
@@ -1264,17 +1272,14 @@ static int acpi_thermal_remove_fs(struct acpi_device *device)
                                  Driver Interface
    -------------------------------------------------------------------------- */
 
-static void acpi_thermal_notify(acpi_handle handle, u32 event, void *data)
+static void acpi_thermal_notify(struct acpi_device *device, u32 event)
 {
-        struct acpi_thermal *tz = data;
-        struct acpi_device *device = NULL;
+        struct acpi_thermal *tz = acpi_driver_data(device);
 
 
         if (!tz)
                 return;
 
-        device = tz->device;
-
         switch (event) {
         case ACPI_THERMAL_NOTIFY_TEMPERATURE:
                 acpi_thermal_check(tz);
@@ -1298,8 +1303,6 @@ static void acpi_thermal_notify(acpi_handle handle, u32 event, void *data)
                                   "Unsupported event [0x%x]\n", event));
                 break;
         }
-
-        return;
 }
 
 static int acpi_thermal_get_info(struct acpi_thermal *tz)
@@ -1334,10 +1337,28 @@ static int acpi_thermal_get_info(struct acpi_thermal *tz)
         return 0;
 }
 
+/*
+ * The exact offset between Kelvin and degree Celsius is 273.15. However ACPI
+ * handles temperature values with a single decimal place. As a consequence,
+ * some implementations use an offset of 273.1 and others use an offset of
+ * 273.2. Try to find out which one is being used, to present the most
+ * accurate and visually appealing number.
+ *
+ * The heuristic below should work for all ACPI thermal zones which have a
+ * critical trip point with a value being a multiple of 0.5 degree Celsius.
+ */
+static void acpi_thermal_guess_offset(struct acpi_thermal *tz)
+{
+        if (tz->trips.critical.flags.valid &&
+            (tz->trips.critical.temperature % 5) == 1)
+                tz->kelvin_offset = 2731;
+        else
+                tz->kelvin_offset = 2732;
+}
+
 static int acpi_thermal_add(struct acpi_device *device)
 {
         int result = 0;
-        acpi_status status = AE_OK;
         struct acpi_thermal *tz = NULL;
 
 
@@ -1360,6 +1381,8 @@ static int acpi_thermal_add(struct acpi_device *device)
         if (result)
                 goto free_memory;
 
+        acpi_thermal_guess_offset(tz);
+
         result = acpi_thermal_register_thermal_zone(tz);
         if (result)
                 goto free_memory;
@@ -1368,21 +1391,11 @@ static int acpi_thermal_add(struct acpi_device *device)
         if (result)
                 goto unregister_thermal_zone;
 
-        status = acpi_install_notify_handler(device->handle,
-                                             ACPI_DEVICE_NOTIFY,
-                                             acpi_thermal_notify, tz);
-        if (ACPI_FAILURE(status)) {
-                result = -ENODEV;
-                goto remove_fs;
-        }
-
         printk(KERN_INFO PREFIX "%s [%s] (%ld C)\n",
                acpi_device_name(device), acpi_device_bid(device),
                KELVIN_TO_CELSIUS(tz->temperature));
         goto end;
 
-remove_fs:
-        acpi_thermal_remove_fs(device);
 unregister_thermal_zone:
         thermal_zone_device_unregister(tz->thermal_zone);
 free_memory:
@@ -1393,7 +1406,6 @@ end:
 
 static int acpi_thermal_remove(struct acpi_device *device, int type)
 {
-        acpi_status status = AE_OK;
         struct acpi_thermal *tz = NULL;
 
         if (!device || !acpi_driver_data(device))
@@ -1401,10 +1413,6 @@ static int acpi_thermal_remove(struct acpi_device *device, int type)
 
         tz = acpi_driver_data(device);
 
-        status = acpi_remove_notify_handler(device->handle,
-                                            ACPI_DEVICE_NOTIFY,
-                                            acpi_thermal_notify);
-
         acpi_thermal_remove_fs(device);
         acpi_thermal_unregister_thermal_zone(tz);
         mutex_destroy(&tz->lock);
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index ab06143672bc..cd4fb7543a90 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -79,6 +79,7 @@ module_param(brightness_switch_enabled, bool, 0644);
 static int acpi_video_bus_add(struct acpi_device *device);
 static int acpi_video_bus_remove(struct acpi_device *device, int type);
 static int acpi_video_resume(struct acpi_device *device);
+static void acpi_video_bus_notify(struct acpi_device *device, u32 event);
 
 static const struct acpi_device_id video_device_ids[] = {
         {ACPI_VIDEO_HID, 0},
@@ -94,6 +95,7 @@ static struct acpi_driver acpi_video_bus = {
                 .add = acpi_video_bus_add,
                 .remove = acpi_video_bus_remove,
                 .resume = acpi_video_resume,
+                .notify = acpi_video_bus_notify,
                 },
 };
 
@@ -1986,17 +1988,15 @@ static int acpi_video_bus_stop_devices(struct acpi_video_bus *video)
         return acpi_video_bus_DOS(video, 0, 1);
 }
 
-static void acpi_video_bus_notify(acpi_handle handle, u32 event, void *data)
+static void acpi_video_bus_notify(struct acpi_device *device, u32 event)
 {
-        struct acpi_video_bus *video = data;
-        struct acpi_device *device = NULL;
+        struct acpi_video_bus *video = acpi_driver_data(device);
         struct input_dev *input;
         int keycode;
 
         if (!video)
                 return;
 
-        device = video->device;
         input = video->input;
 
         switch (event) {
@@ -2127,7 +2127,6 @@ static int acpi_video_resume(struct acpi_device *device)
 
 static int acpi_video_bus_add(struct acpi_device *device)
 {
-        acpi_status status;
         struct acpi_video_bus *video;
         struct input_dev *input;
         int error;
@@ -2169,20 +2168,10 @@ static int acpi_video_bus_add(struct acpi_device *device)
         acpi_video_bus_get_devices(video, device);
         acpi_video_bus_start_devices(video);
 
-        status = acpi_install_notify_handler(device->handle,
-                                             ACPI_DEVICE_NOTIFY,
-                                             acpi_video_bus_notify, video);
-        if (ACPI_FAILURE(status)) {
-                printk(KERN_ERR PREFIX
-                                  "Error installing notify handler\n");
-                error = -ENODEV;
-                goto err_stop_video;
-        }
-
         video->input = input = input_allocate_device();
         if (!input) {
                 error = -ENOMEM;
-                goto err_uninstall_notify;
+                goto err_stop_video;
         }
 
         snprintf(video->phys, sizeof(video->phys),
@@ -2218,9 +2207,6 @@ static int acpi_video_bus_add(struct acpi_device *device)
 
  err_free_input_dev:
         input_free_device(input);
- err_uninstall_notify:
-        acpi_remove_notify_handler(device->handle, ACPI_DEVICE_NOTIFY,
-                                   acpi_video_bus_notify);
  err_stop_video:
         acpi_video_bus_stop_devices(video);
         acpi_video_bus_put_devices(video);
@@ -2235,7 +2221,6 @@ static int acpi_video_bus_add(struct acpi_device *device)
 
 static int acpi_video_bus_remove(struct acpi_device *device, int type)
 {
-        acpi_status status = 0;
         struct acpi_video_bus *video = NULL;
 
 
@@ -2245,11 +2230,6 @@ static int acpi_video_bus_remove(struct acpi_device *device, int type)
         video = acpi_driver_data(device);
 
         acpi_video_bus_stop_devices(video);
-
-        status = acpi_remove_notify_handler(video->device->handle,
-                                            ACPI_DEVICE_NOTIFY,
-                                            acpi_video_bus_notify);
-
         acpi_video_bus_put_devices(video);
         acpi_video_bus_remove_fs(device);
 
diff --git a/drivers/acpi/wakeup.c b/drivers/acpi/wakeup.c
index 5aee8c26cc9f..88725dcdf8bc 100644
--- a/drivers/acpi/wakeup.c
+++ b/drivers/acpi/wakeup.c
@@ -12,12 +12,14 @@
 #include "internal.h"
 #include "sleep.h"
 
+/*
+ * We didn't lock acpi_device_lock in the file, because it invokes oops in
+ * suspend/resume and isn't really required as this is called in S-state. At
+ * that time, there is no device hotplug
+ **/
 #define _COMPONENT              ACPI_SYSTEM_COMPONENT
 ACPI_MODULE_NAME("wakeup_devices")
 
-extern struct list_head acpi_wakeup_device_list;
-extern spinlock_t acpi_device_lock;
-
 /**
  * acpi_enable_wakeup_device_prep - prepare wakeup devices
  *      @sleep_state:   ACPI state
@@ -29,7 +31,6 @@ void acpi_enable_wakeup_device_prep(u8 sleep_state)
 {
         struct list_head *node, *next;
 
-        spin_lock(&acpi_device_lock);
         list_for_each_safe(node, next, &acpi_wakeup_device_list) {
                 struct acpi_device *dev = container_of(node,
                                                        struct acpi_device,
@@ -40,11 +41,8 @@ void acpi_enable_wakeup_device_prep(u8 sleep_state)
                     (sleep_state > (u32) dev->wakeup.sleep_state))
                         continue;
 
-                spin_unlock(&acpi_device_lock);
                 acpi_enable_wakeup_device_power(dev, sleep_state);
-                spin_lock(&acpi_device_lock);
         }
-        spin_unlock(&acpi_device_lock);
 }
 
 /**
@@ -60,7 +58,6 @@ void acpi_enable_wakeup_device(u8 sleep_state)
          * Caution: this routine must be invoked when interrupt is disabled 
          * Refer ACPI2.0: P212
          */
-        spin_lock(&acpi_device_lock);
         list_for_each_safe(node, next, &acpi_wakeup_device_list) {
                 struct acpi_device *dev =
                         container_of(node, struct acpi_device, wakeup_list);
@@ -74,22 +71,17 @@ void acpi_enable_wakeup_device(u8 sleep_state)
                 if ((!dev->wakeup.state.enabled && !dev->wakeup.flags.prepared)
                     || sleep_state > (u32) dev->wakeup.sleep_state) {
                         if (dev->wakeup.flags.run_wake) {
-                                spin_unlock(&acpi_device_lock);
                                 /* set_gpe_type will disable GPE, leave it like that */
                                 acpi_set_gpe_type(dev->wakeup.gpe_device,
                                                   dev->wakeup.gpe_number,
                                                   ACPI_GPE_TYPE_RUNTIME);
-                                spin_lock(&acpi_device_lock);
                         }
                         continue;
                 }
-                spin_unlock(&acpi_device_lock);
                 if (!dev->wakeup.flags.run_wake)
                         acpi_enable_gpe(dev->wakeup.gpe_device,
                                         dev->wakeup.gpe_number);
-                spin_lock(&acpi_device_lock);
         }
-        spin_unlock(&acpi_device_lock);
 }
 
 /**
@@ -101,7 +93,6 @@ void acpi_disable_wakeup_device(u8 sleep_state)
 {
         struct list_head *node, *next;
 
-        spin_lock(&acpi_device_lock);
         list_for_each_safe(node, next, &acpi_wakeup_device_list) {
                 struct acpi_device *dev =
                         container_of(node, struct acpi_device, wakeup_list);
@@ -112,19 +103,16 @@ void acpi_disable_wakeup_device(u8 sleep_state)
                 if ((!dev->wakeup.state.enabled && !dev->wakeup.flags.prepared)
                     || sleep_state > (u32) dev->wakeup.sleep_state) {
                         if (dev->wakeup.flags.run_wake) {
-                                spin_unlock(&acpi_device_lock);
                                 acpi_set_gpe_type(dev->wakeup.gpe_device,
                                                   dev->wakeup.gpe_number,
                                                   ACPI_GPE_TYPE_WAKE_RUN);
                                 /* Re-enable it, since set_gpe_type will disable it */
                                 acpi_enable_gpe(dev->wakeup.gpe_device,
                                                 dev->wakeup.gpe_number);
-                                spin_lock(&acpi_device_lock);
                         }
                         continue;
                 }
 
-                spin_unlock(&acpi_device_lock);
                 acpi_disable_wakeup_device_power(dev);
                 /* Never disable run-wake GPE */
                 if (!dev->wakeup.flags.run_wake) {
@@ -133,16 +121,14 @@ void acpi_disable_wakeup_device(u8 sleep_state)
                         acpi_clear_gpe(dev->wakeup.gpe_device,
                                        dev->wakeup.gpe_number, ACPI_NOT_ISR);
                 }
-                spin_lock(&acpi_device_lock);
         }
-        spin_unlock(&acpi_device_lock);
 }
 
 int __init acpi_wakeup_device_init(void)
 {
         struct list_head *node, *next;
 
-        spin_lock(&acpi_device_lock);
+        mutex_lock(&acpi_device_lock);
         list_for_each_safe(node, next, &acpi_wakeup_device_list) {
                 struct acpi_device *dev = container_of(node,
                                                        struct acpi_device,
@@ -150,15 +136,13 @@ int __init acpi_wakeup_device_init(void)
                 /* In case user doesn't load button driver */
                 if (!dev->wakeup.flags.run_wake || dev->wakeup.state.enabled)
                         continue;
-                spin_unlock(&acpi_device_lock);
                 acpi_set_gpe_type(dev->wakeup.gpe_device,
                                   dev->wakeup.gpe_number,
                                   ACPI_GPE_TYPE_WAKE_RUN);
                 acpi_enable_gpe(dev->wakeup.gpe_device,
                                 dev->wakeup.gpe_number);
                 dev->wakeup.state.enabled = 1;
-                spin_lock(&acpi_device_lock);
         }
-        spin_unlock(&acpi_device_lock);
+        mutex_unlock(&acpi_device_lock);
         return 0;
 }
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 57be6bea48eb..08186ecbaf8d 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -114,6 +114,7 @@ enum {
         board_ahci_sb700        = 5, /* for SB700 and SB800 */
         board_ahci_mcp65        = 6,
         board_ahci_nopmp        = 7,
+        board_ahci_yesncq       = 8,
 
         /* global controller registers */
         HOST_CAP                = 0x00, /* host capabilities */
@@ -469,6 +470,14 @@ static const struct ata_port_info ahci_port_info[] = {
                 .udma_mask      = ATA_UDMA6,
                 .port_ops       = &ahci_ops,
         },
+        /* board_ahci_yesncq */
+        {
+                AHCI_HFLAGS     (AHCI_HFLAG_YES_NCQ),
+                .flags          = AHCI_FLAG_COMMON,
+                .pio_mask       = ATA_PIO4,
+                .udma_mask      = ATA_UDMA6,
+                .port_ops       = &ahci_ops,
+        },
 };
 
 static const struct pci_device_id ahci_pci_tbl[] = {
@@ -535,30 +544,30 @@ static const struct pci_device_id ahci_pci_tbl[] = {
         { PCI_VDEVICE(NVIDIA, 0x045d), board_ahci_mcp65 },      /* MCP65 */
         { PCI_VDEVICE(NVIDIA, 0x045e), board_ahci_mcp65 },      /* MCP65 */
         { PCI_VDEVICE(NVIDIA, 0x045f), board_ahci_mcp65 },      /* MCP65 */
-        { PCI_VDEVICE(NVIDIA, 0x0550), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x0551), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x0552), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x0553), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x0554), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x0555), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x0556), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x0557), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x0558), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x0559), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x055a), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x055b), board_ahci },            /* MCP67 */
-        { PCI_VDEVICE(NVIDIA, 0x07f0), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07f1), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07f2), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07f3), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07f4), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07f5), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07f6), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07f7), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07f8), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07f9), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07fa), board_ahci },            /* MCP73 */
-        { PCI_VDEVICE(NVIDIA, 0x07fb), board_ahci },            /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x0550), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x0551), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x0552), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x0553), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x0554), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x0555), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x0556), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x0557), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x0558), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x0559), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x055a), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x055b), board_ahci_yesncq },     /* MCP67 */
+        { PCI_VDEVICE(NVIDIA, 0x07f0), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07f1), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07f2), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07f3), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07f4), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07f5), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07f6), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07f7), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07f8), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07f9), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07fa), board_ahci_yesncq },     /* MCP73 */
+        { PCI_VDEVICE(NVIDIA, 0x07fb), board_ahci_yesncq },     /* MCP73 */
         { PCI_VDEVICE(NVIDIA, 0x0ad0), board_ahci },            /* MCP77 */
         { PCI_VDEVICE(NVIDIA, 0x0ad1), board_ahci },            /* MCP77 */
         { PCI_VDEVICE(NVIDIA, 0x0ad2), board_ahci },            /* MCP77 */
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index e7ea77cf6069..065507c46644 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6110,13 +6110,11 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)
                         ata_port_printk(ap, KERN_INFO, "DUMMY\n");
         }
 
-        /* perform each probe synchronously */
-        DPRINTK("probe begin\n");
+        /* perform each probe asynchronously */
         for (i = 0; i < host->n_ports; i++) {
                 struct ata_port *ap = host->ports[i];
                 async_schedule(async_port_probe, ap);
         }
-        DPRINTK("probe end\n");
 
         return 0;
 }
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 98e8c50703b3..bdd43c7f432e 100644
--- a/drivers/ata/sata_via.c
+++ b/drivers/ata/sata_via.c
@@ -566,7 +566,7 @@ static int svia_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
         static int printed_version;
         unsigned int i;
         int rc;
-        struct ata_host *host;
+        struct ata_host *host = NULL;
         int board_id = (int) ent->driver_data;
         const unsigned *bar_sizes;
 
diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
index 6cccdc3f5220..4aecf5dc6a93 100644
--- a/drivers/block/xsysace.c
+++ b/drivers/block/xsysace.c
@@ -563,7 +563,7 @@ static void ace_fsm_dostate(struct ace_device *ace)
         case ACE_FSM_STATE_IDENTIFY_PREPARE:
                 /* Send identify command */
                 ace->fsm_task = ACE_TASK_IDENTIFY;
-                ace->data_ptr = &ace->cf_id;
+                ace->data_ptr = ace->cf_id;
                 ace->data_count = ACE_BUF_PER_SECTOR;
                 ace_out(ace, ACE_SECCNTCMD, ACE_SECCNTCMD_IDENTIFY);
 
@@ -608,8 +608,8 @@ static void ace_fsm_dostate(struct ace_device *ace)
                 break;
 
         case ACE_FSM_STATE_IDENTIFY_COMPLETE:
-                ace_fix_driveid(&ace->cf_id[0]);
-                ace_dump_mem(&ace->cf_id, 512); /* Debug: Dump out disk ID */
+                ace_fix_driveid(ace->cf_id);
+                ace_dump_mem(ace->cf_id, 512);  /* Debug: Dump out disk ID */
 
                 if (ace->data_result) {
                         /* Error occured, disable the disk */
@@ -622,9 +622,9 @@ static void ace_fsm_dostate(struct ace_device *ace)
 
                         /* Record disk parameters */
                         set_capacity(ace->gd,
-                                ata_id_u32(&ace->cf_id, ATA_ID_LBA_CAPACITY));
+                                ata_id_u32(ace->cf_id, ATA_ID_LBA_CAPACITY));
                         dev_info(ace->dev, "capacity: %i sectors\n",
-                                ata_id_u32(&ace->cf_id, ATA_ID_LBA_CAPACITY));
+                                ata_id_u32(ace->cf_id, ATA_ID_LBA_CAPACITY));
                 }
 
                 /* We're done, drop to IDLE state and notify waiters */
@@ -923,7 +923,7 @@ static int ace_release(struct gendisk *disk, fmode_t mode)
 static int ace_getgeo(struct block_device *bdev, struct hd_geometry *geo)
 {
         struct ace_device *ace = bdev->bd_disk->private_data;
-        u16 *cf_id = &ace->cf_id[0];
+        u16 *cf_id = ace->cf_id;
 
         dev_dbg(ace->dev, "ace_getgeo()\n");
 
diff --git a/drivers/i2c/algos/i2c-algo-pca.c b/drivers/i2c/algos/i2c-algo-pca.c
index f68e5f8e23ee..6318f7ddc1d4 100644
--- a/drivers/i2c/algos/i2c-algo-pca.c
+++ b/drivers/i2c/algos/i2c-algo-pca.c
@@ -190,7 +190,7 @@ static int pca_xfer(struct i2c_adapter *i2c_adap,
         int completed = 1;
         unsigned long timeout = jiffies + i2c_adap->timeout;
 
-        while (pca_status(adap) != 0xf8) {
+        while ((state = pca_status(adap)) != 0xf8) {
                 if (time_before(jiffies, timeout)) {
                         msleep(10);
                 } else {
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 94eae5c3cbc7..a48c8aee0218 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -604,12 +604,14 @@ comment "Graphics adapter I2C/DDC channel drivers"
         depends on PCI
 
 config I2C_VOODOO3
-        tristate "Voodoo 3"
+        tristate "Voodoo 3 (DEPRECATED)"
         depends on PCI
         select I2C_ALGOBIT
         help
           If you say yes to this option, support will be included for the
-          Voodoo 3 I2C interface.
+          Voodoo 3 I2C interface. This driver is deprecated and you should
+          use the tdfxfb driver instead, which additionally provides
+          framebuffer support.
 
           This driver can also be built as a module.  If so, the module
           will be called i2c-voodoo3.
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index b6f3a0de6ca2..85e2e919d1cd 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -716,8 +716,7 @@ int i2c_register_driver(struct module *owner, struct i2c_driver *driver)
 
         /* new style driver methods can't mix with legacy ones */
         if (is_newstyle_driver(driver)) {
-                if (driver->attach_adapter || driver->detach_adapter
-                                || driver->detach_client) {
+                if (driver->detach_adapter || driver->detach_client) {
                         printk(KERN_WARNING
                                         "i2c-core: driver [%s] is confused\n",
                                         driver->driver.name);
diff --git a/drivers/ide/at91_ide.c b/drivers/ide/at91_ide.c
index 8eda552326e9..403d0e4265db 100644
--- a/drivers/ide/at91_ide.c
+++ b/drivers/ide/at91_ide.c
@@ -20,7 +20,6 @@
  *
  */
 
-#include <linux/version.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/clk.h>
@@ -175,90 +174,6 @@ static void at91_ide_output_data(ide_drive_t *drive, struct ide_cmd *cmd,
         leave_16bit(chipselect, mode);
 }
 
-static u8 ide_mm_inb(unsigned long port)
-{
-        return readb((void __iomem *) port);
-}
-
-static void ide_mm_outb(u8 value, unsigned long port)
-{
-        writeb(value, (void __iomem *) port);
-}
-
-static void at91_ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
-{
-        ide_hwif_t *hwif = drive->hwif;
-        struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-        u8 HIHI = (cmd->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF;
-
-        if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED)
-                HIHI = 0xFF;
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE)
-                ide_mm_outb(tf->hob_feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT)
-                ide_mm_outb(tf->hob_nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAL)
-                ide_mm_outb(tf->hob_lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAM)
-                ide_mm_outb(tf->hob_lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAH)
-                ide_mm_outb(tf->hob_lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_FEATURE)
-                ide_mm_outb(tf->feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_NSECT)
-                ide_mm_outb(tf->nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAL)
-                ide_mm_outb(tf->lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAM)
-                ide_mm_outb(tf->lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAH)
-                ide_mm_outb(tf->lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_DEVICE)
-                ide_mm_outb((tf->device & HIHI) | drive->select, io_ports->device_addr);
-}
-
-static void at91_ide_tf_read(ide_drive_t *drive, struct ide_cmd *cmd)
-{
-        ide_hwif_t *hwif = drive->hwif;
-        struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-
-        /* be sure we're looking at the low order bits */
-        ide_mm_outb(ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_IN_ERROR)
-                tf->error  = ide_mm_inb(io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_NSECT)
-                tf->nsect  = ide_mm_inb(io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAL)
-                tf->lbal   = ide_mm_inb(io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAM)
-                tf->lbam   = ide_mm_inb(io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAH)
-                tf->lbah   = ide_mm_inb(io_ports->lbah_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_DEVICE)
-                tf->device = ide_mm_inb(io_ports->device_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_LBA48) {
-                ide_mm_outb(ATA_HOB | ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_ERROR)
-                        tf->hob_error = ide_mm_inb(io_ports->feature_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_NSECT)
-                        tf->hob_nsect = ide_mm_inb(io_ports->nsect_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAL)
-                        tf->hob_lbal  = ide_mm_inb(io_ports->lbal_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAM)
-                        tf->hob_lbam  = ide_mm_inb(io_ports->lbam_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAH)
-                        tf->hob_lbah  = ide_mm_inb(io_ports->lbah_addr);
-        }
-}
-
 static void at91_ide_set_pio_mode(ide_drive_t *drive, const u8 pio)
 {
         struct ide_timing *timing;
@@ -284,8 +199,8 @@ static const struct ide_tp_ops at91_ide_tp_ops = {
         .write_devctl   = ide_write_devctl,
 
         .dev_select     = ide_dev_select,
-        .tf_load        = at91_ide_tf_load,
-        .tf_read        = at91_ide_tf_read,
+        .tf_load        = ide_tf_load,
+        .tf_read        = ide_tf_read,
 
         .input_data     = at91_ide_input_data,
         .output_data    = at91_ide_output_data,
@@ -300,7 +215,7 @@ static const struct ide_port_info at91_ide_port_info __initdata = {
         .tp_ops         = &at91_ide_tp_ops,
         .host_flags     = IDE_HFLAG_MMIO | IDE_HFLAG_NO_DMA | IDE_HFLAG_SINGLE |
                           IDE_HFLAG_NO_IO_32BIT | IDE_HFLAG_UNMASK_IRQS,
-        .pio_mask       = ATA_PIO5,
+        .pio_mask       = ATA_PIO6,
 };
 
 /*
diff --git a/drivers/ide/falconide.c b/drivers/ide/falconide.c
index afa2af9a362b..0e2df6755ec9 100644
--- a/drivers/ide/falconide.c
+++ b/drivers/ide/falconide.c
@@ -20,6 +20,7 @@
 #include <asm/atarihw.h>
 #include <asm/atariints.h>
 #include <asm/atari_stdma.h>
+#include <asm/ide.h>
 
 #define DRV_NAME "falconide"
 
@@ -67,8 +68,10 @@ static void falconide_input_data(ide_drive_t *drive, struct ide_cmd *cmd,
 {
         unsigned long data_addr = drive->hwif->io_ports.data_addr;
 
-        if (drive->media == ide_disk && cmd && (cmd->tf_flags & IDE_TFLAG_FS))
-                return insw(data_addr, buf, (len + 1) / 2);
+        if (drive->media == ide_disk && cmd && (cmd->tf_flags & IDE_TFLAG_FS)) {
+                __ide_mm_insw(data_addr, buf, (len + 1) / 2);
+                return;
+        }
 
         raw_insw_swapw((u16 *)data_addr, buf, (len + 1) / 2);
 }
@@ -78,8 +81,10 @@ static void falconide_output_data(ide_drive_t *drive, struct ide_cmd *cmd,
 {
         unsigned long data_addr = drive->hwif->io_ports.data_addr;
 
-        if (drive->media == ide_disk && cmd && (cmd->tf_flags & IDE_TFLAG_FS))
-                return outsw(data_addr, buf, (len + 1) / 2);
+        if (drive->media == ide_disk && cmd && (cmd->tf_flags & IDE_TFLAG_FS)) {
+                __ide_mm_outsw(data_addr, buf, (len + 1) / 2);
+                return;
+        }
 
         raw_outsw_swapw((u16 *)data_addr, buf, (len + 1) / 2);
 }
diff --git a/drivers/ide/ide-acpi.c b/drivers/ide/ide-acpi.c
index 12f436951bff..77f79d26b264 100644
--- a/drivers/ide/ide-acpi.c
+++ b/drivers/ide/ide-acpi.c
@@ -318,8 +318,9 @@ static int do_drive_set_taskfiles(ide_drive_t *drive,
 
                 /* convert GTF to taskfile */
                 memset(&cmd, 0, sizeof(cmd));
-                memcpy(&cmd.tf_array[7], gtf, REGS_PER_GTF);
-                cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+                memcpy(&cmd.tf.feature, gtf, REGS_PER_GTF);
+                cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+                cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
 
                 err = ide_no_data_taskfile(drive, &cmd);
                 if (err) {
diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c
index 3e43b889dd64..7201b176d75b 100644
--- a/drivers/ide/ide-atapi.c
+++ b/drivers/ide/ide-atapi.c
@@ -254,16 +254,13 @@ EXPORT_SYMBOL_GPL(ide_cd_get_xferlen);
 
 void ide_read_bcount_and_ireason(ide_drive_t *drive, u16 *bcount, u8 *ireason)
 {
-        struct ide_cmd cmd;
+        struct ide_taskfile tf;
 
-        memset(&cmd, 0, sizeof(cmd));
-        cmd.tf_flags = IDE_TFLAG_IN_LBAH | IDE_TFLAG_IN_LBAM |
-                       IDE_TFLAG_IN_NSECT;
+        drive->hwif->tp_ops->tf_read(drive, &tf, IDE_VALID_NSECT |
+                                     IDE_VALID_LBAM | IDE_VALID_LBAH);
 
-        drive->hwif->tp_ops->tf_read(drive, &cmd);
-
-        *bcount = (cmd.tf.lbah << 8) | cmd.tf.lbam;
-        *ireason = cmd.tf.nsect & 3;
+        *bcount = (tf.lbah << 8) | tf.lbam;
+        *ireason = tf.nsect & 3;
 }
 EXPORT_SYMBOL_GPL(ide_read_bcount_and_ireason);
 
@@ -439,12 +436,12 @@ static ide_startstop_t ide_pc_intr(ide_drive_t *drive)
         return ide_started;
 }
 
-static void ide_init_packet_cmd(struct ide_cmd *cmd, u32 tf_flags,
+static void ide_init_packet_cmd(struct ide_cmd *cmd, u8 valid_tf,
                                 u16 bcount, u8 dma)
 {
-        cmd->protocol  = dma ? ATAPI_PROT_DMA : ATAPI_PROT_PIO;
-        cmd->tf_flags |= IDE_TFLAG_OUT_LBAH | IDE_TFLAG_OUT_LBAM |
-                         IDE_TFLAG_OUT_FEATURE | tf_flags;
+        cmd->protocol = dma ? ATAPI_PROT_DMA : ATAPI_PROT_PIO;
+        cmd->valid.out.tf = IDE_VALID_LBAH | IDE_VALID_LBAM |
+                            IDE_VALID_FEATURE | valid_tf;
         cmd->tf.command = ATA_CMD_PACKET;
         cmd->tf.feature = dma;          /* Use PIO/DMA */
         cmd->tf.lbam    = bcount & 0xff;
@@ -453,14 +450,11 @@ static void ide_init_packet_cmd(struct ide_cmd *cmd, u32 tf_flags,
 
 static u8 ide_read_ireason(ide_drive_t *drive)
 {
-        struct ide_cmd cmd;
-
-        memset(&cmd, 0, sizeof(cmd));
-        cmd.tf_flags = IDE_TFLAG_IN_NSECT;
+        struct ide_taskfile tf;
 
-        drive->hwif->tp_ops->tf_read(drive, &cmd);
+        drive->hwif->tp_ops->tf_read(drive, &tf, IDE_VALID_NSECT);
 
-        return cmd.tf.nsect & 3;
+        return tf.nsect & 3;
 }
 
 static u8 ide_wait_ireason(ide_drive_t *drive, u8 ireason)
@@ -588,12 +582,12 @@ ide_startstop_t ide_issue_pc(ide_drive_t *drive, struct ide_cmd *cmd)
         ide_expiry_t *expiry = NULL;
         struct request *rq = hwif->rq;
         unsigned int timeout;
-        u32 tf_flags;
         u16 bcount;
+        u8 valid_tf;
         u8 drq_int = !!(drive->atapi_flags & IDE_AFLAG_DRQ_INTERRUPT);
 
         if (dev_is_idecd(drive)) {
-                tf_flags = IDE_TFLAG_OUT_NSECT | IDE_TFLAG_OUT_LBAL;
+                valid_tf = IDE_VALID_NSECT | IDE_VALID_LBAL;
                 bcount = ide_cd_get_xferlen(rq);
                 expiry = ide_cd_expiry;
                 timeout = ATAPI_WAIT_PC;
@@ -607,7 +601,7 @@ ide_startstop_t ide_issue_pc(ide_drive_t *drive, struct ide_cmd *cmd)
                 pc->xferred = 0;
                 pc->cur_pos = pc->buf;
 
-                tf_flags = IDE_TFLAG_OUT_DEVICE;
+                valid_tf = IDE_VALID_DEVICE;
                 bcount = ((drive->media == ide_tape) ?
                                 pc->req_xfer :
                                 min(pc->req_xfer, 63 * 1024));
@@ -627,7 +621,7 @@ ide_startstop_t ide_issue_pc(ide_drive_t *drive, struct ide_cmd *cmd)
                                                        : WAIT_TAPE_CMD;
         }
 
-        ide_init_packet_cmd(cmd, tf_flags, bcount, drive->dma);
+        ide_init_packet_cmd(cmd, valid_tf, bcount, drive->dma);
 
         (void)do_rw_taskfile(drive, cmd);
 
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 35729a47f797..3aec19d1fdfc 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -265,35 +265,62 @@ static void ide_cd_complete_failed_rq(ide_drive_t *drive, struct request *rq)
                 cdrom_analyze_sense_data(drive, NULL, sense);
 }
 
+
 /*
+ * Allow the drive 5 seconds to recover; some devices will return NOT_READY
+ * while flushing data from cache.
+ *
+ * returns: 0 failed (write timeout expired)
+ *          1 success
+ */
+static int ide_cd_breathe(ide_drive_t *drive, struct request *rq)
+{
+
+        struct cdrom_info *info = drive->driver_data;
+
+        if (!rq->errors)
+                info->write_timeout = jiffies + ATAPI_WAIT_WRITE_BUSY;
+
+        rq->errors = 1;
+
+        if (time_after(jiffies, info->write_timeout))
+                return 0;
+        else {
+                struct request_queue *q = drive->queue;
+                unsigned long flags;
+
+                /*
+                 * take a breather relying on the unplug timer to kick us again
+                 */
+
+                spin_lock_irqsave(q->queue_lock, flags);
+                blk_plug_device(q);
+                spin_unlock_irqrestore(q->queue_lock, flags);
+
+                return 1;
+        }
+}
+
+/**
  * Returns:
  * 0: if the request should be continued.
  * 1: if the request will be going through error recovery.
  * 2: if the request should be ended.
  */
-static int cdrom_decode_status(ide_drive_t *drive, int good_stat, int *stat_ret)
+static int cdrom_decode_status(ide_drive_t *drive, u8 stat)
 {
         ide_hwif_t *hwif = drive->hwif;
         struct request *rq = hwif->rq;
-        int stat, err, sense_key;
-
-        /* check for errors */
-        stat = hwif->tp_ops->read_status(hwif);
-
-        if (stat_ret)
-                *stat_ret = stat;
-
-        if (OK_STAT(stat, good_stat, BAD_R_STAT))
-                return 0;
+        int err, sense_key, do_end_request = 0;
+        u8 quiet = rq->cmd_flags & REQ_QUIET;
 
         /* get the IDE error register */
         err = ide_read_error(drive);
         sense_key = err >> 4;
 
-        ide_debug_log(IDE_DBG_RQ, "stat: 0x%x, good_stat: 0x%x, cmd[0]: 0x%x, "
-                                  "rq->cmd_type: 0x%x, err: 0x%x",
-                                  stat, good_stat, rq->cmd[0], rq->cmd_type,
-                                  err);
+        ide_debug_log(IDE_DBG_RQ, "cmd: 0x%x, rq->cmd_type: 0x%x, err: 0x%x, "
+                                  "stat 0x%x",
+                                  rq->cmd[0], rq->cmd_type, err, stat);
 
         if (blk_sense_request(rq)) {
                 /*
@@ -303,151 +330,108 @@ static int cdrom_decode_status(ide_drive_t *drive, int good_stat, int *stat_ret)
                  */
                 rq->cmd_flags |= REQ_FAILED;
                 return 2;
-        } else if (blk_pc_request(rq) || rq->cmd_type == REQ_TYPE_ATA_PC) {
-                /* All other functions, except for READ. */
+        }
 
-                /*
-                 * if we have an error, pass back CHECK_CONDITION as the
-                 * scsi status byte
-                 */
-                if (blk_pc_request(rq) && !rq->errors)
-                        rq->errors = SAM_STAT_CHECK_CONDITION;
+        /* if we have an error, pass CHECK_CONDITION as the SCSI status byte */
+        if (blk_pc_request(rq) && !rq->errors)
+                rq->errors = SAM_STAT_CHECK_CONDITION;
 
-                /* check for tray open */
-                if (sense_key == NOT_READY) {
-                        cdrom_saw_media_change(drive);
-                } else if (sense_key == UNIT_ATTENTION) {
-                        /* check for media change */
+        if (blk_noretry_request(rq))
+                do_end_request = 1;
+
+        switch (sense_key) {
+        case NOT_READY:
+                if (blk_fs_request(rq) && rq_data_dir(rq) == WRITE) {
+                        if (ide_cd_breathe(drive, rq))
+                                return 1;
+                } else {
                         cdrom_saw_media_change(drive);
-                        return 0;
-                } else if (sense_key == ILLEGAL_REQUEST &&
-                           rq->cmd[0] == GPCMD_START_STOP_UNIT) {
-                        /*
-                         * Don't print error message for this condition--
-                         * SFF8090i indicates that 5/24/00 is the correct
-                         * response to a request to close the tray if the
-                         * drive doesn't have that capability.
-                         * cdrom_log_sense() knows this!
-                         */
-                } else if (!(rq->cmd_flags & REQ_QUIET)) {
-                        /* otherwise, print an error */
-                        ide_dump_status(drive, "packet command error", stat);
+
+                        if (blk_fs_request(rq) && !quiet)
+                                printk(KERN_ERR PFX "%s: tray open\n",
+                                        drive->name);
                 }
+                do_end_request = 1;
+                break;
+        case UNIT_ATTENTION:
+                cdrom_saw_media_change(drive);
 
-                rq->cmd_flags |= REQ_FAILED;
+                if (blk_fs_request(rq) == 0)
+                        return 0;
 
                 /*
-                 * instead of playing games with moving completions around,
-                 * remove failed request completely and end it when the
-                 * request sense has completed
+                 * Arrange to retry the request but be sure to give up if we've
+                 * retried too many times.
                  */
-                goto end_request;
-
-        } else if (blk_fs_request(rq)) {
-                int do_end_request = 0;
-
-                /* handle errors from READ and WRITE requests */
-
-                if (blk_noretry_request(rq))
+                if (++rq->errors > ERROR_MAX)
                         do_end_request = 1;
-
-                if (sense_key == NOT_READY) {
-                        /* tray open */
-                        if (rq_data_dir(rq) == READ) {
-                                cdrom_saw_media_change(drive);
-
-                                /* fail the request */
-                                printk(KERN_ERR PFX "%s: tray open\n",
-                                                drive->name);
-                                do_end_request = 1;
-                        } else {
-                                struct cdrom_info *info = drive->driver_data;
-
-                                /*
-                                 * Allow the drive 5 seconds to recover, some
-                                 * devices will return this error while flushing
-                                 * data from cache.
-                                 */
-                                if (!rq->errors)
-                                        info->write_timeout = jiffies +
-                                                        ATAPI_WAIT_WRITE_BUSY;
-                                rq->errors = 1;
-                                if (time_after(jiffies, info->write_timeout))
-                                        do_end_request = 1;
-                                else {
-                                        struct request_queue *q = drive->queue;
-                                        unsigned long flags;
-
-                                        /*
-                                         * take a breather relying on the unplug
-                                         * timer to kick us again
-                                         */
-                                        spin_lock_irqsave(q->queue_lock, flags);
-                                        blk_plug_device(q);
-                                        spin_unlock_irqrestore(q->queue_lock, flags);
-
-                                        return 1;
-                                }
-                        }
-                } else if (sense_key == UNIT_ATTENTION) {
-                        /* media change */
-                        cdrom_saw_media_change(drive);
-
-                        /*
-                         * Arrange to retry the request but be sure to give up
-                         * if we've retried too many times.
-                         */
-                        if (++rq->errors > ERROR_MAX)
-                                do_end_request = 1;
-                } else if (sense_key == ILLEGAL_REQUEST ||
-                           sense_key == DATA_PROTECT) {
-                        /*
-                         * No point in retrying after an illegal request or data
-                         * protect error.
-                         */
+                break;
+        case ILLEGAL_REQUEST:
+                /*
+                 * Don't print error message for this condition -- SFF8090i
+                 * indicates that 5/24/00 is the correct response to a request
+                 * to close the tray if the drive doesn't have that capability.
+                 *
+                 * cdrom_log_sense() knows this!
+                 */
+                if (rq->cmd[0] == GPCMD_START_STOP_UNIT)
+                        break;
+                /* fall-through */
+        case DATA_PROTECT:
+                /*
+                 * No point in retrying after an illegal request or data
+                 * protect error.
+                 */
+                if (!quiet)
                         ide_dump_status(drive, "command error", stat);
-                        do_end_request = 1;
-                } else if (sense_key == MEDIUM_ERROR) {
-                        /*
-                         * No point in re-trying a zillion times on a bad
-                         * sector. If we got here the error is not correctable.
-                         */
-                        ide_dump_status(drive, "media error (bad sector)",
+                do_end_request = 1;
+                break;
+        case MEDIUM_ERROR:
+                /*
+                 * No point in re-trying a zillion times on a bad sector.
+                 * If we got here the error is not correctable.
+                 */
+                if (!quiet)
+                        ide_dump_status(drive, "media error "
+                                        "(bad sector)", stat);
+                do_end_request = 1;
+                break;
+        case BLANK_CHECK:
+                /* disk appears blank? */
+                if (!quiet)
+                        ide_dump_status(drive, "media error (blank)",
                                         stat);
-                        do_end_request = 1;
-                } else if (sense_key == BLANK_CHECK) {
-                        /* disk appears blank ?? */
-                        ide_dump_status(drive, "media error (blank)", stat);
-                        do_end_request = 1;
-                } else if ((err & ~ATA_ABORTED) != 0) {
+                do_end_request = 1;
+                break;
+        default:
+                if (blk_fs_request(rq) == 0)
+                        break;
+                if (err & ~ATA_ABORTED) {
                         /* go to the default handler for other errors */
                         ide_error(drive, "cdrom_decode_status", stat);
                         return 1;
-                } else if ((++rq->errors > ERROR_MAX)) {
+                } else if (++rq->errors > ERROR_MAX)
                         /* we've racked up too many retries, abort */
                         do_end_request = 1;
-                }
-
-                /*
-                 * End a request through request sense analysis when we have
-                 * sense data. We need this in order to perform end of media
-                 * processing.
-                 */
-                if (do_end_request)
-                        goto end_request;
+        }
 
-                /*
-                 * If we got a CHECK_CONDITION status, queue
-                 * a request sense command.
-                 */
-                if (stat & ATA_ERR)
-                        cdrom_queue_request_sense(drive, NULL, NULL);
-                return 1;
-        } else {
-                blk_dump_rq_flags(rq, PFX "bad rq");
-                return 2;
+        if (blk_fs_request(rq) == 0) {
+                rq->cmd_flags |= REQ_FAILED;
+                do_end_request = 1;
         }
 
+        /*
+         * End a request through request sense analysis when we have sense data.
+         * We need this in order to perform end of media processing.
+         */
+        if (do_end_request)
+                goto end_request;
+
+        /* if we got a CHECK_CONDITION status, queue a request sense command */
+        if (stat & ATA_ERR)
+                cdrom_queue_request_sense(drive, NULL, NULL);
+        return 1;
+
 end_request:
         if (stat & ATA_ERR) {
                 struct request_queue *q = drive->queue;
@@ -624,15 +608,14 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
         struct ide_cmd *cmd = &hwif->cmd;
         struct request *rq = hwif->rq;
         ide_expiry_t *expiry = NULL;
-        int dma_error = 0, dma, stat, thislen, uptodate = 0;
+        int dma_error = 0, dma, thislen, uptodate = 0;
         int write = (rq_data_dir(rq) == WRITE) ? 1 : 0, rc, nsectors;
         int sense = blk_sense_request(rq);
         unsigned int timeout;
         u16 len;
-        u8 ireason;
+        u8 ireason, stat;
 
-        ide_debug_log(IDE_DBG_PC, "cmd[0]: 0x%x, write: 0x%x",
-                                  rq->cmd[0], write);
+        ide_debug_log(IDE_DBG_PC, "cmd: 0x%x, write: 0x%x", rq->cmd[0], write);
 
         /* check for errors */
         dma = drive->dma;
@@ -648,11 +631,16 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
                 }
         }
 
-        rc = cdrom_decode_status(drive, 0, &stat);
-        if (rc) {
-                if (rc == 2)
-                        goto out_end;
-                return ide_stopped;
+        /* check status */
+        stat = hwif->tp_ops->read_status(hwif);
+
+        if (!OK_STAT(stat, 0, BAD_R_STAT)) {
+                rc = cdrom_decode_status(drive, stat);
+                if (rc) {
+                        if (rc == 2)
+                                goto out_end;
+                        return ide_stopped;
+                }
         }
 
         /* using dma, transfer is complete now */
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index c998cf8e971a..a9fbe2c31210 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -97,35 +97,38 @@ static ide_startstop_t __ide_do_rw_disk(ide_drive_t *drive, struct request *rq,
         }
 
         memset(&cmd, 0, sizeof(cmd));
-        cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
 
         if (drive->dev_flags & IDE_DFLAG_LBA) {
                 if (lba48) {
                         pr_debug("%s: LBA=0x%012llx\n", drive->name,
                                         (unsigned long long)block);
 
-                        tf->hob_nsect = (nsectors >> 8) & 0xff;
-                        tf->hob_lbal  = (u8)(block >> 24);
-                        if (sizeof(block) != 4) {
-                                tf->hob_lbam = (u8)((u64)block >> 32);
-                                tf->hob_lbah = (u8)((u64)block >> 40);
-                        }
-
                         tf->nsect  = nsectors & 0xff;
                         tf->lbal   = (u8) block;
                         tf->lbam   = (u8)(block >>  8);
                         tf->lbah   = (u8)(block >> 16);
+                        tf->device = ATA_LBA;
 
-                        cmd.tf_flags |= (IDE_TFLAG_LBA48 | IDE_TFLAG_HOB);
+                        tf = &cmd.hob;
+                        tf->nsect = (nsectors >> 8) & 0xff;
+                        tf->lbal  = (u8)(block >> 24);
+                        if (sizeof(block) != 4) {
+                                tf->lbam = (u8)((u64)block >> 32);
+                                tf->lbah = (u8)((u64)block >> 40);
+                        }
+
+                        cmd.valid.out.hob = IDE_VALID_OUT_HOB;
+                        cmd.valid.in.hob  = IDE_VALID_IN_HOB;
+                        cmd.tf_flags |= IDE_TFLAG_LBA48;
                 } else {
                         tf->nsect  = nsectors & 0xff;
                         tf->lbal   = block;
                         tf->lbam   = block >>= 8;
                         tf->lbah   = block >>= 8;
-                        tf->device = (block >> 8) & 0xf;
+                        tf->device = ((block >> 8) & 0xf) | ATA_LBA;
                 }
-
-                tf->device |= ATA_LBA;
         } else {
                 unsigned int sect, head, cyl, track;
 
@@ -220,15 +223,19 @@ static u64 idedisk_read_native_max_address(ide_drive_t *drive, int lba48)
                 tf->command = ATA_CMD_READ_NATIVE_MAX;
         tf->device  = ATA_LBA;
 
-        cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
-        if (lba48)
-                cmd.tf_flags |= (IDE_TFLAG_LBA48 | IDE_TFLAG_HOB);
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
+        if (lba48) {
+                cmd.valid.out.hob = IDE_VALID_OUT_HOB;
+                cmd.valid.in.hob  = IDE_VALID_IN_HOB;
+                cmd.tf_flags = IDE_TFLAG_LBA48;
+        }
 
         ide_no_data_taskfile(drive, &cmd);
 
         /* if OK, compute maximum address value */
         if (!(tf->status & ATA_ERR))
-                addr = ide_get_lba_addr(tf, lba48) + 1;
+                addr = ide_get_lba_addr(&cmd, lba48) + 1;
 
         return addr;
 }
@@ -250,9 +257,9 @@ static u64 idedisk_set_max_address(ide_drive_t *drive, u64 addr_req, int lba48)
         tf->lbam     = (addr_req >>= 8) & 0xff;
         tf->lbah     = (addr_req >>= 8) & 0xff;
         if (lba48) {
-                tf->hob_lbal = (addr_req >>= 8) & 0xff;
-                tf->hob_lbam = (addr_req >>= 8) & 0xff;
-                tf->hob_lbah = (addr_req >>= 8) & 0xff;
+                cmd.hob.lbal = (addr_req >>= 8) & 0xff;
+                cmd.hob.lbam = (addr_req >>= 8) & 0xff;
+                cmd.hob.lbah = (addr_req >>= 8) & 0xff;
                 tf->command  = ATA_CMD_SET_MAX_EXT;
         } else {
                 tf->device   = (addr_req >>= 8) & 0x0f;
@@ -260,15 +267,19 @@ static u64 idedisk_set_max_address(ide_drive_t *drive, u64 addr_req, int lba48)
         }
         tf->device |= ATA_LBA;
 
-        cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
-        if (lba48)
-                cmd.tf_flags |= (IDE_TFLAG_LBA48 | IDE_TFLAG_HOB);
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
+        if (lba48) {
+                cmd.valid.out.hob = IDE_VALID_OUT_HOB;
+                cmd.valid.in.hob  = IDE_VALID_IN_HOB;
+                cmd.tf_flags = IDE_TFLAG_LBA48;
+        }
 
         ide_no_data_taskfile(drive, &cmd);
 
         /* if OK, compute maximum address value */
         if (!(tf->status & ATA_ERR))
-                addr_set = ide_get_lba_addr(tf, lba48) + 1;
+                addr_set = ide_get_lba_addr(&cmd, lba48) + 1;
 
         return addr_set;
 }
@@ -395,8 +406,8 @@ static void idedisk_prepare_flush(struct request_queue *q, struct request *rq)
                 cmd->tf.command = ATA_CMD_FLUSH_EXT;
         else
                 cmd->tf.command = ATA_CMD_FLUSH;
-        cmd->tf_flags = IDE_TFLAG_OUT_TF | IDE_TFLAG_OUT_DEVICE |
-                        IDE_TFLAG_DYN;
+        cmd->valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd->tf_flags = IDE_TFLAG_DYN;
         cmd->protocol = ATA_PROT_NODATA;
 
         rq->cmd_type = REQ_TYPE_ATA_TASKFILE;
@@ -457,7 +468,8 @@ static int ide_do_setfeature(ide_drive_t *drive, u8 feature, u8 nsect)
         cmd.tf.feature = feature;
         cmd.tf.nsect   = nsect;
         cmd.tf.command = ATA_CMD_SET_FEATURES;
-        cmd.tf_flags   = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
 
         return ide_no_data_taskfile(drive, &cmd);
 }
@@ -533,7 +545,8 @@ static int do_idedisk_flushcache(ide_drive_t *drive)
                 cmd.tf.command = ATA_CMD_FLUSH_EXT;
         else
                 cmd.tf.command = ATA_CMD_FLUSH;
-        cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
 
         return ide_no_data_taskfile(drive, &cmd);
 }
@@ -715,7 +728,8 @@ static int ide_disk_set_doorlock(ide_drive_t *drive, struct gendisk *disk,
 
         memset(&cmd, 0, sizeof(cmd));
         cmd.tf.command = on ? ATA_CMD_MEDIA_LOCK : ATA_CMD_MEDIA_UNLOCK;
-        cmd.tf_flags   = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
 
         ret = ide_no_data_taskfile(drive, &cmd);
 
diff --git a/drivers/ide/ide-disk_proc.c b/drivers/ide/ide-disk_proc.c
index eaea3bef2073..19f263bf0a9e 100644
--- a/drivers/ide/ide-disk_proc.c
+++ b/drivers/ide/ide-disk_proc.c
@@ -13,7 +13,8 @@ static int smart_enable(ide_drive_t *drive)
         tf->lbam    = ATA_SMART_LBAM_PASS;
         tf->lbah    = ATA_SMART_LBAH_PASS;
         tf->command = ATA_CMD_SMART;
-        cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
 
         return ide_no_data_taskfile(drive, &cmd);
 }
@@ -29,7 +30,8 @@ static int get_smart_data(ide_drive_t *drive, u8 *buf, u8 sub_cmd)
         tf->lbam    = ATA_SMART_LBAM_PASS;
         tf->lbah    = ATA_SMART_LBAH_PASS;
         tf->command = ATA_CMD_SMART;
-        cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
         cmd.protocol = ATA_PROT_PIO;
 
         return ide_raw_taskfile(drive, &cmd, buf, 1);
diff --git a/drivers/ide/ide-dma-sff.c b/drivers/ide/ide-dma-sff.c
index 16fc46edc32d..e4cdf78cc3e9 100644
--- a/drivers/ide/ide-dma-sff.c
+++ b/drivers/ide/ide-dma-sff.c
@@ -277,8 +277,6 @@ void ide_dma_start(ide_drive_t *drive)
                 dma_cmd = inb(hwif->dma_base + ATA_DMA_CMD);
                 outb(dma_cmd | ATA_DMA_START, hwif->dma_base + ATA_DMA_CMD);
         }
-
-        wmb();
 }
 EXPORT_SYMBOL_GPL(ide_dma_start);
 
@@ -286,7 +284,7 @@ EXPORT_SYMBOL_GPL(ide_dma_start);
 int ide_dma_end(ide_drive_t *drive)
 {
         ide_hwif_t *hwif = drive->hwif;
-        u8 dma_stat = 0, dma_cmd = 0, mask;
+        u8 dma_stat = 0, dma_cmd = 0;
 
         /* stop DMA */
         if (hwif->host_flags & IDE_HFLAG_MMIO) {
@@ -304,11 +302,10 @@ int ide_dma_end(ide_drive_t *drive)
         /* clear INTR & ERROR bits */
         ide_dma_sff_write_status(hwif, dma_stat | ATA_DMA_ERR | ATA_DMA_INTR);
 
-        wmb();
+#define CHECK_DMA_MASK (ATA_DMA_ACTIVE | ATA_DMA_ERR | ATA_DMA_INTR)
 
         /* verify good DMA status */
-        mask = ATA_DMA_ACTIVE | ATA_DMA_ERR | ATA_DMA_INTR;
-        if ((dma_stat & mask) != ATA_DMA_INTR)
+        if ((dma_stat & CHECK_DMA_MASK) != ATA_DMA_INTR)
                 return 0x10 | dma_stat;
         return 0;
 }
diff --git a/drivers/ide/ide-h8300.c b/drivers/ide/ide-h8300.c
index dac9a6d44963..c06ebdc4a130 100644
--- a/drivers/ide/ide-h8300.c
+++ b/drivers/ide/ide-h8300.c
@@ -22,103 +22,6 @@
         (r);                            \
 })
 
-static void mm_outw(u16 d, unsigned long a)
-{
-        __asm__("mov.b %w0,r2h\n\t"
-                "mov.b %x0,r2l\n\t"
-                "mov.w r2,@%1"
-                :
-                :"r"(d),"r"(a)
-                :"er2");
-}
-
-static u16 mm_inw(unsigned long a)
-{
-        register u16 r __asm__("er0");
-        __asm__("mov.w @%1,r2\n\t"
-                "mov.b r2l,%x0\n\t"
-                "mov.b r2h,%w0"
-                :"=r"(r)
-                :"r"(a)
-                :"er2");
-        return r;
-}
-
-static void h8300_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
-{
-        ide_hwif_t *hwif = drive->hwif;
-        struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-        u8 HIHI = (cmd->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF;
-
-        if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED)
-                HIHI = 0xFF;
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE)
-                outb(tf->hob_feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT)
-                outb(tf->hob_nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAL)
-                outb(tf->hob_lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAM)
-                outb(tf->hob_lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAH)
-                outb(tf->hob_lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_FEATURE)
-                outb(tf->feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_NSECT)
-                outb(tf->nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAL)
-                outb(tf->lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAM)
-                outb(tf->lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAH)
-                outb(tf->lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_DEVICE)
-                outb((tf->device & HIHI) | drive->select,
-                     io_ports->device_addr);
-}
-
-static void h8300_tf_read(ide_drive_t *drive, struct ide_cmd *cmd)
-{
-        ide_hwif_t *hwif = drive->hwif;
-        struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-
-        /* be sure we're looking at the low order bits */
-        outb(ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_IN_ERROR)
-                tf->error  = inb(io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_NSECT)
-                tf->nsect  = inb(io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAL)
-                tf->lbal   = inb(io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAM)
-                tf->lbam   = inb(io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAH)
-                tf->lbah   = inb(io_ports->lbah_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_DEVICE)
-                tf->device = inb(io_ports->device_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_LBA48) {
-                outb(ATA_HOB | ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_ERROR)
-                        tf->hob_error = inb(io_ports->feature_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_NSECT)
-                        tf->hob_nsect = inb(io_ports->nsect_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAL)
-                        tf->hob_lbal  = inb(io_ports->lbal_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAM)
-                        tf->hob_lbam  = inb(io_ports->lbam_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAH)
-                        tf->hob_lbah  = inb(io_ports->lbah_addr);
-        }
-}
-
 static void mm_outsw(unsigned long addr, void *buf, u32 len)
 {
         unsigned short *bp = (unsigned short *)buf;
@@ -152,8 +55,8 @@ static const struct ide_tp_ops h8300_tp_ops = {
         .write_devctl           = ide_write_devctl,
 
         .dev_select             = ide_dev_select,
-        .tf_load                = h8300_tf_load,
-        .tf_read                = h8300_tf_read,
+        .tf_load                = ide_tf_load,
+        .tf_read                = ide_tf_read,
 
         .input_data             = h8300_input_data,
         .output_data            = h8300_output_data,
diff --git a/drivers/ide/ide-io-std.c b/drivers/ide/ide-io-std.c
index 9cac281d82c4..46721c454518 100644
--- a/drivers/ide/ide-io-std.c
+++ b/drivers/ide/ide-io-std.c
@@ -85,98 +85,57 @@ void ide_dev_select(ide_drive_t *drive)
 }
 EXPORT_SYMBOL_GPL(ide_dev_select);
 
-void ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
+void ide_tf_load(ide_drive_t *drive, struct ide_taskfile *tf, u8 valid)
 {
         ide_hwif_t *hwif = drive->hwif;
         struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
         void (*tf_outb)(u8 addr, unsigned long port);
         u8 mmio = (hwif->host_flags & IDE_HFLAG_MMIO) ? 1 : 0;
-        u8 HIHI = (cmd->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF;
 
         if (mmio)
                 tf_outb = ide_mm_outb;
         else
                 tf_outb = ide_outb;
 
-        if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED)
-                HIHI = 0xFF;
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE)
-                tf_outb(tf->hob_feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT)
-                tf_outb(tf->hob_nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAL)
-                tf_outb(tf->hob_lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAM)
-                tf_outb(tf->hob_lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAH)
-                tf_outb(tf->hob_lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_FEATURE)
+        if (valid & IDE_VALID_FEATURE)
                 tf_outb(tf->feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_NSECT)
+        if (valid & IDE_VALID_NSECT)
                 tf_outb(tf->nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAL)
+        if (valid & IDE_VALID_LBAL)
                 tf_outb(tf->lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAM)
+        if (valid & IDE_VALID_LBAM)
                 tf_outb(tf->lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAH)
+        if (valid & IDE_VALID_LBAH)
                 tf_outb(tf->lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_DEVICE)
-                tf_outb((tf->device & HIHI) | drive->select,
-                         io_ports->device_addr);
+        if (valid & IDE_VALID_DEVICE)
+                tf_outb(tf->device, io_ports->device_addr);
 }
 EXPORT_SYMBOL_GPL(ide_tf_load);
 
-void ide_tf_read(ide_drive_t *drive, struct ide_cmd *cmd)
+void ide_tf_read(ide_drive_t *drive, struct ide_taskfile *tf, u8 valid)
 {
         ide_hwif_t *hwif = drive->hwif;
         struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-        void (*tf_outb)(u8 addr, unsigned long port);
         u8 (*tf_inb)(unsigned long port);
         u8 mmio = (hwif->host_flags & IDE_HFLAG_MMIO) ? 1 : 0;
 
-        if (mmio) {
-                tf_outb = ide_mm_outb;
+        if (mmio)
                 tf_inb  = ide_mm_inb;
-        } else {
-                tf_outb = ide_outb;
+        else
                 tf_inb  = ide_inb;
-        }
-
-        /* be sure we're looking at the low order bits */
-        tf_outb(ATA_DEVCTL_OBS, io_ports->ctl_addr);
 
-        if (cmd->tf_flags & IDE_TFLAG_IN_ERROR)
+        if (valid & IDE_VALID_ERROR)
                 tf->error  = tf_inb(io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_NSECT)
+        if (valid & IDE_VALID_NSECT)
                 tf->nsect  = tf_inb(io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAL)
+        if (valid & IDE_VALID_LBAL)
                 tf->lbal   = tf_inb(io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAM)
+        if (valid & IDE_VALID_LBAM)
                 tf->lbam   = tf_inb(io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAH)
+        if (valid & IDE_VALID_LBAH)
                 tf->lbah   = tf_inb(io_ports->lbah_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_DEVICE)
+        if (valid & IDE_VALID_DEVICE)
                 tf->device = tf_inb(io_ports->device_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_LBA48) {
-                tf_outb(ATA_HOB | ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_ERROR)
-                        tf->hob_error = tf_inb(io_ports->feature_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_NSECT)
-                        tf->hob_nsect = tf_inb(io_ports->nsect_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAL)
-                        tf->hob_lbal  = tf_inb(io_ports->lbal_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAM)
-                        tf->hob_lbam  = tf_inb(io_ports->lbam_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAH)
-                        tf->hob_lbah  = tf_inb(io_ports->lbah_addr);
-        }
 }
 EXPORT_SYMBOL_GPL(ide_tf_read);
 
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 1deb6d29b186..2ae02b8d7f8e 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -86,18 +86,18 @@ void ide_complete_cmd(ide_drive_t *drive, struct ide_cmd *cmd, u8 stat, u8 err)
 
                 tp_ops->input_data(drive, cmd, data, 2);
 
-                tf->data = data[0];
-                tf->hob_data = data[1];
+                cmd->tf.data  = data[0];
+                cmd->hob.data = data[1];
         }
 
-        tp_ops->tf_read(drive, cmd);
+        ide_tf_readback(drive, cmd);
 
         if ((cmd->tf_flags & IDE_TFLAG_CUSTOM_HANDLER) &&
             tf_cmd == ATA_CMD_IDLEIMMEDIATE) {
                 if (tf->lbal != 0xc4) {
                         printk(KERN_ERR "%s: head unload failed!\n",
                                drive->name);
-                        ide_tf_dump(drive->name, tf);
+                        ide_tf_dump(drive->name, cmd);
                 } else
                         drive->dev_flags |= IDE_DFLAG_PARKED;
         }
@@ -205,8 +205,9 @@ static ide_startstop_t ide_disk_special(ide_drive_t *drive)
                 return ide_stopped;
         }
 
-        cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE |
-                       IDE_TFLAG_CUSTOM_HANDLER;
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
+        cmd.tf_flags = IDE_TFLAG_CUSTOM_HANDLER;
 
         do_rw_taskfile(drive, &cmd);
 
diff --git a/drivers/ide/ide-ioctls.c b/drivers/ide/ide-ioctls.c
index 770142767437..c1c25ebbaa1f 100644
--- a/drivers/ide/ide-ioctls.c
+++ b/drivers/ide/ide-ioctls.c
@@ -141,11 +141,12 @@ static int ide_cmd_ioctl(ide_drive_t *drive, unsigned long arg)
                 tf->lbal  = args[1];
                 tf->lbam  = 0x4f;
                 tf->lbah  = 0xc2;
-                cmd.tf_flags = IDE_TFLAG_OUT_TF | IDE_TFLAG_IN_NSECT;
+                cmd.valid.out.tf = IDE_VALID_OUT_TF;
+                cmd.valid.in.tf  = IDE_VALID_NSECT;
         } else {
                 tf->nsect = args[1];
-                cmd.tf_flags = IDE_TFLAG_OUT_FEATURE | IDE_TFLAG_OUT_NSECT |
-                               IDE_TFLAG_IN_NSECT;
+                cmd.valid.out.tf = IDE_VALID_FEATURE | IDE_VALID_NSECT;
+                cmd.valid.in.tf  = IDE_VALID_NSECT;
         }
         tf->command = args[0];
         cmd.protocol = args[3] ? ATA_PROT_PIO : ATA_PROT_NODATA;
@@ -205,14 +206,15 @@ static int ide_task_ioctl(ide_drive_t *drive, unsigned long arg)
                 return -EFAULT;
 
         memset(&cmd, 0, sizeof(cmd));
-        memcpy(&cmd.tf_array[7], &args[1], 6);
+        memcpy(&cmd.tf.feature, &args[1], 6);
         cmd.tf.command = args[0];
-        cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
 
         err = ide_no_data_taskfile(drive, &cmd);
 
         args[0] = cmd.tf.command;
-        memcpy(&args[1], &cmd.tf_array[7], 6);
+        memcpy(&args[1], &cmd.tf.feature, 6);
 
         if (copy_to_user(p, args, 7))
                 err = -EFAULT;
diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c
index 27bb70ddd459..c19a221b1e18 100644
--- a/drivers/ide/ide-iops.c
+++ b/drivers/ide/ide-iops.c
@@ -37,14 +37,11 @@ void SELECT_MASK(ide_drive_t *drive, int mask)
 
 u8 ide_read_error(ide_drive_t *drive)
 {
-        struct ide_cmd cmd;
+        struct ide_taskfile tf;
 
-        memset(&cmd, 0, sizeof(cmd));
-        cmd.tf_flags = IDE_TFLAG_IN_ERROR;
+        drive->hwif->tp_ops->tf_read(drive, &tf, IDE_VALID_ERROR);
 
-        drive->hwif->tp_ops->tf_read(drive, &cmd);
-
-        return cmd.tf.error;
+        return tf.error;
 }
 EXPORT_SYMBOL_GPL(ide_read_error);
 
@@ -312,10 +309,10 @@ int ide_config_drive_speed(ide_drive_t *drive, u8 speed)
 {
         ide_hwif_t *hwif = drive->hwif;
         const struct ide_tp_ops *tp_ops = hwif->tp_ops;
+        struct ide_taskfile tf;
         u16 *id = drive->id, i;
         int error = 0;
         u8 stat;
-        struct ide_cmd cmd;
 
 #ifdef CONFIG_BLK_DEV_IDEDMA
         if (hwif->dma_ops)      /* check if host supports DMA */
@@ -347,12 +344,11 @@ int ide_config_drive_speed(ide_drive_t *drive, u8 speed)
         udelay(1);
         tp_ops->write_devctl(hwif, ATA_NIEN | ATA_DEVCTL_OBS);
 
-        memset(&cmd, 0, sizeof(cmd));
-        cmd.tf_flags = IDE_TFLAG_OUT_FEATURE | IDE_TFLAG_OUT_NSECT;
-        cmd.tf.feature = SETFEATURES_XFER;
-        cmd.tf.nsect   = speed;
+        memset(&tf, 0, sizeof(tf));
+        tf.feature = SETFEATURES_XFER;
+        tf.nsect   = speed;
 
-        tp_ops->tf_load(drive, &cmd);
+        tp_ops->tf_load(drive, &tf, IDE_VALID_FEATURE | IDE_VALID_NSECT);
 
         tp_ops->exec_command(hwif, ATA_CMD_SET_FEATURES);
 
diff --git a/drivers/ide/ide-lib.c b/drivers/ide/ide-lib.c
index 217b7fdf2b17..56ff8c46c7d1 100644
--- a/drivers/ide/ide-lib.c
+++ b/drivers/ide/ide-lib.c
@@ -49,16 +49,17 @@ static void ide_dump_opcode(ide_drive_t *drive)
                 printk(KERN_CONT "0x%02x\n", cmd->tf.command);
 }
 
-u64 ide_get_lba_addr(struct ide_taskfile *tf, int lba48)
+u64 ide_get_lba_addr(struct ide_cmd *cmd, int lba48)
 {
+        struct ide_taskfile *tf = &cmd->tf;
         u32 high, low;
 
-        if (lba48)
-                high = (tf->hob_lbah << 16) | (tf->hob_lbam << 8) |
-                        tf->hob_lbal;
-        else
-                high = tf->device & 0xf;
         low  = (tf->lbah << 16) | (tf->lbam << 8) | tf->lbal;
+        if (lba48) {
+                tf = &cmd->hob;
+                high = (tf->lbah << 16) | (tf->lbam << 8) | tf->lbal;
+        } else
+                high = tf->device & 0xf;
 
         return ((u64)high << 24) | low;
 }
@@ -71,17 +72,18 @@ static void ide_dump_sector(ide_drive_t *drive)
         u8 lba48 = !!(drive->dev_flags & IDE_DFLAG_LBA48);
 
         memset(&cmd, 0, sizeof(cmd));
-        if (lba48)
-                cmd.tf_flags = IDE_TFLAG_IN_LBA | IDE_TFLAG_IN_HOB_LBA |
-                                IDE_TFLAG_LBA48;
-        else
-                cmd.tf_flags = IDE_TFLAG_IN_LBA | IDE_TFLAG_IN_DEVICE;
+        if (lba48) {
+                cmd.valid.in.tf  = IDE_VALID_LBA;
+                cmd.valid.in.hob = IDE_VALID_LBA;
+                cmd.tf_flags = IDE_TFLAG_LBA48;
+        } else
+                cmd.valid.in.tf  = IDE_VALID_LBA | IDE_VALID_DEVICE;
 
-        drive->hwif->tp_ops->tf_read(drive, &cmd);
+        ide_tf_readback(drive, &cmd);
 
         if (lba48 || (tf->device & ATA_LBA))
                 printk(KERN_CONT ", LBAsect=%llu",
-                        (unsigned long long)ide_get_lba_addr(tf, lba48));
+                        (unsigned long long)ide_get_lba_addr(&cmd, lba48));
         else
                 printk(KERN_CONT ", CHS=%d/%d/%d", (tf->lbah << 8) + tf->lbam,
                         tf->device & 0xf, tf->lbal);
diff --git a/drivers/ide/ide-park.c b/drivers/ide/ide-park.c
index 9490b446519f..310d03f2b5b7 100644
--- a/drivers/ide/ide-park.c
+++ b/drivers/ide/ide-park.c
@@ -74,7 +74,8 @@ ide_startstop_t ide_do_park_unpark(ide_drive_t *drive, struct request *rq)
                 tf->lbal = 0x4c;
                 tf->lbam = 0x4e;
                 tf->lbah = 0x55;
-                cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+                cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+                cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
         } else          /* cmd == REQ_UNPARK_HEADS */
                 tf->command = ATA_CMD_CHK_POWER;
 
diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c
index bb7858ebb7d1..0d8a151c0a01 100644
--- a/drivers/ide/ide-pm.c
+++ b/drivers/ide/ide-pm.c
@@ -163,7 +163,8 @@ ide_startstop_t ide_start_power_step(ide_drive_t *drive, struct request *rq)
         return ide_stopped;
 
 out_do_tf:
-        cmd->tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+        cmd->valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd->valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
         cmd->protocol = ATA_PROT_NODATA;
 
         return do_rw_taskfile(drive, cmd);
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index d8c1c3e735bb..7f264ed1141b 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -283,13 +283,11 @@ int ide_dev_read_id(ide_drive_t *drive, u8 cmd, u16 *id)
          * identify command to be sure of reply
          */
         if (cmd == ATA_CMD_ID_ATAPI) {
-                struct ide_cmd cmd;
+                struct ide_taskfile tf;
 
-                memset(&cmd, 0, sizeof(cmd));
+                memset(&tf, 0, sizeof(tf));
                 /* disable DMA & overlap */
-                cmd.tf_flags = IDE_TFLAG_OUT_FEATURE;
-
-                tp_ops->tf_load(drive, &cmd);
+                tp_ops->tf_load(drive, &tf, IDE_VALID_FEATURE);
         }
 
         /* ask drive for ID */
@@ -337,14 +335,11 @@ int ide_busy_sleep(ide_hwif_t *hwif, unsigned long timeout, int altstatus)
 
 static u8 ide_read_device(ide_drive_t *drive)
 {
-        struct ide_cmd cmd;
-
-        memset(&cmd, 0, sizeof(cmd));
-        cmd.tf_flags = IDE_TFLAG_IN_DEVICE;
+        struct ide_taskfile tf;
 
-        drive->hwif->tp_ops->tf_read(drive, &cmd);
+        drive->hwif->tp_ops->tf_read(drive, &tf, IDE_VALID_DEVICE);
 
-        return cmd.tf.device;
+        return tf.device;
 }
 
 /**
@@ -1314,6 +1309,7 @@ struct ide_host *ide_host_alloc(const struct ide_port_info *d, hw_regs_t **hws)
                 host->get_lock     = d->get_lock;
                 host->release_lock = d->release_lock;
                 host->host_flags = d->host_flags;
+                host->irq_flags = d->irq_flags;
         }
 
         return host;
diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c
index 10a88bf3eefa..3242698832a4 100644
--- a/drivers/ide/ide-proc.c
+++ b/drivers/ide/ide-proc.c
@@ -204,8 +204,8 @@ static int set_xfer_rate (ide_drive_t *drive, int arg)
         cmd.tf.command = ATA_CMD_SET_FEATURES;
         cmd.tf.feature = SETFEATURES_XFER;
         cmd.tf.nsect   = (u8)arg;
-        cmd.tf_flags   = IDE_TFLAG_OUT_FEATURE | IDE_TFLAG_OUT_NSECT |
-                         IDE_TFLAG_IN_NSECT;
+        cmd.valid.out.tf = IDE_VALID_FEATURE | IDE_VALID_NSECT;
+        cmd.valid.in.tf  = IDE_VALID_NSECT;
 
         err = ide_no_data_taskfile(drive, &cmd);
 
diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
index 243421ce40d0..4aa6223c11be 100644
--- a/drivers/ide/ide-taskfile.c
+++ b/drivers/ide/ide-taskfile.c
@@ -23,17 +23,33 @@
 #include <asm/uaccess.h>
 #include <asm/io.h>
 
-void ide_tf_dump(const char *s, struct ide_taskfile *tf)
+void ide_tf_readback(ide_drive_t *drive, struct ide_cmd *cmd)
+{
+        ide_hwif_t *hwif = drive->hwif;
+        const struct ide_tp_ops *tp_ops = hwif->tp_ops;
+
+        /* Be sure we're looking at the low order bytes */
+        tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS);
+
+        tp_ops->tf_read(drive, &cmd->tf, cmd->valid.in.tf);
+
+        if (cmd->tf_flags & IDE_TFLAG_LBA48) {
+                tp_ops->write_devctl(hwif, ATA_HOB | ATA_DEVCTL_OBS);
+
+                tp_ops->tf_read(drive, &cmd->hob, cmd->valid.in.hob);
+        }
+}
+
+void ide_tf_dump(const char *s, struct ide_cmd *cmd)
 {
 #ifdef DEBUG
         printk("%s: tf: feat 0x%02x nsect 0x%02x lbal 0x%02x "
                 "lbam 0x%02x lbah 0x%02x dev 0x%02x cmd 0x%02x\n",
-                s, tf->feature, tf->nsect, tf->lbal,
-                tf->lbam, tf->lbah, tf->device, tf->command);
-        printk("%s: hob: nsect 0x%02x lbal 0x%02x "
-                "lbam 0x%02x lbah 0x%02x\n",
-                s, tf->hob_nsect, tf->hob_lbal,
-                tf->hob_lbam, tf->hob_lbah);
+               s, cmd->tf.feature, cmd->tf.nsect,
+               cmd->tf.lbal, cmd->tf.lbam, cmd->tf.lbah,
+               cmd->tf.device, cmd->tf.command);
+        printk("%s: hob: nsect 0x%02x lbal 0x%02x lbam 0x%02x lbah 0x%02x\n",
+               s, cmd->hob.nsect, cmd->hob.lbal, cmd->hob.lbam, cmd->hob.lbah);
 #endif
 }
 
@@ -47,7 +63,8 @@ int taskfile_lib_get_identify (ide_drive_t *drive, u8 *buf)
                 cmd.tf.command = ATA_CMD_ID_ATA;
         else
                 cmd.tf.command = ATA_CMD_ID_ATAPI;
-        cmd.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
+        cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
         cmd.protocol = ATA_PROT_PIO;
 
         return ide_raw_taskfile(drive, &cmd, buf, 1);
@@ -79,16 +96,27 @@ ide_startstop_t do_rw_taskfile(ide_drive_t *drive, struct ide_cmd *orig_cmd)
         memcpy(cmd, orig_cmd, sizeof(*cmd));
 
         if ((cmd->tf_flags & IDE_TFLAG_DMA_PIO_FALLBACK) == 0) {
-                ide_tf_dump(drive->name, tf);
+                ide_tf_dump(drive->name, cmd);
                 tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS);
                 SELECT_MASK(drive, 0);
 
                 if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) {
-                        u8 data[2] = { tf->data, tf->hob_data };
+                        u8 data[2] = { cmd->tf.data, cmd->hob.data };
 
                         tp_ops->output_data(drive, cmd, data, 2);
                 }
-                tp_ops->tf_load(drive, cmd);
+
+                if (cmd->valid.out.tf & IDE_VALID_DEVICE) {
+                        u8 HIHI = (cmd->tf_flags & IDE_TFLAG_LBA48) ?
+                                  0xE0 : 0xEF;
+
+                        if (!(cmd->ftf_flags & IDE_FTFLAG_FLAGGED))
+                                cmd->tf.device &= HIHI;
+                        cmd->tf.device |= drive->select;
+                }
+
+                tp_ops->tf_load(drive, &cmd->hob, cmd->valid.out.hob);
+                tp_ops->tf_load(drive, &cmd->tf,  cmd->valid.out.tf);
         }
 
         switch (cmd->protocol) {
@@ -489,16 +517,17 @@ int ide_taskfile_ioctl(ide_drive_t *drive, unsigned long arg)
 
         memset(&cmd, 0, sizeof(cmd));
 
-        memcpy(&cmd.tf_array[0], req_task->hob_ports,
-               HDIO_DRIVE_HOB_HDR_SIZE - 2);
-        memcpy(&cmd.tf_array[6], req_task->io_ports,
-               HDIO_DRIVE_TASK_HDR_SIZE);
+        memcpy(&cmd.hob, req_task->hob_ports, HDIO_DRIVE_HOB_HDR_SIZE - 2);
+        memcpy(&cmd.tf,  req_task->io_ports,  HDIO_DRIVE_TASK_HDR_SIZE);
 
-        cmd.tf_flags   = IDE_TFLAG_IO_16BIT | IDE_TFLAG_DEVICE |
-                         IDE_TFLAG_IN_TF;
+        cmd.valid.out.tf = IDE_VALID_DEVICE;
+        cmd.valid.in.tf  = IDE_VALID_DEVICE | IDE_VALID_IN_TF;
+        cmd.tf_flags = IDE_TFLAG_IO_16BIT;
 
-        if (drive->dev_flags & IDE_DFLAG_LBA48)
-                cmd.tf_flags |= (IDE_TFLAG_LBA48 | IDE_TFLAG_IN_HOB);
+        if (drive->dev_flags & IDE_DFLAG_LBA48) {
+                cmd.tf_flags |= IDE_TFLAG_LBA48;
+                cmd.valid.in.hob = IDE_VALID_IN_HOB;
+        }
 
         if (req_task->out_flags.all) {
                 cmd.ftf_flags |= IDE_FTFLAG_FLAGGED;
@@ -507,28 +536,28 @@ int ide_taskfile_ioctl(ide_drive_t *drive, unsigned long arg)
                         cmd.ftf_flags |= IDE_FTFLAG_OUT_DATA;
 
                 if (req_task->out_flags.b.nsector_hob)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_HOB_NSECT;
+                        cmd.valid.out.hob |= IDE_VALID_NSECT;
                 if (req_task->out_flags.b.sector_hob)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_HOB_LBAL;
+                        cmd.valid.out.hob |= IDE_VALID_LBAL;
                 if (req_task->out_flags.b.lcyl_hob)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_HOB_LBAM;
+                        cmd.valid.out.hob |= IDE_VALID_LBAM;
                 if (req_task->out_flags.b.hcyl_hob)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_HOB_LBAH;
+                        cmd.valid.out.hob |= IDE_VALID_LBAH;
 
                 if (req_task->out_flags.b.error_feature)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_FEATURE;
+                        cmd.valid.out.tf  |= IDE_VALID_FEATURE;
                 if (req_task->out_flags.b.nsector)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_NSECT;
+                        cmd.valid.out.tf  |= IDE_VALID_NSECT;
                 if (req_task->out_flags.b.sector)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_LBAL;
+                        cmd.valid.out.tf  |= IDE_VALID_LBAL;
                 if (req_task->out_flags.b.lcyl)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_LBAM;
+                        cmd.valid.out.tf  |= IDE_VALID_LBAM;
                 if (req_task->out_flags.b.hcyl)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_LBAH;
+                        cmd.valid.out.tf  |= IDE_VALID_LBAH;
         } else {
-                cmd.tf_flags |= IDE_TFLAG_OUT_TF;
+                cmd.valid.out.tf |= IDE_VALID_OUT_TF;
                 if (cmd.tf_flags & IDE_TFLAG_LBA48)
-                        cmd.tf_flags |= IDE_TFLAG_OUT_HOB;
+                        cmd.valid.out.hob |= IDE_VALID_OUT_HOB;
         }
 
         if (req_task->in_flags.b.data)
@@ -594,7 +623,7 @@ int ide_taskfile_ioctl(ide_drive_t *drive, unsigned long arg)
         if (req_task->req_cmd == IDE_DRIVE_TASK_NO_DATA)
                 nsect = 0;
         else if (!nsect) {
-                nsect = (cmd.tf.hob_nsect << 8) | cmd.tf.nsect;
+                nsect = (cmd.hob.nsect << 8) | cmd.tf.nsect;
 
                 if (!nsect) {
                         printk(KERN_ERR "%s: in/out command without data\n",
@@ -606,10 +635,8 @@ int ide_taskfile_ioctl(ide_drive_t *drive, unsigned long arg)
 
         err = ide_raw_taskfile(drive, &cmd, data_buf, nsect);
 
-        memcpy(req_task->hob_ports, &cmd.tf_array[0],
-               HDIO_DRIVE_HOB_HDR_SIZE - 2);
-        memcpy(req_task->io_ports, &cmd.tf_array[6],
-               HDIO_DRIVE_TASK_HDR_SIZE);
+        memcpy(req_task->hob_ports, &cmd.hob, HDIO_DRIVE_HOB_HDR_SIZE - 2);
+        memcpy(req_task->io_ports,  &cmd.tf,  HDIO_DRIVE_TASK_HDR_SIZE);
 
         if ((cmd.ftf_flags & IDE_FTFLAG_SET_IN_FLAGS) &&
             req_task->in_flags.all == 0) {
diff --git a/drivers/ide/ns87415.c b/drivers/ide/ns87415.c
index 71a39fb3856f..95327a2c2422 100644
--- a/drivers/ide/ns87415.c
+++ b/drivers/ide/ns87415.c
@@ -61,41 +61,23 @@ static u8 superio_dma_sff_read_status(ide_hwif_t *hwif)
         return superio_ide_inb(hwif->dma_base + ATA_DMA_STATUS);
 }
 
-static void superio_tf_read(ide_drive_t *drive, struct ide_cmd *cmd)
+static void superio_tf_read(ide_drive_t *drive, struct ide_taskfile *tf,
+                            u8 valid)
 {
         struct ide_io_ports *io_ports = &drive->hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
 
-        /* be sure we're looking at the low order bits */
-        outb(ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_IN_ERROR)
+        if (valid & IDE_VALID_ERROR)
                 tf->error  = inb(io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_NSECT)
+        if (valid & IDE_VALID_NSECT)
                 tf->nsect  = inb(io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAL)
+        if (valid & IDE_VALID_LBAL)
                 tf->lbal   = inb(io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAM)
+        if (valid & IDE_VALID_LBAM)
                 tf->lbam   = inb(io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAH)
+        if (valid & IDE_VALID_LBAH)
                 tf->lbah   = inb(io_ports->lbah_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_DEVICE)
+        if (valid & IDE_VALID_DEVICE)
                 tf->device = superio_ide_inb(io_ports->device_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_LBA48) {
-                outb(ATA_HOB | ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_ERROR)
-                        tf->hob_error = inb(io_ports->feature_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_NSECT)
-                        tf->hob_nsect = inb(io_ports->nsect_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAL)
-                        tf->hob_lbal  = inb(io_ports->lbal_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAM)
-                        tf->hob_lbam  = inb(io_ports->lbam_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAH)
-                        tf->hob_lbah  = inb(io_ports->lbah_addr);
-        }
 }
 
 static void ns87415_dev_select(ide_drive_t *drive);
diff --git a/drivers/ide/q40ide.c b/drivers/ide/q40ide.c
index d007e7f66598..c79346679244 100644
--- a/drivers/ide/q40ide.c
+++ b/drivers/ide/q40ide.c
@@ -16,6 +16,8 @@
 #include <linux/blkdev.h>
 #include <linux/ide.h>
 
+#include <asm/ide.h>
+
     /*
      *  Bases of the IDE interfaces
      */
@@ -77,8 +79,10 @@ static void q40ide_input_data(ide_drive_t *drive, struct ide_cmd *cmd,
 {
         unsigned long data_addr = drive->hwif->io_ports.data_addr;
 
-        if (drive->media == ide_disk && cmd && (cmd->tf_flags & IDE_TFLAG_FS))
-                return insw(data_addr, buf, (len + 1) / 2);
+        if (drive->media == ide_disk && cmd && (cmd->tf_flags & IDE_TFLAG_FS)) {
+                __ide_mm_insw(data_addr, buf, (len + 1) / 2);
+                return;
+        }
 
         raw_insw_swapw((u16 *)data_addr, buf, (len + 1) / 2);
 }
@@ -88,8 +92,10 @@ static void q40ide_output_data(ide_drive_t *drive, struct ide_cmd *cmd,
 {
         unsigned long data_addr = drive->hwif->io_ports.data_addr;
 
-        if (drive->media == ide_disk && cmd && (cmd->tf_flags & IDE_TFLAG_FS))
-                return outsw(data_addr, buf, (len + 1) / 2);
+        if (drive->media == ide_disk && cmd && (cmd->tf_flags & IDE_TFLAG_FS)) {
+                __ide_mm_outsw(data_addr, buf, (len + 1) / 2);
+                return;
+        }
 
         raw_outsw_swapw((u16 *)data_addr, buf, (len + 1) / 2);
 }
diff --git a/drivers/ide/scc_pata.c b/drivers/ide/scc_pata.c
index 6d8dbd9c10bc..5be41f25204f 100644
--- a/drivers/ide/scc_pata.c
+++ b/drivers/ide/scc_pata.c
@@ -337,7 +337,6 @@ static void scc_dma_start(ide_drive_t *drive)
 
         /* start DMA */
         scc_ide_outb(dma_cmd | 1, hwif->dma_base);
-        wmb();
 }
 
 static int __scc_dma_end(ide_drive_t *drive)
@@ -354,7 +353,6 @@ static int __scc_dma_end(ide_drive_t *drive)
         /* clear the INTR & ERROR bits */
         scc_ide_outb(dma_stat | 6, hwif->dma_base + 4);
         /* verify good DMA status */
-        wmb();
         return (dma_stat & 7) != 4 ? (0x10 | dma_stat) : 0;
 }
 
@@ -647,77 +645,40 @@ static int __devinit init_setup_scc(struct pci_dev *dev,
         return rc;
 }
 
-static void scc_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
+static void scc_tf_load(ide_drive_t *drive, struct ide_taskfile *tf, u8 valid)
 {
         struct ide_io_ports *io_ports = &drive->hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-        u8 HIHI = (cmd->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF;
-
-        if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED)
-                HIHI = 0xFF;
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE)
-                scc_ide_outb(tf->hob_feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT)
-                scc_ide_outb(tf->hob_nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAL)
-                scc_ide_outb(tf->hob_lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAM)
-                scc_ide_outb(tf->hob_lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAH)
-                scc_ide_outb(tf->hob_lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_FEATURE)
+
+        if (valid & IDE_VALID_FEATURE)
                 scc_ide_outb(tf->feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_NSECT)
+        if (valid & IDE_VALID_NSECT)
                 scc_ide_outb(tf->nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAL)
+        if (valid & IDE_VALID_LBAL)
                 scc_ide_outb(tf->lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAM)
+        if (valid & IDE_VALID_LBAM)
                 scc_ide_outb(tf->lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAH)
+        if (valid & IDE_VALID_LBAH)
                 scc_ide_outb(tf->lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_DEVICE)
-                scc_ide_outb((tf->device & HIHI) | drive->select,
-                             io_ports->device_addr);
+        if (valid & IDE_VALID_DEVICE)
+                scc_ide_outb(tf->device, io_ports->device_addr);
 }
 
-static void scc_tf_read(ide_drive_t *drive, struct ide_cmd *cmd)
+static void scc_tf_read(ide_drive_t *drive, struct ide_taskfile *tf, u8 valid)
 {
         struct ide_io_ports *io_ports = &drive->hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-
-        /* be sure we're looking at the low order bits */
-        scc_ide_outb(ATA_DEVCTL_OBS, io_ports->ctl_addr);
 
-        if (cmd->tf_flags & IDE_TFLAG_IN_ERROR)
+        if (valid & IDE_VALID_ERROR)
                 tf->error  = scc_ide_inb(io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_NSECT)
+        if (valid & IDE_VALID_NSECT)
                 tf->nsect  = scc_ide_inb(io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAL)
+        if (valid & IDE_VALID_LBAL)
                 tf->lbal   = scc_ide_inb(io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAM)
+        if (valid & IDE_VALID_LBAM)
                 tf->lbam   = scc_ide_inb(io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAH)
+        if (valid & IDE_VALID_LBAH)
                 tf->lbah   = scc_ide_inb(io_ports->lbah_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_DEVICE)
+        if (valid & IDE_VALID_DEVICE)
                 tf->device = scc_ide_inb(io_ports->device_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_LBA48) {
-                scc_ide_outb(ATA_HOB | ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_ERROR)
-                        tf->hob_error = scc_ide_inb(io_ports->feature_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_NSECT)
-                        tf->hob_nsect = scc_ide_inb(io_ports->nsect_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAL)
-                        tf->hob_lbal  = scc_ide_inb(io_ports->lbal_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAM)
-                        tf->hob_lbam  = scc_ide_inb(io_ports->lbam_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAH)
-                        tf->hob_lbah  = scc_ide_inb(io_ports->lbah_addr);
-        }
 }
 
 static void scc_input_data(ide_drive_t *drive, struct ide_cmd *cmd,
diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c
index 4cb79c4c2604..e33d764e2945 100644
--- a/drivers/ide/tx4938ide.c
+++ b/drivers/ide/tx4938ide.c
@@ -72,91 +72,6 @@ static void tx4938ide_set_pio_mode(ide_drive_t *drive, const u8 pio)
 #ifdef __BIG_ENDIAN
 
 /* custom iops (independent from SWAP_IO_SPACE) */
-static u8 tx4938ide_inb(unsigned long port)
-{
-        return __raw_readb((void __iomem *)port);
-}
-
-static void tx4938ide_outb(u8 value, unsigned long port)
-{
-        __raw_writeb(value, (void __iomem *)port);
-}
-
-static void tx4938ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
-{
-        ide_hwif_t *hwif = drive->hwif;
-        struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-        u8 HIHI = cmd->tf_flags & IDE_TFLAG_LBA48 ? 0xE0 : 0xEF;
-
-        if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED)
-                HIHI = 0xFF;
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE)
-                tx4938ide_outb(tf->hob_feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT)
-                tx4938ide_outb(tf->hob_nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAL)
-                tx4938ide_outb(tf->hob_lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAM)
-                tx4938ide_outb(tf->hob_lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAH)
-                tx4938ide_outb(tf->hob_lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_FEATURE)
-                tx4938ide_outb(tf->feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_NSECT)
-                tx4938ide_outb(tf->nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAL)
-                tx4938ide_outb(tf->lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAM)
-                tx4938ide_outb(tf->lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAH)
-                tx4938ide_outb(tf->lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_DEVICE)
-                tx4938ide_outb((tf->device & HIHI) | drive->select,
-                               io_ports->device_addr);
-}
-
-static void tx4938ide_tf_read(ide_drive_t *drive, struct ide_cmd *cmd)
-{
-        ide_hwif_t *hwif = drive->hwif;
-        struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-
-        /* be sure we're looking at the low order bits */
-        tx4938ide_outb(ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_IN_ERROR)
-                tf->error  = tx4938ide_inb(io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_NSECT)
-                tf->nsect  = tx4938ide_inb(io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAL)
-                tf->lbal   = tx4938ide_inb(io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAM)
-                tf->lbam   = tx4938ide_inb(io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAH)
-                tf->lbah   = tx4938ide_inb(io_ports->lbah_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_DEVICE)
-                tf->device = tx4938ide_inb(io_ports->device_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_LBA48) {
-                tx4938ide_outb(ATA_HOB | ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_ERROR)
-                        tf->hob_error = tx4938ide_inb(io_ports->feature_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_NSECT)
-                        tf->hob_nsect = tx4938ide_inb(io_ports->nsect_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAL)
-                        tf->hob_lbal  = tx4938ide_inb(io_ports->lbal_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAM)
-                        tf->hob_lbam  = tx4938ide_inb(io_ports->lbam_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAH)
-                        tf->hob_lbah  = tx4938ide_inb(io_ports->lbah_addr);
-        }
-}
-
 static void tx4938ide_input_data_swap(ide_drive_t *drive, struct ide_cmd *cmd,
                                 void *buf, unsigned int len)
 {
@@ -190,8 +105,8 @@ static const struct ide_tp_ops tx4938ide_tp_ops = {
         .write_devctl           = ide_write_devctl,
 
         .dev_select             = ide_dev_select,
-        .tf_load                = tx4938ide_tf_load,
-        .tf_read                = tx4938ide_tf_read,
+        .tf_load                = ide_tf_load,
+        .tf_read                = ide_tf_read,
 
         .input_data             = tx4938ide_input_data_swap,
         .output_data            = tx4938ide_output_data_swap,
diff --git a/drivers/ide/tx4939ide.c b/drivers/ide/tx4939ide.c
index 0040a9a3e26e..564422d23976 100644
--- a/drivers/ide/tx4939ide.c
+++ b/drivers/ide/tx4939ide.c
@@ -327,15 +327,15 @@ static int tx4939ide_dma_end(ide_drive_t *drive)
         /* read and clear the INTR & ERROR bits */
         dma_stat = tx4939ide_clear_dma_status(base);
 
-        wmb();
+#define CHECK_DMA_MASK (ATA_DMA_ACTIVE | ATA_DMA_ERR | ATA_DMA_INTR)
 
         /* verify good DMA status */
-        if ((dma_stat & (ATA_DMA_INTR | ATA_DMA_ERR | ATA_DMA_ACTIVE)) == 0 &&
+        if ((dma_stat & CHECK_DMA_MASK) == 0 &&
             (ctl & (TX4939IDE_INT_XFEREND | TX4939IDE_INT_HOST)) ==
             (TX4939IDE_INT_XFEREND | TX4939IDE_INT_HOST))
                 /* INT_IDE lost... bug? */
                 return 0;
-        return ((dma_stat & (ATA_DMA_INTR | ATA_DMA_ERR | ATA_DMA_ACTIVE)) !=
+        return ((dma_stat & CHECK_DMA_MASK) !=
                 ATA_DMA_INTR) ? 0x10 | dma_stat : 0;
 }
 
@@ -434,97 +434,19 @@ static void tx4939ide_tf_load_fixup(ide_drive_t *drive)
         tx4939ide_writew(sysctl, base, TX4939IDE_Sys_Ctl);
 }
 
-#ifdef __BIG_ENDIAN
-
-/* custom iops (independent from SWAP_IO_SPACE) */
-static u8 tx4939ide_inb(unsigned long port)
+static void tx4939ide_tf_load(ide_drive_t *drive, struct ide_taskfile *tf,
+                              u8 valid)
 {
-        return __raw_readb((void __iomem *)port);
-}
+        ide_tf_load(drive, tf, valid);
 
-static void tx4939ide_outb(u8 value, unsigned long port)
-{
-        __raw_writeb(value, (void __iomem *)port);
-}
-
-static void tx4939ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
-{
-        ide_hwif_t *hwif = drive->hwif;
-        struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-        u8 HIHI = cmd->tf_flags & IDE_TFLAG_LBA48 ? 0xE0 : 0xEF;
-
-        if (cmd->ftf_flags & IDE_FTFLAG_FLAGGED)
-                HIHI = 0xFF;
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE)
-                tx4939ide_outb(tf->hob_feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT)
-                tx4939ide_outb(tf->hob_nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAL)
-                tx4939ide_outb(tf->hob_lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAM)
-                tx4939ide_outb(tf->hob_lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAH)
-                tx4939ide_outb(tf->hob_lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_FEATURE)
-                tx4939ide_outb(tf->feature, io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_NSECT)
-                tx4939ide_outb(tf->nsect, io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAL)
-                tx4939ide_outb(tf->lbal, io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAM)
-                tx4939ide_outb(tf->lbam, io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_OUT_LBAH)
-                tx4939ide_outb(tf->lbah, io_ports->lbah_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_DEVICE) {
-                tx4939ide_outb((tf->device & HIHI) | drive->select,
-                               io_ports->device_addr);
+        if (valid & IDE_VALID_DEVICE)
                 tx4939ide_tf_load_fixup(drive);
-        }
 }
 
-static void tx4939ide_tf_read(ide_drive_t *drive, struct ide_cmd *cmd)
-{
-        ide_hwif_t *hwif = drive->hwif;
-        struct ide_io_ports *io_ports = &hwif->io_ports;
-        struct ide_taskfile *tf = &cmd->tf;
-
-        /* be sure we're looking at the low order bits */
-        tx4939ide_outb(ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_IN_ERROR)
-                tf->error  = tx4939ide_inb(io_ports->feature_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_NSECT)
-                tf->nsect  = tx4939ide_inb(io_ports->nsect_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAL)
-                tf->lbal   = tx4939ide_inb(io_ports->lbal_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAM)
-                tf->lbam   = tx4939ide_inb(io_ports->lbam_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_LBAH)
-                tf->lbah   = tx4939ide_inb(io_ports->lbah_addr);
-        if (cmd->tf_flags & IDE_TFLAG_IN_DEVICE)
-                tf->device = tx4939ide_inb(io_ports->device_addr);
-
-        if (cmd->tf_flags & IDE_TFLAG_LBA48) {
-                tx4939ide_outb(ATA_HOB | ATA_DEVCTL_OBS, io_ports->ctl_addr);
-
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_ERROR)
-                        tf->hob_error = tx4939ide_inb(io_ports->feature_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_NSECT)
-                        tf->hob_nsect = tx4939ide_inb(io_ports->nsect_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAL)
-                        tf->hob_lbal  = tx4939ide_inb(io_ports->lbal_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAM)
-                        tf->hob_lbam  = tx4939ide_inb(io_ports->lbam_addr);
-                if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAH)
-                        tf->hob_lbah  = tx4939ide_inb(io_ports->lbah_addr);
-        }
-}
+#ifdef __BIG_ENDIAN
 
-static void tx4939ide_input_data_swap(ide_drive_t *drive, struct request *rq,
+/* custom iops (independent from SWAP_IO_SPACE) */
+static void tx4939ide_input_data_swap(ide_drive_t *drive, struct ide_cmd *cmd,
                                 void *buf, unsigned int len)
 {
         unsigned long port = drive->hwif->io_ports.data_addr;
@@ -536,7 +458,7 @@ static void tx4939ide_input_data_swap(ide_drive_t *drive, struct request *rq,
         __ide_flush_dcache_range((unsigned long)buf, roundup(len, 2));
 }
 
-static void tx4939ide_output_data_swap(ide_drive_t *drive, struct request *rq,
+static void tx4939ide_output_data_swap(ide_drive_t *drive, struct ide_cmd *cmd,
                                 void *buf, unsigned int len)
 {
         unsigned long port = drive->hwif->io_ports.data_addr;
@@ -558,7 +480,7 @@ static const struct ide_tp_ops tx4939ide_tp_ops = {
 
         .dev_select             = ide_dev_select,
         .tf_load                = tx4939ide_tf_load,
-        .tf_read                = tx4939ide_tf_read,
+        .tf_read                = ide_tf_read,
 
         .input_data             = tx4939ide_input_data_swap,
         .output_data            = tx4939ide_output_data_swap,
@@ -566,14 +488,6 @@ static const struct ide_tp_ops tx4939ide_tp_ops = {
 
 #else   /* __LITTLE_ENDIAN */
 
-static void tx4939ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd)
-{
-        ide_tf_load(drive, cmd);
-
-        if (cmd->tf_flags & IDE_TFLAG_OUT_DEVICE)
-                tx4939ide_tf_load_fixup(drive);
-}
-
 static const struct ide_tp_ops tx4939ide_tp_ops = {
         .exec_command           = ide_exec_command,
         .read_status            = ide_read_status,
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 2a2e50871b40..851de83ff455 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -297,21 +297,25 @@ static void cma_detach_from_dev(struct rdma_id_private *id_priv)
         id_priv->cma_dev = NULL;
 }
 
-static int cma_set_qkey(struct ib_device *device, u8 port_num,
-                        enum rdma_port_space ps,
-                        struct rdma_dev_addr *dev_addr, u32 *qkey)
+static int cma_set_qkey(struct rdma_id_private *id_priv)
 {
         struct ib_sa_mcmember_rec rec;
         int ret = 0;
 
-        switch (ps) {
+        if (id_priv->qkey)
+                return 0;
+
+        switch (id_priv->id.ps) {
         case RDMA_PS_UDP:
-                *qkey = RDMA_UDP_QKEY;
+                id_priv->qkey = RDMA_UDP_QKEY;
                 break;
         case RDMA_PS_IPOIB:
-                ib_addr_get_mgid(dev_addr, &rec.mgid);
-                ret = ib_sa_get_mcmember_rec(device, port_num, &rec.mgid, &rec);
-                *qkey = be32_to_cpu(rec.qkey);
+                ib_addr_get_mgid(&id_priv->id.route.addr.dev_addr, &rec.mgid);
+                ret = ib_sa_get_mcmember_rec(id_priv->id.device,
+                                             id_priv->id.port_num, &rec.mgid,
+                                             &rec);
+                if (!ret)
+                        id_priv->qkey = be32_to_cpu(rec.qkey);
                 break;
         default:
                 break;
@@ -341,12 +345,7 @@ static int cma_acquire_dev(struct rdma_id_private *id_priv)
                 ret = ib_find_cached_gid(cma_dev->device, &gid,
                                          &id_priv->id.port_num, NULL);
                 if (!ret) {
-                        ret = cma_set_qkey(cma_dev->device,
-                                           id_priv->id.port_num,
-                                           id_priv->id.ps, dev_addr,
-                                           &id_priv->qkey);
-                        if (!ret)
-                                cma_attach_to_dev(id_priv, cma_dev);
+                        cma_attach_to_dev(id_priv, cma_dev);
                         break;
                 }
         }
@@ -578,6 +577,10 @@ static int cma_ib_init_qp_attr(struct rdma_id_private *id_priv,
         *qp_attr_mask = IB_QP_STATE | IB_QP_PKEY_INDEX | IB_QP_PORT;
 
         if (cma_is_ud_ps(id_priv->id.ps)) {
+                ret = cma_set_qkey(id_priv);
+                if (ret)
+                        return ret;
+
                 qp_attr->qkey = id_priv->qkey;
                 *qp_attr_mask |= IB_QP_QKEY;
         } else {
@@ -2201,6 +2204,12 @@ static int cma_sidr_rep_handler(struct ib_cm_id *cm_id,
                         event.status = ib_event->param.sidr_rep_rcvd.status;
                         break;
                 }
+                ret = cma_set_qkey(id_priv);
+                if (ret) {
+                        event.event = RDMA_CM_EVENT_ADDR_ERROR;
+                        event.status = -EINVAL;
+                        break;
+                }
                 if (id_priv->qkey != rep->qkey) {
                         event.event = RDMA_CM_EVENT_UNREACHABLE;
                         event.status = -EINVAL;
@@ -2480,10 +2489,14 @@ static int cma_send_sidr_rep(struct rdma_id_private *id_priv,
                              const void *private_data, int private_data_len)
 {
         struct ib_cm_sidr_rep_param rep;
+        int ret;
 
         memset(&rep, 0, sizeof rep);
         rep.status = status;
         if (status == IB_SIDR_SUCCESS) {
+                ret = cma_set_qkey(id_priv);
+                if (ret)
+                        return ret;
                 rep.qp_num = id_priv->qp_num;
                 rep.qkey = id_priv->qkey;
         }
@@ -2713,6 +2726,10 @@ static int cma_join_ib_multicast(struct rdma_id_private *id_priv,
                     IB_SA_MCMEMBER_REC_FLOW_LABEL |
                     IB_SA_MCMEMBER_REC_TRAFFIC_CLASS;
 
+        if (id_priv->id.ps == RDMA_PS_IPOIB)
+                comp_mask |= IB_SA_MCMEMBER_REC_RATE |
+                             IB_SA_MCMEMBER_REC_RATE_SELECTOR;
+
         mc->multicast.ib = ib_sa_join_multicast(&sa_client, id_priv->id.device,
                                                 id_priv->id.port_num, &rec,
                                                 comp_mask, GFP_KERNEL,
diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
index a4a82bff7100..8d71086f5a1c 100644
--- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
+++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
@@ -152,7 +152,7 @@ static int cxio_hal_clear_qp_ctx(struct cxio_rdev *rdev_p, u32 qpid)
         sge_cmd = qpid << 8 | 3;
         wqe->sge_cmd = cpu_to_be64(sge_cmd);
         skb->priority = CPL_PRIORITY_CONTROL;
-        return (cxgb3_ofld_send(rdev_p->t3cdev_p, skb));
+        return iwch_cxgb3_ofld_send(rdev_p->t3cdev_p, skb);
 }
 
 int cxio_create_cq(struct cxio_rdev *rdev_p, struct t3_cq *cq)
@@ -571,7 +571,7 @@ static int cxio_hal_init_ctrl_qp(struct cxio_rdev *rdev_p)
              (unsigned long long) rdev_p->ctrl_qp.dma_addr,
              rdev_p->ctrl_qp.workq, 1 << T3_CTRL_QP_SIZE_LOG2);
         skb->priority = CPL_PRIORITY_CONTROL;
-        return (cxgb3_ofld_send(rdev_p->t3cdev_p, skb));
+        return iwch_cxgb3_ofld_send(rdev_p->t3cdev_p, skb);
 err:
         kfree_skb(skb);
         return err;
@@ -701,7 +701,7 @@ static int __cxio_tpt_op(struct cxio_rdev *rdev_p, u32 reset_tpt_entry,
         u32 stag_idx;
         u32 wptr;
 
-        if (rdev_p->flags)
+        if (cxio_fatal_error(rdev_p))
                 return -EIO;
 
         stag_state = stag_state > 0;
@@ -858,7 +858,7 @@ int cxio_rdma_init(struct cxio_rdev *rdev_p, struct t3_rdma_init_attr *attr)
         wqe->qp_dma_size = cpu_to_be32(attr->qp_dma_size);
         wqe->irs = cpu_to_be32(attr->irs);
         skb->priority = 0;      /* 0=>ToeQ; 1=>CtrlQ */
-        return (cxgb3_ofld_send(rdev_p->t3cdev_p, skb));
+        return iwch_cxgb3_ofld_send(rdev_p->t3cdev_p, skb);
 }
 
 void cxio_register_ev_cb(cxio_hal_ev_callback_func_t ev_cb)
@@ -1041,9 +1041,9 @@ void cxio_rdev_close(struct cxio_rdev *rdev_p)
                 cxio_hal_pblpool_destroy(rdev_p);
                 cxio_hal_rqtpool_destroy(rdev_p);
                 list_del(&rdev_p->entry);
-                rdev_p->t3cdev_p->ulp = NULL;
                 cxio_hal_destroy_ctrl_qp(rdev_p);
                 cxio_hal_destroy_resource(rdev_p->rscp);
+                rdev_p->t3cdev_p->ulp = NULL;
         }
 }
 
diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.h b/drivers/infiniband/hw/cxgb3/cxio_hal.h
index 094a66d1480c..bfd03bf8be54 100644
--- a/drivers/infiniband/hw/cxgb3/cxio_hal.h
+++ b/drivers/infiniband/hw/cxgb3/cxio_hal.h
@@ -115,6 +115,11 @@ struct cxio_rdev {
 #define CXIO_ERROR_FATAL        1
 };
 
+static inline int cxio_fatal_error(struct cxio_rdev *rdev_p)
+{
+        return rdev_p->flags & CXIO_ERROR_FATAL;
+}
+
 static inline int cxio_num_stags(struct cxio_rdev *rdev_p)
 {
         return min((int)T3_MAX_NUM_STAG, (int)((rdev_p->rnic_info.tpt_top - rdev_p->rnic_info.tpt_base) >> 5));
@@ -188,6 +193,7 @@ void cxio_count_scqes(struct t3_cq *cq, struct t3_wq *wq, int *count);
 void cxio_flush_hw_cq(struct t3_cq *cq);
 int cxio_poll_cq(struct t3_wq *wq, struct t3_cq *cq, struct t3_cqe *cqe,
                      u8 *cqe_flushed, u64 *cookie, u32 *credit);
+int iwch_cxgb3_ofld_send(struct t3cdev *tdev, struct sk_buff *skb);
 
 #define MOD "iw_cxgb3: "
 #define PDBG(fmt, args...) pr_debug(MOD fmt, ## args)
diff --git a/drivers/infiniband/hw/cxgb3/iwch.c b/drivers/infiniband/hw/cxgb3/iwch.c
index 37a4fc264a07..26fc0a4eaa74 100644
--- a/drivers/infiniband/hw/cxgb3/iwch.c
+++ b/drivers/infiniband/hw/cxgb3/iwch.c
@@ -165,12 +165,19 @@ static void close_rnic_dev(struct t3cdev *tdev)
 static void iwch_err_handler(struct t3cdev *tdev, u32 status, u32 error)
 {
         struct cxio_rdev *rdev = tdev->ulp;
+        struct iwch_dev *rnicp = rdev_to_iwch_dev(rdev);
+        struct ib_event event;
 
-        if (status == OFFLOAD_STATUS_DOWN)
+        if (status == OFFLOAD_STATUS_DOWN) {
                 rdev->flags = CXIO_ERROR_FATAL;
 
-        return;
+                event.device = &rnicp->ibdev;
+                event.event  = IB_EVENT_DEVICE_FATAL;
+                event.element.port_num = 0;
+                ib_dispatch_event(&event);
+        }
 
+        return;
 }
 
 static int __init iwch_init_module(void)
diff --git a/drivers/infiniband/hw/cxgb3/iwch.h b/drivers/infiniband/hw/cxgb3/iwch.h
index 3773453b2cf0..84735506333f 100644
--- a/drivers/infiniband/hw/cxgb3/iwch.h
+++ b/drivers/infiniband/hw/cxgb3/iwch.h
@@ -117,6 +117,11 @@ static inline struct iwch_dev *to_iwch_dev(struct ib_device *ibdev)
         return container_of(ibdev, struct iwch_dev, ibdev);
 }
 
+static inline struct iwch_dev *rdev_to_iwch_dev(struct cxio_rdev *rdev)
+{
+        return container_of(rdev, struct iwch_dev, rdev);
+}
+
 static inline int t3b_device(const struct iwch_dev *rhp)
 {
         return rhp->rdev.t3cdev_p->type == T3B;
diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index 8699947aaf6c..fef3f1ae7225 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -139,6 +139,38 @@ static void stop_ep_timer(struct iwch_ep *ep)
         put_ep(&ep->com);
 }
 
+int iwch_l2t_send(struct t3cdev *tdev, struct sk_buff *skb, struct l2t_entry *l2e)
+{
+        int     error = 0;
+        struct cxio_rdev *rdev;
+
+        rdev = (struct cxio_rdev *)tdev->ulp;
+        if (cxio_fatal_error(rdev)) {
+                kfree_skb(skb);
+                return -EIO;
+        }
+        error = l2t_send(tdev, skb, l2e);
+        if (error)
+                kfree_skb(skb);
+        return error;
+}
+
+int iwch_cxgb3_ofld_send(struct t3cdev *tdev, struct sk_buff *skb)
+{
+        int     error = 0;
+        struct cxio_rdev *rdev;
+
+        rdev = (struct cxio_rdev *)tdev->ulp;
+        if (cxio_fatal_error(rdev)) {
+                kfree_skb(skb);
+                return -EIO;
+        }
+        error = cxgb3_ofld_send(tdev, skb);
+        if (error)
+                kfree_skb(skb);
+        return error;
+}
+
 static void release_tid(struct t3cdev *tdev, u32 hwtid, struct sk_buff *skb)
 {
         struct cpl_tid_release *req;
@@ -150,7 +182,7 @@ static void release_tid(struct t3cdev *tdev, u32 hwtid, struct sk_buff *skb)
         req->wr.wr_hi = htonl(V_WR_OP(FW_WROPCODE_FORWARD));
         OPCODE_TID(req) = htonl(MK_OPCODE_TID(CPL_TID_RELEASE, hwtid));
         skb->priority = CPL_PRIORITY_SETUP;
-        cxgb3_ofld_send(tdev, skb);
+        iwch_cxgb3_ofld_send(tdev, skb);
         return;
 }
 
@@ -172,8 +204,7 @@ int iwch_quiesce_tid(struct iwch_ep *ep)
         req->val = cpu_to_be64(1 << S_TCB_RX_QUIESCE);
 
         skb->priority = CPL_PRIORITY_DATA;
-        cxgb3_ofld_send(ep->com.tdev, skb);
-        return 0;
+        return iwch_cxgb3_ofld_send(ep->com.tdev, skb);
 }
 
 int iwch_resume_tid(struct iwch_ep *ep)
@@ -194,8 +225,7 @@ int iwch_resume_tid(struct iwch_ep *ep)
         req->val = 0;
 
         skb->priority = CPL_PRIORITY_DATA;
-        cxgb3_ofld_send(ep->com.tdev, skb);
-        return 0;
+        return iwch_cxgb3_ofld_send(ep->com.tdev, skb);
 }
 
 static void set_emss(struct iwch_ep *ep, u16 opt)
@@ -252,18 +282,22 @@ static void *alloc_ep(int size, gfp_t gfp)
 
 void __free_ep(struct kref *kref)
 {
-        struct iwch_ep_common *epc;
-        epc = container_of(kref, struct iwch_ep_common, kref);
-        PDBG("%s ep %p state %s\n", __func__, epc, states[state_read(epc)]);
-        kfree(epc);
+        struct iwch_ep *ep;
+        ep = container_of(container_of(kref, struct iwch_ep_common, kref),
+                          struct iwch_ep, com);
+        PDBG("%s ep %p state %s\n", __func__, ep, states[state_read(&ep->com)]);
+        if (ep->com.flags & RELEASE_RESOURCES) {
+                cxgb3_remove_tid(ep->com.tdev, (void *)ep, ep->hwtid);
+                dst_release(ep->dst);
+                l2t_release(L2DATA(ep->com.tdev), ep->l2t);
+        }
+        kfree(ep);
 }
 
 static void release_ep_resources(struct iwch_ep *ep)
 {
         PDBG("%s ep %p tid %d\n", __func__, ep, ep->hwtid);
-        cxgb3_remove_tid(ep->com.tdev, (void *)ep, ep->hwtid);
-        dst_release(ep->dst);
-        l2t_release(L2DATA(ep->com.tdev), ep->l2t);
+        ep->com.flags |= RELEASE_RESOURCES;
         put_ep(&ep->com);
 }
 
@@ -382,7 +416,7 @@ static void abort_arp_failure(struct t3cdev *dev, struct sk_buff *skb)
 
         PDBG("%s t3cdev %p\n", __func__, dev);
         req->cmd = CPL_ABORT_NO_RST;
-        cxgb3_ofld_send(dev, skb);
+        iwch_cxgb3_ofld_send(dev, skb);
 }
 
 static int send_halfclose(struct iwch_ep *ep, gfp_t gfp)
@@ -402,8 +436,7 @@ static int send_halfclose(struct iwch_ep *ep, gfp_t gfp)
         req->wr.wr_hi = htonl(V_WR_OP(FW_WROPCODE_OFLD_CLOSE_CON));
         req->wr.wr_lo = htonl(V_WR_TID(ep->hwtid));
         OPCODE_TID(req) = htonl(MK_OPCODE_TID(CPL_CLOSE_CON_REQ, ep->hwtid));
-        l2t_send(ep->com.tdev, skb, ep->l2t);
-        return 0;
+        return iwch_l2t_send(ep->com.tdev, skb, ep->l2t);
 }
 
 static int send_abort(struct iwch_ep *ep, struct sk_buff *skb, gfp_t gfp)
@@ -424,8 +457,7 @@ static int send_abort(struct iwch_ep *ep, struct sk_buff *skb, gfp_t gfp)
         req->wr.wr_lo = htonl(V_WR_TID(ep->hwtid));
         OPCODE_TID(req) = htonl(MK_OPCODE_TID(CPL_ABORT_REQ, ep->hwtid));
         req->cmd = CPL_ABORT_SEND_RST;
-        l2t_send(ep->com.tdev, skb, ep->l2t);
-        return 0;
+        return iwch_l2t_send(ep->com.tdev, skb, ep->l2t);
 }
 
 static int send_connect(struct iwch_ep *ep)
@@ -469,8 +501,7 @@ static int send_connect(struct iwch_ep *ep)
         req->opt0l = htonl(opt0l);
         req->params = 0;
         req->opt2 = htonl(opt2);
-        l2t_send(ep->com.tdev, skb, ep->l2t);
-        return 0;
+        return iwch_l2t_send(ep->com.tdev, skb, ep->l2t);
 }
 
 static void send_mpa_req(struct iwch_ep *ep, struct sk_buff *skb)
@@ -527,7 +558,7 @@ static void send_mpa_req(struct iwch_ep *ep, struct sk_buff *skb)
         req->sndseq = htonl(ep->snd_seq);
         BUG_ON(ep->mpa_skb);
         ep->mpa_skb = skb;
-        l2t_send(ep->com.tdev, skb, ep->l2t);
+        iwch_l2t_send(ep->com.tdev, skb, ep->l2t);
         start_ep_timer(ep);
         state_set(&ep->com, MPA_REQ_SENT);
         return;
@@ -578,8 +609,7 @@ static int send_mpa_reject(struct iwch_ep *ep, const void *pdata, u8 plen)
         req->sndseq = htonl(ep->snd_seq);
         BUG_ON(ep->mpa_skb);
         ep->mpa_skb = skb;
-        l2t_send(ep->com.tdev, skb, ep->l2t);
-        return 0;
+        return iwch_l2t_send(ep->com.tdev, skb, ep->l2t);
 }
 
 static int send_mpa_reply(struct iwch_ep *ep, const void *pdata, u8 plen)
@@ -630,8 +660,7 @@ static int send_mpa_reply(struct iwch_ep *ep, const void *pdata, u8 plen)
         req->sndseq = htonl(ep->snd_seq);
         ep->mpa_skb = skb;
         state_set(&ep->com, MPA_REP_SENT);
-        l2t_send(ep->com.tdev, skb, ep->l2t);
-        return 0;
+        return iwch_l2t_send(ep->com.tdev, skb, ep->l2t);
 }
 
 static int act_establish(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
@@ -795,7 +824,7 @@ static int update_rx_credits(struct iwch_ep *ep, u32 credits)
         OPCODE_TID(req) = htonl(MK_OPCODE_TID(CPL_RX_DATA_ACK, ep->hwtid));
         req->credit_dack = htonl(V_RX_CREDITS(credits) | V_RX_FORCE_ACK(1));
         skb->priority = CPL_PRIORITY_ACK;
-        cxgb3_ofld_send(ep->com.tdev, skb);
+        iwch_cxgb3_ofld_send(ep->com.tdev, skb);
         return credits;
 }
 
@@ -1127,8 +1156,8 @@ static int abort_rpl(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
          * We get 2 abort replies from the HW.  The first one must
          * be ignored except for scribbling that we need one more.
          */
-        if (!(ep->flags & ABORT_REQ_IN_PROGRESS)) {
-                ep->flags |= ABORT_REQ_IN_PROGRESS;
+        if (!(ep->com.flags & ABORT_REQ_IN_PROGRESS)) {
+                ep->com.flags |= ABORT_REQ_IN_PROGRESS;
                 return CPL_RET_BUF_DONE;
         }
 
@@ -1203,8 +1232,7 @@ static int listen_start(struct iwch_listen_ep *ep)
         req->opt1 = htonl(V_CONN_POLICY(CPL_CONN_POLICY_ASK));
 
         skb->priority = 1;
-        cxgb3_ofld_send(ep->com.tdev, skb);
-        return 0;
+        return iwch_cxgb3_ofld_send(ep->com.tdev, skb);
 }
 
 static int pass_open_rpl(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
@@ -1237,8 +1265,7 @@ static int listen_stop(struct iwch_listen_ep *ep)
         req->cpu_idx = 0;
         OPCODE_TID(req) = htonl(MK_OPCODE_TID(CPL_CLOSE_LISTSRV_REQ, ep->stid));
         skb->priority = 1;
-        cxgb3_ofld_send(ep->com.tdev, skb);
-        return 0;
+        return iwch_cxgb3_ofld_send(ep->com.tdev, skb);
 }
 
 static int close_listsrv_rpl(struct t3cdev *tdev, struct sk_buff *skb,
@@ -1286,7 +1313,7 @@ static void accept_cr(struct iwch_ep *ep, __be32 peer_ip, struct sk_buff *skb)
         rpl->opt2 = htonl(opt2);
         rpl->rsvd = rpl->opt2;  /* workaround for HW bug */
         skb->priority = CPL_PRIORITY_SETUP;
-        l2t_send(ep->com.tdev, skb, ep->l2t);
+        iwch_l2t_send(ep->com.tdev, skb, ep->l2t);
 
         return;
 }
@@ -1315,7 +1342,7 @@ static void reject_cr(struct t3cdev *tdev, u32 hwtid, __be32 peer_ip,
                 rpl->opt0l_status = htonl(CPL_PASS_OPEN_REJECT);
                 rpl->opt2 = 0;
                 rpl->rsvd = rpl->opt2;
-                cxgb3_ofld_send(tdev, skb);
+                iwch_cxgb3_ofld_send(tdev, skb);
         }
 }
 
@@ -1534,8 +1561,8 @@ static int peer_abort(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
          * We get 2 peer aborts from the HW.  The first one must
          * be ignored except for scribbling that we need one more.
          */
-        if (!(ep->flags & PEER_ABORT_IN_PROGRESS)) {
-                ep->flags |= PEER_ABORT_IN_PROGRESS;
+        if (!(ep->com.flags & PEER_ABORT_IN_PROGRESS)) {
+                ep->com.flags |= PEER_ABORT_IN_PROGRESS;
                 return CPL_RET_BUF_DONE;
         }
 
@@ -1613,7 +1640,7 @@ static int peer_abort(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
         rpl->wr.wr_lo = htonl(V_WR_TID(ep->hwtid));
         OPCODE_TID(rpl) = htonl(MK_OPCODE_TID(CPL_ABORT_RPL, ep->hwtid));
         rpl->cmd = CPL_ABORT_NO_RST;
-        cxgb3_ofld_send(ep->com.tdev, rpl_skb);
+        iwch_cxgb3_ofld_send(ep->com.tdev, rpl_skb);
 out:
         if (release)
                 release_ep_resources(ep);
@@ -2017,8 +2044,11 @@ int iwch_destroy_listen(struct iw_cm_id *cm_id)
         ep->com.rpl_done = 0;
         ep->com.rpl_err = 0;
         err = listen_stop(ep);
+        if (err)
+                goto done;
         wait_event(ep->com.waitq, ep->com.rpl_done);
         cxgb3_free_stid(ep->com.tdev, ep->stid);
+done:
         err = ep->com.rpl_err;
         cm_id->rem_ref(cm_id);
         put_ep(&ep->com);
@@ -2030,12 +2060,22 @@ int iwch_ep_disconnect(struct iwch_ep *ep, int abrupt, gfp_t gfp)
         int ret=0;
         unsigned long flags;
         int close = 0;
+        int fatal = 0;
+        struct t3cdev *tdev;
+        struct cxio_rdev *rdev;
 
         spin_lock_irqsave(&ep->com.lock, flags);
 
         PDBG("%s ep %p state %s, abrupt %d\n", __func__, ep,
              states[ep->com.state], abrupt);
 
+        tdev = (struct t3cdev *)ep->com.tdev;
+        rdev = (struct cxio_rdev *)tdev->ulp;
+        if (cxio_fatal_error(rdev)) {
+                fatal = 1;
+                close_complete_upcall(ep);
+                ep->com.state = DEAD;
+        }
         switch (ep->com.state) {
         case MPA_REQ_WAIT:
         case MPA_REQ_SENT:
@@ -2075,7 +2115,11 @@ int iwch_ep_disconnect(struct iwch_ep *ep, int abrupt, gfp_t gfp)
                         ret = send_abort(ep, NULL, gfp);
                 else
                         ret = send_halfclose(ep, gfp);
+                if (ret)
+                        fatal = 1;
         }
+        if (fatal)
+                release_ep_resources(ep);
         return ret;
 }
 
diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.h b/drivers/infiniband/hw/cxgb3/iwch_cm.h
index d7c7e09f0996..43c0aea7eadc 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.h
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.h
@@ -147,6 +147,7 @@ enum iwch_ep_state {
 enum iwch_ep_flags {
         PEER_ABORT_IN_PROGRESS  = (1 << 0),
         ABORT_REQ_IN_PROGRESS   = (1 << 1),
+        RELEASE_RESOURCES       = (1 << 2),
 };
 
 struct iwch_ep_common {
@@ -161,6 +162,7 @@ struct iwch_ep_common {
         wait_queue_head_t waitq;
         int rpl_done;
         int rpl_err;
+        u32 flags;
 };
 
 struct iwch_listen_ep {
@@ -188,7 +190,6 @@ struct iwch_ep {
         u16 plen;
         u32 ird;
         u32 ord;
-        u32 flags;
 };
 
 static inline struct iwch_ep *to_ep(struct iw_cm_id *cm_id)
diff --git a/drivers/infiniband/hw/cxgb3/iwch_qp.c b/drivers/infiniband/hw/cxgb3/iwch_qp.c
index c758fbd58478..2f546a625330 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_qp.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_qp.c
@@ -751,7 +751,7 @@ int iwch_post_zb_read(struct iwch_qp *qhp)
         wqe->send.wrh.gen_tid_len = cpu_to_be32(V_FW_RIWR_TID(qhp->ep->hwtid)|
                                                 V_FW_RIWR_LEN(flit_cnt));
         skb->priority = CPL_PRIORITY_DATA;
-        return cxgb3_ofld_send(qhp->rhp->rdev.t3cdev_p, skb);
+        return iwch_cxgb3_ofld_send(qhp->rhp->rdev.t3cdev_p, skb);
 }
 
 /*
@@ -783,7 +783,7 @@ int iwch_post_terminate(struct iwch_qp *qhp, struct respQ_msg_t *rsp_msg)
                          V_FW_RIWR_FLAGS(T3_COMPLETION_FLAG | T3_NOTIFY_FLAG));
         wqe->send.wrh.gen_tid_len = cpu_to_be32(V_FW_RIWR_TID(qhp->ep->hwtid));
         skb->priority = CPL_PRIORITY_DATA;
-        return cxgb3_ofld_send(qhp->rhp->rdev.t3cdev_p, skb);
+        return iwch_cxgb3_ofld_send(qhp->rhp->rdev.t3cdev_p, skb);
 }
 
 /*
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index 2ccb9d31771f..ae3d7590346e 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -394,8 +394,7 @@ static int mlx4_ib_mmap(struct ib_ucontext *context, struct vm_area_struct *vma)
                                        PAGE_SIZE, vma->vm_page_prot))
                         return -EAGAIN;
         } else if (vma->vm_pgoff == 1 && dev->dev->caps.bf_reg_size != 0) {
-                /* FIXME want pgprot_writecombine() for BlueFlame pages */
-                vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
+                vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);
 
                 if (io_remap_pfn_range(vma, vma->vm_start,
                                        to_mucontext(context)->uar.pfn +
diff --git a/drivers/infiniband/hw/nes/nes.h b/drivers/infiniband/hw/nes/nes.h
index 04b12ad23390..17621de54a9f 100644
--- a/drivers/infiniband/hw/nes/nes.h
+++ b/drivers/infiniband/hw/nes/nes.h
@@ -289,8 +289,8 @@ static inline __le32 get_crc_value(struct nes_v4_quad *nes_quad)
 static inline void
 set_wqe_64bit_value(__le32 *wqe_words, u32 index, u64 value)
 {
-        wqe_words[index]     = cpu_to_le32((u32) ((unsigned long)value));
-        wqe_words[index + 1] = cpu_to_le32((u32)(upper_32_bits((unsigned long)value)));
+        wqe_words[index]     = cpu_to_le32((u32) value);
+        wqe_words[index + 1] = cpu_to_le32(upper_32_bits(value));
 }
 
 static inline void
diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
index 52425154acd4..dbd9a75474e3 100644
--- a/drivers/infiniband/hw/nes/nes_cm.c
+++ b/drivers/infiniband/hw/nes/nes_cm.c
@@ -426,6 +426,7 @@ int schedule_nes_timer(struct nes_cm_node *cm_node, struct sk_buff *skb,
         if (type == NES_TIMER_TYPE_CLOSE) {
                 new_send->timetosend += (HZ/10);
                 if (cm_node->recv_entry) {
+                        kfree(new_send);
                         WARN_ON(1);
                         return -EINVAL;
                 }
@@ -445,8 +446,8 @@ int schedule_nes_timer(struct nes_cm_node *cm_node, struct sk_buff *skb,
                 if (ret != NETDEV_TX_OK) {
                         nes_debug(NES_DBG_CM, "Error sending packet %p "
                                 "(jiffies = %lu)\n", new_send, jiffies);
-                        atomic_dec(&new_send->skb->users);
                         new_send->timetosend = jiffies;
+                        ret = NETDEV_TX_OK;
                 } else {
                         cm_packets_sent++;
                         if (!send_retrans) {
@@ -630,7 +631,6 @@ static void nes_cm_timer_tick(unsigned long pass)
                                 nes_debug(NES_DBG_CM, "rexmit failed for "
                                         "node=%p\n", cm_node);
                                 cm_packets_bounced++;
-                                atomic_dec(&send_entry->skb->users);
                                 send_entry->retrycount--;
                                 nexttimeout = jiffies + NES_SHORT_TIME;
                                 settimer = 1;
@@ -666,11 +666,6 @@ static void nes_cm_timer_tick(unsigned long pass)
 
                 spin_unlock_irqrestore(&cm_node->retrans_list_lock, flags);
                 rem_ref_cm_node(cm_node->cm_core, cm_node);
-                if (ret != NETDEV_TX_OK) {
-                        nes_debug(NES_DBG_CM, "rexmit failed for cm_node=%p\n",
-                                cm_node);
-                        break;
-                }
         }
 
         if (settimer) {
@@ -1262,7 +1257,6 @@ static int rem_ref_cm_node(struct nes_cm_core *cm_core,
                 cm_node->nesqp = NULL;
         }
 
-        cm_node->freed = 1;
         kfree(cm_node);
         return 0;
 }
@@ -1999,13 +1993,17 @@ static struct nes_cm_node *mini_cm_connect(struct nes_cm_core *cm_core,
                 if (loopbackremotelistener == NULL) {
                         create_event(cm_node, NES_CM_EVENT_ABORTED);
                 } else {
-                        atomic_inc(&cm_loopbacks);
                         loopback_cm_info = *cm_info;
                         loopback_cm_info.loc_port = cm_info->rem_port;
                         loopback_cm_info.rem_port = cm_info->loc_port;
                         loopback_cm_info.cm_id = loopbackremotelistener->cm_id;
                         loopbackremotenode = make_cm_node(cm_core, nesvnic,
                                 &loopback_cm_info, loopbackremotelistener);
+                        if (!loopbackremotenode) {
+                                rem_ref_cm_node(cm_node->cm_core, cm_node);
+                                return NULL;
+                        }
+                        atomic_inc(&cm_loopbacks);
                         loopbackremotenode->loopbackpartner = cm_node;
                         loopbackremotenode->tcp_cntxt.rcv_wscale =
                                 NES_CM_DEFAULT_RCV_WND_SCALE;
@@ -2690,6 +2688,7 @@ int nes_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
         struct ib_mr *ibmr = NULL;
         struct ib_phys_buf ibphysbuf;
         struct nes_pd *nespd;
+        u64 tagged_offset;
 
 
 
@@ -2755,10 +2754,11 @@ int nes_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
                 ibphysbuf.addr = nesqp->ietf_frame_pbase;
                 ibphysbuf.size = conn_param->private_data_len +
                                         sizeof(struct ietf_mpa_frame);
+                tagged_offset = (u64)(unsigned long)nesqp->ietf_frame;
                 ibmr = nesibdev->ibdev.reg_phys_mr((struct ib_pd *)nespd,
                                                 &ibphysbuf, 1,
                                                 IB_ACCESS_LOCAL_WRITE,
-                                                (u64 *)&nesqp->ietf_frame);
+                                                &tagged_offset);
                 if (!ibmr) {
                         nes_debug(NES_DBG_CM, "Unable to register memory region"
                                         "for lSMM for cm_node = %p \n",
@@ -2782,7 +2782,7 @@ int nes_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
                         sizeof(struct ietf_mpa_frame));
                 set_wqe_64bit_value(wqe->wqe_words,
                                         NES_IWARP_SQ_WQE_FRAG0_LOW_IDX,
-                                        (u64)nesqp->ietf_frame);
+                                        (u64)(unsigned long)nesqp->ietf_frame);
                 wqe->wqe_words[NES_IWARP_SQ_WQE_LENGTH0_IDX] =
                         cpu_to_le32(conn_param->private_data_len +
                         sizeof(struct ietf_mpa_frame));
diff --git a/drivers/infiniband/hw/nes/nes_cm.h b/drivers/infiniband/hw/nes/nes_cm.h
index d5f778202eb7..80bba1892571 100644
--- a/drivers/infiniband/hw/nes/nes_cm.h
+++ b/drivers/infiniband/hw/nes/nes_cm.h
@@ -298,7 +298,6 @@ struct nes_cm_node {
         struct nes_vnic           *nesvnic;
         int                       apbvt_set;
         int                       accept_pend;
-        int                     freed;
         struct list_head        timer_entry;
         struct list_head        reset_entry;
         struct nes_qp           *nesqp;
diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c
index 52e734042b8e..d6fc9ae44062 100644
--- a/drivers/infiniband/hw/nes/nes_hw.c
+++ b/drivers/infiniband/hw/nes/nes_hw.c
@@ -46,6 +46,10 @@ static unsigned int nes_lro_max_aggr = NES_LRO_MAX_AGGR;
 module_param(nes_lro_max_aggr, uint, 0444);
 MODULE_PARM_DESC(nes_lro_max_aggr, "NIC LRO max packet aggregation");
 
+static int wide_ppm_offset;
+module_param(wide_ppm_offset, int, 0644);
+MODULE_PARM_DESC(wide_ppm_offset, "Increase CX4 interface clock ppm offset, 0=100ppm (default), 1=300ppm");
+
 static u32 crit_err_count;
 u32 int_mod_timer_init;
 u32 int_mod_cq_depth_256;
@@ -546,8 +550,11 @@ struct nes_adapter *nes_init_adapter(struct nes_device *nesdev, u8 hw_rev) {
                         msleep(1);
                 }
                 if (int_cnt > 1) {
+                        u32 sds;
                         spin_lock_irqsave(&nesadapter->phy_lock, flags);
-                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL1, 0x0000F088);
+                        sds = nes_read_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL1);
+                        sds |= 0x00000040;
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL1, sds);
                         mh_detected++;
                         reset_value = nes_read32(nesdev->regs+NES_SOFTWARE_RESET);
                         reset_value |= 0x0000003d;
@@ -736,39 +743,49 @@ static int nes_init_serdes(struct nes_device *nesdev, u8 hw_rev, u8 port_count,
 {
         int i;
         u32 u32temp;
-        u32 serdes_common_control;
+        u32 sds;
 
         if (hw_rev != NE020_REV) {
                 /* init serdes 0 */
+                if (wide_ppm_offset && (nesadapter->phy_type[0] == NES_PHY_TYPE_CX4))
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_CDR_CONTROL0, 0x000FFFAA);
+                else
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_CDR_CONTROL0, 0x000000FF);
 
-                nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_CDR_CONTROL0, 0x000000FF);
                 if (nesadapter->phy_type[0] == NES_PHY_TYPE_PUMA_1G) {
-                        serdes_common_control = nes_read_indexed(nesdev,
-                                        NES_IDX_ETH_SERDES_COMMON_CONTROL0);
-                        serdes_common_control |= 0x000000100;
-                        nes_write_indexed(nesdev,
-                                        NES_IDX_ETH_SERDES_COMMON_CONTROL0,
-                                        serdes_common_control);
-                } else if (!OneG_Mode) {
-                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_TX_HIGHZ_LANE_MODE0, 0x11110000);
+                        sds = nes_read_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL0);
+                        sds |= 0x00000100;
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL0, sds);
                 }
-                if (((port_count > 1) &&
-                        (nesadapter->phy_type[0] != NES_PHY_TYPE_PUMA_1G)) ||
-                        ((port_count > 2) &&
-                        (nesadapter->phy_type[0] == NES_PHY_TYPE_PUMA_1G))) {
-                        /* init serdes 1 */
-                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_CDR_CONTROL1, 0x000000FF);
-                        if (nesadapter->phy_type[0] == NES_PHY_TYPE_PUMA_1G) {
-                                serdes_common_control = nes_read_indexed(nesdev,
-                                        NES_IDX_ETH_SERDES_COMMON_CONTROL1);
-                                serdes_common_control |= 0x000000100;
-                                nes_write_indexed(nesdev,
-                                        NES_IDX_ETH_SERDES_COMMON_CONTROL1,
-                                        serdes_common_control);
-                        } else if (!OneG_Mode) {
-                                nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_TX_HIGHZ_LANE_MODE1, 0x11110000);
-                        }
+                if (!OneG_Mode)
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_TX_HIGHZ_LANE_MODE0, 0x11110000);
+
+                if (port_count < 2)
+                        return 0;
+
+                /* init serdes 1 */
+                switch (nesadapter->phy_type[1]) {
+                case NES_PHY_TYPE_ARGUS:
+                case NES_PHY_TYPE_SFP_D:
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_TX_EMP0, 0x00000000);
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_TX_EMP1, 0x00000000);
+                        break;
+                case NES_PHY_TYPE_CX4:
+                        sds = nes_read_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL1);
+                        sds &= 0xFFFFFFBF;
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL1, sds);
+                        if (wide_ppm_offset)
+                                nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_CDR_CONTROL1, 0x000FFFAA);
+                        else
+                                nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_CDR_CONTROL1, 0x000000FF);
+                        break;
+                case NES_PHY_TYPE_PUMA_1G:
+                        sds = nes_read_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL1);
+                        sds |= 0x000000100;
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL1, sds);
                 }
+                if (!OneG_Mode)
+                        nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_TX_HIGHZ_LANE_MODE1, 0x11110000);
         } else {
                 /* init serdes 0 */
                 nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL0, 0x00000008);
@@ -1259,203 +1276,162 @@ int nes_init_phy(struct nes_device *nesdev)
 {
         struct nes_adapter *nesadapter = nesdev->nesadapter;
         u32 counter = 0;
-        u32 sds_common_control0;
+        u32 sds;
         u32 mac_index = nesdev->mac_index;
         u32 tx_config = 0;
         u16 phy_data;
         u32 temp_phy_data = 0;
         u32 temp_phy_data2 = 0;
-        u32 i = 0;
+        u8  phy_type = nesadapter->phy_type[mac_index];
+        u8  phy_index = nesadapter->phy_index[mac_index];
 
         if ((nesadapter->OneG_Mode) &&
-            (nesadapter->phy_type[mac_index] != NES_PHY_TYPE_PUMA_1G)) {
+            (phy_type != NES_PHY_TYPE_PUMA_1G)) {
                 nes_debug(NES_DBG_PHY, "1G PHY, mac_index = %d.\n", mac_index);
-                if (nesadapter->phy_type[mac_index] == NES_PHY_TYPE_1G) {
-                        printk(PFX "%s: Programming mdc config for 1G\n", __func__);
+                if (phy_type == NES_PHY_TYPE_1G) {
                         tx_config = nes_read_indexed(nesdev, NES_IDX_MAC_TX_CONFIG);
                         tx_config &= 0xFFFFFFE3;
                         tx_config |= 0x04;
                         nes_write_indexed(nesdev, NES_IDX_MAC_TX_CONFIG, tx_config);
                 }
 
-                nes_read_1G_phy_reg(nesdev, 1, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 1 phy address %u = 0x%X.\n",
-                                nesadapter->phy_index[mac_index], phy_data);
-                nes_write_1G_phy_reg(nesdev, 23, nesadapter->phy_index[mac_index], 0xb000);
+                nes_read_1G_phy_reg(nesdev, 1, phy_index, &phy_data);
+                nes_write_1G_phy_reg(nesdev, 23, phy_index, 0xb000);
 
                 /* Reset the PHY */
-                nes_write_1G_phy_reg(nesdev, 0, nesadapter->phy_index[mac_index], 0x8000);
+                nes_write_1G_phy_reg(nesdev, 0, phy_index, 0x8000);
                 udelay(100);
                 counter = 0;
                 do {
-                        nes_read_1G_phy_reg(nesdev, 0, nesadapter->phy_index[mac_index], &phy_data);
-                        nes_debug(NES_DBG_PHY, "Phy data from register 0 = 0x%X.\n", phy_data);
-                        if (counter++ > 100) break;
+                        nes_read_1G_phy_reg(nesdev, 0, phy_index, &phy_data);
+                        if (counter++ > 100)
+                                break;
                 } while (phy_data & 0x8000);
 
                 /* Setting no phy loopback */
                 phy_data &= 0xbfff;
                 phy_data |= 0x1140;
-                nes_write_1G_phy_reg(nesdev, 0, nesadapter->phy_index[mac_index],  phy_data);
-                nes_read_1G_phy_reg(nesdev, 0, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 0 = 0x%X.\n", phy_data);
-
-                nes_read_1G_phy_reg(nesdev, 0x17, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 0x17 = 0x%X.\n", phy_data);
-
-                nes_read_1G_phy_reg(nesdev, 0x1e, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 0x1e = 0x%X.\n", phy_data);
+                nes_write_1G_phy_reg(nesdev, 0, phy_index,  phy_data);
+                nes_read_1G_phy_reg(nesdev, 0, phy_index, &phy_data);
+                nes_read_1G_phy_reg(nesdev, 0x17, phy_index, &phy_data);
+                nes_read_1G_phy_reg(nesdev, 0x1e, phy_index, &phy_data);
 
                 /* Setting the interrupt mask */
-                nes_read_1G_phy_reg(nesdev, 0x19, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 0x19 = 0x%X.\n", phy_data);
-                nes_write_1G_phy_reg(nesdev, 0x19, nesadapter->phy_index[mac_index], 0xffee);
-
-                nes_read_1G_phy_reg(nesdev, 0x19, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 0x19 = 0x%X.\n", phy_data);
+                nes_read_1G_phy_reg(nesdev, 0x19, phy_index, &phy_data);
+                nes_write_1G_phy_reg(nesdev, 0x19, phy_index, 0xffee);
+                nes_read_1G_phy_reg(nesdev, 0x19, phy_index, &phy_data);
 
                 /* turning on flow control */
-                nes_read_1G_phy_reg(nesdev, 4, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 0x4 = 0x%X.\n", phy_data);
-                nes_write_1G_phy_reg(nesdev, 4, nesadapter->phy_index[mac_index],
-                                (phy_data & ~(0x03E0)) | 0xc00);
-                /* nes_write_1G_phy_reg(nesdev, 4, nesadapter->phy_index[mac_index],
-                                phy_data | 0xc00); */
-                nes_read_1G_phy_reg(nesdev, 4, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 0x4 = 0x%X.\n", phy_data);
-
-                nes_read_1G_phy_reg(nesdev, 9, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 0x9 = 0x%X.\n", phy_data);
-                /* Clear Half duplex */
-                nes_write_1G_phy_reg(nesdev, 9, nesadapter->phy_index[mac_index],
-                                phy_data & ~(0x0100));
-                nes_read_1G_phy_reg(nesdev, 9, nesadapter->phy_index[mac_index], &phy_data);
-                nes_debug(NES_DBG_PHY, "Phy data from register 0x9 = 0x%X.\n", phy_data);
-
-                nes_read_1G_phy_reg(nesdev, 0, nesadapter->phy_index[mac_index], &phy_data);
-                nes_write_1G_phy_reg(nesdev, 0, nesadapter->phy_index[mac_index], phy_data | 0x0300);
-        } else {
-                if ((nesadapter->phy_type[mac_index] == NES_PHY_TYPE_IRIS) ||
-                    (nesadapter->phy_type[mac_index] == NES_PHY_TYPE_ARGUS)) {
-                        /* setup 10G MDIO operation */
-                        tx_config = nes_read_indexed(nesdev, NES_IDX_MAC_TX_CONFIG);
-                        tx_config &= 0xFFFFFFE3;
-                        tx_config |= 0x15;
-                        nes_write_indexed(nesdev, NES_IDX_MAC_TX_CONFIG, tx_config);
-                }
-                if ((nesadapter->phy_type[mac_index] == NES_PHY_TYPE_ARGUS)) {
-                        nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x3, 0xd7ee);
+                nes_read_1G_phy_reg(nesdev, 4, phy_index, &phy_data);
+                nes_write_1G_phy_reg(nesdev, 4, phy_index, (phy_data & ~(0x03E0)) | 0xc00);
+                nes_read_1G_phy_reg(nesdev, 4, phy_index, &phy_data);
 
-                        temp_phy_data = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
-                        mdelay(10);
-                        nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x3, 0xd7ee);
-                        temp_phy_data2 = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
+                /* Clear Half duplex */
+                nes_read_1G_phy_reg(nesdev, 9, phy_index, &phy_data);
+                nes_write_1G_phy_reg(nesdev, 9, phy_index, phy_data & ~(0x0100));
+                nes_read_1G_phy_reg(nesdev, 9, phy_index, &phy_data);
 
-                        /*
-                         * if firmware is already running (like from a
-                         * driver un-load/load, don't do anything.
-                         */
-                        if (temp_phy_data == temp_phy_data2) {
-                                /* configure QT2505 AMCC PHY */
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0x0000, 0x8000);
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xc300, 0x0000);
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xc302, 0x0044);
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xc318, 0x0052);
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xc319, 0x0008);
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xc31a, 0x0098);
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x3, 0x0026, 0x0E00);
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x3, 0x0027, 0x0001);
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x3, 0x0028, 0xA528);
+                nes_read_1G_phy_reg(nesdev, 0, phy_index, &phy_data);
+                nes_write_1G_phy_reg(nesdev, 0, phy_index, phy_data | 0x0300);
 
-                                /*
-                                 * remove micro from reset; chip boots from ROM,
-                                 * uploads EEPROM f/w image, uC executes f/w
-                                 */
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xc300, 0x0002);
+                return 0;
+        }
 
-                                /*
-                                 * wait for heart beat to start to
-                                 * know loading is done
-                                 */
-                                counter = 0;
-                                do {
-                                        nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x3, 0xd7ee);
-                                        temp_phy_data = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
-                                        if (counter++ > 1000) {
-                                                nes_debug(NES_DBG_PHY, "AMCC PHY- breaking from heartbeat check <this is bad!!!> \n");
-                                                break;
-                                        }
-                                        mdelay(100);
-                                        nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x3, 0xd7ee);
-                                        temp_phy_data2 = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
-                                } while ((temp_phy_data2 == temp_phy_data));
+        if ((phy_type == NES_PHY_TYPE_IRIS) ||
+            (phy_type == NES_PHY_TYPE_ARGUS) ||
+            (phy_type == NES_PHY_TYPE_SFP_D)) {
+                /* setup 10G MDIO operation */
+                tx_config = nes_read_indexed(nesdev, NES_IDX_MAC_TX_CONFIG);
+                tx_config &= 0xFFFFFFE3;
+                tx_config |= 0x15;
+                nes_write_indexed(nesdev, NES_IDX_MAC_TX_CONFIG, tx_config);
+        }
+        if ((phy_type == NES_PHY_TYPE_ARGUS) ||
+            (phy_type == NES_PHY_TYPE_SFP_D)) {
+                /* Check firmware heartbeat */
+                nes_read_10G_phy_reg(nesdev, phy_index, 0x3, 0xd7ee);
+                temp_phy_data = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
+                udelay(1500);
+                nes_read_10G_phy_reg(nesdev, phy_index, 0x3, 0xd7ee);
+                temp_phy_data2 = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
+
+                if (temp_phy_data != temp_phy_data2)
+                        return 0;
 
-                                /*
-                                 * wait for tracking to start to know
-                                 * f/w is good to go
-                                 */
-                                counter = 0;
-                                do {
-                                        nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x3, 0xd7fd);
-                                        temp_phy_data = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
-                                        if (counter++ > 1000) {
-                                                nes_debug(NES_DBG_PHY, "AMCC PHY- breaking from status check <this is bad!!!> \n");
-                                                break;
-                                        }
-                                        mdelay(1000);
-                                        /*
-                                         * nes_debug(NES_DBG_PHY, "AMCC PHY- phy_status not ready yet = 0x%02X\n",
-                                         *                      temp_phy_data);
-                                         */
-                                } while (((temp_phy_data & 0xff) != 0x50) && ((temp_phy_data & 0xff) != 0x70));
-
-                                /* set LOS Control invert RXLOSB_I_PADINV */
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xd003, 0x0000);
-                                /* set LOS Control to mask of RXLOSB_I */
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xc314, 0x0042);
-                                /* set LED1 to input mode (LED1 and LED2 share same LED) */
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xd006, 0x0007);
-                                /* set LED2 to RX link_status and activity */
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xd007, 0x000A);
-                                /* set LED3 to RX link_status */
-                                nes_write_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 0x1, 0xd008, 0x0009);
+                /* no heartbeat, configure the PHY */
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0x0000, 0x8000);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc300, 0x0000);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc316, 0x000A);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc318, 0x0052);
+                if (phy_type == NES_PHY_TYPE_ARGUS) {
+                        nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc302, 0x000C);
+                        nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc319, 0x0008);
+                } else {
+                        nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc302, 0x0004);
+                        nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc319, 0x0038);
+                }
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc31a, 0x0098);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x3, 0x0026, 0x0E00);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x3, 0x0027, 0x0001);
 
-                                /*
-                                 * reset the res-calibration on t2
-                                 * serdes; ensures it is stable after
-                                 * the amcc phy is stable
-                                 */
+                /* setup LEDs */
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xd006, 0x0007);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xd007, 0x000A);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xd008, 0x0009);
 
-                                sds_common_control0  = nes_read_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL0);
-                                sds_common_control0 |= 0x1;
-                                nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL0, sds_common_control0);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x3, 0x0028, 0xA528);
 
-                                /* release the res-calibration reset */
-                                sds_common_control0 &= 0xfffffffe;
-                                nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL0, sds_common_control0);
+                /* Bring PHY out of reset */
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc300, 0x0002);
 
-                                i = 0;
-                                while (((nes_read32(nesdev->regs + NES_SOFTWARE_RESET) & 0x00000040) != 0x00000040)
-                                                && (i++ < 5000)) {
-                                        /* mdelay(1); */
-                                }
+                /* Check for heartbeat */
+                counter = 0;
+                mdelay(690);
+                nes_read_10G_phy_reg(nesdev, phy_index, 0x3, 0xd7ee);
+                temp_phy_data = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
+                do {
+                        if (counter++ > 150) {
+                                nes_debug(NES_DBG_PHY, "No PHY heartbeat\n");
+                                break;
+                        }
+                        mdelay(1);
+                        nes_read_10G_phy_reg(nesdev, phy_index, 0x3, 0xd7ee);
+                        temp_phy_data2 = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
+                } while ((temp_phy_data2 == temp_phy_data));
 
-                                /*
-                                 * wait for link train done before moving on,
-                                 * or will get an interupt storm
-                                 */
-                                counter = 0;
-                                do {
-                                        temp_phy_data = nes_read_indexed(nesdev, NES_IDX_PHY_PCS_CONTROL_STATUS0 +
-                                                                (0x200 * (nesdev->mac_index & 1)));
-                                        if (counter++ > 1000) {
-                                                nes_debug(NES_DBG_PHY, "AMCC PHY- breaking from link train wait <this is bad, link didnt train!!!>\n");
-                                                break;
-                                        }
-                                        mdelay(1);
-                                } while (((temp_phy_data & 0x0f1f0000) != 0x0f0f0000));
+                /* wait for tracking */
+                counter = 0;
+                do {
+                        nes_read_10G_phy_reg(nesdev, phy_index, 0x3, 0xd7fd);
+                        temp_phy_data = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
+                        if (counter++ > 300) {
+                                nes_debug(NES_DBG_PHY, "PHY did not track\n");
+                                break;
                         }
-                }
+                        mdelay(10);
+                } while (((temp_phy_data & 0xff) != 0x50) && ((temp_phy_data & 0xff) != 0x70));
+
+                /* setup signal integrity */
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xd003, 0x0000);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xF00D, 0x00FE);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xF00E, 0x0032);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xF00F, 0x0002);
+                nes_write_10G_phy_reg(nesdev, phy_index, 0x1, 0xc314, 0x0063);
+
+                /* reset serdes */
+                sds = nes_read_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL0 +
+                                       mac_index * 0x200);
+                sds |= 0x1;
+                nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL0 +
+                                  mac_index * 0x200, sds);
+                sds &= 0xfffffffe;
+                nes_write_indexed(nesdev, NES_IDX_ETH_SERDES_COMMON_CONTROL0 +
+                                  mac_index * 0x200, sds);
+
+                counter = 0;
+                while (((nes_read32(nesdev->regs + NES_SOFTWARE_RESET) & 0x00000040) != 0x00000040)
+                                && (counter++ < 5000))
+                        ;
         }
         return 0;
 }
@@ -2359,6 +2335,7 @@ static void nes_process_mac_intr(struct nes_device *nesdev, u32 mac_number)
         u16 temp_phy_data;
         u32 pcs_val  = 0x0f0f0000;
         u32 pcs_mask = 0x0f1f0000;
+        u32 cdr_ctrl;
 
         spin_lock_irqsave(&nesadapter->phy_lock, flags);
         if (nesadapter->mac_sw_state[mac_number] != NES_MAC_SW_IDLE) {
@@ -2473,6 +2450,7 @@ static void nes_process_mac_intr(struct nes_device *nesdev, u32 mac_number)
                                 break;
 
                         case NES_PHY_TYPE_ARGUS:
+                        case NES_PHY_TYPE_SFP_D:
                                 /* clear the alarms */
                                 nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 4, 0x0008);
                                 nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 4, 0xc001);
@@ -2483,19 +2461,18 @@ static void nes_process_mac_intr(struct nes_device *nesdev, u32 mac_number)
                                 nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 1, 0x9004);
                                 nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 1, 0x9005);
                                 /* check link status */
-                                nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 1, 1);
+                                nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 1, 0x9003);
                                 temp_phy_data = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
-                                u32temp = 100;
-                                do {
-                                        nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 1, 1);
 
-                                        phy_data = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
-                                        if ((phy_data == temp_phy_data) || (!(--u32temp)))
-                                                break;
-                                        temp_phy_data = phy_data;
-                                } while (1);
+                                nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 3, 0x0021);
+                                nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
+                                nes_read_10G_phy_reg(nesdev, nesadapter->phy_index[mac_index], 3, 0x0021);
+                                phy_data = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
+
+                                phy_data = (!temp_phy_data && (phy_data == 0x8000)) ? 0x4 : 0x0;
+
                                 nes_debug(NES_DBG_PHY, "%s: Phy data = 0x%04X, link was %s.\n",
-                                        __func__, phy_data, nesadapter->mac_link_down ? "DOWN" : "UP");
+                                        __func__, phy_data, nesadapter->mac_link_down[mac_index] ? "DOWN" : "UP");
                                 break;
 
                         case NES_PHY_TYPE_PUMA_1G:
@@ -2511,6 +2488,17 @@ static void nes_process_mac_intr(struct nes_device *nesdev, u32 mac_number)
                 }
 
                 if (phy_data & 0x0004) {
+                        if (wide_ppm_offset &&
+                            (nesadapter->phy_type[mac_index] == NES_PHY_TYPE_CX4) &&
+                            (nesadapter->hw_rev != NE020_REV)) {
+                                cdr_ctrl = nes_read_indexed(nesdev,
+                                                            NES_IDX_ETH_SERDES_CDR_CONTROL0 +
+                                                            mac_index * 0x200);
+                                nes_write_indexed(nesdev,
+                                                  NES_IDX_ETH_SERDES_CDR_CONTROL0 +
+                                                  mac_index * 0x200,
+                                                  cdr_ctrl | 0x000F0000);
+                        }
                         nesadapter->mac_link_down[mac_index] = 0;
                         list_for_each_entry(nesvnic, &nesadapter->nesvnic_list[mac_index], list) {
                                 nes_debug(NES_DBG_PHY, "The Link is UP!!.  linkup was %d\n",
@@ -2525,6 +2513,17 @@ static void nes_process_mac_intr(struct nes_device *nesdev, u32 mac_number)
                                 }
                         }
                 } else {
+                        if (wide_ppm_offset &&
+                            (nesadapter->phy_type[mac_index] == NES_PHY_TYPE_CX4) &&
+                            (nesadapter->hw_rev != NE020_REV)) {
+                                cdr_ctrl = nes_read_indexed(nesdev,
+                                                            NES_IDX_ETH_SERDES_CDR_CONTROL0 +
+                                                            mac_index * 0x200);
+                                nes_write_indexed(nesdev,
+                                                  NES_IDX_ETH_SERDES_CDR_CONTROL0 +
+                                                  mac_index * 0x200,
+                                                  cdr_ctrl & 0xFFF0FFFF);
+                        }
                         nesadapter->mac_link_down[mac_index] = 1;
                         list_for_each_entry(nesvnic, &nesadapter->nesvnic_list[mac_index], list) {
                                 nes_debug(NES_DBG_PHY, "The Link is Down!!. linkup was %d\n",
diff --git a/drivers/infiniband/hw/nes/nes_hw.h b/drivers/infiniband/hw/nes/nes_hw.h
index f41a8710d2a8..c3654c6383fe 100644
--- a/drivers/infiniband/hw/nes/nes_hw.h
+++ b/drivers/infiniband/hw/nes/nes_hw.h
@@ -35,12 +35,14 @@
 
 #include <linux/inet_lro.h>
 
+#define NES_PHY_TYPE_CX4       1
 #define NES_PHY_TYPE_1G        2
 #define NES_PHY_TYPE_IRIS      3
 #define NES_PHY_TYPE_ARGUS     4
 #define NES_PHY_TYPE_PUMA_1G   5
 #define NES_PHY_TYPE_PUMA_10G  6
 #define NES_PHY_TYPE_GLADIUS   7
+#define NES_PHY_TYPE_SFP_D     8
 
 #define NES_MULTICAST_PF_MAX 8
 
diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c
index ecb1f6fd6276..c6e6611d3016 100644
--- a/drivers/infiniband/hw/nes/nes_nic.c
+++ b/drivers/infiniband/hw/nes/nes_nic.c
@@ -1426,49 +1426,55 @@ static int nes_netdev_get_settings(struct net_device *netdev, struct ethtool_cmd
         struct nes_vnic *nesvnic = netdev_priv(netdev);
         struct nes_device *nesdev = nesvnic->nesdev;
         struct nes_adapter *nesadapter = nesdev->nesadapter;
+        u32 mac_index = nesdev->mac_index;
+        u8 phy_type = nesadapter->phy_type[mac_index];
+        u8 phy_index = nesadapter->phy_index[mac_index];
         u16 phy_data;
 
         et_cmd->duplex = DUPLEX_FULL;
         et_cmd->port   = PORT_MII;
+        et_cmd->maxtxpkt = 511;
+        et_cmd->maxrxpkt = 511;
 
         if (nesadapter->OneG_Mode) {
                 et_cmd->speed = SPEED_1000;
-                if (nesadapter->phy_type[nesdev->mac_index] == NES_PHY_TYPE_PUMA_1G) {
+                if (phy_type == NES_PHY_TYPE_PUMA_1G) {
                         et_cmd->supported   = SUPPORTED_1000baseT_Full;
                         et_cmd->advertising = ADVERTISED_1000baseT_Full;
                         et_cmd->autoneg     = AUTONEG_DISABLE;
                         et_cmd->transceiver = XCVR_INTERNAL;
-                        et_cmd->phy_address = nesdev->mac_index;
+                        et_cmd->phy_address = mac_index;
                 } else {
-                        et_cmd->supported   = SUPPORTED_1000baseT_Full | SUPPORTED_Autoneg;
-                        et_cmd->advertising = ADVERTISED_1000baseT_Full | ADVERTISED_Autoneg;
-                        nes_read_1G_phy_reg(nesdev, 0, nesadapter->phy_index[nesdev->mac_index], &phy_data);
+                        et_cmd->supported   = SUPPORTED_1000baseT_Full
+                                            | SUPPORTED_Autoneg;
+                        et_cmd->advertising = ADVERTISED_1000baseT_Full
+                                            | ADVERTISED_Autoneg;
+                        nes_read_1G_phy_reg(nesdev, 0, phy_index, &phy_data);
                         if (phy_data & 0x1000)
                                 et_cmd->autoneg = AUTONEG_ENABLE;
                         else
                                 et_cmd->autoneg = AUTONEG_DISABLE;
                         et_cmd->transceiver = XCVR_EXTERNAL;
-                        et_cmd->phy_address = nesadapter->phy_index[nesdev->mac_index];
+                        et_cmd->phy_address = phy_index;
                 }
+                return 0;
+        }
+        if ((phy_type == NES_PHY_TYPE_IRIS) ||
+            (phy_type == NES_PHY_TYPE_ARGUS) ||
+            (phy_type == NES_PHY_TYPE_SFP_D)) {
+                et_cmd->transceiver = XCVR_EXTERNAL;
+                et_cmd->port        = PORT_FIBRE;
+                et_cmd->supported   = SUPPORTED_FIBRE;
+                et_cmd->advertising = ADVERTISED_FIBRE;
+                et_cmd->phy_address = phy_index;
         } else {
-                if ((nesadapter->phy_type[nesdev->mac_index] == NES_PHY_TYPE_IRIS) ||
-                    (nesadapter->phy_type[nesdev->mac_index] == NES_PHY_TYPE_ARGUS)) {
-                        et_cmd->transceiver = XCVR_EXTERNAL;
-                        et_cmd->port        = PORT_FIBRE;
-                        et_cmd->supported   = SUPPORTED_FIBRE;
-                        et_cmd->advertising = ADVERTISED_FIBRE;
-                        et_cmd->phy_address = nesadapter->phy_index[nesdev->mac_index];
-                } else {
-                        et_cmd->transceiver = XCVR_INTERNAL;
-                        et_cmd->supported   = SUPPORTED_10000baseT_Full;
-                        et_cmd->advertising = ADVERTISED_10000baseT_Full;
-                        et_cmd->phy_address = nesdev->mac_index;
-                }
-                et_cmd->speed = SPEED_10000;
-                et_cmd->autoneg = AUTONEG_DISABLE;
+                et_cmd->transceiver = XCVR_INTERNAL;
+                et_cmd->supported   = SUPPORTED_10000baseT_Full;
+                et_cmd->advertising = ADVERTISED_10000baseT_Full;
+                et_cmd->phy_address = mac_index;
         }
-        et_cmd->maxtxpkt = 511;
-        et_cmd->maxrxpkt = 511;
+        et_cmd->speed = SPEED_10000;
+        et_cmd->autoneg = AUTONEG_DISABLE;
         return 0;
 }
 
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c
index 5a76a5510350..4c57f329dd50 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c
@@ -70,12 +70,14 @@ int ipoib_vlan_add(struct net_device *pdev, unsigned short pkey)
          */
         if (ppriv->pkey == pkey) {
                 result = -ENOTUNIQ;
+                priv = NULL;
                 goto err;
         }
 
         list_for_each_entry(priv, &ppriv->child_intfs, list) {
                 if (priv->pkey == pkey) {
                         result = -ENOTUNIQ;
+                        priv = NULL;
                         goto err;
                 }
         }
@@ -96,7 +98,7 @@ int ipoib_vlan_add(struct net_device *pdev, unsigned short pkey)
 
         result = ipoib_set_dev_features(priv, ppriv->ca);
         if (result)
-                goto device_init_failed;
+                goto err;
 
         priv->pkey = pkey;
 
@@ -109,7 +111,7 @@ int ipoib_vlan_add(struct net_device *pdev, unsigned short pkey)
                 ipoib_warn(ppriv, "failed to initialize subinterface: "
                            "device %s, port %d",
                            ppriv->ca->name, ppriv->port);
-                goto device_init_failed;
+                goto err;
         }
 
         result = register_netdevice(priv->dev);
@@ -146,19 +148,19 @@ sysfs_failed:
 register_failed:
         ipoib_dev_cleanup(priv->dev);
 
-device_init_failed:
-        free_netdev(priv->dev);
-
 err:
         mutex_unlock(&ppriv->vlan_mutex);
         rtnl_unlock();
+        if (priv)
+                free_netdev(priv->dev);
+
         return result;
 }
 
 int ipoib_vlan_delete(struct net_device *pdev, unsigned short pkey)
 {
         struct ipoib_dev_priv *ppriv, *priv, *tpriv;
-        int ret = -ENOENT;
+        struct net_device *dev = NULL;
 
         if (!capable(CAP_NET_ADMIN))
                 return -EPERM;
@@ -172,14 +174,17 @@ int ipoib_vlan_delete(struct net_device *pdev, unsigned short pkey)
                         unregister_netdevice(priv->dev);
                         ipoib_dev_cleanup(priv->dev);
                         list_del(&priv->list);
-                        free_netdev(priv->dev);
-
-                        ret = 0;
+                        dev = priv->dev;
                         break;
                 }
         }
         mutex_unlock(&ppriv->vlan_mutex);
         rtnl_unlock();
 
-        return ret;
+        if (dev) {
+                free_netdev(dev);
+                return 0;
+        }
+
+        return -ENODEV;
 }
diff --git a/drivers/input/input.c b/drivers/input/input.c
index ec3db3ade118..d44065d2e662 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -132,6 +132,11 @@ static void input_start_autorepeat(struct input_dev *dev, int code)
         }
 }
 
+static void input_stop_autorepeat(struct input_dev *dev)
+{
+        del_timer(&dev->timer);
+}
+
 #define INPUT_IGNORE_EVENT      0
 #define INPUT_PASS_TO_HANDLERS  1
 #define INPUT_PASS_TO_DEVICE    2
@@ -167,6 +172,8 @@ static void input_handle_event(struct input_dev *dev,
                                 __change_bit(code, dev->key);
                                 if (value)
                                         input_start_autorepeat(dev, code);
+                                else
+                                        input_stop_autorepeat(dev);
                         }
 
                         disposition = INPUT_PASS_TO_HANDLERS;
@@ -737,11 +744,11 @@ static inline void input_wakeup_procfs_readers(void)
 
 static unsigned int input_proc_devices_poll(struct file *file, poll_table *wait)
 {
-        int state = input_devices_state;
-
         poll_wait(file, &input_devices_poll_wait, wait);
-        if (state != input_devices_state)
+        if (file->f_version != input_devices_state) {
+                file->f_version = input_devices_state;
                 return POLLIN | POLLRDNORM;
+        }
 
         return 0;
 }
diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 45470f18d7e9..f999dc60c3b8 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -229,7 +229,8 @@ struct atkbd {
 /*
  * System-specific ketymap fixup routine
  */
-static void (*atkbd_platform_fixup)(struct atkbd *);
+static void (*atkbd_platform_fixup)(struct atkbd *, const void *data);
+static void *atkbd_platform_fixup_data;
 
 static ssize_t atkbd_attr_show_helper(struct device *dev, char *buf,
                                 ssize_t (*handler)(struct atkbd *, char *));
@@ -834,87 +835,64 @@ static void atkbd_disconnect(struct serio *serio)
 }
 
 /*
- * Most special keys (Fn+F?) on Dell laptops do not generate release
- * events so we have to do it ourselves.
+ * generate release events for the keycodes given in data
  */
-static void atkbd_dell_laptop_keymap_fixup(struct atkbd *atkbd)
+static void atkbd_apply_forced_release_keylist(struct atkbd* atkbd,
+                                                const void *data)
 {
-        static const unsigned int forced_release_keys[] = {
-                0x85, 0x86, 0x87, 0x88, 0x89, 0x8a, 0x8b, 0x8f, 0x93,
-        };
-        int i;
+        const unsigned int *keys = data;
+        unsigned int i;
 
         if (atkbd->set == 2)
-                for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
-                        __set_bit(forced_release_keys[i],
-                                  atkbd->force_release_mask);
+                for (i = 0; keys[i] != -1U; i++)
+                        __set_bit(keys[i], atkbd->force_release_mask);
 }
 
 /*
+ * Most special keys (Fn+F?) on Dell laptops do not generate release
+ * events so we have to do it ourselves.
+ */
+static unsigned int atkbd_dell_laptop_forced_release_keys[] = {
+        0x85, 0x86, 0x87, 0x88, 0x89, 0x8a, 0x8b, 0x8f, 0x93, -1U
+};
+
+/*
  * Perform fixup for HP system that doesn't generate release
  * for its video switch
  */
-static void atkbd_hp_keymap_fixup(struct atkbd *atkbd)
-{
-        static const unsigned int forced_release_keys[] = {
-                0x94,
-        };
-        int i;
-
-        if (atkbd->set == 2)
-                for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
-                        __set_bit(forced_release_keys[i],
-                                        atkbd->force_release_mask);
-}
+static unsigned int atkbd_hp_forced_release_keys[] = {
+        0x94, -1U
+};
 
 /*
  * Inventec system with broken key release on volume keys
  */
-static void atkbd_inventec_keymap_fixup(struct atkbd *atkbd)
-{
-        const unsigned int forced_release_keys[] = {
-                0xae, 0xb0,
-        };
-        int i;
-
-        if (atkbd->set == 2)
-                for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
-                        __set_bit(forced_release_keys[i],
-                                  atkbd->force_release_mask);
-}
+static unsigned int atkbd_inventec_forced_release_keys[] = {
+        0xae, 0xb0, -1U
+};
 
 /*
  * Perform fixup for HP Pavilion ZV6100 laptop that doesn't generate release
  * for its volume buttons
  */
-static void atkbd_hp_zv6100_keymap_fixup(struct atkbd *atkbd)
-{
-        const unsigned int forced_release_keys[] = {
-                0xae, 0xb0,
-        };
-        int i;
-
-        if (atkbd->set == 2)
-                for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
-                        __set_bit(forced_release_keys[i],
-                                        atkbd->force_release_mask);
-}
+static unsigned int atkbd_hp_zv6100_forced_release_keys[] = {
+        0xae, 0xb0, -1U
+};
 
 /*
  * Samsung NC10 with Fn+F? key release not working
  */
-static void atkbd_samsung_keymap_fixup(struct atkbd *atkbd)
-{
-        const unsigned int forced_release_keys[] = {
-                0x82, 0x83, 0x84, 0x86, 0x88, 0x89, 0xb3, 0xf7, 0xf9,
-        };
-        int i;
+static unsigned int atkbd_samsung_forced_release_keys[] = {
+        0x82, 0x83, 0x84, 0x86, 0x88, 0x89, 0xb3, 0xf7, 0xf9, -1U
+};
 
-        if (atkbd->set == 2)
-                for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
-                        __set_bit(forced_release_keys[i],
-                                  atkbd->force_release_mask);
-}
+/*
+ * The volume up and volume down special keys on a Fujitsu Amilo PA 1510 laptop
+ * do not generate release events so we have to do it ourselves.
+ */
+static unsigned int atkbd_amilo_pa1510_forced_release_keys[] = {
+        0xb0, 0xae, -1U
+};
 
 /*
  * atkbd_set_keycode_table() initializes keyboard's keycode table
@@ -967,7 +945,7 @@ static void atkbd_set_keycode_table(struct atkbd *atkbd)
  * Perform additional fixups
  */
         if (atkbd_platform_fixup)
-                atkbd_platform_fixup(atkbd);
+                atkbd_platform_fixup(atkbd, atkbd_platform_fixup_data);
 }
 
 /*
@@ -1492,9 +1470,11 @@ static ssize_t atkbd_show_err_count(struct atkbd *atkbd, char *buf)
         return sprintf(buf, "%lu\n", atkbd->err_count);
 }
 
-static int __init atkbd_setup_fixup(const struct dmi_system_id *id)
+static int __init atkbd_setup_forced_release(const struct dmi_system_id *id)
 {
-        atkbd_platform_fixup = id->driver_data;
+        atkbd_platform_fixup = atkbd_apply_forced_release_keylist;
+        atkbd_platform_fixup_data = id->driver_data;
+
         return 0;
 }
 
@@ -1505,8 +1485,8 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
                         DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
                 },
-                .callback = atkbd_setup_fixup,
-                .driver_data = atkbd_dell_laptop_keymap_fixup,
+                .callback = atkbd_setup_forced_release,
+                .driver_data = atkbd_dell_laptop_forced_release_keys,
         },
         {
                 .ident = "Dell Laptop",
@@ -1514,8 +1494,8 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
                         DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
                 },
-                .callback = atkbd_setup_fixup,
-                .driver_data = atkbd_dell_laptop_keymap_fixup,
+                .callback = atkbd_setup_forced_release,
+                .driver_data = atkbd_dell_laptop_forced_release_keys,
         },
         {
                 .ident = "HP 2133",
@@ -1523,8 +1503,8 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "HP 2133"),
                 },
-                .callback = atkbd_setup_fixup,
-                .driver_data = atkbd_hp_keymap_fixup,
+                .callback = atkbd_setup_forced_release,
+                .driver_data = atkbd_hp_forced_release_keys,
         },
         {
                 .ident = "HP Pavilion ZV6100",
@@ -1532,8 +1512,8 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Pavilion ZV6100"),
                 },
-                .callback = atkbd_setup_fixup,
-                .driver_data = atkbd_hp_zv6100_keymap_fixup,
+                .callback = atkbd_setup_forced_release,
+                .driver_data = atkbd_hp_zv6100_forced_release_keys,
         },
         {
                 .ident = "Inventec Symphony",
@@ -1541,8 +1521,8 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                         DMI_MATCH(DMI_SYS_VENDOR, "INVENTEC"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "SYMPHONY 6.0/7.0"),
                 },
-                .callback = atkbd_setup_fixup,
-                .driver_data = atkbd_inventec_keymap_fixup,
+                .callback = atkbd_setup_forced_release,
+                .driver_data = atkbd_inventec_forced_release_keys,
         },
         {
                 .ident = "Samsung NC10",
@@ -1550,8 +1530,17 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                         DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "NC10"),
                 },
-                .callback = atkbd_setup_fixup,
-                .driver_data = atkbd_samsung_keymap_fixup,
+                .callback = atkbd_setup_forced_release,
+                .driver_data = atkbd_samsung_forced_release_keys,
+        },
+        {
+                .ident = "Fujitsu Amilo PA 1510",
+                .matches = {
+                        DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
+                        DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Pa 1510"),
+                },
+                .callback = atkbd_setup_forced_release,
+                .driver_data = atkbd_amilo_pa1510_forced_release_keys,
         },
         { }
 };
diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c
index ee855c5202e8..e94b7d735aca 100644
--- a/drivers/input/keyboard/bf54x-keys.c
+++ b/drivers/input/keyboard/bf54x-keys.c
@@ -211,8 +211,8 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
 
         if (!pdata->debounce_time || pdata->debounce_time > MAX_MULT ||
             !pdata->coldrive_time || pdata->coldrive_time > MAX_MULT) {
-                printk(KERN_ERR DRV_NAME
-                        ": Invalid Debounce/Columdrive Time from pdata\n");
+                printk(KERN_WARNING DRV_NAME
+                        ": Invalid Debounce/Columndrive Time in platform data\n");
                 bfin_write_KPAD_MSEL(0xFF0);    /* Default MSEL */
         } else {
                 bfin_write_KPAD_MSEL(
diff --git a/drivers/input/keyboard/hilkbd.c b/drivers/input/keyboard/hilkbd.c
index aacf71f3cd44..e9d639ec283d 100644
--- a/drivers/input/keyboard/hilkbd.c
+++ b/drivers/input/keyboard/hilkbd.c
@@ -198,45 +198,28 @@ static void hil_do(unsigned char cmd, unsigned char *data, unsigned int len)
 }
 
 
-/* initialise HIL */
-static int __init
-hil_keyb_init(void)
+/* initialize HIL */
+static int __devinit hil_keyb_init(void)
 {
         unsigned char c;
         unsigned int i, kbid;
         wait_queue_head_t hil_wait;
         int err;
 
-        if (hil_dev.dev) {
+        if (hil_dev.dev)
                 return -ENODEV; /* already initialized */
-        }
 
+        init_waitqueue_head(&hil_wait);
         spin_lock_init(&hil_dev.lock);
+
         hil_dev.dev = input_allocate_device();
         if (!hil_dev.dev)
                 return -ENOMEM;
 
-#if defined(CONFIG_HP300)
-        if (!MACH_IS_HP300) {
-                err = -ENODEV;
-                goto err1;
-        }
-        if (!hwreg_present((void *)(HILBASE + HIL_DATA))) {
-                printk(KERN_ERR "HIL: hardware register was not found\n");
-                err = -ENODEV;
-                goto err1;
-        }
-        if (!request_region(HILBASE + HIL_DATA, 2, "hil")) {
-                printk(KERN_ERR "HIL: IOPORT region already used\n");
-                err = -EIO;
-                goto err1;
-        }
-#endif
-
         err = request_irq(HIL_IRQ, hil_interrupt, 0, "hil", hil_dev.dev_id);
         if (err) {
                 printk(KERN_ERR "HIL: Can't get IRQ\n");
-                goto err2;
+                goto err1;
         }
 
         /* Turn on interrupts */
@@ -246,11 +229,9 @@ hil_keyb_init(void)
         hil_dev.valid = 0;      /* clear any pending data */
         hil_do(HIL_READKBDSADR, NULL, 0);
 
-        init_waitqueue_head(&hil_wait);
-        wait_event_interruptible_timeout(hil_wait, hil_dev.valid, 3*HZ);
-        if (!hil_dev.valid) {
+        wait_event_interruptible_timeout(hil_wait, hil_dev.valid, 3 * HZ);
+        if (!hil_dev.valid)
                 printk(KERN_WARNING "HIL: timed out, assuming no keyboard present\n");
-        }
 
         c = hil_dev.c;
         hil_dev.valid = 0;
@@ -268,7 +249,7 @@ hil_keyb_init(void)
 
         for (i = 0; i < HIL_KEYCODES_SET1_TBLSIZE; i++)
                 if (hphilkeyb_keycode[i] != KEY_RESERVED)
-                        set_bit(hphilkeyb_keycode[i], hil_dev.dev->keybit);
+                        __set_bit(hphilkeyb_keycode[i], hil_dev.dev->keybit);
 
         hil_dev.dev->evbit[0]   = BIT_MASK(EV_KEY) | BIT_MASK(EV_REP);
         hil_dev.dev->ledbit[0]  = BIT_MASK(LED_NUML) | BIT_MASK(LED_CAPSL) |
@@ -287,34 +268,45 @@ hil_keyb_init(void)
         err = input_register_device(hil_dev.dev);
         if (err) {
                 printk(KERN_ERR "HIL: Can't register device\n");
-                goto err3;
+                goto err2;
         }
+
         printk(KERN_INFO "input: %s, ID %d at 0x%08lx (irq %d) found and attached\n",
                hil_dev.dev->name, kbid, HILBASE, HIL_IRQ);
 
         return 0;
 
-err3:
+err2:
         hil_do(HIL_INTOFF, NULL, 0);
-        disable_irq(HIL_IRQ);
         free_irq(HIL_IRQ, hil_dev.dev_id);
-err2:
-#if defined(CONFIG_HP300)
-        release_region(HILBASE + HIL_DATA, 2);
 err1:
-#endif
         input_free_device(hil_dev.dev);
         hil_dev.dev = NULL;
         return err;
 }
 
+static void __devexit hil_keyb_exit(void)
+{
+        if (HIL_IRQ)
+                free_irq(HIL_IRQ, hil_dev.dev_id);
+
+        /* Turn off interrupts */
+        hil_do(HIL_INTOFF, NULL, 0);
+
+        input_unregister_device(hil_dev.dev);
+        hil_dev.dev = NULL;
+}
 
 #if defined(CONFIG_PARISC)
-static int __init
-hil_init_chip(struct parisc_device *dev)
+static int __devinit hil_probe_chip(struct parisc_device *dev)
 {
+        /* Only allow one HIL keyboard */
+        if (hil_dev.dev)
+                return -ENODEV;
+
         if (!dev->irq) {
-                printk(KERN_WARNING "HIL: IRQ not found for HIL bus at 0x%08lx\n", dev->hpa.start);
+                printk(KERN_WARNING "HIL: IRQ not found for HIL bus at 0x%p\n",
+                        (void *)dev->hpa.start);
                 return -ENODEV;
         }
 
@@ -327,51 +319,79 @@ hil_init_chip(struct parisc_device *dev)
         return hil_keyb_init();
 }
 
+static int __devexit hil_remove_chip(struct parisc_device *dev)
+{
+        hil_keyb_exit();
+
+        return 0;
+}
+
 static struct parisc_device_id hil_tbl[] = {
         { HPHW_FIO, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x00073 },
         { 0, }
 };
 
+#if 0
+/* Disabled to avoid conflicts with the HP SDC HIL drivers */
 MODULE_DEVICE_TABLE(parisc, hil_tbl);
+#endif
 
 static struct parisc_driver hil_driver = {
-        .name =         "hil",
-        .id_table =     hil_tbl,
-        .probe =        hil_init_chip,
+        .name           = "hil",
+        .id_table       = hil_tbl,
+        .probe          = hil_probe_chip,
+        .remove         = __devexit_p(hil_remove_chip),
 };
-#endif /* CONFIG_PARISC */
-
 
 static int __init hil_init(void)
 {
-#if defined(CONFIG_PARISC)
         return register_parisc_driver(&hil_driver);
-#else
-        return hil_keyb_init();
-#endif
 }
 
-
 static void __exit hil_exit(void)
 {
-        if (HIL_IRQ) {
-                disable_irq(HIL_IRQ);
-                free_irq(HIL_IRQ, hil_dev.dev_id);
+        unregister_parisc_driver(&hil_driver);
+}
+
+#else /* !CONFIG_PARISC */
+
+static int __init hil_init(void)
+{
+        int error;
+
+        /* Only allow one HIL keyboard */
+        if (hil_dev.dev)
+                return -EBUSY;
+
+        if (!MACH_IS_HP300)
+                return -ENODEV;
+
+        if (!hwreg_present((void *)(HILBASE + HIL_DATA))) {
+                printk(KERN_ERR "HIL: hardware register was not found\n");
+                return -ENODEV;
         }
 
-        /* Turn off interrupts */
-        hil_do(HIL_INTOFF, NULL, 0);
+        if (!request_region(HILBASE + HIL_DATA, 2, "hil")) {
+                printk(KERN_ERR "HIL: IOPORT region already used\n");
+                return -EIO;
+        }
 
-        input_unregister_device(hil_dev.dev);
+        error = hil_keyb_init();
+        if (error) {
+                release_region(HILBASE + HIL_DATA, 2);
+                return error;
+        }
 
-        hil_dev.dev = NULL;
+        return 0;
+}
 
-#if defined(CONFIG_PARISC)
-        unregister_parisc_driver(&hil_driver);
-#else
-        release_region(HILBASE+HIL_DATA, 2);
-#endif
+static void __exit hil_exit(void)
+{
+        hil_keyb_exit();
+        release_region(HILBASE + HIL_DATA, 2);
 }
 
+#endif /* CONFIG_PARISC */
+
 module_init(hil_init);
 module_exit(hil_exit);
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 67e5553f699a..203abac1e23e 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -227,4 +227,27 @@ config INPUT_PCF50633_PMU
          Say Y to include support for delivering  PMU events via  input
          layer on NXP PCF50633.
 
+config INPUT_GPIO_ROTARY_ENCODER
+        tristate "Rotary encoders connected to GPIO pins"
+        depends on GPIOLIB && GENERIC_GPIO
+        help
+          Say Y here to add support for rotary encoders connected to GPIO lines.
+          Check file:Documentation/incput/rotary_encoder.txt for more
+          information.
+
+          To compile this driver as a module, choose M here: the
+          module will be called rotary_encoder.
+
+config INPUT_RB532_BUTTON
+        tristate "Mikrotik Routerboard 532 button interface"
+        depends on MIKROTIK_RB532
+        depends on GPIOLIB && GENERIC_GPIO
+        select INPUT_POLLDEV
+        help
+          Say Y here if you want support for the S1 button built into
+          Mikrotik's Routerboard 532.
+
+          To compile this driver as a module, choose M here: the
+          module will be called rb532_button.
+
 endif
diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile
index bb62e6efacf3..eb3f407baedf 100644
--- a/drivers/input/misc/Makefile
+++ b/drivers/input/misc/Makefile
@@ -4,21 +4,23 @@
 
 # Each configuration option enables a list of files.
 
-obj-$(CONFIG_INPUT_SPARCSPKR)           += sparcspkr.o
-obj-$(CONFIG_INPUT_PCSPKR)              += pcspkr.o
-obj-$(CONFIG_INPUT_M68K_BEEP)           += m68kspkr.o
-obj-$(CONFIG_INPUT_IXP4XX_BEEPER)       += ixp4xx-beeper.o
-obj-$(CONFIG_INPUT_COBALT_BTNS)         += cobalt_btns.o
-obj-$(CONFIG_INPUT_WISTRON_BTNS)        += wistron_btns.o
-obj-$(CONFIG_INPUT_ATLAS_BTNS)          += atlas_btns.o
+obj-$(CONFIG_INPUT_APANEL)              += apanel.o
 obj-$(CONFIG_INPUT_ATI_REMOTE)          += ati_remote.o
 obj-$(CONFIG_INPUT_ATI_REMOTE2)         += ati_remote2.o
-obj-$(CONFIG_INPUT_KEYSPAN_REMOTE)      += keyspan_remote.o
-obj-$(CONFIG_INPUT_POWERMATE)           += powermate.o
-obj-$(CONFIG_INPUT_YEALINK)             += yealink.o
+obj-$(CONFIG_INPUT_ATLAS_BTNS)          += atlas_btns.o
 obj-$(CONFIG_INPUT_CM109)               += cm109.o
+obj-$(CONFIG_INPUT_COBALT_BTNS)         += cobalt_btns.o
 obj-$(CONFIG_HP_SDC_RTC)                += hp_sdc_rtc.o
-obj-$(CONFIG_INPUT_UINPUT)              += uinput.o
-obj-$(CONFIG_INPUT_APANEL)              += apanel.o
-obj-$(CONFIG_INPUT_SGI_BTNS)            += sgi_btns.o
+obj-$(CONFIG_INPUT_IXP4XX_BEEPER)       += ixp4xx-beeper.o
+obj-$(CONFIG_INPUT_KEYSPAN_REMOTE)      += keyspan_remote.o
+obj-$(CONFIG_INPUT_M68K_BEEP)           += m68kspkr.o
 obj-$(CONFIG_INPUT_PCF50633_PMU)        += pcf50633-input.o
+obj-$(CONFIG_INPUT_PCSPKR)              += pcspkr.o
+obj-$(CONFIG_INPUT_POWERMATE)           += powermate.o
+obj-$(CONFIG_INPUT_RB532_BUTTON)        += rb532_button.o
+obj-$(CONFIG_INPUT_GPIO_ROTARY_ENCODER) += rotary_encoder.o
+obj-$(CONFIG_INPUT_SGI_BTNS)            += sgi_btns.o
+obj-$(CONFIG_INPUT_SPARCSPKR)           += sparcspkr.o
+obj-$(CONFIG_INPUT_UINPUT)              += uinput.o
+obj-$(CONFIG_INPUT_WISTRON_BTNS)        += wistron_btns.o
+obj-$(CONFIG_INPUT_YEALINK)             += yealink.o
diff --git a/drivers/input/misc/ati_remote2.c b/drivers/input/misc/ati_remote2.c
index 3c9988dc0e9f..922c05141585 100644
--- a/drivers/input/misc/ati_remote2.c
+++ b/drivers/input/misc/ati_remote2.c
@@ -31,12 +31,73 @@ MODULE_LICENSE("GPL");
  * newly configured "channel".
  */
 
-static unsigned int channel_mask = 0xFFFF;
-module_param(channel_mask, uint, 0644);
+enum {
+        ATI_REMOTE2_MAX_CHANNEL_MASK = 0xFFFF,
+        ATI_REMOTE2_MAX_MODE_MASK = 0x1F,
+};
+
+static int ati_remote2_set_mask(const char *val,
+                                struct kernel_param *kp, unsigned int max)
+{
+        unsigned long mask;
+        int ret;
+
+        if (!val)
+                return -EINVAL;
+
+        ret = strict_strtoul(val, 0, &mask);
+        if (ret)
+                return ret;
+
+        if (mask & ~max)
+                return -EINVAL;
+
+        *(unsigned int *)kp->arg = mask;
+
+        return 0;
+}
+
+static int ati_remote2_set_channel_mask(const char *val,
+                                        struct kernel_param *kp)
+{
+        pr_debug("%s()\n", __func__);
+
+        return ati_remote2_set_mask(val, kp, ATI_REMOTE2_MAX_CHANNEL_MASK);
+}
+
+static int ati_remote2_get_channel_mask(char *buffer, struct kernel_param *kp)
+{
+        pr_debug("%s()\n", __func__);
+
+        return sprintf(buffer, "0x%04x", *(unsigned int *)kp->arg);
+}
+
+static int ati_remote2_set_mode_mask(const char *val, struct kernel_param *kp)
+{
+        pr_debug("%s()\n", __func__);
+
+        return ati_remote2_set_mask(val, kp, ATI_REMOTE2_MAX_MODE_MASK);
+}
+
+static int ati_remote2_get_mode_mask(char *buffer, struct kernel_param *kp)
+{
+        pr_debug("%s()\n", __func__);
+
+        return sprintf(buffer, "0x%02x", *(unsigned int *)kp->arg);
+}
+
+static unsigned int channel_mask = ATI_REMOTE2_MAX_CHANNEL_MASK;
+#define param_check_channel_mask(name, p) __param_check(name, p, unsigned int)
+#define param_set_channel_mask ati_remote2_set_channel_mask
+#define param_get_channel_mask ati_remote2_get_channel_mask
+module_param(channel_mask, channel_mask, 0644);
 MODULE_PARM_DESC(channel_mask, "Bitmask of channels to accept <15:Channel16>...<1:Channel2><0:Channel1>");
 
-static unsigned int mode_mask = 0x1F;
-module_param(mode_mask, uint, 0644);
+static unsigned int mode_mask = ATI_REMOTE2_MAX_MODE_MASK;
+#define param_check_mode_mask(name, p) __param_check(name, p, unsigned int)
+#define param_set_mode_mask ati_remote2_set_mode_mask
+#define param_get_mode_mask ati_remote2_get_mode_mask
+module_param(mode_mask, mode_mask, 0644);
 MODULE_PARM_DESC(mode_mask, "Bitmask of modes to accept <4:PC><3:AUX4><2:AUX3><1:AUX2><0:AUX1>");
 
 static struct usb_device_id ati_remote2_id_table[] = {
@@ -133,12 +194,18 @@ struct ati_remote2 {
         u16 keycode[ATI_REMOTE2_MODES][ARRAY_SIZE(ati_remote2_key_table)];
 
         unsigned int flags;
+
+        unsigned int channel_mask;
+        unsigned int mode_mask;
 };
 
 static int ati_remote2_probe(struct usb_interface *interface, const struct usb_device_id *id);
 static void ati_remote2_disconnect(struct usb_interface *interface);
 static int ati_remote2_suspend(struct usb_interface *interface, pm_message_t message);
 static int ati_remote2_resume(struct usb_interface *interface);
+static int ati_remote2_reset_resume(struct usb_interface *interface);
+static int ati_remote2_pre_reset(struct usb_interface *interface);
+static int ati_remote2_post_reset(struct usb_interface *interface);
 
 static struct usb_driver ati_remote2_driver = {
         .name       = "ati_remote2",
@@ -147,6 +214,9 @@ static struct usb_driver ati_remote2_driver = {
         .id_table   = ati_remote2_id_table,
         .suspend    = ati_remote2_suspend,
         .resume     = ati_remote2_resume,
+        .reset_resume = ati_remote2_reset_resume,
+        .pre_reset  = ati_remote2_pre_reset,
+        .post_reset = ati_remote2_post_reset,
         .supports_autosuspend = 1,
 };
 
@@ -238,7 +308,7 @@ static void ati_remote2_input_mouse(struct ati_remote2 *ar2)
 
         channel = data[0] >> 4;
 
-        if (!((1 << channel) & channel_mask))
+        if (!((1 << channel) & ar2->channel_mask))
                 return;
 
         mode = data[0] & 0x0F;
@@ -250,7 +320,7 @@ static void ati_remote2_input_mouse(struct ati_remote2 *ar2)
                 return;
         }
 
-        if (!((1 << mode) & mode_mask))
+        if (!((1 << mode) & ar2->mode_mask))
                 return;
 
         input_event(idev, EV_REL, REL_X, (s8) data[1]);
@@ -277,7 +347,7 @@ static void ati_remote2_input_key(struct ati_remote2 *ar2)
 
         channel = data[0] >> 4;
 
-        if (!((1 << channel) & channel_mask))
+        if (!((1 << channel) & ar2->channel_mask))
                 return;
 
         mode = data[0] & 0x0F;
@@ -305,7 +375,7 @@ static void ati_remote2_input_key(struct ati_remote2 *ar2)
                         ar2->mode = mode;
         }
 
-        if (!((1 << mode) & mode_mask))
+        if (!((1 << mode) & ar2->mode_mask))
                 return;
 
         index = ati_remote2_lookup(hw_code);
@@ -410,7 +480,7 @@ static int ati_remote2_getkeycode(struct input_dev *idev,
         int index, mode;
 
         mode = scancode >> 8;
-        if (mode > ATI_REMOTE2_PC || !((1 << mode) & mode_mask))
+        if (mode > ATI_REMOTE2_PC || !((1 << mode) & ar2->mode_mask))
                 return -EINVAL;
 
         index = ati_remote2_lookup(scancode & 0xFF);
@@ -427,7 +497,7 @@ static int ati_remote2_setkeycode(struct input_dev *idev, int scancode, int keyc
         int index, mode, old_keycode;
 
         mode = scancode >> 8;
-        if (mode > ATI_REMOTE2_PC || !((1 << mode) & mode_mask))
+        if (mode > ATI_REMOTE2_PC || !((1 << mode) & ar2->mode_mask))
                 return -EINVAL;
 
         index = ati_remote2_lookup(scancode & 0xFF);
@@ -550,7 +620,7 @@ static void ati_remote2_urb_cleanup(struct ati_remote2 *ar2)
         }
 }
 
-static int ati_remote2_setup(struct ati_remote2 *ar2)
+static int ati_remote2_setup(struct ati_remote2 *ar2, unsigned int ch_mask)
 {
         int r, i, channel;
 
@@ -565,8 +635,8 @@ static int ati_remote2_setup(struct ati_remote2 *ar2)
 
         channel = 0;
         for (i = 0; i < 16; i++) {
-                if ((1 << i) & channel_mask) {
-                        if (!(~(1 << i) & 0xFFFF & channel_mask))
+                if ((1 << i) & ch_mask) {
+                        if (!(~(1 << i) & ch_mask))
                                 channel = i + 1;
                         break;
                 }
@@ -585,6 +655,99 @@ static int ati_remote2_setup(struct ati_remote2 *ar2)
         return 0;
 }
 
+static ssize_t ati_remote2_show_channel_mask(struct device *dev,
+                                             struct device_attribute *attr,
+                                             char *buf)
+{
+        struct usb_device *udev = to_usb_device(dev);
+        struct usb_interface *intf = usb_ifnum_to_if(udev, 0);
+        struct ati_remote2 *ar2 = usb_get_intfdata(intf);
+
+        return sprintf(buf, "0x%04x\n", ar2->channel_mask);
+}
+
+static ssize_t ati_remote2_store_channel_mask(struct device *dev,
+                                              struct device_attribute *attr,
+                                              const char *buf, size_t count)
+{
+        struct usb_device *udev = to_usb_device(dev);
+        struct usb_interface *intf = usb_ifnum_to_if(udev, 0);
+        struct ati_remote2 *ar2 = usb_get_intfdata(intf);
+        unsigned long mask;
+        int r;
+
+        if (strict_strtoul(buf, 0, &mask))
+                return -EINVAL;
+
+        if (mask & ~ATI_REMOTE2_MAX_CHANNEL_MASK)
+                return -EINVAL;
+
+        r = usb_autopm_get_interface(ar2->intf[0]);
+        if (r) {
+                dev_err(&ar2->intf[0]->dev,
+                        "%s(): usb_autopm_get_interface() = %d\n", __func__, r);
+                return r;
+        }
+
+        mutex_lock(&ati_remote2_mutex);
+
+        if (mask != ar2->channel_mask && !ati_remote2_setup(ar2, mask))
+                ar2->channel_mask = mask;
+
+        mutex_unlock(&ati_remote2_mutex);
+
+        usb_autopm_put_interface(ar2->intf[0]);
+
+        return count;
+}
+
+static ssize_t ati_remote2_show_mode_mask(struct device *dev,
+                                          struct device_attribute *attr,
+                                          char *buf)
+{
+        struct usb_device *udev = to_usb_device(dev);
+        struct usb_interface *intf = usb_ifnum_to_if(udev, 0);
+        struct ati_remote2 *ar2 = usb_get_intfdata(intf);
+
+        return sprintf(buf, "0x%02x\n", ar2->mode_mask);
+}
+
+static ssize_t ati_remote2_store_mode_mask(struct device *dev,
+                                           struct device_attribute *attr,
+                                           const char *buf, size_t count)
+{
+        struct usb_device *udev = to_usb_device(dev);
+        struct usb_interface *intf = usb_ifnum_to_if(udev, 0);
+        struct ati_remote2 *ar2 = usb_get_intfdata(intf);
+        unsigned long mask;
+
+        if (strict_strtoul(buf, 0, &mask))
+                return -EINVAL;
+
+        if (mask & ~ATI_REMOTE2_MAX_MODE_MASK)
+                return -EINVAL;
+
+        ar2->mode_mask = mask;
+
+        return count;
+}
+
+static DEVICE_ATTR(channel_mask, 0644, ati_remote2_show_channel_mask,
+                   ati_remote2_store_channel_mask);
+
+static DEVICE_ATTR(mode_mask, 0644, ati_remote2_show_mode_mask,
+                   ati_remote2_store_mode_mask);
+
+static struct attribute *ati_remote2_attrs[] = {
+        &dev_attr_channel_mask.attr,
+        &dev_attr_mode_mask.attr,
+        NULL,
+};
+
+static struct attribute_group ati_remote2_attr_group = {
+        .attrs = ati_remote2_attrs,
+};
+
 static int ati_remote2_probe(struct usb_interface *interface, const struct usb_device_id *id)
 {
         struct usb_device *udev = interface_to_usbdev(interface);
@@ -615,7 +778,10 @@ static int ati_remote2_probe(struct usb_interface *interface, const struct usb_d
         if (r)
                 goto fail2;
 
-        r = ati_remote2_setup(ar2);
+        ar2->channel_mask = channel_mask;
+        ar2->mode_mask = mode_mask;
+
+        r = ati_remote2_setup(ar2, ar2->channel_mask);
         if (r)
                 goto fail2;
 
@@ -624,19 +790,24 @@ static int ati_remote2_probe(struct usb_interface *interface, const struct usb_d
 
         strlcat(ar2->name, "ATI Remote Wonder II", sizeof(ar2->name));
 
-        r = ati_remote2_input_init(ar2);
+        r = sysfs_create_group(&udev->dev.kobj, &ati_remote2_attr_group);
         if (r)
                 goto fail2;
 
+        r = ati_remote2_input_init(ar2);
+        if (r)
+                goto fail3;
+
         usb_set_intfdata(interface, ar2);
 
         interface->needs_remote_wakeup = 1;
 
         return 0;
 
+ fail3:
+        sysfs_remove_group(&udev->dev.kobj, &ati_remote2_attr_group);
  fail2:
         ati_remote2_urb_cleanup(ar2);
-
         usb_driver_release_interface(&ati_remote2_driver, ar2->intf[1]);
  fail1:
         kfree(ar2);
@@ -657,6 +828,8 @@ static void ati_remote2_disconnect(struct usb_interface *interface)
 
         input_unregister_device(ar2->idev);
 
+        sysfs_remove_group(&ar2->udev->dev.kobj, &ati_remote2_attr_group);
+
         ati_remote2_urb_cleanup(ar2);
 
         usb_driver_release_interface(&ati_remote2_driver, ar2->intf[1]);
@@ -715,6 +888,78 @@ static int ati_remote2_resume(struct usb_interface *interface)
         return r;
 }
 
+static int ati_remote2_reset_resume(struct usb_interface *interface)
+{
+        struct ati_remote2 *ar2;
+        struct usb_host_interface *alt = interface->cur_altsetting;
+        int r = 0;
+
+        if (alt->desc.bInterfaceNumber)
+                return 0;
+
+        ar2 = usb_get_intfdata(interface);
+
+        dev_dbg(&ar2->intf[0]->dev, "%s()\n", __func__);
+
+        mutex_lock(&ati_remote2_mutex);
+
+        r = ati_remote2_setup(ar2, ar2->channel_mask);
+        if (r)
+                goto out;
+
+        if (ar2->flags & ATI_REMOTE2_OPENED)
+                r = ati_remote2_submit_urbs(ar2);
+
+        if (!r)
+                ar2->flags &= ~ATI_REMOTE2_SUSPENDED;
+
+ out:
+        mutex_unlock(&ati_remote2_mutex);
+
+        return r;
+}
+
+static int ati_remote2_pre_reset(struct usb_interface *interface)
+{
+        struct ati_remote2 *ar2;
+        struct usb_host_interface *alt = interface->cur_altsetting;
+
+        if (alt->desc.bInterfaceNumber)
+                return 0;
+
+        ar2 = usb_get_intfdata(interface);
+
+        dev_dbg(&ar2->intf[0]->dev, "%s()\n", __func__);
+
+        mutex_lock(&ati_remote2_mutex);
+
+        if (ar2->flags == ATI_REMOTE2_OPENED)
+                ati_remote2_kill_urbs(ar2);
+
+        return 0;
+}
+
+static int ati_remote2_post_reset(struct usb_interface *interface)
+{
+        struct ati_remote2 *ar2;
+        struct usb_host_interface *alt = interface->cur_altsetting;
+        int r = 0;
+
+        if (alt->desc.bInterfaceNumber)
+                return 0;
+
+        ar2 = usb_get_intfdata(interface);
+
+        dev_dbg(&ar2->intf[0]->dev, "%s()\n", __func__);
+
+        if (ar2->flags == ATI_REMOTE2_OPENED)
+                r = ati_remote2_submit_urbs(ar2);
+
+        mutex_unlock(&ati_remote2_mutex);
+
+        return r;
+}
+
 static int __init ati_remote2_init(void)
 {
         int r;
diff --git a/drivers/input/misc/rb532_button.c b/drivers/input/misc/rb532_button.c
new file mode 100644
index 000000000000..e2c7f622a0b5
--- /dev/null
+++ b/drivers/input/misc/rb532_button.c
@@ -0,0 +1,120 @@
+/*
+ * Support for the S1 button on Routerboard 532
+ *
+ * Copyright (C) 2009  Phil Sutter <n0-1@freewrt.org>
+ */
+
+#include <linux/input-polldev.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+
+#include <asm/mach-rc32434/gpio.h>
+#include <asm/mach-rc32434/rb.h>
+
+#define DRV_NAME "rb532-button"
+
+#define RB532_BTN_RATE 100 /* msec */
+#define RB532_BTN_KSYM BTN_0
+
+/* The S1 button state is provided by GPIO pin 1. But as this
+ * pin is also used for uart input as alternate function, the
+ * operational modes must be switched first:
+ * 1) disable uart using set_latch_u5()
+ * 2) turn off alternate function implicitly through
+ *    gpio_direction_input()
+ * 3) read the GPIO's current value
+ * 4) undo step 2 by enabling alternate function (in this
+ *    mode the GPIO direction is fixed, so no change needed)
+ * 5) turn on uart again
+ * The GPIO value occurs to be inverted, so pin high means
+ * button is not pressed.
+ */
+static bool rb532_button_pressed(void)
+{
+        int val;
+
+        set_latch_u5(0, LO_FOFF);
+        gpio_direction_input(GPIO_BTN_S1);
+
+        val = gpio_get_value(GPIO_BTN_S1);
+
+        rb532_gpio_set_func(GPIO_BTN_S1);
+        set_latch_u5(LO_FOFF, 0);
+
+        return !val;
+}
+
+static void rb532_button_poll(struct input_polled_dev *poll_dev)
+{
+        input_report_key(poll_dev->input, RB532_BTN_KSYM,
+                         rb532_button_pressed());
+        input_sync(poll_dev->input);
+}
+
+static int __devinit rb532_button_probe(struct platform_device *pdev)
+{
+        struct input_polled_dev *poll_dev;
+        int error;
+
+        poll_dev = input_allocate_polled_device();
+        if (!poll_dev)
+                return -ENOMEM;
+
+        poll_dev->poll = rb532_button_poll;
+        poll_dev->poll_interval = RB532_BTN_RATE;
+
+        poll_dev->input->name = "rb532 button";
+        poll_dev->input->phys = "rb532/button0";
+        poll_dev->input->id.bustype = BUS_HOST;
+        poll_dev->input->dev.parent = &pdev->dev;
+
+        dev_set_drvdata(&pdev->dev, poll_dev);
+
+        input_set_capability(poll_dev->input, EV_KEY, RB532_BTN_KSYM);
+
+        error = input_register_polled_device(poll_dev);
+        if (error) {
+                input_free_polled_device(poll_dev);
+                return error;
+        }
+
+        return 0;
+}
+
+static int __devexit rb532_button_remove(struct platform_device *pdev)
+{
+        struct input_polled_dev *poll_dev = dev_get_drvdata(&pdev->dev);
+
+        input_unregister_polled_device(poll_dev);
+        input_free_polled_device(poll_dev);
+        dev_set_drvdata(&pdev->dev, NULL);
+
+        return 0;
+}
+
+static struct platform_driver rb532_button_driver = {
+        .probe = rb532_button_probe,
+        .remove = __devexit_p(rb532_button_remove),
+        .driver = {
+                .name = DRV_NAME,
+                .owner = THIS_MODULE,
+        },
+};
+
+static int __init rb532_button_init(void)
+{
+        return platform_driver_register(&rb532_button_driver);
+}
+
+static void __exit rb532_button_exit(void)
+{
+        platform_driver_unregister(&rb532_button_driver);
+}
+
+module_init(rb532_button_init);
+module_exit(rb532_button_exit);
+
+MODULE_AUTHOR("Phil Sutter <n0-1@freewrt.org>");
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Support for S1 button on Routerboard 532");
+MODULE_ALIAS("platform:" DRV_NAME);
diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c
new file mode 100644
index 000000000000..5bb3ab51b8c6
--- /dev/null
+++ b/drivers/input/misc/rotary_encoder.c
@@ -0,0 +1,221 @@
+/*
+ * rotary_encoder.c
+ *
+ * (c) 2009 Daniel Mack <daniel@caiaq.de>
+ *
+ * state machine code inspired by code from Tim Ruetz
+ *
+ * A generic driver for rotary encoders connected to GPIO lines.
+ * See file:Documentation/input/rotary_encoder.txt for more information
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/interrupt.h>
+#include <linux/input.h>
+#include <linux/device.h>
+#include <linux/platform_device.h>
+#include <linux/gpio.h>
+#include <linux/rotary_encoder.h>
+
+#define DRV_NAME "rotary-encoder"
+
+struct rotary_encoder {
+        unsigned int irq_a;
+        unsigned int irq_b;
+        unsigned int pos;
+        unsigned int armed;
+        unsigned int dir;
+        struct input_dev *input;
+        struct rotary_encoder_platform_data *pdata;
+};
+
+static irqreturn_t rotary_encoder_irq(int irq, void *dev_id)
+{
+        struct rotary_encoder *encoder = dev_id;
+        struct rotary_encoder_platform_data *pdata = encoder->pdata;
+        int a = !!gpio_get_value(pdata->gpio_a);
+        int b = !!gpio_get_value(pdata->gpio_b);
+        int state;
+
+        a ^= pdata->inverted_a;
+        b ^= pdata->inverted_b;
+        state = (a << 1) | b;
+
+        switch (state) {
+
+        case 0x0:
+                if (!encoder->armed)
+                        break;
+
+                if (encoder->dir) {
+                        /* turning counter-clockwise */
+                        encoder->pos += pdata->steps;
+                        encoder->pos--;
+                        encoder->pos %= pdata->steps;
+                } else {
+                        /* turning clockwise */
+                        encoder->pos++;
+                        encoder->pos %= pdata->steps;
+                }
+
+                input_report_abs(encoder->input, pdata->axis, encoder->pos);
+                input_sync(encoder->input);
+
+                encoder->armed = 0;
+                break;
+
+        case 0x1:
+        case 0x2:
+                if (encoder->armed)
+                        encoder->dir = state - 1;
+                break;
+
+        case 0x3:
+                encoder->armed = 1;
+                break;
+        }
+
+        return IRQ_HANDLED;
+}
+
+static int __devinit rotary_encoder_probe(struct platform_device *pdev)
+{
+        struct rotary_encoder_platform_data *pdata = pdev->dev.platform_data;
+        struct rotary_encoder *encoder;
+        struct input_dev *input;
+        int err;
+
+        if (!pdata || !pdata->steps) {
+                dev_err(&pdev->dev, "invalid platform data\n");
+                return -ENOENT;
+        }
+
+        encoder = kzalloc(sizeof(struct rotary_encoder), GFP_KERNEL);
+        input = input_allocate_device();
+        if (!encoder || !input) {
+                dev_err(&pdev->dev, "failed to allocate memory for device\n");
+                err = -ENOMEM;
+                goto exit_free_mem;
+        }
+
+        encoder->input = input;
+        encoder->pdata = pdata;
+        encoder->irq_a = gpio_to_irq(pdata->gpio_a);
+        encoder->irq_b = gpio_to_irq(pdata->gpio_b);
+
+        /* create and register the input driver */
+        input->name = pdev->name;
+        input->id.bustype = BUS_HOST;
+        input->dev.parent = &pdev->dev;
+        input->evbit[0] = BIT_MASK(EV_ABS);
+        input_set_abs_params(encoder->input,
+                             pdata->axis, 0, pdata->steps, 0, 1);
+
+        err = input_register_device(input);
+        if (err) {
+                dev_err(&pdev->dev, "failed to register input device\n");
+                goto exit_free_mem;
+        }
+
+        /* request the GPIOs */
+        err = gpio_request(pdata->gpio_a, DRV_NAME);
+        if (err) {
+                dev_err(&pdev->dev, "unable to request GPIO %d\n",
+                        pdata->gpio_a);
+                goto exit_unregister_input;
+        }
+
+        err = gpio_request(pdata->gpio_b, DRV_NAME);
+        if (err) {
+                dev_err(&pdev->dev, "unable to request GPIO %d\n",
+                        pdata->gpio_b);
+                goto exit_free_gpio_a;
+        }
+
+        /* request the IRQs */
+        err = request_irq(encoder->irq_a, &rotary_encoder_irq,
+                          IORESOURCE_IRQ_HIGHEDGE | IORESOURCE_IRQ_LOWEDGE,
+                          DRV_NAME, encoder);
+        if (err) {
+                dev_err(&pdev->dev, "unable to request IRQ %d\n",
+                        encoder->irq_a);
+                goto exit_free_gpio_b;
+        }
+
+        err = request_irq(encoder->irq_b, &rotary_encoder_irq,
+                          IORESOURCE_IRQ_HIGHEDGE | IORESOURCE_IRQ_LOWEDGE,
+                          DRV_NAME, encoder);
+        if (err) {
+                dev_err(&pdev->dev, "unable to request IRQ %d\n",
+                        encoder->irq_b);
+                goto exit_free_irq_a;
+        }
+
+        platform_set_drvdata(pdev, encoder);
+
+        return 0;
+
+exit_free_irq_a:
+        free_irq(encoder->irq_a, encoder);
+exit_free_gpio_b:
+        gpio_free(pdata->gpio_b);
+exit_free_gpio_a:
+        gpio_free(pdata->gpio_a);
+exit_unregister_input:
+        input_unregister_device(input);
+        input = NULL; /* so we don't try to free it */
+exit_free_mem:
+        input_free_device(input);
+        kfree(encoder);
+        return err;
+}
+
+static int __devexit rotary_encoder_remove(struct platform_device *pdev)
+{
+        struct rotary_encoder *encoder = platform_get_drvdata(pdev);
+        struct rotary_encoder_platform_data *pdata = pdev->dev.platform_data;
+
+        free_irq(encoder->irq_a, encoder);
+        free_irq(encoder->irq_b, encoder);
+        gpio_free(pdata->gpio_a);
+        gpio_free(pdata->gpio_b);
+        input_unregister_device(encoder->input);
+        platform_set_drvdata(pdev, NULL);
+        kfree(encoder);
+
+        return 0;
+}
+
+static struct platform_driver rotary_encoder_driver = {
+        .probe          = rotary_encoder_probe,
+        .remove         = __devexit_p(rotary_encoder_remove),
+        .driver         = {
+                .name   = DRV_NAME,
+                .owner  = THIS_MODULE,
+        }
+};
+
+static int __init rotary_encoder_init(void)
+{
+        return platform_driver_register(&rotary_encoder_driver);
+}
+
+static void __exit rotary_encoder_exit(void)
+{
+        platform_driver_unregister(&rotary_encoder_driver);
+}
+
+module_init(rotary_encoder_init);
+module_exit(rotary_encoder_exit);
+
+MODULE_ALIAS("platform:" DRV_NAME);
+MODULE_DESCRIPTION("GPIO rotary encoder driver");
+MODULE_AUTHOR("Daniel Mack <daniel@caiaq.de>");
+MODULE_LICENSE("GPL v2");
+
diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
index 4f38e6f7dfdd..c66cc3d08c2f 100644
--- a/drivers/input/mouse/Kconfig
+++ b/drivers/input/mouse/Kconfig
@@ -292,4 +292,15 @@ config MOUSE_PXA930_TRKBALL
         help
           Say Y here to support PXA930 Trackball mouse.
 
+config MOUSE_MAPLE
+        tristate "Maple mouse (for the Dreamcast)"
+        depends on MAPLE
+        help
+          This driver supports the Maple mouse on the SEGA Dreamcast.
+
+          Most Dreamcast users, who have a mouse, will say Y here.
+
+          To compile this driver as a module choose M here: the module will be
+          called maplemouse.
+
 endif
diff --git a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile
index 8c8a1f236e28..472189468d67 100644
--- a/drivers/input/mouse/Makefile
+++ b/drivers/input/mouse/Makefile
@@ -6,18 +6,19 @@
 
 obj-$(CONFIG_MOUSE_AMIGA)               += amimouse.o
 obj-$(CONFIG_MOUSE_APPLETOUCH)          += appletouch.o
-obj-$(CONFIG_MOUSE_BCM5974)             += bcm5974.o
 obj-$(CONFIG_MOUSE_ATARI)               += atarimouse.o
-obj-$(CONFIG_MOUSE_RISCPC)              += rpcmouse.o
+obj-$(CONFIG_MOUSE_BCM5974)             += bcm5974.o
+obj-$(CONFIG_MOUSE_GPIO)                += gpio_mouse.o
+obj-$(CONFIG_MOUSE_HIL)                 += hil_ptr.o
 obj-$(CONFIG_MOUSE_INPORT)              += inport.o
 obj-$(CONFIG_MOUSE_LOGIBM)              += logibm.o
+obj-$(CONFIG_MOUSE_MAPLE)               += maplemouse.o
 obj-$(CONFIG_MOUSE_PC110PAD)            += pc110pad.o
 obj-$(CONFIG_MOUSE_PS2)                 += psmouse.o
 obj-$(CONFIG_MOUSE_PXA930_TRKBALL)      += pxa930_trkball.o
+obj-$(CONFIG_MOUSE_RISCPC)              += rpcmouse.o
 obj-$(CONFIG_MOUSE_SERIAL)              += sermouse.o
-obj-$(CONFIG_MOUSE_HIL)                 += hil_ptr.o
 obj-$(CONFIG_MOUSE_VSXXXAA)             += vsxxxaa.o
-obj-$(CONFIG_MOUSE_GPIO)                += gpio_mouse.o
 
 psmouse-objs := psmouse-base.o synaptics.o
 
diff --git a/drivers/input/mouse/hgpk.c b/drivers/input/mouse/hgpk.c
index 55cd0fa68339..a1ad2f1a7bb3 100644
--- a/drivers/input/mouse/hgpk.c
+++ b/drivers/input/mouse/hgpk.c
@@ -472,7 +472,7 @@ static enum hgpk_model_t hgpk_get_model(struct psmouse *psmouse)
                 return -EIO;
         }
 
-        hgpk_dbg(psmouse, "ID: %02x %02x %02x", param[0], param[1], param[2]);
+        hgpk_dbg(psmouse, "ID: %02x %02x %02x\n", param[0], param[1], param[2]);
 
         /* HGPK signature: 0x67, 0x00, 0x<model> */
         if (param[0] != 0x67 || param[1] != 0x00)
diff --git a/drivers/input/mouse/maplemouse.c b/drivers/input/mouse/maplemouse.c
new file mode 100644
index 000000000000..d196abfb68bc
--- /dev/null
+++ b/drivers/input/mouse/maplemouse.c
@@ -0,0 +1,147 @@
+/*
+ *      SEGA Dreamcast mouse driver
+ *      Based on drivers/usb/usbmouse.c
+ *
+ *      Copyright Yaegashi Takeshi, 2001
+ *      Adrian McMenamin, 2008
+ */
+
+#include <linux/kernel.h>
+#include <linux/slab.h>
+#include <linux/input.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/timer.h>
+#include <linux/maple.h>
+
+MODULE_AUTHOR("Adrian McMenamin <adrian@mcmen.demon.co.uk>");
+MODULE_DESCRIPTION("SEGA Dreamcast mouse driver");
+MODULE_LICENSE("GPL");
+
+struct dc_mouse {
+        struct input_dev *dev;
+        struct maple_device *mdev;
+};
+
+static void dc_mouse_callback(struct mapleq *mq)
+{
+        int buttons, relx, rely, relz;
+        struct maple_device *mapledev = mq->dev;
+        struct dc_mouse *mse = maple_get_drvdata(mapledev);
+        struct input_dev *dev = mse->dev;
+        unsigned char *res = mq->recvbuf;
+
+        buttons = ~res[8];
+        relx = *(unsigned short *)(res + 12) - 512;
+        rely = *(unsigned short *)(res + 14) - 512;
+        relz = *(unsigned short *)(res + 16) - 512;
+
+        input_report_key(dev, BTN_LEFT,   buttons & 4);
+        input_report_key(dev, BTN_MIDDLE, buttons & 9);
+        input_report_key(dev, BTN_RIGHT,  buttons & 2);
+        input_report_rel(dev, REL_X,      relx);
+        input_report_rel(dev, REL_Y,      rely);
+        input_report_rel(dev, REL_WHEEL,  relz);
+        input_sync(dev);
+}
+
+static int dc_mouse_open(struct input_dev *dev)
+{
+        struct dc_mouse *mse = dev->dev.platform_data;
+
+        maple_getcond_callback(mse->mdev, dc_mouse_callback, HZ/50,
+                MAPLE_FUNC_MOUSE);
+
+        return 0;
+}
+
+static void dc_mouse_close(struct input_dev *dev)
+{
+        struct dc_mouse *mse = dev->dev.platform_data;
+
+        maple_getcond_callback(mse->mdev, dc_mouse_callback, 0,
+                MAPLE_FUNC_MOUSE);
+}
+
+
+static int __devinit probe_maple_mouse(struct device *dev)
+{
+        struct maple_device *mdev = to_maple_dev(dev);
+        struct maple_driver *mdrv = to_maple_driver(dev->driver);
+        struct input_dev *input_dev;
+        struct dc_mouse *mse;
+        int error;
+
+        mse = kzalloc(sizeof(struct dc_mouse), GFP_KERNEL);
+        input_dev = input_allocate_device();
+
+        if (!mse || !input_dev) {
+                error = -ENOMEM;
+                goto fail;
+        }
+
+        mse->dev = input_dev;
+        mse->mdev = mdev;
+
+        input_set_drvdata(input_dev, mse);
+        input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_REL);
+        input_dev->keybit[BIT_WORD(BTN_MOUSE)] = BIT_MASK(BTN_LEFT) |
+                BIT_MASK(BTN_RIGHT) | BIT_MASK(BTN_MIDDLE);
+        input_dev->relbit[0] = BIT_MASK(REL_X) | BIT_MASK(REL_Y) |
+                BIT_MASK(REL_WHEEL);
+        input_dev->name = mdev->product_name;
+        input_dev->id.bustype = BUS_HOST;
+        input_dev->open = dc_mouse_open;
+        input_dev->close = dc_mouse_close;
+
+        mdev->driver = mdrv;
+        maple_set_drvdata(mdev, mse);
+
+        error = input_register_device(input_dev);
+        if (error)
+                goto fail;
+
+        return 0;
+
+fail:
+        input_free_device(input_dev);
+        maple_set_drvdata(mdev, NULL);
+        kfree(mse);
+        mdev->driver = NULL;
+        return error;
+}
+
+static int __devexit remove_maple_mouse(struct device *dev)
+{
+        struct maple_device *mdev = to_maple_dev(dev);
+        struct dc_mouse *mse = maple_get_drvdata(mdev);
+
+        mdev->callback = NULL;
+        input_unregister_device(mse->dev);
+        maple_set_drvdata(mdev, NULL);
+        kfree(mse);
+
+        return 0;
+}
+
+static struct maple_driver dc_mouse_driver = {
+        .function =     MAPLE_FUNC_MOUSE,
+        .drv = {
+                .name = "Dreamcast_mouse",
+                .probe = probe_maple_mouse,
+                .remove = __devexit_p(remove_maple_mouse),
+        },
+};
+
+static int __init dc_mouse_init(void)
+{
+        return maple_driver_register(&dc_mouse_driver);
+}
+
+static void __exit dc_mouse_exit(void)
+{
+        maple_driver_unregister(&dc_mouse_driver);
+}
+
+module_init(dc_mouse_init);
+module_exit(dc_mouse_exit);
diff --git a/drivers/input/mouse/pc110pad.c b/drivers/input/mouse/pc110pad.c
index fd09c8df81f2..f63995f854ff 100644
--- a/drivers/input/mouse/pc110pad.c
+++ b/drivers/input/mouse/pc110pad.c
@@ -111,11 +111,8 @@ static int __init pc110pad_init(void)
         struct pci_dev *dev;
         int err;
 
-        dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, NULL);
-        if (dev) {
-                pci_dev_put(dev);
+        if (!no_pci_devices())
                 return -ENODEV;
-        }
 
         if (!request_region(pc110pad_io, 4, "pc110pad")) {
                 printk(KERN_ERR "pc110pad: I/O area %#x-%#x in use.\n",
diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index 6fa2deff7446..83ed2d56b924 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -151,6 +151,14 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = {
                         DMI_MATCH(DMI_PRODUCT_VERSION, "01"),
                 },
         },
+        {
+                .ident = "HP DV9700",
+                .matches = {
+                        DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+                        DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv9700"),
+                        DMI_MATCH(DMI_PRODUCT_VERSION, "Rev 1"),
+                },
+        },
         { }
 };
 
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index bb6486a8c070..b01fd61dadcc 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -29,6 +29,51 @@ config TOUCHSCREEN_ADS7846
           To compile this driver as a module, choose M here: the
           module will be called ads7846.
 
+config TOUCHSCREEN_AD7877
+        tristate "AD7877 based touchscreens"
+        depends on SPI_MASTER
+        help
+          Say Y here if you have a touchscreen interface using the
+          AD7877 controller, and your board-specific initialization
+          code includes that in its table of SPI devices.
+
+          If unsure, say N (but it's safe to say "Y").
+
+          To compile this driver as a module, choose M here: the
+          module will be called ad7877.
+
+config TOUCHSCREEN_AD7879_I2C
+        tristate "AD7879 based touchscreens: AD7879-1 I2C Interface"
+        depends on I2C
+        select TOUCHSCREEN_AD7879
+        help
+          Say Y here if you have a touchscreen interface using the
+          AD7879-1 controller, and your board-specific initialization
+          code includes that in its table of I2C devices.
+
+          If unsure, say N (but it's safe to say "Y").
+
+          To compile this driver as a module, choose M here: the
+          module will be called ad7879.
+
+config TOUCHSCREEN_AD7879_SPI
+        tristate "AD7879 based touchscreens: AD7879 SPI Interface"
+        depends on SPI_MASTER && TOUCHSCREEN_AD7879_I2C = n
+        select TOUCHSCREEN_AD7879
+        help
+          Say Y here if you have a touchscreen interface using the
+          AD7879 controller, and your board-specific initialization
+          code includes that in its table of SPI devices.
+
+          If unsure, say N (but it's safe to say "Y").
+
+          To compile this driver as a module, choose M here: the
+          module will be called ad7879.
+
+config TOUCHSCREEN_AD7879
+        tristate
+        default n
+
 config TOUCHSCREEN_BITSY
         tristate "Compaq iPAQ H3600 (Bitsy) touchscreen"
         depends on SA1100_BITSY
@@ -308,6 +353,19 @@ config TOUCHSCREEN_WM97XX_MAINSTONE
           To compile this driver as a module, choose M here: the
           module will be called mainstone-wm97xx.
 
+config TOUCHSCREEN_WM97XX_ZYLONITE
+        tristate "Zylonite accelerated touch"
+        depends on TOUCHSCREEN_WM97XX && MACH_ZYLONITE
+        select TOUCHSCREEN_WM9713
+        help
+          Say Y here for support for streaming mode with the touchscreen
+          on Zylonite systems.
+
+          If unsure, say N.
+
+          To compile this driver as a module, choose M here: the
+          module will be called zylonite-wm97xx.
+
 config TOUCHSCREEN_USB_COMPOSITE
         tristate "USB Touchscreen Driver"
         depends on USB_ARCH_HAS_HCD
diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile
index d3375aff46fe..6700f7b9d165 100644
--- a/drivers/input/touchscreen/Makefile
+++ b/drivers/input/touchscreen/Makefile
@@ -6,6 +6,8 @@
 
 wm97xx-ts-y := wm97xx-core.o
 
+obj-$(CONFIG_TOUCHSCREEN_AD7877)        += ad7877.o
+obj-$(CONFIG_TOUCHSCREEN_AD7879)        += ad7879.o
 obj-$(CONFIG_TOUCHSCREEN_ADS7846)       += ads7846.o
 obj-$(CONFIG_TOUCHSCREEN_ATMEL_TSADCC)  += atmel_tsadcc.o
 obj-$(CONFIG_TOUCHSCREEN_BITSY)         += h3600_ts_input.o
@@ -34,3 +36,4 @@ wm97xx-ts-$(CONFIG_TOUCHSCREEN_WM9705)	+= wm9705.o
 wm97xx-ts-$(CONFIG_TOUCHSCREEN_WM9712)  += wm9712.o
 wm97xx-ts-$(CONFIG_TOUCHSCREEN_WM9713)  += wm9713.o
 obj-$(CONFIG_TOUCHSCREEN_WM97XX_MAINSTONE)      += mainstone-wm97xx.o
+obj-$(CONFIG_TOUCHSCREEN_WM97XX_ZYLONITE)       += zylonite-wm97xx.o
diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
new file mode 100644
index 000000000000..e4728a28f492
--- /dev/null
+++ b/drivers/input/touchscreen/ad7877.c
@@ -0,0 +1,844 @@
+/*
+ * Copyright (C) 2006-2008 Michael Hennerich, Analog Devices Inc.
+ *
+ * Description: AD7877 based touchscreen, sensor (ADCs), DAC and GPIO driver
+ * Based on:    ads7846.c
+ *
+ * Bugs:        Enter bugs at http://blackfin.uclinux.org/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see the file COPYING, or write
+ * to the Free Software Foundation, Inc.,
+ * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ * History:
+ * Copyright (c) 2005 David Brownell
+ * Copyright (c) 2006 Nokia Corporation
+ * Various changes: Imre Deak <imre.deak@nokia.com>
+ *
+ * Using code from:
+ *  - corgi_ts.c
+ *      Copyright (C) 2004-2005 Richard Purdie
+ *  - omap_ts.[hc], ads7846.h, ts_osk.c
+ *      Copyright (C) 2002 MontaVista Software
+ *      Copyright (C) 2004 Texas Instruments
+ *      Copyright (C) 2005 Dirk Behme
+ */
+
+
+#include <linux/device.h>
+#include <linux/init.h>
+#include <linux/delay.h>
+#include <linux/input.h>
+#include <linux/interrupt.h>
+#include <linux/slab.h>
+#include <linux/spi/spi.h>
+#include <linux/spi/ad7877.h>
+#include <asm/irq.h>
+
+#define TS_PEN_UP_TIMEOUT       msecs_to_jiffies(50)
+
+#define MAX_SPI_FREQ_HZ                 20000000
+#define MAX_12BIT                       ((1<<12)-1)
+
+#define AD7877_REG_ZEROS                        0
+#define AD7877_REG_CTRL1                        1
+#define AD7877_REG_CTRL2                        2
+#define AD7877_REG_ALERT                        3
+#define AD7877_REG_AUX1HIGH                     4
+#define AD7877_REG_AUX1LOW                      5
+#define AD7877_REG_BAT1HIGH                     6
+#define AD7877_REG_BAT1LOW                      7
+#define AD7877_REG_BAT2HIGH                     8
+#define AD7877_REG_BAT2LOW                      9
+#define AD7877_REG_TEMP1HIGH                    10
+#define AD7877_REG_TEMP1LOW                     11
+#define AD7877_REG_SEQ0                         12
+#define AD7877_REG_SEQ1                         13
+#define AD7877_REG_DAC                          14
+#define AD7877_REG_NONE1                        15
+#define AD7877_REG_EXTWRITE                     15
+#define AD7877_REG_XPLUS                        16
+#define AD7877_REG_YPLUS                        17
+#define AD7877_REG_Z2                           18
+#define AD7877_REG_aux1                         19
+#define AD7877_REG_aux2                         20
+#define AD7877_REG_aux3                         21
+#define AD7877_REG_bat1                         22
+#define AD7877_REG_bat2                         23
+#define AD7877_REG_temp1                        24
+#define AD7877_REG_temp2                        25
+#define AD7877_REG_Z1                           26
+#define AD7877_REG_GPIOCTRL1                    27
+#define AD7877_REG_GPIOCTRL2                    28
+#define AD7877_REG_GPIODATA                     29
+#define AD7877_REG_NONE2                        30
+#define AD7877_REG_NONE3                        31
+
+#define AD7877_SEQ_YPLUS_BIT                    (1<<11)
+#define AD7877_SEQ_XPLUS_BIT                    (1<<10)
+#define AD7877_SEQ_Z2_BIT                       (1<<9)
+#define AD7877_SEQ_AUX1_BIT                     (1<<8)
+#define AD7877_SEQ_AUX2_BIT                     (1<<7)
+#define AD7877_SEQ_AUX3_BIT                     (1<<6)
+#define AD7877_SEQ_BAT1_BIT                     (1<<5)
+#define AD7877_SEQ_BAT2_BIT                     (1<<4)
+#define AD7877_SEQ_TEMP1_BIT                    (1<<3)
+#define AD7877_SEQ_TEMP2_BIT                    (1<<2)
+#define AD7877_SEQ_Z1_BIT                       (1<<1)
+
+enum {
+        AD7877_SEQ_YPOS  = 0,
+        AD7877_SEQ_XPOS  = 1,
+        AD7877_SEQ_Z2    = 2,
+        AD7877_SEQ_AUX1  = 3,
+        AD7877_SEQ_AUX2  = 4,
+        AD7877_SEQ_AUX3  = 5,
+        AD7877_SEQ_BAT1  = 6,
+        AD7877_SEQ_BAT2  = 7,
+        AD7877_SEQ_TEMP1 = 8,
+        AD7877_SEQ_TEMP2 = 9,
+        AD7877_SEQ_Z1    = 10,
+        AD7877_NR_SENSE  = 11,
+};
+
+/* DAC Register Default RANGE 0 to Vcc, Volatge Mode, DAC On */
+#define AD7877_DAC_CONF                 0x1
+
+/* If gpio3 is set AUX3/GPIO3 acts as GPIO Output */
+#define AD7877_EXTW_GPIO_3_CONF         0x1C4
+#define AD7877_EXTW_GPIO_DATA           0x200
+
+/* Control REG 2 */
+#define AD7877_TMR(x)                   ((x & 0x3) << 0)
+#define AD7877_REF(x)                   ((x & 0x1) << 2)
+#define AD7877_POL(x)                   ((x & 0x1) << 3)
+#define AD7877_FCD(x)                   ((x & 0x3) << 4)
+#define AD7877_PM(x)                    ((x & 0x3) << 6)
+#define AD7877_ACQ(x)                   ((x & 0x3) << 8)
+#define AD7877_AVG(x)                   ((x & 0x3) << 10)
+
+/* Control REG 1 */
+#define AD7877_SER                      (1 << 11)       /* non-differential */
+#define AD7877_DFR                      (0 << 11)       /* differential */
+
+#define AD7877_MODE_NOC  (0)    /* Do not convert */
+#define AD7877_MODE_SCC  (1)    /* Single channel conversion */
+#define AD7877_MODE_SEQ0 (2)    /* Sequence 0 in Slave Mode */
+#define AD7877_MODE_SEQ1 (3)    /* Sequence 1 in Master Mode */
+
+#define AD7877_CHANADD(x)               ((x&0xF)<<7)
+#define AD7877_READADD(x)               ((x)<<2)
+#define AD7877_WRITEADD(x)              ((x)<<12)
+
+#define AD7877_READ_CHAN(x) (AD7877_WRITEADD(AD7877_REG_CTRL1) | AD7877_SER | \
+                AD7877_MODE_SCC | AD7877_CHANADD(AD7877_REG_ ## x) | \
+                AD7877_READADD(AD7877_REG_ ## x))
+
+#define AD7877_MM_SEQUENCE (AD7877_SEQ_YPLUS_BIT | AD7877_SEQ_XPLUS_BIT | \
+                AD7877_SEQ_Z2_BIT | AD7877_SEQ_Z1_BIT)
+
+/*
+ * Non-touchscreen sensors only use single-ended conversions.
+ */
+
+struct ser_req {
+        u16                     reset;
+        u16                     ref_on;
+        u16                     command;
+        u16                     sample;
+        struct spi_message      msg;
+        struct spi_transfer     xfer[6];
+};
+
+struct ad7877 {
+        struct input_dev        *input;
+        char                    phys[32];
+
+        struct spi_device       *spi;
+        u16                     model;
+        u16                     vref_delay_usecs;
+        u16                     x_plate_ohms;
+        u16                     pressure_max;
+
+        u16                     cmd_crtl1;
+        u16                     cmd_crtl2;
+        u16                     cmd_dummy;
+        u16                     dac;
+
+        u8                      stopacq_polarity;
+        u8                      first_conversion_delay;
+        u8                      acquisition_time;
+        u8                      averaging;
+        u8                      pen_down_acc_interval;
+
+        u16                     conversion_data[AD7877_NR_SENSE];
+
+        struct spi_transfer     xfer[AD7877_NR_SENSE + 2];
+        struct spi_message      msg;
+
+        struct mutex            mutex;
+        unsigned                disabled:1;     /* P: mutex */
+        unsigned                gpio3:1;        /* P: mutex */
+        unsigned                gpio4:1;        /* P: mutex */
+
+        spinlock_t              lock;
+        struct timer_list       timer;          /* P: lock */
+        unsigned                pending:1;      /* P: lock */
+};
+
+static int gpio3;
+module_param(gpio3, int, 0);
+MODULE_PARM_DESC(gpio3, "If gpio3 is set to 1 AUX3 acts as GPIO3");
+
+/*
+ * ad7877_read/write are only used for initial setup and for sysfs controls.
+ * The main traffic is done using spi_async() in the interrupt handler.
+ */
+
+static int ad7877_read(struct spi_device *spi, u16 reg)
+{
+        struct ser_req *req;
+        int status, ret;
+
+        req = kzalloc(sizeof *req, GFP_KERNEL);
+        if (!req)
+                return -ENOMEM;
+
+        spi_message_init(&req->msg);
+
+        req->command = (u16) (AD7877_WRITEADD(AD7877_REG_CTRL1) |
+                        AD7877_READADD(reg));
+        req->xfer[0].tx_buf = &req->command;
+        req->xfer[0].len = 2;
+
+        req->xfer[1].rx_buf = &req->sample;
+        req->xfer[1].len = 2;
+
+        spi_message_add_tail(&req->xfer[0], &req->msg);
+        spi_message_add_tail(&req->xfer[1], &req->msg);
+
+        status = spi_sync(spi, &req->msg);
+        ret = status ? : req->sample;
+
+        kfree(req);
+
+        return ret;
+}
+
+static int ad7877_write(struct spi_device *spi, u16 reg, u16 val)
+{
+        struct ser_req *req;
+        int status;
+
+        req = kzalloc(sizeof *req, GFP_KERNEL);
+        if (!req)
+                return -ENOMEM;
+
+        spi_message_init(&req->msg);
+
+        req->command = (u16) (AD7877_WRITEADD(reg) | (val & MAX_12BIT));
+        req->xfer[0].tx_buf = &req->command;
+        req->xfer[0].len = 2;
+
+        spi_message_add_tail(&req->xfer[0], &req->msg);
+
+        status = spi_sync(spi, &req->msg);
+
+        kfree(req);
+
+        return status;
+}
+
+static int ad7877_read_adc(struct spi_device *spi, unsigned command)
+{
+        struct ad7877 *ts = dev_get_drvdata(&spi->dev);
+        struct ser_req *req;
+        int status;
+        int sample;
+        int i;
+
+        req = kzalloc(sizeof *req, GFP_KERNEL);
+        if (!req)
+                return -ENOMEM;
+
+        spi_message_init(&req->msg);
+
+        /* activate reference, so it has time to settle; */
+        req->ref_on = AD7877_WRITEADD(AD7877_REG_CTRL2) |
+                         AD7877_POL(ts->stopacq_polarity) |
+                         AD7877_AVG(0) | AD7877_PM(2) | AD7877_TMR(0) |
+                         AD7877_ACQ(ts->acquisition_time) | AD7877_FCD(0);
+
+        req->reset = AD7877_WRITEADD(AD7877_REG_CTRL1) | AD7877_MODE_NOC;
+
+        req->command = (u16) command;
+
+        req->xfer[0].tx_buf = &req->reset;
+        req->xfer[0].len = 2;
+
+        req->xfer[1].tx_buf = &req->ref_on;
+        req->xfer[1].len = 2;
+        req->xfer[1].delay_usecs = ts->vref_delay_usecs;
+
+        req->xfer[2].tx_buf = &req->command;
+        req->xfer[2].len = 2;
+        req->xfer[2].delay_usecs = ts->vref_delay_usecs;
+
+        req->xfer[3].rx_buf = &req->sample;
+        req->xfer[3].len = 2;
+
+        req->xfer[4].tx_buf = &ts->cmd_crtl2;   /*REF OFF*/
+        req->xfer[4].len = 2;
+
+        req->xfer[5].tx_buf = &ts->cmd_crtl1;   /*DEFAULT*/
+        req->xfer[5].len = 2;
+
+        /* group all the transfers together, so we can't interfere with
+         * reading touchscreen state; disable penirq while sampling
+         */
+        for (i = 0; i < 6; i++)
+                spi_message_add_tail(&req->xfer[i], &req->msg);
+
+        status = spi_sync(spi, &req->msg);
+        sample = req->sample;
+
+        kfree(req);
+
+        return status ? : sample;
+}
+
+static void ad7877_rx(struct ad7877 *ts)
+{
+        struct input_dev *input_dev = ts->input;
+        unsigned Rt;
+        u16 x, y, z1, z2;
+
+        x = ts->conversion_data[AD7877_SEQ_XPOS] & MAX_12BIT;
+        y = ts->conversion_data[AD7877_SEQ_YPOS] & MAX_12BIT;
+        z1 = ts->conversion_data[AD7877_SEQ_Z1] & MAX_12BIT;
+        z2 = ts->conversion_data[AD7877_SEQ_Z2] & MAX_12BIT;
+
+        /*
+         * The samples processed here are already preprocessed by the AD7877.
+         * The preprocessing function consists of an averaging filter.
+         * The combination of 'first conversion delay' and averaging provides a robust solution,
+         * discarding the spurious noise in the signal and keeping only the data of interest.
+         * The size of the averaging filter is programmable. (dev.platform_data, see linux/spi/ad7877.h)
+         * Other user-programmable conversion controls include variable acquisition time,
+         * and first conversion delay. Up to 16 averages can be taken per conversion.
+         */
+
+        if (likely(x && z1)) {
+                /* compute touch pressure resistance using equation #1 */
+                Rt = (z2 - z1) * x * ts->x_plate_ohms;
+                Rt /= z1;
+                Rt = (Rt + 2047) >> 12;
+
+                input_report_abs(input_dev, ABS_X, x);
+                input_report_abs(input_dev, ABS_Y, y);
+                input_report_abs(input_dev, ABS_PRESSURE, Rt);
+                input_sync(input_dev);
+        }
+}
+
+static inline void ad7877_ts_event_release(struct ad7877 *ts)
+{
+        struct input_dev *input_dev = ts->input;
+
+        input_report_abs(input_dev, ABS_PRESSURE, 0);
+        input_sync(input_dev);
+}
+
+static void ad7877_timer(unsigned long handle)
+{
+        struct ad7877 *ts = (void *)handle;
+
+        ad7877_ts_event_release(ts);
+}
+
+static irqreturn_t ad7877_irq(int irq, void *handle)
+{
+        struct ad7877 *ts = handle;
+        unsigned long flags;
+        int status;
+
+        /*
+         * The repeated conversion sequencer controlled by TMR kicked off
+         * too fast. We ignore the last and process the sample sequence
+         * currently in the queue. It can't be older than 9.4ms, and we
+         * need to avoid that ts->msg doesn't get issued twice while in work.
+         */
+
+        spin_lock_irqsave(&ts->lock, flags);
+        if (!ts->pending) {
+                ts->pending = 1;
+
+                status = spi_async(ts->spi, &ts->msg);
+                if (status)
+                        dev_err(&ts->spi->dev, "spi_sync --> %d\n", status);
+        }
+        spin_unlock_irqrestore(&ts->lock, flags);
+
+        return IRQ_HANDLED;
+}
+
+static void ad7877_callback(void *_ts)
+{
+        struct ad7877 *ts = _ts;
+
+        spin_lock_irq(&ts->lock);
+
+        ad7877_rx(ts);
+        ts->pending = 0;
+        mod_timer(&ts->timer, jiffies + TS_PEN_UP_TIMEOUT);
+
+        spin_unlock_irq(&ts->lock);
+}
+
+static void ad7877_disable(struct ad7877 *ts)
+{
+        mutex_lock(&ts->mutex);
+
+        if (!ts->disabled) {
+                ts->disabled = 1;
+                disable_irq(ts->spi->irq);
+
+                /* Wait for spi_async callback */
+                while (ts->pending)
+                        msleep(1);
+
+                if (del_timer_sync(&ts->timer))
+                        ad7877_ts_event_release(ts);
+        }
+
+        /* we know the chip's in lowpower mode since we always
+         * leave it that way after every request
+         */
+
+        mutex_unlock(&ts->mutex);
+}
+
+static void ad7877_enable(struct ad7877 *ts)
+{
+        mutex_lock(&ts->mutex);
+
+        if (ts->disabled) {
+                ts->disabled = 0;
+                enable_irq(ts->spi->irq);
+        }
+
+        mutex_unlock(&ts->mutex);
+}
+
+#define SHOW(name) static ssize_t \
+name ## _show(struct device *dev, struct device_attribute *attr, char *buf) \
+{ \
+        struct ad7877   *ts = dev_get_drvdata(dev); \
+        ssize_t v = ad7877_read_adc(ts->spi, \
+                        AD7877_READ_CHAN(name)); \
+        if (v < 0) \
+                return v; \
+        return sprintf(buf, "%u\n", (unsigned) v); \
+} \
+static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL);
+
+SHOW(aux1)
+SHOW(aux2)
+SHOW(aux3)
+SHOW(bat1)
+SHOW(bat2)
+SHOW(temp1)
+SHOW(temp2)
+
+static ssize_t ad7877_disable_show(struct device *dev,
+                                     struct device_attribute *attr, char *buf)
+{
+        struct ad7877   *ts = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%u\n", ts->disabled);
+}
+
+static ssize_t ad7877_disable_store(struct device *dev,
+                                     struct device_attribute *attr,
+                                     const char *buf, size_t count)
+{
+        struct ad7877 *ts = dev_get_drvdata(dev);
+        unsigned long val;
+        int error;
+
+        error = strict_strtoul(buf, 10, &val);
+        if (error)
+                return error;
+
+        if (val)
+                ad7877_disable(ts);
+        else
+                ad7877_enable(ts);
+
+        return count;
+}
+
+static DEVICE_ATTR(disable, 0664, ad7877_disable_show, ad7877_disable_store);
+
+static ssize_t ad7877_dac_show(struct device *dev,
+                                     struct device_attribute *attr, char *buf)
+{
+        struct ad7877   *ts = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%u\n", ts->dac);
+}
+
+static ssize_t ad7877_dac_store(struct device *dev,
+                                     struct device_attribute *attr,
+                                     const char *buf, size_t count)
+{
+        struct ad7877 *ts = dev_get_drvdata(dev);
+        unsigned long val;
+        int error;
+
+        error = strict_strtoul(buf, 10, &val);
+        if (error)
+                return error;
+
+        mutex_lock(&ts->mutex);
+        ts->dac = val & 0xFF;
+        ad7877_write(ts->spi, AD7877_REG_DAC, (ts->dac << 4) | AD7877_DAC_CONF);
+        mutex_unlock(&ts->mutex);
+
+        return count;
+}
+
+static DEVICE_ATTR(dac, 0664, ad7877_dac_show, ad7877_dac_store);
+
+static ssize_t ad7877_gpio3_show(struct device *dev,
+                                     struct device_attribute *attr, char *buf)
+{
+        struct ad7877   *ts = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%u\n", ts->gpio3);
+}
+
+static ssize_t ad7877_gpio3_store(struct device *dev,
+                                     struct device_attribute *attr,
+                                     const char *buf, size_t count)
+{
+        struct ad7877 *ts = dev_get_drvdata(dev);
+        unsigned long val;
+        int error;
+
+        error = strict_strtoul(buf, 10, &val);
+        if (error)
+                return error;
+
+        mutex_lock(&ts->mutex);
+        ts->gpio3 = !!val;
+        ad7877_write(ts->spi, AD7877_REG_EXTWRITE, AD7877_EXTW_GPIO_DATA |
+                 (ts->gpio4 << 4) | (ts->gpio3 << 5));
+        mutex_unlock(&ts->mutex);
+
+        return count;
+}
+
+static DEVICE_ATTR(gpio3, 0664, ad7877_gpio3_show, ad7877_gpio3_store);
+
+static ssize_t ad7877_gpio4_show(struct device *dev,
+                                     struct device_attribute *attr, char *buf)
+{
+        struct ad7877   *ts = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%u\n", ts->gpio4);
+}
+
+static ssize_t ad7877_gpio4_store(struct device *dev,
+                                     struct device_attribute *attr,
+                                     const char *buf, size_t count)
+{
+        struct ad7877 *ts = dev_get_drvdata(dev);
+        unsigned long val;
+        int error;
+
+        error = strict_strtoul(buf, 10, &val);
+        if (error)
+                return error;
+
+        mutex_lock(&ts->mutex);
+        ts->gpio4 = !!val;
+        ad7877_write(ts->spi, AD7877_REG_EXTWRITE, AD7877_EXTW_GPIO_DATA |
+                     (ts->gpio4 << 4) | (ts->gpio3 << 5));
+        mutex_unlock(&ts->mutex);
+
+        return count;
+}
+
+static DEVICE_ATTR(gpio4, 0664, ad7877_gpio4_show, ad7877_gpio4_store);
+
+static struct attribute *ad7877_attributes[] = {
+        &dev_attr_temp1.attr,
+        &dev_attr_temp2.attr,
+        &dev_attr_aux1.attr,
+        &dev_attr_aux2.attr,
+        &dev_attr_bat1.attr,
+        &dev_attr_bat2.attr,
+        &dev_attr_disable.attr,
+        &dev_attr_dac.attr,
+        &dev_attr_gpio4.attr,
+        NULL
+};
+
+static const struct attribute_group ad7877_attr_group = {
+        .attrs = ad7877_attributes,
+};
+
+static void ad7877_setup_ts_def_msg(struct spi_device *spi, struct ad7877 *ts)
+{
+        struct spi_message *m;
+        int i;
+
+        ts->cmd_crtl2 = AD7877_WRITEADD(AD7877_REG_CTRL2) |
+                        AD7877_POL(ts->stopacq_polarity) |
+                        AD7877_AVG(ts->averaging) | AD7877_PM(1) |
+                        AD7877_TMR(ts->pen_down_acc_interval) |
+                        AD7877_ACQ(ts->acquisition_time) |
+                        AD7877_FCD(ts->first_conversion_delay);
+
+        ad7877_write(spi, AD7877_REG_CTRL2, ts->cmd_crtl2);
+
+        ts->cmd_crtl1 = AD7877_WRITEADD(AD7877_REG_CTRL1) |
+                        AD7877_READADD(AD7877_REG_XPLUS-1) |
+                        AD7877_MODE_SEQ1 | AD7877_DFR;
+
+        ad7877_write(spi, AD7877_REG_CTRL1, ts->cmd_crtl1);
+
+        ts->cmd_dummy = 0;
+
+        m = &ts->msg;
+
+        spi_message_init(m);
+
+        m->complete = ad7877_callback;
+        m->context = ts;
+
+        ts->xfer[0].tx_buf = &ts->cmd_crtl1;
+        ts->xfer[0].len = 2;
+
+        spi_message_add_tail(&ts->xfer[0], m);
+
+        ts->xfer[1].tx_buf = &ts->cmd_dummy; /* Send ZERO */
+        ts->xfer[1].len = 2;
+
+        spi_message_add_tail(&ts->xfer[1], m);
+
+        for (i = 0; i < 11; i++) {
+                ts->xfer[i + 2].rx_buf = &ts->conversion_data[AD7877_SEQ_YPOS + i];
+                ts->xfer[i + 2].len = 2;
+                spi_message_add_tail(&ts->xfer[i + 2], m);
+        }
+}
+
+static int __devinit ad7877_probe(struct spi_device *spi)
+{
+        struct ad7877                   *ts;
+        struct input_dev                *input_dev;
+        struct ad7877_platform_data     *pdata = spi->dev.platform_data;
+        int                             err;
+        u16                             verify;
+
+        if (!spi->irq) {
+                dev_dbg(&spi->dev, "no IRQ?\n");
+                return -ENODEV;
+        }
+
+        if (!pdata) {
+                dev_dbg(&spi->dev, "no platform data?\n");
+                return -ENODEV;
+        }
+
+        /* don't exceed max specified SPI CLK frequency */
+        if (spi->max_speed_hz > MAX_SPI_FREQ_HZ) {
+                dev_dbg(&spi->dev, "SPI CLK %d Hz?\n",spi->max_speed_hz);
+                return -EINVAL;
+        }
+
+        ts = kzalloc(sizeof(struct ad7877), GFP_KERNEL);
+        input_dev = input_allocate_device();
+        if (!ts || !input_dev) {
+                err = -ENOMEM;
+                goto err_free_mem;
+        }
+
+        dev_set_drvdata(&spi->dev, ts);
+        ts->spi = spi;
+        ts->input = input_dev;
+
+        setup_timer(&ts->timer, ad7877_timer, (unsigned long) ts);
+        mutex_init(&ts->mutex);
+        spin_lock_init(&ts->lock);
+
+        ts->model = pdata->model ? : 7877;
+        ts->vref_delay_usecs = pdata->vref_delay_usecs ? : 100;
+        ts->x_plate_ohms = pdata->x_plate_ohms ? : 400;
+        ts->pressure_max = pdata->pressure_max ? : ~0;
+
+        ts->stopacq_polarity = pdata->stopacq_polarity;
+        ts->first_conversion_delay = pdata->first_conversion_delay;
+        ts->acquisition_time = pdata->acquisition_time;
+        ts->averaging = pdata->averaging;
+        ts->pen_down_acc_interval = pdata->pen_down_acc_interval;
+
+        snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(&spi->dev));
+
+        input_dev->name = "AD7877 Touchscreen";
+        input_dev->phys = ts->phys;
+        input_dev->dev.parent = &spi->dev;
+
+        __set_bit(EV_ABS, input_dev->evbit);
+        __set_bit(ABS_X, input_dev->absbit);
+        __set_bit(ABS_Y, input_dev->absbit);
+        __set_bit(ABS_PRESSURE, input_dev->absbit);
+
+        input_set_abs_params(input_dev, ABS_X,
+                        pdata->x_min ? : 0,
+                        pdata->x_max ? : MAX_12BIT,
+                        0, 0);
+        input_set_abs_params(input_dev, ABS_Y,
+                        pdata->y_min ? : 0,
+                        pdata->y_max ? : MAX_12BIT,
+                        0, 0);
+        input_set_abs_params(input_dev, ABS_PRESSURE,
+                        pdata->pressure_min, pdata->pressure_max, 0, 0);
+
+        ad7877_write(spi, AD7877_REG_SEQ1, AD7877_MM_SEQUENCE);
+
+        verify = ad7877_read(spi, AD7877_REG_SEQ1);
+
+        if (verify != AD7877_MM_SEQUENCE){
+                dev_err(&spi->dev, "%s: Failed to probe %s\n",
+                        dev_name(&spi->dev), input_dev->name);
+                err = -ENODEV;
+                goto err_free_mem;
+        }
+
+        if (gpio3)
+                ad7877_write(spi, AD7877_REG_EXTWRITE, AD7877_EXTW_GPIO_3_CONF);
+
+        ad7877_setup_ts_def_msg(spi, ts);
+
+        /* Request AD7877 /DAV GPIO interrupt */
+
+        err = request_irq(spi->irq, ad7877_irq, IRQF_TRIGGER_FALLING |
+                        IRQF_SAMPLE_RANDOM, spi->dev.driver->name, ts);
+        if (err) {
+                dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq);
+                goto err_free_mem;
+        }
+
+        err = sysfs_create_group(&spi->dev.kobj, &ad7877_attr_group);
+        if (err)
+                goto err_free_irq;
+
+        err = device_create_file(&spi->dev,
+                                 gpio3 ? &dev_attr_gpio3 : &dev_attr_aux3);
+        if (err)
+                goto err_remove_attr_group;
+
+        err = input_register_device(input_dev);
+        if (err)
+                goto err_remove_attr;
+
+        return 0;
+
+err_remove_attr:
+        device_remove_file(&spi->dev,
+                           gpio3 ? &dev_attr_gpio3 : &dev_attr_aux3);
+err_remove_attr_group:
+        sysfs_remove_group(&spi->dev.kobj, &ad7877_attr_group);
+err_free_irq:
+        free_irq(spi->irq, ts);
+err_free_mem:
+        input_free_device(input_dev);
+        kfree(ts);
+        dev_set_drvdata(&spi->dev, NULL);
+        return err;
+}
+
+static int __devexit ad7877_remove(struct spi_device *spi)
+{
+        struct ad7877           *ts = dev_get_drvdata(&spi->dev);
+
+        sysfs_remove_group(&spi->dev.kobj, &ad7877_attr_group);
+        device_remove_file(&spi->dev,
+                           gpio3 ? &dev_attr_gpio3 : &dev_attr_aux3);
+
+        ad7877_disable(ts);
+        free_irq(ts->spi->irq, ts);
+
+        input_unregister_device(ts->input);
+        kfree(ts);
+
+        dev_dbg(&spi->dev, "unregistered touchscreen\n");
+        dev_set_drvdata(&spi->dev, NULL);
+
+        return 0;
+}
+
+#ifdef CONFIG_PM
+static int ad7877_suspend(struct spi_device *spi, pm_message_t message)
+{
+        struct ad7877 *ts = dev_get_drvdata(&spi->dev);
+
+        ad7877_disable(ts);
+
+        return 0;
+}
+
+static int ad7877_resume(struct spi_device *spi)
+{
+        struct ad7877 *ts = dev_get_drvdata(&spi->dev);
+
+        ad7877_enable(ts);
+
+        return 0;
+}
+#else
+#define ad7877_suspend NULL
+#define ad7877_resume  NULL
+#endif
+
+static struct spi_driver ad7877_driver = {
+        .driver = {
+                .name   = "ad7877",
+                .bus    = &spi_bus_type,
+                .owner  = THIS_MODULE,
+        },
+        .probe          = ad7877_probe,
+        .remove         = __devexit_p(ad7877_remove),
+        .suspend        = ad7877_suspend,
+        .resume         = ad7877_resume,
+};
+
+static int __init ad7877_init(void)
+{
+        return spi_register_driver(&ad7877_driver);
+}
+module_init(ad7877_init);
+
+static void __exit ad7877_exit(void)
+{
+        spi_unregister_driver(&ad7877_driver);
+}
+module_exit(ad7877_exit);
+
+MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
+MODULE_DESCRIPTION("AD7877 touchscreen Driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c
new file mode 100644
index 000000000000..ea4c61d68683
--- /dev/null
+++ b/drivers/input/touchscreen/ad7879.c
@@ -0,0 +1,782 @@
+/*
+ * Copyright (C) 2008 Michael Hennerich, Analog Devices Inc.
+ *
+ * Description: AD7879 based touchscreen, and GPIO driver (I2C/SPI Interface)
+ *
+ * Bugs:        Enter bugs at http://blackfin.uclinux.org/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see the file COPYING, or write
+ * to the Free Software Foundation, Inc.,
+ * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ * History:
+ * Copyright (c) 2005 David Brownell
+ * Copyright (c) 2006 Nokia Corporation
+ * Various changes: Imre Deak <imre.deak@nokia.com>
+ *
+ * Using code from:
+ *  - corgi_ts.c
+ *      Copyright (C) 2004-2005 Richard Purdie
+ *  - omap_ts.[hc], ads7846.h, ts_osk.c
+ *      Copyright (C) 2002 MontaVista Software
+ *      Copyright (C) 2004 Texas Instruments
+ *      Copyright (C) 2005 Dirk Behme
+ *  - ad7877.c
+ *      Copyright (C) 2006-2008 Analog Devices Inc.
+ */
+
+#include <linux/device.h>
+#include <linux/init.h>
+#include <linux/delay.h>
+#include <linux/input.h>
+#include <linux/interrupt.h>
+#include <linux/irq.h>
+#include <linux/slab.h>
+#include <linux/workqueue.h>
+#include <linux/spi/spi.h>
+#include <linux/i2c.h>
+
+#include <linux/spi/ad7879.h>
+
+#define AD7879_REG_ZEROS                0
+#define AD7879_REG_CTRL1                1
+#define AD7879_REG_CTRL2                2
+#define AD7879_REG_CTRL3                3
+#define AD7879_REG_AUX1HIGH             4
+#define AD7879_REG_AUX1LOW              5
+#define AD7879_REG_TEMP1HIGH            6
+#define AD7879_REG_TEMP1LOW             7
+#define AD7879_REG_XPLUS                8
+#define AD7879_REG_YPLUS                9
+#define AD7879_REG_Z1                   10
+#define AD7879_REG_Z2                   11
+#define AD7879_REG_AUXVBAT              12
+#define AD7879_REG_TEMP                 13
+#define AD7879_REG_REVID                14
+
+/* Control REG 1 */
+#define AD7879_TMR(x)                   ((x & 0xFF) << 0)
+#define AD7879_ACQ(x)                   ((x & 0x3) << 8)
+#define AD7879_MODE_NOC                 (0 << 10)       /* Do not convert */
+#define AD7879_MODE_SCC                 (1 << 10)       /* Single channel conversion */
+#define AD7879_MODE_SEQ0                (2 << 10)       /* Sequence 0 in Slave Mode */
+#define AD7879_MODE_SEQ1                (3 << 10)       /* Sequence 1 in Master Mode */
+#define AD7879_MODE_INT                 (1 << 15)       /* PENIRQ disabled INT enabled */
+
+/* Control REG 2 */
+#define AD7879_FCD(x)                   ((x & 0x3) << 0)
+#define AD7879_RESET                    (1 << 4)
+#define AD7879_MFS(x)                   ((x & 0x3) << 5)
+#define AD7879_AVG(x)                   ((x & 0x3) << 7)
+#define AD7879_SER                      (1 << 9)        /* non-differential */
+#define AD7879_DFR                      (0 << 9)        /* differential */
+#define AD7879_GPIOPOL                  (1 << 10)
+#define AD7879_GPIODIR                  (1 << 11)
+#define AD7879_GPIO_DATA                (1 << 12)
+#define AD7879_GPIO_EN                  (1 << 13)
+#define AD7879_PM(x)                    ((x & 0x3) << 14)
+#define AD7879_PM_SHUTDOWN              (0)
+#define AD7879_PM_DYN                   (1)
+#define AD7879_PM_FULLON                (2)
+
+/* Control REG 3 */
+#define AD7879_TEMPMASK_BIT             (1<<15)
+#define AD7879_AUXVBATMASK_BIT          (1<<14)
+#define AD7879_INTMODE_BIT              (1<<13)
+#define AD7879_GPIOALERTMASK_BIT        (1<<12)
+#define AD7879_AUXLOW_BIT               (1<<11)
+#define AD7879_AUXHIGH_BIT              (1<<10)
+#define AD7879_TEMPLOW_BIT              (1<<9)
+#define AD7879_TEMPHIGH_BIT             (1<<8)
+#define AD7879_YPLUS_BIT                (1<<7)
+#define AD7879_XPLUS_BIT                (1<<6)
+#define AD7879_Z1_BIT                   (1<<5)
+#define AD7879_Z2_BIT                   (1<<4)
+#define AD7879_AUX_BIT                  (1<<3)
+#define AD7879_VBAT_BIT                 (1<<2)
+#define AD7879_TEMP_BIT                 (1<<1)
+
+enum {
+        AD7879_SEQ_XPOS  = 0,
+        AD7879_SEQ_YPOS  = 1,
+        AD7879_SEQ_Z1    = 2,
+        AD7879_SEQ_Z2    = 3,
+        AD7879_NR_SENSE  = 4,
+};
+
+#define MAX_12BIT                       ((1<<12)-1)
+#define TS_PEN_UP_TIMEOUT               msecs_to_jiffies(50)
+
+#if defined(CONFIG_TOUCHSCREEN_AD7879_SPI) || defined(CONFIG_TOUCHSCREEN_AD7879_SPI_MODULE)
+#define AD7879_DEVID            0x7A
+typedef struct spi_device       bus_device;
+#elif defined(CONFIG_TOUCHSCREEN_AD7879_I2C) || defined(CONFIG_TOUCHSCREEN_AD7879_I2C_MODULE)
+#define AD7879_DEVID            0x79
+typedef struct i2c_client       bus_device;
+#endif
+
+struct ad7879 {
+        bus_device              *bus;
+        struct input_dev        *input;
+        struct work_struct      work;
+        struct timer_list       timer;
+
+        struct mutex            mutex;
+        unsigned                disabled:1;     /* P: mutex */
+
+#if defined(CONFIG_TOUCHSCREEN_AD7879_SPI) || defined(CONFIG_TOUCHSCREEN_AD7879_SPI_MODULE)
+        struct spi_message      msg;
+        struct spi_transfer     xfer[AD7879_NR_SENSE + 1];
+        u16                     cmd;
+#endif
+        u16                     conversion_data[AD7879_NR_SENSE];
+        char                    phys[32];
+        u8                      first_conversion_delay;
+        u8                      acquisition_time;
+        u8                      averaging;
+        u8                      pen_down_acc_interval;
+        u8                      median;
+        u16                     x_plate_ohms;
+        u16                     pressure_max;
+        u16                     gpio_init;
+        u16                     cmd_crtl1;
+        u16                     cmd_crtl2;
+        u16                     cmd_crtl3;
+        unsigned                gpio:1;
+};
+
+static int ad7879_read(bus_device *, u8);
+static int ad7879_write(bus_device *, u8, u16);
+static void ad7879_collect(struct ad7879 *);
+
+static void ad7879_report(struct ad7879 *ts)
+{
+        struct input_dev *input_dev = ts->input;
+        unsigned Rt;
+        u16 x, y, z1, z2;
+
+        x = ts->conversion_data[AD7879_SEQ_XPOS] & MAX_12BIT;
+        y = ts->conversion_data[AD7879_SEQ_YPOS] & MAX_12BIT;
+        z1 = ts->conversion_data[AD7879_SEQ_Z1] & MAX_12BIT;
+        z2 = ts->conversion_data[AD7879_SEQ_Z2] & MAX_12BIT;
+
+        /*
+         * The samples processed here are already preprocessed by the AD7879.
+         * The preprocessing function consists of a median and an averaging filter.
+         * The combination of these two techniques provides a robust solution,
+         * discarding the spurious noise in the signal and keeping only the data of interest.
+         * The size of both filters is programmable. (dev.platform_data, see linux/spi/ad7879.h)
+         * Other user-programmable conversion controls include variable acquisition time,
+         * and first conversion delay. Up to 16 averages can be taken per conversion.
+         */
+
+        if (likely(x && z1)) {
+                /* compute touch pressure resistance using equation #1 */
+                Rt = (z2 - z1) * x * ts->x_plate_ohms;
+                Rt /= z1;
+                Rt = (Rt + 2047) >> 12;
+
+                input_report_abs(input_dev, ABS_X, x);
+                input_report_abs(input_dev, ABS_Y, y);
+                input_report_abs(input_dev, ABS_PRESSURE, Rt);
+                input_sync(input_dev);
+        }
+}
+
+static void ad7879_work(struct work_struct *work)
+{
+        struct ad7879 *ts = container_of(work, struct ad7879, work);
+
+        /* use keventd context to read the result registers */
+        ad7879_collect(ts);
+        ad7879_report(ts);
+        mod_timer(&ts->timer, jiffies + TS_PEN_UP_TIMEOUT);
+}
+
+static void ad7879_ts_event_release(struct ad7879 *ts)
+{
+        struct input_dev *input_dev = ts->input;
+
+        input_report_abs(input_dev, ABS_PRESSURE, 0);
+        input_sync(input_dev);
+}
+
+static void ad7879_timer(unsigned long handle)
+{
+        struct ad7879 *ts = (void *)handle;
+
+        ad7879_ts_event_release(ts);
+}
+
+static irqreturn_t ad7879_irq(int irq, void *handle)
+{
+        struct ad7879 *ts = handle;
+
+        /* The repeated conversion sequencer controlled by TMR kicked off too fast.
+         * We ignore the last and process the sample sequence currently in the queue.
+         * It can't be older than 9.4ms
+         */
+
+        if (!work_pending(&ts->work))
+                schedule_work(&ts->work);
+
+        return IRQ_HANDLED;
+}
+
+static void ad7879_setup(struct ad7879 *ts)
+{
+        ts->cmd_crtl3 = AD7879_YPLUS_BIT |
+                        AD7879_XPLUS_BIT |
+                        AD7879_Z2_BIT |
+                        AD7879_Z1_BIT |
+                        AD7879_TEMPMASK_BIT |
+                        AD7879_AUXVBATMASK_BIT |
+                        AD7879_GPIOALERTMASK_BIT;
+
+        ts->cmd_crtl2 = AD7879_PM(AD7879_PM_DYN) | AD7879_DFR |
+                        AD7879_AVG(ts->averaging) |
+                        AD7879_MFS(ts->median) |
+                        AD7879_FCD(ts->first_conversion_delay) |
+                        ts->gpio_init;
+
+        ts->cmd_crtl1 = AD7879_MODE_INT | AD7879_MODE_SEQ1 |
+                        AD7879_ACQ(ts->acquisition_time) |
+                        AD7879_TMR(ts->pen_down_acc_interval);
+
+        ad7879_write(ts->bus, AD7879_REG_CTRL2, ts->cmd_crtl2);
+        ad7879_write(ts->bus, AD7879_REG_CTRL3, ts->cmd_crtl3);
+        ad7879_write(ts->bus, AD7879_REG_CTRL1, ts->cmd_crtl1);
+}
+
+static void ad7879_disable(struct ad7879 *ts)
+{
+        mutex_lock(&ts->mutex);
+
+        if (!ts->disabled) {
+
+                ts->disabled = 1;
+                disable_irq(ts->bus->irq);
+
+                cancel_work_sync(&ts->work);
+
+                if (del_timer_sync(&ts->timer))
+                        ad7879_ts_event_release(ts);
+
+                ad7879_write(ts->bus, AD7879_REG_CTRL2,
+                             AD7879_PM(AD7879_PM_SHUTDOWN));
+        }
+
+        mutex_unlock(&ts->mutex);
+}
+
+static void ad7879_enable(struct ad7879 *ts)
+{
+        mutex_lock(&ts->mutex);
+
+        if (ts->disabled) {
+                ad7879_setup(ts);
+                ts->disabled = 0;
+                enable_irq(ts->bus->irq);
+        }
+
+        mutex_unlock(&ts->mutex);
+}
+
+static ssize_t ad7879_disable_show(struct device *dev,
+                                     struct device_attribute *attr, char *buf)
+{
+        struct ad7879 *ts = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%u\n", ts->disabled);
+}
+
+static ssize_t ad7879_disable_store(struct device *dev,
+                                     struct device_attribute *attr,
+                                     const char *buf, size_t count)
+{
+        struct ad7879 *ts = dev_get_drvdata(dev);
+        unsigned long val;
+        int error;
+
+        error = strict_strtoul(buf, 10, &val);
+        if (error)
+                return error;
+
+        if (val)
+                ad7879_disable(ts);
+        else
+                ad7879_enable(ts);
+
+        return count;
+}
+
+static DEVICE_ATTR(disable, 0664, ad7879_disable_show, ad7879_disable_store);
+
+static ssize_t ad7879_gpio_show(struct device *dev,
+                                     struct device_attribute *attr, char *buf)
+{
+        struct ad7879 *ts = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%u\n", ts->gpio);
+}
+
+static ssize_t ad7879_gpio_store(struct device *dev,
+                                     struct device_attribute *attr,
+                                     const char *buf, size_t count)
+{
+        struct ad7879 *ts = dev_get_drvdata(dev);
+        unsigned long val;
+        int error;
+
+        error = strict_strtoul(buf, 10, &val);
+        if (error)
+                return error;
+
+        mutex_lock(&ts->mutex);
+        ts->gpio = !!val;
+        error = ad7879_write(ts->bus, AD7879_REG_CTRL2,
+                           ts->gpio ?
+                                ts->cmd_crtl2 & ~AD7879_GPIO_DATA :
+                                ts->cmd_crtl2 | AD7879_GPIO_DATA);
+        mutex_unlock(&ts->mutex);
+
+        return error ? : count;
+}
+
+static DEVICE_ATTR(gpio, 0664, ad7879_gpio_show, ad7879_gpio_store);
+
+static struct attribute *ad7879_attributes[] = {
+        &dev_attr_disable.attr,
+        &dev_attr_gpio.attr,
+        NULL
+};
+
+static const struct attribute_group ad7879_attr_group = {
+        .attrs = ad7879_attributes,
+};
+
+static int __devinit ad7879_construct(bus_device *bus, struct ad7879 *ts)
+{
+        struct input_dev *input_dev;
+        struct ad7879_platform_data *pdata = bus->dev.platform_data;
+        int err;
+        u16 revid;
+
+        if (!bus->irq) {
+                dev_err(&bus->dev, "no IRQ?\n");
+                return -ENODEV;
+        }
+
+        if (!pdata) {
+                dev_err(&bus->dev, "no platform data?\n");
+                return -ENODEV;
+        }
+
+        input_dev = input_allocate_device();
+        if (!input_dev)
+                return -ENOMEM;
+
+        ts->input = input_dev;
+
+        setup_timer(&ts->timer, ad7879_timer, (unsigned long) ts);
+        INIT_WORK(&ts->work, ad7879_work);
+        mutex_init(&ts->mutex);
+
+        ts->x_plate_ohms = pdata->x_plate_ohms ? : 400;
+        ts->pressure_max = pdata->pressure_max ? : ~0;
+
+        ts->first_conversion_delay = pdata->first_conversion_delay;
+        ts->acquisition_time = pdata->acquisition_time;
+        ts->averaging = pdata->averaging;
+        ts->pen_down_acc_interval = pdata->pen_down_acc_interval;
+        ts->median = pdata->median;
+
+        if (pdata->gpio_output)
+                ts->gpio_init = AD7879_GPIO_EN |
+                                (pdata->gpio_default ? 0 : AD7879_GPIO_DATA);
+        else
+                ts->gpio_init = AD7879_GPIO_EN | AD7879_GPIODIR;
+
+        snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(&bus->dev));
+
+        input_dev->name = "AD7879 Touchscreen";
+        input_dev->phys = ts->phys;
+        input_dev->dev.parent = &bus->dev;
+
+        __set_bit(EV_ABS, input_dev->evbit);
+        __set_bit(ABS_X, input_dev->absbit);
+        __set_bit(ABS_Y, input_dev->absbit);
+        __set_bit(ABS_PRESSURE, input_dev->absbit);
+
+        input_set_abs_params(input_dev, ABS_X,
+                        pdata->x_min ? : 0,
+                        pdata->x_max ? : MAX_12BIT,
+                        0, 0);
+        input_set_abs_params(input_dev, ABS_Y,
+                        pdata->y_min ? : 0,
+                        pdata->y_max ? : MAX_12BIT,
+                        0, 0);
+        input_set_abs_params(input_dev, ABS_PRESSURE,
+                        pdata->pressure_min, pdata->pressure_max, 0, 0);
+
+        err = ad7879_write(bus, AD7879_REG_CTRL2, AD7879_RESET);
+
+        if (err < 0) {
+                dev_err(&bus->dev, "Failed to write %s\n", input_dev->name);
+                goto err_free_mem;
+        }
+
+        revid = ad7879_read(bus, AD7879_REG_REVID);
+
+        if ((revid & 0xFF) != AD7879_DEVID) {
+                dev_err(&bus->dev, "Failed to probe %s\n", input_dev->name);
+                err = -ENODEV;
+                goto err_free_mem;
+        }
+
+        ad7879_setup(ts);
+
+        err = request_irq(bus->irq, ad7879_irq,
+                          IRQF_TRIGGER_FALLING | IRQF_SAMPLE_RANDOM,
+                          bus->dev.driver->name, ts);
+
+        if (err) {
+                dev_err(&bus->dev, "irq %d busy?\n", bus->irq);
+                goto err_free_mem;
+        }
+
+        err = sysfs_create_group(&bus->dev.kobj, &ad7879_attr_group);
+        if (err)
+                goto err_free_irq;
+
+        err = input_register_device(input_dev);
+        if (err)
+                goto err_remove_attr;
+
+        dev_info(&bus->dev, "Rev.%d touchscreen, irq %d\n",
+                 revid >> 8, bus->irq);
+
+        return 0;
+
+err_remove_attr:
+        sysfs_remove_group(&bus->dev.kobj, &ad7879_attr_group);
+err_free_irq:
+        free_irq(bus->irq, ts);
+err_free_mem:
+        input_free_device(input_dev);
+
+        return err;
+}
+
+static int __devexit ad7879_destroy(bus_device *bus, struct ad7879 *ts)
+{
+        ad7879_disable(ts);
+        sysfs_remove_group(&ts->bus->dev.kobj, &ad7879_attr_group);
+        free_irq(ts->bus->irq, ts);
+        input_unregister_device(ts->input);
+        dev_dbg(&bus->dev, "unregistered touchscreen\n");
+
+        return 0;
+}
+
+#ifdef CONFIG_PM
+static int ad7879_suspend(bus_device *bus, pm_message_t message)
+{
+        struct ad7879 *ts = dev_get_drvdata(&bus->dev);
+
+        ad7879_disable(ts);
+
+        return 0;
+}
+
+static int ad7879_resume(bus_device *bus)
+{
+        struct ad7879 *ts = dev_get_drvdata(&bus->dev);
+
+        ad7879_enable(ts);
+
+        return 0;
+}
+#else
+#define ad7879_suspend NULL
+#define ad7879_resume  NULL
+#endif
+
+#if defined(CONFIG_TOUCHSCREEN_AD7879_SPI) || defined(CONFIG_TOUCHSCREEN_AD7879_SPI_MODULE)
+#define MAX_SPI_FREQ_HZ         5000000
+#define AD7879_CMD_MAGIC        0xE000
+#define AD7879_CMD_READ         (1 << 10)
+#define AD7879_WRITECMD(reg)    (AD7879_CMD_MAGIC | (reg & 0xF))
+#define AD7879_READCMD(reg)     (AD7879_CMD_MAGIC | AD7879_CMD_READ | (reg & 0xF))
+
+struct ser_req {
+        u16                     command;
+        u16                     data;
+        struct spi_message      msg;
+        struct spi_transfer     xfer[2];
+};
+
+/*
+ * ad7879_read/write are only used for initial setup and for sysfs controls.
+ * The main traffic is done in ad7879_collect().
+ */
+
+static int ad7879_read(struct spi_device *spi, u8 reg)
+{
+        struct ser_req *req;
+        int status, ret;
+
+        req = kzalloc(sizeof *req, GFP_KERNEL);
+        if (!req)
+                return -ENOMEM;
+
+        spi_message_init(&req->msg);
+
+        req->command = (u16) AD7879_READCMD(reg);
+        req->xfer[0].tx_buf = &req->command;
+        req->xfer[0].len = 2;
+
+        req->xfer[1].rx_buf = &req->data;
+        req->xfer[1].len = 2;
+
+        spi_message_add_tail(&req->xfer[0], &req->msg);
+        spi_message_add_tail(&req->xfer[1], &req->msg);
+
+        status = spi_sync(spi, &req->msg);
+        ret = status ? : req->data;
+
+        kfree(req);
+
+        return ret;
+}
+
+static int ad7879_write(struct spi_device *spi, u8 reg, u16 val)
+{
+        struct ser_req *req;
+        int status;
+
+        req = kzalloc(sizeof *req, GFP_KERNEL);
+        if (!req)
+                return -ENOMEM;
+
+        spi_message_init(&req->msg);
+
+        req->command = (u16) AD7879_WRITECMD(reg);
+        req->xfer[0].tx_buf = &req->command;
+        req->xfer[0].len = 2;
+
+        req->data = val;
+        req->xfer[1].tx_buf = &req->data;
+        req->xfer[1].len = 2;
+
+        spi_message_add_tail(&req->xfer[0], &req->msg);
+        spi_message_add_tail(&req->xfer[1], &req->msg);
+
+        status = spi_sync(spi, &req->msg);
+
+        kfree(req);
+
+        return status;
+}
+
+static void ad7879_collect(struct ad7879 *ts)
+{
+        int status = spi_sync(ts->bus, &ts->msg);
+
+        if (status)
+                dev_err(&ts->bus->dev, "spi_sync --> %d\n", status);
+}
+
+static void ad7879_setup_ts_def_msg(struct ad7879 *ts)
+{
+        struct spi_message *m;
+        int i;
+
+        ts->cmd = (u16) AD7879_READCMD(AD7879_REG_XPLUS);
+
+        m = &ts->msg;
+        spi_message_init(m);
+        ts->xfer[0].tx_buf = &ts->cmd;
+        ts->xfer[0].len = 2;
+
+        spi_message_add_tail(&ts->xfer[0], m);
+
+        for (i = 0; i < AD7879_NR_SENSE; i++) {
+                ts->xfer[i + 1].rx_buf = &ts->conversion_data[i];
+                ts->xfer[i + 1].len = 2;
+                spi_message_add_tail(&ts->xfer[i + 1], m);
+        }
+}
+
+static int __devinit ad7879_probe(struct spi_device *spi)
+{
+        struct ad7879 *ts;
+        int error;
+
+        /* don't exceed max specified SPI CLK frequency */
+        if (spi->max_speed_hz > MAX_SPI_FREQ_HZ) {
+                dev_err(&spi->dev, "SPI CLK %d Hz?\n", spi->max_speed_hz);
+                return -EINVAL;
+        }
+
+        ts = kzalloc(sizeof(struct ad7879), GFP_KERNEL);
+        if (!ts)
+                return -ENOMEM;
+
+        dev_set_drvdata(&spi->dev, ts);
+        ts->bus = spi;
+
+        ad7879_setup_ts_def_msg(ts);
+
+        error = ad7879_construct(spi, ts);
+        if (error) {
+                dev_set_drvdata(&spi->dev, NULL);
+                kfree(ts);
+        }
+
+        return 0;
+}
+
+static int __devexit ad7879_remove(struct spi_device *spi)
+{
+        struct ad7879 *ts = dev_get_drvdata(&spi->dev);
+
+        ad7879_destroy(spi, ts);
+        dev_set_drvdata(&spi->dev, NULL);
+        kfree(ts);
+
+        return 0;
+}
+
+static struct spi_driver ad7879_driver = {
+        .driver = {
+                .name   = "ad7879",
+                .bus    = &spi_bus_type,
+                .owner  = THIS_MODULE,
+        },
+        .probe          = ad7879_probe,
+        .remove         = __devexit_p(ad7879_remove),
+        .suspend        = ad7879_suspend,
+        .resume         = ad7879_resume,
+};
+
+static int __init ad7879_init(void)
+{
+        return spi_register_driver(&ad7879_driver);
+}
+module_init(ad7879_init);
+
+static void __exit ad7879_exit(void)
+{
+        spi_unregister_driver(&ad7879_driver);
+}
+module_exit(ad7879_exit);
+
+#elif defined(CONFIG_TOUCHSCREEN_AD7879_I2C) || defined(CONFIG_TOUCHSCREEN_AD7879_I2C_MODULE)
+
+/* All registers are word-sized.
+ * AD7879 uses a high-byte first convention.
+ */
+static int ad7879_read(struct i2c_client *client, u8 reg)
+{
+        return swab16(i2c_smbus_read_word_data(client, reg));
+}
+
+static int ad7879_write(struct i2c_client *client, u8 reg, u16 val)
+{
+        return i2c_smbus_write_word_data(client, reg, swab16(val));
+}
+
+static void ad7879_collect(struct ad7879 *ts)
+{
+        int i;
+
+        for (i = 0; i < AD7879_NR_SENSE; i++)
+                ts->conversion_data[i] = ad7879_read(ts->bus,
+                                                     AD7879_REG_XPLUS + i);
+}
+
+static int __devinit ad7879_probe(struct i2c_client *client,
+                                        const struct i2c_device_id *id)
+{
+        struct ad7879 *ts;
+        int error;
+
+        if (!i2c_check_functionality(client->adapter,
+                                        I2C_FUNC_SMBUS_WORD_DATA)) {
+                dev_err(&client->dev, "SMBUS Word Data not Supported\n");
+                return -EIO;
+        }
+
+        ts = kzalloc(sizeof(struct ad7879), GFP_KERNEL);
+        if (!ts)
+                return -ENOMEM;
+
+        i2c_set_clientdata(client, ts);
+        ts->bus = client;
+
+        error = ad7879_construct(client, ts);
+        if (error) {
+                i2c_set_clientdata(client, NULL);
+                kfree(ts);
+        }
+
+        return 0;
+}
+
+static int __devexit ad7879_remove(struct i2c_client *client)
+{
+        struct ad7879 *ts = dev_get_drvdata(&client->dev);
+
+        ad7879_destroy(client, ts);
+        i2c_set_clientdata(client, NULL);
+        kfree(ts);
+
+        return 0;
+}
+
+static const struct i2c_device_id ad7879_id[] = {
+        { "ad7879", 0 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, ad7879_id);
+
+static struct i2c_driver ad7879_driver = {
+        .driver = {
+                .name   = "ad7879",
+                .owner  = THIS_MODULE,
+        },
+        .probe          = ad7879_probe,
+        .remove         = __devexit_p(ad7879_remove),
+        .suspend        = ad7879_suspend,
+        .resume         = ad7879_resume,
+        .id_table       = ad7879_id,
+};
+
+static int __init ad7879_init(void)
+{
+        return i2c_add_driver(&ad7879_driver);
+}
+module_init(ad7879_init);
+
+static void __exit ad7879_exit(void)
+{
+        i2c_del_driver(&ad7879_driver);
+}
+module_exit(ad7879_exit);
+#endif
+
+MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
+MODULE_DESCRIPTION("AD7879(-1) touchscreen Driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/input/touchscreen/mainstone-wm97xx.c b/drivers/input/touchscreen/mainstone-wm97xx.c
index 1d11e2be9ef8..dfa6a84ab50a 100644
--- a/drivers/input/touchscreen/mainstone-wm97xx.c
+++ b/drivers/input/touchscreen/mainstone-wm97xx.c
@@ -162,6 +162,7 @@ static int wm97xx_acc_pen_down(struct wm97xx *wm)
                 input_report_abs(wm->input_dev, ABS_X, x & 0xfff);
                 input_report_abs(wm->input_dev, ABS_Y, y & 0xfff);
                 input_report_abs(wm->input_dev, ABS_PRESSURE, p & 0xfff);
+                input_report_key(wm->input_dev, BTN_TOUCH, (p != 0));
                 input_sync(wm->input_dev);
                 reads++;
         } while (reads < cinfo[sp_idx].reads);
@@ -245,7 +246,7 @@ static void wm97xx_irq_enable(struct wm97xx *wm, int enable)
         if (enable)
                 enable_irq(wm->pen_irq);
         else
-                disable_irq(wm->pen_irq);
+                disable_irq_nosync(wm->pen_irq);
 }
 
 static struct wm97xx_mach_ops mainstone_mach_ops = {
diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index 54986627def0..e868264fe799 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -151,12 +151,14 @@ static void ucb1400_ts_evt_add(struct input_dev *idev, u16 pressure, u16 x, u16
         input_report_abs(idev, ABS_X, x);
         input_report_abs(idev, ABS_Y, y);
         input_report_abs(idev, ABS_PRESSURE, pressure);
+        input_report_key(idev, BTN_TOUCH, 1);
         input_sync(idev);
 }
 
 static void ucb1400_ts_event_release(struct input_dev *idev)
 {
         input_report_abs(idev, ABS_PRESSURE, 0);
+        input_report_key(idev, BTN_TOUCH, 0);
         input_sync(idev);
 }
 
@@ -377,7 +379,8 @@ static int ucb1400_ts_probe(struct platform_device *dev)
         ucb->ts_idev->id.product        = ucb->id;
         ucb->ts_idev->open              = ucb1400_ts_open;
         ucb->ts_idev->close             = ucb1400_ts_close;
-        ucb->ts_idev->evbit[0]          = BIT_MASK(EV_ABS);
+        ucb->ts_idev->evbit[0]          = BIT_MASK(EV_ABS) | BIT_MASK(EV_KEY);
+        ucb->ts_idev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
 
         ucb1400_adc_enable(ucb->ac97);
         x_res = ucb1400_ts_read_xres(ucb);
diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
index d15aa11d7056..cec480bffe38 100644
--- a/drivers/input/touchscreen/wm97xx-core.c
+++ b/drivers/input/touchscreen/wm97xx-core.c
@@ -409,6 +409,7 @@ static int wm97xx_read_samples(struct wm97xx *wm)
                         wm->pen_is_down = 0;
                         dev_dbg(wm->dev, "pen up\n");
                         input_report_abs(wm->input_dev, ABS_PRESSURE, 0);
+                        input_report_key(wm->input_dev, BTN_TOUCH, 0);
                         input_sync(wm->input_dev);
                 } else if (!(rc & RC_AGAIN)) {
                         /* We need high frequency updates only while
@@ -433,6 +434,7 @@ static int wm97xx_read_samples(struct wm97xx *wm)
                 input_report_abs(wm->input_dev, ABS_X, data.x & 0xfff);
                 input_report_abs(wm->input_dev, ABS_Y, data.y & 0xfff);
                 input_report_abs(wm->input_dev, ABS_PRESSURE, data.p & 0xfff);
+                input_report_key(wm->input_dev, BTN_TOUCH, 1);
                 input_sync(wm->input_dev);
                 wm->pen_is_down = 1;
                 wm->ts_reader_interval = wm->ts_reader_min_interval;
@@ -628,18 +630,21 @@ static int wm97xx_probe(struct device *dev)
         wm->input_dev->phys = "wm97xx";
         wm->input_dev->open = wm97xx_ts_input_open;
         wm->input_dev->close = wm97xx_ts_input_close;
-        set_bit(EV_ABS, wm->input_dev->evbit);
-        set_bit(ABS_X, wm->input_dev->absbit);
-        set_bit(ABS_Y, wm->input_dev->absbit);
-        set_bit(ABS_PRESSURE, wm->input_dev->absbit);
+
+        __set_bit(EV_ABS, wm->input_dev->evbit);
+        __set_bit(EV_KEY, wm->input_dev->evbit);
+        __set_bit(BTN_TOUCH, wm->input_dev->keybit);
+
         input_set_abs_params(wm->input_dev, ABS_X, abs_x[0], abs_x[1],
                              abs_x[2], 0);
         input_set_abs_params(wm->input_dev, ABS_Y, abs_y[0], abs_y[1],
                              abs_y[2], 0);
         input_set_abs_params(wm->input_dev, ABS_PRESSURE, abs_p[0], abs_p[1],
                              abs_p[2], 0);
+
         input_set_drvdata(wm->input_dev, wm);
         wm->input_dev->dev.parent = dev;
+
         ret = input_register_device(wm->input_dev);
         if (ret < 0)
                 goto dev_alloc_err;
diff --git a/drivers/input/touchscreen/zylonite-wm97xx.c b/drivers/input/touchscreen/zylonite-wm97xx.c
new file mode 100644
index 000000000000..41e4359c277c
--- /dev/null
+++ b/drivers/input/touchscreen/zylonite-wm97xx.c
@@ -0,0 +1,240 @@
+/*
+ * zylonite-wm97xx.c  --  Zylonite Continuous Touch screen driver
+ *
+ * Copyright 2004, 2007, 2008 Wolfson Microelectronics PLC.
+ * Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
+ * Parts Copyright : Ian Molton <spyro@f2s.com>
+ *                   Andrew Zabolotny <zap@homelink.ru>
+ *
+ *  This program is free software; you can redistribute  it and/or modify it
+ *  under  the terms of  the GNU General  Public License as published by the
+ *  Free Software Foundation;  either version 2 of the  License, or (at your
+ *  option) any later version.
+ *
+ * Notes:
+ *     This is a wm97xx extended touch driver supporting interrupt driven
+ *     and continuous operation on Marvell Zylonite development systems
+ *     (which have a WM9713 on board).
+ */
+
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/delay.h>
+#include <linux/irq.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/wm97xx.h>
+
+#include <mach/hardware.h>
+#include <mach/mfp.h>
+#include <mach/regs-ac97.h>
+
+struct continuous {
+        u16 id;    /* codec id */
+        u8 code;   /* continuous code */
+        u8 reads;  /* number of coord reads per read cycle */
+        u32 speed; /* number of coords per second */
+};
+
+#define WM_READS(sp) ((sp / HZ) + 1)
+
+static const struct continuous cinfo[] = {
+        { WM9713_ID2, 0, WM_READS(94),  94  },
+        { WM9713_ID2, 1, WM_READS(120), 120 },
+        { WM9713_ID2, 2, WM_READS(154), 154 },
+        { WM9713_ID2, 3, WM_READS(188), 188 },
+};
+
+/* continuous speed index */
+static int sp_idx;
+
+/*
+ * Pen sampling frequency (Hz) in continuous mode.
+ */
+static int cont_rate = 200;
+module_param(cont_rate, int, 0);
+MODULE_PARM_DESC(cont_rate, "Sampling rate in continuous mode (Hz)");
+
+/*
+ * Pressure readback.
+ *
+ * Set to 1 to read back pen down pressure
+ */
+static int pressure;
+module_param(pressure, int, 0);
+MODULE_PARM_DESC(pressure, "Pressure readback (1 = pressure, 0 = no pressure)");
+
+/*
+ * AC97 touch data slot.
+ *
+ * Touch screen readback data ac97 slot
+ */
+static int ac97_touch_slot = 5;
+module_param(ac97_touch_slot, int, 0);
+MODULE_PARM_DESC(ac97_touch_slot, "Touch screen data slot AC97 number");
+
+
+/* flush AC97 slot 5 FIFO machines */
+static void wm97xx_acc_pen_up(struct wm97xx *wm)
+{
+        int i;
+
+        msleep(1);
+
+        for (i = 0; i < 16; i++)
+                MODR;
+}
+
+static int wm97xx_acc_pen_down(struct wm97xx *wm)
+{
+        u16 x, y, p = 0x100 | WM97XX_ADCSEL_PRES;
+        int reads = 0;
+        static u16 last, tries;
+
+        /* When the AC97 queue has been drained we need to allow time
+         * to buffer up samples otherwise we end up spinning polling
+         * for samples.  The controller can't have a suitably low
+         * threashold set to use the notifications it gives.
+         */
+        msleep(1);
+
+        if (tries > 5) {
+                tries = 0;
+                return RC_PENUP;
+        }
+
+        x = MODR;
+        if (x == last) {
+                tries++;
+                return RC_AGAIN;
+        }
+        last = x;
+        do {
+                if (reads)
+                        x = MODR;
+                y = MODR;
+                if (pressure)
+                        p = MODR;
+
+                /* are samples valid */
+                if ((x & WM97XX_ADCSRC_MASK) != WM97XX_ADCSEL_X ||
+                    (y & WM97XX_ADCSRC_MASK) != WM97XX_ADCSEL_Y ||
+                    (p & WM97XX_ADCSRC_MASK) != WM97XX_ADCSEL_PRES)
+                        goto up;
+
+                /* coordinate is good */
+                tries = 0;
+                input_report_abs(wm->input_dev, ABS_X, x & 0xfff);
+                input_report_abs(wm->input_dev, ABS_Y, y & 0xfff);
+                input_report_abs(wm->input_dev, ABS_PRESSURE, p & 0xfff);
+                input_report_key(wm->input_dev, BTN_TOUCH, (p != 0));
+                input_sync(wm->input_dev);
+                reads++;
+        } while (reads < cinfo[sp_idx].reads);
+up:
+        return RC_PENDOWN | RC_AGAIN;
+}
+
+static int wm97xx_acc_startup(struct wm97xx *wm)
+{
+        int idx;
+
+        /* check we have a codec */
+        if (wm->ac97 == NULL)
+                return -ENODEV;
+
+        /* Go you big red fire engine */
+        for (idx = 0; idx < ARRAY_SIZE(cinfo); idx++) {
+                if (wm->id != cinfo[idx].id)
+                        continue;
+                sp_idx = idx;
+                if (cont_rate <= cinfo[idx].speed)
+                        break;
+        }
+        wm->acc_rate = cinfo[sp_idx].code;
+        wm->acc_slot = ac97_touch_slot;
+        dev_info(wm->dev,
+                 "zylonite accelerated touchscreen driver, %d samples/sec\n",
+                 cinfo[sp_idx].speed);
+
+        return 0;
+}
+
+static void wm97xx_irq_enable(struct wm97xx *wm, int enable)
+{
+        if (enable)
+                enable_irq(wm->pen_irq);
+        else
+                disable_irq_nosync(wm->pen_irq);
+}
+
+static struct wm97xx_mach_ops zylonite_mach_ops = {
+        .acc_enabled    = 1,
+        .acc_pen_up     = wm97xx_acc_pen_up,
+        .acc_pen_down   = wm97xx_acc_pen_down,
+        .acc_startup    = wm97xx_acc_startup,
+        .irq_enable     = wm97xx_irq_enable,
+        .irq_gpio       = WM97XX_GPIO_2,
+};
+
+static int zylonite_wm97xx_probe(struct platform_device *pdev)
+{
+        struct wm97xx *wm = platform_get_drvdata(pdev);
+        int gpio_touch_irq;
+
+        if (cpu_is_pxa320())
+                gpio_touch_irq = mfp_to_gpio(MFP_PIN_GPIO15);
+        else
+                gpio_touch_irq = mfp_to_gpio(MFP_PIN_GPIO26);
+
+        wm->pen_irq = IRQ_GPIO(gpio_touch_irq);
+        set_irq_type(IRQ_GPIO(gpio_touch_irq), IRQ_TYPE_EDGE_BOTH);
+
+        wm97xx_config_gpio(wm, WM97XX_GPIO_13, WM97XX_GPIO_IN,
+                           WM97XX_GPIO_POL_HIGH,
+                           WM97XX_GPIO_STICKY,
+                           WM97XX_GPIO_WAKE);
+        wm97xx_config_gpio(wm, WM97XX_GPIO_2, WM97XX_GPIO_OUT,
+                           WM97XX_GPIO_POL_HIGH,
+                           WM97XX_GPIO_NOTSTICKY,
+                           WM97XX_GPIO_NOWAKE);
+
+        return wm97xx_register_mach_ops(wm, &zylonite_mach_ops);
+}
+
+static int zylonite_wm97xx_remove(struct platform_device *pdev)
+{
+        struct wm97xx *wm = platform_get_drvdata(pdev);
+
+        wm97xx_unregister_mach_ops(wm);
+
+        return 0;
+}
+
+static struct platform_driver zylonite_wm97xx_driver = {
+        .probe  = zylonite_wm97xx_probe,
+        .remove = zylonite_wm97xx_remove,
+        .driver = {
+                .name   = "wm97xx-touch",
+        },
+};
+
+static int __init zylonite_wm97xx_init(void)
+{
+        return platform_driver_register(&zylonite_wm97xx_driver);
+}
+
+static void __exit zylonite_wm97xx_exit(void)
+{
+        platform_driver_unregister(&zylonite_wm97xx_driver);
+}
+
+module_init(zylonite_wm97xx_init);
+module_exit(zylonite_wm97xx_exit);
+
+/* Module information */
+MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>");
+MODULE_DESCRIPTION("wm97xx continuous touch driver for Zylonite");
+MODULE_LICENSE("GPL");
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 102ef4a14c5f..d2109054de85 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -82,7 +82,7 @@ static int __devinit create_gpio_led(const struct gpio_led *template,
         if (!gpio_is_valid(template->gpio)) {
                 printk(KERN_INFO "Skipping unavilable LED gpio %d (%s)\n", 
                                 template->gpio, template->name);
-                return;
+                return 0;
         }
 
         ret = gpio_request(template->gpio, template->name);
diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index f01096549a93..823ceba6efa8 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -1047,6 +1047,19 @@ static int populate_table(struct dm_table *table,
         return dm_table_complete(table);
 }
 
+static int table_prealloc_integrity(struct dm_table *t,
+                                    struct mapped_device *md)
+{
+        struct list_head *devices = dm_table_get_devices(t);
+        struct dm_dev_internal *dd;
+
+        list_for_each_entry(dd, devices, list)
+                if (bdev_get_integrity(dd->dm_dev.bdev))
+                        return blk_integrity_register(dm_disk(md), NULL);
+
+        return 0;
+}
+
 static int table_load(struct dm_ioctl *param, size_t param_size)
 {
         int r;
@@ -1068,6 +1081,14 @@ static int table_load(struct dm_ioctl *param, size_t param_size)
                 goto out;
         }
 
+        r = table_prealloc_integrity(t, md);
+        if (r) {
+                DMERR("%s: could not register integrity profile.",
+                      dm_device_name(md));
+                dm_table_destroy(t);
+                goto out;
+        }
+
         down_write(&_hash_lock);
         hc = dm_get_mdptr(md);
         if (!hc || hc->md != md) {
diff --git a/drivers/md/dm-kcopyd.c b/drivers/md/dm-kcopyd.c
index 0a225da21272..3e3fc06cb861 100644
--- a/drivers/md/dm-kcopyd.c
+++ b/drivers/md/dm-kcopyd.c
@@ -297,7 +297,8 @@ static int run_complete_job(struct kcopyd_job *job)
         dm_kcopyd_notify_fn fn = job->fn;
         struct dm_kcopyd_client *kc = job->kc;
 
-        kcopyd_put_pages(kc, job->pages);
+        if (job->pages)
+                kcopyd_put_pages(kc, job->pages);
         mempool_free(job, kc->job_pool);
         fn(read_err, write_err, context);
 
@@ -461,6 +462,7 @@ static void segment_complete(int read_err, unsigned long write_err,
         sector_t progress = 0;
         sector_t count = 0;
         struct kcopyd_job *job = (struct kcopyd_job *) context;
+        struct dm_kcopyd_client *kc = job->kc;
 
         mutex_lock(&job->lock);
 
@@ -490,7 +492,7 @@ static void segment_complete(int read_err, unsigned long write_err,
 
         if (count) {
                 int i;
-                struct kcopyd_job *sub_job = mempool_alloc(job->kc->job_pool,
+                struct kcopyd_job *sub_job = mempool_alloc(kc->job_pool,
                                                            GFP_NOIO);
 
                 *sub_job = *job;
@@ -509,13 +511,16 @@ static void segment_complete(int read_err, unsigned long write_err,
         } else if (atomic_dec_and_test(&job->sub_jobs)) {
 
                 /*
-                 * To avoid a race we must keep the job around
-                 * until after the notify function has completed.
-                 * Otherwise the client may try and stop the job
-                 * after we've completed.
+                 * Queue the completion callback to the kcopyd thread.
+                 *
+                 * Some callers assume that all the completions are called
+                 * from a single thread and don't race with each other.
+                 *
+                 * We must not call the callback directly here because this
+                 * code may not be executing in the thread.
                  */
-                job->fn(read_err, write_err, job->context);
-                mempool_free(job, job->kc->job_pool);
+                push(&kc->complete_jobs, job);
+                wake(kc);
         }
 }
 
@@ -528,6 +533,8 @@ static void split_job(struct kcopyd_job *job)
 {
         int i;
 
+        atomic_inc(&job->kc->nr_jobs);
+
         atomic_set(&job->sub_jobs, SPLIT_COUNT);
         for (i = 0; i < SPLIT_COUNT; i++)
                 segment_complete(0, 0u, job);
diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c
index bfa107f59d96..79fb53e51c70 100644
--- a/drivers/md/dm-linear.c
+++ b/drivers/md/dm-linear.c
@@ -142,7 +142,6 @@ static struct target_type linear_target = {
         .status = linear_status,
         .ioctl  = linear_ioctl,
         .merge  = linear_merge,
-        .features = DM_TARGET_SUPPORTS_BARRIERS,
 };
 
 int __init dm_linear_init(void)
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index e8361b191b9b..429b50b975d5 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -52,8 +52,6 @@ struct dm_table {
         sector_t *highs;
         struct dm_target *targets;
 
-        unsigned barriers_supported:1;
-
         /*
          * Indicates the rw permissions for the new logical
          * device.  This should be a combination of FMODE_READ
@@ -243,7 +241,6 @@ int dm_table_create(struct dm_table **result, fmode_t mode,
 
         INIT_LIST_HEAD(&t->devices);
         atomic_set(&t->holders, 0);
-        t->barriers_supported = 1;
 
         if (!num_targets)
                 num_targets = KEYS_PER_NODE;
@@ -751,10 +748,6 @@ int dm_table_add_target(struct dm_table *t, const char *type,
         /* FIXME: the plan is to combine high here and then have
          * the merge fn apply the target level restrictions. */
         combine_restrictions_low(&t->limits, &tgt->limits);
-
-        if (!(tgt->type->features & DM_TARGET_SUPPORTS_BARRIERS))
-                t->barriers_supported = 0;
-
         return 0;
 
  bad:
@@ -799,12 +792,6 @@ int dm_table_complete(struct dm_table *t)
 
         check_for_valid_limits(&t->limits);
 
-        /*
-         * We only support barriers if there is exactly one underlying device.
-         */
-        if (!list_is_singular(&t->devices))
-                t->barriers_supported = 0;
-
         /* how many indexes will the btree have ? */
         leaf_nodes = dm_div_up(t->num_targets, KEYS_PER_NODE);
         t->depth = 1 + int_log(leaf_nodes, CHILDREN_PER_NODE);
@@ -879,6 +866,45 @@ struct dm_target *dm_table_find_target(struct dm_table *t, sector_t sector)
         return &t->targets[(KEYS_PER_NODE * n) + k];
 }
 
+/*
+ * Set the integrity profile for this device if all devices used have
+ * matching profiles.
+ */
+static void dm_table_set_integrity(struct dm_table *t)
+{
+        struct list_head *devices = dm_table_get_devices(t);
+        struct dm_dev_internal *prev = NULL, *dd = NULL;
+
+        if (!blk_get_integrity(dm_disk(t->md)))
+                return;
+
+        list_for_each_entry(dd, devices, list) {
+                if (prev &&
+                    blk_integrity_compare(prev->dm_dev.bdev->bd_disk,
+                                          dd->dm_dev.bdev->bd_disk) < 0) {
+                        DMWARN("%s: integrity not set: %s and %s mismatch",
+                               dm_device_name(t->md),
+                               prev->dm_dev.bdev->bd_disk->disk_name,
+                               dd->dm_dev.bdev->bd_disk->disk_name);
+                        goto no_integrity;
+                }
+                prev = dd;
+        }
+
+        if (!prev || !bdev_get_integrity(prev->dm_dev.bdev))
+                goto no_integrity;
+
+        blk_integrity_register(dm_disk(t->md),
+                               bdev_get_integrity(prev->dm_dev.bdev));
+
+        return;
+
+no_integrity:
+        blk_integrity_register(dm_disk(t->md), NULL);
+
+        return;
+}
+
 void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q)
 {
         /*
@@ -899,6 +925,7 @@ void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q)
         else
                 queue_flag_set_unlocked(QUEUE_FLAG_CLUSTER, q);
 
+        dm_table_set_integrity(t);
 }
 
 unsigned int dm_table_get_num_targets(struct dm_table *t)
@@ -1019,12 +1046,6 @@ struct mapped_device *dm_table_get_md(struct dm_table *t)
         return t->md;
 }
 
-int dm_table_barrier_ok(struct dm_table *t)
-{
-        return t->barriers_supported;
-}
-EXPORT_SYMBOL(dm_table_barrier_ok);
-
 EXPORT_SYMBOL(dm_vcalloc);
 EXPORT_SYMBOL(dm_get_device);
 EXPORT_SYMBOL(dm_put_device);
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 788ba96a6256..8a994be035ba 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -89,12 +89,13 @@ union map_info *dm_get_mapinfo(struct bio *bio)
 /*
  * Bits for the md->flags field.
  */
-#define DMF_BLOCK_IO 0
+#define DMF_BLOCK_IO_FOR_SUSPEND 0
 #define DMF_SUSPENDED 1
 #define DMF_FROZEN 2
 #define DMF_FREEING 3
 #define DMF_DELETING 4
 #define DMF_NOFLUSH_SUSPENDING 5
+#define DMF_QUEUE_IO_TO_THREAD 6
 
 /*
  * Work processed by per-device workqueue.
@@ -124,6 +125,11 @@ struct mapped_device {
         spinlock_t deferred_lock;
 
         /*
+         * An error from the barrier request currently being processed.
+         */
+        int barrier_error;
+
+        /*
          * Processing queue (flush/barriers)
          */
         struct workqueue_struct *wq;
@@ -424,6 +430,10 @@ static void end_io_acct(struct dm_io *io)
         part_stat_add(cpu, &dm_disk(md)->part0, ticks[rw], duration);
         part_stat_unlock();
 
+        /*
+         * After this is decremented the bio must not be touched if it is
+         * a barrier.
+         */
         dm_disk(md)->part0.in_flight = pending =
                 atomic_dec_return(&md->pending);
 
@@ -435,21 +445,18 @@ static void end_io_acct(struct dm_io *io)
 /*
  * Add the bio to the list of deferred io.
  */
-static int queue_io(struct mapped_device *md, struct bio *bio)
+static void queue_io(struct mapped_device *md, struct bio *bio)
 {
         down_write(&md->io_lock);
 
-        if (!test_bit(DMF_BLOCK_IO, &md->flags)) {
-                up_write(&md->io_lock);
-                return 1;
-        }
-
         spin_lock_irq(&md->deferred_lock);
         bio_list_add(&md->deferred, bio);
         spin_unlock_irq(&md->deferred_lock);
 
+        if (!test_and_set_bit(DMF_QUEUE_IO_TO_THREAD, &md->flags))
+                queue_work(md->wq, &md->work);
+
         up_write(&md->io_lock);
-        return 0;               /* deferred successfully */
 }
 
 /*
@@ -533,25 +540,35 @@ static void dec_pending(struct dm_io *io, int error)
                          */
                         spin_lock_irqsave(&md->deferred_lock, flags);
                         if (__noflush_suspending(md))
-                                bio_list_add(&md->deferred, io->bio);
+                                bio_list_add_head(&md->deferred, io->bio);
                         else
                                 /* noflush suspend was interrupted. */
                                 io->error = -EIO;
                         spin_unlock_irqrestore(&md->deferred_lock, flags);
                 }
 
-                end_io_acct(io);
-
                 io_error = io->error;
                 bio = io->bio;
 
-                free_io(md, io);
+                if (bio_barrier(bio)) {
+                        /*
+                         * There can be just one barrier request so we use
+                         * a per-device variable for error reporting.
+                         * Note that you can't touch the bio after end_io_acct
+                         */
+                        md->barrier_error = io_error;
+                        end_io_acct(io);
+                } else {
+                        end_io_acct(io);
 
-                if (io_error != DM_ENDIO_REQUEUE) {
-                        trace_block_bio_complete(md->queue, bio);
+                        if (io_error != DM_ENDIO_REQUEUE) {
+                                trace_block_bio_complete(md->queue, bio);
 
-                        bio_endio(bio, io_error);
+                                bio_endio(bio, io_error);
+                        }
                 }
+
+                free_io(md, io);
         }
 }
 
@@ -693,13 +710,19 @@ static struct bio *split_bvec(struct bio *bio, sector_t sector,
 
         clone->bi_sector = sector;
         clone->bi_bdev = bio->bi_bdev;
-        clone->bi_rw = bio->bi_rw;
+        clone->bi_rw = bio->bi_rw & ~(1 << BIO_RW_BARRIER);
         clone->bi_vcnt = 1;
         clone->bi_size = to_bytes(len);
         clone->bi_io_vec->bv_offset = offset;
         clone->bi_io_vec->bv_len = clone->bi_size;
         clone->bi_flags |= 1 << BIO_CLONED;
 
+        if (bio_integrity(bio)) {
+                bio_integrity_clone(clone, bio, GFP_NOIO);
+                bio_integrity_trim(clone,
+                                   bio_sector_offset(bio, idx, offset), len);
+        }
+
         return clone;
 }
 
@@ -714,6 +737,7 @@ static struct bio *clone_bio(struct bio *bio, sector_t sector,
 
         clone = bio_alloc_bioset(GFP_NOIO, bio->bi_max_vecs, bs);
         __bio_clone(clone, bio);
+        clone->bi_rw &= ~(1 << BIO_RW_BARRIER);
         clone->bi_destructor = dm_bio_destructor;
         clone->bi_sector = sector;
         clone->bi_idx = idx;
@@ -721,6 +745,14 @@ static struct bio *clone_bio(struct bio *bio, sector_t sector,
         clone->bi_size = to_bytes(len);
         clone->bi_flags &= ~(1 << BIO_SEG_VALID);
 
+        if (bio_integrity(bio)) {
+                bio_integrity_clone(clone, bio, GFP_NOIO);
+
+                if (idx != bio->bi_idx || clone->bi_size < bio->bi_size)
+                        bio_integrity_trim(clone,
+                                           bio_sector_offset(bio, idx, 0), len);
+        }
+
         return clone;
 }
 
@@ -834,14 +866,13 @@ static void __split_and_process_bio(struct mapped_device *md, struct bio *bio)
 
         ci.map = dm_get_table(md);
         if (unlikely(!ci.map)) {
-                bio_io_error(bio);
-                return;
-        }
-        if (unlikely(bio_barrier(bio) && !dm_table_barrier_ok(ci.map))) {
-                dm_table_put(ci.map);
-                bio_endio(bio, -EOPNOTSUPP);
+                if (!bio_barrier(bio))
+                        bio_io_error(bio);
+                else
+                        md->barrier_error = -EIO;
                 return;
         }
+
         ci.md = md;
         ci.bio = bio;
         ci.io = alloc_io(md);
@@ -918,7 +949,6 @@ out:
  */
 static int dm_request(struct request_queue *q, struct bio *bio)
 {
-        int r = -EIO;
         int rw = bio_data_dir(bio);
         struct mapped_device *md = q->queuedata;
         int cpu;
@@ -931,34 +961,27 @@ static int dm_request(struct request_queue *q, struct bio *bio)
         part_stat_unlock();
 
         /*
-         * If we're suspended we have to queue
-         * this io for later.
+         * If we're suspended or the thread is processing barriers
+         * we have to queue this io for later.
          */
-        while (test_bit(DMF_BLOCK_IO, &md->flags)) {
+        if (unlikely(test_bit(DMF_QUEUE_IO_TO_THREAD, &md->flags)) ||
+            unlikely(bio_barrier(bio))) {
                 up_read(&md->io_lock);
 
-                if (bio_rw(bio) != READA)
-                        r = queue_io(md, bio);
+                if (unlikely(test_bit(DMF_BLOCK_IO_FOR_SUSPEND, &md->flags)) &&
+                    bio_rw(bio) == READA) {
+                        bio_io_error(bio);
+                        return 0;
+                }
 
-                if (r <= 0)
-                        goto out_req;
+                queue_io(md, bio);
 
-                /*
-                 * We're in a while loop, because someone could suspend
-                 * before we get to the following read lock.
-                 */
-                down_read(&md->io_lock);
+                return 0;
         }
 
         __split_and_process_bio(md, bio);
         up_read(&md->io_lock);
         return 0;
-
-out_req:
-        if (r < 0)
-                bio_io_error(bio);
-
-        return 0;
 }
 
 static void dm_unplug_all(struct request_queue *q)
@@ -978,7 +1001,7 @@ static int dm_any_congested(void *congested_data, int bdi_bits)
         struct mapped_device *md = congested_data;
         struct dm_table *map;
 
-        if (!test_bit(DMF_BLOCK_IO, &md->flags)) {
+        if (!test_bit(DMF_BLOCK_IO_FOR_SUSPEND, &md->flags)) {
                 map = dm_get_table(md);
                 if (map) {
                         r = dm_table_any_congested(map, bdi_bits);
@@ -1193,6 +1216,7 @@ static void free_dev(struct mapped_device *md)
         mempool_destroy(md->tio_pool);
         mempool_destroy(md->io_pool);
         bioset_free(md->bs);
+        blk_integrity_unregister(md->disk);
         del_gendisk(md->disk);
         free_minor(minor);
 
@@ -1406,6 +1430,36 @@ static int dm_wait_for_completion(struct mapped_device *md, int interruptible)
         return r;
 }
 
+static int dm_flush(struct mapped_device *md)
+{
+        dm_wait_for_completion(md, TASK_UNINTERRUPTIBLE);
+        return 0;
+}
+
+static void process_barrier(struct mapped_device *md, struct bio *bio)
+{
+        int error = dm_flush(md);
+
+        if (unlikely(error)) {
+                bio_endio(bio, error);
+                return;
+        }
+        if (bio_empty_barrier(bio)) {
+                bio_endio(bio, 0);
+                return;
+        }
+
+        __split_and_process_bio(md, bio);
+
+        error = dm_flush(md);
+
+        if (!error && md->barrier_error)
+                error = md->barrier_error;
+
+        if (md->barrier_error != DM_ENDIO_REQUEUE)
+                bio_endio(bio, error);
+}
+
 /*
  * Process the deferred bios
  */
@@ -1417,25 +1471,34 @@ static void dm_wq_work(struct work_struct *work)
 
         down_write(&md->io_lock);
 
-next_bio:
-        spin_lock_irq(&md->deferred_lock);
-        c = bio_list_pop(&md->deferred);
-        spin_unlock_irq(&md->deferred_lock);
+        while (!test_bit(DMF_BLOCK_IO_FOR_SUSPEND, &md->flags)) {
+                spin_lock_irq(&md->deferred_lock);
+                c = bio_list_pop(&md->deferred);
+                spin_unlock_irq(&md->deferred_lock);
 
-        if (c) {
-                __split_and_process_bio(md, c);
-                goto next_bio;
-        }
+                if (!c) {
+                        clear_bit(DMF_QUEUE_IO_TO_THREAD, &md->flags);
+                        break;
+                }
 
-        clear_bit(DMF_BLOCK_IO, &md->flags);
+                up_write(&md->io_lock);
+
+                if (bio_barrier(c))
+                        process_barrier(md, c);
+                else
+                        __split_and_process_bio(md, c);
+
+                down_write(&md->io_lock);
+        }
 
         up_write(&md->io_lock);
 }
 
 static void dm_queue_flush(struct mapped_device *md)
 {
+        clear_bit(DMF_BLOCK_IO_FOR_SUSPEND, &md->flags);
+        smp_mb__after_clear_bit();
         queue_work(md->wq, &md->work);
-        flush_workqueue(md->wq);
 }
 
 /*
@@ -1553,20 +1616,36 @@ int dm_suspend(struct mapped_device *md, unsigned suspend_flags)
         }
 
         /*
-         * First we set the BLOCK_IO flag so no more ios will be mapped.
+         * Here we must make sure that no processes are submitting requests
+         * to target drivers i.e. no one may be executing
+         * __split_and_process_bio. This is called from dm_request and
+         * dm_wq_work.
+         *
+         * To get all processes out of __split_and_process_bio in dm_request,
+         * we take the write lock. To prevent any process from reentering
+         * __split_and_process_bio from dm_request, we set
+         * DMF_QUEUE_IO_TO_THREAD.
+         *
+         * To quiesce the thread (dm_wq_work), we set DMF_BLOCK_IO_FOR_SUSPEND
+         * and call flush_workqueue(md->wq). flush_workqueue will wait until
+         * dm_wq_work exits and DMF_BLOCK_IO_FOR_SUSPEND will prevent any
+         * further calls to __split_and_process_bio from dm_wq_work.
          */
         down_write(&md->io_lock);
-        set_bit(DMF_BLOCK_IO, &md->flags);
-
+        set_bit(DMF_BLOCK_IO_FOR_SUSPEND, &md->flags);
+        set_bit(DMF_QUEUE_IO_TO_THREAD, &md->flags);
         up_write(&md->io_lock);
 
+        flush_workqueue(md->wq);
+
         /*
-         * Wait for the already-mapped ios to complete.
+         * At this point no more requests are entering target request routines.
+         * We call dm_wait_for_completion to wait for all existing requests
+         * to finish.
          */
         r = dm_wait_for_completion(md, TASK_INTERRUPTIBLE);
 
         down_write(&md->io_lock);
-
         if (noflush)
                 clear_bit(DMF_NOFLUSH_SUSPENDING, &md->flags);
         up_write(&md->io_lock);
@@ -1579,6 +1658,12 @@ int dm_suspend(struct mapped_device *md, unsigned suspend_flags)
                 goto out; /* pushback list is already flushed, so skip flush */
         }
 
+        /*
+         * If dm_wait_for_completion returned 0, the device is completely
+         * quiescent now. There is no request-processing activity. All new
+         * requests are being added to md->deferred list.
+         */
+
         dm_table_postsuspend_targets(map);
 
         set_bit(DMF_SUSPENDED, &md->flags);
diff --git a/drivers/md/dm.h b/drivers/md/dm.h
index b48397c0abbd..a31506d93e91 100644
--- a/drivers/md/dm.h
+++ b/drivers/md/dm.h
@@ -52,7 +52,6 @@ int dm_table_any_congested(struct dm_table *t, int bdi_bits);
  * To check the return value from dm_table_find_target().
  */
 #define dm_target_is_valid(t) ((t)->table)
-int dm_table_barrier_ok(struct dm_table *t);
 
 /*-----------------------------------------------------------------
  * A registry of target types.
diff --git a/drivers/media/dvb/ttpci/Kconfig b/drivers/media/dvb/ttpci/Kconfig
index 772990415f99..68eb4493f991 100644
--- a/drivers/media/dvb/ttpci/Kconfig
+++ b/drivers/media/dvb/ttpci/Kconfig
@@ -28,25 +28,12 @@ config DVB_AV7110
           download/extract it, and then copy it to /usr/lib/hotplug/firmware
           or /lib/firmware (depending on configuration of firmware hotplug).
 
-          Say Y if you own such a card and want to use it.
-
-config DVB_AV7110_FIRMWARE
-        bool "Compile AV7110 firmware into the driver"
-        depends on DVB_AV7110 && !STANDALONE
-        default y if DVB_AV7110=y
-        help
-          The AV7110 firmware is normally loaded by the firmware hotplug manager.
-          If you want to compile the firmware into the driver you need to say
-          Y here and provide the correct path of the firmware. You need this
-          option if you want to compile the whole driver statically into the
-          kernel.
+          Alternatively, you can download the file and use the kernel's
+          EXTRA_FIRMWARE configuration option to build it into your
+          kernel image by adding the filename to the EXTRA_FIRMWARE
+          configuration option string.
 
-          All other people say N.
-
-config DVB_AV7110_FIRMWARE_FILE
-        string "Full pathname of av7110 firmware file"
-        depends on DVB_AV7110_FIRMWARE
-        default "/usr/lib/hotplug/firmware/dvb-ttpci-01.fw"
+          Say Y if you own such a card and want to use it.
 
 config DVB_AV7110_OSD
         bool "AV7110 OSD support"
diff --git a/drivers/media/dvb/ttpci/Makefile b/drivers/media/dvb/ttpci/Makefile
index 71451237294c..8a4d5bb20a5b 100644
--- a/drivers/media/dvb/ttpci/Makefile
+++ b/drivers/media/dvb/ttpci/Makefile
@@ -19,12 +19,3 @@ obj-$(CONFIG_DVB_AV7110) += dvb-ttpci.o
 
 EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core/ -Idrivers/media/dvb/frontends/
 EXTRA_CFLAGS += -Idrivers/media/common/tuners
-
-hostprogs-y     := fdump
-
-ifeq ($(CONFIG_DVB_AV7110_FIRMWARE),y)
-$(obj)/av7110.o: $(obj)/av7110_firm.h
-
-$(obj)/av7110_firm.h: $(obj)/fdump
-        $(obj)/fdump $(CONFIG_DVB_AV7110_FIRMWARE_FILE) dvb_ttpci_fw $@
-endif
diff --git a/drivers/media/dvb/ttpci/av7110.c b/drivers/media/dvb/ttpci/av7110.c
index 4624cee93e74..d1d959ed37b7 100644
--- a/drivers/media/dvb/ttpci/av7110.c
+++ b/drivers/media/dvb/ttpci/av7110.c
@@ -1518,20 +1518,6 @@ static int check_firmware(struct av7110* av7110)
         return 0;
 }
 
-#ifdef CONFIG_DVB_AV7110_FIRMWARE_FILE
-#include "av7110_firm.h"
-static void put_firmware(struct av7110* av7110)
-{
-        av7110->bin_fw = NULL;
-}
-
-static inline int get_firmware(struct av7110* av7110)
-{
-        av7110->bin_fw = dvb_ttpci_fw;
-        av7110->size_fw = sizeof(dvb_ttpci_fw);
-        return check_firmware(av7110);
-}
-#else
 static void put_firmware(struct av7110* av7110)
 {
         vfree(av7110->bin_fw);
@@ -1580,8 +1566,6 @@ static int get_firmware(struct av7110* av7110)
         release_firmware(fw);
         return ret;
 }
-#endif
-
 
 static int alps_bsrv2_tuner_set_params(struct dvb_frontend* fe, struct dvb_frontend_parameters *params)
 {
diff --git a/drivers/media/dvb/ttpci/av7110_hw.c b/drivers/media/dvb/ttpci/av7110_hw.c
index 3a3f5279e927..5e3f88911a1d 100644
--- a/drivers/media/dvb/ttpci/av7110_hw.c
+++ b/drivers/media/dvb/ttpci/av7110_hw.c
@@ -198,29 +198,10 @@ static int load_dram(struct av7110 *av7110, u32 *data, int len)
 
 /* we cannot write av7110 DRAM directly, so load a bootloader into
  * the DPRAM which implements a simple boot protocol */
-static u8 bootcode[] = {
-  0xea, 0x00, 0x00, 0x0e, 0xe1, 0xb0, 0xf0, 0x0e, 0xe2, 0x5e, 0xf0, 0x04,
-  0xe2, 0x5e, 0xf0, 0x04, 0xe2, 0x5e, 0xf0, 0x08, 0xe2, 0x5e, 0xf0, 0x04,
-  0xe2, 0x5e, 0xf0, 0x04, 0xe2, 0x5e, 0xf0, 0x04, 0x2c, 0x00, 0x00, 0x24,
-  0x00, 0x00, 0x00, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x2c, 0x00, 0x00, 0x34,
-  0x00, 0x00, 0x00, 0x00, 0xa5, 0xa5, 0x5a, 0x5a, 0x00, 0x1f, 0x15, 0x55,
-  0x00, 0x00, 0x00, 0x09, 0xe5, 0x9f, 0xd0, 0x7c, 0xe5, 0x9f, 0x40, 0x74,
-  0xe3, 0xa0, 0x00, 0x00, 0xe5, 0x84, 0x00, 0x00, 0xe5, 0x84, 0x00, 0x04,
-  0xe5, 0x9f, 0x10, 0x70, 0xe5, 0x9f, 0x20, 0x70, 0xe5, 0x9f, 0x30, 0x64,
-  0xe8, 0xb1, 0x1f, 0xe0, 0xe8, 0xa3, 0x1f, 0xe0, 0xe1, 0x51, 0x00, 0x02,
-  0xda, 0xff, 0xff, 0xfb, 0xe5, 0x9f, 0xf0, 0x50, 0xe1, 0xd4, 0x10, 0xb0,
-  0xe3, 0x51, 0x00, 0x00, 0x0a, 0xff, 0xff, 0xfc, 0xe1, 0xa0, 0x10, 0x0d,
-  0xe5, 0x94, 0x30, 0x04, 0xe1, 0xd4, 0x20, 0xb2, 0xe2, 0x82, 0x20, 0x3f,
-  0xe1, 0xb0, 0x23, 0x22, 0x03, 0xa0, 0x00, 0x02, 0xe1, 0xc4, 0x00, 0xb0,
-  0x0a, 0xff, 0xff, 0xf4, 0xe8, 0xb1, 0x1f, 0xe0, 0xe8, 0xa3, 0x1f, 0xe0,
-  0xe8, 0xb1, 0x1f, 0xe0, 0xe8, 0xa3, 0x1f, 0xe0, 0xe2, 0x52, 0x20, 0x01,
-  0x1a, 0xff, 0xff, 0xf9, 0xe2, 0x2d, 0xdb, 0x05, 0xea, 0xff, 0xff, 0xec,
-  0x2c, 0x00, 0x03, 0xf8, 0x2c, 0x00, 0x04, 0x00, 0x9e, 0x00, 0x08, 0x00,
-  0x2c, 0x00, 0x00, 0x74, 0x2c, 0x00, 0x00, 0xc0
-};
-
 int av7110_bootarm(struct av7110 *av7110)
 {
+        const struct firmware *fw;
+        const char *fw_name = "av7110/bootcode.bin";
         struct saa7146_dev *dev = av7110->dev;
         u32 ret;
         int i;
@@ -261,7 +242,15 @@ int av7110_bootarm(struct av7110 *av7110)
         //saa7146_setgpio(dev, DEBI_DONE_LINE, SAA7146_GPIO_INPUT);
         //saa7146_setgpio(dev, 3, SAA7146_GPIO_INPUT);
 
-        mwdebi(av7110, DEBISWAB, DPRAM_BASE, bootcode, sizeof(bootcode));
+        ret = request_firmware(&fw, fw_name, &dev->pci->dev);
+        if (ret) {
+                printk(KERN_ERR "dvb-ttpci: Failed to load firmware \"%s\"\n",
+                        fw_name);
+                return ret;
+        }
+
+        mwdebi(av7110, DEBISWAB, DPRAM_BASE, fw->data, fw->size);
+        release_firmware(fw);
         iwdebi(av7110, DEBINOSWAP, AV7110_BOOT_STATE, BOOTSTATE_BUFFER_FULL, 2);
 
         if (saa7146_wait_for_debi_done(av7110->dev, 1)) {
@@ -302,7 +291,7 @@ int av7110_bootarm(struct av7110 *av7110)
         av7110->arm_ready = 1;
         return 0;
 }
-
+MODULE_FIRMWARE("av7110/bootcode.bin");
 
 /****************************************************************************
  * DEBI command polling
diff --git a/drivers/media/dvb/ttpci/av7110_hw.h b/drivers/media/dvb/ttpci/av7110_hw.h
index ca99e5c1fc8a..1634aba5cb84 100644
--- a/drivers/media/dvb/ttpci/av7110_hw.h
+++ b/drivers/media/dvb/ttpci/av7110_hw.h
@@ -390,7 +390,8 @@ static inline void iwdebi(struct av7110 *av7110, u32 config, int addr, u32 val,
 }
 
 /* buffer writes */
-static inline void mwdebi(struct av7110 *av7110, u32 config, int addr, u8 *val, int count)
+static inline void mwdebi(struct av7110 *av7110, u32 config, int addr,
+                          const u8 *val, int count)
 {
         memcpy(av7110->debi_virt, val, count);
         av7110_debiwrite(av7110, config, addr, 0, count);
diff --git a/drivers/media/dvb/ttpci/fdump.c b/drivers/media/dvb/ttpci/fdump.c
deleted file mode 100644
index c90001d35e7d..000000000000
--- a/drivers/media/dvb/ttpci/fdump.c
+++ /dev/null
@@ -1,44 +0,0 @@
-#include <stdio.h>
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <fcntl.h>
-#include <unistd.h>
-
-int main(int argc, char **argv)
-{
-    unsigned char buf[8];
-    unsigned int i, count, bytes = 0;
-    FILE *fd_in, *fd_out;
-
-    if (argc != 4) {
-        fprintf(stderr, "\n\tusage: %s <ucode.bin> <array_name> <output_name>\n\n", argv[0]);
-        return -1;
-    }
-
-    fd_in = fopen(argv[1], "rb");
-    if (fd_in == NULL) {
-        fprintf(stderr, "firmware file '%s' not found\n", argv[1]);
-        return -1;
-    }
-
-    fd_out = fopen(argv[3], "w+");
-    if (fd_out == NULL) {
-        fprintf(stderr, "cannot create output file '%s'\n", argv[3]);
-        return -1;
-    }
-
-    fprintf(fd_out, "\n#include <asm/types.h>\n\nu8 %s [] = {", argv[2]);
-
-    while ((count = fread(buf, 1, 8, fd_in)) > 0) {
-        fprintf(fd_out, "\n\t");
-        for (i = 0; i < count; i++, bytes++)
-            fprintf(fd_out, "0x%02x, ", buf[i]);
-    }
-
-    fprintf(fd_out, "\n};\n\n");
-
-    fclose(fd_in);
-    fclose(fd_out);
-
-    return 0;
-}
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index c232d11a7ed4..06084dbf1277 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -208,7 +208,7 @@ static int mmc_read_ext_csd(struct mmc_card *card)
         }
 
         ext_csd_struct = ext_csd[EXT_CSD_REV];
-        if (ext_csd_struct > 2) {
+        if (ext_csd_struct > 3) {
                 printk(KERN_ERR "%s: unrecognised EXT_CSD structure "
                         "version %d\n", mmc_hostname(card->host),
                         ext_csd_struct);
diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index 26fc098d77cd..cd81c395e164 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -363,15 +363,6 @@ static int mmc_sd_init_card(struct mmc_host *host, u32 ocr,
                 goto err;
 
         /*
-         * For SPI, enable CRC as appropriate.
-         */
-        if (mmc_host_is_spi(host)) {
-                err = mmc_spi_set_crc(host, use_spi_crc);
-                if (err)
-                        goto err;
-        }
-
-        /*
          * Fetch CID from card.
          */
         if (mmc_host_is_spi(host))
@@ -458,6 +449,18 @@ static int mmc_sd_init_card(struct mmc_host *host, u32 ocr,
         }
 
         /*
+         * For SPI, enable CRC as appropriate.
+         * This CRC enable is located AFTER the reading of the
+         * card registers because some SDHC cards are not able
+         * to provide valid CRCs for non-512-byte blocks.
+         */
+        if (mmc_host_is_spi(host)) {
+                err = mmc_spi_set_crc(host, use_spi_crc);
+                if (err)
+                        goto free_card;
+        }
+
+        /*
          * Attempt to change to high-speed (if supported)
          */
         err = mmc_switch_hs(card);
diff --git a/drivers/mmc/host/imxmmc.c b/drivers/mmc/host/imxmmc.c
index eb29b1d933ac..e0be21a4a696 100644
--- a/drivers/mmc/host/imxmmc.c
+++ b/drivers/mmc/host/imxmmc.c
@@ -307,13 +307,6 @@ static void imxmci_setup_data(struct imxmci_host *host, struct mmc_data *data)
 
         wmb();
 
-        if (host->actual_bus_width == MMC_BUS_WIDTH_4)
-                BLR(host->dma) = 0;     /* burst 64 byte read / 64 bytes write */
-        else
-                BLR(host->dma) = 16;    /* burst 16 byte read / 16 bytes write */
-
-        RSSR(host->dma) = DMA_REQ_SDHC;
-
         set_bit(IMXMCI_PEND_DMA_DATA_b, &host->pending_events);
         clear_bit(IMXMCI_PEND_CPU_DATA_b, &host->pending_events);
 
@@ -818,9 +811,11 @@ static void imxmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
         if (ios->bus_width == MMC_BUS_WIDTH_4) {
                 host->actual_bus_width = MMC_BUS_WIDTH_4;
                 imx_gpio_mode(PB11_PF_SD_DAT3);
+                BLR(host->dma) = 0;     /* burst 64 byte read/write */
         } else {
                 host->actual_bus_width = MMC_BUS_WIDTH_1;
                 imx_gpio_mode(GPIO_PORTB | GPIO_IN | GPIO_PUEN | 11);
+                BLR(host->dma) = 16;    /* burst 16 byte read/write */
         }
 
         if (host->power_mode != ios->power_mode) {
@@ -938,7 +933,7 @@ static void imxmci_check_status(unsigned long data)
         mod_timer(&host->timer, jiffies + (HZ>>1));
 }
 
-static int imxmci_probe(struct platform_device *pdev)
+static int __init imxmci_probe(struct platform_device *pdev)
 {
         struct mmc_host *mmc;
         struct imxmci_host *host = NULL;
@@ -1034,6 +1029,7 @@ static int imxmci_probe(struct platform_device *pdev)
         }
         host->dma_allocated = 1;
         imx_dma_setup_handlers(host->dma, imxmci_dma_irq, NULL, host);
+        RSSR(host->dma) = DMA_REQ_SDHC;
 
         tasklet_init(&host->tasklet, imxmci_tasklet_fnc, (unsigned long)host);
         host->status_reg=0;
@@ -1079,7 +1075,7 @@ out:
         return ret;
 }
 
-static int imxmci_remove(struct platform_device *pdev)
+static int __exit imxmci_remove(struct platform_device *pdev)
 {
         struct mmc_host *mmc = platform_get_drvdata(pdev);
 
@@ -1145,8 +1141,7 @@ static int imxmci_resume(struct platform_device *dev)
 #endif /* CONFIG_PM */
 
 static struct platform_driver imxmci_driver = {
-        .probe          = imxmci_probe,
-        .remove         = imxmci_remove,
+        .remove         = __exit_p(imxmci_remove),
         .suspend        = imxmci_suspend,
         .resume         = imxmci_resume,
         .driver         = {
@@ -1157,7 +1152,7 @@ static struct platform_driver imxmci_driver = {
 
 static int __init imxmci_init(void)
 {
-        return platform_driver_register(&imxmci_driver);
+        return platform_driver_probe(&imxmci_driver, imxmci_probe);
 }
 
 static void __exit imxmci_exit(void)
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 72f8bde4877a..f48349d18c92 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -24,7 +24,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
-#include <linux/hrtimer.h>
+#include <linux/sched.h>
 #include <linux/delay.h>
 #include <linux/bio.h>
 #include <linux/dma-mapping.h>
@@ -95,7 +95,7 @@
  * reads which takes nowhere near that long.  Older cards may be able to use
  * shorter timeouts ... but why bother?
  */
-#define r1b_timeout             ktime_set(3, 0)
+#define r1b_timeout             (HZ * 3)
 
 
 /****************************************************************************/
@@ -183,12 +183,11 @@ mmc_spi_readbytes(struct mmc_spi_host *host, unsigned len)
         return status;
 }
 
-static int
-mmc_spi_skip(struct mmc_spi_host *host, ktime_t timeout, unsigned n, u8 byte)
+static int mmc_spi_skip(struct mmc_spi_host *host, unsigned long timeout,
+                        unsigned n, u8 byte)
 {
         u8              *cp = host->data->status;
-
-        timeout = ktime_add(timeout, ktime_get());
+        unsigned long start = jiffies;
 
         while (1) {
                 int             status;
@@ -203,22 +202,26 @@ mmc_spi_skip(struct mmc_spi_host *host, ktime_t timeout, unsigned n, u8 byte)
                                 return cp[i];
                 }
 
-                /* REVISIT investigate msleep() to avoid busy-wait I/O
-                 * in at least some cases.
-                 */
-                if (ktime_to_ns(ktime_sub(ktime_get(), timeout)) > 0)
+                if (time_is_before_jiffies(start + timeout))
                         break;
+
+                /* If we need long timeouts, we may release the CPU.
+                 * We use jiffies here because we want to have a relation
+                 * between elapsed time and the blocking of the scheduler.
+                 */
+                if (time_is_before_jiffies(start+1))
+                        schedule();
         }
         return -ETIMEDOUT;
 }
 
 static inline int
-mmc_spi_wait_unbusy(struct mmc_spi_host *host, ktime_t timeout)
+mmc_spi_wait_unbusy(struct mmc_spi_host *host, unsigned long timeout)
 {
         return mmc_spi_skip(host, timeout, sizeof(host->data->status), 0);
 }
 
-static int mmc_spi_readtoken(struct mmc_spi_host *host, ktime_t timeout)
+static int mmc_spi_readtoken(struct mmc_spi_host *host, unsigned long timeout)
 {
         return mmc_spi_skip(host, timeout, 1, 0xff);
 }
@@ -251,6 +254,10 @@ static int mmc_spi_response_get(struct mmc_spi_host *host,
         u8      *cp = host->data->status;
         u8      *end = cp + host->t.len;
         int     value = 0;
+        int     bitshift;
+        u8      leftover = 0;
+        unsigned short rotator;
+        int     i;
         char    tag[32];
 
         snprintf(tag, sizeof(tag), "  ... CMD%d response SPI_%s",
@@ -268,9 +275,8 @@ static int mmc_spi_response_get(struct mmc_spi_host *host,
 
         /* Data block reads (R1 response types) may need more data... */
         if (cp == end) {
-                unsigned        i;
-
                 cp = host->data->status;
+                end = cp+1;
 
                 /* Card sends N(CR) (== 1..8) bytes of all-ones then one
                  * status byte ... and we already scanned 2 bytes.
@@ -295,20 +301,34 @@ static int mmc_spi_response_get(struct mmc_spi_host *host,
         }
 
 checkstatus:
-        if (*cp & 0x80) {
-                dev_dbg(&host->spi->dev, "%s: INVALID RESPONSE, %02x\n",
-                                        tag, *cp);
-                value = -EBADR;
-                goto done;
+        bitshift = 0;
+        if (*cp & 0x80) {
+                /* Houston, we have an ugly card with a bit-shifted response */
+                rotator = *cp++ << 8;
+                /* read the next byte */
+                if (cp == end) {
+                        value = mmc_spi_readbytes(host, 1);
+                        if (value < 0)
+                                goto done;
+                        cp = host->data->status;
+                        end = cp+1;
+                }
+                rotator |= *cp++;
+                while (rotator & 0x8000) {
+                        bitshift++;
+                        rotator <<= 1;
+                }
+                cmd->resp[0] = rotator >> 8;
+                leftover = rotator;
+        } else {
+                cmd->resp[0] = *cp++;
         }
-
-        cmd->resp[0] = *cp++;
         cmd->error = 0;
 
         /* Status byte: the entire seven-bit R1 response.  */
         if (cmd->resp[0] != 0) {
                 if ((R1_SPI_PARAMETER | R1_SPI_ADDRESS
-                                        | R1_SPI_ILLEGAL_COMMAND)
+                                      | R1_SPI_ILLEGAL_COMMAND)
                                 & cmd->resp[0])
                         value = -EINVAL;
                 else if (R1_SPI_COM_CRC & cmd->resp[0])
@@ -336,12 +356,45 @@ checkstatus:
          * SPI R5 == R1 + data byte; IO_RW_DIRECT
          */
         case MMC_RSP_SPI_R2:
-                cmd->resp[0] |= *cp << 8;
+                /* read the next byte */
+                if (cp == end) {
+                        value = mmc_spi_readbytes(host, 1);
+                        if (value < 0)
+                                goto done;
+                        cp = host->data->status;
+                        end = cp+1;
+                }
+                if (bitshift) {
+                        rotator = leftover << 8;
+                        rotator |= *cp << bitshift;
+                        cmd->resp[0] |= (rotator & 0xFF00);
+                } else {
+                        cmd->resp[0] |= *cp << 8;
+                }
                 break;
 
         /* SPI R3, R4, or R7 == R1 + 4 bytes */
         case MMC_RSP_SPI_R3:
-                cmd->resp[1] = get_unaligned_be32(cp);
+                rotator = leftover << 8;
+                cmd->resp[1] = 0;
+                for (i = 0; i < 4; i++) {
+                        cmd->resp[1] <<= 8;
+                        /* read the next byte */
+                        if (cp == end) {
+                                value = mmc_spi_readbytes(host, 1);
+                                if (value < 0)
+                                        goto done;
+                                cp = host->data->status;
+                                end = cp+1;
+                        }
+                        if (bitshift) {
+                                rotator |= *cp++ << bitshift;
+                                cmd->resp[1] |= (rotator >> 8);
+                                rotator <<= 8;
+                        } else {
+                                cmd->resp[1] |= *cp++;
+                        }
+                }
                 break;
 
         /* SPI R1 == just one status byte */
@@ -607,7 +660,7 @@ mmc_spi_setup_data_message(
  */
 static int
 mmc_spi_writeblock(struct mmc_spi_host *host, struct spi_transfer *t,
-        ktime_t timeout)
+        unsigned long timeout)
 {
         struct spi_device       *spi = host->spi;
         int                     status, i;
@@ -717,11 +770,13 @@ mmc_spi_writeblock(struct mmc_spi_host *host, struct spi_transfer *t,
  */
 static int
 mmc_spi_readblock(struct mmc_spi_host *host, struct spi_transfer *t,
-        ktime_t timeout)
+        unsigned long timeout)
 {
         struct spi_device       *spi = host->spi;
         int                     status;
         struct scratch          *scratch = host->data;
+        unsigned int            bitshift;
+        u8                      leftover;
 
         /* At least one SD card sends an all-zeroes byte when N(CX)
          * applies, before the all-ones bytes ... just cope with that.
@@ -733,38 +788,60 @@ mmc_spi_readblock(struct mmc_spi_host *host, struct spi_transfer *t,
         if (status == 0xff || status == 0)
                 status = mmc_spi_readtoken(host, timeout);
 
-        if (status == SPI_TOKEN_SINGLE) {
-                if (host->dma_dev) {
-                        dma_sync_single_for_device(host->dma_dev,
-                                        host->data_dma, sizeof(*scratch),
-                                        DMA_BIDIRECTIONAL);
-                        dma_sync_single_for_device(host->dma_dev,
-                                        t->rx_dma, t->len,
-                                        DMA_FROM_DEVICE);
-                }
+        if (status < 0) {
+                dev_dbg(&spi->dev, "read error %02x (%d)\n", status, status);
+                return status;
+        }
 
-                status = spi_sync(spi, &host->m);
+        /* The token may be bit-shifted...
+         * the first 0-bit precedes the data stream.
+         */
+        bitshift = 7;
+        while (status & 0x80) {
+                status <<= 1;
+                bitshift--;
+        }
+        leftover = status << 1;
 
-                if (host->dma_dev) {
-                        dma_sync_single_for_cpu(host->dma_dev,
-                                        host->data_dma, sizeof(*scratch),
-                                        DMA_BIDIRECTIONAL);
-                        dma_sync_single_for_cpu(host->dma_dev,
-                                        t->rx_dma, t->len,
-                                        DMA_FROM_DEVICE);
-                }
+        if (host->dma_dev) {
+                dma_sync_single_for_device(host->dma_dev,
+                                host->data_dma, sizeof(*scratch),
+                                DMA_BIDIRECTIONAL);
+                dma_sync_single_for_device(host->dma_dev,
+                                t->rx_dma, t->len,
+                                DMA_FROM_DEVICE);
+        }
 
-        } else {
-                dev_dbg(&spi->dev, "read error %02x (%d)\n", status, status);
+        status = spi_sync(spi, &host->m);
 
-                /* we've read extra garbage, timed out, etc */
-                if (status < 0)
-                        return status;
+        if (host->dma_dev) {
+                dma_sync_single_for_cpu(host->dma_dev,
+                                host->data_dma, sizeof(*scratch),
+                                DMA_BIDIRECTIONAL);
+                dma_sync_single_for_cpu(host->dma_dev,
+                                t->rx_dma, t->len,
+                                DMA_FROM_DEVICE);
+        }
 
-                /* low four bits are an R2 subset, fifth seems to be
-                 * vendor specific ... map them all to generic error..
+        if (bitshift) {
+                /* Walk through the data and the crc and do
+                 * all the magic to get byte-aligned data.
                  */
-                return -EIO;
+                u8 *cp = t->rx_buf;
+                unsigned int len;
+                unsigned int bitright = 8 - bitshift;
+                u8 temp;
+                for (len = t->len; len; len--) {
+                        temp = *cp;
+                        *cp++ = leftover | (temp >> bitshift);
+                        leftover = temp << bitright;
+                }
+                cp = (u8 *) &scratch->crc_val;
+                temp = *cp;
+                *cp++ = leftover | (temp >> bitshift);
+                leftover = temp << bitright;
+                temp = *cp;
+                *cp = leftover | (temp >> bitshift);
         }
 
         if (host->mmc->use_spi_crc) {
@@ -803,7 +880,7 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd,
         unsigned                n_sg;
         int                     multiple = (data->blocks > 1);
         u32                     clock_rate;
-        ktime_t                 timeout;
+        unsigned long           timeout;
 
         if (data->flags & MMC_DATA_READ)
                 direction = DMA_FROM_DEVICE;
@@ -817,8 +894,9 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd,
         else
                 clock_rate = spi->max_speed_hz;
 
-        timeout = ktime_add_ns(ktime_set(0, 0), data->timeout_ns +
-                        data->timeout_clks * 1000000 / clock_rate);
+        timeout = data->timeout_ns +
+                  data->timeout_clks * 1000000 / clock_rate;
+        timeout = usecs_to_jiffies((unsigned int)(timeout / 1000)) + 1;
 
         /* Handle scatterlist segments one at a time, with synch for
          * each 512-byte block
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index d183be6f2a5f..e62a22a7f00c 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -298,7 +298,6 @@ mmc_omap_xfer_done(struct mmc_omap_host *host, struct mmc_data *data)
                 struct mmc_request *mrq = host->mrq;
 
                 host->mrq = NULL;
-                mmc_omap_fclk_lazy_disable(host);
                 mmc_request_done(host->mmc, mrq);
                 return;
         }
@@ -434,6 +433,8 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
         if (host->mrq == NULL) {
                 OMAP_HSMMC_WRITE(host->base, STAT,
                         OMAP_HSMMC_READ(host->base, STAT));
+                /* Flush posted write */
+                OMAP_HSMMC_READ(host->base, STAT);
                 return IRQ_HANDLED;
         }
 
@@ -489,8 +490,10 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
         }
 
         OMAP_HSMMC_WRITE(host->base, STAT, status);
+        /* Flush posted write */
+        OMAP_HSMMC_READ(host->base, STAT);
 
-        if (end_cmd || (status & CC))
+        if (end_cmd || ((status & CC) && host->cmd))
                 mmc_omap_cmd_done(host, host->cmd);
         if (end_trans || (status & TC))
                 mmc_omap_xfer_done(host, data);
diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index c5b316e22371..cd37962ec44f 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -729,6 +729,6 @@ static void __exit sdhci_drv_exit(void)
 module_init(sdhci_drv_init);
 module_exit(sdhci_drv_exit);
 
-MODULE_AUTHOR("Pierre Ossman <drzeus@drzeus.cx>");
+MODULE_AUTHOR("Pierre Ossman <pierre@ossman.eu>");
 MODULE_DESCRIPTION("Secure Digital Host Controller Interface PCI driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 30d8e3d4e6fd..9234be2226e7 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1935,7 +1935,7 @@ module_exit(sdhci_drv_exit);
 
 module_param(debug_quirks, uint, 0444);
 
-MODULE_AUTHOR("Pierre Ossman <drzeus@drzeus.cx>");
+MODULE_AUTHOR("Pierre Ossman <pierre@ossman.eu>");
 MODULE_DESCRIPTION("Secure Digital Host Controller Interface core driver");
 MODULE_LICENSE("GPL");
 
diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
index adda37952032..89bf8cd25cac 100644
--- a/drivers/mmc/host/wbsd.c
+++ b/drivers/mmc/host/wbsd.c
@@ -2036,7 +2036,7 @@ module_param_named(irq, param_irq, uint, 0444);
 module_param_named(dma, param_dma, int, 0444);
 
 MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Pierre Ossman <drzeus@drzeus.cx>");
+MODULE_AUTHOR("Pierre Ossman <pierre@ossman.eu>");
 MODULE_DESCRIPTION("Winbond W83L51xD SD/MMC card interface driver");
 
 #ifdef CONFIG_PNP
diff --git a/drivers/net/mlx4/port.c b/drivers/net/mlx4/port.c
index 7cce3342ef8c..606aa58afdea 100644
--- a/drivers/net/mlx4/port.c
+++ b/drivers/net/mlx4/port.c
@@ -299,13 +299,14 @@ int mlx4_SET_PORT(struct mlx4_dev *dev, u8 port)
         struct mlx4_cmd_mailbox *mailbox;
         int err;
 
+        if (dev->caps.port_type[port] == MLX4_PORT_TYPE_ETH)
+                return 0;
+
         mailbox = mlx4_alloc_cmd_mailbox(dev);
         if (IS_ERR(mailbox))
                 return PTR_ERR(mailbox);
 
         memset(mailbox->buf, 0, 256);
-        if (dev->caps.port_type[port] == MLX4_PORT_TYPE_ETH)
-                return 0;
 
         ((__be32 *) mailbox->buf)[1] = dev->caps.ib_port_def_cap[port];
         err = mlx4_cmd(dev, mailbox->dma, port, 0, MLX4_CMD_SET_PORT,
diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
index 912308eec865..329f890e2903 100644
--- a/drivers/net/smc91x.h
+++ b/drivers/net/smc91x.h
@@ -369,7 +369,7 @@ static inline void LPD7_SMC_outsw (unsigned char* a, int r,
  * MN10300/AM33 configuration
  */
 
-#include <asm/unit/smc91111.h>
+#include <unit/smc91111.h>
 
 #else
 
diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index 25a00ce4f24d..fa3a11365ec3 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -173,12 +173,21 @@ dmar_parse_one_drhd(struct acpi_dmar_header *header)
         struct dmar_drhd_unit *dmaru;
         int ret = 0;
 
+        drhd = (struct acpi_dmar_hardware_unit *)header;
+        if (!drhd->address) {
+                /* Promote an attitude of violence to a BIOS engineer today */
+                WARN(1, "Your BIOS is broken; DMAR reported at address zero!\n"
+                     "BIOS vendor: %s; Ver: %s; Product Version: %s\n",
+                     dmi_get_system_info(DMI_BIOS_VENDOR),
+                     dmi_get_system_info(DMI_BIOS_VERSION),
+                     dmi_get_system_info(DMI_PRODUCT_VERSION));
+                return -ENODEV;
+        }
         dmaru = kzalloc(sizeof(*dmaru), GFP_KERNEL);
         if (!dmaru)
                 return -ENOMEM;
 
         dmaru->hdr = header;
-        drhd = (struct acpi_dmar_hardware_unit *)header;
         dmaru->reg_base_addr = drhd->address;
         dmaru->segment = drhd->segment;
         dmaru->include_all = drhd->flags & 0x1; /* BIT0: INCLUDE_ALL */
diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
index fb3a3f3fca7a..001b328adf80 100644
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -733,8 +733,8 @@ static void dma_pte_clear_range(struct dmar_domain *domain, u64 start, u64 end)
         start &= (((u64)1) << addr_width) - 1;
         end &= (((u64)1) << addr_width) - 1;
         /* in case it's partial page */
-        start = PAGE_ALIGN(start);
-        end &= PAGE_MASK;
+        start &= PAGE_MASK;
+        end = PAGE_ALIGN(end);
         npages = (end - start) / VTD_PAGE_SIZE;
 
         /* we don't need lock here, nobody else touches the iova range */
diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 45940f31fe9e..218b9a16ac3f 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -174,8 +174,7 @@ struct fujitsu_hotkey_t {
 
 static struct fujitsu_hotkey_t *fujitsu_hotkey;
 
-static void acpi_fujitsu_hotkey_notify(acpi_handle handle, u32 event,
-                                       void *data);
+static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event);
 
 #ifdef CONFIG_LEDS_CLASS
 static enum led_brightness logolamp_get(struct led_classdev *cdev);
@@ -203,7 +202,7 @@ struct led_classdev kblamps_led = {
 static u32 dbg_level = 0x03;
 #endif
 
-static void acpi_fujitsu_notify(acpi_handle handle, u32 event, void *data);
+static void acpi_fujitsu_notify(struct acpi_device *device, u32 event);
 
 /* Fujitsu ACPI interface function */
 
@@ -658,7 +657,6 @@ static struct dmi_system_id fujitsu_dmi_table[] = {
 
 static int acpi_fujitsu_add(struct acpi_device *device)
 {
-        acpi_status status;
         acpi_handle handle;
         int result = 0;
         int state = 0;
@@ -673,20 +671,10 @@ static int acpi_fujitsu_add(struct acpi_device *device)
         sprintf(acpi_device_class(device), "%s", ACPI_FUJITSU_CLASS);
         device->driver_data = fujitsu;
 
-        status = acpi_install_notify_handler(device->handle,
-                                             ACPI_DEVICE_NOTIFY,
-                                             acpi_fujitsu_notify, fujitsu);
-
-        if (ACPI_FAILURE(status)) {
-                printk(KERN_ERR "Error installing notify handler\n");
-                error = -ENODEV;
-                goto err_stop;
-        }
-
         fujitsu->input = input = input_allocate_device();
         if (!input) {
                 error = -ENOMEM;
-                goto err_uninstall_notify;
+                goto err_stop;
         }
 
         snprintf(fujitsu->phys, sizeof(fujitsu->phys),
@@ -743,9 +731,6 @@ static int acpi_fujitsu_add(struct acpi_device *device)
 end:
 err_free_input_dev:
         input_free_device(input);
-err_uninstall_notify:
-        acpi_remove_notify_handler(device->handle, ACPI_DEVICE_NOTIFY,
-                                   acpi_fujitsu_notify);
 err_stop:
 
         return result;
@@ -753,7 +738,6 @@ err_stop:
 
 static int acpi_fujitsu_remove(struct acpi_device *device, int type)
 {
-        acpi_status status;
         struct fujitsu_t *fujitsu = NULL;
 
         if (!device || !acpi_driver_data(device))
@@ -761,10 +745,6 @@ static int acpi_fujitsu_remove(struct acpi_device *device, int type)
 
         fujitsu = acpi_driver_data(device);
 
-        status = acpi_remove_notify_handler(fujitsu->acpi_handle,
-                                            ACPI_DEVICE_NOTIFY,
-                                            acpi_fujitsu_notify);
-
         if (!device || !acpi_driver_data(device))
                 return -EINVAL;
 
@@ -775,7 +755,7 @@ static int acpi_fujitsu_remove(struct acpi_device *device, int type)
 
 /* Brightness notify */
 
-static void acpi_fujitsu_notify(acpi_handle handle, u32 event, void *data)
+static void acpi_fujitsu_notify(struct acpi_device *device, u32 event)
 {
         struct input_dev *input;
         int keycode;
@@ -829,15 +809,12 @@ static void acpi_fujitsu_notify(acpi_handle handle, u32 event, void *data)
                 input_report_key(input, keycode, 0);
                 input_sync(input);
         }
-
-        return;
 }
 
 /* ACPI device for hotkey handling */
 
 static int acpi_fujitsu_hotkey_add(struct acpi_device *device)
 {
-        acpi_status status;
         acpi_handle handle;
         int result = 0;
         int state = 0;
@@ -854,17 +831,6 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device)
         sprintf(acpi_device_class(device), "%s", ACPI_FUJITSU_CLASS);
         device->driver_data = fujitsu_hotkey;
 
-        status = acpi_install_notify_handler(device->handle,
-                                             ACPI_DEVICE_NOTIFY,
-                                             acpi_fujitsu_hotkey_notify,
-                                             fujitsu_hotkey);
-
-        if (ACPI_FAILURE(status)) {
-                printk(KERN_ERR "Error installing notify handler\n");
-                error = -ENODEV;
-                goto err_stop;
-        }
-
         /* kfifo */
         spin_lock_init(&fujitsu_hotkey->fifo_lock);
         fujitsu_hotkey->fifo =
@@ -879,7 +845,7 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device)
         fujitsu_hotkey->input = input = input_allocate_device();
         if (!input) {
                 error = -ENOMEM;
-                goto err_uninstall_notify;
+                goto err_free_fifo;
         }
 
         snprintf(fujitsu_hotkey->phys, sizeof(fujitsu_hotkey->phys),
@@ -975,9 +941,7 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device)
 end:
 err_free_input_dev:
         input_free_device(input);
-err_uninstall_notify:
-        acpi_remove_notify_handler(device->handle, ACPI_DEVICE_NOTIFY,
-                                   acpi_fujitsu_hotkey_notify);
+err_free_fifo:
         kfifo_free(fujitsu_hotkey->fifo);
 err_stop:
 
@@ -986,7 +950,6 @@ err_stop:
 
 static int acpi_fujitsu_hotkey_remove(struct acpi_device *device, int type)
 {
-        acpi_status status;
         struct fujitsu_hotkey_t *fujitsu_hotkey = NULL;
 
         if (!device || !acpi_driver_data(device))
@@ -994,10 +957,6 @@ static int acpi_fujitsu_hotkey_remove(struct acpi_device *device, int type)
 
         fujitsu_hotkey = acpi_driver_data(device);
 
-        status = acpi_remove_notify_handler(fujitsu_hotkey->acpi_handle,
-                                            ACPI_DEVICE_NOTIFY,
-                                            acpi_fujitsu_hotkey_notify);
-
         fujitsu_hotkey->acpi_handle = NULL;
 
         kfifo_free(fujitsu_hotkey->fifo);
@@ -1005,8 +964,7 @@ static int acpi_fujitsu_hotkey_remove(struct acpi_device *device, int type)
         return 0;
 }
 
-static void acpi_fujitsu_hotkey_notify(acpi_handle handle, u32 event,
-                                       void *data)
+static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event)
 {
         struct input_dev *input;
         int keycode, keycode_r;
@@ -1089,8 +1047,6 @@ static void acpi_fujitsu_hotkey_notify(acpi_handle handle, u32 event,
                 input_sync(input);
                 break;
         }
-
-        return;
 }
 
 /* Initialization */
@@ -1107,6 +1063,7 @@ static struct acpi_driver acpi_fujitsu_driver = {
         .ops = {
                 .add = acpi_fujitsu_add,
                 .remove = acpi_fujitsu_remove,
+                .notify = acpi_fujitsu_notify,
                 },
 };
 
@@ -1122,6 +1079,7 @@ static struct acpi_driver acpi_fujitsu_hotkey_driver = {
         .ops = {
                 .add = acpi_fujitsu_hotkey_add,
                 .remove = acpi_fujitsu_hotkey_remove,
+                .notify = acpi_fujitsu_hotkey_notify,
                 },
 };
 
diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c
index a5ce4bc202e3..fe7cf0188acc 100644
--- a/drivers/platform/x86/panasonic-laptop.c
+++ b/drivers/platform/x86/panasonic-laptop.c
@@ -176,6 +176,7 @@ enum SINF_BITS { SINF_NUM_BATTERIES = 0,
 static int acpi_pcc_hotkey_add(struct acpi_device *device);
 static int acpi_pcc_hotkey_remove(struct acpi_device *device, int type);
 static int acpi_pcc_hotkey_resume(struct acpi_device *device);
+static void acpi_pcc_hotkey_notify(struct acpi_device *device, u32 event);
 
 static const struct acpi_device_id pcc_device_ids[] = {
         { "MAT0012", 0},
@@ -194,6 +195,7 @@ static struct acpi_driver acpi_pcc_driver = {
                                 .add =          acpi_pcc_hotkey_add,
                                 .remove =       acpi_pcc_hotkey_remove,
                                 .resume =       acpi_pcc_hotkey_resume,
+                                .notify =       acpi_pcc_hotkey_notify,
                         },
 };
 
@@ -271,7 +273,7 @@ static int acpi_pcc_retrieve_biosdata(struct pcc_acpi *pcc, u32 *sinf)
         union acpi_object *hkey = NULL;
         int i;
 
-        status = acpi_evaluate_object(pcc->handle, METHOD_HKEY_SINF, 0,
+        status = acpi_evaluate_object(pcc->handle, METHOD_HKEY_SINF, NULL,
                                       &buffer);
         if (ACPI_FAILURE(status)) {
                 ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
@@ -527,9 +529,9 @@ static void acpi_pcc_generate_keyinput(struct pcc_acpi *pcc)
         return;
 }
 
-static void acpi_pcc_hotkey_notify(acpi_handle handle, u32 event, void *data)
+static void acpi_pcc_hotkey_notify(struct acpi_device *device, u32 event)
 {
-        struct pcc_acpi *pcc = (struct pcc_acpi *) data;
+        struct pcc_acpi *pcc = acpi_driver_data(device);
 
         switch (event) {
         case HKEY_NOTIFY:
@@ -599,7 +601,6 @@ static int acpi_pcc_hotkey_resume(struct acpi_device *device)
 
 static int acpi_pcc_hotkey_add(struct acpi_device *device)
 {
-        acpi_status status;
         struct pcc_acpi *pcc;
         int num_sifr, result;
 
@@ -640,22 +641,11 @@ static int acpi_pcc_hotkey_add(struct acpi_device *device)
                 goto out_sinf;
         }
 
-        /* initialize hotkey input device */
-        status = acpi_install_notify_handler(pcc->handle, ACPI_DEVICE_NOTIFY,
-                                             acpi_pcc_hotkey_notify, pcc);
-
-        if (ACPI_FAILURE(status)) {
-                ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
-                                  "Error installing notify handler\n"));
-                result = -ENODEV;
-                goto out_input;
-        }
-
         /* initialize backlight */
         pcc->backlight = backlight_device_register("panasonic", NULL, pcc,
                                                    &pcc_backlight_ops);
         if (IS_ERR(pcc->backlight))
-                goto out_notify;
+                goto out_input;
 
         if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf)) {
                 ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
@@ -680,9 +670,6 @@ static int acpi_pcc_hotkey_add(struct acpi_device *device)
 
 out_backlight:
         backlight_device_unregister(pcc->backlight);
-out_notify:
-        acpi_remove_notify_handler(pcc->handle, ACPI_DEVICE_NOTIFY,
-                                   acpi_pcc_hotkey_notify);
 out_input:
         input_unregister_device(pcc->input_dev);
         /* no need to input_free_device() since core input API refcount and
@@ -723,9 +710,6 @@ static int acpi_pcc_hotkey_remove(struct acpi_device *device, int type)
 
         backlight_device_unregister(pcc->backlight);
 
-        acpi_remove_notify_handler(pcc->handle, ACPI_DEVICE_NOTIFY,
-                                   acpi_pcc_hotkey_notify);
-
         input_unregister_device(pcc->input_dev);
         /* no need to input_free_device() since core input API refcount and
          * free()s the device */
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index a90ec5cb2f20..d3c92d777bde 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -914,7 +914,7 @@ static struct sony_nc_event sony_127_events[] = {
 /*
  * ACPI callbacks
  */
-static void sony_acpi_notify(acpi_handle handle, u32 event, void *data)
+static void sony_nc_notify(struct acpi_device *device, u32 event)
 {
         u32 ev = event;
 
@@ -933,7 +933,7 @@ static void sony_acpi_notify(acpi_handle handle, u32 event, void *data)
                         struct sony_nc_event *key_event;
 
                         if (sony_call_snc_handle(key_handle, 0x200, &result)) {
-                                dprintk("sony_acpi_notify, unable to decode"
+                                dprintk("sony_nc_notify, unable to decode"
                                         " event 0x%.2x 0x%.2x\n", key_handle,
                                         ev);
                                 /* restore the original event */
@@ -968,7 +968,7 @@ static void sony_acpi_notify(acpi_handle handle, u32 event, void *data)
         } else
                 sony_laptop_report_input_event(ev);
 
-        dprintk("sony_acpi_notify, event: 0x%.2x\n", ev);
+        dprintk("sony_nc_notify, event: 0x%.2x\n", ev);
         acpi_bus_generate_proc_event(sony_nc_acpi_device, 1, ev);
 }
 
@@ -1276,15 +1276,6 @@ static int sony_nc_add(struct acpi_device *device)
                 goto outwalk;
         }
 
-        status = acpi_install_notify_handler(sony_nc_acpi_handle,
-                                             ACPI_DEVICE_NOTIFY,
-                                             sony_acpi_notify, NULL);
-        if (ACPI_FAILURE(status)) {
-                printk(KERN_WARNING DRV_PFX "unable to install notify handler (%u)\n", status);
-                result = -ENODEV;
-                goto outinput;
-        }
-
         if (acpi_video_backlight_support()) {
                 printk(KERN_INFO DRV_PFX "brightness ignored, must be "
                        "controlled by ACPI video driver\n");
@@ -1362,13 +1353,6 @@ static int sony_nc_add(struct acpi_device *device)
         if (sony_backlight_device)
                 backlight_device_unregister(sony_backlight_device);
 
-        status = acpi_remove_notify_handler(sony_nc_acpi_handle,
-                                            ACPI_DEVICE_NOTIFY,
-                                            sony_acpi_notify);
-        if (ACPI_FAILURE(status))
-                printk(KERN_WARNING DRV_PFX "unable to remove notify handler\n");
-
-      outinput:
         sony_laptop_remove_input();
 
       outwalk:
@@ -1378,7 +1362,6 @@ static int sony_nc_add(struct acpi_device *device)
 
 static int sony_nc_remove(struct acpi_device *device, int type)
 {
-        acpi_status status;
         struct sony_nc_value *item;
 
         if (sony_backlight_device)
@@ -1386,12 +1369,6 @@ static int sony_nc_remove(struct acpi_device *device, int type)
 
         sony_nc_acpi_device = NULL;
 
-        status = acpi_remove_notify_handler(sony_nc_acpi_handle,
-                                            ACPI_DEVICE_NOTIFY,
-                                            sony_acpi_notify);
-        if (ACPI_FAILURE(status))
-                printk(KERN_WARNING DRV_PFX "unable to remove notify handler\n");
-
         for (item = sony_nc_values; item->name; ++item) {
                 device_remove_file(&sony_pf_device->dev, &item->devattr);
         }
@@ -1425,6 +1402,7 @@ static struct acpi_driver sony_nc_driver = {
                 .add = sony_nc_add,
                 .remove = sony_nc_remove,
                 .resume = sony_nc_resume,
+                .notify = sony_nc_notify,
                 },
 };
 
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 2f269e117b8f..043b208d971d 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -81,6 +81,7 @@ static struct wmi_block wmi_blocks;
 
 static int acpi_wmi_remove(struct acpi_device *device, int type);
 static int acpi_wmi_add(struct acpi_device *device);
+static void acpi_wmi_notify(struct acpi_device *device, u32 event);
 
 static const struct acpi_device_id wmi_device_ids[] = {
         {"PNP0C14", 0},
@@ -96,6 +97,7 @@ static struct acpi_driver acpi_wmi_driver = {
         .ops = {
                 .add = acpi_wmi_add,
                 .remove = acpi_wmi_remove,
+                .notify = acpi_wmi_notify,
                 },
 };
 
@@ -643,12 +645,11 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,
         }
 }
 
-static void acpi_wmi_notify(acpi_handle handle, u32 event, void *data)
+static void acpi_wmi_notify(struct acpi_device *device, u32 event)
 {
         struct guid_block *block;
         struct wmi_block *wblock;
         struct list_head *p;
-        struct acpi_device *device = data;
 
         list_for_each(p, &wmi_blocks.list) {
                 wblock = list_entry(p, struct wmi_block, list);
@@ -669,9 +670,6 @@ static void acpi_wmi_notify(acpi_handle handle, u32 event, void *data)
 
 static int acpi_wmi_remove(struct acpi_device *device, int type)
 {
-        acpi_remove_notify_handler(device->handle, ACPI_DEVICE_NOTIFY,
-                acpi_wmi_notify);
-
         acpi_remove_address_space_handler(device->handle,
                                 ACPI_ADR_SPACE_EC, &acpi_wmi_ec_space_handler);
 
@@ -683,13 +681,6 @@ static int __init acpi_wmi_add(struct acpi_device *device)
         acpi_status status;
         int result = 0;
 
-        status = acpi_install_notify_handler(device->handle, ACPI_DEVICE_NOTIFY,
-                acpi_wmi_notify, device);
-        if (ACPI_FAILURE(status)) {
-                printk(KERN_ERR PREFIX "Error installing notify handler\n");
-                return -ENODEV;
-        }
-
         status = acpi_install_address_space_handler(device->handle,
                                                     ACPI_ADR_SPACE_EC,
                                                     &acpi_wmi_ec_space_handler,
diff --git a/drivers/power/pcf50633-charger.c b/drivers/power/pcf50633-charger.c
index 41aec2acbb91..e8b278f71781 100644
--- a/drivers/power/pcf50633-charger.c
+++ b/drivers/power/pcf50633-charger.c
@@ -36,6 +36,8 @@ struct pcf50633_mbc {
 
         struct power_supply usb;
         struct power_supply adapter;
+
+        struct delayed_work charging_restart_work;
 };
 
 int pcf50633_mbc_usb_curlim_set(struct pcf50633 *pcf, int ma)
@@ -43,6 +45,8 @@ int pcf50633_mbc_usb_curlim_set(struct pcf50633 *pcf, int ma)
         struct pcf50633_mbc *mbc = platform_get_drvdata(pcf->mbc_pdev);
         int ret = 0;
         u8 bits;
+        int charging_start = 1;
+        u8 mbcs2, chgmod;
 
         if (ma >= 1000)
                 bits = PCF50633_MBCC7_USB_1000mA;
@@ -50,8 +54,10 @@ int pcf50633_mbc_usb_curlim_set(struct pcf50633 *pcf, int ma)
                 bits = PCF50633_MBCC7_USB_500mA;
         else if (ma >= 100)
                 bits = PCF50633_MBCC7_USB_100mA;
-        else
+        else {
                 bits = PCF50633_MBCC7_USB_SUSPEND;
+                charging_start = 0;
+        }
 
         ret = pcf50633_reg_set_bit_mask(pcf, PCF50633_REG_MBCC7,
                                         PCF50633_MBCC7_USB_MASK, bits);
@@ -60,6 +66,22 @@ int pcf50633_mbc_usb_curlim_set(struct pcf50633 *pcf, int ma)
         else
                 dev_info(pcf->dev, "usb curlim to %d mA\n", ma);
 
+        /* Manual charging start */
+        mbcs2 = pcf50633_reg_read(pcf, PCF50633_REG_MBCS2);
+        chgmod = (mbcs2 & PCF50633_MBCS2_MBC_MASK);
+
+        /* If chgmod == BATFULL, setting chgena has no effect.
+         * We need to set resume instead.
+         */
+        if (chgmod != PCF50633_MBCS2_MBC_BAT_FULL)
+                pcf50633_reg_set_bit_mask(pcf, PCF50633_REG_MBCC1,
+                                PCF50633_MBCC1_CHGENA, PCF50633_MBCC1_CHGENA);
+        else
+                pcf50633_reg_set_bit_mask(pcf, PCF50633_REG_MBCC1,
+                                PCF50633_MBCC1_RESUME, PCF50633_MBCC1_RESUME);
+
+        mbc->usb_active = charging_start;
+
         power_supply_changed(&mbc->usb);
 
         return ret;
@@ -84,21 +106,6 @@ int pcf50633_mbc_get_status(struct pcf50633 *pcf)
 }
 EXPORT_SYMBOL_GPL(pcf50633_mbc_get_status);
 
-void pcf50633_mbc_set_status(struct pcf50633 *pcf, int what, int status)
-{
-        struct pcf50633_mbc *mbc = platform_get_drvdata(pcf->mbc_pdev);
-
-        if (what & PCF50633_MBC_USB_ONLINE)
-                mbc->usb_online = !!status;
-        if (what & PCF50633_MBC_USB_ACTIVE)
-                mbc->usb_active = !!status;
-        if (what & PCF50633_MBC_ADAPTER_ONLINE)
-                mbc->adapter_online = !!status;
-        if (what & PCF50633_MBC_ADAPTER_ACTIVE)
-                mbc->adapter_active = !!status;
-}
-EXPORT_SYMBOL_GPL(pcf50633_mbc_set_status);
-
 static ssize_t
 show_chgmode(struct device *dev, struct device_attribute *attr, char *buf)
 {
@@ -160,10 +167,44 @@ static struct attribute_group mbc_attr_group = {
         .attrs  = pcf50633_mbc_sysfs_entries,
 };
 
+/* MBC state machine switches into charging mode when the battery voltage
+ * falls below 96% of a battery float voltage. But the voltage drop in Li-ion
+ * batteries is marginal(1~2 %) till about 80% of its capacity - which means,
+ * after a BATFULL, charging won't be restarted until 80%.
+ *
+ * This work_struct function restarts charging at regular intervals to make
+ * sure we don't discharge too much
+ */
+
+static void pcf50633_mbc_charging_restart(struct work_struct *work)
+{
+        struct pcf50633_mbc *mbc;
+        u8 mbcs2, chgmod;
+
+        mbc = container_of(work, struct pcf50633_mbc,
+                                charging_restart_work.work);
+
+        mbcs2 = pcf50633_reg_read(mbc->pcf, PCF50633_REG_MBCS2);
+        chgmod = (mbcs2 & PCF50633_MBCS2_MBC_MASK);
+
+        if (chgmod != PCF50633_MBCS2_MBC_BAT_FULL)
+                return;
+
+        /* Restart charging */
+        pcf50633_reg_set_bit_mask(mbc->pcf, PCF50633_REG_MBCC1,
+                                PCF50633_MBCC1_RESUME, PCF50633_MBCC1_RESUME);
+        mbc->usb_active = 1;
+        power_supply_changed(&mbc->usb);
+
+        dev_info(mbc->pcf->dev, "Charging restarted\n");
+}
+
 static void
 pcf50633_mbc_irq_handler(int irq, void *data)
 {
         struct pcf50633_mbc *mbc = data;
+        int chg_restart_interval =
+                        mbc->pcf->pdata->charging_restart_interval;
 
         /* USB */
         if (irq == PCF50633_IRQ_USBINS) {
@@ -172,6 +213,7 @@ pcf50633_mbc_irq_handler(int irq, void *data)
                 mbc->usb_online = 0;
                 mbc->usb_active = 0;
                 pcf50633_mbc_usb_curlim_set(mbc->pcf, 0);
+                cancel_delayed_work_sync(&mbc->charging_restart_work);
         }
 
         /* Adapter */
@@ -186,7 +228,14 @@ pcf50633_mbc_irq_handler(int irq, void *data)
         if (irq == PCF50633_IRQ_BATFULL) {
                 mbc->usb_active = 0;
                 mbc->adapter_active = 0;
-        }
+
+                if (chg_restart_interval > 0)
+                        schedule_delayed_work(&mbc->charging_restart_work,
+                                                        chg_restart_interval);
+        } else if (irq == PCF50633_IRQ_USBLIMON)
+                mbc->usb_active = 0;
+        else if (irq == PCF50633_IRQ_USBLIMOFF)
+                mbc->usb_active = 1;
 
         power_supply_changed(&mbc->usb);
         power_supply_changed(&mbc->adapter);
@@ -303,6 +352,9 @@ static int __devinit pcf50633_mbc_probe(struct platform_device *pdev)
                 return ret;
         }
 
+        INIT_DELAYED_WORK(&mbc->charging_restart_work,
+                                pcf50633_mbc_charging_restart);
+
         ret = sysfs_create_group(&pdev->dev.kobj, &mbc_attr_group);
         if (ret)
                 dev_err(mbc->pcf->dev, "failed to create sysfs entries\n");
@@ -328,6 +380,8 @@ static int __devexit pcf50633_mbc_remove(struct platform_device *pdev)
         power_supply_unregister(&mbc->usb);
         power_supply_unregister(&mbc->adapter);
 
+        cancel_delayed_work_sync(&mbc->charging_restart_work);
+
         kfree(mbc);
 
         return 0;
diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
index b56a704409d2..a232de6a5703 100644
--- a/drivers/power/pda_power.c
+++ b/drivers/power/pda_power.c
@@ -12,11 +12,14 @@
 
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/err.h>
 #include <linux/interrupt.h>
 #include <linux/power_supply.h>
 #include <linux/pda_power.h>
+#include <linux/regulator/consumer.h>
 #include <linux/timer.h>
 #include <linux/jiffies.h>
+#include <linux/usb/otg.h>
 
 static inline unsigned int get_irq_flags(struct resource *res)
 {
@@ -35,6 +38,11 @@ static struct timer_list supply_timer;
 static struct timer_list polling_timer;
 static int polling;
 
+#ifdef CONFIG_USB_OTG_UTILS
+static struct otg_transceiver *transceiver;
+#endif
+static struct regulator *ac_draw;
+
 enum {
         PDA_PSY_OFFLINE = 0,
         PDA_PSY_ONLINE = 1,
@@ -104,18 +112,35 @@ static void update_status(void)
 
 static void update_charger(void)
 {
-        if (!pdata->set_charge)
-                return;
-
-        if (new_ac_status > 0) {
-                dev_dbg(dev, "charger on (AC)\n");
-                pdata->set_charge(PDA_POWER_CHARGE_AC);
-        } else if (new_usb_status > 0) {
-                dev_dbg(dev, "charger on (USB)\n");
-                pdata->set_charge(PDA_POWER_CHARGE_USB);
-        } else {
-                dev_dbg(dev, "charger off\n");
-                pdata->set_charge(0);
+        static int regulator_enabled;
+        int max_uA = pdata->ac_max_uA;
+
+        if (pdata->set_charge) {
+                if (new_ac_status > 0) {
+                        dev_dbg(dev, "charger on (AC)\n");
+                        pdata->set_charge(PDA_POWER_CHARGE_AC);
+                } else if (new_usb_status > 0) {
+                        dev_dbg(dev, "charger on (USB)\n");
+                        pdata->set_charge(PDA_POWER_CHARGE_USB);
+                } else {
+                        dev_dbg(dev, "charger off\n");
+                        pdata->set_charge(0);
+                }
+        } else if (ac_draw) {
+                if (new_ac_status > 0) {
+                        regulator_set_current_limit(ac_draw, max_uA, max_uA);
+                        if (!regulator_enabled) {
+                                dev_dbg(dev, "charger on (AC)\n");
+                                regulator_enable(ac_draw);
+                                regulator_enabled = 1;
+                        }
+                } else {
+                        if (regulator_enabled) {
+                                dev_dbg(dev, "charger off\n");
+                                regulator_disable(ac_draw);
+                                regulator_enabled = 0;
+                        }
+                }
         }
 }
 
@@ -194,6 +219,13 @@ static void polling_timer_func(unsigned long unused)
                   jiffies + msecs_to_jiffies(pdata->polling_interval));
 }
 
+#ifdef CONFIG_USB_OTG_UTILS
+static int otg_is_usb_online(void)
+{
+        return (transceiver->state == OTG_STATE_B_PERIPHERAL);
+}
+#endif
+
 static int pda_power_probe(struct platform_device *pdev)
 {
         int ret = 0;
@@ -227,6 +259,9 @@ static int pda_power_probe(struct platform_device *pdev)
         if (!pdata->polling_interval)
                 pdata->polling_interval = 2000;
 
+        if (!pdata->ac_max_uA)
+                pdata->ac_max_uA = 500000;
+
         setup_timer(&charger_timer, charger_timer_func, 0);
         setup_timer(&supply_timer, supply_timer_func, 0);
 
@@ -240,6 +275,13 @@ static int pda_power_probe(struct platform_device *pdev)
                 pda_psy_usb.num_supplicants = pdata->num_supplicants;
         }
 
+        ac_draw = regulator_get(dev, "ac_draw");
+        if (IS_ERR(ac_draw)) {
+                dev_dbg(dev, "couldn't get ac_draw regulator\n");
+                ac_draw = NULL;
+                ret = PTR_ERR(ac_draw);
+        }
+
         if (pdata->is_ac_online) {
                 ret = power_supply_register(&pdev->dev, &pda_psy_ac);
                 if (ret) {
@@ -261,6 +303,13 @@ static int pda_power_probe(struct platform_device *pdev)
                 }
         }
 
+#ifdef CONFIG_USB_OTG_UTILS
+        transceiver = otg_get_transceiver();
+        if (transceiver && !pdata->is_usb_online) {
+                pdata->is_usb_online = otg_is_usb_online;
+        }
+#endif
+
         if (pdata->is_usb_online) {
                 ret = power_supply_register(&pdev->dev, &pda_psy_usb);
                 if (ret) {
@@ -300,10 +349,18 @@ usb_irq_failed:
 usb_supply_failed:
         if (pdata->is_ac_online && ac_irq)
                 free_irq(ac_irq->start, &pda_psy_ac);
+#ifdef CONFIG_USB_OTG_UTILS
+        if (transceiver)
+                otg_put_transceiver(transceiver);
+#endif
 ac_irq_failed:
         if (pdata->is_ac_online)
                 power_supply_unregister(&pda_psy_ac);
 ac_supply_failed:
+        if (ac_draw) {
+                regulator_put(ac_draw);
+                ac_draw = NULL;
+        }
         if (pdata->exit)
                 pdata->exit(dev);
 init_failed:
@@ -327,6 +384,14 @@ static int pda_power_remove(struct platform_device *pdev)
                 power_supply_unregister(&pda_psy_usb);
         if (pdata->is_ac_online)
                 power_supply_unregister(&pda_psy_ac);
+#ifdef CONFIG_USB_OTG_UTILS
+        if (transceiver)
+                otg_put_transceiver(transceiver);
+#endif
+        if (ac_draw) {
+                regulator_put(ac_draw);
+                ac_draw = NULL;
+        }
         if (pdata->exit)
                 pdata->exit(dev);
 
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 687dcf2d0154..5defe5ea5eda 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -1663,7 +1663,7 @@ qla1280_load_firmware_pio(struct scsi_qla_host *ha)
 
         /* Load RISC code. */
         risc_address = ha->fwstart;
-        fw_data = (const __le16 *)&fw->data[4];
+        fw_data = (const __le16 *)&fw->data[6];
         risc_code_size = (fw->size - 6) / 2;
 
         for (i = 0; i < risc_code_size; i++) {
@@ -1722,7 +1722,7 @@ qla1280_load_firmware_dma(struct scsi_qla_host *ha)
 
         /* Load RISC code. */
         risc_address = ha->fwstart;
-        fw_data = (const __le16 *)&fw->data[4];
+        fw_data = (const __le16 *)&fw->data[6];
         risc_code_size = (fw->size - 6) / 2;
 
         dprintk(1, "%s: DMA RISC code (%i) words\n",
diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
index e1850904ff73..fbc83bebdd8e 100644
--- a/drivers/scsi/scsi_priv.h
+++ b/drivers/scsi/scsi_priv.h
@@ -38,9 +38,6 @@ static inline void scsi_log_completion(struct scsi_cmnd *cmd, int disposition)
         { };
 #endif
 
-/* scsi_scan.c */
-int scsi_complete_async_scans(void);
-
 /* scsi_devinfo.c */
 extern int scsi_get_device_flags(struct scsi_device *sdev,
                                  const unsigned char *vendor,
diff --git a/drivers/scsi/scsi_wait_scan.c b/drivers/scsi/scsi_wait_scan.c
index 8a636103083d..2f21af21269a 100644
--- a/drivers/scsi/scsi_wait_scan.c
+++ b/drivers/scsi/scsi_wait_scan.c
@@ -11,7 +11,7 @@
  */
 
 #include <linux/module.h>
-#include "scsi_priv.h"
+#include <scsi/scsi_scan.h>
 
 static int __init wait_scan_init(void)
 {
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 0328fd4006e5..343e3a35b6a3 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -854,7 +854,7 @@ config SERIAL_IMX_CONSOLE
 
 config SERIAL_UARTLITE
         tristate "Xilinx uartlite serial port support"
-        depends on PPC32
+        depends on PPC32 || MICROBLAZE
         select SERIAL_CORE
         help
           Say Y here if you want to use the Xilinx uartlite serial controller.
@@ -1340,7 +1340,7 @@ config SERIAL_NETX_CONSOLE
 
 config SERIAL_OF_PLATFORM
         tristate "Serial port on Open Firmware platform bus"
-        depends on PPC_OF
+        depends on PPC_OF || MICROBLAZE
         depends on SERIAL_8250 || SERIAL_OF_PLATFORM_NWPSERIAL
         help
           If you have a PowerPC based system that has serial ports
diff --git a/drivers/serial/max3100.c b/drivers/serial/max3100.c
new file mode 100644
index 000000000000..9fd33e5622bd
--- /dev/null
+++ b/drivers/serial/max3100.c
@@ -0,0 +1,927 @@
+/*
+ *
+ *  Copyright (C) 2008 Christian Pellegrin <chripell@evolware.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ *
+ * Notes: the MAX3100 doesn't provide an interrupt on CTS so we have
+ * to use polling for flow control. TX empty IRQ is unusable, since
+ * writing conf clears FIFO buffer and we cannot have this interrupt
+ * always asking us for attention.
+ *
+ * Example platform data:
+
+ static struct plat_max3100 max3100_plat_data = {
+ .loopback = 0,
+ .crystal = 0,
+ .poll_time = 100,
+ };
+
+ static struct spi_board_info spi_board_info[] = {
+ {
+ .modalias      = "max3100",
+ .platform_data = &max3100_plat_data,
+ .irq           = IRQ_EINT12,
+ .max_speed_hz  = 5*1000*1000,
+ .chip_select   = 0,
+ },
+ };
+
+ * The initial minor number is 209 in the low-density serial port:
+ * mknod /dev/ttyMAX0 c 204 209
+ */
+
+#define MAX3100_MAJOR 204
+#define MAX3100_MINOR 209
+/* 4 MAX3100s should be enough for everyone */
+#define MAX_MAX3100 4
+
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/serial_core.h>
+#include <linux/serial.h>
+#include <linux/spi/spi.h>
+#include <linux/freezer.h>
+
+#include <linux/serial_max3100.h>
+
+#define MAX3100_C    (1<<14)
+#define MAX3100_D    (0<<14)
+#define MAX3100_W    (1<<15)
+#define MAX3100_RX   (0<<15)
+
+#define MAX3100_WC   (MAX3100_W  | MAX3100_C)
+#define MAX3100_RC   (MAX3100_RX | MAX3100_C)
+#define MAX3100_WD   (MAX3100_W  | MAX3100_D)
+#define MAX3100_RD   (MAX3100_RX | MAX3100_D)
+#define MAX3100_CMD  (3 << 14)
+
+#define MAX3100_T    (1<<14)
+#define MAX3100_R    (1<<15)
+
+#define MAX3100_FEN  (1<<13)
+#define MAX3100_SHDN (1<<12)
+#define MAX3100_TM   (1<<11)
+#define MAX3100_RM   (1<<10)
+#define MAX3100_PM   (1<<9)
+#define MAX3100_RAM  (1<<8)
+#define MAX3100_IR   (1<<7)
+#define MAX3100_ST   (1<<6)
+#define MAX3100_PE   (1<<5)
+#define MAX3100_L    (1<<4)
+#define MAX3100_BAUD (0xf)
+
+#define MAX3100_TE   (1<<10)
+#define MAX3100_RAFE (1<<10)
+#define MAX3100_RTS  (1<<9)
+#define MAX3100_CTS  (1<<9)
+#define MAX3100_PT   (1<<8)
+#define MAX3100_DATA (0xff)
+
+#define MAX3100_RT   (MAX3100_R | MAX3100_T)
+#define MAX3100_RTC  (MAX3100_RT | MAX3100_CTS | MAX3100_RAFE)
+
+/* the following simulate a status reg for ignore_status_mask */
+#define MAX3100_STATUS_PE 1
+#define MAX3100_STATUS_FE 2
+#define MAX3100_STATUS_OE 4
+
+struct max3100_port {
+        struct uart_port port;
+        struct spi_device *spi;
+
+        int cts;                /* last CTS received for flow ctrl */
+        int tx_empty;           /* last TX empty bit */
+
+        spinlock_t conf_lock;   /* shared data */
+        int conf_commit;        /* need to make changes */
+        int conf;               /* configuration for the MAX31000
+                                 * (bits 0-7, bits 8-11 are irqs) */
+        int rts_commit;         /* need to change rts */
+        int rts;                /* rts status */
+        int baud;               /* current baud rate */
+
+        int parity;             /* keeps track if we should send parity */
+#define MAX3100_PARITY_ON 1
+#define MAX3100_PARITY_ODD 2
+#define MAX3100_7BIT 4
+        int rx_enabled;         /* if we should rx chars */
+
+        int irq;                /* irq assigned to the max3100 */
+
+        int minor;              /* minor number */
+        int crystal;            /* 1 if 3.6864Mhz crystal 0 for 1.8432 */
+        int loopback;           /* 1 if we are in loopback mode */
+
+        /* for handling irqs: need workqueue since we do spi_sync */
+        struct workqueue_struct *workqueue;
+        struct work_struct work;
+        /* set to 1 to make the workhandler exit as soon as possible */
+        int  force_end_work;
+        /* need to know we are suspending to avoid deadlock on workqueue */
+        int suspending;
+
+        /* hook for suspending MAX3100 via dedicated pin */
+        void (*max3100_hw_suspend) (int suspend);
+
+        /* poll time (in ms) for ctrl lines */
+        int poll_time;
+        /* and its timer */
+        struct timer_list       timer;
+};
+
+static struct max3100_port *max3100s[MAX_MAX3100]; /* the chips */
+static DEFINE_MUTEX(max3100s_lock);                /* race on probe */
+
+static int max3100_do_parity(struct max3100_port *s, u16 c)
+{
+        int parity;
+
+        if (s->parity & MAX3100_PARITY_ODD)
+                parity = 1;
+        else
+                parity = 0;
+
+        if (s->parity & MAX3100_7BIT)
+                c &= 0x7f;
+        else
+                c &= 0xff;
+
+        parity = parity ^ (hweight8(c) & 1);
+        return parity;
+}
+
+static int max3100_check_parity(struct max3100_port *s, u16 c)
+{
+        return max3100_do_parity(s, c) == ((c >> 8) & 1);
+}
+
+static void max3100_calc_parity(struct max3100_port *s, u16 *c)
+{
+        if (s->parity & MAX3100_7BIT)
+                *c &= 0x7f;
+        else
+                *c &= 0xff;
+
+        if (s->parity & MAX3100_PARITY_ON)
+                *c |= max3100_do_parity(s, *c) << 8;
+}
+
+static void max3100_work(struct work_struct *w);
+
+static void max3100_dowork(struct max3100_port *s)
+{
+        if (!s->force_end_work && !work_pending(&s->work) &&
+            !freezing(current) && !s->suspending)
+                queue_work(s->workqueue, &s->work);
+}
+
+static void max3100_timeout(unsigned long data)
+{
+        struct max3100_port *s = (struct max3100_port *)data;
+
+        if (s->port.info) {
+                max3100_dowork(s);
+                mod_timer(&s->timer, jiffies + s->poll_time);
+        }
+}
+
+static int max3100_sr(struct max3100_port *s, u16 tx, u16 *rx)
+{
+        struct spi_message message;
+        u16 etx, erx;
+        int status;
+        struct spi_transfer tran = {
+                .tx_buf = &etx,
+                .rx_buf = &erx,
+                .len = 2,
+        };
+
+        etx = cpu_to_be16(tx);
+        spi_message_init(&message);
+        spi_message_add_tail(&tran, &message);
+        status = spi_sync(s->spi, &message);
+        if (status) {
+                dev_warn(&s->spi->dev, "error while calling spi_sync\n");
+                return -EIO;
+        }
+        *rx = be16_to_cpu(erx);
+        s->tx_empty = (*rx & MAX3100_T) > 0;
+        dev_dbg(&s->spi->dev, "%04x - %04x\n", tx, *rx);
+        return 0;
+}
+
+static int max3100_handlerx(struct max3100_port *s, u16 rx)
+{
+        unsigned int ch, flg, status = 0;
+        int ret = 0, cts;
+
+        if (rx & MAX3100_R && s->rx_enabled) {
+                dev_dbg(&s->spi->dev, "%s\n", __func__);
+                ch = rx & (s->parity & MAX3100_7BIT ? 0x7f : 0xff);
+                if (rx & MAX3100_RAFE) {
+                        s->port.icount.frame++;
+                        flg = TTY_FRAME;
+                        status |= MAX3100_STATUS_FE;
+                } else {
+                        if (s->parity & MAX3100_PARITY_ON) {
+                                if (max3100_check_parity(s, rx)) {
+                                        s->port.icount.rx++;
+                                        flg = TTY_NORMAL;
+                                } else {
+                                        s->port.icount.parity++;
+                                        flg = TTY_PARITY;
+                                        status |= MAX3100_STATUS_PE;
+                                }
+                        } else {
+                                s->port.icount.rx++;
+                                flg = TTY_NORMAL;
+                        }
+                }
+                uart_insert_char(&s->port, status, MAX3100_STATUS_OE, ch, flg);
+                ret = 1;
+        }
+
+        cts = (rx & MAX3100_CTS) > 0;
+        if (s->cts != cts) {
+                s->cts = cts;
+                uart_handle_cts_change(&s->port, cts ? TIOCM_CTS : 0);
+        }
+
+        return ret;
+}
+
+static void max3100_work(struct work_struct *w)
+{
+        struct max3100_port *s = container_of(w, struct max3100_port, work);
+        int rxchars;
+        u16 tx, rx;
+        int conf, cconf, rts, crts;
+        struct circ_buf *xmit = &s->port.info->xmit;
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        rxchars = 0;
+        do {
+                spin_lock(&s->conf_lock);
+                conf = s->conf;
+                cconf = s->conf_commit;
+                s->conf_commit = 0;
+                rts = s->rts;
+                crts = s->rts_commit;
+                s->rts_commit = 0;
+                spin_unlock(&s->conf_lock);
+                if (cconf)
+                        max3100_sr(s, MAX3100_WC | conf, &rx);
+                if (crts) {
+                        max3100_sr(s, MAX3100_WD | MAX3100_TE |
+                                   (s->rts ? MAX3100_RTS : 0), &rx);
+                        rxchars += max3100_handlerx(s, rx);
+                }
+
+                max3100_sr(s, MAX3100_RD, &rx);
+                rxchars += max3100_handlerx(s, rx);
+
+                if (rx & MAX3100_T) {
+                        tx = 0xffff;
+                        if (s->port.x_char) {
+                                tx = s->port.x_char;
+                                s->port.icount.tx++;
+                                s->port.x_char = 0;
+                        } else if (!uart_circ_empty(xmit) &&
+                                   !uart_tx_stopped(&s->port)) {
+                                tx = xmit->buf[xmit->tail];
+                                xmit->tail = (xmit->tail + 1) &
+                                        (UART_XMIT_SIZE - 1);
+                                s->port.icount.tx++;
+                        }
+                        if (tx != 0xffff) {
+                                max3100_calc_parity(s, &tx);
+                                tx |= MAX3100_WD | (s->rts ? MAX3100_RTS : 0);
+                                max3100_sr(s, tx, &rx);
+                                rxchars += max3100_handlerx(s, rx);
+                        }
+                }
+
+                if (rxchars > 16 && s->port.info->port.tty != NULL) {
+                        tty_flip_buffer_push(s->port.info->port.tty);
+                        rxchars = 0;
+                }
+                if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
+                        uart_write_wakeup(&s->port);
+
+        } while (!s->force_end_work &&
+                 !freezing(current) &&
+                 ((rx & MAX3100_R) ||
+                  (!uart_circ_empty(xmit) &&
+                   !uart_tx_stopped(&s->port))));
+
+        if (rxchars > 0 && s->port.info->port.tty != NULL)
+                tty_flip_buffer_push(s->port.info->port.tty);
+}
+
+static irqreturn_t max3100_irq(int irqno, void *dev_id)
+{
+        struct max3100_port *s = dev_id;
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        max3100_dowork(s);
+        return IRQ_HANDLED;
+}
+
+static void max3100_enable_ms(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        if (s->poll_time > 0)
+                mod_timer(&s->timer, jiffies);
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+}
+
+static void max3100_start_tx(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        max3100_dowork(s);
+}
+
+static void max3100_stop_rx(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        s->rx_enabled = 0;
+        spin_lock(&s->conf_lock);
+        s->conf &= ~MAX3100_RM;
+        s->conf_commit = 1;
+        spin_unlock(&s->conf_lock);
+        max3100_dowork(s);
+}
+
+static unsigned int max3100_tx_empty(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        /* may not be truly up-to-date */
+        max3100_dowork(s);
+        return s->tx_empty;
+}
+
+static unsigned int max3100_get_mctrl(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        /* may not be truly up-to-date */
+        max3100_dowork(s);
+        /* always assert DCD and DSR since these lines are not wired */
+        return (s->cts ? TIOCM_CTS : 0) | TIOCM_DSR | TIOCM_CAR;
+}
+
+static void max3100_set_mctrl(struct uart_port *port, unsigned int mctrl)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+        int rts;
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        rts = (mctrl & TIOCM_RTS) > 0;
+
+        spin_lock(&s->conf_lock);
+        if (s->rts != rts) {
+                s->rts = rts;
+                s->rts_commit = 1;
+                max3100_dowork(s);
+        }
+        spin_unlock(&s->conf_lock);
+}
+
+static void
+max3100_set_termios(struct uart_port *port, struct ktermios *termios,
+                    struct ktermios *old)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+        int baud = 0;
+        unsigned cflag;
+        u32 param_new, param_mask, parity = 0;
+        struct tty_struct *tty = s->port.info->port.tty;
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+        if (!tty)
+                return;
+
+        cflag = termios->c_cflag;
+        param_new = 0;
+        param_mask = 0;
+
+        baud = tty_get_baud_rate(tty);
+        param_new = s->conf & MAX3100_BAUD;
+        switch (baud) {
+        case 300:
+                if (s->crystal)
+                        baud = s->baud;
+                else
+                        param_new = 15;
+                break;
+        case 600:
+                param_new = 14 + s->crystal;
+                break;
+        case 1200:
+                param_new = 13 + s->crystal;
+                break;
+        case 2400:
+                param_new = 12 + s->crystal;
+                break;
+        case 4800:
+                param_new = 11 + s->crystal;
+                break;
+        case 9600:
+                param_new = 10 + s->crystal;
+                break;
+        case 19200:
+                param_new = 9 + s->crystal;
+                break;
+        case 38400:
+                param_new = 8 + s->crystal;
+                break;
+        case 57600:
+                param_new = 1 + s->crystal;
+                break;
+        case 115200:
+                param_new = 0 + s->crystal;
+                break;
+        case 230400:
+                if (s->crystal)
+                        param_new = 0;
+                else
+                        baud = s->baud;
+                break;
+        default:
+                baud = s->baud;
+        }
+        tty_encode_baud_rate(tty, baud, baud);
+        s->baud = baud;
+        param_mask |= MAX3100_BAUD;
+
+        if ((cflag & CSIZE) == CS8) {
+                param_new &= ~MAX3100_L;
+                parity &= ~MAX3100_7BIT;
+        } else {
+                param_new |= MAX3100_L;
+                parity |= MAX3100_7BIT;
+                cflag = (cflag & ~CSIZE) | CS7;
+        }
+        param_mask |= MAX3100_L;
+
+        if (cflag & CSTOPB)
+                param_new |= MAX3100_ST;
+        else
+                param_new &= ~MAX3100_ST;
+        param_mask |= MAX3100_ST;
+
+        if (cflag & PARENB) {
+                param_new |= MAX3100_PE;
+                parity |= MAX3100_PARITY_ON;
+        } else {
+                param_new &= ~MAX3100_PE;
+                parity &= ~MAX3100_PARITY_ON;
+        }
+        param_mask |= MAX3100_PE;
+
+        if (cflag & PARODD)
+                parity |= MAX3100_PARITY_ODD;
+        else
+                parity &= ~MAX3100_PARITY_ODD;
+
+        /* mask termios capabilities we don't support */
+        cflag &= ~CMSPAR;
+        termios->c_cflag = cflag;
+
+        s->port.ignore_status_mask = 0;
+        if (termios->c_iflag & IGNPAR)
+                s->port.ignore_status_mask |=
+                        MAX3100_STATUS_PE | MAX3100_STATUS_FE |
+                        MAX3100_STATUS_OE;
+
+        /* we are sending char from a workqueue so enable */
+        s->port.info->port.tty->low_latency = 1;
+
+        if (s->poll_time > 0)
+                del_timer_sync(&s->timer);
+
+        uart_update_timeout(port, termios->c_cflag, baud);
+
+        spin_lock(&s->conf_lock);
+        s->conf = (s->conf & ~param_mask) | (param_new & param_mask);
+        s->conf_commit = 1;
+        s->parity = parity;
+        spin_unlock(&s->conf_lock);
+        max3100_dowork(s);
+
+        if (UART_ENABLE_MS(&s->port, termios->c_cflag))
+                max3100_enable_ms(&s->port);
+}
+
+static void max3100_shutdown(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        if (s->suspending)
+                return;
+
+        s->force_end_work = 1;
+
+        if (s->poll_time > 0)
+                del_timer_sync(&s->timer);
+
+        if (s->workqueue) {
+                flush_workqueue(s->workqueue);
+                destroy_workqueue(s->workqueue);
+                s->workqueue = NULL;
+        }
+        if (s->irq)
+                free_irq(s->irq, s);
+
+        /* set shutdown mode to save power */
+        if (s->max3100_hw_suspend)
+                s->max3100_hw_suspend(1);
+        else  {
+                u16 tx, rx;
+
+                tx = MAX3100_WC | MAX3100_SHDN;
+                max3100_sr(s, tx, &rx);
+        }
+}
+
+static int max3100_startup(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+        char b[12];
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        s->conf = MAX3100_RM;
+        s->baud = s->crystal ? 230400 : 115200;
+        s->rx_enabled = 1;
+
+        if (s->suspending)
+                return 0;
+
+        s->force_end_work = 0;
+        s->parity = 0;
+        s->rts = 0;
+
+        sprintf(b, "max3100-%d", s->minor);
+        s->workqueue = create_freezeable_workqueue(b);
+        if (!s->workqueue) {
+                dev_warn(&s->spi->dev, "cannot create workqueue\n");
+                return -EBUSY;
+        }
+        INIT_WORK(&s->work, max3100_work);
+
+        if (request_irq(s->irq, max3100_irq,
+                        IRQF_TRIGGER_FALLING, "max3100", s) < 0) {
+                dev_warn(&s->spi->dev, "cannot allocate irq %d\n", s->irq);
+                s->irq = 0;
+                destroy_workqueue(s->workqueue);
+                s->workqueue = NULL;
+                return -EBUSY;
+        }
+
+        if (s->loopback) {
+                u16 tx, rx;
+                tx = 0x4001;
+                max3100_sr(s, tx, &rx);
+        }
+
+        if (s->max3100_hw_suspend)
+                s->max3100_hw_suspend(0);
+        s->conf_commit = 1;
+        max3100_dowork(s);
+        /* wait for clock to settle */
+        msleep(50);
+
+        max3100_enable_ms(&s->port);
+
+        return 0;
+}
+
+static const char *max3100_type(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        return s->port.type == PORT_MAX3100 ? "MAX3100" : NULL;
+}
+
+static void max3100_release_port(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+}
+
+static void max3100_config_port(struct uart_port *port, int flags)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        if (flags & UART_CONFIG_TYPE)
+                s->port.type = PORT_MAX3100;
+}
+
+static int max3100_verify_port(struct uart_port *port,
+                               struct serial_struct *ser)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+        int ret = -EINVAL;
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        if (ser->type == PORT_UNKNOWN || ser->type == PORT_MAX3100)
+                ret = 0;
+        return ret;
+}
+
+static void max3100_stop_tx(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+}
+
+static int max3100_request_port(struct uart_port *port)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+        return 0;
+}
+
+static void max3100_break_ctl(struct uart_port *port, int break_state)
+{
+        struct max3100_port *s = container_of(port,
+                                              struct max3100_port,
+                                              port);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+}
+
+static struct uart_ops max3100_ops = {
+        .tx_empty       = max3100_tx_empty,
+        .set_mctrl      = max3100_set_mctrl,
+        .get_mctrl      = max3100_get_mctrl,
+        .stop_tx        = max3100_stop_tx,
+        .start_tx       = max3100_start_tx,
+        .stop_rx        = max3100_stop_rx,
+        .enable_ms      = max3100_enable_ms,
+        .break_ctl      = max3100_break_ctl,
+        .startup        = max3100_startup,
+        .shutdown       = max3100_shutdown,
+        .set_termios    = max3100_set_termios,
+        .type           = max3100_type,
+        .release_port   = max3100_release_port,
+        .request_port   = max3100_request_port,
+        .config_port    = max3100_config_port,
+        .verify_port    = max3100_verify_port,
+};
+
+static struct uart_driver max3100_uart_driver = {
+        .owner          = THIS_MODULE,
+        .driver_name    = "ttyMAX",
+        .dev_name       = "ttyMAX",
+        .major          = MAX3100_MAJOR,
+        .minor          = MAX3100_MINOR,
+        .nr             = MAX_MAX3100,
+};
+static int uart_driver_registered;
+
+static int __devinit max3100_probe(struct spi_device *spi)
+{
+        int i, retval;
+        struct plat_max3100 *pdata;
+        u16 tx, rx;
+
+        mutex_lock(&max3100s_lock);
+
+        if (!uart_driver_registered) {
+                uart_driver_registered = 1;
+                retval = uart_register_driver(&max3100_uart_driver);
+                if (retval) {
+                        printk(KERN_ERR "Couldn't register max3100 uart driver\n");
+                        mutex_unlock(&max3100s_lock);
+                        return retval;
+                }
+        }
+
+        for (i = 0; i < MAX_MAX3100; i++)
+                if (!max3100s[i])
+                        break;
+        if (i == MAX_MAX3100) {
+                dev_warn(&spi->dev, "too many MAX3100 chips\n");
+                mutex_unlock(&max3100s_lock);
+                return -ENOMEM;
+        }
+
+        max3100s[i] = kzalloc(sizeof(struct max3100_port), GFP_KERNEL);
+        if (!max3100s[i]) {
+                dev_warn(&spi->dev,
+                         "kmalloc for max3100 structure %d failed!\n", i);
+                mutex_unlock(&max3100s_lock);
+                return -ENOMEM;
+        }
+        max3100s[i]->spi = spi;
+        max3100s[i]->irq = spi->irq;
+        spin_lock_init(&max3100s[i]->conf_lock);
+        dev_set_drvdata(&spi->dev, max3100s[i]);
+        pdata = spi->dev.platform_data;
+        max3100s[i]->crystal = pdata->crystal;
+        max3100s[i]->loopback = pdata->loopback;
+        max3100s[i]->poll_time = pdata->poll_time * HZ / 1000;
+        if (pdata->poll_time > 0 && max3100s[i]->poll_time == 0)
+                max3100s[i]->poll_time = 1;
+        max3100s[i]->max3100_hw_suspend = pdata->max3100_hw_suspend;
+        max3100s[i]->minor = i;
+        init_timer(&max3100s[i]->timer);
+        max3100s[i]->timer.function = max3100_timeout;
+        max3100s[i]->timer.data = (unsigned long) max3100s[i];
+
+        dev_dbg(&spi->dev, "%s: adding port %d\n", __func__, i);
+        max3100s[i]->port.irq = max3100s[i]->irq;
+        max3100s[i]->port.uartclk = max3100s[i]->crystal ? 3686400 : 1843200;
+        max3100s[i]->port.fifosize = 16;
+        max3100s[i]->port.ops = &max3100_ops;
+        max3100s[i]->port.flags = UPF_SKIP_TEST | UPF_BOOT_AUTOCONF;
+        max3100s[i]->port.line = i;
+        max3100s[i]->port.type = PORT_MAX3100;
+        max3100s[i]->port.dev = &spi->dev;
+        retval = uart_add_one_port(&max3100_uart_driver, &max3100s[i]->port);
+        if (retval < 0)
+                dev_warn(&spi->dev,
+                         "uart_add_one_port failed for line %d with error %d\n",
+                         i, retval);
+
+        /* set shutdown mode to save power. Will be woken-up on open */
+        if (max3100s[i]->max3100_hw_suspend)
+                max3100s[i]->max3100_hw_suspend(1);
+        else {
+                tx = MAX3100_WC | MAX3100_SHDN;
+                max3100_sr(max3100s[i], tx, &rx);
+        }
+        mutex_unlock(&max3100s_lock);
+        return 0;
+}
+
+static int __devexit max3100_remove(struct spi_device *spi)
+{
+        struct max3100_port *s = dev_get_drvdata(&spi->dev);
+        int i;
+
+        mutex_lock(&max3100s_lock);
+
+        /* find out the index for the chip we are removing */
+        for (i = 0; i < MAX_MAX3100; i++)
+                if (max3100s[i] == s)
+                        break;
+
+        dev_dbg(&spi->dev, "%s: removing port %d\n", __func__, i);
+        uart_remove_one_port(&max3100_uart_driver, &max3100s[i]->port);
+        kfree(max3100s[i]);
+        max3100s[i] = NULL;
+
+        /* check if this is the last chip we have */
+        for (i = 0; i < MAX_MAX3100; i++)
+                if (max3100s[i]) {
+                        mutex_unlock(&max3100s_lock);
+                        return 0;
+                }
+        pr_debug("removing max3100 driver\n");
+        uart_unregister_driver(&max3100_uart_driver);
+
+        mutex_unlock(&max3100s_lock);
+        return 0;
+}
+
+#ifdef CONFIG_PM
+
+static int max3100_suspend(struct spi_device *spi, pm_message_t state)
+{
+        struct max3100_port *s = dev_get_drvdata(&spi->dev);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        disable_irq(s->irq);
+
+        s->suspending = 1;
+        uart_suspend_port(&max3100_uart_driver, &s->port);
+
+        if (s->max3100_hw_suspend)
+                s->max3100_hw_suspend(1);
+        else {
+                /* no HW suspend, so do SW one */
+                u16 tx, rx;
+
+                tx = MAX3100_WC | MAX3100_SHDN;
+                max3100_sr(s, tx, &rx);
+        }
+        return 0;
+}
+
+static int max3100_resume(struct spi_device *spi)
+{
+        struct max3100_port *s = dev_get_drvdata(&spi->dev);
+
+        dev_dbg(&s->spi->dev, "%s\n", __func__);
+
+        if (s->max3100_hw_suspend)
+                s->max3100_hw_suspend(0);
+        uart_resume_port(&max3100_uart_driver, &s->port);
+        s->suspending = 0;
+
+        enable_irq(s->irq);
+
+        s->conf_commit = 1;
+        if (s->workqueue)
+                max3100_dowork(s);
+
+        return 0;
+}
+
+#else
+#define max3100_suspend NULL
+#define max3100_resume  NULL
+#endif
+
+static struct spi_driver max3100_driver = {
+        .driver = {
+                .name           = "max3100",
+                .bus            = &spi_bus_type,
+                .owner          = THIS_MODULE,
+        },
+
+        .probe          = max3100_probe,
+        .remove         = __devexit_p(max3100_remove),
+        .suspend        = max3100_suspend,
+        .resume         = max3100_resume,
+};
+
+static int __init max3100_init(void)
+{
+        return spi_register_driver(&max3100_driver);
+}
+module_init(max3100_init);
+
+static void __exit max3100_exit(void)
+{
+        spi_unregister_driver(&max3100_driver);
+}
+module_exit(max3100_exit);
+
+MODULE_DESCRIPTION("MAX3100 driver");
+MODULE_AUTHOR("Christian Pellegrin <chripell@evolware.org>");
+MODULE_LICENSE("GPL");
diff --git a/drivers/serial/sunsu.c b/drivers/serial/sunsu.c
index a4dc79b1d7ab..47c6837850b1 100644
--- a/drivers/serial/sunsu.c
+++ b/drivers/serial/sunsu.c
@@ -1178,7 +1178,7 @@ static struct uart_driver sunsu_reg = {
         .major                  = TTY_MAJOR,
 };
 
-static int __init sunsu_kbd_ms_init(struct uart_sunsu_port *up)
+static int __devinit sunsu_kbd_ms_init(struct uart_sunsu_port *up)
 {
         int quot, baud;
 #ifdef CONFIG_SERIO
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index 4ed228a89943..bb5e6f671578 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -280,7 +280,7 @@ static int ohci_hcd_at91_drv_probe(struct platform_device *pdev)
                  * are always powered while this driver is active, and use
                  * active-low power switches.
                  */
-                for (i = 0; i < pdata->ports; i++) {
+                for (i = 0; i < ARRAY_SIZE(pdata->vbus_pin); i++) {
                         if (pdata->vbus_pin[i] <= 0)
                                 continue;
                         gpio_request(pdata->vbus_pin[i], "ohci_vbus");
@@ -298,7 +298,7 @@ static int ohci_hcd_at91_drv_remove(struct platform_device *pdev)
         int                     i;
 
         if (pdata) {
-                for (i = 0; i < pdata->ports; i++) {
+                for (i = 0; i < ARRAY_SIZE(pdata->vbus_pin); i++) {
                         if (pdata->vbus_pin[i] <= 0)
                                 continue;
                         gpio_direction_output(pdata->vbus_pin[i], 1);
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 63024145215d..5eb8f21da82e 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -240,8 +240,6 @@ config ORION5X_WATCHDOG
           To compile this driver as a module, choose M here: the
           module will be called orion5x_wdt.
 
-# ARM26 Architecture
-
 # AVR32 Architecture
 
 config AT32AP700X_WDT
diff --git a/drivers/watchdog/Makefile b/drivers/watchdog/Makefile
index 806b3eb08536..7f8c56b14f58 100644
--- a/drivers/watchdog/Makefile
+++ b/drivers/watchdog/Makefile
@@ -42,8 +42,6 @@ obj-$(CONFIG_IOP_WATCHDOG) += iop_wdt.o
 obj-$(CONFIG_DAVINCI_WATCHDOG) += davinci_wdt.o
 obj-$(CONFIG_ORION5X_WATCHDOG) += orion5x_wdt.o
 
-# ARM26 Architecture
-
 # AVR32 Architecture
 obj-$(CONFIG_AT32AP700X_WDT) += at32ap700x_wdt.o
 
diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c
index e35d54589232..29e52c237a3b 100644
--- a/drivers/watchdog/at91rm9200_wdt.c
+++ b/drivers/watchdog/at91rm9200_wdt.c
@@ -197,7 +197,7 @@ static struct miscdevice at91wdt_miscdev = {
         .fops           = &at91wdt_fops,
 };
 
-static int __init at91wdt_probe(struct platform_device *pdev)
+static int __devinit at91wdt_probe(struct platform_device *pdev)
 {
         int res;
 
@@ -214,7 +214,7 @@ static int __init at91wdt_probe(struct platform_device *pdev)
         return 0;
 }
 
-static int __exit at91wdt_remove(struct platform_device *pdev)
+static int __devexit at91wdt_remove(struct platform_device *pdev)
 {
         int res;
 
@@ -252,7 +252,7 @@ static int at91wdt_resume(struct platform_device *pdev)
 
 static struct platform_driver at91wdt_driver = {
         .probe          = at91wdt_probe,
-        .remove         = __exit_p(at91wdt_remove),
+        .remove         = __devexit_p(at91wdt_remove),
         .shutdown       = at91wdt_shutdown,
         .suspend        = at91wdt_suspend,
         .resume         = at91wdt_resume,
diff --git a/drivers/watchdog/i6300esb.c b/drivers/watchdog/i6300esb.c
index 2dbe83570d65..7ba0b11ec525 100644
--- a/drivers/watchdog/i6300esb.c
+++ b/drivers/watchdog/i6300esb.c
@@ -52,10 +52,10 @@
 #define ESB_LOCK_REG    0x68            /* WDT lock register                 */
 
 /* Memory mapped registers */
-#define ESB_TIMER1_REG  BASEADDR + 0x00 /* Timer1 value after each reset     */
-#define ESB_TIMER2_REG  BASEADDR + 0x04 /* Timer2 value after each reset     */
-#define ESB_GINTSR_REG  BASEADDR + 0x08 /* General Interrupt Status Register */
-#define ESB_RELOAD_REG  BASEADDR + 0x0c /* Reload register                   */
+#define ESB_TIMER1_REG (BASEADDR + 0x00)/* Timer1 value after each reset     */
+#define ESB_TIMER2_REG (BASEADDR + 0x04)/* Timer2 value after each reset     */
+#define ESB_GINTSR_REG (BASEADDR + 0x08)/* General Interrupt Status Register */
+#define ESB_RELOAD_REG (BASEADDR + 0x0c)/* Reload register                   */
 
 /* Lock register bits */
 #define ESB_WDT_FUNC    (0x01 << 2)   /* Watchdog functionality            */
@@ -68,6 +68,7 @@
 #define ESB_WDT_INTTYPE (0x11 << 0)   /* Interrupt type on timer1 timeout  */
 
 /* Reload register bits */
+#define ESB_WDT_TIMEOUT (0x01 << 9)    /* Watchdog timed out                */
 #define ESB_WDT_RELOAD  (0x01 << 8)    /* prevent timeout                   */
 
 /* Magic constants */
@@ -87,7 +88,6 @@ static struct platform_device *esb_platform_device;
 /* 30 sec default heartbeat (1 < heartbeat < 2*1023) */
 #define WATCHDOG_HEARTBEAT 30
 static int heartbeat = WATCHDOG_HEARTBEAT;  /* in seconds */
-
 module_param(heartbeat, int, 0);
 MODULE_PARM_DESC(heartbeat,
                 "Watchdog heartbeat in seconds. (1<heartbeat<2046, default="
@@ -123,7 +123,7 @@ static int esb_timer_start(void)
         esb_unlock_registers();
         writew(ESB_WDT_RELOAD, ESB_RELOAD_REG);
         /* Enable or Enable + Lock? */
-        val = 0x02 | (nowayout ? 0x01 : 0x00);
+        val = ESB_WDT_ENABLE | (nowayout ? ESB_WDT_LOCK : 0x00);
         pci_write_config_byte(esb_pci, ESB_LOCK_REG, val);
         spin_unlock(&esb_lock);
         return 0;
@@ -143,7 +143,7 @@ static int esb_timer_stop(void)
         spin_unlock(&esb_lock);
 
         /* Returns 0 if the timer was disabled, non-zero otherwise */
-        return (val & 0x01);
+        return val & ESB_WDT_ENABLE;
 }
 
 static void esb_timer_keepalive(void)
@@ -190,18 +190,6 @@ static int esb_timer_set_heartbeat(int time)
         return 0;
 }
 
-static int esb_timer_read(void)
-{
-        u32 count;
-
-        /* This isn't documented, and doesn't take into
-         * acount which stage is running, but it looks
-         * like a 20 bit count down, so we might as well report it.
-         */
-        pci_read_config_dword(esb_pci, 0x64, &count);
-        return (int)count;
-}
-
 /*
  *      /dev/watchdog handling
  */
@@ -282,7 +270,7 @@ static long esb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
                                         sizeof(ident)) ? -EFAULT : 0;
 
         case WDIOC_GETSTATUS:
-                return put_user(esb_timer_read(), p);
+                return put_user(0, p);
 
         case WDIOC_GETBOOTSTATUS:
                 return put_user(triggered, p);
@@ -362,8 +350,6 @@ MODULE_DEVICE_TABLE(pci, esb_pci_tbl);
 
 static unsigned char __devinit esb_getdevice(void)
 {
-        u8 val1;
-        unsigned short val2;
         /*
          *      Find the PCI device
          */
@@ -371,66 +357,79 @@ static unsigned char __devinit esb_getdevice(void)
         esb_pci = pci_get_device(PCI_VENDOR_ID_INTEL,
                                         PCI_DEVICE_ID_INTEL_ESB_9, NULL);
 
-        if (esb_pci) {
-                if (pci_enable_device(esb_pci)) {
-                        printk(KERN_ERR PFX "failed to enable device\n");
-                        goto err_devput;
-                }
+        if (!esb_pci)
+                return 0;
 
-                if (pci_request_region(esb_pci, 0, ESB_MODULE_NAME)) {
-                        printk(KERN_ERR PFX "failed to request region\n");
-                        goto err_disable;
-                }
+        if (pci_enable_device(esb_pci)) {
+                printk(KERN_ERR PFX "failed to enable device\n");
+                goto err_devput;
+        }
 
-                BASEADDR = pci_ioremap_bar(esb_pci, 0);
-                if (BASEADDR == NULL) {
-                        /* Something's wrong here, BASEADDR has to be set */
-                        printk(KERN_ERR PFX "failed to get BASEADDR\n");
-                        goto err_release;
-                }
+        if (pci_request_region(esb_pci, 0, ESB_MODULE_NAME)) {
+                printk(KERN_ERR PFX "failed to request region\n");
+                goto err_disable;
+        }
 
-                /*
-                 * The watchdog has two timers, it can be setup so that the
-                 * expiry of timer1 results in an interrupt and the expiry of
-                 * timer2 results in a reboot. We set it to not generate
-                 * any interrupts as there is not much we can do with it
-                 * right now.
-                 *
-                 * We also enable reboots and set the timer frequency to
-                 * the PCI clock divided by 2^15 (approx 1KHz).
-                 */
-                pci_write_config_word(esb_pci, ESB_CONFIG_REG, 0x0003);
-
-                /* Check that the WDT isn't already locked */
-                pci_read_config_byte(esb_pci, ESB_LOCK_REG, &val1);
-                if (val1 & ESB_WDT_LOCK)
-                        printk(KERN_WARNING PFX "nowayout already set\n");
-
-                /* Set the timer to watchdog mode and disable it for now */
-                pci_write_config_byte(esb_pci, ESB_LOCK_REG, 0x00);
-
-                /* Check if the watchdog was previously triggered */
-                esb_unlock_registers();
-                val2 = readw(ESB_RELOAD_REG);
-                triggered = (val2 & (0x01 << 9) >> 9);
-
-                /* Reset trigger flag and timers */
-                esb_unlock_registers();
-                writew((0x11 << 8), ESB_RELOAD_REG);
-
-                /* Done */
-                return 1;
+        BASEADDR = pci_ioremap_bar(esb_pci, 0);
+        if (BASEADDR == NULL) {
+                /* Something's wrong here, BASEADDR has to be set */
+                printk(KERN_ERR PFX "failed to get BASEADDR\n");
+                goto err_release;
+        }
+
+        /* Done */
+        return 1;
 
 err_release:
-                pci_release_region(esb_pci, 0);
+        pci_release_region(esb_pci, 0);
 err_disable:
-                pci_disable_device(esb_pci);
+        pci_disable_device(esb_pci);
 err_devput:
-                pci_dev_put(esb_pci);
-        }
+        pci_dev_put(esb_pci);
         return 0;
 }
 
+static void __devinit esb_initdevice(void)
+{
+        u8 val1;
+        u16 val2;
+
+        /*
+         * Config register:
+         * Bit    5 : 0 = Enable WDT_OUTPUT
+         * Bit    2 : 0 = set the timer frequency to the PCI clock
+         * divided by 2^15 (approx 1KHz).
+         * Bits 1:0 : 11 = WDT_INT_TYPE Disabled.
+         * The watchdog has two timers, it can be setup so that the
+         * expiry of timer1 results in an interrupt and the expiry of
+         * timer2 results in a reboot. We set it to not generate
+         * any interrupts as there is not much we can do with it
+         * right now.
+         */
+        pci_write_config_word(esb_pci, ESB_CONFIG_REG, 0x0003);
+
+        /* Check that the WDT isn't already locked */
+        pci_read_config_byte(esb_pci, ESB_LOCK_REG, &val1);
+        if (val1 & ESB_WDT_LOCK)
+                printk(KERN_WARNING PFX "nowayout already set\n");
+
+        /* Set the timer to watchdog mode and disable it for now */
+        pci_write_config_byte(esb_pci, ESB_LOCK_REG, 0x00);
+
+        /* Check if the watchdog was previously triggered */
+        esb_unlock_registers();
+        val2 = readw(ESB_RELOAD_REG);
+        if (val2 & ESB_WDT_TIMEOUT)
+                triggered = WDIOF_CARDRESET;
+
+        /* Reset WDT_TIMEOUT flag and timers */
+        esb_unlock_registers();
+        writew((ESB_WDT_TIMEOUT | ESB_WDT_RELOAD), ESB_RELOAD_REG);
+
+        /* And set the correct timeout value */
+        esb_timer_set_heartbeat(heartbeat);
+}
+
 static int __devinit esb_probe(struct platform_device *dev)
 {
         int ret;
@@ -441,13 +440,17 @@ static int __devinit esb_probe(struct platform_device *dev)
 
         /* Check that the heartbeat value is within it's range;
            if not reset to the default */
-        if (esb_timer_set_heartbeat(heartbeat)) {
-                esb_timer_set_heartbeat(WATCHDOG_HEARTBEAT);
+        if (heartbeat < 0x1 || heartbeat > 2 * 0x03ff) {
+                heartbeat = WATCHDOG_HEARTBEAT;
                 printk(KERN_INFO PFX
                         "heartbeat value must be 1<heartbeat<2046, using %d\n",
                                                                 heartbeat);
         }
 
+        /* Initialize the watchdog and make sure it does not run */
+        esb_initdevice();
+
+        /* Register the watchdog so that userspace has access to it */
         ret = misc_register(&esb_miscdev);
         if (ret != 0) {
                 printk(KERN_ERR PFX
@@ -455,7 +458,6 @@ static int __devinit esb_probe(struct platform_device *dev)
                                                         WATCHDOG_MINOR, ret);
                 goto err_unmap;
         }
-        esb_timer_stop();
         printk(KERN_INFO PFX
                 "initialized (0x%p). heartbeat=%d sec (nowayout=%d)\n",
                                                 BASEADDR, heartbeat, nowayout);
@@ -463,11 +465,8 @@ static int __devinit esb_probe(struct platform_device *dev)
 
 err_unmap:
         iounmap(BASEADDR);
-/* err_release: */
         pci_release_region(esb_pci, 0);
-/* err_disable: */
         pci_disable_device(esb_pci);
-/* err_devput: */
         pci_dev_put(esb_pci);
         return ret;
 }
diff --git a/drivers/watchdog/ks8695_wdt.c b/drivers/watchdog/ks8695_wdt.c
index 74c92d384112..ae3832110acb 100644
--- a/drivers/watchdog/ks8695_wdt.c
+++ b/drivers/watchdog/ks8695_wdt.c
@@ -221,7 +221,7 @@ static struct miscdevice ks8695wdt_miscdev = {
         .fops           = &ks8695wdt_fops,
 };
 
-static int __init ks8695wdt_probe(struct platform_device *pdev)
+static int __devinit ks8695wdt_probe(struct platform_device *pdev)
 {
         int res;
 
@@ -238,7 +238,7 @@ static int __init ks8695wdt_probe(struct platform_device *pdev)
         return 0;
 }
 
-static int __exit ks8695wdt_remove(struct platform_device *pdev)
+static int __devexit ks8695wdt_remove(struct platform_device *pdev)
 {
         int res;
 
@@ -276,7 +276,7 @@ static int ks8695wdt_resume(struct platform_device *pdev)
 
 static struct platform_driver ks8695wdt_driver = {
         .probe          = ks8695wdt_probe,
-        .remove         = __exit_p(ks8695wdt_remove),
+        .remove         = __devexit_p(ks8695wdt_remove),
         .shutdown       = ks8695wdt_shutdown,
         .suspend        = ks8695wdt_suspend,
         .resume         = ks8695wdt_resume,
diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
index aa5ad6e33f02..f2713851aaab 100644
--- a/drivers/watchdog/omap_wdt.c
+++ b/drivers/watchdog/omap_wdt.c
@@ -258,7 +258,7 @@ static const struct file_operations omap_wdt_fops = {
         .release = omap_wdt_release,
 };
 
-static int __init omap_wdt_probe(struct platform_device *pdev)
+static int __devinit omap_wdt_probe(struct platform_device *pdev)
 {
         struct resource *res, *mem;
         struct omap_wdt_dev *wdev;
@@ -367,7 +367,7 @@ static void omap_wdt_shutdown(struct platform_device *pdev)
                 omap_wdt_disable(wdev);
 }
 
-static int omap_wdt_remove(struct platform_device *pdev)
+static int __devexit omap_wdt_remove(struct platform_device *pdev)
 {
         struct omap_wdt_dev *wdev = platform_get_drvdata(pdev);
         struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -426,7 +426,7 @@ static int omap_wdt_resume(struct platform_device *pdev)
 
 static struct platform_driver omap_wdt_driver = {
         .probe          = omap_wdt_probe,
-        .remove         = omap_wdt_remove,
+        .remove         = __devexit_p(omap_wdt_remove),
         .shutdown       = omap_wdt_shutdown,
         .suspend        = omap_wdt_suspend,
         .resume         = omap_wdt_resume,
diff --git a/drivers/watchdog/orion5x_wdt.c b/drivers/watchdog/orion5x_wdt.c
index e81441f103dd..7529616739d2 100644
--- a/drivers/watchdog/orion5x_wdt.c
+++ b/drivers/watchdog/orion5x_wdt.c
@@ -42,7 +42,17 @@ static unsigned int wdt_tclk;
 static unsigned long wdt_status;
 static spinlock_t wdt_lock;
 
-static void wdt_enable(void)
+static void orion5x_wdt_ping(void)
+{
+        spin_lock(&wdt_lock);
+
+        /* Reload watchdog duration */
+        writel(wdt_tclk * heartbeat, WDT_VAL);
+
+        spin_unlock(&wdt_lock);
+}
+
+static void orion5x_wdt_enable(void)
 {
         u32 reg;
 
@@ -69,7 +79,7 @@ static void wdt_enable(void)
         spin_unlock(&wdt_lock);
 }
 
-static void wdt_disable(void)
+static void orion5x_wdt_disable(void)
 {
         u32 reg;
 
@@ -101,7 +111,7 @@ static int orion5x_wdt_open(struct inode *inode, struct file *file)
         if (test_and_set_bit(WDT_IN_USE, &wdt_status))
                 return -EBUSY;
         clear_bit(WDT_OK_TO_CLOSE, &wdt_status);
-        wdt_enable();
+        orion5x_wdt_enable();
         return nonseekable_open(inode, file);
 }
 
@@ -122,18 +132,28 @@ static ssize_t orion5x_wdt_write(struct file *file, const char *data,
                                         set_bit(WDT_OK_TO_CLOSE, &wdt_status);
                         }
                 }
-                wdt_enable();
+                orion5x_wdt_ping();
         }
         return len;
 }
 
-static struct watchdog_info ident = {
+static int orion5x_wdt_settimeout(int new_time)
+{
+        if ((new_time <= 0) || (new_time > wdt_max_duration))
+                return -EINVAL;
+
+        /* Set new watchdog time to be used when
+         * orion5x_wdt_enable() or orion5x_wdt_ping() is called. */
+        heartbeat = new_time;
+        return 0;
+}
+
+static const struct watchdog_info ident = {
         .options        = WDIOF_MAGICCLOSE | WDIOF_SETTIMEOUT |
                           WDIOF_KEEPALIVEPING,
         .identity       = "Orion5x Watchdog",
 };
 
-
 static long orion5x_wdt_ioctl(struct file *file, unsigned int cmd,
                                 unsigned long arg)
 {
@@ -152,7 +172,7 @@ static long orion5x_wdt_ioctl(struct file *file, unsigned int cmd,
                 break;
 
         case WDIOC_KEEPALIVE:
-                wdt_enable();
+                orion5x_wdt_ping();
                 ret = 0;
                 break;
 
@@ -161,12 +181,11 @@ static long orion5x_wdt_ioctl(struct file *file, unsigned int cmd,
                 if (ret)
                         break;
 
-                if (time <= 0 || time > wdt_max_duration) {
+                if (orion5x_wdt_settimeout(time)) {
                         ret = -EINVAL;
                         break;
                 }
-                heartbeat = time;
-                wdt_enable();
+                orion5x_wdt_ping();
                 /* Fall through */
 
         case WDIOC_GETTIMEOUT:
@@ -187,7 +206,7 @@ static long orion5x_wdt_ioctl(struct file *file, unsigned int cmd,
 static int orion5x_wdt_release(struct inode *inode, struct file *file)
 {
         if (test_bit(WDT_OK_TO_CLOSE, &wdt_status))
-                wdt_disable();
+                orion5x_wdt_disable();
         else
                 printk(KERN_CRIT "WATCHDOG: Device closed unexpectedly - "
                                         "timer will not stop\n");
@@ -230,7 +249,7 @@ static int __devinit orion5x_wdt_probe(struct platform_device *pdev)
         orion5x_wdt_miscdev.parent = &pdev->dev;
 
         wdt_max_duration = WDT_MAX_CYCLE_COUNT / wdt_tclk;
-        if (heartbeat <= 0 || heartbeat > wdt_max_duration)
+        if (orion5x_wdt_settimeout(heartbeat))
                 heartbeat = wdt_max_duration;
 
         ret = misc_register(&orion5x_wdt_miscdev);
@@ -247,7 +266,7 @@ static int __devexit orion5x_wdt_remove(struct platform_device *pdev)
         int ret;
 
         if (test_bit(WDT_IN_USE, &wdt_status)) {
-                wdt_disable();
+                orion5x_wdt_disable();
                 clear_bit(WDT_IN_USE, &wdt_status);
         }
 
@@ -258,9 +277,16 @@ static int __devexit orion5x_wdt_remove(struct platform_device *pdev)
         return ret;
 }
 
+static void orion5x_wdt_shutdown(struct platform_device *pdev)
+{
+        if (test_bit(WDT_IN_USE, &wdt_status))
+                orion5x_wdt_disable();
+}
+
 static struct platform_driver orion5x_wdt_driver = {
         .probe          = orion5x_wdt_probe,
         .remove         = __devexit_p(orion5x_wdt_remove),
+        .shutdown       = orion5x_wdt_shutdown,
         .driver         = {
                 .owner  = THIS_MODULE,
                 .name   = "orion5x_wdt",
@@ -285,10 +311,11 @@ MODULE_AUTHOR("Sylver Bruneau <sylver.bruneau@googlemail.com>");
 MODULE_DESCRIPTION("Orion5x Processor Watchdog");
 
 module_param(heartbeat, int, 0);
-MODULE_PARM_DESC(heartbeat, "Watchdog heartbeat in seconds");
+MODULE_PARM_DESC(heartbeat, "Initial watchdog heartbeat in seconds");
 
 module_param(nowayout, int, 0);
-MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started");
+MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
+                                __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
 
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);