8 files changed, 102 insertions, 63 deletions

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 9b88b25b6edb..e76d91906c99 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -95,11 +95,13 @@ config SENSORS_ADM9240
           will be called adm9240.
 
 config SENSORS_K8TEMP
-        tristate "AMD K8 processor sensor"
+        tristate "AMD Athlon64/FX or Opteron temperature sensor"
         depends on HWMON && X86 && PCI && EXPERIMENTAL
         help
           If you say yes here you get support for the temperature
-          sensor(s) inside your AMD K8 CPU.
+          sensor(s) inside your CPU. Supported is whole AMD K8
+          microarchitecture. Please note that you will need at least
+          lm-sensors 2.10.1 for proper userspace support.
 
           This driver can also be built as a module.  If so, the module
           will be called k8temp.
@@ -369,8 +371,8 @@ config SENSORS_SMSC47M1
         help
           If you say yes here you get support for the integrated fan
           monitoring and control capabilities of the SMSC LPC47B27x,
-          LPC47M10x, LPC47M13x, LPC47M14x, LPC47M15x, LPC47M192 and
-          LPC47M997 chips.
+          LPC47M10x, LPC47M112, LPC47M13x, LPC47M14x, LPC47M15x,
+          LPC47M192 and LPC47M997 chips.
 
           The temperature and voltage sensor features of the LPC47M192
           and LPC47M997 are supported by another driver, select also
diff --git a/drivers/hwmon/adm9240.c b/drivers/hwmon/adm9240.c
index 377961c4a41e..aad594adf0c7 100644
--- a/drivers/hwmon/adm9240.c
+++ b/drivers/hwmon/adm9240.c
@@ -5,7 +5,7 @@
  * Copyright (C) 1999   Frodo Looijaard <frodol@dds.nl>
  *                      Philip Edelbrock <phil@netroedge.com>
  * Copyright (C) 2003   Michiel Rook <michiel@grendelproject.nl>
- * Copyright (C) 2005   Grant Coady <gcoady@gmail.com> with valuable
+ * Copyright (C) 2005   Grant Coady <gcoady.lk@gmail.com> with valuable
  *                              guidance from Jean Delvare
  *
  * Driver supports      Analog Devices          ADM9240
@@ -774,7 +774,7 @@ static void __exit sensors_adm9240_exit(void)
 }
 
 MODULE_AUTHOR("Michiel Rook <michiel@grendelproject.nl>, "
-                "Grant Coady <gcoady@gmail.com> and others");
+                "Grant Coady <gcoady.lk@gmail.com> and others");
 MODULE_DESCRIPTION("ADM9240/DS1780/LM81 driver");
 MODULE_LICENSE("GPL");
 
diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c
index ac1b746df6d0..73bc2ffc598d 100644
--- a/drivers/hwmon/lm78.c
+++ b/drivers/hwmon/lm78.c
@@ -815,18 +815,18 @@ static int __init sm_lm78_init(void)
         if (res)
                 return res;
 
-        res = i2c_isa_add_driver(&lm78_isa_driver);
-        if (res) {
-                i2c_del_driver(&lm78_driver);
-                return res;
-        }
+        /* Don't exit if this one fails, we still want the I2C variants
+           to work! */
+        if (i2c_isa_add_driver(&lm78_isa_driver))
+                isa_address = 0;
 
         return 0;
 }
 
 static void __exit sm_lm78_exit(void)
 {
-        i2c_isa_del_driver(&lm78_isa_driver);
+        if (isa_address)
+                i2c_isa_del_driver(&lm78_isa_driver);
         i2c_del_driver(&lm78_driver);
 }
 
diff --git a/drivers/hwmon/smsc47m1.c b/drivers/hwmon/smsc47m1.c
index 47132fd26b1b..beb881c4b2e8 100644
--- a/drivers/hwmon/smsc47m1.c
+++ b/drivers/hwmon/smsc47m1.c
@@ -2,8 +2,8 @@
     smsc47m1.c - Part of lm_sensors, Linux kernel modules
                  for hardware monitoring
 
-    Supports the SMSC LPC47B27x, LPC47M10x, LPC47M13x, LPC47M14x,
-    LPC47M15x, LPC47M192 and LPC47M997 Super-I/O chips.
+    Supports the SMSC LPC47B27x, LPC47M10x, LPC47M112, LPC47M13x,
+    LPC47M14x, LPC47M15x, LPC47M192 and LPC47M997 Super-I/O chips.
 
     Copyright (C) 2002 Mark D. Studebaker <mdsxyz123@yahoo.com>
     Copyright (C) 2004 Jean Delvare <khali@linux-fr.org>
@@ -380,8 +380,8 @@ static int __init smsc47m1_find(unsigned short *addr)
         val = superio_inb(SUPERIO_REG_DEVID);
 
         /*
-         * SMSC LPC47M10x/LPC47M13x (device id 0x59), LPC47M14x (device id
-         * 0x5F) and LPC47B27x (device id 0x51) have fan control.
+         * SMSC LPC47M10x/LPC47M112/LPC47M13x (device id 0x59), LPC47M14x
+         * (device id 0x5F) and LPC47B27x (device id 0x51) have fan control.
          * The LPC47M15x and LPC47M192 chips "with hardware monitoring block"
          * can do much more besides (device id 0x60).
          * The LPC47M997 is undocumented, but seems to be compatible with
@@ -390,7 +390,8 @@ static int __init smsc47m1_find(unsigned short *addr)
         if (val == 0x51)
                 printk(KERN_INFO "smsc47m1: Found SMSC LPC47B27x\n");
         else if (val == 0x59)
-                printk(KERN_INFO "smsc47m1: Found SMSC LPC47M10x/LPC47M13x\n");
+                printk(KERN_INFO "smsc47m1: Found SMSC "
+                       "LPC47M10x/LPC47M112/LPC47M13x\n");
         else if (val == 0x5F)
                 printk(KERN_INFO "smsc47m1: Found SMSC LPC47M14x\n");
         else if (val == 0x60)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index 833faa275ffa..2257806d0102 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -354,6 +354,8 @@ static void w83627ehf_write_fan_div(struct i2c_client *client, int nr)
         case 0:
                 reg = (w83627ehf_read_value(client, W83627EHF_REG_FANDIV1) & 0xcf)
                     | ((data->fan_div[0] & 0x03) << 4);
+                /* fan5 input control bit is write only, compute the value */
+                reg |= (data->has_fan & (1 << 4)) ? 1 : 0;
                 w83627ehf_write_value(client, W83627EHF_REG_FANDIV1, reg);
                 reg = (w83627ehf_read_value(client, W83627EHF_REG_VBAT) & 0xdf)
                     | ((data->fan_div[0] & 0x04) << 3);
@@ -362,6 +364,8 @@ static void w83627ehf_write_fan_div(struct i2c_client *client, int nr)
         case 1:
                 reg = (w83627ehf_read_value(client, W83627EHF_REG_FANDIV1) & 0x3f)
                     | ((data->fan_div[1] & 0x03) << 6);
+                /* fan5 input control bit is write only, compute the value */
+                reg |= (data->has_fan & (1 << 4)) ? 1 : 0;
                 w83627ehf_write_value(client, W83627EHF_REG_FANDIV1, reg);
                 reg = (w83627ehf_read_value(client, W83627EHF_REG_VBAT) & 0xbf)
                     | ((data->fan_div[1] & 0x04) << 4);
@@ -1216,13 +1220,16 @@ static int w83627ehf_detect(struct i2c_adapter *adapter)
         superio_exit();
 
         /* It looks like fan4 and fan5 pins can be alternatively used
-           as fan on/off switches */
+           as fan on/off switches, but fan5 control is write only :/
+           We assume that if the serial interface is disabled, designers
+           connected fan5 as input unless they are emitting log 1, which
+           is not the default. */
 
         data->has_fan = 0x07; /* fan1, fan2 and fan3 */
         i = w83627ehf_read_value(client, W83627EHF_REG_FANDIV1);
         if ((i & (1 << 2)) && (!fan4pin))
                 data->has_fan |= (1 << 3);
-        if ((i & (1 << 0)) && (!fan5pin))
+        if (!(i & (1 << 1)) && (!fan5pin))
                 data->has_fan |= (1 << 4);
 
         /* Register sysfs hooks */
diff --git a/drivers/hwmon/w83781d.c b/drivers/hwmon/w83781d.c
index a4584ec69842..1232171c3aad 100644
--- a/drivers/hwmon/w83781d.c
+++ b/drivers/hwmon/w83781d.c
@@ -1099,7 +1099,8 @@ w83781d_detect(struct i2c_adapter *adapter, int address, int kind)
            bank. */
         if (kind < 0) {
                 if (w83781d_read_value(client, W83781D_REG_CONFIG) & 0x80) {
-                        dev_dbg(dev, "Detection failed at step 3\n");
+                        dev_dbg(&adapter->dev, "Detection of w83781d chip "
+                                "failed at step 3\n");
                         err = -ENODEV;
                         goto ERROR2;
                 }
@@ -1109,7 +1110,8 @@ w83781d_detect(struct i2c_adapter *adapter, int address, int kind)
                 if ((!(val1 & 0x07)) &&
                     (((!(val1 & 0x80)) && (val2 != 0xa3) && (val2 != 0xc3))
                      || ((val1 & 0x80) && (val2 != 0x5c) && (val2 != 0x12)))) {
-                        dev_dbg(dev, "Detection failed at step 4\n");
+                        dev_dbg(&adapter->dev, "Detection of w83781d chip "
+                                "failed at step 4\n");
                         err = -ENODEV;
                         goto ERROR2;
                 }
@@ -1119,7 +1121,8 @@ w83781d_detect(struct i2c_adapter *adapter, int address, int kind)
                                   ((val1 & 0x80) && (val2 == 0x5c)))) {
                         if (w83781d_read_value
                             (client, W83781D_REG_I2C_ADDR) != address) {
-                                dev_dbg(dev, "Detection failed at step 5\n");
+                                dev_dbg(&adapter->dev, "Detection of w83781d "
+                                        "chip failed at step 5\n");
                                 err = -ENODEV;
                                 goto ERROR2;
                         }
@@ -1141,8 +1144,8 @@ w83781d_detect(struct i2c_adapter *adapter, int address, int kind)
                 else if (val2 == 0x12)
                         vendid = asus;
                 else {
-                        dev_dbg(dev, "Chip was made by neither "
-                                "Winbond nor Asus?\n");
+                        dev_dbg(&adapter->dev, "w83781d chip vendor is "
+                                "neither Winbond nor Asus\n");
                         err = -ENODEV;
                         goto ERROR2;
                 }
@@ -1161,10 +1164,9 @@ w83781d_detect(struct i2c_adapter *adapter, int address, int kind)
                         kind = as99127f;
                 else {
                         if (kind == 0)
-                                dev_warn(dev, "Ignoring 'force' "
+                                dev_warn(&adapter->dev, "Ignoring 'force' "
                                          "parameter for unknown chip at "
-                                         "adapter %d, address 0x%02x\n",
-                                         i2c_adapter_id(adapter), address);
+                                         "address 0x%02x\n", address);
                         err = -EINVAL;
                         goto ERROR2;
                 }
@@ -1685,11 +1687,10 @@ sensors_w83781d_init(void)
         if (res)
                 return res;
 
-        res = i2c_isa_add_driver(&w83781d_isa_driver);
-        if (res) {
-                i2c_del_driver(&w83781d_driver);
-                return res;
-        }
+        /* Don't exit if this one fails, we still want the I2C variants
+           to work! */
+        if (i2c_isa_add_driver(&w83781d_isa_driver))
+                isa_address = 0;
 
         return 0;
 }
@@ -1697,7 +1698,8 @@ sensors_w83781d_init(void)
 static void __exit
 sensors_w83781d_exit(void)
 {
-        i2c_isa_del_driver(&w83781d_isa_driver);
+        if (isa_address)
+                i2c_isa_del_driver(&w83781d_isa_driver);
         i2c_del_driver(&w83781d_driver);
 }
 
diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
index 371ed4f69a97..9e5f885368b4 100644
--- a/drivers/hwmon/w83791d.c
+++ b/drivers/hwmon/w83791d.c
@@ -746,6 +746,52 @@ static ssize_t store_vrm_reg(struct device *dev,
 
 static DEVICE_ATTR(vrm, S_IRUGO | S_IWUSR, show_vrm_reg, store_vrm_reg);
 
+#define IN_UNIT_ATTRS(X) \
+        &sda_in_input[X].dev_attr.attr, \
+        &sda_in_min[X].dev_attr.attr,   \
+        &sda_in_max[X].dev_attr.attr
+
+#define FAN_UNIT_ATTRS(X) \
+        &sda_fan_input[X].dev_attr.attr,        \
+        &sda_fan_min[X].dev_attr.attr,          \
+        &sda_fan_div[X].dev_attr.attr
+
+#define TEMP_UNIT_ATTRS(X) \
+        &sda_temp_input[X].dev_attr.attr,       \
+        &sda_temp_max[X].dev_attr.attr,         \
+        &sda_temp_max_hyst[X].dev_attr.attr
+
+static struct attribute *w83791d_attributes[] = {
+        IN_UNIT_ATTRS(0),
+        IN_UNIT_ATTRS(1),
+        IN_UNIT_ATTRS(2),
+        IN_UNIT_ATTRS(3),
+        IN_UNIT_ATTRS(4),
+        IN_UNIT_ATTRS(5),
+        IN_UNIT_ATTRS(6),
+        IN_UNIT_ATTRS(7),
+        IN_UNIT_ATTRS(8),
+        IN_UNIT_ATTRS(9),
+        FAN_UNIT_ATTRS(0),
+        FAN_UNIT_ATTRS(1),
+        FAN_UNIT_ATTRS(2),
+        FAN_UNIT_ATTRS(3),
+        FAN_UNIT_ATTRS(4),
+        TEMP_UNIT_ATTRS(0),
+        TEMP_UNIT_ATTRS(1),
+        TEMP_UNIT_ATTRS(2),
+        &dev_attr_alarms.attr,
+        &sda_beep_ctrl[0].dev_attr.attr,
+        &sda_beep_ctrl[1].dev_attr.attr,
+        &dev_attr_cpu0_vid.attr,
+        &dev_attr_vrm.attr,
+        NULL
+};
+
+static const struct attribute_group w83791d_group = {
+        .attrs = w83791d_attributes,
+};
+
 /* This function is called when:
      * w83791d_driver is inserted (when this module is loaded), for each
        available adapter
@@ -967,41 +1013,20 @@ static int w83791d_detect(struct i2c_adapter *adapter, int address, int kind)
         }
 
         /* Register sysfs hooks */
+        if ((err = sysfs_create_group(&client->dev.kobj, &w83791d_group)))
+                goto error3;
+
+        /* Everything is ready, now register the working device */
         data->class_dev = hwmon_device_register(dev);
         if (IS_ERR(data->class_dev)) {
                 err = PTR_ERR(data->class_dev);
-                goto error3;
+                goto error4;
         }
 
-        for (i = 0; i < NUMBER_OF_VIN; i++) {
-                device_create_file(dev, &sda_in_input[i].dev_attr);
-                device_create_file(dev, &sda_in_min[i].dev_attr);
-                device_create_file(dev, &sda_in_max[i].dev_attr);
-        }
-
-        for (i = 0; i < NUMBER_OF_FANIN; i++) {
-                device_create_file(dev, &sda_fan_input[i].dev_attr);
-                device_create_file(dev, &sda_fan_div[i].dev_attr);
-                device_create_file(dev, &sda_fan_min[i].dev_attr);
-        }
-
-        for (i = 0; i < NUMBER_OF_TEMPIN; i++) {
-                device_create_file(dev, &sda_temp_input[i].dev_attr);
-                device_create_file(dev, &sda_temp_max[i].dev_attr);
-                device_create_file(dev, &sda_temp_max_hyst[i].dev_attr);
-        }
-
-        device_create_file(dev, &dev_attr_alarms);
-
-        for (i = 0; i < ARRAY_SIZE(sda_beep_ctrl); i++) {
-                device_create_file(dev, &sda_beep_ctrl[i].dev_attr);
-        }
-
-        device_create_file(dev, &dev_attr_cpu0_vid);
-        device_create_file(dev, &dev_attr_vrm);
-
         return 0;
 
+error4:
+        sysfs_remove_group(&client->dev.kobj, &w83791d_group);
 error3:
         if (data->lm75[0] != NULL) {
                 i2c_detach_client(data->lm75[0]);
@@ -1025,8 +1050,10 @@ static int w83791d_detach_client(struct i2c_client *client)
         int err;
 
         /* main client */
-        if (data)
+        if (data) {
                 hwmon_device_unregister(data->class_dev);
+                sysfs_remove_group(&client->dev.kobj, &w83791d_group);
+        }
 
         if ((err = i2c_detach_client(client)))
                 return err;
diff --git a/drivers/i2c/busses/i2c-isa.c b/drivers/i2c/busses/i2c-isa.c
index 4380653748a4..8ed59a2dff53 100644
--- a/drivers/i2c/busses/i2c-isa.c
+++ b/drivers/i2c/busses/i2c-isa.c
@@ -91,7 +91,7 @@ int i2c_isa_add_driver(struct i2c_driver *driver)
         /* Now look for clients */
         res = driver->attach_adapter(&isa_adapter);
         if (res) {
-                dev_err(&isa_adapter.dev,
+                dev_dbg(&isa_adapter.dev,
                         "Driver %s failed to attach adapter, unregistering\n",
                         driver->driver.name);
                 driver_unregister(&driver->driver);