5 files changed, 61 insertions, 4 deletions

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 5cdee8669ea3..59f5a965bdc4 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -700,7 +700,7 @@ static struct pinctrl *create_pinctrl(struct device *dev)
                 }
         }
 
-        /* Add the pinmux to the global list */
+        /* Add the pinctrl handle to the global list */
         list_add_tail(&p->node, &pinctrl_list);
 
         return p;
diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index c5e757157183..bff54bfaff43 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -265,7 +265,7 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev,
         /* create mux map */
         parent = of_get_parent(np);
         if (!parent) {
-                kfree(new_map);
+                devm_kfree(pctldev->dev, new_map);
                 return -EINVAL;
         }
         new_map[0].type = PIN_MAP_TYPE_MUX_GROUP;
diff --git a/drivers/pinctrl/pinctrl-imx53.c b/drivers/pinctrl/pinctrl-imx53.c
index ec4048691775..af571dc3dc63 100644
--- a/drivers/pinctrl/pinctrl-imx53.c
+++ b/drivers/pinctrl/pinctrl-imx53.c
@@ -1371,7 +1371,7 @@ static struct imx_pin_reg imx53_pin_regs[] = {
         IMX_PIN_REG(MX53_PAD_GPIO_8, 0x6C8, 0x338, 0, 0x7F8, 1), /* MX53_PAD_GPIO_8__ESAI1_TX5_RX0 */
         IMX_PIN_REG(MX53_PAD_GPIO_8, 0x6C8, 0x338, 1, 0x000, 0), /* MX53_PAD_GPIO_8__GPIO1_8 */
         IMX_PIN_REG(MX53_PAD_GPIO_8, 0x6C8, 0x338, 2, 0x000, 0), /* MX53_PAD_GPIO_8__EPIT2_EPITO */
-        IMX_PIN_REG(MX53_PAD_GPIO_8, 0x6C8, 0x338, 3, 0x760, 3), /* MX53_PAD_GPIO_8__CAN1_RXCAN */
+        IMX_PIN_REG(MX53_PAD_GPIO_8, 0x6C8, 0x338, 3, 0x760, 2), /* MX53_PAD_GPIO_8__CAN1_RXCAN */
         IMX_PIN_REG(MX53_PAD_GPIO_8, 0x6C8, 0x338, 4, 0x880, 5), /* MX53_PAD_GPIO_8__UART2_RXD_MUX */
         IMX_PIN_REG(MX53_PAD_GPIO_8, 0x6C8, 0x338, 5, 0x000, 0), /* MX53_PAD_GPIO_8__FIRI_TXD */
         IMX_PIN_REG(MX53_PAD_GPIO_8, 0x6C8, 0x338, 6, 0x000, 0), /* MX53_PAD_GPIO_8__SPDIF_SRCLK */
diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c
index ef66f98e9202..015b093287a4 100644
--- a/drivers/pinctrl/pinctrl-nomadik.c
+++ b/drivers/pinctrl/pinctrl-nomadik.c
@@ -259,6 +259,9 @@ static void nmk_prcm_altcx_set_mode(struct nmk_pinctrl *npct,
         const struct prcm_gpiocr_altcx_pin_desc *pin_desc;
         const u16 *gpiocr_regs;
 
+        if (!npct->prcm_base)
+                return;
+
         if (alt_num > PRCM_IDX_GPIOCR_ALTC_MAX) {
                 dev_err(npct->dev, "PRCM GPIOCR: alternate-C%i is invalid\n",
                         alt_num);
@@ -682,6 +685,9 @@ static int nmk_prcm_gpiocr_get_mode(struct pinctrl_dev *pctldev, int gpio)
         const struct prcm_gpiocr_altcx_pin_desc *pin_desc;
         const u16 *gpiocr_regs;
 
+        if (!npct->prcm_base)
+                return NMK_GPIO_ALT_C;
+
         for (i = 0; i < npct->soc->npins_altcx; i++) {
                 if (npct->soc->altcx_pins[i].pin == gpio)
                         break;
@@ -1887,9 +1893,12 @@ static int __devinit nmk_pinctrl_probe(struct platform_device *pdev)
                                 "failed to ioremap PRCM registers\n");
                         return -ENOMEM;
                 }
-        } else {
+        } else if (version == PINCTRL_NMK_STN8815) {
                 dev_info(&pdev->dev,
                          "No PRCM base, assume no ALT-Cx control is available\n");
+        } else {
+                dev_err(&pdev->dev, "missing PRCM base address\n");
+                return -EINVAL;
         }
 
         /*
diff --git a/drivers/pinctrl/pinctrl-sirf.c b/drivers/pinctrl/pinctrl-sirf.c
index a4f0c5e487d5..30e1a38293a0 100644
--- a/drivers/pinctrl/pinctrl-sirf.c
+++ b/drivers/pinctrl/pinctrl-sirf.c
@@ -1663,6 +1663,44 @@ const struct irq_domain_ops sirfsoc_gpio_irq_simple_ops = {
         .xlate = irq_domain_xlate_twocell,
 };
 
+static void sirfsoc_gpio_set_pullup(const u32 *pullups)
+{
+        int i, n;
+        const unsigned long *p = (const unsigned long *)pullups;
+
+        for (i = 0; i < SIRFSOC_GPIO_NO_OF_BANKS; i++) {
+                n = find_first_bit(p + i, BITS_PER_LONG);
+                while (n < BITS_PER_LONG) {
+                        u32 offset = SIRFSOC_GPIO_CTRL(i, n);
+                        u32 val = readl(sgpio_bank[i].chip.regs + offset);
+                        val |= SIRFSOC_GPIO_CTL_PULL_MASK;
+                        val |= SIRFSOC_GPIO_CTL_PULL_HIGH;
+                        writel(val, sgpio_bank[i].chip.regs + offset);
+
+                        n = find_next_bit(p + i, BITS_PER_LONG, n + 1);
+                }
+        }
+}
+
+static void sirfsoc_gpio_set_pulldown(const u32 *pulldowns)
+{
+        int i, n;
+        const unsigned long *p = (const unsigned long *)pulldowns;
+
+        for (i = 0; i < SIRFSOC_GPIO_NO_OF_BANKS; i++) {
+                n = find_first_bit(p + i, BITS_PER_LONG);
+                while (n < BITS_PER_LONG) {
+                        u32 offset = SIRFSOC_GPIO_CTRL(i, n);
+                        u32 val = readl(sgpio_bank[i].chip.regs + offset);
+                        val |= SIRFSOC_GPIO_CTL_PULL_MASK;
+                        val &= ~SIRFSOC_GPIO_CTL_PULL_HIGH;
+                        writel(val, sgpio_bank[i].chip.regs + offset);
+
+                        n = find_next_bit(p + i, BITS_PER_LONG, n + 1);
+                }
+        }
+}
+
 static int __devinit sirfsoc_gpio_probe(struct device_node *np)
 {
         int i, err = 0;
@@ -1671,6 +1709,8 @@ static int __devinit sirfsoc_gpio_probe(struct device_node *np)
         struct platform_device *pdev;
         bool is_marco = false;
 
+        u32 pullups[SIRFSOC_GPIO_NO_OF_BANKS], pulldowns[SIRFSOC_GPIO_NO_OF_BANKS];
+
         pdev = of_find_device_by_node(np);
         if (!pdev)
                 return -ENODEV;
@@ -1726,6 +1766,14 @@ static int __devinit sirfsoc_gpio_probe(struct device_node *np)
                 irq_set_handler_data(bank->parent_irq, bank);
         }
 
+        if (!of_property_read_u32_array(np, "sirf,pullups", pullups,
+                SIRFSOC_GPIO_NO_OF_BANKS))
+                sirfsoc_gpio_set_pullup(pullups);
+
+        if (!of_property_read_u32_array(np, "sirf,pulldowns", pulldowns,
+                SIRFSOC_GPIO_NO_OF_BANKS))
+                sirfsoc_gpio_set_pulldown(pulldowns);
+
         return 0;
 
 out: