diff options
Diffstat (limited to 'drivers')
64 files changed, 625 insertions, 328 deletions
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index e1284b8dc6ee..3270d3c8ba4e 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c | |||
@@ -908,9 +908,6 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device) | |||
908 | device->cap._DDC = 1; | 908 | device->cap._DDC = 1; |
909 | } | 909 | } |
910 | 910 | ||
911 | if (acpi_video_init_brightness(device)) | ||
912 | return; | ||
913 | |||
914 | if (acpi_video_backlight_support()) { | 911 | if (acpi_video_backlight_support()) { |
915 | struct backlight_properties props; | 912 | struct backlight_properties props; |
916 | struct pci_dev *pdev; | 913 | struct pci_dev *pdev; |
@@ -920,6 +917,9 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device) | |||
920 | static int count = 0; | 917 | static int count = 0; |
921 | char *name; | 918 | char *name; |
922 | 919 | ||
920 | result = acpi_video_init_brightness(device); | ||
921 | if (result) | ||
922 | return; | ||
923 | name = kasprintf(GFP_KERNEL, "acpi_video%d", count); | 923 | name = kasprintf(GFP_KERNEL, "acpi_video%d", count); |
924 | if (!name) | 924 | if (!name) |
925 | return; | 925 | return; |
@@ -979,11 +979,6 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device) | |||
979 | if (result) | 979 | if (result) |
980 | printk(KERN_ERR PREFIX "Create sysfs link\n"); | 980 | printk(KERN_ERR PREFIX "Create sysfs link\n"); |
981 | 981 | ||
982 | } else { | ||
983 | /* Remove the brightness object. */ | ||
984 | kfree(device->brightness->levels); | ||
985 | kfree(device->brightness); | ||
986 | device->brightness = NULL; | ||
987 | } | 982 | } |
988 | } | 983 | } |
989 | 984 | ||
diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index 1c41722bb7e2..20fd337a5731 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c | |||
@@ -289,24 +289,24 @@ static int sata_pmp_configure(struct ata_device *dev, int print_info) | |||
289 | 289 | ||
290 | /* Disable sending Early R_OK. | 290 | /* Disable sending Early R_OK. |
291 | * With "cached read" HDD testing and multiple ports busy on a SATA | 291 | * With "cached read" HDD testing and multiple ports busy on a SATA |
292 | * host controller, 3726 PMP will very rarely drop a deferred | 292 | * host controller, 3x26 PMP will very rarely drop a deferred |
293 | * R_OK that was intended for the host. Symptom will be all | 293 | * R_OK that was intended for the host. Symptom will be all |
294 | * 5 drives under test will timeout, get reset, and recover. | 294 | * 5 drives under test will timeout, get reset, and recover. |
295 | */ | 295 | */ |
296 | if (vendor == 0x1095 && devid == 0x3726) { | 296 | if (vendor == 0x1095 && (devid == 0x3726 || devid == 0x3826)) { |
297 | u32 reg; | 297 | u32 reg; |
298 | 298 | ||
299 | err_mask = sata_pmp_read(&ap->link, PMP_GSCR_SII_POL, ®); | 299 | err_mask = sata_pmp_read(&ap->link, PMP_GSCR_SII_POL, ®); |
300 | if (err_mask) { | 300 | if (err_mask) { |
301 | rc = -EIO; | 301 | rc = -EIO; |
302 | reason = "failed to read Sil3726 Private Register"; | 302 | reason = "failed to read Sil3x26 Private Register"; |
303 | goto fail; | 303 | goto fail; |
304 | } | 304 | } |
305 | reg &= ~0x1; | 305 | reg &= ~0x1; |
306 | err_mask = sata_pmp_write(&ap->link, PMP_GSCR_SII_POL, reg); | 306 | err_mask = sata_pmp_write(&ap->link, PMP_GSCR_SII_POL, reg); |
307 | if (err_mask) { | 307 | if (err_mask) { |
308 | rc = -EIO; | 308 | rc = -EIO; |
309 | reason = "failed to write Sil3726 Private Register"; | 309 | reason = "failed to write Sil3x26 Private Register"; |
310 | goto fail; | 310 | goto fail; |
311 | } | 311 | } |
312 | } | 312 | } |
@@ -383,8 +383,8 @@ static void sata_pmp_quirks(struct ata_port *ap) | |||
383 | u16 devid = sata_pmp_gscr_devid(gscr); | 383 | u16 devid = sata_pmp_gscr_devid(gscr); |
384 | struct ata_link *link; | 384 | struct ata_link *link; |
385 | 385 | ||
386 | if (vendor == 0x1095 && devid == 0x3726) { | 386 | if (vendor == 0x1095 && (devid == 0x3726 || devid == 0x3826)) { |
387 | /* sil3726 quirks */ | 387 | /* sil3x26 quirks */ |
388 | ata_for_each_link(link, ap, EDGE) { | 388 | ata_for_each_link(link, ap, EDGE) { |
389 | /* link reports offline after LPM */ | 389 | /* link reports offline after LPM */ |
390 | link->flags |= ATA_LFLAG_NO_LPM; | 390 | link->flags |= ATA_LFLAG_NO_LPM; |
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index 19720a0a4a65..851bd3f43ac6 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c | |||
@@ -293,6 +293,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, | |||
293 | { | 293 | { |
294 | struct sata_fsl_host_priv *host_priv = host->private_data; | 294 | struct sata_fsl_host_priv *host_priv = host->private_data; |
295 | void __iomem *hcr_base = host_priv->hcr_base; | 295 | void __iomem *hcr_base = host_priv->hcr_base; |
296 | unsigned long flags; | ||
296 | 297 | ||
297 | if (count > ICC_MAX_INT_COUNT_THRESHOLD) | 298 | if (count > ICC_MAX_INT_COUNT_THRESHOLD) |
298 | count = ICC_MAX_INT_COUNT_THRESHOLD; | 299 | count = ICC_MAX_INT_COUNT_THRESHOLD; |
@@ -305,12 +306,12 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host, | |||
305 | (count > ICC_MIN_INT_COUNT_THRESHOLD)) | 306 | (count > ICC_MIN_INT_COUNT_THRESHOLD)) |
306 | ticks = ICC_SAFE_INT_TICKS; | 307 | ticks = ICC_SAFE_INT_TICKS; |
307 | 308 | ||
308 | spin_lock(&host->lock); | 309 | spin_lock_irqsave(&host->lock, flags); |
309 | iowrite32((count << 24 | ticks), hcr_base + ICC); | 310 | iowrite32((count << 24 | ticks), hcr_base + ICC); |
310 | 311 | ||
311 | intr_coalescing_count = count; | 312 | intr_coalescing_count = count; |
312 | intr_coalescing_ticks = ticks; | 313 | intr_coalescing_ticks = ticks; |
313 | spin_unlock(&host->lock); | 314 | spin_unlock_irqrestore(&host->lock, flags); |
314 | 315 | ||
315 | DPRINTK("interrupt coalescing, count = 0x%x, ticks = %x\n", | 316 | DPRINTK("interrupt coalescing, count = 0x%x, ticks = %x\n", |
316 | intr_coalescing_count, intr_coalescing_ticks); | 317 | intr_coalescing_count, intr_coalescing_ticks); |
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c index d047d92a456f..e9a4f46d962e 100644 --- a/drivers/ata/sata_highbank.c +++ b/drivers/ata/sata_highbank.c | |||
@@ -86,11 +86,11 @@ struct ecx_plat_data { | |||
86 | 86 | ||
87 | #define SGPIO_SIGNALS 3 | 87 | #define SGPIO_SIGNALS 3 |
88 | #define ECX_ACTIVITY_BITS 0x300000 | 88 | #define ECX_ACTIVITY_BITS 0x300000 |
89 | #define ECX_ACTIVITY_SHIFT 2 | 89 | #define ECX_ACTIVITY_SHIFT 0 |
90 | #define ECX_LOCATE_BITS 0x80000 | 90 | #define ECX_LOCATE_BITS 0x80000 |
91 | #define ECX_LOCATE_SHIFT 1 | 91 | #define ECX_LOCATE_SHIFT 1 |
92 | #define ECX_FAULT_BITS 0x400000 | 92 | #define ECX_FAULT_BITS 0x400000 |
93 | #define ECX_FAULT_SHIFT 0 | 93 | #define ECX_FAULT_SHIFT 2 |
94 | static inline int sgpio_bit_shift(struct ecx_plat_data *pdata, u32 port, | 94 | static inline int sgpio_bit_shift(struct ecx_plat_data *pdata, u32 port, |
95 | u32 shift) | 95 | u32 shift) |
96 | { | 96 | { |
diff --git a/drivers/base/memory.c b/drivers/base/memory.c index 2b7813ec6d02..ec386ee9cb22 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c | |||
@@ -141,6 +141,8 @@ static ssize_t show_mem_removable(struct device *dev, | |||
141 | container_of(dev, struct memory_block, dev); | 141 | container_of(dev, struct memory_block, dev); |
142 | 142 | ||
143 | for (i = 0; i < sections_per_block; i++) { | 143 | for (i = 0; i < sections_per_block; i++) { |
144 | if (!present_section_nr(mem->start_section_nr + i)) | ||
145 | continue; | ||
144 | pfn = section_nr_to_pfn(mem->start_section_nr + i); | 146 | pfn = section_nr_to_pfn(mem->start_section_nr + i); |
145 | ret &= is_mem_section_removable(pfn, PAGES_PER_SECTION); | 147 | ret &= is_mem_section_removable(pfn, PAGES_PER_SECTION); |
146 | } | 148 | } |
diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c index 5c1435c4e210..0fccc99881fd 100644 --- a/drivers/base/regmap/regcache-rbtree.c +++ b/drivers/base/regmap/regcache-rbtree.c | |||
@@ -332,7 +332,7 @@ regcache_rbtree_node_alloc(struct regmap *map, unsigned int reg) | |||
332 | } | 332 | } |
333 | 333 | ||
334 | if (!rbnode->blklen) { | 334 | if (!rbnode->blklen) { |
335 | rbnode->blklen = sizeof(*rbnode); | 335 | rbnode->blklen = 1; |
336 | rbnode->base_reg = reg; | 336 | rbnode->base_reg = reg; |
337 | } | 337 | } |
338 | 338 | ||
diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma500/psb_intel_sdvo.c index 19e36603b23b..3bc8414533c9 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c | |||
@@ -500,7 +500,8 @@ static bool psb_intel_sdvo_read_response(struct psb_intel_sdvo *psb_intel_sdvo, | |||
500 | &status)) | 500 | &status)) |
501 | goto log_fail; | 501 | goto log_fail; |
502 | 502 | ||
503 | while (status == SDVO_CMD_STATUS_PENDING && retry--) { | 503 | while ((status == SDVO_CMD_STATUS_PENDING || |
504 | status == SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED) && retry--) { | ||
504 | udelay(15); | 505 | udelay(15); |
505 | if (!psb_intel_sdvo_read_byte(psb_intel_sdvo, | 506 | if (!psb_intel_sdvo_read_byte(psb_intel_sdvo, |
506 | SDVO_I2C_CMD_STATUS, | 507 | SDVO_I2C_CMD_STATUS, |
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 6f514297c483..342f1f336168 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h | |||
@@ -752,6 +752,8 @@ | |||
752 | will not assert AGPBUSY# and will only | 752 | will not assert AGPBUSY# and will only |
753 | be delivered when out of C3. */ | 753 | be delivered when out of C3. */ |
754 | #define INSTPM_FORCE_ORDERING (1<<7) /* GEN6+ */ | 754 | #define INSTPM_FORCE_ORDERING (1<<7) /* GEN6+ */ |
755 | #define INSTPM_TLB_INVALIDATE (1<<9) | ||
756 | #define INSTPM_SYNC_FLUSH (1<<5) | ||
755 | #define ACTHD 0x020c8 | 757 | #define ACTHD 0x020c8 |
756 | #define FW_BLC 0x020d8 | 758 | #define FW_BLC 0x020d8 |
757 | #define FW_BLC2 0x020dc | 759 | #define FW_BLC2 0x020dc |
@@ -4438,7 +4440,7 @@ | |||
4438 | #define EDP_LINK_TRAIN_600MV_0DB_IVB (0x30 <<22) | 4440 | #define EDP_LINK_TRAIN_600MV_0DB_IVB (0x30 <<22) |
4439 | #define EDP_LINK_TRAIN_600MV_3_5DB_IVB (0x36 <<22) | 4441 | #define EDP_LINK_TRAIN_600MV_3_5DB_IVB (0x36 <<22) |
4440 | #define EDP_LINK_TRAIN_800MV_0DB_IVB (0x38 <<22) | 4442 | #define EDP_LINK_TRAIN_800MV_0DB_IVB (0x38 <<22) |
4441 | #define EDP_LINK_TRAIN_800MV_3_5DB_IVB (0x33 <<22) | 4443 | #define EDP_LINK_TRAIN_800MV_3_5DB_IVB (0x3e <<22) |
4442 | 4444 | ||
4443 | /* legacy values */ | 4445 | /* legacy values */ |
4444 | #define EDP_LINK_TRAIN_500MV_0DB_IVB (0x00 <<22) | 4446 | #define EDP_LINK_TRAIN_500MV_0DB_IVB (0x00 <<22) |
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 664118d8c1d6..079ef0129e74 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c | |||
@@ -968,6 +968,18 @@ void intel_ring_setup_status_page(struct intel_ring_buffer *ring) | |||
968 | 968 | ||
969 | I915_WRITE(mmio, (u32)ring->status_page.gfx_addr); | 969 | I915_WRITE(mmio, (u32)ring->status_page.gfx_addr); |
970 | POSTING_READ(mmio); | 970 | POSTING_READ(mmio); |
971 | |||
972 | /* Flush the TLB for this page */ | ||
973 | if (INTEL_INFO(dev)->gen >= 6) { | ||
974 | u32 reg = RING_INSTPM(ring->mmio_base); | ||
975 | I915_WRITE(reg, | ||
976 | _MASKED_BIT_ENABLE(INSTPM_TLB_INVALIDATE | | ||
977 | INSTPM_SYNC_FLUSH)); | ||
978 | if (wait_for((I915_READ(reg) & INSTPM_SYNC_FLUSH) == 0, | ||
979 | 1000)) | ||
980 | DRM_ERROR("%s: wait for SyncFlush to complete for TLB invalidation timed out\n", | ||
981 | ring->name); | ||
982 | } | ||
971 | } | 983 | } |
972 | 984 | ||
973 | static int | 985 | static int |
diff --git a/drivers/gpu/drm/nouveau/core/core/mm.c b/drivers/gpu/drm/nouveau/core/core/mm.c index d8291724dbd4..7a4e0891c5f8 100644 --- a/drivers/gpu/drm/nouveau/core/core/mm.c +++ b/drivers/gpu/drm/nouveau/core/core/mm.c | |||
@@ -98,6 +98,8 @@ nouveau_mm_head(struct nouveau_mm *mm, u8 type, u32 size_max, u32 size_min, | |||
98 | u32 splitoff; | 98 | u32 splitoff; |
99 | u32 s, e; | 99 | u32 s, e; |
100 | 100 | ||
101 | BUG_ON(!type); | ||
102 | |||
101 | list_for_each_entry(this, &mm->free, fl_entry) { | 103 | list_for_each_entry(this, &mm->free, fl_entry) { |
102 | e = this->offset + this->length; | 104 | e = this->offset + this->length; |
103 | s = this->offset; | 105 | s = this->offset; |
@@ -162,6 +164,8 @@ nouveau_mm_tail(struct nouveau_mm *mm, u8 type, u32 size_max, u32 size_min, | |||
162 | struct nouveau_mm_node *prev, *this, *next; | 164 | struct nouveau_mm_node *prev, *this, *next; |
163 | u32 mask = align - 1; | 165 | u32 mask = align - 1; |
164 | 166 | ||
167 | BUG_ON(!type); | ||
168 | |||
165 | list_for_each_entry_reverse(this, &mm->free, fl_entry) { | 169 | list_for_each_entry_reverse(this, &mm->free, fl_entry) { |
166 | u32 e = this->offset + this->length; | 170 | u32 e = this->offset + this->length; |
167 | u32 s = this->offset; | 171 | u32 s = this->offset; |
diff --git a/drivers/gpu/drm/nouveau/core/include/subdev/mc.h b/drivers/gpu/drm/nouveau/core/include/subdev/mc.h index d5502267c30f..9d2cd2006250 100644 --- a/drivers/gpu/drm/nouveau/core/include/subdev/mc.h +++ b/drivers/gpu/drm/nouveau/core/include/subdev/mc.h | |||
@@ -20,8 +20,8 @@ nouveau_mc(void *obj) | |||
20 | return (void *)nv_device(obj)->subdev[NVDEV_SUBDEV_MC]; | 20 | return (void *)nv_device(obj)->subdev[NVDEV_SUBDEV_MC]; |
21 | } | 21 | } |
22 | 22 | ||
23 | #define nouveau_mc_create(p,e,o,d) \ | 23 | #define nouveau_mc_create(p,e,o,m,d) \ |
24 | nouveau_mc_create_((p), (e), (o), sizeof(**d), (void **)d) | 24 | nouveau_mc_create_((p), (e), (o), (m), sizeof(**d), (void **)d) |
25 | #define nouveau_mc_destroy(p) ({ \ | 25 | #define nouveau_mc_destroy(p) ({ \ |
26 | struct nouveau_mc *pmc = (p); _nouveau_mc_dtor(nv_object(pmc)); \ | 26 | struct nouveau_mc *pmc = (p); _nouveau_mc_dtor(nv_object(pmc)); \ |
27 | }) | 27 | }) |
@@ -33,7 +33,8 @@ nouveau_mc(void *obj) | |||
33 | }) | 33 | }) |
34 | 34 | ||
35 | int nouveau_mc_create_(struct nouveau_object *, struct nouveau_object *, | 35 | int nouveau_mc_create_(struct nouveau_object *, struct nouveau_object *, |
36 | struct nouveau_oclass *, int, void **); | 36 | struct nouveau_oclass *, const struct nouveau_mc_intr *, |
37 | int, void **); | ||
37 | void _nouveau_mc_dtor(struct nouveau_object *); | 38 | void _nouveau_mc_dtor(struct nouveau_object *); |
38 | int _nouveau_mc_init(struct nouveau_object *); | 39 | int _nouveau_mc_init(struct nouveau_object *); |
39 | int _nouveau_mc_fini(struct nouveau_object *, bool); | 40 | int _nouveau_mc_fini(struct nouveau_object *, bool); |
diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/ramnv49.c b/drivers/gpu/drm/nouveau/core/subdev/fb/ramnv49.c index 19e3a9a63a02..ab7ef0ac9e34 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/fb/ramnv49.c +++ b/drivers/gpu/drm/nouveau/core/subdev/fb/ramnv49.c | |||
@@ -40,15 +40,15 @@ nv49_ram_create(struct nouveau_object *parent, struct nouveau_object *engine, | |||
40 | return ret; | 40 | return ret; |
41 | 41 | ||
42 | switch (pfb914 & 0x00000003) { | 42 | switch (pfb914 & 0x00000003) { |
43 | case 0x00000000: pfb->ram->type = NV_MEM_TYPE_DDR1; break; | 43 | case 0x00000000: ram->type = NV_MEM_TYPE_DDR1; break; |
44 | case 0x00000001: pfb->ram->type = NV_MEM_TYPE_DDR2; break; | 44 | case 0x00000001: ram->type = NV_MEM_TYPE_DDR2; break; |
45 | case 0x00000002: pfb->ram->type = NV_MEM_TYPE_GDDR3; break; | 45 | case 0x00000002: ram->type = NV_MEM_TYPE_GDDR3; break; |
46 | case 0x00000003: break; | 46 | case 0x00000003: break; |
47 | } | 47 | } |
48 | 48 | ||
49 | pfb->ram->size = nv_rd32(pfb, 0x10020c) & 0xff000000; | 49 | ram->size = nv_rd32(pfb, 0x10020c) & 0xff000000; |
50 | pfb->ram->parts = (nv_rd32(pfb, 0x100200) & 0x00000003) + 1; | 50 | ram->parts = (nv_rd32(pfb, 0x100200) & 0x00000003) + 1; |
51 | pfb->ram->tags = nv_rd32(pfb, 0x100320); | 51 | ram->tags = nv_rd32(pfb, 0x100320); |
52 | return 0; | 52 | return 0; |
53 | } | 53 | } |
54 | 54 | ||
diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/ramnv4e.c b/drivers/gpu/drm/nouveau/core/subdev/fb/ramnv4e.c index 7192aa6e5577..63a6aab86028 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/fb/ramnv4e.c +++ b/drivers/gpu/drm/nouveau/core/subdev/fb/ramnv4e.c | |||
@@ -38,8 +38,8 @@ nv4e_ram_create(struct nouveau_object *parent, struct nouveau_object *engine, | |||
38 | if (ret) | 38 | if (ret) |
39 | return ret; | 39 | return ret; |
40 | 40 | ||
41 | pfb->ram->size = nv_rd32(pfb, 0x10020c) & 0xff000000; | 41 | ram->size = nv_rd32(pfb, 0x10020c) & 0xff000000; |
42 | pfb->ram->type = NV_MEM_TYPE_STOLEN; | 42 | ram->type = NV_MEM_TYPE_STOLEN; |
43 | return 0; | 43 | return 0; |
44 | } | 44 | } |
45 | 45 | ||
diff --git a/drivers/gpu/drm/nouveau/core/subdev/ltcg/nvc0.c b/drivers/gpu/drm/nouveau/core/subdev/ltcg/nvc0.c index bcca883018f4..cce65cc56514 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/ltcg/nvc0.c +++ b/drivers/gpu/drm/nouveau/core/subdev/ltcg/nvc0.c | |||
@@ -30,8 +30,9 @@ struct nvc0_ltcg_priv { | |||
30 | struct nouveau_ltcg base; | 30 | struct nouveau_ltcg base; |
31 | u32 part_nr; | 31 | u32 part_nr; |
32 | u32 subp_nr; | 32 | u32 subp_nr; |
33 | struct nouveau_mm tags; | ||
34 | u32 num_tags; | 33 | u32 num_tags; |
34 | u32 tag_base; | ||
35 | struct nouveau_mm tags; | ||
35 | struct nouveau_mm_node *tag_ram; | 36 | struct nouveau_mm_node *tag_ram; |
36 | }; | 37 | }; |
37 | 38 | ||
@@ -117,10 +118,6 @@ nvc0_ltcg_init_tag_ram(struct nouveau_fb *pfb, struct nvc0_ltcg_priv *priv) | |||
117 | u32 tag_size, tag_margin, tag_align; | 118 | u32 tag_size, tag_margin, tag_align; |
118 | int ret; | 119 | int ret; |
119 | 120 | ||
120 | nv_wr32(priv, 0x17e8d8, priv->part_nr); | ||
121 | if (nv_device(pfb)->card_type >= NV_E0) | ||
122 | nv_wr32(priv, 0x17e000, priv->part_nr); | ||
123 | |||
124 | /* tags for 1/4 of VRAM should be enough (8192/4 per GiB of VRAM) */ | 121 | /* tags for 1/4 of VRAM should be enough (8192/4 per GiB of VRAM) */ |
125 | priv->num_tags = (pfb->ram->size >> 17) / 4; | 122 | priv->num_tags = (pfb->ram->size >> 17) / 4; |
126 | if (priv->num_tags > (1 << 17)) | 123 | if (priv->num_tags > (1 << 17)) |
@@ -142,7 +139,7 @@ nvc0_ltcg_init_tag_ram(struct nouveau_fb *pfb, struct nvc0_ltcg_priv *priv) | |||
142 | tag_size += tag_align; | 139 | tag_size += tag_align; |
143 | tag_size = (tag_size + 0xfff) >> 12; /* round up */ | 140 | tag_size = (tag_size + 0xfff) >> 12; /* round up */ |
144 | 141 | ||
145 | ret = nouveau_mm_tail(&pfb->vram, 0, tag_size, tag_size, 1, | 142 | ret = nouveau_mm_tail(&pfb->vram, 1, tag_size, tag_size, 1, |
146 | &priv->tag_ram); | 143 | &priv->tag_ram); |
147 | if (ret) { | 144 | if (ret) { |
148 | priv->num_tags = 0; | 145 | priv->num_tags = 0; |
@@ -152,7 +149,7 @@ nvc0_ltcg_init_tag_ram(struct nouveau_fb *pfb, struct nvc0_ltcg_priv *priv) | |||
152 | tag_base += tag_align - 1; | 149 | tag_base += tag_align - 1; |
153 | ret = do_div(tag_base, tag_align); | 150 | ret = do_div(tag_base, tag_align); |
154 | 151 | ||
155 | nv_wr32(priv, 0x17e8d4, tag_base); | 152 | priv->tag_base = tag_base; |
156 | } | 153 | } |
157 | ret = nouveau_mm_init(&priv->tags, 0, priv->num_tags, 1); | 154 | ret = nouveau_mm_init(&priv->tags, 0, priv->num_tags, 1); |
158 | 155 | ||
@@ -182,8 +179,6 @@ nvc0_ltcg_ctor(struct nouveau_object *parent, struct nouveau_object *engine, | |||
182 | } | 179 | } |
183 | priv->subp_nr = nv_rd32(priv, 0x17e8dc) >> 28; | 180 | priv->subp_nr = nv_rd32(priv, 0x17e8dc) >> 28; |
184 | 181 | ||
185 | nv_mask(priv, 0x17e820, 0x00100000, 0x00000000); /* INTR_EN &= ~0x10 */ | ||
186 | |||
187 | ret = nvc0_ltcg_init_tag_ram(pfb, priv); | 182 | ret = nvc0_ltcg_init_tag_ram(pfb, priv); |
188 | if (ret) | 183 | if (ret) |
189 | return ret; | 184 | return ret; |
@@ -209,13 +204,32 @@ nvc0_ltcg_dtor(struct nouveau_object *object) | |||
209 | nouveau_ltcg_destroy(ltcg); | 204 | nouveau_ltcg_destroy(ltcg); |
210 | } | 205 | } |
211 | 206 | ||
207 | static int | ||
208 | nvc0_ltcg_init(struct nouveau_object *object) | ||
209 | { | ||
210 | struct nouveau_ltcg *ltcg = (struct nouveau_ltcg *)object; | ||
211 | struct nvc0_ltcg_priv *priv = (struct nvc0_ltcg_priv *)ltcg; | ||
212 | int ret; | ||
213 | |||
214 | ret = nouveau_ltcg_init(ltcg); | ||
215 | if (ret) | ||
216 | return ret; | ||
217 | |||
218 | nv_mask(priv, 0x17e820, 0x00100000, 0x00000000); /* INTR_EN &= ~0x10 */ | ||
219 | nv_wr32(priv, 0x17e8d8, priv->part_nr); | ||
220 | if (nv_device(ltcg)->card_type >= NV_E0) | ||
221 | nv_wr32(priv, 0x17e000, priv->part_nr); | ||
222 | nv_wr32(priv, 0x17e8d4, priv->tag_base); | ||
223 | return 0; | ||
224 | } | ||
225 | |||
212 | struct nouveau_oclass | 226 | struct nouveau_oclass |
213 | nvc0_ltcg_oclass = { | 227 | nvc0_ltcg_oclass = { |
214 | .handle = NV_SUBDEV(LTCG, 0xc0), | 228 | .handle = NV_SUBDEV(LTCG, 0xc0), |
215 | .ofuncs = &(struct nouveau_ofuncs) { | 229 | .ofuncs = &(struct nouveau_ofuncs) { |
216 | .ctor = nvc0_ltcg_ctor, | 230 | .ctor = nvc0_ltcg_ctor, |
217 | .dtor = nvc0_ltcg_dtor, | 231 | .dtor = nvc0_ltcg_dtor, |
218 | .init = _nouveau_ltcg_init, | 232 | .init = nvc0_ltcg_init, |
219 | .fini = _nouveau_ltcg_fini, | 233 | .fini = _nouveau_ltcg_fini, |
220 | }, | 234 | }, |
221 | }; | 235 | }; |
diff --git a/drivers/gpu/drm/nouveau/core/subdev/mc/base.c b/drivers/gpu/drm/nouveau/core/subdev/mc/base.c index 1c0330b8c9a4..ec9cd6f10f91 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/mc/base.c +++ b/drivers/gpu/drm/nouveau/core/subdev/mc/base.c | |||
@@ -80,7 +80,9 @@ _nouveau_mc_dtor(struct nouveau_object *object) | |||
80 | 80 | ||
81 | int | 81 | int |
82 | nouveau_mc_create_(struct nouveau_object *parent, struct nouveau_object *engine, | 82 | nouveau_mc_create_(struct nouveau_object *parent, struct nouveau_object *engine, |
83 | struct nouveau_oclass *oclass, int length, void **pobject) | 83 | struct nouveau_oclass *oclass, |
84 | const struct nouveau_mc_intr *intr_map, | ||
85 | int length, void **pobject) | ||
84 | { | 86 | { |
85 | struct nouveau_device *device = nv_device(parent); | 87 | struct nouveau_device *device = nv_device(parent); |
86 | struct nouveau_mc *pmc; | 88 | struct nouveau_mc *pmc; |
@@ -92,6 +94,8 @@ nouveau_mc_create_(struct nouveau_object *parent, struct nouveau_object *engine, | |||
92 | if (ret) | 94 | if (ret) |
93 | return ret; | 95 | return ret; |
94 | 96 | ||
97 | pmc->intr_map = intr_map; | ||
98 | |||
95 | ret = request_irq(device->pdev->irq, nouveau_mc_intr, | 99 | ret = request_irq(device->pdev->irq, nouveau_mc_intr, |
96 | IRQF_SHARED, "nouveau", pmc); | 100 | IRQF_SHARED, "nouveau", pmc); |
97 | if (ret < 0) | 101 | if (ret < 0) |
diff --git a/drivers/gpu/drm/nouveau/core/subdev/mc/nv04.c b/drivers/gpu/drm/nouveau/core/subdev/mc/nv04.c index 8c769715227b..64aa4edb0d9d 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/mc/nv04.c +++ b/drivers/gpu/drm/nouveau/core/subdev/mc/nv04.c | |||
@@ -50,12 +50,11 @@ nv04_mc_ctor(struct nouveau_object *parent, struct nouveau_object *engine, | |||
50 | struct nv04_mc_priv *priv; | 50 | struct nv04_mc_priv *priv; |
51 | int ret; | 51 | int ret; |
52 | 52 | ||
53 | ret = nouveau_mc_create(parent, engine, oclass, &priv); | 53 | ret = nouveau_mc_create(parent, engine, oclass, nv04_mc_intr, &priv); |
54 | *pobject = nv_object(priv); | 54 | *pobject = nv_object(priv); |
55 | if (ret) | 55 | if (ret) |
56 | return ret; | 56 | return ret; |
57 | 57 | ||
58 | priv->base.intr_map = nv04_mc_intr; | ||
59 | return 0; | 58 | return 0; |
60 | } | 59 | } |
61 | 60 | ||
diff --git a/drivers/gpu/drm/nouveau/core/subdev/mc/nv44.c b/drivers/gpu/drm/nouveau/core/subdev/mc/nv44.c index 51919371810f..d9891782bf28 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/mc/nv44.c +++ b/drivers/gpu/drm/nouveau/core/subdev/mc/nv44.c | |||
@@ -36,12 +36,11 @@ nv44_mc_ctor(struct nouveau_object *parent, struct nouveau_object *engine, | |||
36 | struct nv44_mc_priv *priv; | 36 | struct nv44_mc_priv *priv; |
37 | int ret; | 37 | int ret; |
38 | 38 | ||
39 | ret = nouveau_mc_create(parent, engine, oclass, &priv); | 39 | ret = nouveau_mc_create(parent, engine, oclass, nv04_mc_intr, &priv); |
40 | *pobject = nv_object(priv); | 40 | *pobject = nv_object(priv); |
41 | if (ret) | 41 | if (ret) |
42 | return ret; | 42 | return ret; |
43 | 43 | ||
44 | priv->base.intr_map = nv04_mc_intr; | ||
45 | return 0; | 44 | return 0; |
46 | } | 45 | } |
47 | 46 | ||
diff --git a/drivers/gpu/drm/nouveau/core/subdev/mc/nv50.c b/drivers/gpu/drm/nouveau/core/subdev/mc/nv50.c index f25fc5fc7dd1..2b1afe225db8 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/mc/nv50.c +++ b/drivers/gpu/drm/nouveau/core/subdev/mc/nv50.c | |||
@@ -53,12 +53,11 @@ nv50_mc_ctor(struct nouveau_object *parent, struct nouveau_object *engine, | |||
53 | struct nv50_mc_priv *priv; | 53 | struct nv50_mc_priv *priv; |
54 | int ret; | 54 | int ret; |
55 | 55 | ||
56 | ret = nouveau_mc_create(parent, engine, oclass, &priv); | 56 | ret = nouveau_mc_create(parent, engine, oclass, nv50_mc_intr, &priv); |
57 | *pobject = nv_object(priv); | 57 | *pobject = nv_object(priv); |
58 | if (ret) | 58 | if (ret) |
59 | return ret; | 59 | return ret; |
60 | 60 | ||
61 | priv->base.intr_map = nv50_mc_intr; | ||
62 | return 0; | 61 | return 0; |
63 | } | 62 | } |
64 | 63 | ||
diff --git a/drivers/gpu/drm/nouveau/core/subdev/mc/nv98.c b/drivers/gpu/drm/nouveau/core/subdev/mc/nv98.c index e82fd21b5041..0d57b4d3e001 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/mc/nv98.c +++ b/drivers/gpu/drm/nouveau/core/subdev/mc/nv98.c | |||
@@ -54,12 +54,11 @@ nv98_mc_ctor(struct nouveau_object *parent, struct nouveau_object *engine, | |||
54 | struct nv98_mc_priv *priv; | 54 | struct nv98_mc_priv *priv; |
55 | int ret; | 55 | int ret; |
56 | 56 | ||
57 | ret = nouveau_mc_create(parent, engine, oclass, &priv); | 57 | ret = nouveau_mc_create(parent, engine, oclass, nv98_mc_intr, &priv); |
58 | *pobject = nv_object(priv); | 58 | *pobject = nv_object(priv); |
59 | if (ret) | 59 | if (ret) |
60 | return ret; | 60 | return ret; |
61 | 61 | ||
62 | priv->base.intr_map = nv98_mc_intr; | ||
63 | return 0; | 62 | return 0; |
64 | } | 63 | } |
65 | 64 | ||
diff --git a/drivers/gpu/drm/nouveau/core/subdev/mc/nvc0.c b/drivers/gpu/drm/nouveau/core/subdev/mc/nvc0.c index c5da3babbc62..104175c5a2dd 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/mc/nvc0.c +++ b/drivers/gpu/drm/nouveau/core/subdev/mc/nvc0.c | |||
@@ -57,12 +57,11 @@ nvc0_mc_ctor(struct nouveau_object *parent, struct nouveau_object *engine, | |||
57 | struct nvc0_mc_priv *priv; | 57 | struct nvc0_mc_priv *priv; |
58 | int ret; | 58 | int ret; |
59 | 59 | ||
60 | ret = nouveau_mc_create(parent, engine, oclass, &priv); | 60 | ret = nouveau_mc_create(parent, engine, oclass, nvc0_mc_intr, &priv); |
61 | *pobject = nv_object(priv); | 61 | *pobject = nv_object(priv); |
62 | if (ret) | 62 | if (ret) |
63 | return ret; | 63 | return ret; |
64 | 64 | ||
65 | priv->base.intr_map = nvc0_mc_intr; | ||
66 | return 0; | 65 | return 0; |
67 | } | 66 | } |
68 | 67 | ||
diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau/dispnv04/crtc.c index 0782bd2f1e04..6a13ffb53bdb 100644 --- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c +++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c | |||
@@ -606,6 +606,24 @@ nv_crtc_mode_set_regs(struct drm_crtc *crtc, struct drm_display_mode * mode) | |||
606 | regp->ramdac_a34 = 0x1; | 606 | regp->ramdac_a34 = 0x1; |
607 | } | 607 | } |
608 | 608 | ||
609 | static int | ||
610 | nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb) | ||
611 | { | ||
612 | struct nv04_display *disp = nv04_display(crtc->dev); | ||
613 | struct nouveau_framebuffer *nvfb = nouveau_framebuffer(crtc->fb); | ||
614 | struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc); | ||
615 | int ret; | ||
616 | |||
617 | ret = nouveau_bo_pin(nvfb->nvbo, TTM_PL_FLAG_VRAM); | ||
618 | if (ret == 0) { | ||
619 | if (disp->image[nv_crtc->index]) | ||
620 | nouveau_bo_unpin(disp->image[nv_crtc->index]); | ||
621 | nouveau_bo_ref(nvfb->nvbo, &disp->image[nv_crtc->index]); | ||
622 | } | ||
623 | |||
624 | return ret; | ||
625 | } | ||
626 | |||
609 | /** | 627 | /** |
610 | * Sets up registers for the given mode/adjusted_mode pair. | 628 | * Sets up registers for the given mode/adjusted_mode pair. |
611 | * | 629 | * |
@@ -622,10 +640,15 @@ nv_crtc_mode_set(struct drm_crtc *crtc, struct drm_display_mode *mode, | |||
622 | struct drm_device *dev = crtc->dev; | 640 | struct drm_device *dev = crtc->dev; |
623 | struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc); | 641 | struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc); |
624 | struct nouveau_drm *drm = nouveau_drm(dev); | 642 | struct nouveau_drm *drm = nouveau_drm(dev); |
643 | int ret; | ||
625 | 644 | ||
626 | NV_DEBUG(drm, "CTRC mode on CRTC %d:\n", nv_crtc->index); | 645 | NV_DEBUG(drm, "CTRC mode on CRTC %d:\n", nv_crtc->index); |
627 | drm_mode_debug_printmodeline(adjusted_mode); | 646 | drm_mode_debug_printmodeline(adjusted_mode); |
628 | 647 | ||
648 | ret = nv_crtc_swap_fbs(crtc, old_fb); | ||
649 | if (ret) | ||
650 | return ret; | ||
651 | |||
629 | /* unlock must come after turning off FP_TG_CONTROL in output_prepare */ | 652 | /* unlock must come after turning off FP_TG_CONTROL in output_prepare */ |
630 | nv_lock_vga_crtc_shadow(dev, nv_crtc->index, -1); | 653 | nv_lock_vga_crtc_shadow(dev, nv_crtc->index, -1); |
631 | 654 | ||
@@ -722,6 +745,7 @@ static void nv_crtc_commit(struct drm_crtc *crtc) | |||
722 | 745 | ||
723 | static void nv_crtc_destroy(struct drm_crtc *crtc) | 746 | static void nv_crtc_destroy(struct drm_crtc *crtc) |
724 | { | 747 | { |
748 | struct nv04_display *disp = nv04_display(crtc->dev); | ||
725 | struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc); | 749 | struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc); |
726 | 750 | ||
727 | if (!nv_crtc) | 751 | if (!nv_crtc) |
@@ -729,6 +753,10 @@ static void nv_crtc_destroy(struct drm_crtc *crtc) | |||
729 | 753 | ||
730 | drm_crtc_cleanup(crtc); | 754 | drm_crtc_cleanup(crtc); |
731 | 755 | ||
756 | if (disp->image[nv_crtc->index]) | ||
757 | nouveau_bo_unpin(disp->image[nv_crtc->index]); | ||
758 | nouveau_bo_ref(NULL, &disp->image[nv_crtc->index]); | ||
759 | |||
732 | nouveau_bo_unmap(nv_crtc->cursor.nvbo); | 760 | nouveau_bo_unmap(nv_crtc->cursor.nvbo); |
733 | nouveau_bo_unpin(nv_crtc->cursor.nvbo); | 761 | nouveau_bo_unpin(nv_crtc->cursor.nvbo); |
734 | nouveau_bo_ref(NULL, &nv_crtc->cursor.nvbo); | 762 | nouveau_bo_ref(NULL, &nv_crtc->cursor.nvbo); |
@@ -754,6 +782,16 @@ nv_crtc_gamma_load(struct drm_crtc *crtc) | |||
754 | } | 782 | } |
755 | 783 | ||
756 | static void | 784 | static void |
785 | nv_crtc_disable(struct drm_crtc *crtc) | ||
786 | { | ||
787 | struct nv04_display *disp = nv04_display(crtc->dev); | ||
788 | struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc); | ||
789 | if (disp->image[nv_crtc->index]) | ||
790 | nouveau_bo_unpin(disp->image[nv_crtc->index]); | ||
791 | nouveau_bo_ref(NULL, &disp->image[nv_crtc->index]); | ||
792 | } | ||
793 | |||
794 | static void | ||
757 | nv_crtc_gamma_set(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b, uint32_t start, | 795 | nv_crtc_gamma_set(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b, uint32_t start, |
758 | uint32_t size) | 796 | uint32_t size) |
759 | { | 797 | { |
@@ -791,7 +829,6 @@ nv04_crtc_do_mode_set_base(struct drm_crtc *crtc, | |||
791 | struct drm_framebuffer *drm_fb; | 829 | struct drm_framebuffer *drm_fb; |
792 | struct nouveau_framebuffer *fb; | 830 | struct nouveau_framebuffer *fb; |
793 | int arb_burst, arb_lwm; | 831 | int arb_burst, arb_lwm; |
794 | int ret; | ||
795 | 832 | ||
796 | NV_DEBUG(drm, "index %d\n", nv_crtc->index); | 833 | NV_DEBUG(drm, "index %d\n", nv_crtc->index); |
797 | 834 | ||
@@ -801,10 +838,8 @@ nv04_crtc_do_mode_set_base(struct drm_crtc *crtc, | |||
801 | return 0; | 838 | return 0; |
802 | } | 839 | } |
803 | 840 | ||
804 | |||
805 | /* If atomic, we want to switch to the fb we were passed, so | 841 | /* If atomic, we want to switch to the fb we were passed, so |
806 | * now we update pointers to do that. (We don't pin; just | 842 | * now we update pointers to do that. |
807 | * assume we're already pinned and update the base address.) | ||
808 | */ | 843 | */ |
809 | if (atomic) { | 844 | if (atomic) { |
810 | drm_fb = passed_fb; | 845 | drm_fb = passed_fb; |
@@ -812,17 +847,6 @@ nv04_crtc_do_mode_set_base(struct drm_crtc *crtc, | |||
812 | } else { | 847 | } else { |
813 | drm_fb = crtc->fb; | 848 | drm_fb = crtc->fb; |
814 | fb = nouveau_framebuffer(crtc->fb); | 849 | fb = nouveau_framebuffer(crtc->fb); |
815 | /* If not atomic, we can go ahead and pin, and unpin the | ||
816 | * old fb we were passed. | ||
817 | */ | ||
818 | ret = nouveau_bo_pin(fb->nvbo, TTM_PL_FLAG_VRAM); | ||
819 | if (ret) | ||
820 | return ret; | ||
821 | |||
822 | if (passed_fb) { | ||
823 | struct nouveau_framebuffer *ofb = nouveau_framebuffer(passed_fb); | ||
824 | nouveau_bo_unpin(ofb->nvbo); | ||
825 | } | ||
826 | } | 850 | } |
827 | 851 | ||
828 | nv_crtc->fb.offset = fb->nvbo->bo.offset; | 852 | nv_crtc->fb.offset = fb->nvbo->bo.offset; |
@@ -877,6 +901,9 @@ static int | |||
877 | nv04_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y, | 901 | nv04_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y, |
878 | struct drm_framebuffer *old_fb) | 902 | struct drm_framebuffer *old_fb) |
879 | { | 903 | { |
904 | int ret = nv_crtc_swap_fbs(crtc, old_fb); | ||
905 | if (ret) | ||
906 | return ret; | ||
880 | return nv04_crtc_do_mode_set_base(crtc, old_fb, x, y, false); | 907 | return nv04_crtc_do_mode_set_base(crtc, old_fb, x, y, false); |
881 | } | 908 | } |
882 | 909 | ||
@@ -1027,6 +1054,7 @@ static const struct drm_crtc_helper_funcs nv04_crtc_helper_funcs = { | |||
1027 | .mode_set_base = nv04_crtc_mode_set_base, | 1054 | .mode_set_base = nv04_crtc_mode_set_base, |
1028 | .mode_set_base_atomic = nv04_crtc_mode_set_base_atomic, | 1055 | .mode_set_base_atomic = nv04_crtc_mode_set_base_atomic, |
1029 | .load_lut = nv_crtc_gamma_load, | 1056 | .load_lut = nv_crtc_gamma_load, |
1057 | .disable = nv_crtc_disable, | ||
1030 | }; | 1058 | }; |
1031 | 1059 | ||
1032 | int | 1060 | int |
diff --git a/drivers/gpu/drm/nouveau/dispnv04/disp.h b/drivers/gpu/drm/nouveau/dispnv04/disp.h index a0a031dad13f..9928187f0a7d 100644 --- a/drivers/gpu/drm/nouveau/dispnv04/disp.h +++ b/drivers/gpu/drm/nouveau/dispnv04/disp.h | |||
@@ -81,6 +81,7 @@ struct nv04_display { | |||
81 | uint32_t saved_vga_font[4][16384]; | 81 | uint32_t saved_vga_font[4][16384]; |
82 | uint32_t dac_users[4]; | 82 | uint32_t dac_users[4]; |
83 | struct nouveau_object *core; | 83 | struct nouveau_object *core; |
84 | struct nouveau_bo *image[2]; | ||
84 | }; | 85 | }; |
85 | 86 | ||
86 | static inline struct nv04_display * | 87 | static inline struct nv04_display * |
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index 907d20ef6d4d..a03e75deacaf 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c | |||
@@ -577,6 +577,9 @@ nouveau_crtc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb, | |||
577 | ret = nv50_display_flip_next(crtc, fb, chan, 0); | 577 | ret = nv50_display_flip_next(crtc, fb, chan, 0); |
578 | if (ret) | 578 | if (ret) |
579 | goto fail_unreserve; | 579 | goto fail_unreserve; |
580 | } else { | ||
581 | struct nv04_display *dispnv04 = nv04_display(dev); | ||
582 | nouveau_bo_ref(new_bo, &dispnv04->image[nouveau_crtc(crtc)->index]); | ||
580 | } | 583 | } |
581 | 584 | ||
582 | ret = nouveau_page_flip_emit(chan, old_bo, new_bo, s, &fence); | 585 | ret = nouveau_page_flip_emit(chan, old_bo, new_bo, s, &fence); |
diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd0b203..625f80d53dc2 100644 --- a/drivers/gpu/drm/nouveau/nv40_pm.c +++ b/drivers/gpu/drm/nouveau/nv40_pm.c | |||
@@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32 reg, struct nvbios_pll *pll, | |||
131 | if (clk < pll->vco1.max_freq) | 131 | if (clk < pll->vco1.max_freq) |
132 | pll->vco2.max_freq = 0; | 132 | pll->vco2.max_freq = 0; |
133 | 133 | ||
134 | pclk->pll_calc(pclk, pll, clk, &coef); | 134 | ret = pclk->pll_calc(pclk, pll, clk, &coef); |
135 | if (ret == 0) | 135 | if (ret == 0) |
136 | return -ERANGE; | 136 | return -ERANGE; |
137 | 137 | ||
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c index 3751730764a5..1a0bf07fe54b 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c | |||
@@ -29,7 +29,9 @@ | |||
29 | #include <drm/drmP.h> | 29 | #include <drm/drmP.h> |
30 | #include <drm/ttm/ttm_bo_driver.h> | 30 | #include <drm/ttm/ttm_bo_driver.h> |
31 | 31 | ||
32 | #define VMW_PPN_SIZE sizeof(unsigned long) | 32 | #define VMW_PPN_SIZE (sizeof(unsigned long)) |
33 | /* A future safe maximum remap size. */ | ||
34 | #define VMW_PPN_PER_REMAP ((31 * 1024) / VMW_PPN_SIZE) | ||
33 | 35 | ||
34 | static int vmw_gmr2_bind(struct vmw_private *dev_priv, | 36 | static int vmw_gmr2_bind(struct vmw_private *dev_priv, |
35 | struct page *pages[], | 37 | struct page *pages[], |
@@ -38,43 +40,61 @@ static int vmw_gmr2_bind(struct vmw_private *dev_priv, | |||
38 | { | 40 | { |
39 | SVGAFifoCmdDefineGMR2 define_cmd; | 41 | SVGAFifoCmdDefineGMR2 define_cmd; |
40 | SVGAFifoCmdRemapGMR2 remap_cmd; | 42 | SVGAFifoCmdRemapGMR2 remap_cmd; |
41 | uint32_t define_size = sizeof(define_cmd) + 4; | ||
42 | uint32_t remap_size = VMW_PPN_SIZE * num_pages + sizeof(remap_cmd) + 4; | ||
43 | uint32_t *cmd; | 43 | uint32_t *cmd; |
44 | uint32_t *cmd_orig; | 44 | uint32_t *cmd_orig; |
45 | uint32_t define_size = sizeof(define_cmd) + sizeof(*cmd); | ||
46 | uint32_t remap_num = num_pages / VMW_PPN_PER_REMAP + ((num_pages % VMW_PPN_PER_REMAP) > 0); | ||
47 | uint32_t remap_size = VMW_PPN_SIZE * num_pages + (sizeof(remap_cmd) + sizeof(*cmd)) * remap_num; | ||
48 | uint32_t remap_pos = 0; | ||
49 | uint32_t cmd_size = define_size + remap_size; | ||
45 | uint32_t i; | 50 | uint32_t i; |
46 | 51 | ||
47 | cmd_orig = cmd = vmw_fifo_reserve(dev_priv, define_size + remap_size); | 52 | cmd_orig = cmd = vmw_fifo_reserve(dev_priv, cmd_size); |
48 | if (unlikely(cmd == NULL)) | 53 | if (unlikely(cmd == NULL)) |
49 | return -ENOMEM; | 54 | return -ENOMEM; |
50 | 55 | ||
51 | define_cmd.gmrId = gmr_id; | 56 | define_cmd.gmrId = gmr_id; |
52 | define_cmd.numPages = num_pages; | 57 | define_cmd.numPages = num_pages; |
53 | 58 | ||
59 | *cmd++ = SVGA_CMD_DEFINE_GMR2; | ||
60 | memcpy(cmd, &define_cmd, sizeof(define_cmd)); | ||
61 | cmd += sizeof(define_cmd) / sizeof(*cmd); | ||
62 | |||
63 | /* | ||
64 | * Need to split the command if there are too many | ||
65 | * pages that goes into the gmr. | ||
66 | */ | ||
67 | |||
54 | remap_cmd.gmrId = gmr_id; | 68 | remap_cmd.gmrId = gmr_id; |
55 | remap_cmd.flags = (VMW_PPN_SIZE > sizeof(*cmd)) ? | 69 | remap_cmd.flags = (VMW_PPN_SIZE > sizeof(*cmd)) ? |
56 | SVGA_REMAP_GMR2_PPN64 : SVGA_REMAP_GMR2_PPN32; | 70 | SVGA_REMAP_GMR2_PPN64 : SVGA_REMAP_GMR2_PPN32; |
57 | remap_cmd.offsetPages = 0; | ||
58 | remap_cmd.numPages = num_pages; | ||
59 | 71 | ||
60 | *cmd++ = SVGA_CMD_DEFINE_GMR2; | 72 | while (num_pages > 0) { |
61 | memcpy(cmd, &define_cmd, sizeof(define_cmd)); | 73 | unsigned long nr = min(num_pages, (unsigned long)VMW_PPN_PER_REMAP); |
62 | cmd += sizeof(define_cmd) / sizeof(uint32); | 74 | |
75 | remap_cmd.offsetPages = remap_pos; | ||
76 | remap_cmd.numPages = nr; | ||
63 | 77 | ||
64 | *cmd++ = SVGA_CMD_REMAP_GMR2; | 78 | *cmd++ = SVGA_CMD_REMAP_GMR2; |
65 | memcpy(cmd, &remap_cmd, sizeof(remap_cmd)); | 79 | memcpy(cmd, &remap_cmd, sizeof(remap_cmd)); |
66 | cmd += sizeof(remap_cmd) / sizeof(uint32); | 80 | cmd += sizeof(remap_cmd) / sizeof(*cmd); |
67 | 81 | ||
68 | for (i = 0; i < num_pages; ++i) { | 82 | for (i = 0; i < nr; ++i) { |
69 | if (VMW_PPN_SIZE <= 4) | 83 | if (VMW_PPN_SIZE <= 4) |
70 | *cmd = page_to_pfn(*pages++); | 84 | *cmd = page_to_pfn(*pages++); |
71 | else | 85 | else |
72 | *((uint64_t *)cmd) = page_to_pfn(*pages++); | 86 | *((uint64_t *)cmd) = page_to_pfn(*pages++); |
73 | 87 | ||
74 | cmd += VMW_PPN_SIZE / sizeof(*cmd); | 88 | cmd += VMW_PPN_SIZE / sizeof(*cmd); |
89 | } | ||
90 | |||
91 | num_pages -= nr; | ||
92 | remap_pos += nr; | ||
75 | } | 93 | } |
76 | 94 | ||
77 | vmw_fifo_commit(dev_priv, define_size + remap_size); | 95 | BUG_ON(cmd != cmd_orig + cmd_size / sizeof(*cmd)); |
96 | |||
97 | vmw_fifo_commit(dev_priv, cmd_size); | ||
78 | 98 | ||
79 | return 0; | 99 | return 0; |
80 | } | 100 | } |
diff --git a/drivers/iio/light/adjd_s311.c b/drivers/iio/light/adjd_s311.c index 5f4749e60b04..c1cd5698b8ae 100644 --- a/drivers/iio/light/adjd_s311.c +++ b/drivers/iio/light/adjd_s311.c | |||
@@ -232,7 +232,8 @@ static int adjd_s311_read_raw(struct iio_dev *indio_dev, | |||
232 | 232 | ||
233 | switch (mask) { | 233 | switch (mask) { |
234 | case IIO_CHAN_INFO_RAW: | 234 | case IIO_CHAN_INFO_RAW: |
235 | ret = adjd_s311_read_data(indio_dev, chan->address, val); | 235 | ret = adjd_s311_read_data(indio_dev, |
236 | ADJD_S311_DATA_REG(chan->address), val); | ||
236 | if (ret < 0) | 237 | if (ret < 0) |
237 | return ret; | 238 | return ret; |
238 | return IIO_VAL_INT; | 239 | return IIO_VAL_INT; |
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index fa061d46527f..75e3b102ce45 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c | |||
@@ -167,6 +167,7 @@ static const struct xpad_device { | |||
167 | { 0x1430, 0x8888, "TX6500+ Dance Pad (first generation)", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX }, | 167 | { 0x1430, 0x8888, "TX6500+ Dance Pad (first generation)", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX }, |
168 | { 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 }, | 168 | { 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 }, |
169 | { 0x1689, 0xfd00, "Razer Onza Tournament Edition", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, | 169 | { 0x1689, 0xfd00, "Razer Onza Tournament Edition", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, |
170 | { 0x1689, 0xfd01, "Razer Onza Classic Edition", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, | ||
170 | { 0x1bad, 0x0002, "Harmonix Rock Band Guitar", 0, XTYPE_XBOX360 }, | 171 | { 0x1bad, 0x0002, "Harmonix Rock Band Guitar", 0, XTYPE_XBOX360 }, |
171 | { 0x1bad, 0x0003, "Harmonix Rock Band Drumkit", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, | 172 | { 0x1bad, 0x0003, "Harmonix Rock Band Drumkit", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 }, |
172 | { 0x1bad, 0xf016, "Mad Catz Xbox 360 Controller", 0, XTYPE_XBOX360 }, | 173 | { 0x1bad, 0xf016, "Mad Catz Xbox 360 Controller", 0, XTYPE_XBOX360 }, |
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 57b2637e153a..8551dcaf24db 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c | |||
@@ -672,6 +672,7 @@ static int elantech_packet_check_v2(struct psmouse *psmouse) | |||
672 | */ | 672 | */ |
673 | static int elantech_packet_check_v3(struct psmouse *psmouse) | 673 | static int elantech_packet_check_v3(struct psmouse *psmouse) |
674 | { | 674 | { |
675 | struct elantech_data *etd = psmouse->private; | ||
675 | const u8 debounce_packet[] = { 0xc4, 0xff, 0xff, 0x02, 0xff, 0xff }; | 676 | const u8 debounce_packet[] = { 0xc4, 0xff, 0xff, 0x02, 0xff, 0xff }; |
676 | unsigned char *packet = psmouse->packet; | 677 | unsigned char *packet = psmouse->packet; |
677 | 678 | ||
@@ -682,19 +683,48 @@ static int elantech_packet_check_v3(struct psmouse *psmouse) | |||
682 | if (!memcmp(packet, debounce_packet, sizeof(debounce_packet))) | 683 | if (!memcmp(packet, debounce_packet, sizeof(debounce_packet))) |
683 | return PACKET_DEBOUNCE; | 684 | return PACKET_DEBOUNCE; |
684 | 685 | ||
685 | if ((packet[0] & 0x0c) == 0x04 && (packet[3] & 0xcf) == 0x02) | 686 | /* |
686 | return PACKET_V3_HEAD; | 687 | * If the hardware flag 'crc_enabled' is set the packets have |
688 | * different signatures. | ||
689 | */ | ||
690 | if (etd->crc_enabled) { | ||
691 | if ((packet[3] & 0x09) == 0x08) | ||
692 | return PACKET_V3_HEAD; | ||
693 | |||
694 | if ((packet[3] & 0x09) == 0x09) | ||
695 | return PACKET_V3_TAIL; | ||
696 | } else { | ||
697 | if ((packet[0] & 0x0c) == 0x04 && (packet[3] & 0xcf) == 0x02) | ||
698 | return PACKET_V3_HEAD; | ||
687 | 699 | ||
688 | if ((packet[0] & 0x0c) == 0x0c && (packet[3] & 0xce) == 0x0c) | 700 | if ((packet[0] & 0x0c) == 0x0c && (packet[3] & 0xce) == 0x0c) |
689 | return PACKET_V3_TAIL; | 701 | return PACKET_V3_TAIL; |
702 | } | ||
690 | 703 | ||
691 | return PACKET_UNKNOWN; | 704 | return PACKET_UNKNOWN; |
692 | } | 705 | } |
693 | 706 | ||
694 | static int elantech_packet_check_v4(struct psmouse *psmouse) | 707 | static int elantech_packet_check_v4(struct psmouse *psmouse) |
695 | { | 708 | { |
709 | struct elantech_data *etd = psmouse->private; | ||
696 | unsigned char *packet = psmouse->packet; | 710 | unsigned char *packet = psmouse->packet; |
697 | unsigned char packet_type = packet[3] & 0x03; | 711 | unsigned char packet_type = packet[3] & 0x03; |
712 | bool sanity_check; | ||
713 | |||
714 | /* | ||
715 | * Sanity check based on the constant bits of a packet. | ||
716 | * The constant bits change depending on the value of | ||
717 | * the hardware flag 'crc_enabled' but are the same for | ||
718 | * every packet, regardless of the type. | ||
719 | */ | ||
720 | if (etd->crc_enabled) | ||
721 | sanity_check = ((packet[3] & 0x08) == 0x00); | ||
722 | else | ||
723 | sanity_check = ((packet[0] & 0x0c) == 0x04 && | ||
724 | (packet[3] & 0x1c) == 0x10); | ||
725 | |||
726 | if (!sanity_check) | ||
727 | return PACKET_UNKNOWN; | ||
698 | 728 | ||
699 | switch (packet_type) { | 729 | switch (packet_type) { |
700 | case 0: | 730 | case 0: |
@@ -1313,6 +1343,12 @@ static int elantech_set_properties(struct elantech_data *etd) | |||
1313 | etd->reports_pressure = true; | 1343 | etd->reports_pressure = true; |
1314 | } | 1344 | } |
1315 | 1345 | ||
1346 | /* | ||
1347 | * The signatures of v3 and v4 packets change depending on the | ||
1348 | * value of this hardware flag. | ||
1349 | */ | ||
1350 | etd->crc_enabled = ((etd->fw_version & 0x4000) == 0x4000); | ||
1351 | |||
1316 | return 0; | 1352 | return 0; |
1317 | } | 1353 | } |
1318 | 1354 | ||
diff --git a/drivers/input/mouse/elantech.h b/drivers/input/mouse/elantech.h index 46db3be45ac9..036a04abaef7 100644 --- a/drivers/input/mouse/elantech.h +++ b/drivers/input/mouse/elantech.h | |||
@@ -129,6 +129,7 @@ struct elantech_data { | |||
129 | bool paritycheck; | 129 | bool paritycheck; |
130 | bool jumpy_cursor; | 130 | bool jumpy_cursor; |
131 | bool reports_pressure; | 131 | bool reports_pressure; |
132 | bool crc_enabled; | ||
132 | unsigned char hw_version; | 133 | unsigned char hw_version; |
133 | unsigned int fw_version; | 134 | unsigned int fw_version; |
134 | unsigned int single_finger_reports; | 135 | unsigned int single_finger_reports; |
diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index 94c17c28d268..1e691a3a79cb 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig | |||
@@ -22,7 +22,8 @@ config SERIO_I8042 | |||
22 | tristate "i8042 PC Keyboard controller" if EXPERT || !X86 | 22 | tristate "i8042 PC Keyboard controller" if EXPERT || !X86 |
23 | default y | 23 | default y |
24 | depends on !PARISC && (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST) && \ | 24 | depends on !PARISC && (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST) && \ |
25 | (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !S390 | 25 | (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !S390 && \ |
26 | !ARC | ||
26 | help | 27 | help |
27 | i8042 is the chip over which the standard AT keyboard and PS/2 | 28 | i8042 is the chip over which the standard AT keyboard and PS/2 |
28 | mouse are connected to the computer. If you use these devices, | 29 | mouse are connected to the computer. If you use these devices, |
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index 384fbcd0cee0..f3e91f0b57ae 100644 --- a/drivers/input/tablet/wacom_wac.c +++ b/drivers/input/tablet/wacom_wac.c | |||
@@ -2112,7 +2112,7 @@ static const struct wacom_features wacom_features_0xDA = | |||
2112 | { "Wacom Bamboo 2FG 4x5 SE", WACOM_PKGLEN_BBFUN, 14720, 9200, 1023, | 2112 | { "Wacom Bamboo 2FG 4x5 SE", WACOM_PKGLEN_BBFUN, 14720, 9200, 1023, |
2113 | 31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES, | 2113 | 31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES, |
2114 | .touch_max = 2 }; | 2114 | .touch_max = 2 }; |
2115 | static struct wacom_features wacom_features_0xDB = | 2115 | static const struct wacom_features wacom_features_0xDB = |
2116 | { "Wacom Bamboo 2FG 6x8 SE", WACOM_PKGLEN_BBFUN, 21648, 13700, 1023, | 2116 | { "Wacom Bamboo 2FG 6x8 SE", WACOM_PKGLEN_BBFUN, 21648, 13700, 1023, |
2117 | 31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES, | 2117 | 31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES, |
2118 | .touch_max = 2 }; | 2118 | .touch_max = 2 }; |
@@ -2127,6 +2127,12 @@ static const struct wacom_features wacom_features_0xDF = | |||
2127 | { "Wacom Bamboo 16FG 6x8", WACOM_PKGLEN_BBPEN, 21648, 13700, 1023, | 2127 | { "Wacom Bamboo 16FG 6x8", WACOM_PKGLEN_BBPEN, 21648, 13700, 1023, |
2128 | 31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES, | 2128 | 31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES, |
2129 | .touch_max = 16 }; | 2129 | .touch_max = 16 }; |
2130 | static const struct wacom_features wacom_features_0x300 = | ||
2131 | { "Wacom Bamboo One S", WACOM_PKGLEN_BBPEN, 14720, 9225, 1023, | ||
2132 | 31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; | ||
2133 | static const struct wacom_features wacom_features_0x301 = | ||
2134 | { "Wacom Bamboo One M", WACOM_PKGLEN_BBPEN, 21648, 13530, 1023, | ||
2135 | 31, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; | ||
2130 | static const struct wacom_features wacom_features_0x6004 = | 2136 | static const struct wacom_features wacom_features_0x6004 = |
2131 | { "ISD-V4", WACOM_PKGLEN_GRAPHIRE, 12800, 8000, 255, | 2137 | { "ISD-V4", WACOM_PKGLEN_GRAPHIRE, 12800, 8000, 255, |
2132 | 0, TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; | 2138 | 0, TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; |
@@ -2253,6 +2259,8 @@ const struct usb_device_id wacom_ids[] = { | |||
2253 | { USB_DEVICE_WACOM(0x100) }, | 2259 | { USB_DEVICE_WACOM(0x100) }, |
2254 | { USB_DEVICE_WACOM(0x101) }, | 2260 | { USB_DEVICE_WACOM(0x101) }, |
2255 | { USB_DEVICE_WACOM(0x10D) }, | 2261 | { USB_DEVICE_WACOM(0x10D) }, |
2262 | { USB_DEVICE_WACOM(0x300) }, | ||
2263 | { USB_DEVICE_WACOM(0x301) }, | ||
2256 | { USB_DEVICE_WACOM(0x304) }, | 2264 | { USB_DEVICE_WACOM(0x304) }, |
2257 | { USB_DEVICE_WACOM(0x4001) }, | 2265 | { USB_DEVICE_WACOM(0x4001) }, |
2258 | { USB_DEVICE_WACOM(0x47) }, | 2266 | { USB_DEVICE_WACOM(0x47) }, |
diff --git a/drivers/irqchip/irq-sirfsoc.c b/drivers/irqchip/irq-sirfsoc.c index 69ea44ebcf61..4851afae38dc 100644 --- a/drivers/irqchip/irq-sirfsoc.c +++ b/drivers/irqchip/irq-sirfsoc.c | |||
@@ -23,7 +23,7 @@ | |||
23 | #define SIRFSOC_INT_RISC_LEVEL1 0x0024 | 23 | #define SIRFSOC_INT_RISC_LEVEL1 0x0024 |
24 | #define SIRFSOC_INIT_IRQ_ID 0x0038 | 24 | #define SIRFSOC_INIT_IRQ_ID 0x0038 |
25 | 25 | ||
26 | #define SIRFSOC_NUM_IRQS 128 | 26 | #define SIRFSOC_NUM_IRQS 64 |
27 | 27 | ||
28 | static struct irq_domain *sirfsoc_irqdomain; | 28 | static struct irq_domain *sirfsoc_irqdomain; |
29 | 29 | ||
@@ -32,15 +32,18 @@ sirfsoc_alloc_gc(void __iomem *base, unsigned int irq_start, unsigned int num) | |||
32 | { | 32 | { |
33 | struct irq_chip_generic *gc; | 33 | struct irq_chip_generic *gc; |
34 | struct irq_chip_type *ct; | 34 | struct irq_chip_type *ct; |
35 | int ret; | ||
36 | unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN; | ||
35 | 37 | ||
36 | gc = irq_alloc_generic_chip("SIRFINTC", 1, irq_start, base, handle_level_irq); | 38 | ret = irq_alloc_domain_generic_chips(sirfsoc_irqdomain, num, 1, "irq_sirfsoc", |
37 | ct = gc->chip_types; | 39 | handle_level_irq, clr, 0, IRQ_GC_INIT_MASK_CACHE); |
38 | 40 | ||
41 | gc = irq_get_domain_generic_chip(sirfsoc_irqdomain, irq_start); | ||
42 | gc->reg_base = base; | ||
43 | ct = gc->chip_types; | ||
39 | ct->chip.irq_mask = irq_gc_mask_clr_bit; | 44 | ct->chip.irq_mask = irq_gc_mask_clr_bit; |
40 | ct->chip.irq_unmask = irq_gc_mask_set_bit; | 45 | ct->chip.irq_unmask = irq_gc_mask_set_bit; |
41 | ct->regs.mask = SIRFSOC_INT_RISC_MASK0; | 46 | ct->regs.mask = SIRFSOC_INT_RISC_MASK0; |
42 | |||
43 | irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE, IRQ_NOREQUEST, 0); | ||
44 | } | 47 | } |
45 | 48 | ||
46 | static asmlinkage void __exception_irq_entry sirfsoc_handle_irq(struct pt_regs *regs) | 49 | static asmlinkage void __exception_irq_entry sirfsoc_handle_irq(struct pt_regs *regs) |
@@ -60,9 +63,8 @@ static int __init sirfsoc_irq_init(struct device_node *np, struct device_node *p | |||
60 | if (!base) | 63 | if (!base) |
61 | panic("unable to map intc cpu registers\n"); | 64 | panic("unable to map intc cpu registers\n"); |
62 | 65 | ||
63 | /* using legacy because irqchip_generic does not work with linear */ | 66 | sirfsoc_irqdomain = irq_domain_add_linear(np, SIRFSOC_NUM_IRQS, |
64 | sirfsoc_irqdomain = irq_domain_add_legacy(np, SIRFSOC_NUM_IRQS, 0, 0, | 67 | &irq_generic_chip_ops, base); |
65 | &irq_domain_simple_ops, base); | ||
66 | 68 | ||
67 | sirfsoc_alloc_gc(base, 0, 32); | 69 | sirfsoc_alloc_gc(base, 0, 32); |
68 | sirfsoc_alloc_gc(base + 4, 32, SIRFSOC_NUM_IRQS - 32); | 70 | sirfsoc_alloc_gc(base + 4, 32, SIRFSOC_NUM_IRQS - 32); |
diff --git a/drivers/isdn/mISDN/dsp_core.c b/drivers/isdn/mISDN/dsp_core.c index 22b720ec80cb..77025f5cb57d 100644 --- a/drivers/isdn/mISDN/dsp_core.c +++ b/drivers/isdn/mISDN/dsp_core.c | |||
@@ -288,8 +288,10 @@ dsp_control_req(struct dsp *dsp, struct mISDNhead *hh, struct sk_buff *skb) | |||
288 | u8 *data; | 288 | u8 *data; |
289 | int len; | 289 | int len; |
290 | 290 | ||
291 | if (skb->len < sizeof(int)) | 291 | if (skb->len < sizeof(int)) { |
292 | printk(KERN_ERR "%s: PH_CONTROL message too short\n", __func__); | 292 | printk(KERN_ERR "%s: PH_CONTROL message too short\n", __func__); |
293 | return -EINVAL; | ||
294 | } | ||
293 | cont = *((int *)skb->data); | 295 | cont = *((int *)skb->data); |
294 | len = skb->len - sizeof(int); | 296 | len = skb->len - sizeof(int); |
295 | data = skb->data + sizeof(int); | 297 | data = skb->data + sizeof(int); |
diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig index a5f91e1e8fe3..becef25fa194 100644 --- a/drivers/net/ethernet/8390/Kconfig +++ b/drivers/net/ethernet/8390/Kconfig | |||
@@ -148,7 +148,7 @@ config PCMCIA_PCNET | |||
148 | 148 | ||
149 | config NE_H8300 | 149 | config NE_H8300 |
150 | tristate "NE2000 compatible support for H8/300" | 150 | tristate "NE2000 compatible support for H8/300" |
151 | depends on H8300 | 151 | depends on H8300H_AKI3068NET || H8300H_H8MAX |
152 | ---help--- | 152 | ---help--- |
153 | Say Y here if you want to use the NE2000 compatible | 153 | Say Y here if you want to use the NE2000 compatible |
154 | controller on the Renesas H8/300 processor. | 154 | controller on the Renesas H8/300 processor. |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 8d726f6e1c52..2361bf236ce3 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | |||
@@ -53,6 +53,7 @@ static inline void bnx2x_move_fp(struct bnx2x *bp, int from, int to) | |||
53 | struct bnx2x_fp_stats *to_fp_stats = &bp->fp_stats[to]; | 53 | struct bnx2x_fp_stats *to_fp_stats = &bp->fp_stats[to]; |
54 | int old_max_eth_txqs, new_max_eth_txqs; | 54 | int old_max_eth_txqs, new_max_eth_txqs; |
55 | int old_txdata_index = 0, new_txdata_index = 0; | 55 | int old_txdata_index = 0, new_txdata_index = 0; |
56 | struct bnx2x_agg_info *old_tpa_info = to_fp->tpa_info; | ||
56 | 57 | ||
57 | /* Copy the NAPI object as it has been already initialized */ | 58 | /* Copy the NAPI object as it has been already initialized */ |
58 | from_fp->napi = to_fp->napi; | 59 | from_fp->napi = to_fp->napi; |
@@ -61,6 +62,11 @@ static inline void bnx2x_move_fp(struct bnx2x *bp, int from, int to) | |||
61 | memcpy(to_fp, from_fp, sizeof(*to_fp)); | 62 | memcpy(to_fp, from_fp, sizeof(*to_fp)); |
62 | to_fp->index = to; | 63 | to_fp->index = to; |
63 | 64 | ||
65 | /* Retain the tpa_info of the original `to' version as we don't want | ||
66 | * 2 FPs to contain the same tpa_info pointer. | ||
67 | */ | ||
68 | to_fp->tpa_info = old_tpa_info; | ||
69 | |||
64 | /* move sp_objs contents as well, as their indices match fp ones */ | 70 | /* move sp_objs contents as well, as their indices match fp ones */ |
65 | memcpy(to_sp_objs, from_sp_objs, sizeof(*to_sp_objs)); | 71 | memcpy(to_sp_objs, from_sp_objs, sizeof(*to_sp_objs)); |
66 | 72 | ||
@@ -2959,8 +2965,9 @@ int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode, bool keep_link) | |||
2959 | if (IS_PF(bp)) { | 2965 | if (IS_PF(bp)) { |
2960 | if (CNIC_LOADED(bp)) | 2966 | if (CNIC_LOADED(bp)) |
2961 | bnx2x_free_mem_cnic(bp); | 2967 | bnx2x_free_mem_cnic(bp); |
2962 | bnx2x_free_mem(bp); | ||
2963 | } | 2968 | } |
2969 | bnx2x_free_mem(bp); | ||
2970 | |||
2964 | bp->state = BNX2X_STATE_CLOSED; | 2971 | bp->state = BNX2X_STATE_CLOSED; |
2965 | bp->cnic_loaded = false; | 2972 | bp->cnic_loaded = false; |
2966 | 2973 | ||
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c index 9d64b988ab34..664568420c9b 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | |||
@@ -6501,12 +6501,13 @@ static int bnx2x_link_initialize(struct link_params *params, | |||
6501 | struct bnx2x_phy *phy = ¶ms->phy[INT_PHY]; | 6501 | struct bnx2x_phy *phy = ¶ms->phy[INT_PHY]; |
6502 | if (vars->line_speed == SPEED_AUTO_NEG && | 6502 | if (vars->line_speed == SPEED_AUTO_NEG && |
6503 | (CHIP_IS_E1x(bp) || | 6503 | (CHIP_IS_E1x(bp) || |
6504 | CHIP_IS_E2(bp))) | 6504 | CHIP_IS_E2(bp))) { |
6505 | bnx2x_set_parallel_detection(phy, params); | 6505 | bnx2x_set_parallel_detection(phy, params); |
6506 | if (params->phy[INT_PHY].config_init) | 6506 | if (params->phy[INT_PHY].config_init) |
6507 | params->phy[INT_PHY].config_init(phy, | 6507 | params->phy[INT_PHY].config_init(phy, |
6508 | params, | 6508 | params, |
6509 | vars); | 6509 | vars); |
6510 | } | ||
6510 | } | 6511 | } |
6511 | 6512 | ||
6512 | /* Init external phy*/ | 6513 | /* Init external phy*/ |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index c69990d2170e..285f2a59a3a5 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | |||
@@ -7855,12 +7855,15 @@ void bnx2x_free_mem(struct bnx2x *bp) | |||
7855 | { | 7855 | { |
7856 | int i; | 7856 | int i; |
7857 | 7857 | ||
7858 | BNX2X_PCI_FREE(bp->def_status_blk, bp->def_status_blk_mapping, | ||
7859 | sizeof(struct host_sp_status_block)); | ||
7860 | |||
7861 | BNX2X_PCI_FREE(bp->fw_stats, bp->fw_stats_mapping, | 7858 | BNX2X_PCI_FREE(bp->fw_stats, bp->fw_stats_mapping, |
7862 | bp->fw_stats_data_sz + bp->fw_stats_req_sz); | 7859 | bp->fw_stats_data_sz + bp->fw_stats_req_sz); |
7863 | 7860 | ||
7861 | if (IS_VF(bp)) | ||
7862 | return; | ||
7863 | |||
7864 | BNX2X_PCI_FREE(bp->def_status_blk, bp->def_status_blk_mapping, | ||
7865 | sizeof(struct host_sp_status_block)); | ||
7866 | |||
7864 | BNX2X_PCI_FREE(bp->slowpath, bp->slowpath_mapping, | 7867 | BNX2X_PCI_FREE(bp->slowpath, bp->slowpath_mapping, |
7865 | sizeof(struct bnx2x_slowpath)); | 7868 | sizeof(struct bnx2x_slowpath)); |
7866 | 7869 | ||
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 73731eb68f2a..b26eb83069b6 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | |||
@@ -545,23 +545,6 @@ static int bnx2x_vfop_set_user_req(struct bnx2x *bp, | |||
545 | return 0; | 545 | return 0; |
546 | } | 546 | } |
547 | 547 | ||
548 | static int | ||
549 | bnx2x_vfop_config_vlan0(struct bnx2x *bp, | ||
550 | struct bnx2x_vlan_mac_ramrod_params *vlan_mac, | ||
551 | bool add) | ||
552 | { | ||
553 | int rc; | ||
554 | |||
555 | vlan_mac->user_req.cmd = add ? BNX2X_VLAN_MAC_ADD : | ||
556 | BNX2X_VLAN_MAC_DEL; | ||
557 | vlan_mac->user_req.u.vlan.vlan = 0; | ||
558 | |||
559 | rc = bnx2x_config_vlan_mac(bp, vlan_mac); | ||
560 | if (rc == -EEXIST) | ||
561 | rc = 0; | ||
562 | return rc; | ||
563 | } | ||
564 | |||
565 | static int bnx2x_vfop_config_list(struct bnx2x *bp, | 548 | static int bnx2x_vfop_config_list(struct bnx2x *bp, |
566 | struct bnx2x_vfop_filters *filters, | 549 | struct bnx2x_vfop_filters *filters, |
567 | struct bnx2x_vlan_mac_ramrod_params *vlan_mac) | 550 | struct bnx2x_vlan_mac_ramrod_params *vlan_mac) |
@@ -666,30 +649,14 @@ static void bnx2x_vfop_vlan_mac(struct bnx2x *bp, struct bnx2x_virtf *vf) | |||
666 | 649 | ||
667 | case BNX2X_VFOP_VLAN_CONFIG_LIST: | 650 | case BNX2X_VFOP_VLAN_CONFIG_LIST: |
668 | /* next state */ | 651 | /* next state */ |
669 | vfop->state = BNX2X_VFOP_VLAN_CONFIG_LIST_0; | 652 | vfop->state = BNX2X_VFOP_VLAN_MAC_CHK_DONE; |
670 | |||
671 | /* remove vlan0 - could be no-op */ | ||
672 | vfop->rc = bnx2x_vfop_config_vlan0(bp, vlan_mac, false); | ||
673 | if (vfop->rc) | ||
674 | goto op_err; | ||
675 | 653 | ||
676 | /* Do vlan list config. if this operation fails we try to | 654 | /* do list config */ |
677 | * restore vlan0 to keep the queue is working order | ||
678 | */ | ||
679 | vfop->rc = bnx2x_vfop_config_list(bp, filters, vlan_mac); | 655 | vfop->rc = bnx2x_vfop_config_list(bp, filters, vlan_mac); |
680 | if (!vfop->rc) { | 656 | if (!vfop->rc) { |
681 | set_bit(RAMROD_CONT, &vlan_mac->ramrod_flags); | 657 | set_bit(RAMROD_CONT, &vlan_mac->ramrod_flags); |
682 | vfop->rc = bnx2x_config_vlan_mac(bp, vlan_mac); | 658 | vfop->rc = bnx2x_config_vlan_mac(bp, vlan_mac); |
683 | } | 659 | } |
684 | bnx2x_vfop_finalize(vf, vfop->rc, VFOP_CONT); /* fall-through */ | ||
685 | |||
686 | case BNX2X_VFOP_VLAN_CONFIG_LIST_0: | ||
687 | /* next state */ | ||
688 | vfop->state = BNX2X_VFOP_VLAN_MAC_CHK_DONE; | ||
689 | |||
690 | if (list_empty(&obj->head)) | ||
691 | /* add vlan0 */ | ||
692 | vfop->rc = bnx2x_vfop_config_vlan0(bp, vlan_mac, true); | ||
693 | bnx2x_vfop_finalize(vf, vfop->rc, VFOP_DONE); | 660 | bnx2x_vfop_finalize(vf, vfop->rc, VFOP_DONE); |
694 | 661 | ||
695 | default: | 662 | default: |
@@ -2833,6 +2800,18 @@ int bnx2x_vf_init(struct bnx2x *bp, struct bnx2x_virtf *vf, dma_addr_t *sb_map) | |||
2833 | return 0; | 2800 | return 0; |
2834 | } | 2801 | } |
2835 | 2802 | ||
2803 | struct set_vf_state_cookie { | ||
2804 | struct bnx2x_virtf *vf; | ||
2805 | u8 state; | ||
2806 | }; | ||
2807 | |||
2808 | void bnx2x_set_vf_state(void *cookie) | ||
2809 | { | ||
2810 | struct set_vf_state_cookie *p = (struct set_vf_state_cookie *)cookie; | ||
2811 | |||
2812 | p->vf->state = p->state; | ||
2813 | } | ||
2814 | |||
2836 | /* VFOP close (teardown the queues, delete mcasts and close HW) */ | 2815 | /* VFOP close (teardown the queues, delete mcasts and close HW) */ |
2837 | static void bnx2x_vfop_close(struct bnx2x *bp, struct bnx2x_virtf *vf) | 2816 | static void bnx2x_vfop_close(struct bnx2x *bp, struct bnx2x_virtf *vf) |
2838 | { | 2817 | { |
@@ -2883,7 +2862,19 @@ static void bnx2x_vfop_close(struct bnx2x *bp, struct bnx2x_virtf *vf) | |||
2883 | op_err: | 2862 | op_err: |
2884 | BNX2X_ERR("VF[%d] CLOSE error: rc %d\n", vf->abs_vfid, vfop->rc); | 2863 | BNX2X_ERR("VF[%d] CLOSE error: rc %d\n", vf->abs_vfid, vfop->rc); |
2885 | op_done: | 2864 | op_done: |
2886 | vf->state = VF_ACQUIRED; | 2865 | |
2866 | /* need to make sure there are no outstanding stats ramrods which may | ||
2867 | * cause the device to access the VF's stats buffer which it will free | ||
2868 | * as soon as we return from the close flow. | ||
2869 | */ | ||
2870 | { | ||
2871 | struct set_vf_state_cookie cookie; | ||
2872 | |||
2873 | cookie.vf = vf; | ||
2874 | cookie.state = VF_ACQUIRED; | ||
2875 | bnx2x_stats_safe_exec(bp, bnx2x_set_vf_state, &cookie); | ||
2876 | } | ||
2877 | |||
2887 | DP(BNX2X_MSG_IOV, "set state to acquired\n"); | 2878 | DP(BNX2X_MSG_IOV, "set state to acquired\n"); |
2888 | bnx2x_vfop_end(bp, vf, vfop); | 2879 | bnx2x_vfop_end(bp, vf, vfop); |
2889 | } | 2880 | } |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c index d63d1327b051..86436c77af03 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c | |||
@@ -522,20 +522,16 @@ static void bnx2x_func_stats_init(struct bnx2x *bp) | |||
522 | /* should be called under stats_sema */ | 522 | /* should be called under stats_sema */ |
523 | static void __bnx2x_stats_start(struct bnx2x *bp) | 523 | static void __bnx2x_stats_start(struct bnx2x *bp) |
524 | { | 524 | { |
525 | /* vfs travel through here as part of the statistics FSM, but no action | 525 | if (IS_PF(bp)) { |
526 | * is required | 526 | if (bp->port.pmf) |
527 | */ | 527 | bnx2x_port_stats_init(bp); |
528 | if (IS_VF(bp)) | ||
529 | return; | ||
530 | |||
531 | if (bp->port.pmf) | ||
532 | bnx2x_port_stats_init(bp); | ||
533 | 528 | ||
534 | else if (bp->func_stx) | 529 | else if (bp->func_stx) |
535 | bnx2x_func_stats_init(bp); | 530 | bnx2x_func_stats_init(bp); |
536 | 531 | ||
537 | bnx2x_hw_stats_post(bp); | 532 | bnx2x_hw_stats_post(bp); |
538 | bnx2x_storm_stats_post(bp); | 533 | bnx2x_storm_stats_post(bp); |
534 | } | ||
539 | 535 | ||
540 | bp->stats_started = true; | 536 | bp->stats_started = true; |
541 | } | 537 | } |
@@ -1997,3 +1993,14 @@ void bnx2x_afex_collect_stats(struct bnx2x *bp, void *void_afex_stats, | |||
1997 | estats->mac_discard); | 1993 | estats->mac_discard); |
1998 | } | 1994 | } |
1999 | } | 1995 | } |
1996 | |||
1997 | void bnx2x_stats_safe_exec(struct bnx2x *bp, | ||
1998 | void (func_to_exec)(void *cookie), | ||
1999 | void *cookie){ | ||
2000 | if (down_timeout(&bp->stats_sema, HZ/10)) | ||
2001 | BNX2X_ERR("Unable to acquire stats lock\n"); | ||
2002 | bnx2x_stats_comp(bp); | ||
2003 | func_to_exec(cookie); | ||
2004 | __bnx2x_stats_start(bp); | ||
2005 | up(&bp->stats_sema); | ||
2006 | } | ||
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h index 853824d258e8..f35845006cdd 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h | |||
@@ -539,6 +539,9 @@ struct bnx2x; | |||
539 | void bnx2x_memset_stats(struct bnx2x *bp); | 539 | void bnx2x_memset_stats(struct bnx2x *bp); |
540 | void bnx2x_stats_init(struct bnx2x *bp); | 540 | void bnx2x_stats_init(struct bnx2x *bp); |
541 | void bnx2x_stats_handle(struct bnx2x *bp, enum bnx2x_stats_event event); | 541 | void bnx2x_stats_handle(struct bnx2x *bp, enum bnx2x_stats_event event); |
542 | void bnx2x_stats_safe_exec(struct bnx2x *bp, | ||
543 | void (func_to_exec)(void *cookie), | ||
544 | void *cookie); | ||
542 | 545 | ||
543 | /** | 546 | /** |
544 | * bnx2x_save_statistics - save statistics when unloading. | 547 | * bnx2x_save_statistics - save statistics when unloading. |
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 2e55ee29cf13..5701f3d1a169 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c | |||
@@ -3030,6 +3030,19 @@ static bool tg3_phy_power_bug(struct tg3 *tp) | |||
3030 | return false; | 3030 | return false; |
3031 | } | 3031 | } |
3032 | 3032 | ||
3033 | static bool tg3_phy_led_bug(struct tg3 *tp) | ||
3034 | { | ||
3035 | switch (tg3_asic_rev(tp)) { | ||
3036 | case ASIC_REV_5719: | ||
3037 | if ((tp->phy_flags & TG3_PHYFLG_MII_SERDES) && | ||
3038 | !tp->pci_fn) | ||
3039 | return true; | ||
3040 | return false; | ||
3041 | } | ||
3042 | |||
3043 | return false; | ||
3044 | } | ||
3045 | |||
3033 | static void tg3_power_down_phy(struct tg3 *tp, bool do_low_power) | 3046 | static void tg3_power_down_phy(struct tg3 *tp, bool do_low_power) |
3034 | { | 3047 | { |
3035 | u32 val; | 3048 | u32 val; |
@@ -3077,8 +3090,9 @@ static void tg3_power_down_phy(struct tg3 *tp, bool do_low_power) | |||
3077 | } | 3090 | } |
3078 | return; | 3091 | return; |
3079 | } else if (do_low_power) { | 3092 | } else if (do_low_power) { |
3080 | tg3_writephy(tp, MII_TG3_EXT_CTRL, | 3093 | if (!tg3_phy_led_bug(tp)) |
3081 | MII_TG3_EXT_CTRL_FORCE_LED_OFF); | 3094 | tg3_writephy(tp, MII_TG3_EXT_CTRL, |
3095 | MII_TG3_EXT_CTRL_FORCE_LED_OFF); | ||
3082 | 3096 | ||
3083 | val = MII_TG3_AUXCTL_PCTL_100TX_LPWR | | 3097 | val = MII_TG3_AUXCTL_PCTL_100TX_LPWR | |
3084 | MII_TG3_AUXCTL_PCTL_SPR_ISOLATE | | 3098 | MII_TG3_AUXCTL_PCTL_SPR_ISOLATE | |
diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index 7cb148c495c9..78d6d6b970e1 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c | |||
@@ -353,11 +353,9 @@ struct xgmac_extra_stats { | |||
353 | /* Receive errors */ | 353 | /* Receive errors */ |
354 | unsigned long rx_watchdog; | 354 | unsigned long rx_watchdog; |
355 | unsigned long rx_da_filter_fail; | 355 | unsigned long rx_da_filter_fail; |
356 | unsigned long rx_sa_filter_fail; | ||
357 | unsigned long rx_payload_error; | 356 | unsigned long rx_payload_error; |
358 | unsigned long rx_ip_header_error; | 357 | unsigned long rx_ip_header_error; |
359 | /* Tx/Rx IRQ errors */ | 358 | /* Tx/Rx IRQ errors */ |
360 | unsigned long tx_undeflow; | ||
361 | unsigned long tx_process_stopped; | 359 | unsigned long tx_process_stopped; |
362 | unsigned long rx_buf_unav; | 360 | unsigned long rx_buf_unav; |
363 | unsigned long rx_process_stopped; | 361 | unsigned long rx_process_stopped; |
@@ -393,6 +391,7 @@ struct xgmac_priv { | |||
393 | char rx_pause; | 391 | char rx_pause; |
394 | char tx_pause; | 392 | char tx_pause; |
395 | int wolopts; | 393 | int wolopts; |
394 | struct work_struct tx_timeout_work; | ||
396 | }; | 395 | }; |
397 | 396 | ||
398 | /* XGMAC Configuration Settings */ | 397 | /* XGMAC Configuration Settings */ |
@@ -409,6 +408,9 @@ struct xgmac_priv { | |||
409 | #define dma_ring_space(h, t, s) CIRC_SPACE(h, t, s) | 408 | #define dma_ring_space(h, t, s) CIRC_SPACE(h, t, s) |
410 | #define dma_ring_cnt(h, t, s) CIRC_CNT(h, t, s) | 409 | #define dma_ring_cnt(h, t, s) CIRC_CNT(h, t, s) |
411 | 410 | ||
411 | #define tx_dma_ring_space(p) \ | ||
412 | dma_ring_space((p)->tx_head, (p)->tx_tail, DMA_TX_RING_SZ) | ||
413 | |||
412 | /* XGMAC Descriptor Access Helpers */ | 414 | /* XGMAC Descriptor Access Helpers */ |
413 | static inline void desc_set_buf_len(struct xgmac_dma_desc *p, u32 buf_sz) | 415 | static inline void desc_set_buf_len(struct xgmac_dma_desc *p, u32 buf_sz) |
414 | { | 416 | { |
@@ -421,7 +423,7 @@ static inline void desc_set_buf_len(struct xgmac_dma_desc *p, u32 buf_sz) | |||
421 | 423 | ||
422 | static inline int desc_get_buf_len(struct xgmac_dma_desc *p) | 424 | static inline int desc_get_buf_len(struct xgmac_dma_desc *p) |
423 | { | 425 | { |
424 | u32 len = cpu_to_le32(p->flags); | 426 | u32 len = le32_to_cpu(p->buf_size); |
425 | return (len & DESC_BUFFER1_SZ_MASK) + | 427 | return (len & DESC_BUFFER1_SZ_MASK) + |
426 | ((len & DESC_BUFFER2_SZ_MASK) >> DESC_BUFFER2_SZ_OFFSET); | 428 | ((len & DESC_BUFFER2_SZ_MASK) >> DESC_BUFFER2_SZ_OFFSET); |
427 | } | 429 | } |
@@ -464,11 +466,23 @@ static inline void desc_set_tx_owner(struct xgmac_dma_desc *p, u32 flags) | |||
464 | p->flags = cpu_to_le32(tmpflags); | 466 | p->flags = cpu_to_le32(tmpflags); |
465 | } | 467 | } |
466 | 468 | ||
469 | static inline void desc_clear_tx_owner(struct xgmac_dma_desc *p) | ||
470 | { | ||
471 | u32 tmpflags = le32_to_cpu(p->flags); | ||
472 | tmpflags &= TXDESC_END_RING; | ||
473 | p->flags = cpu_to_le32(tmpflags); | ||
474 | } | ||
475 | |||
467 | static inline int desc_get_tx_ls(struct xgmac_dma_desc *p) | 476 | static inline int desc_get_tx_ls(struct xgmac_dma_desc *p) |
468 | { | 477 | { |
469 | return le32_to_cpu(p->flags) & TXDESC_LAST_SEG; | 478 | return le32_to_cpu(p->flags) & TXDESC_LAST_SEG; |
470 | } | 479 | } |
471 | 480 | ||
481 | static inline int desc_get_tx_fs(struct xgmac_dma_desc *p) | ||
482 | { | ||
483 | return le32_to_cpu(p->flags) & TXDESC_FIRST_SEG; | ||
484 | } | ||
485 | |||
472 | static inline u32 desc_get_buf_addr(struct xgmac_dma_desc *p) | 486 | static inline u32 desc_get_buf_addr(struct xgmac_dma_desc *p) |
473 | { | 487 | { |
474 | return le32_to_cpu(p->buf1_addr); | 488 | return le32_to_cpu(p->buf1_addr); |
@@ -609,10 +623,15 @@ static void xgmac_set_mac_addr(void __iomem *ioaddr, unsigned char *addr, | |||
609 | { | 623 | { |
610 | u32 data; | 624 | u32 data; |
611 | 625 | ||
612 | data = (addr[5] << 8) | addr[4] | (num ? XGMAC_ADDR_AE : 0); | 626 | if (addr) { |
613 | writel(data, ioaddr + XGMAC_ADDR_HIGH(num)); | 627 | data = (addr[5] << 8) | addr[4] | (num ? XGMAC_ADDR_AE : 0); |
614 | data = (addr[3] << 24) | (addr[2] << 16) | (addr[1] << 8) | addr[0]; | 628 | writel(data, ioaddr + XGMAC_ADDR_HIGH(num)); |
615 | writel(data, ioaddr + XGMAC_ADDR_LOW(num)); | 629 | data = (addr[3] << 24) | (addr[2] << 16) | (addr[1] << 8) | addr[0]; |
630 | writel(data, ioaddr + XGMAC_ADDR_LOW(num)); | ||
631 | } else { | ||
632 | writel(0, ioaddr + XGMAC_ADDR_HIGH(num)); | ||
633 | writel(0, ioaddr + XGMAC_ADDR_LOW(num)); | ||
634 | } | ||
616 | } | 635 | } |
617 | 636 | ||
618 | static void xgmac_get_mac_addr(void __iomem *ioaddr, unsigned char *addr, | 637 | static void xgmac_get_mac_addr(void __iomem *ioaddr, unsigned char *addr, |
@@ -683,9 +702,14 @@ static void xgmac_rx_refill(struct xgmac_priv *priv) | |||
683 | if (unlikely(skb == NULL)) | 702 | if (unlikely(skb == NULL)) |
684 | break; | 703 | break; |
685 | 704 | ||
686 | priv->rx_skbuff[entry] = skb; | ||
687 | paddr = dma_map_single(priv->device, skb->data, | 705 | paddr = dma_map_single(priv->device, skb->data, |
688 | bufsz, DMA_FROM_DEVICE); | 706 | priv->dma_buf_sz - NET_IP_ALIGN, |
707 | DMA_FROM_DEVICE); | ||
708 | if (dma_mapping_error(priv->device, paddr)) { | ||
709 | dev_kfree_skb_any(skb); | ||
710 | break; | ||
711 | } | ||
712 | priv->rx_skbuff[entry] = skb; | ||
689 | desc_set_buf_addr(p, paddr, priv->dma_buf_sz); | 713 | desc_set_buf_addr(p, paddr, priv->dma_buf_sz); |
690 | } | 714 | } |
691 | 715 | ||
@@ -782,20 +806,21 @@ static void xgmac_free_rx_skbufs(struct xgmac_priv *priv) | |||
782 | return; | 806 | return; |
783 | 807 | ||
784 | for (i = 0; i < DMA_RX_RING_SZ; i++) { | 808 | for (i = 0; i < DMA_RX_RING_SZ; i++) { |
785 | if (priv->rx_skbuff[i] == NULL) | 809 | struct sk_buff *skb = priv->rx_skbuff[i]; |
810 | if (skb == NULL) | ||
786 | continue; | 811 | continue; |
787 | 812 | ||
788 | p = priv->dma_rx + i; | 813 | p = priv->dma_rx + i; |
789 | dma_unmap_single(priv->device, desc_get_buf_addr(p), | 814 | dma_unmap_single(priv->device, desc_get_buf_addr(p), |
790 | priv->dma_buf_sz, DMA_FROM_DEVICE); | 815 | priv->dma_buf_sz - NET_IP_ALIGN, DMA_FROM_DEVICE); |
791 | dev_kfree_skb_any(priv->rx_skbuff[i]); | 816 | dev_kfree_skb_any(skb); |
792 | priv->rx_skbuff[i] = NULL; | 817 | priv->rx_skbuff[i] = NULL; |
793 | } | 818 | } |
794 | } | 819 | } |
795 | 820 | ||
796 | static void xgmac_free_tx_skbufs(struct xgmac_priv *priv) | 821 | static void xgmac_free_tx_skbufs(struct xgmac_priv *priv) |
797 | { | 822 | { |
798 | int i, f; | 823 | int i; |
799 | struct xgmac_dma_desc *p; | 824 | struct xgmac_dma_desc *p; |
800 | 825 | ||
801 | if (!priv->tx_skbuff) | 826 | if (!priv->tx_skbuff) |
@@ -806,16 +831,15 @@ static void xgmac_free_tx_skbufs(struct xgmac_priv *priv) | |||
806 | continue; | 831 | continue; |
807 | 832 | ||
808 | p = priv->dma_tx + i; | 833 | p = priv->dma_tx + i; |
809 | dma_unmap_single(priv->device, desc_get_buf_addr(p), | 834 | if (desc_get_tx_fs(p)) |
810 | desc_get_buf_len(p), DMA_TO_DEVICE); | 835 | dma_unmap_single(priv->device, desc_get_buf_addr(p), |
811 | 836 | desc_get_buf_len(p), DMA_TO_DEVICE); | |
812 | for (f = 0; f < skb_shinfo(priv->tx_skbuff[i])->nr_frags; f++) { | 837 | else |
813 | p = priv->dma_tx + i++; | ||
814 | dma_unmap_page(priv->device, desc_get_buf_addr(p), | 838 | dma_unmap_page(priv->device, desc_get_buf_addr(p), |
815 | desc_get_buf_len(p), DMA_TO_DEVICE); | 839 | desc_get_buf_len(p), DMA_TO_DEVICE); |
816 | } | ||
817 | 840 | ||
818 | dev_kfree_skb_any(priv->tx_skbuff[i]); | 841 | if (desc_get_tx_ls(p)) |
842 | dev_kfree_skb_any(priv->tx_skbuff[i]); | ||
819 | priv->tx_skbuff[i] = NULL; | 843 | priv->tx_skbuff[i] = NULL; |
820 | } | 844 | } |
821 | } | 845 | } |
@@ -852,8 +876,6 @@ static void xgmac_free_dma_desc_rings(struct xgmac_priv *priv) | |||
852 | */ | 876 | */ |
853 | static void xgmac_tx_complete(struct xgmac_priv *priv) | 877 | static void xgmac_tx_complete(struct xgmac_priv *priv) |
854 | { | 878 | { |
855 | int i; | ||
856 | |||
857 | while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) { | 879 | while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) { |
858 | unsigned int entry = priv->tx_tail; | 880 | unsigned int entry = priv->tx_tail; |
859 | struct sk_buff *skb = priv->tx_skbuff[entry]; | 881 | struct sk_buff *skb = priv->tx_skbuff[entry]; |
@@ -863,55 +885,45 @@ static void xgmac_tx_complete(struct xgmac_priv *priv) | |||
863 | if (desc_get_owner(p)) | 885 | if (desc_get_owner(p)) |
864 | break; | 886 | break; |
865 | 887 | ||
866 | /* Verify tx error by looking at the last segment */ | ||
867 | if (desc_get_tx_ls(p)) | ||
868 | desc_get_tx_status(priv, p); | ||
869 | |||
870 | netdev_dbg(priv->dev, "tx ring: curr %d, dirty %d\n", | 888 | netdev_dbg(priv->dev, "tx ring: curr %d, dirty %d\n", |
871 | priv->tx_head, priv->tx_tail); | 889 | priv->tx_head, priv->tx_tail); |
872 | 890 | ||
873 | dma_unmap_single(priv->device, desc_get_buf_addr(p), | 891 | if (desc_get_tx_fs(p)) |
874 | desc_get_buf_len(p), DMA_TO_DEVICE); | 892 | dma_unmap_single(priv->device, desc_get_buf_addr(p), |
875 | 893 | desc_get_buf_len(p), DMA_TO_DEVICE); | |
876 | priv->tx_skbuff[entry] = NULL; | 894 | else |
877 | priv->tx_tail = dma_ring_incr(entry, DMA_TX_RING_SZ); | ||
878 | |||
879 | if (!skb) { | ||
880 | continue; | ||
881 | } | ||
882 | |||
883 | for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { | ||
884 | entry = priv->tx_tail = dma_ring_incr(priv->tx_tail, | ||
885 | DMA_TX_RING_SZ); | ||
886 | p = priv->dma_tx + priv->tx_tail; | ||
887 | |||
888 | dma_unmap_page(priv->device, desc_get_buf_addr(p), | 895 | dma_unmap_page(priv->device, desc_get_buf_addr(p), |
889 | desc_get_buf_len(p), DMA_TO_DEVICE); | 896 | desc_get_buf_len(p), DMA_TO_DEVICE); |
897 | |||
898 | /* Check tx error on the last segment */ | ||
899 | if (desc_get_tx_ls(p)) { | ||
900 | desc_get_tx_status(priv, p); | ||
901 | dev_kfree_skb(skb); | ||
890 | } | 902 | } |
891 | 903 | ||
892 | dev_kfree_skb(skb); | 904 | priv->tx_skbuff[entry] = NULL; |
905 | priv->tx_tail = dma_ring_incr(entry, DMA_TX_RING_SZ); | ||
893 | } | 906 | } |
894 | 907 | ||
895 | if (dma_ring_space(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ) > | 908 | /* Ensure tx_tail is visible to xgmac_xmit */ |
896 | MAX_SKB_FRAGS) | 909 | smp_mb(); |
910 | if (unlikely(netif_queue_stopped(priv->dev) && | ||
911 | (tx_dma_ring_space(priv) > MAX_SKB_FRAGS))) | ||
897 | netif_wake_queue(priv->dev); | 912 | netif_wake_queue(priv->dev); |
898 | } | 913 | } |
899 | 914 | ||
900 | /** | 915 | static void xgmac_tx_timeout_work(struct work_struct *work) |
901 | * xgmac_tx_err: | ||
902 | * @priv: pointer to the private device structure | ||
903 | * Description: it cleans the descriptors and restarts the transmission | ||
904 | * in case of errors. | ||
905 | */ | ||
906 | static void xgmac_tx_err(struct xgmac_priv *priv) | ||
907 | { | 916 | { |
908 | u32 reg, value, inten; | 917 | u32 reg, value; |
918 | struct xgmac_priv *priv = | ||
919 | container_of(work, struct xgmac_priv, tx_timeout_work); | ||
909 | 920 | ||
910 | netif_stop_queue(priv->dev); | 921 | napi_disable(&priv->napi); |
911 | 922 | ||
912 | inten = readl(priv->base + XGMAC_DMA_INTR_ENA); | ||
913 | writel(0, priv->base + XGMAC_DMA_INTR_ENA); | 923 | writel(0, priv->base + XGMAC_DMA_INTR_ENA); |
914 | 924 | ||
925 | netif_tx_lock(priv->dev); | ||
926 | |||
915 | reg = readl(priv->base + XGMAC_DMA_CONTROL); | 927 | reg = readl(priv->base + XGMAC_DMA_CONTROL); |
916 | writel(reg & ~DMA_CONTROL_ST, priv->base + XGMAC_DMA_CONTROL); | 928 | writel(reg & ~DMA_CONTROL_ST, priv->base + XGMAC_DMA_CONTROL); |
917 | do { | 929 | do { |
@@ -927,9 +939,15 @@ static void xgmac_tx_err(struct xgmac_priv *priv) | |||
927 | 939 | ||
928 | writel(DMA_STATUS_TU | DMA_STATUS_TPS | DMA_STATUS_NIS | DMA_STATUS_AIS, | 940 | writel(DMA_STATUS_TU | DMA_STATUS_TPS | DMA_STATUS_NIS | DMA_STATUS_AIS, |
929 | priv->base + XGMAC_DMA_STATUS); | 941 | priv->base + XGMAC_DMA_STATUS); |
930 | writel(inten, priv->base + XGMAC_DMA_INTR_ENA); | ||
931 | 942 | ||
943 | netif_tx_unlock(priv->dev); | ||
932 | netif_wake_queue(priv->dev); | 944 | netif_wake_queue(priv->dev); |
945 | |||
946 | napi_enable(&priv->napi); | ||
947 | |||
948 | /* Enable interrupts */ | ||
949 | writel(DMA_INTR_DEFAULT_MASK, priv->base + XGMAC_DMA_STATUS); | ||
950 | writel(DMA_INTR_DEFAULT_MASK, priv->base + XGMAC_DMA_INTR_ENA); | ||
933 | } | 951 | } |
934 | 952 | ||
935 | static int xgmac_hw_init(struct net_device *dev) | 953 | static int xgmac_hw_init(struct net_device *dev) |
@@ -957,9 +975,7 @@ static int xgmac_hw_init(struct net_device *dev) | |||
957 | DMA_BUS_MODE_FB | DMA_BUS_MODE_ATDS | DMA_BUS_MODE_AAL; | 975 | DMA_BUS_MODE_FB | DMA_BUS_MODE_ATDS | DMA_BUS_MODE_AAL; |
958 | writel(value, ioaddr + XGMAC_DMA_BUS_MODE); | 976 | writel(value, ioaddr + XGMAC_DMA_BUS_MODE); |
959 | 977 | ||
960 | /* Enable interrupts */ | 978 | writel(0, ioaddr + XGMAC_DMA_INTR_ENA); |
961 | writel(DMA_INTR_DEFAULT_MASK, ioaddr + XGMAC_DMA_STATUS); | ||
962 | writel(DMA_INTR_DEFAULT_MASK, ioaddr + XGMAC_DMA_INTR_ENA); | ||
963 | 979 | ||
964 | /* Mask power mgt interrupt */ | 980 | /* Mask power mgt interrupt */ |
965 | writel(XGMAC_INT_STAT_PMTIM, ioaddr + XGMAC_INT_STAT); | 981 | writel(XGMAC_INT_STAT_PMTIM, ioaddr + XGMAC_INT_STAT); |
@@ -1027,6 +1043,10 @@ static int xgmac_open(struct net_device *dev) | |||
1027 | napi_enable(&priv->napi); | 1043 | napi_enable(&priv->napi); |
1028 | netif_start_queue(dev); | 1044 | netif_start_queue(dev); |
1029 | 1045 | ||
1046 | /* Enable interrupts */ | ||
1047 | writel(DMA_INTR_DEFAULT_MASK, ioaddr + XGMAC_DMA_STATUS); | ||
1048 | writel(DMA_INTR_DEFAULT_MASK, ioaddr + XGMAC_DMA_INTR_ENA); | ||
1049 | |||
1030 | return 0; | 1050 | return 0; |
1031 | } | 1051 | } |
1032 | 1052 | ||
@@ -1087,7 +1107,7 @@ static netdev_tx_t xgmac_xmit(struct sk_buff *skb, struct net_device *dev) | |||
1087 | paddr = dma_map_single(priv->device, skb->data, len, DMA_TO_DEVICE); | 1107 | paddr = dma_map_single(priv->device, skb->data, len, DMA_TO_DEVICE); |
1088 | if (dma_mapping_error(priv->device, paddr)) { | 1108 | if (dma_mapping_error(priv->device, paddr)) { |
1089 | dev_kfree_skb(skb); | 1109 | dev_kfree_skb(skb); |
1090 | return -EIO; | 1110 | return NETDEV_TX_OK; |
1091 | } | 1111 | } |
1092 | priv->tx_skbuff[entry] = skb; | 1112 | priv->tx_skbuff[entry] = skb; |
1093 | desc_set_buf_addr_and_size(desc, paddr, len); | 1113 | desc_set_buf_addr_and_size(desc, paddr, len); |
@@ -1099,14 +1119,12 @@ static netdev_tx_t xgmac_xmit(struct sk_buff *skb, struct net_device *dev) | |||
1099 | 1119 | ||
1100 | paddr = skb_frag_dma_map(priv->device, frag, 0, len, | 1120 | paddr = skb_frag_dma_map(priv->device, frag, 0, len, |
1101 | DMA_TO_DEVICE); | 1121 | DMA_TO_DEVICE); |
1102 | if (dma_mapping_error(priv->device, paddr)) { | 1122 | if (dma_mapping_error(priv->device, paddr)) |
1103 | dev_kfree_skb(skb); | 1123 | goto dma_err; |
1104 | return -EIO; | ||
1105 | } | ||
1106 | 1124 | ||
1107 | entry = dma_ring_incr(entry, DMA_TX_RING_SZ); | 1125 | entry = dma_ring_incr(entry, DMA_TX_RING_SZ); |
1108 | desc = priv->dma_tx + entry; | 1126 | desc = priv->dma_tx + entry; |
1109 | priv->tx_skbuff[entry] = NULL; | 1127 | priv->tx_skbuff[entry] = skb; |
1110 | 1128 | ||
1111 | desc_set_buf_addr_and_size(desc, paddr, len); | 1129 | desc_set_buf_addr_and_size(desc, paddr, len); |
1112 | if (i < (nfrags - 1)) | 1130 | if (i < (nfrags - 1)) |
@@ -1124,13 +1142,35 @@ static netdev_tx_t xgmac_xmit(struct sk_buff *skb, struct net_device *dev) | |||
1124 | wmb(); | 1142 | wmb(); |
1125 | desc_set_tx_owner(first, desc_flags | TXDESC_FIRST_SEG); | 1143 | desc_set_tx_owner(first, desc_flags | TXDESC_FIRST_SEG); |
1126 | 1144 | ||
1145 | writel(1, priv->base + XGMAC_DMA_TX_POLL); | ||
1146 | |||
1127 | priv->tx_head = dma_ring_incr(entry, DMA_TX_RING_SZ); | 1147 | priv->tx_head = dma_ring_incr(entry, DMA_TX_RING_SZ); |
1128 | 1148 | ||
1129 | writel(1, priv->base + XGMAC_DMA_TX_POLL); | 1149 | /* Ensure tx_head update is visible to tx completion */ |
1130 | if (dma_ring_space(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ) < | 1150 | smp_mb(); |
1131 | MAX_SKB_FRAGS) | 1151 | if (unlikely(tx_dma_ring_space(priv) <= MAX_SKB_FRAGS)) { |
1132 | netif_stop_queue(dev); | 1152 | netif_stop_queue(dev); |
1153 | /* Ensure netif_stop_queue is visible to tx completion */ | ||
1154 | smp_mb(); | ||
1155 | if (tx_dma_ring_space(priv) > MAX_SKB_FRAGS) | ||
1156 | netif_start_queue(dev); | ||
1157 | } | ||
1158 | return NETDEV_TX_OK; | ||
1133 | 1159 | ||
1160 | dma_err: | ||
1161 | entry = priv->tx_head; | ||
1162 | for ( ; i > 0; i--) { | ||
1163 | entry = dma_ring_incr(entry, DMA_TX_RING_SZ); | ||
1164 | desc = priv->dma_tx + entry; | ||
1165 | priv->tx_skbuff[entry] = NULL; | ||
1166 | dma_unmap_page(priv->device, desc_get_buf_addr(desc), | ||
1167 | desc_get_buf_len(desc), DMA_TO_DEVICE); | ||
1168 | desc_clear_tx_owner(desc); | ||
1169 | } | ||
1170 | desc = first; | ||
1171 | dma_unmap_single(priv->device, desc_get_buf_addr(desc), | ||
1172 | desc_get_buf_len(desc), DMA_TO_DEVICE); | ||
1173 | dev_kfree_skb(skb); | ||
1134 | return NETDEV_TX_OK; | 1174 | return NETDEV_TX_OK; |
1135 | } | 1175 | } |
1136 | 1176 | ||
@@ -1174,7 +1214,7 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit) | |||
1174 | 1214 | ||
1175 | skb_put(skb, frame_len); | 1215 | skb_put(skb, frame_len); |
1176 | dma_unmap_single(priv->device, desc_get_buf_addr(p), | 1216 | dma_unmap_single(priv->device, desc_get_buf_addr(p), |
1177 | frame_len, DMA_FROM_DEVICE); | 1217 | priv->dma_buf_sz - NET_IP_ALIGN, DMA_FROM_DEVICE); |
1178 | 1218 | ||
1179 | skb->protocol = eth_type_trans(skb, priv->dev); | 1219 | skb->protocol = eth_type_trans(skb, priv->dev); |
1180 | skb->ip_summed = ip_checksum; | 1220 | skb->ip_summed = ip_checksum; |
@@ -1225,9 +1265,7 @@ static int xgmac_poll(struct napi_struct *napi, int budget) | |||
1225 | static void xgmac_tx_timeout(struct net_device *dev) | 1265 | static void xgmac_tx_timeout(struct net_device *dev) |
1226 | { | 1266 | { |
1227 | struct xgmac_priv *priv = netdev_priv(dev); | 1267 | struct xgmac_priv *priv = netdev_priv(dev); |
1228 | 1268 | schedule_work(&priv->tx_timeout_work); | |
1229 | /* Clear Tx resources and restart transmitting again */ | ||
1230 | xgmac_tx_err(priv); | ||
1231 | } | 1269 | } |
1232 | 1270 | ||
1233 | /** | 1271 | /** |
@@ -1286,6 +1324,8 @@ static void xgmac_set_rx_mode(struct net_device *dev) | |||
1286 | if ((netdev_mc_count(dev) + reg - 1) > XGMAC_MAX_FILTER_ADDR) { | 1324 | if ((netdev_mc_count(dev) + reg - 1) > XGMAC_MAX_FILTER_ADDR) { |
1287 | use_hash = true; | 1325 | use_hash = true; |
1288 | value |= XGMAC_FRAME_FILTER_HMC | XGMAC_FRAME_FILTER_HPF; | 1326 | value |= XGMAC_FRAME_FILTER_HMC | XGMAC_FRAME_FILTER_HPF; |
1327 | } else { | ||
1328 | use_hash = false; | ||
1289 | } | 1329 | } |
1290 | netdev_for_each_mc_addr(ha, dev) { | 1330 | netdev_for_each_mc_addr(ha, dev) { |
1291 | if (use_hash) { | 1331 | if (use_hash) { |
@@ -1302,6 +1342,8 @@ static void xgmac_set_rx_mode(struct net_device *dev) | |||
1302 | } | 1342 | } |
1303 | 1343 | ||
1304 | out: | 1344 | out: |
1345 | for (i = reg; i < XGMAC_MAX_FILTER_ADDR; i++) | ||
1346 | xgmac_set_mac_addr(ioaddr, NULL, reg); | ||
1305 | for (i = 0; i < XGMAC_NUM_HASH; i++) | 1347 | for (i = 0; i < XGMAC_NUM_HASH; i++) |
1306 | writel(hash_filter[i], ioaddr + XGMAC_HASH(i)); | 1348 | writel(hash_filter[i], ioaddr + XGMAC_HASH(i)); |
1307 | 1349 | ||
@@ -1366,7 +1408,6 @@ static irqreturn_t xgmac_pmt_interrupt(int irq, void *dev_id) | |||
1366 | static irqreturn_t xgmac_interrupt(int irq, void *dev_id) | 1408 | static irqreturn_t xgmac_interrupt(int irq, void *dev_id) |
1367 | { | 1409 | { |
1368 | u32 intr_status; | 1410 | u32 intr_status; |
1369 | bool tx_err = false; | ||
1370 | struct net_device *dev = (struct net_device *)dev_id; | 1411 | struct net_device *dev = (struct net_device *)dev_id; |
1371 | struct xgmac_priv *priv = netdev_priv(dev); | 1412 | struct xgmac_priv *priv = netdev_priv(dev); |
1372 | struct xgmac_extra_stats *x = &priv->xstats; | 1413 | struct xgmac_extra_stats *x = &priv->xstats; |
@@ -1396,16 +1437,12 @@ static irqreturn_t xgmac_interrupt(int irq, void *dev_id) | |||
1396 | if (intr_status & DMA_STATUS_TPS) { | 1437 | if (intr_status & DMA_STATUS_TPS) { |
1397 | netdev_err(priv->dev, "transmit process stopped\n"); | 1438 | netdev_err(priv->dev, "transmit process stopped\n"); |
1398 | x->tx_process_stopped++; | 1439 | x->tx_process_stopped++; |
1399 | tx_err = true; | 1440 | schedule_work(&priv->tx_timeout_work); |
1400 | } | 1441 | } |
1401 | if (intr_status & DMA_STATUS_FBI) { | 1442 | if (intr_status & DMA_STATUS_FBI) { |
1402 | netdev_err(priv->dev, "fatal bus error\n"); | 1443 | netdev_err(priv->dev, "fatal bus error\n"); |
1403 | x->fatal_bus_error++; | 1444 | x->fatal_bus_error++; |
1404 | tx_err = true; | ||
1405 | } | 1445 | } |
1406 | |||
1407 | if (tx_err) | ||
1408 | xgmac_tx_err(priv); | ||
1409 | } | 1446 | } |
1410 | 1447 | ||
1411 | /* TX/RX NORMAL interrupts */ | 1448 | /* TX/RX NORMAL interrupts */ |
@@ -1569,7 +1606,6 @@ static const struct xgmac_stats xgmac_gstrings_stats[] = { | |||
1569 | XGMAC_STAT(rx_payload_error), | 1606 | XGMAC_STAT(rx_payload_error), |
1570 | XGMAC_STAT(rx_ip_header_error), | 1607 | XGMAC_STAT(rx_ip_header_error), |
1571 | XGMAC_STAT(rx_da_filter_fail), | 1608 | XGMAC_STAT(rx_da_filter_fail), |
1572 | XGMAC_STAT(rx_sa_filter_fail), | ||
1573 | XGMAC_STAT(fatal_bus_error), | 1609 | XGMAC_STAT(fatal_bus_error), |
1574 | XGMAC_HW_STAT(rx_watchdog, XGMAC_MMC_RXWATCHDOG), | 1610 | XGMAC_HW_STAT(rx_watchdog, XGMAC_MMC_RXWATCHDOG), |
1575 | XGMAC_HW_STAT(tx_vlan, XGMAC_MMC_TXVLANFRAME), | 1611 | XGMAC_HW_STAT(tx_vlan, XGMAC_MMC_TXVLANFRAME), |
@@ -1708,6 +1744,7 @@ static int xgmac_probe(struct platform_device *pdev) | |||
1708 | ndev->netdev_ops = &xgmac_netdev_ops; | 1744 | ndev->netdev_ops = &xgmac_netdev_ops; |
1709 | SET_ETHTOOL_OPS(ndev, &xgmac_ethtool_ops); | 1745 | SET_ETHTOOL_OPS(ndev, &xgmac_ethtool_ops); |
1710 | spin_lock_init(&priv->stats_lock); | 1746 | spin_lock_init(&priv->stats_lock); |
1747 | INIT_WORK(&priv->tx_timeout_work, xgmac_tx_timeout_work); | ||
1711 | 1748 | ||
1712 | priv->device = &pdev->dev; | 1749 | priv->device = &pdev->dev; |
1713 | priv->dev = ndev; | 1750 | priv->dev = ndev; |
@@ -1759,7 +1796,7 @@ static int xgmac_probe(struct platform_device *pdev) | |||
1759 | if (device_can_wakeup(priv->device)) | 1796 | if (device_can_wakeup(priv->device)) |
1760 | priv->wolopts = WAKE_MAGIC; /* Magic Frame as default */ | 1797 | priv->wolopts = WAKE_MAGIC; /* Magic Frame as default */ |
1761 | 1798 | ||
1762 | ndev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA; | 1799 | ndev->hw_features = NETIF_F_SG | NETIF_F_HIGHDMA; |
1763 | if (readl(priv->base + XGMAC_DMA_HW_FEATURE) & DMA_HW_FEAT_TXCOESEL) | 1800 | if (readl(priv->base + XGMAC_DMA_HW_FEATURE) & DMA_HW_FEAT_TXCOESEL) |
1764 | ndev->hw_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | | 1801 | ndev->hw_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | |
1765 | NETIF_F_RXCSUM; | 1802 | NETIF_F_RXCSUM; |
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index e104db7fcf27..3224d28cdad4 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c | |||
@@ -4476,6 +4476,10 @@ static int be_resume(struct pci_dev *pdev) | |||
4476 | pci_set_power_state(pdev, PCI_D0); | 4476 | pci_set_power_state(pdev, PCI_D0); |
4477 | pci_restore_state(pdev); | 4477 | pci_restore_state(pdev); |
4478 | 4478 | ||
4479 | status = be_fw_wait_ready(adapter); | ||
4480 | if (status) | ||
4481 | return status; | ||
4482 | |||
4479 | /* tell fw we're ready to fire cmds */ | 4483 | /* tell fw we're ready to fire cmds */ |
4480 | status = be_cmd_fw_init(adapter); | 4484 | status = be_cmd_fw_init(adapter); |
4481 | if (status) | 4485 | if (status) |
diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h index ae236009f1a8..0120217a16dd 100644 --- a/drivers/net/ethernet/freescale/fec.h +++ b/drivers/net/ethernet/freescale/fec.h | |||
@@ -296,6 +296,9 @@ struct fec_enet_private { | |||
296 | /* The ring entries to be free()ed */ | 296 | /* The ring entries to be free()ed */ |
297 | struct bufdesc *dirty_tx; | 297 | struct bufdesc *dirty_tx; |
298 | 298 | ||
299 | unsigned short tx_ring_size; | ||
300 | unsigned short rx_ring_size; | ||
301 | |||
299 | struct platform_device *pdev; | 302 | struct platform_device *pdev; |
300 | 303 | ||
301 | int opened; | 304 | int opened; |
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 0cd5e4b8b545..f9aacf5d8523 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c | |||
@@ -238,22 +238,57 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address"); | |||
238 | 238 | ||
239 | static int mii_cnt; | 239 | static int mii_cnt; |
240 | 240 | ||
241 | static struct bufdesc *fec_enet_get_nextdesc(struct bufdesc *bdp, int is_ex) | 241 | static inline |
242 | struct bufdesc *fec_enet_get_nextdesc(struct bufdesc *bdp, struct fec_enet_private *fep) | ||
242 | { | 243 | { |
243 | struct bufdesc_ex *ex = (struct bufdesc_ex *)bdp; | 244 | struct bufdesc *new_bd = bdp + 1; |
244 | if (is_ex) | 245 | struct bufdesc_ex *ex_new_bd = (struct bufdesc_ex *)bdp + 1; |
245 | return (struct bufdesc *)(ex + 1); | 246 | struct bufdesc_ex *ex_base; |
247 | struct bufdesc *base; | ||
248 | int ring_size; | ||
249 | |||
250 | if (bdp >= fep->tx_bd_base) { | ||
251 | base = fep->tx_bd_base; | ||
252 | ring_size = fep->tx_ring_size; | ||
253 | ex_base = (struct bufdesc_ex *)fep->tx_bd_base; | ||
254 | } else { | ||
255 | base = fep->rx_bd_base; | ||
256 | ring_size = fep->rx_ring_size; | ||
257 | ex_base = (struct bufdesc_ex *)fep->rx_bd_base; | ||
258 | } | ||
259 | |||
260 | if (fep->bufdesc_ex) | ||
261 | return (struct bufdesc *)((ex_new_bd >= (ex_base + ring_size)) ? | ||
262 | ex_base : ex_new_bd); | ||
246 | else | 263 | else |
247 | return bdp + 1; | 264 | return (new_bd >= (base + ring_size)) ? |
265 | base : new_bd; | ||
248 | } | 266 | } |
249 | 267 | ||
250 | static struct bufdesc *fec_enet_get_prevdesc(struct bufdesc *bdp, int is_ex) | 268 | static inline |
269 | struct bufdesc *fec_enet_get_prevdesc(struct bufdesc *bdp, struct fec_enet_private *fep) | ||
251 | { | 270 | { |
252 | struct bufdesc_ex *ex = (struct bufdesc_ex *)bdp; | 271 | struct bufdesc *new_bd = bdp - 1; |
253 | if (is_ex) | 272 | struct bufdesc_ex *ex_new_bd = (struct bufdesc_ex *)bdp - 1; |
254 | return (struct bufdesc *)(ex - 1); | 273 | struct bufdesc_ex *ex_base; |
274 | struct bufdesc *base; | ||
275 | int ring_size; | ||
276 | |||
277 | if (bdp >= fep->tx_bd_base) { | ||
278 | base = fep->tx_bd_base; | ||
279 | ring_size = fep->tx_ring_size; | ||
280 | ex_base = (struct bufdesc_ex *)fep->tx_bd_base; | ||
281 | } else { | ||
282 | base = fep->rx_bd_base; | ||
283 | ring_size = fep->rx_ring_size; | ||
284 | ex_base = (struct bufdesc_ex *)fep->rx_bd_base; | ||
285 | } | ||
286 | |||
287 | if (fep->bufdesc_ex) | ||
288 | return (struct bufdesc *)((ex_new_bd < ex_base) ? | ||
289 | (ex_new_bd + ring_size) : ex_new_bd); | ||
255 | else | 290 | else |
256 | return bdp - 1; | 291 | return (new_bd < base) ? (new_bd + ring_size) : new_bd; |
257 | } | 292 | } |
258 | 293 | ||
259 | static void *swap_buffer(void *bufaddr, int len) | 294 | static void *swap_buffer(void *bufaddr, int len) |
@@ -379,7 +414,7 @@ fec_enet_start_xmit(struct sk_buff *skb, struct net_device *ndev) | |||
379 | } | 414 | } |
380 | } | 415 | } |
381 | 416 | ||
382 | bdp_pre = fec_enet_get_prevdesc(bdp, fep->bufdesc_ex); | 417 | bdp_pre = fec_enet_get_prevdesc(bdp, fep); |
383 | if ((id_entry->driver_data & FEC_QUIRK_ERR006358) && | 418 | if ((id_entry->driver_data & FEC_QUIRK_ERR006358) && |
384 | !(bdp_pre->cbd_sc & BD_ENET_TX_READY)) { | 419 | !(bdp_pre->cbd_sc & BD_ENET_TX_READY)) { |
385 | fep->delay_work.trig_tx = true; | 420 | fep->delay_work.trig_tx = true; |
@@ -388,10 +423,7 @@ fec_enet_start_xmit(struct sk_buff *skb, struct net_device *ndev) | |||
388 | } | 423 | } |
389 | 424 | ||
390 | /* If this was the last BD in the ring, start at the beginning again. */ | 425 | /* If this was the last BD in the ring, start at the beginning again. */ |
391 | if (status & BD_ENET_TX_WRAP) | 426 | bdp = fec_enet_get_nextdesc(bdp, fep); |
392 | bdp = fep->tx_bd_base; | ||
393 | else | ||
394 | bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex); | ||
395 | 427 | ||
396 | fep->cur_tx = bdp; | 428 | fep->cur_tx = bdp; |
397 | 429 | ||
@@ -416,18 +448,18 @@ static void fec_enet_bd_init(struct net_device *dev) | |||
416 | 448 | ||
417 | /* Initialize the receive buffer descriptors. */ | 449 | /* Initialize the receive buffer descriptors. */ |
418 | bdp = fep->rx_bd_base; | 450 | bdp = fep->rx_bd_base; |
419 | for (i = 0; i < RX_RING_SIZE; i++) { | 451 | for (i = 0; i < fep->rx_ring_size; i++) { |
420 | 452 | ||
421 | /* Initialize the BD for every fragment in the page. */ | 453 | /* Initialize the BD for every fragment in the page. */ |
422 | if (bdp->cbd_bufaddr) | 454 | if (bdp->cbd_bufaddr) |
423 | bdp->cbd_sc = BD_ENET_RX_EMPTY; | 455 | bdp->cbd_sc = BD_ENET_RX_EMPTY; |
424 | else | 456 | else |
425 | bdp->cbd_sc = 0; | 457 | bdp->cbd_sc = 0; |
426 | bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex); | 458 | bdp = fec_enet_get_nextdesc(bdp, fep); |
427 | } | 459 | } |
428 | 460 | ||
429 | /* Set the last buffer to wrap */ | 461 | /* Set the last buffer to wrap */ |
430 | bdp = fec_enet_get_prevdesc(bdp, fep->bufdesc_ex); | 462 | bdp = fec_enet_get_prevdesc(bdp, fep); |
431 | bdp->cbd_sc |= BD_SC_WRAP; | 463 | bdp->cbd_sc |= BD_SC_WRAP; |
432 | 464 | ||
433 | fep->cur_rx = fep->rx_bd_base; | 465 | fep->cur_rx = fep->rx_bd_base; |
@@ -435,7 +467,7 @@ static void fec_enet_bd_init(struct net_device *dev) | |||
435 | /* ...and the same for transmit */ | 467 | /* ...and the same for transmit */ |
436 | bdp = fep->tx_bd_base; | 468 | bdp = fep->tx_bd_base; |
437 | fep->cur_tx = bdp; | 469 | fep->cur_tx = bdp; |
438 | for (i = 0; i < TX_RING_SIZE; i++) { | 470 | for (i = 0; i < fep->tx_ring_size; i++) { |
439 | 471 | ||
440 | /* Initialize the BD for every fragment in the page. */ | 472 | /* Initialize the BD for every fragment in the page. */ |
441 | bdp->cbd_sc = 0; | 473 | bdp->cbd_sc = 0; |
@@ -444,11 +476,11 @@ static void fec_enet_bd_init(struct net_device *dev) | |||
444 | fep->tx_skbuff[i] = NULL; | 476 | fep->tx_skbuff[i] = NULL; |
445 | } | 477 | } |
446 | bdp->cbd_bufaddr = 0; | 478 | bdp->cbd_bufaddr = 0; |
447 | bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex); | 479 | bdp = fec_enet_get_nextdesc(bdp, fep); |
448 | } | 480 | } |
449 | 481 | ||
450 | /* Set the last buffer to wrap */ | 482 | /* Set the last buffer to wrap */ |
451 | bdp = fec_enet_get_prevdesc(bdp, fep->bufdesc_ex); | 483 | bdp = fec_enet_get_prevdesc(bdp, fep); |
452 | bdp->cbd_sc |= BD_SC_WRAP; | 484 | bdp->cbd_sc |= BD_SC_WRAP; |
453 | fep->dirty_tx = bdp; | 485 | fep->dirty_tx = bdp; |
454 | } | 486 | } |
@@ -509,10 +541,10 @@ fec_restart(struct net_device *ndev, int duplex) | |||
509 | writel(fep->bd_dma, fep->hwp + FEC_R_DES_START); | 541 | writel(fep->bd_dma, fep->hwp + FEC_R_DES_START); |
510 | if (fep->bufdesc_ex) | 542 | if (fep->bufdesc_ex) |
511 | writel((unsigned long)fep->bd_dma + sizeof(struct bufdesc_ex) | 543 | writel((unsigned long)fep->bd_dma + sizeof(struct bufdesc_ex) |
512 | * RX_RING_SIZE, fep->hwp + FEC_X_DES_START); | 544 | * fep->rx_ring_size, fep->hwp + FEC_X_DES_START); |
513 | else | 545 | else |
514 | writel((unsigned long)fep->bd_dma + sizeof(struct bufdesc) | 546 | writel((unsigned long)fep->bd_dma + sizeof(struct bufdesc) |
515 | * RX_RING_SIZE, fep->hwp + FEC_X_DES_START); | 547 | * fep->rx_ring_size, fep->hwp + FEC_X_DES_START); |
516 | 548 | ||
517 | 549 | ||
518 | for (i = 0; i <= TX_RING_MOD_MASK; i++) { | 550 | for (i = 0; i <= TX_RING_MOD_MASK; i++) { |
@@ -726,10 +758,7 @@ fec_enet_tx(struct net_device *ndev) | |||
726 | bdp = fep->dirty_tx; | 758 | bdp = fep->dirty_tx; |
727 | 759 | ||
728 | /* get next bdp of dirty_tx */ | 760 | /* get next bdp of dirty_tx */ |
729 | if (bdp->cbd_sc & BD_ENET_TX_WRAP) | 761 | bdp = fec_enet_get_nextdesc(bdp, fep); |
730 | bdp = fep->tx_bd_base; | ||
731 | else | ||
732 | bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex); | ||
733 | 762 | ||
734 | while (((status = bdp->cbd_sc) & BD_ENET_TX_READY) == 0) { | 763 | while (((status = bdp->cbd_sc) & BD_ENET_TX_READY) == 0) { |
735 | 764 | ||
@@ -799,10 +828,7 @@ fec_enet_tx(struct net_device *ndev) | |||
799 | fep->dirty_tx = bdp; | 828 | fep->dirty_tx = bdp; |
800 | 829 | ||
801 | /* Update pointer to next buffer descriptor to be transmitted */ | 830 | /* Update pointer to next buffer descriptor to be transmitted */ |
802 | if (status & BD_ENET_TX_WRAP) | 831 | bdp = fec_enet_get_nextdesc(bdp, fep); |
803 | bdp = fep->tx_bd_base; | ||
804 | else | ||
805 | bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex); | ||
806 | 832 | ||
807 | /* Since we have freed up a buffer, the ring is no longer full | 833 | /* Since we have freed up a buffer, the ring is no longer full |
808 | */ | 834 | */ |
@@ -970,8 +996,7 @@ fec_enet_rx(struct net_device *ndev, int budget) | |||
970 | htons(ETH_P_8021Q), | 996 | htons(ETH_P_8021Q), |
971 | vlan_tag); | 997 | vlan_tag); |
972 | 998 | ||
973 | if (!skb_defer_rx_timestamp(skb)) | 999 | napi_gro_receive(&fep->napi, skb); |
974 | napi_gro_receive(&fep->napi, skb); | ||
975 | } | 1000 | } |
976 | 1001 | ||
977 | bdp->cbd_bufaddr = dma_map_single(&fep->pdev->dev, data, | 1002 | bdp->cbd_bufaddr = dma_map_single(&fep->pdev->dev, data, |
@@ -993,10 +1018,8 @@ rx_processing_done: | |||
993 | } | 1018 | } |
994 | 1019 | ||
995 | /* Update BD pointer to next entry */ | 1020 | /* Update BD pointer to next entry */ |
996 | if (status & BD_ENET_RX_WRAP) | 1021 | bdp = fec_enet_get_nextdesc(bdp, fep); |
997 | bdp = fep->rx_bd_base; | 1022 | |
998 | else | ||
999 | bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex); | ||
1000 | /* Doing this here will keep the FEC running while we process | 1023 | /* Doing this here will keep the FEC running while we process |
1001 | * incoming frames. On a heavily loaded network, we should be | 1024 | * incoming frames. On a heavily loaded network, we should be |
1002 | * able to keep up at the expense of system resources. | 1025 | * able to keep up at the expense of system resources. |
@@ -1662,7 +1685,7 @@ static void fec_enet_free_buffers(struct net_device *ndev) | |||
1662 | struct bufdesc *bdp; | 1685 | struct bufdesc *bdp; |
1663 | 1686 | ||
1664 | bdp = fep->rx_bd_base; | 1687 | bdp = fep->rx_bd_base; |
1665 | for (i = 0; i < RX_RING_SIZE; i++) { | 1688 | for (i = 0; i < fep->rx_ring_size; i++) { |
1666 | skb = fep->rx_skbuff[i]; | 1689 | skb = fep->rx_skbuff[i]; |
1667 | 1690 | ||
1668 | if (bdp->cbd_bufaddr) | 1691 | if (bdp->cbd_bufaddr) |
@@ -1670,11 +1693,11 @@ static void fec_enet_free_buffers(struct net_device *ndev) | |||
1670 | FEC_ENET_RX_FRSIZE, DMA_FROM_DEVICE); | 1693 | FEC_ENET_RX_FRSIZE, DMA_FROM_DEVICE); |
1671 | if (skb) | 1694 | if (skb) |
1672 | dev_kfree_skb(skb); | 1695 | dev_kfree_skb(skb); |
1673 | bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex); | 1696 | bdp = fec_enet_get_nextdesc(bdp, fep); |
1674 | } | 1697 | } |
1675 | 1698 | ||
1676 | bdp = fep->tx_bd_base; | 1699 | bdp = fep->tx_bd_base; |
1677 | for (i = 0; i < TX_RING_SIZE; i++) | 1700 | for (i = 0; i < fep->tx_ring_size; i++) |
1678 | kfree(fep->tx_bounce[i]); | 1701 | kfree(fep->tx_bounce[i]); |
1679 | } | 1702 | } |
1680 | 1703 | ||
@@ -1686,7 +1709,7 @@ static int fec_enet_alloc_buffers(struct net_device *ndev) | |||
1686 | struct bufdesc *bdp; | 1709 | struct bufdesc *bdp; |
1687 | 1710 | ||
1688 | bdp = fep->rx_bd_base; | 1711 | bdp = fep->rx_bd_base; |
1689 | for (i = 0; i < RX_RING_SIZE; i++) { | 1712 | for (i = 0; i < fep->rx_ring_size; i++) { |
1690 | skb = netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE); | 1713 | skb = netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE); |
1691 | if (!skb) { | 1714 | if (!skb) { |
1692 | fec_enet_free_buffers(ndev); | 1715 | fec_enet_free_buffers(ndev); |
@@ -1703,15 +1726,15 @@ static int fec_enet_alloc_buffers(struct net_device *ndev) | |||
1703 | ebdp->cbd_esc = BD_ENET_RX_INT; | 1726 | ebdp->cbd_esc = BD_ENET_RX_INT; |
1704 | } | 1727 | } |
1705 | 1728 | ||
1706 | bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex); | 1729 | bdp = fec_enet_get_nextdesc(bdp, fep); |
1707 | } | 1730 | } |
1708 | 1731 | ||
1709 | /* Set the last buffer to wrap. */ | 1732 | /* Set the last buffer to wrap. */ |
1710 | bdp = fec_enet_get_prevdesc(bdp, fep->bufdesc_ex); | 1733 | bdp = fec_enet_get_prevdesc(bdp, fep); |
1711 | bdp->cbd_sc |= BD_SC_WRAP; | 1734 | bdp->cbd_sc |= BD_SC_WRAP; |
1712 | 1735 | ||
1713 | bdp = fep->tx_bd_base; | 1736 | bdp = fep->tx_bd_base; |
1714 | for (i = 0; i < TX_RING_SIZE; i++) { | 1737 | for (i = 0; i < fep->tx_ring_size; i++) { |
1715 | fep->tx_bounce[i] = kmalloc(FEC_ENET_TX_FRSIZE, GFP_KERNEL); | 1738 | fep->tx_bounce[i] = kmalloc(FEC_ENET_TX_FRSIZE, GFP_KERNEL); |
1716 | 1739 | ||
1717 | bdp->cbd_sc = 0; | 1740 | bdp->cbd_sc = 0; |
@@ -1722,11 +1745,11 @@ static int fec_enet_alloc_buffers(struct net_device *ndev) | |||
1722 | ebdp->cbd_esc = BD_ENET_TX_INT; | 1745 | ebdp->cbd_esc = BD_ENET_TX_INT; |
1723 | } | 1746 | } |
1724 | 1747 | ||
1725 | bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex); | 1748 | bdp = fec_enet_get_nextdesc(bdp, fep); |
1726 | } | 1749 | } |
1727 | 1750 | ||
1728 | /* Set the last buffer to wrap. */ | 1751 | /* Set the last buffer to wrap. */ |
1729 | bdp = fec_enet_get_prevdesc(bdp, fep->bufdesc_ex); | 1752 | bdp = fec_enet_get_prevdesc(bdp, fep); |
1730 | bdp->cbd_sc |= BD_SC_WRAP; | 1753 | bdp->cbd_sc |= BD_SC_WRAP; |
1731 | 1754 | ||
1732 | return 0; | 1755 | return 0; |
@@ -1966,13 +1989,17 @@ static int fec_enet_init(struct net_device *ndev) | |||
1966 | /* Get the Ethernet address */ | 1989 | /* Get the Ethernet address */ |
1967 | fec_get_mac(ndev); | 1990 | fec_get_mac(ndev); |
1968 | 1991 | ||
1992 | /* init the tx & rx ring size */ | ||
1993 | fep->tx_ring_size = TX_RING_SIZE; | ||
1994 | fep->rx_ring_size = RX_RING_SIZE; | ||
1995 | |||
1969 | /* Set receive and transmit descriptor base. */ | 1996 | /* Set receive and transmit descriptor base. */ |
1970 | fep->rx_bd_base = cbd_base; | 1997 | fep->rx_bd_base = cbd_base; |
1971 | if (fep->bufdesc_ex) | 1998 | if (fep->bufdesc_ex) |
1972 | fep->tx_bd_base = (struct bufdesc *) | 1999 | fep->tx_bd_base = (struct bufdesc *) |
1973 | (((struct bufdesc_ex *)cbd_base) + RX_RING_SIZE); | 2000 | (((struct bufdesc_ex *)cbd_base) + fep->rx_ring_size); |
1974 | else | 2001 | else |
1975 | fep->tx_bd_base = cbd_base + RX_RING_SIZE; | 2002 | fep->tx_bd_base = cbd_base + fep->rx_ring_size; |
1976 | 2003 | ||
1977 | /* The FEC Ethernet specific entries in the device structure */ | 2004 | /* The FEC Ethernet specific entries in the device structure */ |
1978 | ndev->watchdog_timeo = TX_TIMEOUT; | 2005 | ndev->watchdog_timeo = TX_TIMEOUT; |
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index 7fbe6abf6054..23de82a9da82 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c | |||
@@ -3069,7 +3069,7 @@ jme_init_one(struct pci_dev *pdev, | |||
3069 | jwrite32(jme, JME_APMC, apmc); | 3069 | jwrite32(jme, JME_APMC, apmc); |
3070 | } | 3070 | } |
3071 | 3071 | ||
3072 | NETIF_NAPI_SET(netdev, &jme->napi, jme_poll, jme->rx_ring_size >> 2) | 3072 | NETIF_NAPI_SET(netdev, &jme->napi, jme_poll, NAPI_POLL_WEIGHT) |
3073 | 3073 | ||
3074 | spin_lock_init(&jme->phy_lock); | 3074 | spin_lock_init(&jme->phy_lock); |
3075 | spin_lock_init(&jme->macaddr_lock); | 3075 | spin_lock_init(&jme->macaddr_lock); |
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 2777c70c603b..e35bac7cfdf1 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c | |||
@@ -138,7 +138,9 @@ | |||
138 | #define MVNETA_GMAC_FORCE_LINK_PASS BIT(1) | 138 | #define MVNETA_GMAC_FORCE_LINK_PASS BIT(1) |
139 | #define MVNETA_GMAC_CONFIG_MII_SPEED BIT(5) | 139 | #define MVNETA_GMAC_CONFIG_MII_SPEED BIT(5) |
140 | #define MVNETA_GMAC_CONFIG_GMII_SPEED BIT(6) | 140 | #define MVNETA_GMAC_CONFIG_GMII_SPEED BIT(6) |
141 | #define MVNETA_GMAC_AN_SPEED_EN BIT(7) | ||
141 | #define MVNETA_GMAC_CONFIG_FULL_DUPLEX BIT(12) | 142 | #define MVNETA_GMAC_CONFIG_FULL_DUPLEX BIT(12) |
143 | #define MVNETA_GMAC_AN_DUPLEX_EN BIT(13) | ||
142 | #define MVNETA_MIB_COUNTERS_BASE 0x3080 | 144 | #define MVNETA_MIB_COUNTERS_BASE 0x3080 |
143 | #define MVNETA_MIB_LATE_COLLISION 0x7c | 145 | #define MVNETA_MIB_LATE_COLLISION 0x7c |
144 | #define MVNETA_DA_FILT_SPEC_MCAST 0x3400 | 146 | #define MVNETA_DA_FILT_SPEC_MCAST 0x3400 |
@@ -948,6 +950,13 @@ static void mvneta_defaults_set(struct mvneta_port *pp) | |||
948 | /* Assign port SDMA configuration */ | 950 | /* Assign port SDMA configuration */ |
949 | mvreg_write(pp, MVNETA_SDMA_CONFIG, val); | 951 | mvreg_write(pp, MVNETA_SDMA_CONFIG, val); |
950 | 952 | ||
953 | /* Disable PHY polling in hardware, since we're using the | ||
954 | * kernel phylib to do this. | ||
955 | */ | ||
956 | val = mvreg_read(pp, MVNETA_UNIT_CONTROL); | ||
957 | val &= ~MVNETA_PHY_POLLING_ENABLE; | ||
958 | mvreg_write(pp, MVNETA_UNIT_CONTROL, val); | ||
959 | |||
951 | mvneta_set_ucast_table(pp, -1); | 960 | mvneta_set_ucast_table(pp, -1); |
952 | mvneta_set_special_mcast_table(pp, -1); | 961 | mvneta_set_special_mcast_table(pp, -1); |
953 | mvneta_set_other_mcast_table(pp, -1); | 962 | mvneta_set_other_mcast_table(pp, -1); |
@@ -2340,7 +2349,9 @@ static void mvneta_adjust_link(struct net_device *ndev) | |||
2340 | val = mvreg_read(pp, MVNETA_GMAC_AUTONEG_CONFIG); | 2349 | val = mvreg_read(pp, MVNETA_GMAC_AUTONEG_CONFIG); |
2341 | val &= ~(MVNETA_GMAC_CONFIG_MII_SPEED | | 2350 | val &= ~(MVNETA_GMAC_CONFIG_MII_SPEED | |
2342 | MVNETA_GMAC_CONFIG_GMII_SPEED | | 2351 | MVNETA_GMAC_CONFIG_GMII_SPEED | |
2343 | MVNETA_GMAC_CONFIG_FULL_DUPLEX); | 2352 | MVNETA_GMAC_CONFIG_FULL_DUPLEX | |
2353 | MVNETA_GMAC_AN_SPEED_EN | | ||
2354 | MVNETA_GMAC_AN_DUPLEX_EN); | ||
2344 | 2355 | ||
2345 | if (phydev->duplex) | 2356 | if (phydev->duplex) |
2346 | val |= MVNETA_GMAC_CONFIG_FULL_DUPLEX; | 2357 | val |= MVNETA_GMAC_CONFIG_FULL_DUPLEX; |
@@ -2473,6 +2484,21 @@ static int mvneta_stop(struct net_device *dev) | |||
2473 | return 0; | 2484 | return 0; |
2474 | } | 2485 | } |
2475 | 2486 | ||
2487 | static int mvneta_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) | ||
2488 | { | ||
2489 | struct mvneta_port *pp = netdev_priv(dev); | ||
2490 | int ret; | ||
2491 | |||
2492 | if (!pp->phy_dev) | ||
2493 | return -ENOTSUPP; | ||
2494 | |||
2495 | ret = phy_mii_ioctl(pp->phy_dev, ifr, cmd); | ||
2496 | if (!ret) | ||
2497 | mvneta_adjust_link(dev); | ||
2498 | |||
2499 | return ret; | ||
2500 | } | ||
2501 | |||
2476 | /* Ethtool methods */ | 2502 | /* Ethtool methods */ |
2477 | 2503 | ||
2478 | /* Get settings (phy address, speed) for ethtools */ | 2504 | /* Get settings (phy address, speed) for ethtools */ |
@@ -2591,6 +2617,7 @@ static const struct net_device_ops mvneta_netdev_ops = { | |||
2591 | .ndo_change_mtu = mvneta_change_mtu, | 2617 | .ndo_change_mtu = mvneta_change_mtu, |
2592 | .ndo_tx_timeout = mvneta_tx_timeout, | 2618 | .ndo_tx_timeout = mvneta_tx_timeout, |
2593 | .ndo_get_stats64 = mvneta_get_stats64, | 2619 | .ndo_get_stats64 = mvneta_get_stats64, |
2620 | .ndo_do_ioctl = mvneta_ioctl, | ||
2594 | }; | 2621 | }; |
2595 | 2622 | ||
2596 | const struct ethtool_ops mvneta_eth_tool_ops = { | 2623 | const struct ethtool_ops mvneta_eth_tool_ops = { |
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic.h b/drivers/net/ethernet/qlogic/netxen/netxen_nic.h index 3fe09ab2d7c9..32675e16021e 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic.h +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic.h | |||
@@ -1171,7 +1171,6 @@ typedef struct { | |||
1171 | 1171 | ||
1172 | #define NETXEN_DB_MAPSIZE_BYTES 0x1000 | 1172 | #define NETXEN_DB_MAPSIZE_BYTES 0x1000 |
1173 | 1173 | ||
1174 | #define NETXEN_NETDEV_WEIGHT 128 | ||
1175 | #define NETXEN_ADAPTER_UP_MAGIC 777 | 1174 | #define NETXEN_ADAPTER_UP_MAGIC 777 |
1176 | #define NETXEN_NIC_PEG_TUNE 0 | 1175 | #define NETXEN_NIC_PEG_TUNE 0 |
1177 | 1176 | ||
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c index 1046e9461509..cbd75f97ffb3 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | |||
@@ -197,7 +197,7 @@ netxen_napi_add(struct netxen_adapter *adapter, struct net_device *netdev) | |||
197 | for (ring = 0; ring < adapter->max_sds_rings; ring++) { | 197 | for (ring = 0; ring < adapter->max_sds_rings; ring++) { |
198 | sds_ring = &recv_ctx->sds_rings[ring]; | 198 | sds_ring = &recv_ctx->sds_rings[ring]; |
199 | netif_napi_add(netdev, &sds_ring->napi, | 199 | netif_napi_add(netdev, &sds_ring->napi, |
200 | netxen_nic_poll, NETXEN_NETDEV_WEIGHT); | 200 | netxen_nic_poll, NAPI_POLL_WEIGHT); |
201 | } | 201 | } |
202 | 202 | ||
203 | return 0; | 203 | return 0; |
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 474c8a86a2af..5cd831ebfa83 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c | |||
@@ -1348,7 +1348,7 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status, int *quota) | |||
1348 | DMA_FROM_DEVICE); | 1348 | DMA_FROM_DEVICE); |
1349 | skb_put(skb, pkt_len); | 1349 | skb_put(skb, pkt_len); |
1350 | skb->protocol = eth_type_trans(skb, ndev); | 1350 | skb->protocol = eth_type_trans(skb, ndev); |
1351 | netif_rx(skb); | 1351 | netif_receive_skb(skb); |
1352 | ndev->stats.rx_packets++; | 1352 | ndev->stats.rx_packets++; |
1353 | ndev->stats.rx_bytes += pkt_len; | 1353 | ndev->stats.rx_bytes += pkt_len; |
1354 | } | 1354 | } |
@@ -1906,11 +1906,13 @@ static int sh_eth_open(struct net_device *ndev) | |||
1906 | 1906 | ||
1907 | pm_runtime_get_sync(&mdp->pdev->dev); | 1907 | pm_runtime_get_sync(&mdp->pdev->dev); |
1908 | 1908 | ||
1909 | napi_enable(&mdp->napi); | ||
1910 | |||
1909 | ret = request_irq(ndev->irq, sh_eth_interrupt, | 1911 | ret = request_irq(ndev->irq, sh_eth_interrupt, |
1910 | mdp->cd->irq_flags, ndev->name, ndev); | 1912 | mdp->cd->irq_flags, ndev->name, ndev); |
1911 | if (ret) { | 1913 | if (ret) { |
1912 | dev_err(&ndev->dev, "Can not assign IRQ number\n"); | 1914 | dev_err(&ndev->dev, "Can not assign IRQ number\n"); |
1913 | return ret; | 1915 | goto out_napi_off; |
1914 | } | 1916 | } |
1915 | 1917 | ||
1916 | /* Descriptor set */ | 1918 | /* Descriptor set */ |
@@ -1928,12 +1930,12 @@ static int sh_eth_open(struct net_device *ndev) | |||
1928 | if (ret) | 1930 | if (ret) |
1929 | goto out_free_irq; | 1931 | goto out_free_irq; |
1930 | 1932 | ||
1931 | napi_enable(&mdp->napi); | ||
1932 | |||
1933 | return ret; | 1933 | return ret; |
1934 | 1934 | ||
1935 | out_free_irq: | 1935 | out_free_irq: |
1936 | free_irq(ndev->irq, ndev); | 1936 | free_irq(ndev->irq, ndev); |
1937 | out_napi_off: | ||
1938 | napi_disable(&mdp->napi); | ||
1937 | pm_runtime_put_sync(&mdp->pdev->dev); | 1939 | pm_runtime_put_sync(&mdp->pdev->dev); |
1938 | return ret; | 1940 | return ret; |
1939 | } | 1941 | } |
@@ -2025,8 +2027,6 @@ static int sh_eth_close(struct net_device *ndev) | |||
2025 | { | 2027 | { |
2026 | struct sh_eth_private *mdp = netdev_priv(ndev); | 2028 | struct sh_eth_private *mdp = netdev_priv(ndev); |
2027 | 2029 | ||
2028 | napi_disable(&mdp->napi); | ||
2029 | |||
2030 | netif_stop_queue(ndev); | 2030 | netif_stop_queue(ndev); |
2031 | 2031 | ||
2032 | /* Disable interrupts by clearing the interrupt mask. */ | 2032 | /* Disable interrupts by clearing the interrupt mask. */ |
@@ -2044,6 +2044,8 @@ static int sh_eth_close(struct net_device *ndev) | |||
2044 | 2044 | ||
2045 | free_irq(ndev->irq, ndev); | 2045 | free_irq(ndev->irq, ndev); |
2046 | 2046 | ||
2047 | napi_disable(&mdp->napi); | ||
2048 | |||
2047 | /* Free all the skbuffs in the Rx queue. */ | 2049 | /* Free all the skbuffs in the Rx queue. */ |
2048 | sh_eth_ring_free(ndev); | 2050 | sh_eth_ring_free(ndev); |
2049 | 2051 | ||
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 623ebc50fe6b..7a0072003f34 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | |||
@@ -71,19 +71,22 @@ static int stmmac_probe_config_dt(struct platform_device *pdev, | |||
71 | plat->force_sf_dma_mode = 1; | 71 | plat->force_sf_dma_mode = 1; |
72 | } | 72 | } |
73 | 73 | ||
74 | dma_cfg = devm_kzalloc(&pdev->dev, sizeof(*dma_cfg), GFP_KERNEL); | 74 | if (of_find_property(np, "snps,pbl", NULL)) { |
75 | if (!dma_cfg) | 75 | dma_cfg = devm_kzalloc(&pdev->dev, sizeof(*dma_cfg), |
76 | return -ENOMEM; | 76 | GFP_KERNEL); |
77 | 77 | if (!dma_cfg) | |
78 | plat->dma_cfg = dma_cfg; | 78 | return -ENOMEM; |
79 | of_property_read_u32(np, "snps,pbl", &dma_cfg->pbl); | 79 | plat->dma_cfg = dma_cfg; |
80 | dma_cfg->fixed_burst = of_property_read_bool(np, "snps,fixed-burst"); | 80 | of_property_read_u32(np, "snps,pbl", &dma_cfg->pbl); |
81 | dma_cfg->mixed_burst = of_property_read_bool(np, "snps,mixed-burst"); | 81 | dma_cfg->fixed_burst = |
82 | of_property_read_bool(np, "snps,fixed-burst"); | ||
83 | dma_cfg->mixed_burst = | ||
84 | of_property_read_bool(np, "snps,mixed-burst"); | ||
85 | } | ||
82 | plat->force_thresh_dma_mode = of_property_read_bool(np, "snps,force_thresh_dma_mode"); | 86 | plat->force_thresh_dma_mode = of_property_read_bool(np, "snps,force_thresh_dma_mode"); |
83 | if (plat->force_thresh_dma_mode) { | 87 | if (plat->force_thresh_dma_mode) { |
84 | plat->force_sf_dma_mode = 0; | 88 | plat->force_sf_dma_mode = 0; |
85 | pr_warn("force_sf_dma_mode is ignored if force_thresh_dma_mode is set."); | 89 | pr_warn("force_sf_dma_mode is ignored if force_thresh_dma_mode is set."); |
86 | } | ||
87 | 90 | ||
88 | return 0; | 91 | return 0; |
89 | } | 92 | } |
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c index ad32af67e618..9c805e0c0cae 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c | |||
@@ -1466,8 +1466,7 @@ static void gelic_ether_setup_netdev_ops(struct net_device *netdev, | |||
1466 | { | 1466 | { |
1467 | netdev->watchdog_timeo = GELIC_NET_WATCHDOG_TIMEOUT; | 1467 | netdev->watchdog_timeo = GELIC_NET_WATCHDOG_TIMEOUT; |
1468 | /* NAPI */ | 1468 | /* NAPI */ |
1469 | netif_napi_add(netdev, napi, | 1469 | netif_napi_add(netdev, napi, gelic_net_poll, NAPI_POLL_WEIGHT); |
1470 | gelic_net_poll, GELIC_NET_NAPI_WEIGHT); | ||
1471 | netdev->ethtool_ops = &gelic_ether_ethtool_ops; | 1470 | netdev->ethtool_ops = &gelic_ether_ethtool_ops; |
1472 | netdev->netdev_ops = &gelic_netdevice_ops; | 1471 | netdev->netdev_ops = &gelic_netdevice_ops; |
1473 | } | 1472 | } |
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.h b/drivers/net/ethernet/toshiba/ps3_gelic_net.h index a93df6ac1909..309abb472aa2 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.h +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.h | |||
@@ -37,7 +37,6 @@ | |||
37 | #define GELIC_NET_RXBUF_ALIGN 128 | 37 | #define GELIC_NET_RXBUF_ALIGN 128 |
38 | #define GELIC_CARD_RX_CSUM_DEFAULT 1 /* hw chksum */ | 38 | #define GELIC_CARD_RX_CSUM_DEFAULT 1 /* hw chksum */ |
39 | #define GELIC_NET_WATCHDOG_TIMEOUT 5*HZ | 39 | #define GELIC_NET_WATCHDOG_TIMEOUT 5*HZ |
40 | #define GELIC_NET_NAPI_WEIGHT (GELIC_NET_RX_DESCRIPTORS) | ||
41 | #define GELIC_NET_BROADCAST_ADDR 0xffffffffffffL | 40 | #define GELIC_NET_BROADCAST_ADDR 0xffffffffffffL |
42 | 41 | ||
43 | #define GELIC_NET_MC_COUNT_MAX 32 /* multicast address list */ | 42 | #define GELIC_NET_MC_COUNT_MAX 32 /* multicast address list */ |
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c index e90e1f46121e..64b4639f43b6 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | |||
@@ -175,6 +175,7 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np) | |||
175 | printk(KERN_WARNING "Setting MDIO clock divisor to " | 175 | printk(KERN_WARNING "Setting MDIO clock divisor to " |
176 | "default %d\n", DEFAULT_CLOCK_DIVISOR); | 176 | "default %d\n", DEFAULT_CLOCK_DIVISOR); |
177 | clk_div = DEFAULT_CLOCK_DIVISOR; | 177 | clk_div = DEFAULT_CLOCK_DIVISOR; |
178 | of_node_put(np1); | ||
178 | goto issue; | 179 | goto issue; |
179 | } | 180 | } |
180 | 181 | ||
diff --git a/drivers/net/usb/cdc_mbim.c b/drivers/net/usb/cdc_mbim.c index 872819851aef..25ba7eca9a13 100644 --- a/drivers/net/usb/cdc_mbim.c +++ b/drivers/net/usb/cdc_mbim.c | |||
@@ -400,6 +400,10 @@ static const struct usb_device_id mbim_devs[] = { | |||
400 | { USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68a2, USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE), | 400 | { USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68a2, USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE), |
401 | .driver_info = (unsigned long)&cdc_mbim_info_zlp, | 401 | .driver_info = (unsigned long)&cdc_mbim_info_zlp, |
402 | }, | 402 | }, |
403 | /* HP hs2434 Mobile Broadband Module needs ZLPs */ | ||
404 | { USB_DEVICE_AND_INTERFACE_INFO(0x3f0, 0x4b1d, USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE), | ||
405 | .driver_info = (unsigned long)&cdc_mbim_info_zlp, | ||
406 | }, | ||
403 | { USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE), | 407 | { USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MBIM, USB_CDC_PROTO_NONE), |
404 | .driver_info = (unsigned long)&cdc_mbim_info, | 408 | .driver_info = (unsigned long)&cdc_mbim_info, |
405 | }, | 409 | }, |
diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c index 1d4c8fe72752..c82fe65c4128 100644 --- a/drivers/s390/scsi/zfcp_erp.c +++ b/drivers/s390/scsi/zfcp_erp.c | |||
@@ -102,10 +102,13 @@ static void zfcp_erp_action_dismiss_port(struct zfcp_port *port) | |||
102 | 102 | ||
103 | if (atomic_read(&port->status) & ZFCP_STATUS_COMMON_ERP_INUSE) | 103 | if (atomic_read(&port->status) & ZFCP_STATUS_COMMON_ERP_INUSE) |
104 | zfcp_erp_action_dismiss(&port->erp_action); | 104 | zfcp_erp_action_dismiss(&port->erp_action); |
105 | else | 105 | else { |
106 | shost_for_each_device(sdev, port->adapter->scsi_host) | 106 | spin_lock(port->adapter->scsi_host->host_lock); |
107 | __shost_for_each_device(sdev, port->adapter->scsi_host) | ||
107 | if (sdev_to_zfcp(sdev)->port == port) | 108 | if (sdev_to_zfcp(sdev)->port == port) |
108 | zfcp_erp_action_dismiss_lun(sdev); | 109 | zfcp_erp_action_dismiss_lun(sdev); |
110 | spin_unlock(port->adapter->scsi_host->host_lock); | ||
111 | } | ||
109 | } | 112 | } |
110 | 113 | ||
111 | static void zfcp_erp_action_dismiss_adapter(struct zfcp_adapter *adapter) | 114 | static void zfcp_erp_action_dismiss_adapter(struct zfcp_adapter *adapter) |
@@ -592,9 +595,11 @@ static void _zfcp_erp_lun_reopen_all(struct zfcp_port *port, int clear, | |||
592 | { | 595 | { |
593 | struct scsi_device *sdev; | 596 | struct scsi_device *sdev; |
594 | 597 | ||
595 | shost_for_each_device(sdev, port->adapter->scsi_host) | 598 | spin_lock(port->adapter->scsi_host->host_lock); |
599 | __shost_for_each_device(sdev, port->adapter->scsi_host) | ||
596 | if (sdev_to_zfcp(sdev)->port == port) | 600 | if (sdev_to_zfcp(sdev)->port == port) |
597 | _zfcp_erp_lun_reopen(sdev, clear, id, 0); | 601 | _zfcp_erp_lun_reopen(sdev, clear, id, 0); |
602 | spin_unlock(port->adapter->scsi_host->host_lock); | ||
598 | } | 603 | } |
599 | 604 | ||
600 | static void zfcp_erp_strategy_followup_failed(struct zfcp_erp_action *act) | 605 | static void zfcp_erp_strategy_followup_failed(struct zfcp_erp_action *act) |
@@ -1434,8 +1439,10 @@ void zfcp_erp_set_adapter_status(struct zfcp_adapter *adapter, u32 mask) | |||
1434 | atomic_set_mask(common_mask, &port->status); | 1439 | atomic_set_mask(common_mask, &port->status); |
1435 | read_unlock_irqrestore(&adapter->port_list_lock, flags); | 1440 | read_unlock_irqrestore(&adapter->port_list_lock, flags); |
1436 | 1441 | ||
1437 | shost_for_each_device(sdev, adapter->scsi_host) | 1442 | spin_lock_irqsave(adapter->scsi_host->host_lock, flags); |
1443 | __shost_for_each_device(sdev, adapter->scsi_host) | ||
1438 | atomic_set_mask(common_mask, &sdev_to_zfcp(sdev)->status); | 1444 | atomic_set_mask(common_mask, &sdev_to_zfcp(sdev)->status); |
1445 | spin_unlock_irqrestore(adapter->scsi_host->host_lock, flags); | ||
1439 | } | 1446 | } |
1440 | 1447 | ||
1441 | /** | 1448 | /** |
@@ -1469,11 +1476,13 @@ void zfcp_erp_clear_adapter_status(struct zfcp_adapter *adapter, u32 mask) | |||
1469 | } | 1476 | } |
1470 | read_unlock_irqrestore(&adapter->port_list_lock, flags); | 1477 | read_unlock_irqrestore(&adapter->port_list_lock, flags); |
1471 | 1478 | ||
1472 | shost_for_each_device(sdev, adapter->scsi_host) { | 1479 | spin_lock_irqsave(adapter->scsi_host->host_lock, flags); |
1480 | __shost_for_each_device(sdev, adapter->scsi_host) { | ||
1473 | atomic_clear_mask(common_mask, &sdev_to_zfcp(sdev)->status); | 1481 | atomic_clear_mask(common_mask, &sdev_to_zfcp(sdev)->status); |
1474 | if (clear_counter) | 1482 | if (clear_counter) |
1475 | atomic_set(&sdev_to_zfcp(sdev)->erp_counter, 0); | 1483 | atomic_set(&sdev_to_zfcp(sdev)->erp_counter, 0); |
1476 | } | 1484 | } |
1485 | spin_unlock_irqrestore(adapter->scsi_host->host_lock, flags); | ||
1477 | } | 1486 | } |
1478 | 1487 | ||
1479 | /** | 1488 | /** |
@@ -1487,16 +1496,19 @@ void zfcp_erp_set_port_status(struct zfcp_port *port, u32 mask) | |||
1487 | { | 1496 | { |
1488 | struct scsi_device *sdev; | 1497 | struct scsi_device *sdev; |
1489 | u32 common_mask = mask & ZFCP_COMMON_FLAGS; | 1498 | u32 common_mask = mask & ZFCP_COMMON_FLAGS; |
1499 | unsigned long flags; | ||
1490 | 1500 | ||
1491 | atomic_set_mask(mask, &port->status); | 1501 | atomic_set_mask(mask, &port->status); |
1492 | 1502 | ||
1493 | if (!common_mask) | 1503 | if (!common_mask) |
1494 | return; | 1504 | return; |
1495 | 1505 | ||
1496 | shost_for_each_device(sdev, port->adapter->scsi_host) | 1506 | spin_lock_irqsave(port->adapter->scsi_host->host_lock, flags); |
1507 | __shost_for_each_device(sdev, port->adapter->scsi_host) | ||
1497 | if (sdev_to_zfcp(sdev)->port == port) | 1508 | if (sdev_to_zfcp(sdev)->port == port) |
1498 | atomic_set_mask(common_mask, | 1509 | atomic_set_mask(common_mask, |
1499 | &sdev_to_zfcp(sdev)->status); | 1510 | &sdev_to_zfcp(sdev)->status); |
1511 | spin_unlock_irqrestore(port->adapter->scsi_host->host_lock, flags); | ||
1500 | } | 1512 | } |
1501 | 1513 | ||
1502 | /** | 1514 | /** |
@@ -1511,6 +1523,7 @@ void zfcp_erp_clear_port_status(struct zfcp_port *port, u32 mask) | |||
1511 | struct scsi_device *sdev; | 1523 | struct scsi_device *sdev; |
1512 | u32 common_mask = mask & ZFCP_COMMON_FLAGS; | 1524 | u32 common_mask = mask & ZFCP_COMMON_FLAGS; |
1513 | u32 clear_counter = mask & ZFCP_STATUS_COMMON_ERP_FAILED; | 1525 | u32 clear_counter = mask & ZFCP_STATUS_COMMON_ERP_FAILED; |
1526 | unsigned long flags; | ||
1514 | 1527 | ||
1515 | atomic_clear_mask(mask, &port->status); | 1528 | atomic_clear_mask(mask, &port->status); |
1516 | 1529 | ||
@@ -1520,13 +1533,15 @@ void zfcp_erp_clear_port_status(struct zfcp_port *port, u32 mask) | |||
1520 | if (clear_counter) | 1533 | if (clear_counter) |
1521 | atomic_set(&port->erp_counter, 0); | 1534 | atomic_set(&port->erp_counter, 0); |
1522 | 1535 | ||
1523 | shost_for_each_device(sdev, port->adapter->scsi_host) | 1536 | spin_lock_irqsave(port->adapter->scsi_host->host_lock, flags); |
1537 | __shost_for_each_device(sdev, port->adapter->scsi_host) | ||
1524 | if (sdev_to_zfcp(sdev)->port == port) { | 1538 | if (sdev_to_zfcp(sdev)->port == port) { |
1525 | atomic_clear_mask(common_mask, | 1539 | atomic_clear_mask(common_mask, |
1526 | &sdev_to_zfcp(sdev)->status); | 1540 | &sdev_to_zfcp(sdev)->status); |
1527 | if (clear_counter) | 1541 | if (clear_counter) |
1528 | atomic_set(&sdev_to_zfcp(sdev)->erp_counter, 0); | 1542 | atomic_set(&sdev_to_zfcp(sdev)->erp_counter, 0); |
1529 | } | 1543 | } |
1544 | spin_unlock_irqrestore(port->adapter->scsi_host->host_lock, flags); | ||
1530 | } | 1545 | } |
1531 | 1546 | ||
1532 | /** | 1547 | /** |
diff --git a/drivers/s390/scsi/zfcp_qdio.c b/drivers/s390/scsi/zfcp_qdio.c index 665e3cfaaf85..de0598eaacd2 100644 --- a/drivers/s390/scsi/zfcp_qdio.c +++ b/drivers/s390/scsi/zfcp_qdio.c | |||
@@ -224,11 +224,9 @@ int zfcp_qdio_sbals_from_sg(struct zfcp_qdio *qdio, struct zfcp_qdio_req *q_req, | |||
224 | 224 | ||
225 | static int zfcp_qdio_sbal_check(struct zfcp_qdio *qdio) | 225 | static int zfcp_qdio_sbal_check(struct zfcp_qdio *qdio) |
226 | { | 226 | { |
227 | spin_lock_irq(&qdio->req_q_lock); | ||
228 | if (atomic_read(&qdio->req_q_free) || | 227 | if (atomic_read(&qdio->req_q_free) || |
229 | !(atomic_read(&qdio->adapter->status) & ZFCP_STATUS_ADAPTER_QDIOUP)) | 228 | !(atomic_read(&qdio->adapter->status) & ZFCP_STATUS_ADAPTER_QDIOUP)) |
230 | return 1; | 229 | return 1; |
231 | spin_unlock_irq(&qdio->req_q_lock); | ||
232 | return 0; | 230 | return 0; |
233 | } | 231 | } |
234 | 232 | ||
@@ -246,9 +244,8 @@ int zfcp_qdio_sbal_get(struct zfcp_qdio *qdio) | |||
246 | { | 244 | { |
247 | long ret; | 245 | long ret; |
248 | 246 | ||
249 | spin_unlock_irq(&qdio->req_q_lock); | 247 | ret = wait_event_interruptible_lock_irq_timeout(qdio->req_q_wq, |
250 | ret = wait_event_interruptible_timeout(qdio->req_q_wq, | 248 | zfcp_qdio_sbal_check(qdio), qdio->req_q_lock, 5 * HZ); |
251 | zfcp_qdio_sbal_check(qdio), 5 * HZ); | ||
252 | 249 | ||
253 | if (!(atomic_read(&qdio->adapter->status) & ZFCP_STATUS_ADAPTER_QDIOUP)) | 250 | if (!(atomic_read(&qdio->adapter->status) & ZFCP_STATUS_ADAPTER_QDIOUP)) |
254 | return -EIO; | 251 | return -EIO; |
@@ -262,7 +259,6 @@ int zfcp_qdio_sbal_get(struct zfcp_qdio *qdio) | |||
262 | zfcp_erp_adapter_reopen(qdio->adapter, 0, "qdsbg_1"); | 259 | zfcp_erp_adapter_reopen(qdio->adapter, 0, "qdsbg_1"); |
263 | } | 260 | } |
264 | 261 | ||
265 | spin_lock_irq(&qdio->req_q_lock); | ||
266 | return -EIO; | 262 | return -EIO; |
267 | } | 263 | } |
268 | 264 | ||
diff --git a/drivers/s390/scsi/zfcp_sysfs.c b/drivers/s390/scsi/zfcp_sysfs.c index 3f01bbf0609f..890639274bcf 100644 --- a/drivers/s390/scsi/zfcp_sysfs.c +++ b/drivers/s390/scsi/zfcp_sysfs.c | |||
@@ -27,6 +27,16 @@ static ssize_t zfcp_sysfs_##_feat##_##_name##_show(struct device *dev, \ | |||
27 | static ZFCP_DEV_ATTR(_feat, _name, S_IRUGO, \ | 27 | static ZFCP_DEV_ATTR(_feat, _name, S_IRUGO, \ |
28 | zfcp_sysfs_##_feat##_##_name##_show, NULL); | 28 | zfcp_sysfs_##_feat##_##_name##_show, NULL); |
29 | 29 | ||
30 | #define ZFCP_DEFINE_ATTR_CONST(_feat, _name, _format, _value) \ | ||
31 | static ssize_t zfcp_sysfs_##_feat##_##_name##_show(struct device *dev, \ | ||
32 | struct device_attribute *at,\ | ||
33 | char *buf) \ | ||
34 | { \ | ||
35 | return sprintf(buf, _format, _value); \ | ||
36 | } \ | ||
37 | static ZFCP_DEV_ATTR(_feat, _name, S_IRUGO, \ | ||
38 | zfcp_sysfs_##_feat##_##_name##_show, NULL); | ||
39 | |||
30 | #define ZFCP_DEFINE_A_ATTR(_name, _format, _value) \ | 40 | #define ZFCP_DEFINE_A_ATTR(_name, _format, _value) \ |
31 | static ssize_t zfcp_sysfs_adapter_##_name##_show(struct device *dev, \ | 41 | static ssize_t zfcp_sysfs_adapter_##_name##_show(struct device *dev, \ |
32 | struct device_attribute *at,\ | 42 | struct device_attribute *at,\ |
@@ -75,6 +85,8 @@ ZFCP_DEFINE_ATTR(zfcp_unit, unit, in_recovery, "%d\n", | |||
75 | ZFCP_DEFINE_ATTR(zfcp_unit, unit, access_denied, "%d\n", | 85 | ZFCP_DEFINE_ATTR(zfcp_unit, unit, access_denied, "%d\n", |
76 | (zfcp_unit_sdev_status(unit) & | 86 | (zfcp_unit_sdev_status(unit) & |
77 | ZFCP_STATUS_COMMON_ACCESS_DENIED) != 0); | 87 | ZFCP_STATUS_COMMON_ACCESS_DENIED) != 0); |
88 | ZFCP_DEFINE_ATTR_CONST(unit, access_shared, "%d\n", 0); | ||
89 | ZFCP_DEFINE_ATTR_CONST(unit, access_readonly, "%d\n", 0); | ||
78 | 90 | ||
79 | static ssize_t zfcp_sysfs_port_failed_show(struct device *dev, | 91 | static ssize_t zfcp_sysfs_port_failed_show(struct device *dev, |
80 | struct device_attribute *attr, | 92 | struct device_attribute *attr, |
@@ -347,6 +359,8 @@ static struct attribute *zfcp_unit_attrs[] = { | |||
347 | &dev_attr_unit_in_recovery.attr, | 359 | &dev_attr_unit_in_recovery.attr, |
348 | &dev_attr_unit_status.attr, | 360 | &dev_attr_unit_status.attr, |
349 | &dev_attr_unit_access_denied.attr, | 361 | &dev_attr_unit_access_denied.attr, |
362 | &dev_attr_unit_access_shared.attr, | ||
363 | &dev_attr_unit_access_readonly.attr, | ||
350 | NULL | 364 | NULL |
351 | }; | 365 | }; |
352 | static struct attribute_group zfcp_unit_attr_group = { | 366 | static struct attribute_group zfcp_unit_attr_group = { |
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 48b2918e0d65..92ff027746f2 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig | |||
@@ -1353,7 +1353,6 @@ config SCSI_LPFC | |||
1353 | tristate "Emulex LightPulse Fibre Channel Support" | 1353 | tristate "Emulex LightPulse Fibre Channel Support" |
1354 | depends on PCI && SCSI | 1354 | depends on PCI && SCSI |
1355 | select SCSI_FC_ATTRS | 1355 | select SCSI_FC_ATTRS |
1356 | select GENERIC_CSUM | ||
1357 | select CRC_T10DIF | 1356 | select CRC_T10DIF |
1358 | help | 1357 | help |
1359 | This lpfc driver supports the Emulex LightPulse | 1358 | This lpfc driver supports the Emulex LightPulse |
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c index e25eba5713c1..b3b5125faa72 100644 --- a/drivers/staging/comedi/drivers.c +++ b/drivers/staging/comedi/drivers.c | |||
@@ -482,7 +482,7 @@ int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it) | |||
482 | ret = comedi_device_postconfig(dev); | 482 | ret = comedi_device_postconfig(dev); |
483 | if (ret < 0) { | 483 | if (ret < 0) { |
484 | comedi_device_detach(dev); | 484 | comedi_device_detach(dev); |
485 | module_put(dev->driver->module); | 485 | module_put(driv->module); |
486 | } | 486 | } |
487 | /* On success, the driver module count has been incremented. */ | 487 | /* On success, the driver module count has been incremented. */ |
488 | return ret; | 488 | return ret; |
diff --git a/drivers/tty/hvc/hvsi_lib.c b/drivers/tty/hvc/hvsi_lib.c index 3396eb9d57a3..ac2767100df5 100644 --- a/drivers/tty/hvc/hvsi_lib.c +++ b/drivers/tty/hvc/hvsi_lib.c | |||
@@ -341,8 +341,8 @@ void hvsilib_establish(struct hvsi_priv *pv) | |||
341 | 341 | ||
342 | pr_devel("HVSI@%x: ... waiting handshake\n", pv->termno); | 342 | pr_devel("HVSI@%x: ... waiting handshake\n", pv->termno); |
343 | 343 | ||
344 | /* Try for up to 200s */ | 344 | /* Try for up to 400ms */ |
345 | for (timeout = 0; timeout < 20; timeout++) { | 345 | for (timeout = 0; timeout < 40; timeout++) { |
346 | if (pv->established) | 346 | if (pv->established) |
347 | goto established; | 347 | goto established; |
348 | if (!hvsi_get_packet(pv)) | 348 | if (!hvsi_get_packet(pv)) |
diff --git a/drivers/usb/host/ohci-pci.c b/drivers/usb/host/ohci-pci.c index 08613e241894..279b04910f00 100644 --- a/drivers/usb/host/ohci-pci.c +++ b/drivers/usb/host/ohci-pci.c | |||
@@ -304,6 +304,13 @@ static int __init ohci_pci_init(void) | |||
304 | pr_info("%s: " DRIVER_DESC "\n", hcd_name); | 304 | pr_info("%s: " DRIVER_DESC "\n", hcd_name); |
305 | 305 | ||
306 | ohci_init_driver(&ohci_pci_hc_driver, &pci_overrides); | 306 | ohci_init_driver(&ohci_pci_hc_driver, &pci_overrides); |
307 | |||
308 | #ifdef CONFIG_PM | ||
309 | /* Entries for the PCI suspend/resume callbacks are special */ | ||
310 | ohci_pci_hc_driver.pci_suspend = ohci_suspend; | ||
311 | ohci_pci_hc_driver.pci_resume = ohci_resume; | ||
312 | #endif | ||
313 | |||
307 | return pci_register_driver(&ohci_pci_driver); | 314 | return pci_register_driver(&ohci_pci_driver); |
308 | } | 315 | } |
309 | module_init(ohci_pci_init); | 316 | module_init(ohci_pci_init); |
diff --git a/drivers/usb/phy/phy-fsl-usb.h b/drivers/usb/phy/phy-fsl-usb.h index ca266280895d..e1859b8ef567 100644 --- a/drivers/usb/phy/phy-fsl-usb.h +++ b/drivers/usb/phy/phy-fsl-usb.h | |||
@@ -15,7 +15,7 @@ | |||
15 | * 675 Mass Ave, Cambridge, MA 02139, USA. | 15 | * 675 Mass Ave, Cambridge, MA 02139, USA. |
16 | */ | 16 | */ |
17 | 17 | ||
18 | #include "otg_fsm.h" | 18 | #include "phy-fsm-usb.h" |
19 | #include <linux/usb/otg.h> | 19 | #include <linux/usb/otg.h> |
20 | #include <linux/ioctl.h> | 20 | #include <linux/ioctl.h> |
21 | 21 | ||
diff --git a/drivers/usb/phy/phy-fsm-usb.c b/drivers/usb/phy/phy-fsm-usb.c index c520b3548e7c..7f4596606e18 100644 --- a/drivers/usb/phy/phy-fsm-usb.c +++ b/drivers/usb/phy/phy-fsm-usb.c | |||
@@ -29,7 +29,7 @@ | |||
29 | #include <linux/usb/gadget.h> | 29 | #include <linux/usb/gadget.h> |
30 | #include <linux/usb/otg.h> | 30 | #include <linux/usb/otg.h> |
31 | 31 | ||
32 | #include "phy-otg-fsm.h" | 32 | #include "phy-fsm-usb.h" |
33 | 33 | ||
34 | /* Change USB protocol when there is a protocol change */ | 34 | /* Change USB protocol when there is a protocol change */ |
35 | static int otg_set_protocol(struct otg_fsm *fsm, int protocol) | 35 | static int otg_set_protocol(struct otg_fsm *fsm, int protocol) |