1 files changed, 106 insertions, 74 deletions

diff --git a/drivers/video/omap2/dss/dpi.c b/drivers/video/omap2/dss/dpi.c
index 960e977a8bf0..ff6bd30132df 100644
--- a/drivers/video/omap2/dss/dpi.c
+++ b/drivers/video/omap2/dss/dpi.c
@@ -30,47 +30,73 @@
 #include <linux/platform_device.h>
 #include <linux/regulator/consumer.h>
 
-#include <plat/display.h>
+#include <video/omapdss.h>
 #include <plat/cpu.h>
 
 #include "dss.h"
 
 static struct {
         struct regulator *vdds_dsi_reg;
+        struct platform_device *dsidev;
 } dpi;
 
-#ifdef CONFIG_OMAP2_DSS_USE_DSI_PLL
-static int dpi_set_dsi_clk(bool is_tft, unsigned long pck_req,
-                unsigned long *fck, int *lck_div, int *pck_div)
+static struct platform_device *dpi_get_dsidev(enum omap_dss_clk_source clk)
+{
+        int dsi_module;
+
+        dsi_module = clk == OMAP_DSS_CLK_SRC_DSI_PLL_HSDIV_DISPC ? 0 : 1;
+
+        return dsi_get_dsidev_from_id(dsi_module);
+}
+
+static bool dpi_use_dsi_pll(struct omap_dss_device *dssdev)
+{
+        if (dssdev->clocks.dispc.dispc_fclk_src ==
+                        OMAP_DSS_CLK_SRC_DSI_PLL_HSDIV_DISPC ||
+                        dssdev->clocks.dispc.dispc_fclk_src ==
+                        OMAP_DSS_CLK_SRC_DSI2_PLL_HSDIV_DISPC ||
+                        dssdev->clocks.dispc.channel.lcd_clk_src ==
+                        OMAP_DSS_CLK_SRC_DSI_PLL_HSDIV_DISPC ||
+                        dssdev->clocks.dispc.channel.lcd_clk_src ==
+                        OMAP_DSS_CLK_SRC_DSI2_PLL_HSDIV_DISPC)
+                return true;
+        else
+                return false;
+}
+
+static int dpi_set_dsi_clk(struct omap_dss_device *dssdev, bool is_tft,
+                unsigned long pck_req, unsigned long *fck, int *lck_div,
+                int *pck_div)
 {
         struct dsi_clock_info dsi_cinfo;
         struct dispc_clock_info dispc_cinfo;
         int r;
 
-        r = dsi_pll_calc_clock_div_pck(is_tft, pck_req, &dsi_cinfo,
-                        &dispc_cinfo);
+        r = dsi_pll_calc_clock_div_pck(dpi.dsidev, is_tft, pck_req,
+                        &dsi_cinfo, &dispc_cinfo);
         if (r)
                 return r;
 
-        r = dsi_pll_set_clock_div(&dsi_cinfo);
+        r = dsi_pll_set_clock_div(dpi.dsidev, &dsi_cinfo);
         if (r)
                 return r;
 
-        dss_select_dispc_clk_source(DSS_SRC_DSI1_PLL_FCLK);
+        dss_select_dispc_clk_source(dssdev->clocks.dispc.dispc_fclk_src);
 
-        r = dispc_set_clock_div(&dispc_cinfo);
+        r = dispc_set_clock_div(dssdev->manager->id, &dispc_cinfo);
         if (r)
                 return r;
 
-        *fck = dsi_cinfo.dsi1_pll_fclk;
+        *fck = dsi_cinfo.dsi_pll_hsdiv_dispc_clk;
         *lck_div = dispc_cinfo.lck_div;
         *pck_div = dispc_cinfo.pck_div;
 
         return 0;
 }
-#else
-static int dpi_set_dispc_clk(bool is_tft, unsigned long pck_req,
-                unsigned long *fck, int *lck_div, int *pck_div)
+
+static int dpi_set_dispc_clk(struct omap_dss_device *dssdev, bool is_tft,
+                unsigned long pck_req, unsigned long *fck, int *lck_div,
+                int *pck_div)
 {
         struct dss_clock_info dss_cinfo;
         struct dispc_clock_info dispc_cinfo;
@@ -84,7 +110,7 @@ static int dpi_set_dispc_clk(bool is_tft, unsigned long pck_req,
         if (r)
                 return r;
 
-        r = dispc_set_clock_div(&dispc_cinfo);
+        r = dispc_set_clock_div(dssdev->manager->id, &dispc_cinfo);
         if (r)
                 return r;
 
@@ -94,31 +120,29 @@ static int dpi_set_dispc_clk(bool is_tft, unsigned long pck_req,
 
         return 0;
 }
-#endif
 
 static int dpi_set_mode(struct omap_dss_device *dssdev)
 {
         struct omap_video_timings *t = &dssdev->panel.timings;
-        int lck_div, pck_div;
-        unsigned long fck;
+        int lck_div = 0, pck_div = 0;
+        unsigned long fck = 0;
         unsigned long pck;
         bool is_tft;
         int r = 0;
 
-        dss_clk_enable(DSS_CLK_ICK | DSS_CLK_FCK1);
+        dss_clk_enable(DSS_CLK_ICK | DSS_CLK_FCK);
 
-        dispc_set_pol_freq(dssdev->panel.config, dssdev->panel.acbi,
-                        dssdev->panel.acb);
+        dispc_set_pol_freq(dssdev->manager->id, dssdev->panel.config,
+                        dssdev->panel.acbi, dssdev->panel.acb);
 
         is_tft = (dssdev->panel.config & OMAP_DSS_LCD_TFT) != 0;
 
-#ifdef CONFIG_OMAP2_DSS_USE_DSI_PLL
-        r = dpi_set_dsi_clk(is_tft, t->pixel_clock * 1000,
-                        &fck, &lck_div, &pck_div);
-#else
-        r = dpi_set_dispc_clk(is_tft, t->pixel_clock * 1000,
-                        &fck, &lck_div, &pck_div);
-#endif
+        if (dpi_use_dsi_pll(dssdev))
+                r = dpi_set_dsi_clk(dssdev, is_tft, t->pixel_clock * 1000,
+                                &fck, &lck_div, &pck_div);
+        else
+                r = dpi_set_dispc_clk(dssdev, is_tft, t->pixel_clock * 1000,
+                                &fck, &lck_div, &pck_div);
         if (r)
                 goto err0;
 
@@ -132,10 +156,10 @@ static int dpi_set_mode(struct omap_dss_device *dssdev)
                 t->pixel_clock = pck;
         }
 
-        dispc_set_lcd_timings(t);
+        dispc_set_lcd_timings(dssdev->manager->id, t);
 
 err0:
-        dss_clk_disable(DSS_CLK_ICK | DSS_CLK_FCK1);
+        dss_clk_disable(DSS_CLK_ICK | DSS_CLK_FCK);
         return r;
 }
 
@@ -145,10 +169,12 @@ static int dpi_basic_init(struct omap_dss_device *dssdev)
 
         is_tft = (dssdev->panel.config & OMAP_DSS_LCD_TFT) != 0;
 
-        dispc_set_parallel_interface_mode(OMAP_DSS_PARALLELMODE_BYPASS);
-        dispc_set_lcd_display_type(is_tft ? OMAP_DSS_LCD_DISPLAY_TFT :
-                        OMAP_DSS_LCD_DISPLAY_STN);
-        dispc_set_tft_data_lines(dssdev->phy.dpi.data_lines);
+        dispc_set_parallel_interface_mode(dssdev->manager->id,
+                        OMAP_DSS_PARALLELMODE_BYPASS);
+        dispc_set_lcd_display_type(dssdev->manager->id, is_tft ?
+                        OMAP_DSS_LCD_DISPLAY_TFT : OMAP_DSS_LCD_DISPLAY_STN);
+        dispc_set_tft_data_lines(dssdev->manager->id,
+                        dssdev->phy.dpi.data_lines);
 
         return 0;
 }
@@ -169,18 +195,19 @@ int omapdss_dpi_display_enable(struct omap_dss_device *dssdev)
                         goto err1;
         }
 
-        dss_clk_enable(DSS_CLK_ICK | DSS_CLK_FCK1);
+        dss_clk_enable(DSS_CLK_ICK | DSS_CLK_FCK);
 
         r = dpi_basic_init(dssdev);
         if (r)
                 goto err2;
 
-#ifdef CONFIG_OMAP2_DSS_USE_DSI_PLL
-        dss_clk_enable(DSS_CLK_FCK2);
-        r = dsi_pll_init(dssdev, 0, 1);
-        if (r)
-                goto err3;
-#endif
+        if (dpi_use_dsi_pll(dssdev)) {
+                dss_clk_enable(DSS_CLK_SYSCK);
+                r = dsi_pll_init(dpi.dsidev, 0, 1);
+                if (r)
+                        goto err3;
+        }
+
         r = dpi_set_mode(dssdev);
         if (r)
                 goto err4;
@@ -192,13 +219,13 @@ int omapdss_dpi_display_enable(struct omap_dss_device *dssdev)
         return 0;
 
 err4:
-#ifdef CONFIG_OMAP2_DSS_USE_DSI_PLL
-        dsi_pll_uninit();
+        if (dpi_use_dsi_pll(dssdev))
+                dsi_pll_uninit(dpi.dsidev, true);
 err3:
-        dss_clk_disable(DSS_CLK_FCK2);
-#endif
+        if (dpi_use_dsi_pll(dssdev))
+                dss_clk_disable(DSS_CLK_SYSCK);
 err2:
-        dss_clk_disable(DSS_CLK_ICK | DSS_CLK_FCK1);
+        dss_clk_disable(DSS_CLK_ICK | DSS_CLK_FCK);
         if (cpu_is_omap34xx())
                 regulator_disable(dpi.vdds_dsi_reg);
 err1:
@@ -212,13 +239,13 @@ void omapdss_dpi_display_disable(struct omap_dss_device *dssdev)
 {
         dssdev->manager->disable(dssdev->manager);
 
-#ifdef CONFIG_OMAP2_DSS_USE_DSI_PLL
-        dss_select_dispc_clk_source(DSS_SRC_DSS1_ALWON_FCLK);
-        dsi_pll_uninit();
-        dss_clk_disable(DSS_CLK_FCK2);
-#endif
+        if (dpi_use_dsi_pll(dssdev)) {
+                dss_select_dispc_clk_source(OMAP_DSS_CLK_SRC_FCK);
+                dsi_pll_uninit(dpi.dsidev, true);
+                dss_clk_disable(DSS_CLK_SYSCK);
+        }
 
-        dss_clk_disable(DSS_CLK_ICK | DSS_CLK_FCK1);
+        dss_clk_disable(DSS_CLK_ICK | DSS_CLK_FCK);
 
         if (cpu_is_omap34xx())
                 regulator_disable(dpi.vdds_dsi_reg);
@@ -234,7 +261,7 @@ void dpi_set_timings(struct omap_dss_device *dssdev,
         dssdev->panel.timings = *timings;
         if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE) {
                 dpi_set_mode(dssdev);
-                dispc_go(OMAP_DSS_CHANNEL_LCD);
+                dispc_go(dssdev->manager->id);
         }
 }
 EXPORT_SYMBOL(dpi_set_timings);
@@ -247,6 +274,7 @@ int dpi_check_timings(struct omap_dss_device *dssdev,
         int lck_div, pck_div;
         unsigned long fck;
         unsigned long pck;
+        struct dispc_clock_info dispc_cinfo;
 
         if (!dispc_lcd_timings_ok(timings))
                 return -EINVAL;
@@ -256,25 +284,18 @@ int dpi_check_timings(struct omap_dss_device *dssdev,
 
         is_tft = (dssdev->panel.config & OMAP_DSS_LCD_TFT) != 0;
 
-#ifdef CONFIG_OMAP2_DSS_USE_DSI_PLL
-        {
+        if (dpi_use_dsi_pll(dssdev)) {
                 struct dsi_clock_info dsi_cinfo;
-                struct dispc_clock_info dispc_cinfo;
-                r = dsi_pll_calc_clock_div_pck(is_tft,
+                r = dsi_pll_calc_clock_div_pck(dpi.dsidev, is_tft,
                                 timings->pixel_clock * 1000,
                                 &dsi_cinfo, &dispc_cinfo);
 
                 if (r)
                         return r;
 
-                fck = dsi_cinfo.dsi1_pll_fclk;
-                lck_div = dispc_cinfo.lck_div;
-                pck_div = dispc_cinfo.pck_div;
-        }
-#else
-        {
+                fck = dsi_cinfo.dsi_pll_hsdiv_dispc_clk;
+        } else {
                 struct dss_clock_info dss_cinfo;
-                struct dispc_clock_info dispc_cinfo;
                 r = dss_calc_clock_div(is_tft, timings->pixel_clock * 1000,
                                 &dss_cinfo, &dispc_cinfo);
 
@@ -282,10 +303,10 @@ int dpi_check_timings(struct omap_dss_device *dssdev,
                         return r;
 
                 fck = dss_cinfo.fck;
-                lck_div = dispc_cinfo.lck_div;
-                pck_div = dispc_cinfo.pck_div;
         }
-#endif
+
+        lck_div = dispc_cinfo.lck_div;
+        pck_div = dispc_cinfo.pck_div;
 
         pck = fck / lck_div / pck_div / 1000;
 
@@ -299,22 +320,33 @@ int dpi_init_display(struct omap_dss_device *dssdev)
 {
         DSSDBG("init_display\n");
 
-        return 0;
-}
+        if (cpu_is_omap34xx() && dpi.vdds_dsi_reg == NULL) {
+                struct regulator *vdds_dsi;
 
-int dpi_init(struct platform_device *pdev)
-{
-        if (cpu_is_omap34xx()) {
-                dpi.vdds_dsi_reg = dss_get_vdds_dsi();
-                if (IS_ERR(dpi.vdds_dsi_reg)) {
+                vdds_dsi = dss_get_vdds_dsi();
+
+                if (IS_ERR(vdds_dsi)) {
                         DSSERR("can't get VDDS_DSI regulator\n");
-                        return PTR_ERR(dpi.vdds_dsi_reg);
+                        return PTR_ERR(vdds_dsi);
                 }
+
+                dpi.vdds_dsi_reg = vdds_dsi;
+        }
+
+        if (dpi_use_dsi_pll(dssdev)) {
+                enum omap_dss_clk_source dispc_fclk_src =
+                        dssdev->clocks.dispc.dispc_fclk_src;
+                dpi.dsidev = dpi_get_dsidev(dispc_fclk_src);
         }
 
         return 0;
 }
 
+int dpi_init(void)
+{
+        return 0;
+}
+
 void dpi_exit(void)
 {
 }