aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/usb-serial.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/usb/serial/usb-serial.c')
-rw-r--r--drivers/usb/serial/usb-serial.c17
1 files changed, 8 insertions, 9 deletions
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 7c9dc28640bb..81fc0dfcfdcf 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -868,7 +868,7 @@ static int usb_serial_probe(struct usb_interface *interface,
868 max_endpoints = max(max_endpoints, (int)serial->num_ports); 868 max_endpoints = max(max_endpoints, (int)serial->num_ports);
869 serial->num_port_pointers = max_endpoints; 869 serial->num_port_pointers = max_endpoints;
870 870
871 dev_dbg(ddev, "setting up %d port structures for this device", max_endpoints); 871 dev_dbg(ddev, "setting up %d port structure(s)\n", max_endpoints);
872 for (i = 0; i < max_endpoints; ++i) { 872 for (i = 0; i < max_endpoints; ++i) {
873 port = kzalloc(sizeof(struct usb_serial_port), GFP_KERNEL); 873 port = kzalloc(sizeof(struct usb_serial_port), GFP_KERNEL);
874 if (!port) 874 if (!port)
@@ -923,9 +923,8 @@ static int usb_serial_probe(struct usb_interface *interface,
923 port = serial->port[i]; 923 port = serial->port[i];
924 if (kfifo_alloc(&port->write_fifo, PAGE_SIZE, GFP_KERNEL)) 924 if (kfifo_alloc(&port->write_fifo, PAGE_SIZE, GFP_KERNEL))
925 goto probe_error; 925 goto probe_error;
926 buffer_size = serial->type->bulk_out_size; 926 buffer_size = max_t(int, serial->type->bulk_out_size,
927 if (!buffer_size) 927 usb_endpoint_maxp(endpoint));
928 buffer_size = usb_endpoint_maxp(endpoint);
929 port->bulk_out_size = buffer_size; 928 port->bulk_out_size = buffer_size;
930 port->bulk_out_endpointAddress = endpoint->bEndpointAddress; 929 port->bulk_out_endpointAddress = endpoint->bEndpointAddress;
931 930
@@ -1034,7 +1033,7 @@ static int usb_serial_probe(struct usb_interface *interface,
1034 for (i = 0; i < num_ports; ++i) { 1033 for (i = 0; i < num_ports; ++i) {
1035 port = serial->port[i]; 1034 port = serial->port[i];
1036 dev_set_name(&port->dev, "ttyUSB%d", port->minor); 1035 dev_set_name(&port->dev, "ttyUSB%d", port->minor);
1037 dev_dbg(ddev, "registering %s", dev_name(&port->dev)); 1036 dev_dbg(ddev, "registering %s\n", dev_name(&port->dev));
1038 device_enable_async_suspend(&port->dev); 1037 device_enable_async_suspend(&port->dev);
1039 1038
1040 retval = device_add(&port->dev); 1039 retval = device_add(&port->dev);
@@ -1161,9 +1160,9 @@ static int usb_serial_reset_resume(struct usb_interface *intf)
1161 usb_serial_unpoison_port_urbs(serial); 1160 usb_serial_unpoison_port_urbs(serial);
1162 1161
1163 serial->suspending = 0; 1162 serial->suspending = 0;
1164 if (serial->type->reset_resume) 1163 if (serial->type->reset_resume) {
1165 rv = serial->type->reset_resume(serial); 1164 rv = serial->type->reset_resume(serial);
1166 else { 1165 } else {
1167 rv = -EOPNOTSUPP; 1166 rv = -EOPNOTSUPP;
1168 intf->needs_binding = 1; 1167 intf->needs_binding = 1;
1169 } 1168 }
@@ -1338,9 +1337,9 @@ static int usb_serial_register(struct usb_serial_driver *driver)
1338 if (retval) { 1337 if (retval) {
1339 pr_err("problem %d when registering driver %s\n", retval, driver->description); 1338 pr_err("problem %d when registering driver %s\n", retval, driver->description);
1340 list_del(&driver->driver_list); 1339 list_del(&driver->driver_list);
1341 } else 1340 } else {
1342 pr_info("USB Serial support registered for %s\n", driver->description); 1341 pr_info("USB Serial support registered for %s\n", driver->description);
1343 1342 }
1344 mutex_unlock(&table_lock); 1343 mutex_unlock(&table_lock);
1345 return retval; 1344 return retval;
1346} 1345}