1 files changed, 5 insertions, 61 deletions

diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c
index d5c0c6ab4966..a40615674a68 100644
--- a/drivers/usb/serial/keyspan_pda.c
+++ b/drivers/usb/serial/keyspan_pda.c
@@ -12,59 +12,6 @@
  *
  * See Documentation/usb/usb-serial.txt for more information on using this
  * driver
- *
- * (09/07/2001) gkh
- *      cleaned up the Xircom support.  Added ids for Entregra device which is
- *      the same as the Xircom device.  Enabled the code to be compiled for
- *      either Xircom or Keyspan devices.
- *
- * (08/11/2001) Cristian M. Craciunescu
- *      support for Xircom PGSDB9
- *
- * (05/31/2001) gkh
- *      switched from using spinlock to a semaphore, which fixes lots of
- *      problems.
- *
- * (04/08/2001) gb
- *      Identify version on module load.
- *
- * (11/01/2000) Adam J. Richter
- *      usb_device_id table support
- *
- * (10/05/2000) gkh
- *      Fixed bug with urb->dev not being set properly, now that the usb
- *      core needs it.
- *
- * (08/28/2000) gkh
- *      Added locks for SMP safeness.
- *      Fixed MOD_INC and MOD_DEC logic and the ability to open a port more
- *      than once.
- *
- * (07/20/2000) borchers
- *      - keyspan_pda_write no longer sleeps if it is called on interrupt time;
- *        PPP and the line discipline with stty echo on can call write on
- *        interrupt time and this would cause an oops if write slept
- *      - if keyspan_pda_write is in an interrupt, it will not call
- *        usb_control_msg (which sleeps) to query the room in the device
- *        buffer, it simply uses the current room value it has
- *      - if the urb is busy or if it is throttled keyspan_pda_write just
- *        returns 0, rather than sleeping to wait for this to change; the
- *        write_chan code in n_tty.c will sleep if needed before calling
- *        keyspan_pda_write again
- *      - if the device needs to be unthrottled, write now queues up the
- *        call to usb_control_msg (which sleeps) to unthrottle the device
- *      - the wakeups from keyspan_pda_write_bulk_callback are queued rather
- *        than done directly from the callback to avoid the race in write_chan
- *      - keyspan_pda_chars_in_buffer also indicates its buffer is full if the
- *        urb status is -EINPROGRESS, meaning it cannot write at the moment
- *
- * (07/19/2000) gkh
- *      Added module_init and module_exit functions to handle the fact that this
- *      driver is a loadable module now.
- *
- * (03/26/2000) gkh
- *      Split driver up into device specific pieces.
- *
  */
 
 
@@ -290,7 +237,6 @@ static void keyspan_pda_rx_unthrottle(struct tty_struct *tty)
         struct usb_serial_port *port = tty->driver_data;
         /* just restart the receive interrupt URB */
         dbg("keyspan_pda_rx_unthrottle port %d", port->number);
-        port->interrupt_in_urb->dev = port->serial->dev;
         if (usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL))
                 dbg(" usb_submit_urb(read urb) failed");
 }
@@ -532,11 +478,11 @@ static int keyspan_pda_write(struct tty_struct *tty,
            the device is full (wait until it says there is room)
         */
         spin_lock_bh(&port->lock);
-        if (port->write_urb_busy || priv->tx_throttled) {
+        if (!test_bit(0, &port->write_urbs_free) || priv->tx_throttled) {
                 spin_unlock_bh(&port->lock);
                 return 0;
         }
-        port->write_urb_busy = 1;
+        clear_bit(0, &port->write_urbs_free);
         spin_unlock_bh(&port->lock);
 
         /* At this point the URB is in our control, nobody else can submit it
@@ -598,7 +544,6 @@ static int keyspan_pda_write(struct tty_struct *tty,
 
                 priv->tx_room -= count;
 
-                port->write_urb->dev = port->serial->dev;
                 rc = usb_submit_urb(port->write_urb, GFP_ATOMIC);
                 if (rc) {
                         dbg(" usb_submit_urb(write bulk) failed");
@@ -618,7 +563,7 @@ static int keyspan_pda_write(struct tty_struct *tty,
         rc = count;
 exit:
         if (rc < 0)
-                port->write_urb_busy = 0;
+                set_bit(0, &port->write_urbs_free);
         return rc;
 }
 
@@ -628,7 +573,7 @@ static void keyspan_pda_write_bulk_callback(struct urb *urb)
         struct usb_serial_port *port = urb->context;
         struct keyspan_pda_private *priv;
 
-        port->write_urb_busy = 0;
+        set_bit(0, &port->write_urbs_free);
         priv = usb_get_serial_port_data(port);
 
         /* queue up a wakeup at scheduler time */
@@ -661,7 +606,7 @@ static int keyspan_pda_chars_in_buffer(struct tty_struct *tty)
            n_tty.c:normal_poll() ) that we're not writeable. */
 
         spin_lock_irqsave(&port->lock, flags);
-        if (port->write_urb_busy || priv->tx_throttled)
+        if (!test_bit(0, &port->write_urbs_free) || priv->tx_throttled)
                 ret = 256;
         spin_unlock_irqrestore(&port->lock, flags);
         return ret;
@@ -717,7 +662,6 @@ static int keyspan_pda_open(struct tty_struct *tty,
         priv->tx_throttled = *room ? 0 : 1;
 
         /*Start reading from the device*/
-        port->interrupt_in_urb->dev = serial->dev;
         rc = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
         if (rc) {
                 dbg("%s - usb_submit_urb(read int) failed", __func__);