diff options
Diffstat (limited to 'drivers/usb/misc/legousbtower.c')
-rw-r--r-- | drivers/usb/misc/legousbtower.c | 42 |
1 files changed, 1 insertions, 41 deletions
diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 80894791c020..93c95d09f04e 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c | |||
@@ -318,8 +318,6 @@ static inline void lego_usb_tower_debug_data (int level, const char *function, i | |||
318 | */ | 318 | */ |
319 | static inline void tower_delete (struct lego_usb_tower *dev) | 319 | static inline void tower_delete (struct lego_usb_tower *dev) |
320 | { | 320 | { |
321 | dbg(2, "%s: enter", __func__); | ||
322 | |||
323 | tower_abort_transfers (dev); | 321 | tower_abort_transfers (dev); |
324 | 322 | ||
325 | /* free data structures */ | 323 | /* free data structures */ |
@@ -329,8 +327,6 @@ static inline void tower_delete (struct lego_usb_tower *dev) | |||
329 | kfree (dev->interrupt_in_buffer); | 327 | kfree (dev->interrupt_in_buffer); |
330 | kfree (dev->interrupt_out_buffer); | 328 | kfree (dev->interrupt_out_buffer); |
331 | kfree (dev); | 329 | kfree (dev); |
332 | |||
333 | dbg(2, "%s: leave", __func__); | ||
334 | } | 330 | } |
335 | 331 | ||
336 | 332 | ||
@@ -346,8 +342,6 @@ static int tower_open (struct inode *inode, struct file *file) | |||
346 | struct tower_reset_reply reset_reply; | 342 | struct tower_reset_reply reset_reply; |
347 | int result; | 343 | int result; |
348 | 344 | ||
349 | dbg(2, "%s: enter", __func__); | ||
350 | |||
351 | nonseekable_open(inode, file); | 345 | nonseekable_open(inode, file); |
352 | subminor = iminor(inode); | 346 | subminor = iminor(inode); |
353 | 347 | ||
@@ -435,8 +429,6 @@ unlock_exit: | |||
435 | mutex_unlock(&dev->lock); | 429 | mutex_unlock(&dev->lock); |
436 | 430 | ||
437 | exit: | 431 | exit: |
438 | dbg(2, "%s: leave, return value %d ", __func__, retval); | ||
439 | |||
440 | return retval; | 432 | return retval; |
441 | } | 433 | } |
442 | 434 | ||
@@ -448,8 +440,6 @@ static int tower_release (struct inode *inode, struct file *file) | |||
448 | struct lego_usb_tower *dev; | 440 | struct lego_usb_tower *dev; |
449 | int retval = 0; | 441 | int retval = 0; |
450 | 442 | ||
451 | dbg(2, "%s: enter", __func__); | ||
452 | |||
453 | dev = file->private_data; | 443 | dev = file->private_data; |
454 | 444 | ||
455 | if (dev == NULL) { | 445 | if (dev == NULL) { |
@@ -491,7 +481,6 @@ unlock_exit: | |||
491 | exit: | 481 | exit: |
492 | mutex_unlock(&open_disc_mutex); | 482 | mutex_unlock(&open_disc_mutex); |
493 | exit_nolock: | 483 | exit_nolock: |
494 | dbg(2, "%s: leave, return value %d", __func__, retval); | ||
495 | return retval; | 484 | return retval; |
496 | } | 485 | } |
497 | 486 | ||
@@ -502,11 +491,9 @@ exit_nolock: | |||
502 | */ | 491 | */ |
503 | static void tower_abort_transfers (struct lego_usb_tower *dev) | 492 | static void tower_abort_transfers (struct lego_usb_tower *dev) |
504 | { | 493 | { |
505 | dbg(2, "%s: enter", __func__); | ||
506 | |||
507 | if (dev == NULL) { | 494 | if (dev == NULL) { |
508 | dbg(1, "%s: dev is null", __func__); | 495 | dbg(1, "%s: dev is null", __func__); |
509 | goto exit; | 496 | return; |
510 | } | 497 | } |
511 | 498 | ||
512 | /* shutdown transfer */ | 499 | /* shutdown transfer */ |
@@ -518,9 +505,6 @@ static void tower_abort_transfers (struct lego_usb_tower *dev) | |||
518 | } | 505 | } |
519 | if (dev->interrupt_out_busy && dev->udev) | 506 | if (dev->interrupt_out_busy && dev->udev) |
520 | usb_kill_urb(dev->interrupt_out_urb); | 507 | usb_kill_urb(dev->interrupt_out_urb); |
521 | |||
522 | exit: | ||
523 | dbg(2, "%s: leave", __func__); | ||
524 | } | 508 | } |
525 | 509 | ||
526 | 510 | ||
@@ -553,8 +537,6 @@ static unsigned int tower_poll (struct file *file, poll_table *wait) | |||
553 | struct lego_usb_tower *dev; | 537 | struct lego_usb_tower *dev; |
554 | unsigned int mask = 0; | 538 | unsigned int mask = 0; |
555 | 539 | ||
556 | dbg(2, "%s: enter", __func__); | ||
557 | |||
558 | dev = file->private_data; | 540 | dev = file->private_data; |
559 | 541 | ||
560 | if (!dev->udev) | 542 | if (!dev->udev) |
@@ -571,8 +553,6 @@ static unsigned int tower_poll (struct file *file, poll_table *wait) | |||
571 | mask |= POLLOUT | POLLWRNORM; | 553 | mask |= POLLOUT | POLLWRNORM; |
572 | } | 554 | } |
573 | 555 | ||
574 | dbg(2, "%s: leave, mask = %d", __func__, mask); | ||
575 | |||
576 | return mask; | 556 | return mask; |
577 | } | 557 | } |
578 | 558 | ||
@@ -597,8 +577,6 @@ static ssize_t tower_read (struct file *file, char __user *buffer, size_t count, | |||
597 | int retval = 0; | 577 | int retval = 0; |
598 | unsigned long timeout = 0; | 578 | unsigned long timeout = 0; |
599 | 579 | ||
600 | dbg(2, "%s: enter, count = %Zd", __func__, count); | ||
601 | |||
602 | dev = file->private_data; | 580 | dev = file->private_data; |
603 | 581 | ||
604 | /* lock this object */ | 582 | /* lock this object */ |
@@ -672,7 +650,6 @@ unlock_exit: | |||
672 | mutex_unlock(&dev->lock); | 650 | mutex_unlock(&dev->lock); |
673 | 651 | ||
674 | exit: | 652 | exit: |
675 | dbg(2, "%s: leave, return value %d", __func__, retval); | ||
676 | return retval; | 653 | return retval; |
677 | } | 654 | } |
678 | 655 | ||
@@ -686,8 +663,6 @@ static ssize_t tower_write (struct file *file, const char __user *buffer, size_t | |||
686 | size_t bytes_to_write; | 663 | size_t bytes_to_write; |
687 | int retval = 0; | 664 | int retval = 0; |
688 | 665 | ||
689 | dbg(2, "%s: enter, count = %Zd", __func__, count); | ||
690 | |||
691 | dev = file->private_data; | 666 | dev = file->private_data; |
692 | 667 | ||
693 | /* lock this object */ | 668 | /* lock this object */ |
@@ -757,8 +732,6 @@ unlock_exit: | |||
757 | mutex_unlock(&dev->lock); | 732 | mutex_unlock(&dev->lock); |
758 | 733 | ||
759 | exit: | 734 | exit: |
760 | dbg(2, "%s: leave, return value %d", __func__, retval); | ||
761 | |||
762 | return retval; | 735 | return retval; |
763 | } | 736 | } |
764 | 737 | ||
@@ -772,8 +745,6 @@ static void tower_interrupt_in_callback (struct urb *urb) | |||
772 | int status = urb->status; | 745 | int status = urb->status; |
773 | int retval; | 746 | int retval; |
774 | 747 | ||
775 | dbg(4, "%s: enter, status %d", __func__, status); | ||
776 | |||
777 | lego_usb_tower_debug_data(5, __func__, urb->actual_length, urb->transfer_buffer); | 748 | lego_usb_tower_debug_data(5, __func__, urb->actual_length, urb->transfer_buffer); |
778 | 749 | ||
779 | if (status) { | 750 | if (status) { |
@@ -817,7 +788,6 @@ exit: | |||
817 | wake_up_interruptible (&dev->read_wait); | 788 | wake_up_interruptible (&dev->read_wait); |
818 | 789 | ||
819 | lego_usb_tower_debug_data(5, __func__, urb->actual_length, urb->transfer_buffer); | 790 | lego_usb_tower_debug_data(5, __func__, urb->actual_length, urb->transfer_buffer); |
820 | dbg(4, "%s: leave, status %d", __func__, status); | ||
821 | } | 791 | } |
822 | 792 | ||
823 | 793 | ||
@@ -829,7 +799,6 @@ static void tower_interrupt_out_callback (struct urb *urb) | |||
829 | struct lego_usb_tower *dev = urb->context; | 799 | struct lego_usb_tower *dev = urb->context; |
830 | int status = urb->status; | 800 | int status = urb->status; |
831 | 801 | ||
832 | dbg(4, "%s: enter, status %d", __func__, status); | ||
833 | lego_usb_tower_debug_data(5, __func__, urb->actual_length, urb->transfer_buffer); | 802 | lego_usb_tower_debug_data(5, __func__, urb->actual_length, urb->transfer_buffer); |
834 | 803 | ||
835 | /* sync/async unlink faults aren't errors */ | 804 | /* sync/async unlink faults aren't errors */ |
@@ -844,7 +813,6 @@ static void tower_interrupt_out_callback (struct urb *urb) | |||
844 | wake_up_interruptible(&dev->write_wait); | 813 | wake_up_interruptible(&dev->write_wait); |
845 | 814 | ||
846 | lego_usb_tower_debug_data(5, __func__, urb->actual_length, urb->transfer_buffer); | 815 | lego_usb_tower_debug_data(5, __func__, urb->actual_length, urb->transfer_buffer); |
847 | dbg(4, "%s: leave, status %d", __func__, status); | ||
848 | } | 816 | } |
849 | 817 | ||
850 | 818 | ||
@@ -866,8 +834,6 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device | |||
866 | int retval = -ENOMEM; | 834 | int retval = -ENOMEM; |
867 | int result; | 835 | int result; |
868 | 836 | ||
869 | dbg(2, "%s: enter", __func__); | ||
870 | |||
871 | /* allocate memory for our device state and initialize it */ | 837 | /* allocate memory for our device state and initialize it */ |
872 | 838 | ||
873 | dev = kmalloc (sizeof(struct lego_usb_tower), GFP_KERNEL); | 839 | dev = kmalloc (sizeof(struct lego_usb_tower), GFP_KERNEL); |
@@ -993,8 +959,6 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device | |||
993 | 959 | ||
994 | 960 | ||
995 | exit: | 961 | exit: |
996 | dbg(2, "%s: leave, return value 0x%.8lx (dev)", __func__, (long) dev); | ||
997 | |||
998 | return retval; | 962 | return retval; |
999 | 963 | ||
1000 | error: | 964 | error: |
@@ -1013,8 +977,6 @@ static void tower_disconnect (struct usb_interface *interface) | |||
1013 | struct lego_usb_tower *dev; | 977 | struct lego_usb_tower *dev; |
1014 | int minor; | 978 | int minor; |
1015 | 979 | ||
1016 | dbg(2, "%s: enter", __func__); | ||
1017 | |||
1018 | dev = usb_get_intfdata (interface); | 980 | dev = usb_get_intfdata (interface); |
1019 | mutex_lock(&open_disc_mutex); | 981 | mutex_lock(&open_disc_mutex); |
1020 | usb_set_intfdata (interface, NULL); | 982 | usb_set_intfdata (interface, NULL); |
@@ -1041,8 +1003,6 @@ static void tower_disconnect (struct usb_interface *interface) | |||
1041 | 1003 | ||
1042 | dev_info(&interface->dev, "LEGO USB Tower #%d now disconnected\n", | 1004 | dev_info(&interface->dev, "LEGO USB Tower #%d now disconnected\n", |
1043 | (minor - LEGO_USB_TOWER_MINOR_BASE)); | 1005 | (minor - LEGO_USB_TOWER_MINOR_BASE)); |
1044 | |||
1045 | dbg(2, "%s: leave", __func__); | ||
1046 | } | 1006 | } |
1047 | 1007 | ||
1048 | module_usb_driver(tower_driver); | 1008 | module_usb_driver(tower_driver); |