11 files changed, 59 insertions, 192 deletions

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index bb55eb4a7d48..d7fe287d0678 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -56,15 +56,6 @@
 #define EHCI_INSNREG05_ULPI_EXTREGADD_SHIFT             8
 #define EHCI_INSNREG05_ULPI_WRDATA_SHIFT                0
 
-/* Errata i693 */
-static struct clk       *utmi_p1_fck;
-static struct clk       *utmi_p2_fck;
-static struct clk       *xclk60mhsp1_ck;
-static struct clk       *xclk60mhsp2_ck;
-static struct clk       *usbhost_p1_fck;
-static struct clk       *usbhost_p2_fck;
-static struct clk       *init_60m_fclk;
-
 /*-------------------------------------------------------------------------*/
 
 static const struct hc_driver ehci_omap_hc_driver;
@@ -80,40 +71,6 @@ static inline u32 ehci_read(void __iomem *base, u32 reg)
         return __raw_readl(base + reg);
 }
 
-/* Erratum i693 workaround sequence */
-static void omap_ehci_erratum_i693(struct ehci_hcd *ehci)
-{
-        int ret = 0;
-
-        /* Switch to the internal 60 MHz clock */
-        ret = clk_set_parent(utmi_p1_fck, init_60m_fclk);
-        if (ret != 0)
-                ehci_err(ehci, "init_60m_fclk set parent"
-                        "failed error:%d\n", ret);
-
-        ret = clk_set_parent(utmi_p2_fck, init_60m_fclk);
-        if (ret != 0)
-                ehci_err(ehci, "init_60m_fclk set parent"
-                        "failed error:%d\n", ret);
-
-        clk_enable(usbhost_p1_fck);
-        clk_enable(usbhost_p2_fck);
-
-        /* Wait 1ms and switch back to the external clock */
-        mdelay(1);
-        ret = clk_set_parent(utmi_p1_fck, xclk60mhsp1_ck);
-        if (ret != 0)
-                ehci_err(ehci, "xclk60mhsp1_ck set parent"
-                        "failed error:%d\n", ret);
-
-        ret = clk_set_parent(utmi_p2_fck, xclk60mhsp2_ck);
-        if (ret != 0)
-                ehci_err(ehci, "xclk60mhsp2_ck set parent"
-                        "failed error:%d\n", ret);
-
-        clk_disable(usbhost_p1_fck);
-        clk_disable(usbhost_p2_fck);
-}
 
 static void omap_ehci_soft_phy_reset(struct usb_hcd *hcd, u8 port)
 {
@@ -195,50 +152,6 @@ static int omap_ehci_init(struct usb_hcd *hcd)
         return rc;
 }
 
-static int omap_ehci_hub_control(
-        struct usb_hcd  *hcd,
-        u16             typeReq,
-        u16             wValue,
-        u16             wIndex,
-        char            *buf,
-        u16             wLength
-)
-{
-        struct ehci_hcd *ehci = hcd_to_ehci(hcd);
-        u32 __iomem *status_reg = &ehci->regs->port_status[
-                                (wIndex & 0xff) - 1];
-        u32             temp;
-        unsigned long   flags;
-        int             retval = 0;
-
-        spin_lock_irqsave(&ehci->lock, flags);
-
-        if (typeReq == SetPortFeature && wValue == USB_PORT_FEAT_SUSPEND) {
-                temp = ehci_readl(ehci, status_reg);
-                if ((temp & PORT_PE) == 0 || (temp & PORT_RESET) != 0) {
-                        retval = -EPIPE;
-                        goto done;
-                }
-
-                temp &= ~PORT_WKCONN_E;
-                temp |= PORT_WKDISC_E | PORT_WKOC_E;
-                ehci_writel(ehci, temp | PORT_SUSPEND, status_reg);
-
-                omap_ehci_erratum_i693(ehci);
-
-                set_bit((wIndex & 0xff) - 1, &ehci->suspended_ports);
-                goto done;
-        }
-
-        spin_unlock_irqrestore(&ehci->lock, flags);
-
-        /* Handle the hub control events here */
-        return ehci_hub_control(hcd, typeReq, wValue, wIndex, buf, wLength);
-done:
-        spin_unlock_irqrestore(&ehci->lock, flags);
-        return retval;
-}
-
 static void disable_put_regulator(
                 struct ehci_hcd_omap_platform_data *pdata)
 {
@@ -351,79 +264,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
                 goto err_pm_runtime;
         }
 
-        /* get clocks */
-        utmi_p1_fck = clk_get(dev, "utmi_p1_gfclk");
-        if (IS_ERR(utmi_p1_fck)) {
-                ret = PTR_ERR(utmi_p1_fck);
-                dev_err(dev, "utmi_p1_gfclk failed error:%d\n", ret);
-                goto err_add_hcd;
-        }
-
-        xclk60mhsp1_ck = clk_get(dev, "xclk60mhsp1_ck");
-        if (IS_ERR(xclk60mhsp1_ck)) {
-                ret = PTR_ERR(xclk60mhsp1_ck);
-                dev_err(dev, "xclk60mhsp1_ck failed error:%d\n", ret);
-                goto err_utmi_p1_fck;
-        }
-
-        utmi_p2_fck = clk_get(dev, "utmi_p2_gfclk");
-        if (IS_ERR(utmi_p2_fck)) {
-                ret = PTR_ERR(utmi_p2_fck);
-                dev_err(dev, "utmi_p2_gfclk failed error:%d\n", ret);
-                goto err_xclk60mhsp1_ck;
-        }
-
-        xclk60mhsp2_ck = clk_get(dev, "xclk60mhsp2_ck");
-        if (IS_ERR(xclk60mhsp2_ck)) {
-                ret = PTR_ERR(xclk60mhsp2_ck);
-                dev_err(dev, "xclk60mhsp2_ck failed error:%d\n", ret);
-                goto err_utmi_p2_fck;
-        }
-
-        usbhost_p1_fck = clk_get(dev, "usb_host_hs_utmi_p1_clk");
-        if (IS_ERR(usbhost_p1_fck)) {
-                ret = PTR_ERR(usbhost_p1_fck);
-                dev_err(dev, "usbhost_p1_fck failed error:%d\n", ret);
-                goto err_xclk60mhsp2_ck;
-        }
-
-        usbhost_p2_fck = clk_get(dev, "usb_host_hs_utmi_p2_clk");
-        if (IS_ERR(usbhost_p2_fck)) {
-                ret = PTR_ERR(usbhost_p2_fck);
-                dev_err(dev, "usbhost_p2_fck failed error:%d\n", ret);
-                goto err_usbhost_p1_fck;
-        }
-
-        init_60m_fclk = clk_get(dev, "init_60m_fclk");
-        if (IS_ERR(init_60m_fclk)) {
-                ret = PTR_ERR(init_60m_fclk);
-                dev_err(dev, "init_60m_fclk failed error:%d\n", ret);
-                goto err_usbhost_p2_fck;
-        }
 
         return 0;
 
-err_usbhost_p2_fck:
-        clk_put(usbhost_p2_fck);
-
-err_usbhost_p1_fck:
-        clk_put(usbhost_p1_fck);
-
-err_xclk60mhsp2_ck:
-        clk_put(xclk60mhsp2_ck);
-
-err_utmi_p2_fck:
-        clk_put(utmi_p2_fck);
-
-err_xclk60mhsp1_ck:
-        clk_put(xclk60mhsp1_ck);
-
-err_utmi_p1_fck:
-        clk_put(utmi_p1_fck);
-
-err_add_hcd:
-        usb_remove_hcd(hcd);
-
 err_pm_runtime:
         disable_put_regulator(pdata);
         pm_runtime_put_sync(dev);
@@ -454,14 +297,6 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev)
         iounmap(hcd->regs);
         usb_put_hcd(hcd);
 
-        clk_put(utmi_p1_fck);
-        clk_put(utmi_p2_fck);
-        clk_put(xclk60mhsp1_ck);
-        clk_put(xclk60mhsp2_ck);
-        clk_put(usbhost_p1_fck);
-        clk_put(usbhost_p2_fck);
-        clk_put(init_60m_fclk);
-
         pm_runtime_put_sync(dev);
         pm_runtime_disable(dev);
 
@@ -532,7 +367,7 @@ static const struct hc_driver ehci_omap_hc_driver = {
          * root hub support
          */
         .hub_status_data        = ehci_hub_status_data,
-        .hub_control            = omap_ehci_hub_control,
+        .hub_control            = ehci_hub_control,
         .bus_suspend            = ehci_bus_suspend,
         .bus_resume             = ehci_bus_resume,
 
diff --git a/drivers/usb/host/ehci-sead3.c b/drivers/usb/host/ehci-sead3.c
index 58c96bd50d22..0c9e43cfaff5 100644
--- a/drivers/usb/host/ehci-sead3.c
+++ b/drivers/usb/host/ehci-sead3.c
@@ -40,7 +40,7 @@ static int ehci_sead3_setup(struct usb_hcd *hcd)
         ehci->need_io_watchdog = 0;
 
         /* Set burst length to 16 words. */
-        ehci_writel(ehci, 0x1010, &ehci->regs->reserved[1]);
+        ehci_writel(ehci, 0x1010, &ehci->regs->reserved1[1]);
 
         return ret;
 }
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 950e95efa381..26dedb30ad0b 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -799,11 +799,12 @@ static int tegra_ehci_remove(struct platform_device *pdev)
 #endif
 
         usb_remove_hcd(hcd);
-        usb_put_hcd(hcd);
 
         tegra_usb_phy_close(tegra->phy);
         iounmap(hcd->regs);
 
+        usb_put_hcd(hcd);
+
         clk_disable_unprepare(tegra->clk);
         clk_put(tegra->clk);
 
diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c
index 2ed112d3e159..256326322cfd 100644
--- a/drivers/usb/host/isp1362-hcd.c
+++ b/drivers/usb/host/isp1362-hcd.c
@@ -543,12 +543,12 @@ static void postproc_ep(struct isp1362_hcd *isp1362_hcd, struct isp1362_ep *ep)
                             usb_pipein(urb->pipe) ? "IN" : "OUT", ep->nextpid,
                             short_ok ? "" : "not_",
                             PTD_GET_COUNT(ptd), ep->maxpacket, len);
+                        /* save the data underrun error code for later and
+                         * proceed with the status stage
+                         */
+                        urb->actual_length += PTD_GET_COUNT(ptd);
                         if (usb_pipecontrol(urb->pipe)) {
                                 ep->nextpid = USB_PID_ACK;
-                                /* save the data underrun error code for later and
-                                 * proceed with the status stage
-                                 */
-                                urb->actual_length += PTD_GET_COUNT(ptd);
                                 BUG_ON(urb->actual_length > urb->transfer_buffer_length);
 
                                 if (urb->status == -EINPROGRESS)
diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
index e7d75d295988..f8b2d91851f7 100644
--- a/drivers/usb/host/ohci-omap.c
+++ b/drivers/usb/host/ohci-omap.c
@@ -403,8 +403,6 @@ err0:
 static inline void
 usb_hcd_omap_remove (struct usb_hcd *hcd, struct platform_device *pdev)
 {
-        struct ohci_hcd         *ohci = hcd_to_ohci (hcd);
-
         usb_remove_hcd(hcd);
         if (!IS_ERR_OR_NULL(hcd->phy)) {
                 (void) otg_set_host(hcd->phy->otg, 0);
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index df0828cb2aa3..c5e9e4a76f14 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -800,6 +800,13 @@ void usb_enable_xhci_ports(struct pci_dev *xhci_pdev)
 }
 EXPORT_SYMBOL_GPL(usb_enable_xhci_ports);
 
+void usb_disable_xhci_ports(struct pci_dev *xhci_pdev)
+{
+        pci_write_config_dword(xhci_pdev, USB_INTEL_USB3_PSSEN, 0x0);
+        pci_write_config_dword(xhci_pdev, USB_INTEL_XUSB2PR, 0x0);
+}
+EXPORT_SYMBOL_GPL(usb_disable_xhci_ports);
+
 /**
  * PCI Quirks for xHCI.
  *
diff --git a/drivers/usb/host/pci-quirks.h b/drivers/usb/host/pci-quirks.h
index b1002a8ef96f..ef004a5de20f 100644
--- a/drivers/usb/host/pci-quirks.h
+++ b/drivers/usb/host/pci-quirks.h
@@ -10,6 +10,7 @@ void usb_amd_quirk_pll_disable(void);
 void usb_amd_quirk_pll_enable(void);
 bool usb_is_intel_switchable_xhci(struct pci_dev *pdev);
 void usb_enable_xhci_ports(struct pci_dev *xhci_pdev);
+void usb_disable_xhci_ports(struct pci_dev *xhci_pdev);
 #else
 static inline void usb_amd_quirk_pll_disable(void) {}
 static inline void usb_amd_quirk_pll_enable(void) {}
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 18b231b0c5d3..9bfd4ca1153c 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -94,11 +94,21 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
                 xhci->quirks |= XHCI_EP_LIMIT_QUIRK;
                 xhci->limit_active_eps = 64;
                 xhci->quirks |= XHCI_SW_BW_CHECKING;
+                /*
+                 * PPT desktop boards DH77EB and DH77DF will power back on after
+                 * a few seconds of being shutdown.  The fix for this is to
+                 * switch the ports from xHCI to EHCI on shutdown.  We can't use
+                 * DMI information to find those particular boards (since each
+                 * vendor will change the board name), so we have to key off all
+                 * PPT chipsets.
+                 */
+                xhci->quirks |= XHCI_SPURIOUS_REBOOT;
         }
         if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
                         pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
                 xhci->quirks |= XHCI_RESET_ON_RESUME;
                 xhci_dbg(xhci, "QUIRK: Resetting on resume\n");
+                xhci->quirks |= XHCI_TRUST_TX_LENGTH;
         }
         if (pdev->vendor == PCI_VENDOR_ID_VIA)
                 xhci->quirks |= XHCI_RESET_ON_RESUME;
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 8275645889da..643c2f3f3e73 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -145,29 +145,37 @@ static void next_trb(struct xhci_hcd *xhci,
  */
 static void inc_deq(struct xhci_hcd *xhci, struct xhci_ring *ring)
 {
-        union xhci_trb *next;
         unsigned long long addr;
 
         ring->deq_updates++;
 
-        /* If this is not event ring, there is one more usable TRB */
+        /*
+         * If this is not event ring, and the dequeue pointer
+         * is not on a link TRB, there is one more usable TRB
+         */
         if (ring->type != TYPE_EVENT &&
                         !last_trb(xhci, ring, ring->deq_seg, ring->dequeue))
                 ring->num_trbs_free++;
-        next = ++(ring->dequeue);
 
-        /* Update the dequeue pointer further if that was a link TRB or we're at
-         * the end of an event ring segment (which doesn't have link TRBS)
-         */
-        while (last_trb(xhci, ring, ring->deq_seg, next)) {
-                if (ring->type == TYPE_EVENT && last_trb_on_last_seg(xhci,
-                                ring, ring->deq_seg, next)) {
-                        ring->cycle_state = (ring->cycle_state ? 0 : 1);
+        do {
+                /*
+                 * Update the dequeue pointer further if that was a link TRB or
+                 * we're at the end of an event ring segment (which doesn't have
+                 * link TRBS)
+                 */
+                if (last_trb(xhci, ring, ring->deq_seg, ring->dequeue)) {
+                        if (ring->type == TYPE_EVENT &&
+                                        last_trb_on_last_seg(xhci, ring,
+                                                ring->deq_seg, ring->dequeue)) {
+                                ring->cycle_state = (ring->cycle_state ? 0 : 1);
+                        }
+                        ring->deq_seg = ring->deq_seg->next;
+                        ring->dequeue = ring->deq_seg->trbs;
+                } else {
+                        ring->dequeue++;
                 }
-                ring->deq_seg = ring->deq_seg->next;
-                ring->dequeue = ring->deq_seg->trbs;
-                next = ring->dequeue;
-        }
+        } while (last_trb(xhci, ring, ring->deq_seg, ring->dequeue));
+
         addr = (unsigned long long) xhci_trb_virt_to_dma(ring->deq_seg, ring->dequeue);
 }
 
@@ -2073,8 +2081,8 @@ static int handle_tx_event(struct xhci_hcd *xhci,
                 if (xhci->quirks & XHCI_TRUST_TX_LENGTH)
                         trb_comp_code = COMP_SHORT_TX;
                 else
-                        xhci_warn(xhci, "WARN Successful completion on short TX: "
-                                        "needs XHCI_TRUST_TX_LENGTH quirk?\n");
+                        xhci_warn_ratelimited(xhci,
+                                        "WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?\n");
         case COMP_SHORT_TX:
                 break;
         case COMP_STOP:
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 7648b2d4b268..c59d5b5b6c7d 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -166,7 +166,7 @@ int xhci_reset(struct xhci_hcd *xhci)
         xhci_writel(xhci, command, &xhci->op_regs->command);
 
         ret = handshake(xhci, &xhci->op_regs->command,
-                        CMD_RESET, 0, 250 * 1000);
+                        CMD_RESET, 0, 10 * 1000 * 1000);
         if (ret)
                 return ret;
 
@@ -175,7 +175,8 @@ int xhci_reset(struct xhci_hcd *xhci)
          * xHCI cannot write to any doorbells or operational registers other
          * than status until the "Controller Not Ready" flag is cleared.
          */
-        ret = handshake(xhci, &xhci->op_regs->status, STS_CNR, 0, 250 * 1000);
+        ret = handshake(xhci, &xhci->op_regs->status,
+                        STS_CNR, 0, 10 * 1000 * 1000);
 
         for (i = 0; i < 2; ++i) {
                 xhci->bus_state[i].port_c_suspend = 0;
@@ -658,6 +659,9 @@ void xhci_shutdown(struct usb_hcd *hcd)
 {
         struct xhci_hcd *xhci = hcd_to_xhci(hcd);
 
+        if (xhci->quirks && XHCI_SPURIOUS_REBOOT)
+                usb_disable_xhci_ports(to_pci_dev(hcd->self.controller));
+
         spin_lock_irq(&xhci->lock);
         xhci_halt(xhci);
         spin_unlock_irq(&xhci->lock);
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 55c0785810c9..c713256297ac 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1494,6 +1494,7 @@ struct xhci_hcd {
 #define XHCI_TRUST_TX_LENGTH    (1 << 10)
 #define XHCI_LPM_SUPPORT        (1 << 11)
 #define XHCI_INTEL_HOST         (1 << 12)
+#define XHCI_SPURIOUS_REBOOT    (1 << 13)
         unsigned int            num_active_eps;
         unsigned int            limit_active_eps;
         /* There are two roothubs to keep track of bus suspend info for */
@@ -1537,6 +1538,8 @@ static inline struct usb_hcd *xhci_to_hcd(struct xhci_hcd *xhci)
         dev_err(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
 #define xhci_warn(xhci, fmt, args...) \
         dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
+#define xhci_warn_ratelimited(xhci, fmt, args...) \
+        dev_warn_ratelimited(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
 
 /* TODO: copied from ehci.h - can be refactored? */
 /* xHCI spec says all registers are little endian */