12 files changed, 428 insertions, 150 deletions

diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index f4e5cc60db0b..58b5b2cde4c5 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -55,7 +55,7 @@ config USB_DWC3_OMAP
 
 config USB_DWC3_EXYNOS
         tristate "Samsung Exynos Platform"
-        depends on ARCH_EXYNOS || COMPILE_TEST
+        depends on ARCH_EXYNOS && OF || COMPILE_TEST
         default USB_DWC3
         help
           Recent Exynos5 SoCs ship with one DesignWare Core USB3 IP inside,
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index b0f4d52b7f04..25ddc39efad8 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -19,6 +19,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <linux/version.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
@@ -32,6 +33,7 @@
 #include <linux/delay.h>
 #include <linux/dma-mapping.h>
 #include <linux/of.h>
+#include <linux/acpi.h>
 
 #include <linux/usb/ch9.h>
 #include <linux/usb/gadget.h>
@@ -363,6 +365,72 @@ static void dwc3_cache_hwparams(struct dwc3 *dwc)
 }
 
 /**
+ * dwc3_phy_setup - Configure USB PHY Interface of DWC3 Core
+ * @dwc: Pointer to our controller context structure
+ */
+static void dwc3_phy_setup(struct dwc3 *dwc)
+{
+        u32 reg;
+
+        reg = dwc3_readl(dwc->regs, DWC3_GUSB3PIPECTL(0));
+
+        /*
+         * Above 1.94a, it is recommended to set DWC3_GUSB3PIPECTL_SUSPHY
+         * to '0' during coreConsultant configuration. So default value
+         * will be '0' when the core is reset. Application needs to set it
+         * to '1' after the core initialization is completed.
+         */
+        if (dwc->revision > DWC3_REVISION_194A)
+                reg |= DWC3_GUSB3PIPECTL_SUSPHY;
+
+        if (dwc->u2ss_inp3_quirk)
+                reg |= DWC3_GUSB3PIPECTL_U2SSINP3OK;
+
+        if (dwc->req_p1p2p3_quirk)
+                reg |= DWC3_GUSB3PIPECTL_REQP1P2P3;
+
+        if (dwc->del_p1p2p3_quirk)
+                reg |= DWC3_GUSB3PIPECTL_DEP1P2P3_EN;
+
+        if (dwc->del_phy_power_chg_quirk)
+                reg |= DWC3_GUSB3PIPECTL_DEPOCHANGE;
+
+        if (dwc->lfps_filter_quirk)
+                reg |= DWC3_GUSB3PIPECTL_LFPSFILT;
+
+        if (dwc->rx_detect_poll_quirk)
+                reg |= DWC3_GUSB3PIPECTL_RX_DETOPOLL;
+
+        if (dwc->tx_de_emphasis_quirk)
+                reg |= DWC3_GUSB3PIPECTL_TX_DEEPH(dwc->tx_de_emphasis);
+
+        if (dwc->dis_u3_susphy_quirk)
+                reg &= ~DWC3_GUSB3PIPECTL_SUSPHY;
+
+        dwc3_writel(dwc->regs, DWC3_GUSB3PIPECTL(0), reg);
+
+        mdelay(100);
+
+        reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(0));
+
+        /*
+         * Above 1.94a, it is recommended to set DWC3_GUSB2PHYCFG_SUSPHY to
+         * '0' during coreConsultant configuration. So default value will
+         * be '0' when the core is reset. Application needs to set it to
+         * '1' after the core initialization is completed.
+         */
+        if (dwc->revision > DWC3_REVISION_194A)
+                reg |= DWC3_GUSB2PHYCFG_SUSPHY;
+
+        if (dwc->dis_u2_susphy_quirk)
+                reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;
+
+        dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
+
+        mdelay(100);
+}
+
+/**
  * dwc3_core_init - Low-level initialization of DWC3 Core
  * @dwc: Pointer to our controller context structure
  *
@@ -384,6 +452,12 @@ static int dwc3_core_init(struct dwc3 *dwc)
         }
         dwc->revision = reg;
 
+        /*
+         * Write Linux Version Code to our GUID register so it's easy to figure
+         * out which kernel version a bug was found.
+         */
+        dwc3_writel(dwc->regs, DWC3_GUID, LINUX_VERSION_CODE);
+
         /* Handle USB2.0-only core configuration */
         if (DWC3_GHWPARAMS3_SSPHY_IFC(dwc->hwparams.hwparams3) ==
                         DWC3_GHWPARAMS3_SSPHY_IFC_DIS) {
@@ -414,7 +488,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
 
         reg = dwc3_readl(dwc->regs, DWC3_GCTL);
         reg &= ~DWC3_GCTL_SCALEDOWN_MASK;
-        reg &= ~DWC3_GCTL_DISSCRAMBLE;
 
         switch (DWC3_GHWPARAMS1_EN_PWROPT(dwc->hwparams.hwparams1)) {
         case DWC3_GHWPARAMS1_EN_PWROPT_CLK:
@@ -441,11 +514,34 @@ static int dwc3_core_init(struct dwc3 *dwc)
         case DWC3_GHWPARAMS1_EN_PWROPT_HIB:
                 /* enable hibernation here */
                 dwc->nr_scratch = DWC3_GHWPARAMS4_HIBER_SCRATCHBUFS(hwparams4);
+
+                /*
+                 * REVISIT Enabling this bit so that host-mode hibernation
+                 * will work. Device-mode hibernation is not yet implemented.
+                 */
+                reg |= DWC3_GCTL_GBLHIBERNATIONEN;
                 break;
         default:
                 dev_dbg(dwc->dev, "No power optimization available\n");
         }
 
+        /* check if current dwc3 is on simulation board */
+        if (dwc->hwparams.hwparams6 & DWC3_GHWPARAMS6_EN_FPGA) {
+                dev_dbg(dwc->dev, "it is on FPGA board\n");
+                dwc->is_fpga = true;
+        }
+
+        WARN_ONCE(dwc->disable_scramble_quirk && !dwc->is_fpga,
+                        "disable_scramble cannot be used on non-FPGA builds\n");
+
+        if (dwc->disable_scramble_quirk && dwc->is_fpga)
+                reg |= DWC3_GCTL_DISSCRAMBLE;
+        else
+                reg &= ~DWC3_GCTL_DISSCRAMBLE;
+
+        if (dwc->u2exit_lfps_quirk)
+                reg |= DWC3_GCTL_U2EXIT_LFPS;
+
         /*
          * WORKAROUND: DWC3 revisions <1.90a have a bug
          * where the device can fail to connect at SuperSpeed
@@ -459,6 +555,8 @@ static int dwc3_core_init(struct dwc3 *dwc)
 
         dwc3_writel(dwc->regs, DWC3_GCTL, reg);
 
+        dwc3_phy_setup(dwc);
+
         ret = dwc3_alloc_scratch_buffers(dwc);
         if (ret)
                 goto err1;
@@ -630,6 +728,9 @@ static int dwc3_probe(struct platform_device *pdev)
         struct device_node      *node = dev->of_node;
         struct resource         *res;
         struct dwc3             *dwc;
+        u8                      lpm_nyet_threshold;
+        u8                      tx_de_emphasis;
+        u8                      hird_threshold;
 
         int                     ret;
 
@@ -685,22 +786,96 @@ static int dwc3_probe(struct platform_device *pdev)
          */
         res->start -= DWC3_GLOBALS_REGS_START;
 
+        /* default to highest possible threshold */
+        lpm_nyet_threshold = 0xff;
+
+        /* default to -3.5dB de-emphasis */
+        tx_de_emphasis = 1;
+
+        /*
+         * default to assert utmi_sleep_n and use maximum allowed HIRD
+         * threshold value of 0b1100
+         */
+        hird_threshold = 12;
+
         if (node) {
                 dwc->maximum_speed = of_usb_get_maximum_speed(node);
-
-                dwc->needs_fifo_resize = of_property_read_bool(node, "tx-fifo-resize");
+                dwc->has_lpm_erratum = of_property_read_bool(node,
+                                "snps,has-lpm-erratum");
+                of_property_read_u8(node, "snps,lpm-nyet-threshold",
+                                &lpm_nyet_threshold);
+                dwc->is_utmi_l1_suspend = of_property_read_bool(node,
+                                "snps,is-utmi-l1-suspend");
+                of_property_read_u8(node, "snps,hird-threshold",
+                                &hird_threshold);
+
+                dwc->needs_fifo_resize = of_property_read_bool(node,
+                                "tx-fifo-resize");
                 dwc->dr_mode = of_usb_get_dr_mode(node);
+
+                dwc->disable_scramble_quirk = of_property_read_bool(node,
+                                "snps,disable_scramble_quirk");
+                dwc->u2exit_lfps_quirk = of_property_read_bool(node,
+                                "snps,u2exit_lfps_quirk");
+                dwc->u2ss_inp3_quirk = of_property_read_bool(node,
+                                "snps,u2ss_inp3_quirk");
+                dwc->req_p1p2p3_quirk = of_property_read_bool(node,
+                                "snps,req_p1p2p3_quirk");
+                dwc->del_p1p2p3_quirk = of_property_read_bool(node,
+                                "snps,del_p1p2p3_quirk");
+                dwc->del_phy_power_chg_quirk = of_property_read_bool(node,
+                                "snps,del_phy_power_chg_quirk");
+                dwc->lfps_filter_quirk = of_property_read_bool(node,
+                                "snps,lfps_filter_quirk");
+                dwc->rx_detect_poll_quirk = of_property_read_bool(node,
+                                "snps,rx_detect_poll_quirk");
+                dwc->dis_u3_susphy_quirk = of_property_read_bool(node,
+                                "snps,dis_u3_susphy_quirk");
+                dwc->dis_u2_susphy_quirk = of_property_read_bool(node,
+                                "snps,dis_u2_susphy_quirk");
+
+                dwc->tx_de_emphasis_quirk = of_property_read_bool(node,
+                                "snps,tx_de_emphasis_quirk");
+                of_property_read_u8(node, "snps,tx_de_emphasis",
+                                &tx_de_emphasis);
         } else if (pdata) {
                 dwc->maximum_speed = pdata->maximum_speed;
+                dwc->has_lpm_erratum = pdata->has_lpm_erratum;
+                if (pdata->lpm_nyet_threshold)
+                        lpm_nyet_threshold = pdata->lpm_nyet_threshold;
+                dwc->is_utmi_l1_suspend = pdata->is_utmi_l1_suspend;
+                if (pdata->hird_threshold)
+                        hird_threshold = pdata->hird_threshold;
 
                 dwc->needs_fifo_resize = pdata->tx_fifo_resize;
                 dwc->dr_mode = pdata->dr_mode;
+
+                dwc->disable_scramble_quirk = pdata->disable_scramble_quirk;
+                dwc->u2exit_lfps_quirk = pdata->u2exit_lfps_quirk;
+                dwc->u2ss_inp3_quirk = pdata->u2ss_inp3_quirk;
+                dwc->req_p1p2p3_quirk = pdata->req_p1p2p3_quirk;
+                dwc->del_p1p2p3_quirk = pdata->del_p1p2p3_quirk;
+                dwc->del_phy_power_chg_quirk = pdata->del_phy_power_chg_quirk;
+                dwc->lfps_filter_quirk = pdata->lfps_filter_quirk;
+                dwc->rx_detect_poll_quirk = pdata->rx_detect_poll_quirk;
+                dwc->dis_u3_susphy_quirk = pdata->dis_u3_susphy_quirk;
+                dwc->dis_u2_susphy_quirk = pdata->dis_u2_susphy_quirk;
+
+                dwc->tx_de_emphasis_quirk = pdata->tx_de_emphasis_quirk;
+                if (pdata->tx_de_emphasis)
+                        tx_de_emphasis = pdata->tx_de_emphasis;
         }
 
         /* default to superspeed if no maximum_speed passed */
         if (dwc->maximum_speed == USB_SPEED_UNKNOWN)
                 dwc->maximum_speed = USB_SPEED_SUPER;
 
+        dwc->lpm_nyet_threshold = lpm_nyet_threshold;
+        dwc->tx_de_emphasis = tx_de_emphasis;
+
+        dwc->hird_threshold = hird_threshold
+                | (dwc->is_utmi_l1_suspend << 4);
+
         ret = dwc3_core_get_phy(dwc);
         if (ret)
                 return ret;
@@ -708,9 +883,11 @@ static int dwc3_probe(struct platform_device *pdev)
         spin_lock_init(&dwc->lock);
         platform_set_drvdata(pdev, dwc);
 
-        dev->dma_mask   = dev->parent->dma_mask;
-        dev->dma_parms  = dev->parent->dma_parms;
-        dma_set_coherent_mask(dev, dev->parent->coherent_dma_mask);
+        if (!dev->dma_mask) {
+                dev->dma_mask = dev->parent->dma_mask;
+                dev->dma_parms = dev->parent->dma_parms;
+                dma_set_coherent_mask(dev, dev->parent->coherent_dma_mask);
+        }
 
         pm_runtime_enable(dev);
         pm_runtime_get_sync(dev);
@@ -815,50 +992,6 @@ static int dwc3_remove(struct platform_device *pdev)
 }
 
 #ifdef CONFIG_PM_SLEEP
-static int dwc3_prepare(struct device *dev)
-{
-        struct dwc3     *dwc = dev_get_drvdata(dev);
-        unsigned long   flags;
-
-        spin_lock_irqsave(&dwc->lock, flags);
-
-        switch (dwc->dr_mode) {
-        case USB_DR_MODE_PERIPHERAL:
-        case USB_DR_MODE_OTG:
-                dwc3_gadget_prepare(dwc);
-                /* FALLTHROUGH */
-        case USB_DR_MODE_HOST:
-        default:
-                dwc3_event_buffers_cleanup(dwc);
-                break;
-        }
-
-        spin_unlock_irqrestore(&dwc->lock, flags);
-
-        return 0;
-}
-
-static void dwc3_complete(struct device *dev)
-{
-        struct dwc3     *dwc = dev_get_drvdata(dev);
-        unsigned long   flags;
-
-        spin_lock_irqsave(&dwc->lock, flags);
-
-        dwc3_event_buffers_setup(dwc);
-        switch (dwc->dr_mode) {
-        case USB_DR_MODE_PERIPHERAL:
-        case USB_DR_MODE_OTG:
-                dwc3_gadget_complete(dwc);
-                /* FALLTHROUGH */
-        case USB_DR_MODE_HOST:
-        default:
-                break;
-        }
-
-        spin_unlock_irqrestore(&dwc->lock, flags);
-}
-
 static int dwc3_suspend(struct device *dev)
 {
         struct dwc3     *dwc = dev_get_drvdata(dev);
@@ -873,7 +1006,7 @@ static int dwc3_suspend(struct device *dev)
                 /* FALLTHROUGH */
         case USB_DR_MODE_HOST:
         default:
-                /* do nothing */
+                dwc3_event_buffers_cleanup(dwc);
                 break;
         }
 
@@ -906,6 +1039,7 @@ static int dwc3_resume(struct device *dev)
 
         spin_lock_irqsave(&dwc->lock, flags);
 
+        dwc3_event_buffers_setup(dwc);
         dwc3_writel(dwc->regs, DWC3_GCTL, dwc->gctl);
 
         switch (dwc->dr_mode) {
@@ -934,9 +1068,6 @@ err_usb2phy_init:
 }
 
 static const struct dev_pm_ops dwc3_dev_pm_ops = {
-        .prepare        = dwc3_prepare,
-        .complete       = dwc3_complete,
-
         SET_SYSTEM_SLEEP_PM_OPS(dwc3_suspend, dwc3_resume)
 };
 
@@ -958,12 +1089,24 @@ static const struct of_device_id of_dwc3_match[] = {
 MODULE_DEVICE_TABLE(of, of_dwc3_match);
 #endif
 
+#ifdef CONFIG_ACPI
+
+#define ACPI_ID_INTEL_BSW       "808622B7"
+
+static const struct acpi_device_id dwc3_acpi_match[] = {
+        { ACPI_ID_INTEL_BSW, 0 },
+        { },
+};
+MODULE_DEVICE_TABLE(acpi, dwc3_acpi_match);
+#endif
+
 static struct platform_driver dwc3_driver = {
         .probe          = dwc3_probe,
         .remove         = dwc3_remove,
         .driver         = {
                 .name   = "dwc3",
                 .of_match_table = of_match_ptr(of_dwc3_match),
+                .acpi_match_table = ACPI_PTR(dwc3_acpi_match),
                 .pm     = DWC3_PM_OPS,
         },
 };
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 66f62563bcf9..4bb9aa696ede 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -166,6 +166,7 @@
 #define DWC3_GCTL_SCALEDOWN(n)          ((n) << 4)
 #define DWC3_GCTL_SCALEDOWN_MASK        DWC3_GCTL_SCALEDOWN(3)
 #define DWC3_GCTL_DISSCRAMBLE           (1 << 3)
+#define DWC3_GCTL_U2EXIT_LFPS           (1 << 2)
 #define DWC3_GCTL_GBLHIBERNATIONEN      (1 << 1)
 #define DWC3_GCTL_DSBLCLKGTNG           (1 << 0)
 
@@ -175,7 +176,17 @@
 
 /* Global USB3 PIPE Control Register */
 #define DWC3_GUSB3PIPECTL_PHYSOFTRST    (1 << 31)
+#define DWC3_GUSB3PIPECTL_U2SSINP3OK    (1 << 29)
+#define DWC3_GUSB3PIPECTL_REQP1P2P3     (1 << 24)
+#define DWC3_GUSB3PIPECTL_DEP1P2P3(n)   ((n) << 19)
+#define DWC3_GUSB3PIPECTL_DEP1P2P3_MASK DWC3_GUSB3PIPECTL_DEP1P2P3(7)
+#define DWC3_GUSB3PIPECTL_DEP1P2P3_EN   DWC3_GUSB3PIPECTL_DEP1P2P3(1)
+#define DWC3_GUSB3PIPECTL_DEPOCHANGE    (1 << 18)
 #define DWC3_GUSB3PIPECTL_SUSPHY        (1 << 17)
+#define DWC3_GUSB3PIPECTL_LFPSFILT      (1 << 9)
+#define DWC3_GUSB3PIPECTL_RX_DETOPOLL   (1 << 8)
+#define DWC3_GUSB3PIPECTL_TX_DEEPH_MASK DWC3_GUSB3PIPECTL_TX_DEEPH(3)
+#define DWC3_GUSB3PIPECTL_TX_DEEPH(n)   ((n) << 1)
 
 /* Global TX Fifo Size Register */
 #define DWC3_GTXFIFOSIZ_TXFDEF(n)       ((n) & 0xffff)
@@ -210,6 +221,9 @@
 #define DWC3_GHWPARAMS4_HIBER_SCRATCHBUFS(n)    (((n) & (0x0f << 13)) >> 13)
 #define DWC3_MAX_HIBER_SCRATCHBUFS              15
 
+/* Global HWPARAMS6 Register */
+#define DWC3_GHWPARAMS6_EN_FPGA                 (1 << 7)
+
 /* Device Configuration Register */
 #define DWC3_DCFG_DEVADDR(addr) ((addr) << 3)
 #define DWC3_DCFG_DEVADDR_MASK  DWC3_DCFG_DEVADDR(0x7f)
@@ -243,16 +257,19 @@
 #define DWC3_DCTL_TRGTULST_SS_INACT     (DWC3_DCTL_TRGTULST(6))
 
 /* These apply for core versions 1.94a and later */
-#define DWC3_DCTL_KEEP_CONNECT  (1 << 19)
-#define DWC3_DCTL_L1_HIBER_EN   (1 << 18)
-#define DWC3_DCTL_CRS           (1 << 17)
-#define DWC3_DCTL_CSS           (1 << 16)
+#define DWC3_DCTL_LPM_ERRATA_MASK       DWC3_DCTL_LPM_ERRATA(0xf)
+#define DWC3_DCTL_LPM_ERRATA(n)         ((n) << 20)
+
+#define DWC3_DCTL_KEEP_CONNECT          (1 << 19)
+#define DWC3_DCTL_L1_HIBER_EN           (1 << 18)
+#define DWC3_DCTL_CRS                   (1 << 17)
+#define DWC3_DCTL_CSS                   (1 << 16)
 
-#define DWC3_DCTL_INITU2ENA     (1 << 12)
-#define DWC3_DCTL_ACCEPTU2ENA   (1 << 11)
-#define DWC3_DCTL_INITU1ENA     (1 << 10)
-#define DWC3_DCTL_ACCEPTU1ENA   (1 << 9)
-#define DWC3_DCTL_TSTCTRL_MASK  (0xf << 1)
+#define DWC3_DCTL_INITU2ENA             (1 << 12)
+#define DWC3_DCTL_ACCEPTU2ENA           (1 << 11)
+#define DWC3_DCTL_INITU1ENA             (1 << 10)
+#define DWC3_DCTL_ACCEPTU1ENA           (1 << 9)
+#define DWC3_DCTL_TSTCTRL_MASK          (0xf << 1)
 
 #define DWC3_DCTL_ULSTCHNGREQ_MASK      (0x0f << 5)
 #define DWC3_DCTL_ULSTCHNGREQ(n) (((n) << 5) & DWC3_DCTL_ULSTCHNGREQ_MASK)
@@ -657,17 +674,41 @@ struct dwc3_scratchpad_array {
  * @regset: debugfs pointer to regdump file
  * @test_mode: true when we're entering a USB test mode
  * @test_mode_nr: test feature selector
+ * @lpm_nyet_threshold: LPM NYET response threshold
+ * @hird_threshold: HIRD threshold
  * @delayed_status: true when gadget driver asks for delayed status
  * @ep0_bounced: true when we used bounce buffer
  * @ep0_expect_in: true when we expect a DATA IN transfer
  * @has_hibernation: true when dwc3 was configured with Hibernation
+ * @has_lpm_erratum: true when core was configured with LPM Erratum. Note that
+ *                      there's now way for software to detect this in runtime.
+ * @is_utmi_l1_suspend: the core asserts output signal
+ *      0       - utmi_sleep_n
+ *      1       - utmi_l1_suspend_n
  * @is_selfpowered: true when we are selfpowered
+ * @is_fpga: true when we are using the FPGA board
  * @needs_fifo_resize: not all users might want fifo resizing, flag it
  * @pullups_connected: true when Run/Stop bit is set
  * @resize_fifos: tells us it's ok to reconfigure our TxFIFO sizes.
  * @setup_packet_pending: true when there's a Setup Packet in FIFO. Workaround
  * @start_config_issued: true when StartConfig command has been issued
  * @three_stage_setup: set if we perform a three phase setup
+ * @disable_scramble_quirk: set if we enable the disable scramble quirk
+ * @u2exit_lfps_quirk: set if we enable u2exit lfps quirk
+ * @u2ss_inp3_quirk: set if we enable P3 OK for U2/SS Inactive quirk
+ * @req_p1p2p3_quirk: set if we enable request p1p2p3 quirk
+ * @del_p1p2p3_quirk: set if we enable delay p1p2p3 quirk
+ * @del_phy_power_chg_quirk: set if we enable delay phy power change quirk
+ * @lfps_filter_quirk: set if we enable LFPS filter quirk
+ * @rx_detect_poll_quirk: set if we enable rx_detect to polling lfps quirk
+ * @dis_u3_susphy_quirk: set if we disable usb3 suspend phy
+ * @dis_u2_susphy_quirk: set if we disable usb2 suspend phy
+ * @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk
+ * @tx_de_emphasis: Tx de-emphasis value
+ *      0       - -6dB de-emphasis
+ *      1       - -3.5dB de-emphasis
+ *      2       - No de-emphasis
+ *      3       - Reserved
  */
 struct dwc3 {
         struct usb_ctrlrequest  *ctrl_req;
@@ -759,18 +800,37 @@ struct dwc3 {
 
         u8                      test_mode;
         u8                      test_mode_nr;
+        u8                      lpm_nyet_threshold;
+        u8                      hird_threshold;
 
         unsigned                delayed_status:1;
         unsigned                ep0_bounced:1;
         unsigned                ep0_expect_in:1;
         unsigned                has_hibernation:1;
+        unsigned                has_lpm_erratum:1;
+        unsigned                is_utmi_l1_suspend:1;
         unsigned                is_selfpowered:1;
+        unsigned                is_fpga:1;
         unsigned                needs_fifo_resize:1;
         unsigned                pullups_connected:1;
         unsigned                resize_fifos:1;
         unsigned                setup_packet_pending:1;
         unsigned                start_config_issued:1;
         unsigned                three_stage_setup:1;
+
+        unsigned                disable_scramble_quirk:1;
+        unsigned                u2exit_lfps_quirk:1;
+        unsigned                u2ss_inp3_quirk:1;
+        unsigned                req_p1p2p3_quirk:1;
+        unsigned                del_p1p2p3_quirk:1;
+        unsigned                del_phy_power_chg_quirk:1;
+        unsigned                lfps_filter_quirk:1;
+        unsigned                rx_detect_poll_quirk:1;
+        unsigned                dis_u3_susphy_quirk:1;
+        unsigned                dis_u2_susphy_quirk:1;
+
+        unsigned                tx_de_emphasis_quirk:1;
+        unsigned                tx_de_emphasis:2;
 };
 
 /* -------------------------------------------------------------------------- */
@@ -964,20 +1024,9 @@ static inline int dwc3_send_gadget_generic_command(struct dwc3 *dwc,
 
 /* power management interface */
 #if !IS_ENABLED(CONFIG_USB_DWC3_HOST)
-int dwc3_gadget_prepare(struct dwc3 *dwc);
-void dwc3_gadget_complete(struct dwc3 *dwc);
 int dwc3_gadget_suspend(struct dwc3 *dwc);
 int dwc3_gadget_resume(struct dwc3 *dwc);
 #else
-static inline int dwc3_gadget_prepare(struct dwc3 *dwc)
-{
-        return 0;
-}
-
-static inline void dwc3_gadget_complete(struct dwc3 *dwc)
-{
-}
-
 static inline int dwc3_gadget_suspend(struct dwc3 *dwc)
 {
         return 0;
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 3951a65fea04..7bd0a95b2815 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -20,7 +20,6 @@
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/platform_device.h>
-#include <linux/platform_data/dwc3-exynos.h>
 #include <linux/dma-mapping.h>
 #include <linux/clk.h>
 #include <linux/usb/otg.h>
@@ -35,6 +34,9 @@ struct dwc3_exynos {
         struct device           *dev;
 
         struct clk              *clk;
+        struct clk              *susp_clk;
+        struct clk              *axius_clk;
+
         struct regulator        *vdd33;
         struct regulator        *vdd10;
 };
@@ -106,7 +108,6 @@ static int dwc3_exynos_remove_child(struct device *dev, void *unused)
 static int dwc3_exynos_probe(struct platform_device *pdev)
 {
         struct dwc3_exynos      *exynos;
-        struct clk              *clk;
         struct device           *dev = &pdev->dev;
         struct device_node      *node = dev->of_node;
 
@@ -133,16 +134,32 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
                 return ret;
         }
 
-        clk = devm_clk_get(dev, "usbdrd30");
-        if (IS_ERR(clk)) {
+        exynos->dev     = dev;
+
+        exynos->clk = devm_clk_get(dev, "usbdrd30");
+        if (IS_ERR(exynos->clk)) {
                 dev_err(dev, "couldn't get clock\n");
                 return -EINVAL;
         }
+        clk_prepare_enable(exynos->clk);
 
-        exynos->dev     = dev;
-        exynos->clk     = clk;
+        exynos->susp_clk = devm_clk_get(dev, "usbdrd30_susp_clk");
+        if (IS_ERR(exynos->susp_clk)) {
+                dev_dbg(dev, "no suspend clk specified\n");
+                exynos->susp_clk = NULL;
+        }
+        clk_prepare_enable(exynos->susp_clk);
 
-        clk_prepare_enable(exynos->clk);
+        if (of_device_is_compatible(node, "samsung,exynos7-dwusb3")) {
+                exynos->axius_clk = devm_clk_get(dev, "usbdrd30_axius_clk");
+                if (IS_ERR(exynos->axius_clk)) {
+                        dev_err(dev, "no AXI UpScaler clk specified\n");
+                        return -ENODEV;
+                }
+                clk_prepare_enable(exynos->axius_clk);
+        } else {
+                exynos->axius_clk = NULL;
+        }
 
         exynos->vdd33 = devm_regulator_get(dev, "vdd33");
         if (IS_ERR(exynos->vdd33)) {
@@ -185,7 +202,9 @@ err4:
 err3:
         regulator_disable(exynos->vdd33);
 err2:
-        clk_disable_unprepare(clk);
+        clk_disable_unprepare(exynos->axius_clk);
+        clk_disable_unprepare(exynos->susp_clk);
+        clk_disable_unprepare(exynos->clk);
         return ret;
 }
 
@@ -197,6 +216,8 @@ static int dwc3_exynos_remove(struct platform_device *pdev)
         platform_device_unregister(exynos->usb2_phy);
         platform_device_unregister(exynos->usb3_phy);
 
+        clk_disable_unprepare(exynos->axius_clk);
+        clk_disable_unprepare(exynos->susp_clk);
         clk_disable_unprepare(exynos->clk);
 
         regulator_disable(exynos->vdd33);
@@ -205,19 +226,19 @@ static int dwc3_exynos_remove(struct platform_device *pdev)
         return 0;
 }
 
-#ifdef CONFIG_OF
 static const struct of_device_id exynos_dwc3_match[] = {
         { .compatible = "samsung,exynos5250-dwusb3" },
+        { .compatible = "samsung,exynos7-dwusb3" },
         {},
 };
 MODULE_DEVICE_TABLE(of, exynos_dwc3_match);
-#endif
 
 #ifdef CONFIG_PM_SLEEP
 static int dwc3_exynos_suspend(struct device *dev)
 {
         struct dwc3_exynos *exynos = dev_get_drvdata(dev);
 
+        clk_disable(exynos->axius_clk);
         clk_disable(exynos->clk);
 
         regulator_disable(exynos->vdd33);
@@ -243,6 +264,7 @@ static int dwc3_exynos_resume(struct device *dev)
         }
 
         clk_enable(exynos->clk);
+        clk_enable(exynos->axius_clk);
 
         /* runtime set active to reflect active state. */
         pm_runtime_disable(dev);
@@ -266,7 +288,7 @@ static struct platform_driver dwc3_exynos_driver = {
         .remove         = dwc3_exynos_remove,
         .driver         = {
                 .name   = "exynos-dwc3",
-                .of_match_table = of_match_ptr(exynos_dwc3_match),
+                .of_match_table = exynos_dwc3_match,
                 .pm     = DEV_PM_OPS,
         },
 };
diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
index dd8d2df6db31..fe3b9335a74e 100644
--- a/drivers/usb/dwc3/dwc3-keystone.c
+++ b/drivers/usb/dwc3/dwc3-keystone.c
@@ -123,6 +123,7 @@ static int kdwc3_probe(struct platform_device *pdev)
         irq = platform_get_irq(pdev, 0);
         if (irq < 0) {
                 dev_err(&pdev->dev, "missing irq\n");
+                error = irq;
                 goto err_irq;
         }
 
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index a0aa9f3da441..172d64e585b6 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -593,27 +593,12 @@ static const struct of_device_id of_dwc3_match[] = {
 MODULE_DEVICE_TABLE(of, of_dwc3_match);
 
 #ifdef CONFIG_PM_SLEEP
-static int dwc3_omap_prepare(struct device *dev)
-{
-        struct dwc3_omap        *omap = dev_get_drvdata(dev);
-
-        dwc3_omap_disable_irqs(omap);
-
-        return 0;
-}
-
-static void dwc3_omap_complete(struct device *dev)
-{
-        struct dwc3_omap        *omap = dev_get_drvdata(dev);
-
-        dwc3_omap_enable_irqs(omap);
-}
-
 static int dwc3_omap_suspend(struct device *dev)
 {
         struct dwc3_omap        *omap = dev_get_drvdata(dev);
 
         omap->utmi_otg_status = dwc3_omap_read_utmi_status(omap);
+        dwc3_omap_disable_irqs(omap);
 
         return 0;
 }
@@ -623,6 +608,7 @@ static int dwc3_omap_resume(struct device *dev)
         struct dwc3_omap        *omap = dev_get_drvdata(dev);
 
         dwc3_omap_write_utmi_status(omap, omap->utmi_otg_status);
+        dwc3_omap_enable_irqs(omap);
 
         pm_runtime_disable(dev);
         pm_runtime_set_active(dev);
@@ -632,8 +618,6 @@ static int dwc3_omap_resume(struct device *dev)
 }
 
 static const struct dev_pm_ops dwc3_omap_dev_pm_ops = {
-        .prepare        = dwc3_omap_prepare,
-        .complete       = dwc3_omap_complete,
 
         SET_SYSTEM_SLEEP_PM_OPS(dwc3_omap_suspend, dwc3_omap_resume)
 };
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index a36cf66302fb..7c4faf738747 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -25,6 +25,8 @@
 #include <linux/usb/otg.h>
 #include <linux/usb/usb_phy_generic.h>
 
+#include "platform_data.h"
+
 /* FIXME define these in <linux/pci_ids.h> */
 #define PCI_VENDOR_ID_SYNOPSYS          0x16c3
 #define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd
@@ -102,6 +104,9 @@ static int dwc3_pci_probe(struct pci_dev *pci,
         struct dwc3_pci         *glue;
         int                     ret;
         struct device           *dev = &pci->dev;
+        struct dwc3_platform_data dwc3_pdata;
+
+        memset(&dwc3_pdata, 0x00, sizeof(dwc3_pdata));
 
         glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);
         if (!glue)
@@ -140,6 +145,31 @@ static int dwc3_pci_probe(struct pci_dev *pci,
         res[1].name     = "dwc_usb3";
         res[1].flags    = IORESOURCE_IRQ;
 
+        if (pci->vendor == PCI_VENDOR_ID_AMD &&
+                        pci->device == PCI_DEVICE_ID_AMD_NL_USB) {
+                dwc3_pdata.has_lpm_erratum = true;
+                dwc3_pdata.lpm_nyet_threshold = 0xf;
+
+                dwc3_pdata.u2exit_lfps_quirk = true;
+                dwc3_pdata.u2ss_inp3_quirk = true;
+                dwc3_pdata.req_p1p2p3_quirk = true;
+                dwc3_pdata.del_p1p2p3_quirk = true;
+                dwc3_pdata.del_phy_power_chg_quirk = true;
+                dwc3_pdata.lfps_filter_quirk = true;
+                dwc3_pdata.rx_detect_poll_quirk = true;
+
+                dwc3_pdata.tx_de_emphasis_quirk = true;
+                dwc3_pdata.tx_de_emphasis = 1;
+
+                /*
+                 * FIXME these quirks should be removed when AMD NL
+                 * taps out
+                 */
+                dwc3_pdata.disable_scramble_quirk = true;
+                dwc3_pdata.dis_u3_susphy_quirk = true;
+                dwc3_pdata.dis_u2_susphy_quirk = true;
+        }
+
         ret = platform_device_add_resources(dwc3, res, ARRAY_SIZE(res));
         if (ret) {
                 dev_err(dev, "couldn't add resources to dwc3 device\n");
@@ -148,6 +178,10 @@ static int dwc3_pci_probe(struct pci_dev *pci,
 
         pci_set_drvdata(pci, glue);
 
+        ret = platform_device_add_data(dwc3, &dwc3_pdata, sizeof(dwc3_pdata));
+        if (ret)
+                goto err3;
+
         dma_set_coherent_mask(&dwc3->dev, dev->coherent_dma_mask);
 
         dwc3->dev.dma_mask = dev->dma_mask;
@@ -185,6 +219,7 @@ static const struct pci_device_id dwc3_pci_id_table[] = {
         { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BSW), },
         { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT), },
         { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRFLD), },
+        { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_NL_USB), },
         {  }    /* Terminating Entry */
 };
 MODULE_DEVICE_TABLE(pci, dwc3_pci_id_table);
diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index c7602b5362ad..4a1a543deeda 100644
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -243,7 +243,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
         dwc3_data->rstc_rst = devm_reset_control_get(dev, "softreset");
         if (IS_ERR(dwc3_data->rstc_rst)) {
                 dev_err(&pdev->dev, "could not get reset controller\n");
-                ret = PTR_ERR(dwc3_data->rstc_pwrdn);
+                ret = PTR_ERR(dwc3_data->rstc_rst);
                 goto undo_powerdown;
         }
 
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index 711b23019d54..baeedbd67f77 100644
--- a/drivers/usb/dwc3/ep0.c
+++ b/drivers/usb/dwc3/ep0.c
@@ -86,6 +86,8 @@ static int dwc3_ep0_start_trans(struct dwc3 *dwc, u8 epnum, dma_addr_t buf_dma,
         params.param0 = upper_32_bits(dwc->ep0_trb_addr);
         params.param1 = lower_32_bits(dwc->ep0_trb_addr);
 
+        trace_dwc3_prepare_trb(dep, trb);
+
         ret = dwc3_send_gadget_ep_cmd(dwc, dep->number,
                         DWC3_DEPCMD_STARTTRANSFER, &params);
         if (ret < 0) {
@@ -441,7 +443,6 @@ static int dwc3_ep0_handle_feature(struct dwc3 *dwc,
 
                 case USB_DEVICE_LTM_ENABLE:
                         return -EINVAL;
-                        break;
 
                 case USB_DEVICE_TEST_MODE:
                         if ((wIndex & 0xff) != 0)
@@ -550,7 +551,6 @@ static int dwc3_ep0_set_config(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl)
         switch (state) {
         case USB_STATE_DEFAULT:
                 return -EINVAL;
-                break;
 
         case USB_STATE_ADDRESS:
                 ret = dwc3_ep0_delegate_req(dwc, ctrl);
@@ -700,35 +700,35 @@ static int dwc3_ep0_std_request(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl)
 
         switch (ctrl->bRequest) {
         case USB_REQ_GET_STATUS:
-                dwc3_trace(trace_dwc3_ep0, "USB_REQ_GET_STATUS\n");
+                dwc3_trace(trace_dwc3_ep0, "USB_REQ_GET_STATUS");
                 ret = dwc3_ep0_handle_status(dwc, ctrl);
                 break;
         case USB_REQ_CLEAR_FEATURE:
-                dwc3_trace(trace_dwc3_ep0, "USB_REQ_CLEAR_FEATURE\n");
+                dwc3_trace(trace_dwc3_ep0, "USB_REQ_CLEAR_FEATURE");
                 ret = dwc3_ep0_handle_feature(dwc, ctrl, 0);
                 break;
         case USB_REQ_SET_FEATURE:
-                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_FEATURE\n");
+                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_FEATURE");
                 ret = dwc3_ep0_handle_feature(dwc, ctrl, 1);
                 break;
         case USB_REQ_SET_ADDRESS:
-                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_ADDRESS\n");
+                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_ADDRESS");
                 ret = dwc3_ep0_set_address(dwc, ctrl);
                 break;
         case USB_REQ_SET_CONFIGURATION:
-                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_CONFIGURATION\n");
+                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_CONFIGURATION");
                 ret = dwc3_ep0_set_config(dwc, ctrl);
                 break;
         case USB_REQ_SET_SEL:
-                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_SEL\n");
+                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_SEL");
                 ret = dwc3_ep0_set_sel(dwc, ctrl);
                 break;
         case USB_REQ_SET_ISOCH_DELAY:
-                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_ISOCH_DELAY\n");
+                dwc3_trace(trace_dwc3_ep0, "USB_REQ_SET_ISOCH_DELAY");
                 ret = dwc3_ep0_set_isoch_delay(dwc, ctrl);
                 break;
         default:
-                dwc3_trace(trace_dwc3_ep0, "Forwarding to gadget driver\n");
+                dwc3_trace(trace_dwc3_ep0, "Forwarding to gadget driver");
                 ret = dwc3_ep0_delegate_req(dwc, ctrl);
                 break;
         }
@@ -791,6 +791,8 @@ static void dwc3_ep0_complete_data(struct dwc3 *dwc,
 
         trb = dwc->ep0_trb;
 
+        trace_dwc3_complete_trb(ep0, trb);
+
         status = DWC3_TRB_SIZE_TRBSTS(trb->size);
         if (status == DWC3_TRBSTS_SETUP_PENDING) {
                 dwc3_trace(trace_dwc3_ep0, "Setup Pending received");
@@ -855,6 +857,8 @@ static void dwc3_ep0_complete_status(struct dwc3 *dwc,
         dep = dwc->eps[0];
         trb = dwc->ep0_trb;
 
+        trace_dwc3_complete_trb(dep, trb);
+
         if (!list_empty(&dep->request_list)) {
                 r = next_request(&dep->request_list);
 
@@ -875,7 +879,7 @@ static void dwc3_ep0_complete_status(struct dwc3 *dwc,
 
         status = DWC3_TRB_SIZE_TRBSTS(trb->size);
         if (status == DWC3_TRBSTS_SETUP_PENDING)
-                dwc3_trace(trace_dwc3_ep0, "Setup Pending received\n");
+                dwc3_trace(trace_dwc3_ep0, "Setup Pending received");
 
         dwc->ep0state = EP0_SETUP_PHASE;
         dwc3_ep0_out_start(dwc);
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 546ea5431b8c..f03b136ecfce 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1140,8 +1140,14 @@ static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request,
         if (!dep->endpoint.desc) {
                 dev_dbg(dwc->dev, "trying to queue request %p to disabled %s\n",
                                 request, ep->name);
-                spin_unlock_irqrestore(&dwc->lock, flags);
-                return -ESHUTDOWN;
+                ret = -ESHUTDOWN;
+                goto out;
+        }
+
+        if (WARN(req->dep != dep, "request %p belongs to '%s'\n",
+                                request, req->dep->name)) {
+                ret = -EINVAL;
+                goto out;
         }
 
         dev_vdbg(dwc->dev, "queing request %p to %s length %d\n",
@@ -1149,6 +1155,8 @@ static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request,
         trace_dwc3_ep_queue(req);
 
         ret = __dwc3_gadget_ep_queue(dep, req);
+
+out:
         spin_unlock_irqrestore(&dwc->lock, flags);
 
         return ret;
@@ -1622,8 +1630,7 @@ err0:
         return ret;
 }
 
-static int dwc3_gadget_stop(struct usb_gadget *g,
-                struct usb_gadget_driver *driver)
+static int dwc3_gadget_stop(struct usb_gadget *g)
 {
         struct dwc3             *dwc = gadget_to_dwc(g);
         unsigned long           flags;
@@ -2034,6 +2041,17 @@ static void dwc3_resume_gadget(struct dwc3 *dwc)
         if (dwc->gadget_driver && dwc->gadget_driver->resume) {
                 spin_unlock(&dwc->lock);
                 dwc->gadget_driver->resume(&dwc->gadget);
+        }
+}
+
+static void dwc3_reset_gadget(struct dwc3 *dwc)
+{
+        if (!dwc->gadget_driver)
+                return;
+
+        if (dwc->gadget.speed != USB_SPEED_UNKNOWN) {
+                spin_unlock(&dwc->lock);
+                usb_gadget_udc_reset(&dwc->gadget, dwc->gadget_driver);
                 spin_lock(&dwc->lock);
         }
 }
@@ -2140,6 +2158,7 @@ static void dwc3_gadget_disconnect_interrupt(struct dwc3 *dwc)
 
         dwc->gadget.speed = USB_SPEED_UNKNOWN;
         dwc->setup_packet_pending = false;
+        usb_gadget_set_state(&dwc->gadget, USB_STATE_NOTATTACHED);
 }
 
 static void dwc3_gadget_reset_interrupt(struct dwc3 *dwc)
@@ -2177,11 +2196,7 @@ static void dwc3_gadget_reset_interrupt(struct dwc3 *dwc)
                         dwc3_gadget_disconnect_interrupt(dwc);
         }
 
-        /* after reset -> Default State */
-        usb_gadget_set_state(&dwc->gadget, USB_STATE_DEFAULT);
-
-        if (dwc->gadget.speed != USB_SPEED_UNKNOWN)
-                dwc3_disconnect_gadget(dwc);
+        dwc3_reset_gadget(dwc);
 
         reg = dwc3_readl(dwc->regs, DWC3_DCTL);
         reg &= ~DWC3_DCTL_TSTCTRL_MASK;
@@ -2287,11 +2302,20 @@ static void dwc3_gadget_conndone_interrupt(struct dwc3 *dwc)
                 reg = dwc3_readl(dwc->regs, DWC3_DCTL);
                 reg &= ~(DWC3_DCTL_HIRD_THRES_MASK | DWC3_DCTL_L1_HIBER_EN);
 
+                reg |= DWC3_DCTL_HIRD_THRES(dwc->hird_threshold);
+
                 /*
-                 * TODO: This should be configurable. For now using
-                 * maximum allowed HIRD threshold value of 0b1100
+                 * When dwc3 revisions >= 2.40a, LPM Erratum is enabled and
+                 * DCFG.LPMCap is set, core responses with an ACK and the
+                 * BESL value in the LPM token is less than or equal to LPM
+                 * NYET threshold.
                  */
-                reg |= DWC3_DCTL_HIRD_THRES(12);
+                WARN_ONCE(dwc->revision < DWC3_REVISION_240A
+                                && dwc->has_lpm_erratum,
+                                "LPM Erratum not available on dwc3 revisisions < 2.40a\n");
+
+                if (dwc->has_lpm_erratum && dwc->revision >= DWC3_REVISION_240A)
+                        reg |= DWC3_DCTL_LPM_ERRATA(dwc->lpm_nyet_threshold);
 
                 dwc3_writel(dwc->regs, DWC3_DCTL, reg);
         } else {
@@ -2744,26 +2768,13 @@ void dwc3_gadget_exit(struct dwc3 *dwc)
                         dwc->ctrl_req, dwc->ctrl_req_addr);
 }
 
-int dwc3_gadget_prepare(struct dwc3 *dwc)
+int dwc3_gadget_suspend(struct dwc3 *dwc)
 {
         if (dwc->pullups_connected) {
                 dwc3_gadget_disable_irq(dwc);
                 dwc3_gadget_run_stop(dwc, true, true);
         }
 
-        return 0;
-}
-
-void dwc3_gadget_complete(struct dwc3 *dwc)
-{
-        if (dwc->pullups_connected) {
-                dwc3_gadget_enable_irq(dwc);
-                dwc3_gadget_run_stop(dwc, true, false);
-        }
-}
-
-int dwc3_gadget_suspend(struct dwc3 *dwc)
-{
         __dwc3_gadget_ep_disable(dwc->eps[0]);
         __dwc3_gadget_ep_disable(dwc->eps[1]);
 
@@ -2798,6 +2809,11 @@ int dwc3_gadget_resume(struct dwc3 *dwc)
 
         dwc3_writel(dwc->regs, DWC3_DCFG, dwc->dcfg);
 
+        if (dwc->pullups_connected) {
+                dwc3_gadget_enable_irq(dwc);
+                dwc3_gadget_run_stop(dwc, true, false);
+        }
+
         return 0;
 
 err1:
diff --git a/drivers/usb/dwc3/platform_data.h b/drivers/usb/dwc3/platform_data.h
index 7db34f00b89a..a3a3b6d5668c 100644
--- a/drivers/usb/dwc3/platform_data.h
+++ b/drivers/usb/dwc3/platform_data.h
@@ -24,4 +24,24 @@ struct dwc3_platform_data {
         enum usb_device_speed maximum_speed;
         enum usb_dr_mode dr_mode;
         bool tx_fifo_resize;
+
+        unsigned is_utmi_l1_suspend:1;
+        u8 hird_threshold;
+
+        u8 lpm_nyet_threshold;
+
+        unsigned disable_scramble_quirk:1;
+        unsigned has_lpm_erratum:1;
+        unsigned u2exit_lfps_quirk:1;
+        unsigned u2ss_inp3_quirk:1;
+        unsigned req_p1p2p3_quirk:1;
+        unsigned del_p1p2p3_quirk:1;
+        unsigned del_phy_power_chg_quirk:1;
+        unsigned lfps_filter_quirk:1;
+        unsigned rx_detect_poll_quirk:1;
+        unsigned dis_u3_susphy_quirk:1;
+        unsigned dis_u2_susphy_quirk:1;
+
+        unsigned tx_de_emphasis_quirk:1;
+        unsigned tx_de_emphasis:2;
 };
diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h
index 60b0f41eafc4..9fc20b33dd8e 100644
--- a/drivers/usb/dwc3/trace.h
+++ b/drivers/usb/dwc3/trace.h
@@ -61,7 +61,7 @@ DECLARE_EVENT_CLASS(dwc3_log_event,
         TP_fast_assign(
                 __entry->event = event;
         ),
-        TP_printk("event %08x\n", __entry->event)
+        TP_printk("event %08x", __entry->event)
 );
 
 DEFINE_EVENT(dwc3_log_event, dwc3_event,
@@ -157,7 +157,7 @@ DECLARE_EVENT_CLASS(dwc3_log_generic_cmd,
                 __entry->cmd = cmd;
                 __entry->param = param;
         ),
-        TP_printk("cmd '%s' [%d] param %08x\n",
+        TP_printk("cmd '%s' [%d] param %08x",
                 dwc3_gadget_generic_cmd_string(__entry->cmd),
                 __entry->cmd, __entry->param
         )
@@ -175,17 +175,21 @@ DECLARE_EVENT_CLASS(dwc3_log_gadget_ep_cmd,
         TP_STRUCT__entry(
                 __dynamic_array(char, name, DWC3_MSG_MAX)
                 __field(unsigned int, cmd)
-                __field(struct dwc3_gadget_ep_cmd_params *, params)
+                __field(u32, param0)
+                __field(u32, param1)
+                __field(u32, param2)
         ),
         TP_fast_assign(
                 snprintf(__get_str(name), DWC3_MSG_MAX, "%s", dep->name);
                 __entry->cmd = cmd;
-                __entry->params = params;
+                __entry->param0 = params->param0;
+                __entry->param1 = params->param1;
+                __entry->param2 = params->param2;
         ),
-        TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x\n",
+        TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x",
                 __get_str(name), dwc3_gadget_ep_cmd_string(__entry->cmd),
-                __entry->cmd, __entry->params->param0,
-                __entry->params->param1, __entry->params->param2
+                __entry->cmd, __entry->param0,
+                __entry->param1, __entry->param2
         )
 );
 
@@ -214,7 +218,7 @@ DECLARE_EVENT_CLASS(dwc3_log_trb,
                 __entry->size = trb->size;
                 __entry->ctrl = trb->ctrl;
         ),
-        TP_printk("%s: trb %p bph %08x bpl %08x size %08x ctrl %08x\n",
+        TP_printk("%s: trb %p bph %08x bpl %08x size %08x ctrl %08x",
                 __get_str(name), __entry->trb, __entry->bph, __entry->bpl,
                 __entry->size, __entry->ctrl
         )