5 files changed, 75 insertions, 60 deletions

diff --git a/drivers/parisc/dino.c b/drivers/parisc/dino.c
index d539d9df88e7..bb5a1c9597cb 100644
--- a/drivers/parisc/dino.c
+++ b/drivers/parisc/dino.c
@@ -479,7 +479,7 @@ dino_card_setup(struct pci_bus *bus, void __iomem *base_addr)
         res = &dino_dev->hba.lmmio_space;
         res->flags = IORESOURCE_MEM;
         size = scnprintf(name, sizeof(name), "Dino LMMIO (%s)", 
-                         bus->bridge->bus_id);
+                         dev_name(bus->bridge));
         res->name = kmalloc(size+1, GFP_KERNEL);
         if(res->name)
                 strcpy((char *)res->name, name);
@@ -493,7 +493,7 @@ dino_card_setup(struct pci_bus *bus, void __iomem *base_addr)
                 struct list_head *ln, *tmp_ln;
 
                 printk(KERN_ERR "Dino: cannot attach bus %s\n",
-                       bus->bridge->bus_id);
+                       dev_name(bus->bridge));
                 /* kill the bus, we can't do anything with it */
                 list_for_each_safe(ln, tmp_ln, &bus->devices) {
                         struct pci_dev *dev = pci_dev_b(ln);
@@ -587,7 +587,7 @@ dino_fixup_bus(struct pci_bus *bus)
                         bus->resource[i+1] = &res[i];
                 }
 
-        } else if(bus->self) {
+        } else if (bus->parent) {
                 int i;
 
                 pci_read_bridge_bases(bus);
@@ -611,12 +611,12 @@ dino_fixup_bus(struct pci_bus *bus)
                         }
                                         
                         DBG("DEBUG %s assigning %d [0x%lx,0x%lx]\n",
-                            bus->self->dev.bus_id, i,
+                            dev_name(&bus->self->dev), i,
                             bus->self->resource[i].start,
                             bus->self->resource[i].end);
                         pci_assign_resource(bus->self, i);
                         DBG("DEBUG %s after assign %d [0x%lx,0x%lx]\n",
-                            bus->self->dev.bus_id, i,
+                            dev_name(&bus->self->dev), i,
                             bus->self->resource[i].start,
                             bus->self->resource[i].end);
                 }
@@ -1026,7 +1026,8 @@ static int __init dino_probe(struct parisc_device *dev)
                 dino_current_bus = bus->subordinate + 1;
                 pci_bus_assign_resources(bus);
         } else {
-                printk(KERN_ERR "ERROR: failed to scan PCI bus on %s (probably duplicate bus number %d)\n", dev->dev.bus_id, dino_current_bus);
+                printk(KERN_ERR "ERROR: failed to scan PCI bus on %s (probably duplicate bus number %d)\n",
+                       dev_name(&dev->dev), dino_current_bus);
                 /* increment the bus number in case of duplicates */
                 dino_current_bus++;
         }
diff --git a/drivers/parisc/gsc.c b/drivers/parisc/gsc.c
index e76db9e4d504..d33632917696 100644
--- a/drivers/parisc/gsc.c
+++ b/drivers/parisc/gsc.c
@@ -186,29 +186,34 @@ void gsc_asic_assign_irq(struct gsc_asic *asic, int local_irq, int *irqp)
         *irqp = irq;
 }
 
-static struct device *next_device(struct klist_iter *i)
+struct gsc_fixup_struct {
+        void (*choose_irq)(struct parisc_device *, void *);
+        void *ctrl;
+};
+
+static int gsc_fixup_irqs_callback(struct device *dev, void *data)
 {
-        struct klist_node * n = klist_next(i);
-        return n ? container_of(n, struct device, knode_parent) : NULL;
+        struct parisc_device *padev = to_parisc_device(dev);
+        struct gsc_fixup_struct *gf = data;
+
+        /* work-around for 715/64 and others which have parent
+           at path [5] and children at path [5/0/x] */
+        if (padev->id.hw_type == HPHW_FAULTY)
+                gsc_fixup_irqs(padev, gf->ctrl, gf->choose_irq);
+        gf->choose_irq(padev, gf->ctrl);
+
+        return 0;
 }
 
 void gsc_fixup_irqs(struct parisc_device *parent, void *ctrl,
                         void (*choose_irq)(struct parisc_device *, void *))
 {
-        struct device *dev;
-        struct klist_iter i;
-
-        klist_iter_init(&parent->dev.klist_children, &i);
-        while ((dev = next_device(&i))) {
-                struct parisc_device *padev = to_parisc_device(dev);
-
-                /* work-around for 715/64 and others which have parent 
-                   at path [5] and children at path [5/0/x] */
-                if (padev->id.hw_type == HPHW_FAULTY)
-                        return gsc_fixup_irqs(padev, ctrl, choose_irq);
-                choose_irq(padev, ctrl);
-        }
-        klist_iter_exit(&i);
+        struct gsc_fixup_struct data = {
+                .choose_irq     = choose_irq,
+                .ctrl           = ctrl,
+        };
+
+        device_for_each_child(&parent->dev, &data, gsc_fixup_irqs_callback);
 }
 
 int gsc_common_setup(struct parisc_device *parent, struct gsc_asic *gsc_asic)
diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c
index 0797659ee016..501aaf1f253f 100644
--- a/drivers/parisc/iosapic.c
+++ b/drivers/parisc/iosapic.c
@@ -487,7 +487,7 @@ iosapic_xlate_pin(struct iosapic_info *isi, struct pci_dev *pcidev)
         }
 
         /* Check if pcidev behind a PPB */
-        if (NULL != pcidev->bus->self) {
+        if (pcidev->bus->parent) {
                 /* Convert pcidev INTR_PIN into something we
                 ** can lookup in the IRT.
                 */
@@ -523,10 +523,9 @@ iosapic_xlate_pin(struct iosapic_info *isi, struct pci_dev *pcidev)
 #endif /* PCI_BRIDGE_FUNCS */
 
                 /*
-                ** Locate the host slot the PPB nearest the Host bus
-                ** adapter.
-                */
-                while (NULL != p->parent->self)
+                 * Locate the host slot of the PPB.
+                 */
+                while (p->parent->parent)
                         p = p->parent;
 
                 intr_slot = PCI_SLOT(p->self->devfn);
@@ -709,11 +708,14 @@ static void iosapic_set_affinity_irq(unsigned int irq,
         struct vector_info *vi = iosapic_get_vector(irq);
         u32 d0, d1, dummy_d0;
         unsigned long flags;
+        int dest_cpu;
 
-        if (cpu_check_affinity(irq, dest))
+        dest_cpu = cpu_check_affinity(irq, dest);
+        if (dest_cpu < 0)
                 return;
 
-        vi->txn_addr = txn_affinity_addr(irq, cpumask_first(dest));
+        irq_desc[irq].affinity = cpumask_of_cpu(dest_cpu);
+        vi->txn_addr = txn_affinity_addr(irq, dest_cpu);
 
         spin_lock_irqsave(&iosapic_lock, flags);
         /* d1 contains the destination CPU, so only want to set that
diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
index d8233de8c75d..59fbbf128365 100644
--- a/drivers/parisc/lba_pci.c
+++ b/drivers/parisc/lba_pci.c
@@ -644,7 +644,7 @@ lba_fixup_bus(struct pci_bus *bus)
         ** Properly Setup MMIO resources for this bus.
         ** pci_alloc_primary_bus() mangles this.
         */
-        if (bus->self) {
+        if (bus->parent) {
                 int i;
                 /* PCI-PCI Bridge */
                 pci_read_bridge_bases(bus);
@@ -802,7 +802,7 @@ lba_fixup_bus(struct pci_bus *bus)
 ** Can't fixup here anyway....garr...
 */
         if (fbb_enable) {
-                if (bus->self) {
+                if (bus->parent) {
                         u8 control;
                         /* enable on PPB */
                         (void) pci_read_config_byte(bus->self, PCI_BRIDGE_CONTROL, &control);
diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
index a70cf16ee1ad..e5999c4cedc8 100644
--- a/drivers/parisc/sba_iommu.c
+++ b/drivers/parisc/sba_iommu.c
@@ -1206,30 +1206,48 @@ sba_alloc_pdir(unsigned int pdir_size)
         return (void *) pdir_base;
 }
 
-static struct device *next_device(struct klist_iter *i)
+struct ibase_data_struct {
+        struct ioc *ioc;
+        int ioc_num;
+};
+
+static int setup_ibase_imask_callback(struct device *dev, void *data)
 {
-        struct klist_node * n = klist_next(i);
-        return n ? container_of(n, struct device, knode_parent) : NULL;
+        /* lba_set_iregs() is in drivers/parisc/lba_pci.c */
+        extern void lba_set_iregs(struct parisc_device *, u32, u32);
+        struct parisc_device *lba = to_parisc_device(dev);
+        struct ibase_data_struct *ibd = data;
+        int rope_num = (lba->hpa.start >> 13) & 0xf;
+        if (rope_num >> 3 == ibd->ioc_num)
+                lba_set_iregs(lba, ibd->ioc->ibase, ibd->ioc->imask);
+        return 0;
 }
 
 /* setup Mercury or Elroy IBASE/IMASK registers. */
 static void 
 setup_ibase_imask(struct parisc_device *sba, struct ioc *ioc, int ioc_num)
 {
-        /* lba_set_iregs() is in drivers/parisc/lba_pci.c */
-        extern void lba_set_iregs(struct parisc_device *, u32, u32);
-        struct device *dev;
-        struct klist_iter i;
-
-        klist_iter_init(&sba->dev.klist_children, &i);
-        while ((dev = next_device(&i))) {
-                struct parisc_device *lba = to_parisc_device(dev);
-                int rope_num = (lba->hpa.start >> 13) & 0xf;
-                if (rope_num >> 3 == ioc_num)
-                        lba_set_iregs(lba, ioc->ibase, ioc->imask);
-        }
-        klist_iter_exit(&i);
+        struct ibase_data_struct ibase_data = {
+                .ioc            = ioc,
+                .ioc_num        = ioc_num,
+        };
+
+        device_for_each_child(&sba->dev, &ibase_data,
+                              setup_ibase_imask_callback);
+}
+
+#ifdef SBA_AGP_SUPPORT
+static int
+sba_ioc_find_quicksilver(struct device *dev, void *data)
+{
+        int *agp_found = data;
+        struct parisc_device *lba = to_parisc_device(dev);
+
+        if (IS_QUICKSILVER(lba))
+                *agp_found = 1;
+        return 0;
 }
+#endif
 
 static void
 sba_ioc_init_pluto(struct parisc_device *sba, struct ioc *ioc, int ioc_num)
@@ -1332,9 +1350,6 @@ sba_ioc_init_pluto(struct parisc_device *sba, struct ioc *ioc, int ioc_num)
         WRITE_REG(ioc->ibase | 31, ioc->ioc_hpa + IOC_PCOM);
 
 #ifdef SBA_AGP_SUPPORT
-{
-        struct klist_iter i;
-        struct device *dev = NULL;
 
         /*
         ** If an AGP device is present, only use half of the IOV space
@@ -1344,13 +1359,7 @@ sba_ioc_init_pluto(struct parisc_device *sba, struct ioc *ioc, int ioc_num)
         ** We program the next pdir index after we stop w/ a key for
         ** the GART code to handshake on.
         */
-        klist_iter_init(&sba->dev.klist_children, &i);
-        while ((dev = next_device(&i))) {
-                struct parisc_device *lba = to_parisc_device(dev);
-                if (IS_QUICKSILVER(lba))
-                        agp_found = 1;
-        }
-        klist_iter_exit(&i);
+        device_for_each_child(&sba->dev, &agp_found, sba_ioc_find_quicksilver);
 
         if (agp_found && sba_reserve_agpgart) {
                 printk(KERN_INFO "%s: reserving %dMb of IOVA space for agpgart\n",
@@ -1358,9 +1367,7 @@ sba_ioc_init_pluto(struct parisc_device *sba, struct ioc *ioc, int ioc_num)
                 ioc->pdir_size /= 2;
                 ioc->pdir_base[PDIR_INDEX(iova_space_size/2)] = SBA_AGPGART_COOKIE;
         }
-}
 #endif /*SBA_AGP_SUPPORT*/
-
 }
 
 static void