aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/net/wireless')
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-3945.c4
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-4965.c12
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-5000.c9
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-agn-hcmd-check.c20
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-agn.c34
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-core.c8
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-debug.h1
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-rfkill.c3
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-scan.c4
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-sta.c9
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-tx.c4
-rw-r--r--drivers/net/wireless/iwlwifi/iwl3945-base.c73
12 files changed, 94 insertions, 87 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
index 328e55f84d95..4a2cc78f0d73 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
@@ -158,7 +158,7 @@ void iwl3945_disable_events(struct iwl_priv *priv)
158 158
159 ret = iwl_grab_nic_access(priv); 159 ret = iwl_grab_nic_access(priv);
160 if (ret) { 160 if (ret) {
161 IWL_WARNING("Can not read from adapter at this time.\n"); 161 IWL_WARN(priv, "Can not read from adapter at this time.\n");
162 return; 162 return;
163 } 163 }
164 164
@@ -2095,7 +2095,7 @@ static void iwl3945_hw_reg_init_channel_groups(struct iwl_priv *priv)
2095 2095
2096 /* sanity check on factory saturation power value */ 2096 /* sanity check on factory saturation power value */
2097 if (group->saturation_power < 40) { 2097 if (group->saturation_power < 40) {
2098 IWL_WARNING("Error: saturation power is %d, " 2098 IWL_WARN(priv, "Error: saturation power is %d, "
2099 "less than minimum expected 40\n", 2099 "less than minimum expected 40\n",
2100 group->saturation_power); 2100 group->saturation_power);
2101 return; 2101 return;
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
index 48223627dd23..3de8d6413994 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
@@ -1485,12 +1485,12 @@ static int iwl4965_fill_txpower_tbl(struct iwl_priv *priv, u8 band, u16 channel,
1485 1485
1486 /* stay within the table! */ 1486 /* stay within the table! */
1487 if (power_index > 107) { 1487 if (power_index > 107) {
1488 IWL_WARNING("txpower index %d > 107\n", 1488 IWL_WARN(priv, "txpower index %d > 107\n",
1489 power_index); 1489 power_index);
1490 power_index = 107; 1490 power_index = 107;
1491 } 1491 }
1492 if (power_index < 0) { 1492 if (power_index < 0) {
1493 IWL_WARNING("txpower index %d < 0\n", 1493 IWL_WARN(priv, "txpower index %d < 0\n",
1494 power_index); 1494 power_index);
1495 power_index = 0; 1495 power_index = 0;
1496 } 1496 }
@@ -1533,7 +1533,7 @@ static int iwl4965_send_tx_power(struct iwl_priv *priv)
1533 /* If this gets hit a lot, switch it to a BUG() and catch 1533 /* If this gets hit a lot, switch it to a BUG() and catch
1534 * the stack trace to find out who is calling this during 1534 * the stack trace to find out who is calling this during
1535 * a scan. */ 1535 * a scan. */
1536 IWL_WARNING("TX Power requested while scanning!\n"); 1536 IWL_WARN(priv, "TX Power requested while scanning!\n");
1537 return -EAGAIN; 1537 return -EAGAIN;
1538 } 1538 }
1539 1539
@@ -1839,7 +1839,8 @@ static int iwl4965_txq_agg_disable(struct iwl_priv *priv, u16 txq_id,
1839 1839
1840 if ((IWL49_FIRST_AMPDU_QUEUE > txq_id) || 1840 if ((IWL49_FIRST_AMPDU_QUEUE > txq_id) ||
1841 (IWL49_FIRST_AMPDU_QUEUE + IWL49_NUM_AMPDU_QUEUES <= txq_id)) { 1841 (IWL49_FIRST_AMPDU_QUEUE + IWL49_NUM_AMPDU_QUEUES <= txq_id)) {
1842 IWL_WARNING("queue number out of range: %d, must be %d to %d\n", 1842 IWL_WARN(priv,
1843 "queue number out of range: %d, must be %d to %d\n",
1843 txq_id, IWL49_FIRST_AMPDU_QUEUE, 1844 txq_id, IWL49_FIRST_AMPDU_QUEUE,
1844 IWL49_FIRST_AMPDU_QUEUE + IWL49_NUM_AMPDU_QUEUES - 1); 1845 IWL49_FIRST_AMPDU_QUEUE + IWL49_NUM_AMPDU_QUEUES - 1);
1845 return -EINVAL; 1846 return -EINVAL;
@@ -1910,7 +1911,8 @@ static int iwl4965_txq_agg_enable(struct iwl_priv *priv, int txq_id,
1910 1911
1911 if ((IWL49_FIRST_AMPDU_QUEUE > txq_id) || 1912 if ((IWL49_FIRST_AMPDU_QUEUE > txq_id) ||
1912 (IWL49_FIRST_AMPDU_QUEUE + IWL49_NUM_AMPDU_QUEUES <= txq_id)) { 1913 (IWL49_FIRST_AMPDU_QUEUE + IWL49_NUM_AMPDU_QUEUES <= txq_id)) {
1913 IWL_WARNING("queue number out of range: %d, must be %d to %d\n", 1914 IWL_WARN(priv,
1915 "queue number out of range: %d, must be %d to %d\n",
1914 txq_id, IWL49_FIRST_AMPDU_QUEUE, 1916 txq_id, IWL49_FIRST_AMPDU_QUEUE,
1915 IWL49_FIRST_AMPDU_QUEUE + IWL49_NUM_AMPDU_QUEUES - 1); 1917 IWL49_FIRST_AMPDU_QUEUE + IWL49_NUM_AMPDU_QUEUES - 1);
1916 return -EINVAL; 1918 return -EINVAL;
diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c
index 338444ab003e..448bdb65bffe 100644
--- a/drivers/net/wireless/iwlwifi/iwl-5000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-5000.c
@@ -676,7 +676,8 @@ static void iwl5000_init_alive_start(struct iwl_priv *priv)
676 iwl_clear_stations_table(priv); 676 iwl_clear_stations_table(priv);
677 ret = priv->cfg->ops->lib->alive_notify(priv); 677 ret = priv->cfg->ops->lib->alive_notify(priv);
678 if (ret) { 678 if (ret) {
679 IWL_WARNING("Could not complete ALIVE transition: %d\n", ret); 679 IWL_WARN(priv,
680 "Could not complete ALIVE transition: %d\n", ret);
680 goto restart; 681 goto restart;
681 } 682 }
682 683
@@ -1012,7 +1013,8 @@ static int iwl5000_txq_agg_enable(struct iwl_priv *priv, int txq_id,
1012 1013
1013 if ((IWL50_FIRST_AMPDU_QUEUE > txq_id) || 1014 if ((IWL50_FIRST_AMPDU_QUEUE > txq_id) ||
1014 (IWL50_FIRST_AMPDU_QUEUE + IWL50_NUM_AMPDU_QUEUES <= txq_id)) { 1015 (IWL50_FIRST_AMPDU_QUEUE + IWL50_NUM_AMPDU_QUEUES <= txq_id)) {
1015 IWL_WARNING("queue number out of range: %d, must be %d to %d\n", 1016 IWL_WARN(priv,
1017 "queue number out of range: %d, must be %d to %d\n",
1016 txq_id, IWL50_FIRST_AMPDU_QUEUE, 1018 txq_id, IWL50_FIRST_AMPDU_QUEUE,
1017 IWL50_FIRST_AMPDU_QUEUE + IWL50_NUM_AMPDU_QUEUES - 1); 1019 IWL50_FIRST_AMPDU_QUEUE + IWL50_NUM_AMPDU_QUEUES - 1);
1018 return -EINVAL; 1020 return -EINVAL;
@@ -1077,7 +1079,8 @@ static int iwl5000_txq_agg_disable(struct iwl_priv *priv, u16 txq_id,
1077 1079
1078 if ((IWL50_FIRST_AMPDU_QUEUE > txq_id) || 1080 if ((IWL50_FIRST_AMPDU_QUEUE > txq_id) ||
1079 (IWL50_FIRST_AMPDU_QUEUE + IWL50_NUM_AMPDU_QUEUES <= txq_id)) { 1081 (IWL50_FIRST_AMPDU_QUEUE + IWL50_NUM_AMPDU_QUEUES <= txq_id)) {
1080 IWL_WARNING("queue number out of range: %d, must be %d to %d\n", 1082 IWL_WARN(priv,
1083 "queue number out of range: %d, must be %d to %d\n",
1081 txq_id, IWL50_FIRST_AMPDU_QUEUE, 1084 txq_id, IWL50_FIRST_AMPDU_QUEUE,
1082 IWL50_FIRST_AMPDU_QUEUE + IWL50_NUM_AMPDU_QUEUES - 1); 1085 IWL50_FIRST_AMPDU_QUEUE + IWL50_NUM_AMPDU_QUEUES - 1);
1083 return -EINVAL; 1086 return -EINVAL;
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-hcmd-check.c b/drivers/net/wireless/iwlwifi/iwl-agn-hcmd-check.c
index 392d96df0b6c..16e656a311a7 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-hcmd-check.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-hcmd-check.c
@@ -51,53 +51,53 @@ int iwl_agn_check_rxon_cmd(struct iwl_priv *priv)
51 (RXON_FLG_TGJ_NARROW_BAND_MSK | 51 (RXON_FLG_TGJ_NARROW_BAND_MSK |
52 RXON_FLG_RADAR_DETECT_MSK)); 52 RXON_FLG_RADAR_DETECT_MSK));
53 if (error) 53 if (error)
54 IWL_WARNING("check 24G fields %d | %d\n", 54 IWL_WARN(priv, "check 24G fields %d | %d\n",
55 counter++, error); 55 counter++, error);
56 } else { 56 } else {
57 error |= (rxon->flags & RXON_FLG_SHORT_SLOT_MSK) ? 57 error |= (rxon->flags & RXON_FLG_SHORT_SLOT_MSK) ?
58 0 : le32_to_cpu(RXON_FLG_SHORT_SLOT_MSK); 58 0 : le32_to_cpu(RXON_FLG_SHORT_SLOT_MSK);
59 if (error) 59 if (error)
60 IWL_WARNING("check 52 fields %d | %d\n", 60 IWL_WARN(priv, "check 52 fields %d | %d\n",
61 counter++, error); 61 counter++, error);
62 error |= le32_to_cpu(rxon->flags & RXON_FLG_CCK_MSK); 62 error |= le32_to_cpu(rxon->flags & RXON_FLG_CCK_MSK);
63 if (error) 63 if (error)
64 IWL_WARNING("check 52 CCK %d | %d\n", 64 IWL_WARN(priv, "check 52 CCK %d | %d\n",
65 counter++, error); 65 counter++, error);
66 } 66 }
67 error |= (rxon->node_addr[0] | rxon->bssid_addr[0]) & 0x1; 67 error |= (rxon->node_addr[0] | rxon->bssid_addr[0]) & 0x1;
68 if (error) 68 if (error)
69 IWL_WARNING("check mac addr %d | %d\n", counter++, error); 69 IWL_WARN(priv, "check mac addr %d | %d\n", counter++, error);
70 70
71 /* make sure basic rates 6Mbps and 1Mbps are supported */ 71 /* make sure basic rates 6Mbps and 1Mbps are supported */
72 error |= (((rxon->ofdm_basic_rates & IWL_RATE_6M_MASK) == 0) && 72 error |= (((rxon->ofdm_basic_rates & IWL_RATE_6M_MASK) == 0) &&
73 ((rxon->cck_basic_rates & IWL_RATE_1M_MASK) == 0)); 73 ((rxon->cck_basic_rates & IWL_RATE_1M_MASK) == 0));
74 if (error) 74 if (error)
75 IWL_WARNING("check basic rate %d | %d\n", counter++, error); 75 IWL_WARN(priv, "check basic rate %d | %d\n", counter++, error);
76 76
77 error |= (le16_to_cpu(rxon->assoc_id) > 2007); 77 error |= (le16_to_cpu(rxon->assoc_id) > 2007);
78 if (error) 78 if (error)
79 IWL_WARNING("check assoc id %d | %d\n", counter++, error); 79 IWL_WARN(priv, "check assoc id %d | %d\n", counter++, error);
80 80
81 error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK)) 81 error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK))
82 == (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK)); 82 == (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK));
83 if (error) 83 if (error)
84 IWL_WARNING("check CCK and short slot %d | %d\n", 84 IWL_WARN(priv, "check CCK and short slot %d | %d\n",
85 counter++, error); 85 counter++, error);
86 86
87 error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK)) 87 error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK))
88 == (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK)); 88 == (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK));
89 if (error) 89 if (error)
90 IWL_WARNING("check CCK & auto detect %d | %d\n", 90 IWL_WARN(priv, "check CCK & auto detect %d | %d\n",
91 counter++, error); 91 counter++, error);
92 92
93 error |= ((rxon->flags & (RXON_FLG_AUTO_DETECT_MSK | 93 error |= ((rxon->flags & (RXON_FLG_AUTO_DETECT_MSK |
94 RXON_FLG_TGG_PROTECT_MSK)) == RXON_FLG_TGG_PROTECT_MSK); 94 RXON_FLG_TGG_PROTECT_MSK)) == RXON_FLG_TGG_PROTECT_MSK);
95 if (error) 95 if (error)
96 IWL_WARNING("check TGG and auto detect %d | %d\n", 96 IWL_WARN(priv, "check TGG and auto detect %d | %d\n",
97 counter++, error); 97 counter++, error);
98 98
99 if (error) 99 if (error)
100 IWL_WARNING("Tuning to channel %d\n", 100 IWL_WARN(priv, "Tuning to channel %d\n",
101 le16_to_cpu(rxon->channel)); 101 le16_to_cpu(rxon->channel));
102 102
103 if (error) { 103 if (error) {
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 6e8ab2e5f3d0..ce290f6867f3 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -337,7 +337,7 @@ static void iwl_clear_free_frames(struct iwl_priv *priv)
337 } 337 }
338 338
339 if (priv->frames_count) { 339 if (priv->frames_count) {
340 IWL_WARNING("%d frames still in use. Did we lose one?\n", 340 IWL_WARN(priv, "%d frames still in use. Did we lose one?\n",
341 priv->frames_count); 341 priv->frames_count);
342 priv->frames_count = 0; 342 priv->frames_count = 0;
343 } 343 }
@@ -745,7 +745,7 @@ static int iwl_set_mode(struct iwl_priv *priv, int mode)
745 745
746 cancel_delayed_work(&priv->scan_check); 746 cancel_delayed_work(&priv->scan_check);
747 if (iwl_scan_cancel_timeout(priv, 100)) { 747 if (iwl_scan_cancel_timeout(priv, 100)) {
748 IWL_WARNING("Aborted scan still in progress after 100ms\n"); 748 IWL_WARN(priv, "Aborted scan still in progress after 100ms\n");
749 IWL_DEBUG_MAC80211("leaving - scan abort failed.\n"); 749 IWL_DEBUG_MAC80211("leaving - scan abort failed.\n");
750 return -EAGAIN; 750 return -EAGAIN;
751 } 751 }
@@ -841,7 +841,7 @@ static void iwl_rx_reply_alive(struct iwl_priv *priv,
841 queue_delayed_work(priv->workqueue, pwork, 841 queue_delayed_work(priv->workqueue, pwork,
842 msecs_to_jiffies(5)); 842 msecs_to_jiffies(5));
843 else 843 else
844 IWL_WARNING("uCode did not respond OK.\n"); 844 IWL_WARN(priv, "uCode did not respond OK.\n");
845} 845}
846 846
847static void iwl_rx_reply_error(struct iwl_priv *priv, 847static void iwl_rx_reply_error(struct iwl_priv *priv,
@@ -1193,7 +1193,7 @@ void iwl_rx_handle(struct iwl_priv *priv)
1193 if (rxb && rxb->skb) 1193 if (rxb && rxb->skb)
1194 iwl_tx_cmd_complete(priv, rxb); 1194 iwl_tx_cmd_complete(priv, rxb);
1195 else 1195 else
1196 IWL_WARNING("Claim null rxb?\n"); 1196 IWL_WARN(priv, "Claim null rxb?\n");
1197 } 1197 }
1198 1198
1199 /* For now we just don't re-use anything. We can tweak this 1199 /* For now we just don't re-use anything. We can tweak this
@@ -1457,9 +1457,9 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
1457 IWL_ERROR("Unhandled INTA bits 0x%08x\n", inta & ~handled); 1457 IWL_ERROR("Unhandled INTA bits 0x%08x\n", inta & ~handled);
1458 1458
1459 if (inta & ~CSR_INI_SET_MASK) { 1459 if (inta & ~CSR_INI_SET_MASK) {
1460 IWL_WARNING("Disabled INTA bits 0x%08x were pending\n", 1460 IWL_WARN(priv, "Disabled INTA bits 0x%08x were pending\n",
1461 inta & ~CSR_INI_SET_MASK); 1461 inta & ~CSR_INI_SET_MASK);
1462 IWL_WARNING(" with FH_INT = 0x%08x\n", inta_fh); 1462 IWL_WARN(priv, " with FH_INT = 0x%08x\n", inta_fh);
1463 } 1463 }
1464 1464
1465 /* Re-enable all interrupts */ 1465 /* Re-enable all interrupts */
@@ -1511,7 +1511,7 @@ static irqreturn_t iwl_isr(int irq, void *data)
1511 if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) { 1511 if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) {
1512 /* Hardware disappeared. It might have already raised 1512 /* Hardware disappeared. It might have already raised
1513 * an interrupt */ 1513 * an interrupt */
1514 IWL_WARNING("HARDWARE GONE?? INTA == 0x%08x\n", inta); 1514 IWL_WARN(priv, "HARDWARE GONE?? INTA == 0x%08x\n", inta);
1515 goto unplugged; 1515 goto unplugged;
1516 } 1516 }
1517 1517
@@ -1833,8 +1833,8 @@ static void iwl_alive_start(struct iwl_priv *priv)
1833 iwl_clear_stations_table(priv); 1833 iwl_clear_stations_table(priv);
1834 ret = priv->cfg->ops->lib->alive_notify(priv); 1834 ret = priv->cfg->ops->lib->alive_notify(priv);
1835 if (ret) { 1835 if (ret) {
1836 IWL_WARNING("Could not complete ALIVE transition [ntf]: %d\n", 1836 IWL_WARN(priv,
1837 ret); 1837 "Could not complete ALIVE transition [ntf]: %d\n", ret);
1838 goto restart; 1838 goto restart;
1839 } 1839 }
1840 1840
@@ -2020,7 +2020,7 @@ static int __iwl_up(struct iwl_priv *priv)
2020 int ret; 2020 int ret;
2021 2021
2022 if (test_bit(STATUS_EXIT_PENDING, &priv->status)) { 2022 if (test_bit(STATUS_EXIT_PENDING, &priv->status)) {
2023 IWL_WARNING("Exit pending; will not bring the NIC up\n"); 2023 IWL_WARN(priv, "Exit pending; will not bring the NIC up\n");
2024 return -EIO; 2024 return -EIO;
2025 } 2025 }
2026 2026
@@ -2037,7 +2037,7 @@ static int __iwl_up(struct iwl_priv *priv)
2037 2037
2038 if (iwl_is_rfkill(priv)) { 2038 if (iwl_is_rfkill(priv)) {
2039 iwl_enable_interrupts(priv); 2039 iwl_enable_interrupts(priv);
2040 IWL_WARNING("Radio disabled by %s RF Kill switch\n", 2040 IWL_WARN(priv, "Radio disabled by %s RF Kill switch\n",
2041 test_bit(STATUS_RF_KILL_HW, &priv->status) ? "HW" : "SW"); 2041 test_bit(STATUS_RF_KILL_HW, &priv->status) ? "HW" : "SW");
2042 return 0; 2042 return 0;
2043 } 2043 }
@@ -2163,7 +2163,7 @@ static void iwl_bg_rf_kill(struct work_struct *work)
2163 IWL_DEBUG_RF_KILL("Can not turn radio back on - " 2163 IWL_DEBUG_RF_KILL("Can not turn radio back on - "
2164 "disabled by SW switch\n"); 2164 "disabled by SW switch\n");
2165 else 2165 else
2166 IWL_WARNING("Radio Frequency Kill Switch is On:\n" 2166 IWL_WARN(priv, "Radio Frequency Kill Switch is On:\n"
2167 "Kill switch must be turned off for " 2167 "Kill switch must be turned off for "
2168 "wireless networking to work.\n"); 2168 "wireless networking to work.\n");
2169 } 2169 }
@@ -2267,7 +2267,7 @@ static void iwl_post_associate(struct iwl_priv *priv)
2267 ret = iwl_send_cmd_pdu(priv, REPLY_RXON_TIMING, 2267 ret = iwl_send_cmd_pdu(priv, REPLY_RXON_TIMING,
2268 sizeof(priv->rxon_timing), &priv->rxon_timing); 2268 sizeof(priv->rxon_timing), &priv->rxon_timing);
2269 if (ret) 2269 if (ret)
2270 IWL_WARNING("REPLY_RXON_TIMING failed - " 2270 IWL_WARN(priv, "REPLY_RXON_TIMING failed - "
2271 "Attempting to continue.\n"); 2271 "Attempting to continue.\n");
2272 2272
2273 priv->staging_rxon.filter_flags |= RXON_FILTER_ASSOC_MSK; 2273 priv->staging_rxon.filter_flags |= RXON_FILTER_ASSOC_MSK;
@@ -2668,7 +2668,7 @@ static void iwl_config_ap(struct iwl_priv *priv)
2668 ret = iwl_send_cmd_pdu(priv, REPLY_RXON_TIMING, 2668 ret = iwl_send_cmd_pdu(priv, REPLY_RXON_TIMING,
2669 sizeof(priv->rxon_timing), &priv->rxon_timing); 2669 sizeof(priv->rxon_timing), &priv->rxon_timing);
2670 if (ret) 2670 if (ret)
2671 IWL_WARNING("REPLY_RXON_TIMING failed - " 2671 IWL_WARN(priv, "REPLY_RXON_TIMING failed - "
2672 "Attempting to continue.\n"); 2672 "Attempting to continue.\n");
2673 2673
2674 iwl_set_rxon_chain(priv); 2674 iwl_set_rxon_chain(priv);
@@ -2774,7 +2774,7 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw,
2774 /* If there is currently a HW scan going on in the background 2774 /* If there is currently a HW scan going on in the background
2775 * then we need to cancel it else the RXON below will fail. */ 2775 * then we need to cancel it else the RXON below will fail. */
2776 if (iwl_scan_cancel_timeout(priv, 100)) { 2776 if (iwl_scan_cancel_timeout(priv, 100)) {
2777 IWL_WARNING("Aborted scan still in progress " 2777 IWL_WARN(priv, "Aborted scan still in progress "
2778 "after 100ms\n"); 2778 "after 100ms\n");
2779 IWL_DEBUG_MAC80211("leaving - scan abort failed.\n"); 2779 IWL_DEBUG_MAC80211("leaving - scan abort failed.\n");
2780 mutex_unlock(&priv->mutex); 2780 mutex_unlock(&priv->mutex);
@@ -3467,7 +3467,7 @@ static ssize_t store_flags(struct device *d,
3467 if (le32_to_cpu(priv->staging_rxon.flags) != flags) { 3467 if (le32_to_cpu(priv->staging_rxon.flags) != flags) {
3468 /* Cancel any currently running scans... */ 3468 /* Cancel any currently running scans... */
3469 if (iwl_scan_cancel_timeout(priv, 100)) 3469 if (iwl_scan_cancel_timeout(priv, 100))
3470 IWL_WARNING("Could not cancel scan.\n"); 3470 IWL_WARN(priv, "Could not cancel scan.\n");
3471 else { 3471 else {
3472 IWL_DEBUG_INFO("Commit rxon.flags = 0x%04X\n", flags); 3472 IWL_DEBUG_INFO("Commit rxon.flags = 0x%04X\n", flags);
3473 priv->staging_rxon.flags = cpu_to_le32(flags); 3473 priv->staging_rxon.flags = cpu_to_le32(flags);
@@ -3506,7 +3506,7 @@ static ssize_t store_filter_flags(struct device *d,
3506 if (le32_to_cpu(priv->staging_rxon.filter_flags) != filter_flags) { 3506 if (le32_to_cpu(priv->staging_rxon.filter_flags) != filter_flags) {
3507 /* Cancel any currently running scans... */ 3507 /* Cancel any currently running scans... */
3508 if (iwl_scan_cancel_timeout(priv, 100)) 3508 if (iwl_scan_cancel_timeout(priv, 100))
3509 IWL_WARNING("Could not cancel scan.\n"); 3509 IWL_WARN(priv, "Could not cancel scan.\n");
3510 else { 3510 else {
3511 IWL_DEBUG_INFO("Committing rxon.filter_flags = " 3511 IWL_DEBUG_INFO("Committing rxon.filter_flags = "
3512 "0x%04X\n", filter_flags); 3512 "0x%04X\n", filter_flags);
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c
index 4100b155531f..2bc461a610ad 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.c
+++ b/drivers/net/wireless/iwlwifi/iwl-core.c
@@ -924,13 +924,13 @@ int iwl_set_tx_power(struct iwl_priv *priv, s8 tx_power, bool force)
924{ 924{
925 int ret = 0; 925 int ret = 0;
926 if (tx_power < IWL_TX_POWER_TARGET_POWER_MIN) { 926 if (tx_power < IWL_TX_POWER_TARGET_POWER_MIN) {
927 IWL_WARNING("Requested user TXPOWER %d below limit.\n", 927 IWL_WARN(priv, "Requested user TXPOWER %d below limit.\n",
928 priv->tx_power_user_lmt); 928 priv->tx_power_user_lmt);
929 return -EINVAL; 929 return -EINVAL;
930 } 930 }
931 931
932 if (tx_power > IWL_TX_POWER_TARGET_POWER_MAX) { 932 if (tx_power > IWL_TX_POWER_TARGET_POWER_MAX) {
933 IWL_WARNING("Requested user TXPOWER %d above limit.\n", 933 IWL_WARN(priv, "Requested user TXPOWER %d above limit.\n",
934 priv->tx_power_user_lmt); 934 priv->tx_power_user_lmt);
935 return -EINVAL; 935 return -EINVAL;
936 } 936 }
@@ -1193,7 +1193,7 @@ void iwl_dump_nic_error_log(struct iwl_priv *priv)
1193 1193
1194 ret = iwl_grab_nic_access(priv); 1194 ret = iwl_grab_nic_access(priv);
1195 if (ret) { 1195 if (ret) {
1196 IWL_WARNING("Can not read from adapter at this time.\n"); 1196 IWL_WARN(priv, "Can not read from adapter at this time.\n");
1197 return; 1197 return;
1198 } 1198 }
1199 1199
@@ -1297,7 +1297,7 @@ void iwl_dump_nic_event_log(struct iwl_priv *priv)
1297 1297
1298 ret = iwl_grab_nic_access(priv); 1298 ret = iwl_grab_nic_access(priv);
1299 if (ret) { 1299 if (ret) {
1300 IWL_WARNING("Can not read from adapter at this time.\n"); 1300 IWL_WARN(priv, "Can not read from adapter at this time.\n");
1301 return; 1301 return;
1302 } 1302 }
1303 1303
diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.h b/drivers/net/wireless/iwlwifi/iwl-debug.h
index d593b83873e6..654dc9cdd23f 100644
--- a/drivers/net/wireless/iwlwifi/iwl-debug.h
+++ b/drivers/net/wireless/iwlwifi/iwl-debug.h
@@ -32,7 +32,6 @@
32struct iwl_priv; 32struct iwl_priv;
33 33
34#define IWL_ERROR(f, a...) dev_err(&(priv->pci_dev->dev), f, ## a) 34#define IWL_ERROR(f, a...) dev_err(&(priv->pci_dev->dev), f, ## a)
35#define IWL_WARNING(f, a...) dev_warn(&(priv->pci_dev->dev), f, ## a)
36#define IWL_ERR(p, f, a...) dev_err(&((p)->pci_dev->dev), f, ## a) 35#define IWL_ERR(p, f, a...) dev_err(&((p)->pci_dev->dev), f, ## a)
37#define IWL_WARN(p, f, a...) dev_warn(&((p)->pci_dev->dev), f, ## a) 36#define IWL_WARN(p, f, a...) dev_warn(&((p)->pci_dev->dev), f, ## a)
38#define IWL_INFO(p, f, a...) dev_info(&((p)->pci_dev->dev), f, ## a) 37#define IWL_INFO(p, f, a...) dev_info(&((p)->pci_dev->dev), f, ## a)
diff --git a/drivers/net/wireless/iwlwifi/iwl-rfkill.c b/drivers/net/wireless/iwlwifi/iwl-rfkill.c
index 4b69da30665c..cece1c563939 100644
--- a/drivers/net/wireless/iwlwifi/iwl-rfkill.c
+++ b/drivers/net/wireless/iwlwifi/iwl-rfkill.c
@@ -62,7 +62,8 @@ static int iwl_rfkill_soft_rf_kill(void *data, enum rfkill_state state)
62 iwl_radio_kill_sw_disable_radio(priv); 62 iwl_radio_kill_sw_disable_radio(priv);
63 break; 63 break;
64 default: 64 default:
65 IWL_WARNING("we received unexpected RFKILL state %d\n", state); 65 IWL_WARN(priv, "we received unexpected RFKILL state %d\n",
66 state);
66 break; 67 break;
67 } 68 }
68out_unlock: 69out_unlock:
diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index 3c803f6922ef..de55d3c5db62 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -650,7 +650,7 @@ static void iwl_bg_request_scan(struct work_struct *data)
650 mutex_lock(&priv->mutex); 650 mutex_lock(&priv->mutex);
651 651
652 if (!iwl_is_ready(priv)) { 652 if (!iwl_is_ready(priv)) {
653 IWL_WARNING("request scan called when driver not ready.\n"); 653 IWL_WARN(priv, "request scan called when driver not ready.\n");
654 goto done; 654 goto done;
655 } 655 }
656 656
@@ -773,7 +773,7 @@ static void iwl_bg_request_scan(struct work_struct *data)
773 if ((priv->hw_rev & CSR_HW_REV_TYPE_MSK) == CSR_HW_REV_TYPE_4965) 773 if ((priv->hw_rev & CSR_HW_REV_TYPE_MSK) == CSR_HW_REV_TYPE_4965)
774 rx_chain = 0x6; 774 rx_chain = 0x6;
775 } else { 775 } else {
776 IWL_WARNING("Invalid scan band count\n"); 776 IWL_WARN(priv, "Invalid scan band count\n");
777 goto done; 777 goto done;
778 } 778 }
779 779
diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c
index 412f66bac1af..41e9013c7427 100644
--- a/drivers/net/wireless/iwlwifi/iwl-sta.c
+++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
@@ -168,7 +168,7 @@ static int iwl_send_add_sta(struct iwl_priv *priv,
168 break; 168 break;
169 default: 169 default:
170 ret = -EIO; 170 ret = -EIO;
171 IWL_WARNING("REPLY_ADD_STA failed\n"); 171 IWL_WARN(priv, "REPLY_ADD_STA failed\n");
172 break; 172 break;
173 } 173 }
174 } 174 }
@@ -204,7 +204,7 @@ static void iwl_set_ht_add_station(struct iwl_priv *priv, u8 index,
204 case WLAN_HT_CAP_SM_PS_DISABLED: 204 case WLAN_HT_CAP_SM_PS_DISABLED:
205 break; 205 break;
206 default: 206 default:
207 IWL_WARNING("Invalid MIMO PS mode %d\n", mimo_ps_mode); 207 IWL_WARN(priv, "Invalid MIMO PS mode %d\n", mimo_ps_mode);
208 break; 208 break;
209 } 209 }
210 210
@@ -812,7 +812,7 @@ int iwl_remove_dynamic_key(struct iwl_priv *priv,
812 } 812 }
813 813
814 if (priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET) { 814 if (priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET) {
815 IWL_WARNING("Removing wrong key %d 0x%x\n", 815 IWL_WARN(priv, "Removing wrong key %d 0x%x\n",
816 keyconf->keyidx, key_flags); 816 keyconf->keyidx, key_flags);
817 spin_unlock_irqrestore(&priv->sta_lock, flags); 817 spin_unlock_irqrestore(&priv->sta_lock, flags);
818 return 0; 818 return 0;
@@ -1069,7 +1069,8 @@ int iwl_get_sta_id(struct iwl_priv *priv, struct ieee80211_hdr *hdr)
1069 return priv->hw_params.bcast_sta_id; 1069 return priv->hw_params.bcast_sta_id;
1070 1070
1071 default: 1071 default:
1072 IWL_WARNING("Unknown mode of operation: %d\n", priv->iw_mode); 1072 IWL_WARN(priv, "Unknown mode of operation: %d\n",
1073 priv->iw_mode);
1073 return priv->hw_params.bcast_sta_id; 1074 return priv->hw_params.bcast_sta_id;
1074 } 1075 }
1075} 1076}
diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
index 13aad392b1b5..e829e86181ec 100644
--- a/drivers/net/wireless/iwlwifi/iwl-tx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
@@ -1306,7 +1306,7 @@ int iwl_tx_agg_start(struct iwl_priv *priv, const u8 *ra, u16 tid, u16 *ssn)
1306 else 1306 else
1307 return -EINVAL; 1307 return -EINVAL;
1308 1308
1309 IWL_WARNING("%s on ra = %pM tid = %d\n", 1309 IWL_WARN(priv, "%s on ra = %pM tid = %d\n",
1310 __func__, ra, tid); 1310 __func__, ra, tid);
1311 1311
1312 sta_id = iwl_find_station(priv, ra); 1312 sta_id = iwl_find_station(priv, ra);
@@ -1369,7 +1369,7 @@ int iwl_tx_agg_stop(struct iwl_priv *priv , const u8 *ra, u16 tid)
1369 return -ENXIO; 1369 return -ENXIO;
1370 1370
1371 if (priv->stations[sta_id].tid[tid].agg.state != IWL_AGG_ON) 1371 if (priv->stations[sta_id].tid[tid].agg.state != IWL_AGG_ON)
1372 IWL_WARNING("Stopping AGG while state not IWL_AGG_ON\n"); 1372 IWL_WARN(priv, "Stopping AGG while state not IWL_AGG_ON\n");
1373 1373
1374 tid_data = &priv->stations[sta_id].tid[tid]; 1374 tid_data = &priv->stations[sta_id].tid[tid];
1375 ssn = (tid_data->seq_number & IEEE80211_SCTL_SEQ) >> 4; 1375 ssn = (tid_data->seq_number & IEEE80211_SCTL_SEQ) >> 4;
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 14864cc6775c..26f53647bf36 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -781,59 +781,59 @@ static int iwl3945_check_rxon_cmd(struct iwl_priv *priv)
781 (RXON_FLG_TGJ_NARROW_BAND_MSK | 781 (RXON_FLG_TGJ_NARROW_BAND_MSK |
782 RXON_FLG_RADAR_DETECT_MSK)); 782 RXON_FLG_RADAR_DETECT_MSK));
783 if (error) 783 if (error)
784 IWL_WARNING("check 24G fields %d | %d\n", 784 IWL_WARN(priv, "check 24G fields %d | %d\n",
785 counter++, error); 785 counter++, error);
786 } else { 786 } else {
787 error |= (rxon->flags & RXON_FLG_SHORT_SLOT_MSK) ? 787 error |= (rxon->flags & RXON_FLG_SHORT_SLOT_MSK) ?
788 0 : le32_to_cpu(RXON_FLG_SHORT_SLOT_MSK); 788 0 : le32_to_cpu(RXON_FLG_SHORT_SLOT_MSK);
789 if (error) 789 if (error)
790 IWL_WARNING("check 52 fields %d | %d\n", 790 IWL_WARN(priv, "check 52 fields %d | %d\n",
791 counter++, error); 791 counter++, error);
792 error |= le32_to_cpu(rxon->flags & RXON_FLG_CCK_MSK); 792 error |= le32_to_cpu(rxon->flags & RXON_FLG_CCK_MSK);
793 if (error) 793 if (error)
794 IWL_WARNING("check 52 CCK %d | %d\n", 794 IWL_WARN(priv, "check 52 CCK %d | %d\n",
795 counter++, error); 795 counter++, error);
796 } 796 }
797 error |= (rxon->node_addr[0] | rxon->bssid_addr[0]) & 0x1; 797 error |= (rxon->node_addr[0] | rxon->bssid_addr[0]) & 0x1;
798 if (error) 798 if (error)
799 IWL_WARNING("check mac addr %d | %d\n", counter++, error); 799 IWL_WARN(priv, "check mac addr %d | %d\n", counter++, error);
800 800
801 /* make sure basic rates 6Mbps and 1Mbps are supported */ 801 /* make sure basic rates 6Mbps and 1Mbps are supported */
802 error |= (((rxon->ofdm_basic_rates & IWL_RATE_6M_MASK) == 0) && 802 error |= (((rxon->ofdm_basic_rates & IWL_RATE_6M_MASK) == 0) &&
803 ((rxon->cck_basic_rates & IWL_RATE_1M_MASK) == 0)); 803 ((rxon->cck_basic_rates & IWL_RATE_1M_MASK) == 0));
804 if (error) 804 if (error)
805 IWL_WARNING("check basic rate %d | %d\n", counter++, error); 805 IWL_WARN(priv, "check basic rate %d | %d\n", counter++, error);
806 806
807 error |= (le16_to_cpu(rxon->assoc_id) > 2007); 807 error |= (le16_to_cpu(rxon->assoc_id) > 2007);
808 if (error) 808 if (error)
809 IWL_WARNING("check assoc id %d | %d\n", counter++, error); 809 IWL_WARN(priv, "check assoc id %d | %d\n", counter++, error);
810 810
811 error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK)) 811 error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK))
812 == (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK)); 812 == (RXON_FLG_CCK_MSK | RXON_FLG_SHORT_SLOT_MSK));
813 if (error) 813 if (error)
814 IWL_WARNING("check CCK and short slot %d | %d\n", 814 IWL_WARN(priv, "check CCK and short slot %d | %d\n",
815 counter++, error); 815 counter++, error);
816 816
817 error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK)) 817 error |= ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK))
818 == (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK)); 818 == (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK));
819 if (error) 819 if (error)
820 IWL_WARNING("check CCK & auto detect %d | %d\n", 820 IWL_WARN(priv, "check CCK & auto detect %d | %d\n",
821 counter++, error); 821 counter++, error);
822 822
823 error |= ((rxon->flags & (RXON_FLG_AUTO_DETECT_MSK | 823 error |= ((rxon->flags & (RXON_FLG_AUTO_DETECT_MSK |
824 RXON_FLG_TGG_PROTECT_MSK)) == RXON_FLG_TGG_PROTECT_MSK); 824 RXON_FLG_TGG_PROTECT_MSK)) == RXON_FLG_TGG_PROTECT_MSK);
825 if (error) 825 if (error)
826 IWL_WARNING("check TGG and auto detect %d | %d\n", 826 IWL_WARN(priv, "check TGG and auto detect %d | %d\n",
827 counter++, error); 827 counter++, error);
828 828
829 if ((rxon->flags & RXON_FLG_DIS_DIV_MSK)) 829 if ((rxon->flags & RXON_FLG_DIS_DIV_MSK))
830 error |= ((rxon->flags & (RXON_FLG_ANT_B_MSK | 830 error |= ((rxon->flags & (RXON_FLG_ANT_B_MSK |
831 RXON_FLG_ANT_A_MSK)) == 0); 831 RXON_FLG_ANT_A_MSK)) == 0);
832 if (error) 832 if (error)
833 IWL_WARNING("check antenna %d %d\n", counter++, error); 833 IWL_WARN(priv, "check antenna %d %d\n", counter++, error);
834 834
835 if (error) 835 if (error)
836 IWL_WARNING("Tuning to channel %d\n", 836 IWL_WARN(priv, "Tuning to channel %d\n",
837 le16_to_cpu(rxon->channel)); 837 le16_to_cpu(rxon->channel));
838 838
839 if (error) { 839 if (error) {
@@ -1207,7 +1207,7 @@ int iwl3945_send_add_station(struct iwl_priv *priv,
1207 break; 1207 break;
1208 default: 1208 default:
1209 rc = -EIO; 1209 rc = -EIO;
1210 IWL_WARNING("REPLY_ADD_STA failed\n"); 1210 IWL_WARN(priv, "REPLY_ADD_STA failed\n");
1211 break; 1211 break;
1212 } 1212 }
1213 } 1213 }
@@ -1289,7 +1289,7 @@ static void iwl3945_clear_free_frames(struct iwl_priv *priv)
1289 } 1289 }
1290 1290
1291 if (priv->frames_count) { 1291 if (priv->frames_count) {
1292 IWL_WARNING("%d frames still in use. Did we lose one?\n", 1292 IWL_WARN(priv, "%d frames still in use. Did we lose one?\n",
1293 priv->frames_count); 1293 priv->frames_count);
1294 priv->frames_count = 0; 1294 priv->frames_count = 0;
1295 } 1295 }
@@ -2187,7 +2187,7 @@ static int iwl3945_set_mode(struct iwl_priv *priv, int mode)
2187 2187
2188 cancel_delayed_work(&priv->scan_check); 2188 cancel_delayed_work(&priv->scan_check);
2189 if (iwl3945_scan_cancel_timeout(priv, 100)) { 2189 if (iwl3945_scan_cancel_timeout(priv, 100)) {
2190 IWL_WARNING("Aborted scan still in progress after 100ms\n"); 2190 IWL_WARN(priv, "Aborted scan still in progress after 100ms\n");
2191 IWL_DEBUG_MAC80211("leaving - scan abort failed.\n"); 2191 IWL_DEBUG_MAC80211("leaving - scan abort failed.\n");
2192 return -EAGAIN; 2192 return -EAGAIN;
2193 } 2193 }
@@ -2363,7 +2363,8 @@ static int iwl3945_get_sta_id(struct iwl_priv *priv, struct ieee80211_hdr *hdr)
2363 return priv->hw_params.bcast_sta_id; 2363 return priv->hw_params.bcast_sta_id;
2364 2364
2365 default: 2365 default:
2366 IWL_WARNING("Unknown mode of operation: %d\n", priv->iw_mode); 2366 IWL_WARN(priv, "Unknown mode of operation: %d\n",
2367 priv->iw_mode);
2367 return priv->hw_params.bcast_sta_id; 2368 return priv->hw_params.bcast_sta_id;
2368 } 2369 }
2369} 2370}
@@ -2895,7 +2896,7 @@ static void iwl3945_rx_reply_alive(struct iwl_priv *priv,
2895 queue_delayed_work(priv->workqueue, pwork, 2896 queue_delayed_work(priv->workqueue, pwork,
2896 msecs_to_jiffies(5)); 2897 msecs_to_jiffies(5));
2897 else 2898 else
2898 IWL_WARNING("uCode did not respond OK.\n"); 2899 IWL_WARN(priv, "uCode did not respond OK.\n");
2899} 2900}
2900 2901
2901static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv, 2902static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
@@ -3789,7 +3790,7 @@ static void iwl3945_rx_handle(struct iwl_priv *priv)
3789 if (rxb && rxb->skb) 3790 if (rxb && rxb->skb)
3790 iwl3945_tx_cmd_complete(priv, rxb); 3791 iwl3945_tx_cmd_complete(priv, rxb);
3791 else 3792 else
3792 IWL_WARNING("Claim null rxb?\n"); 3793 IWL_WARN(priv, "Claim null rxb?\n");
3793 } 3794 }
3794 3795
3795 /* For now we just don't re-use anything. We can tweak this 3796 /* For now we just don't re-use anything. We can tweak this
@@ -3960,7 +3961,7 @@ static void iwl3945_dump_nic_error_log(struct iwl_priv *priv)
3960 3961
3961 rc = iwl_grab_nic_access(priv); 3962 rc = iwl_grab_nic_access(priv);
3962 if (rc) { 3963 if (rc) {
3963 IWL_WARNING("Can not read from adapter at this time.\n"); 3964 IWL_WARN(priv, "Can not read from adapter at this time.\n");
3964 return; 3965 return;
3965 } 3966 }
3966 3967
@@ -4063,7 +4064,7 @@ static void iwl3945_dump_nic_event_log(struct iwl_priv *priv)
4063 4064
4064 rc = iwl_grab_nic_access(priv); 4065 rc = iwl_grab_nic_access(priv);
4065 if (rc) { 4066 if (rc) {
4066 IWL_WARNING("Can not read from adapter at this time.\n"); 4067 IWL_WARN(priv, "Can not read from adapter at this time.\n");
4067 return; 4068 return;
4068 } 4069 }
4069 4070
@@ -4270,9 +4271,9 @@ static void iwl3945_irq_tasklet(struct iwl_priv *priv)
4270 IWL_ERROR("Unhandled INTA bits 0x%08x\n", inta & ~handled); 4271 IWL_ERROR("Unhandled INTA bits 0x%08x\n", inta & ~handled);
4271 4272
4272 if (inta & ~CSR_INI_SET_MASK) { 4273 if (inta & ~CSR_INI_SET_MASK) {
4273 IWL_WARNING("Disabled INTA bits 0x%08x were pending\n", 4274 IWL_WARN(priv, "Disabled INTA bits 0x%08x were pending\n",
4274 inta & ~CSR_INI_SET_MASK); 4275 inta & ~CSR_INI_SET_MASK);
4275 IWL_WARNING(" with FH_INT = 0x%08x\n", inta_fh); 4276 IWL_WARN(priv, " with FH_INT = 0x%08x\n", inta_fh);
4276 } 4277 }
4277 4278
4278 /* Re-enable all interrupts */ 4279 /* Re-enable all interrupts */
@@ -4323,7 +4324,7 @@ static irqreturn_t iwl3945_isr(int irq, void *data)
4323 4324
4324 if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) { 4325 if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) {
4325 /* Hardware disappeared */ 4326 /* Hardware disappeared */
4326 IWL_WARNING("HARDWARE GONE?? INTA == 0x%08x\n", inta); 4327 IWL_WARN(priv, "HARDWARE GONE?? INTA == 0x%08x\n", inta);
4327 goto unplugged; 4328 goto unplugged;
4328 } 4329 }
4329 4330
@@ -4490,7 +4491,7 @@ static int iwl3945_init_channel_map(struct iwl_priv *priv)
4490 } 4491 }
4491 4492
4492 if (priv->eeprom39.version < 0x2f) { 4493 if (priv->eeprom39.version < 0x2f) {
4493 IWL_WARNING("Unsupported EEPROM version: 0x%04X\n", 4494 IWL_WARN(priv, "Unsupported EEPROM version: 0x%04X\n",
4494 priv->eeprom39.version); 4495 priv->eeprom39.version);
4495 return -EINVAL; 4496 return -EINVAL;
4496 } 4497 }
@@ -5583,7 +5584,7 @@ static void iwl3945_alive_start(struct iwl_priv *priv)
5583 5584
5584 rc = iwl_grab_nic_access(priv); 5585 rc = iwl_grab_nic_access(priv);
5585 if (rc) { 5586 if (rc) {
5586 IWL_WARNING("Can not read RFKILL status from adapter\n"); 5587 IWL_WARN(priv, "Can not read RFKILL status from adapter\n");
5587 return; 5588 return;
5588 } 5589 }
5589 5590
@@ -5783,12 +5784,12 @@ static int __iwl3945_up(struct iwl_priv *priv)
5783 int rc, i; 5784 int rc, i;
5784 5785
5785 if (test_bit(STATUS_EXIT_PENDING, &priv->status)) { 5786 if (test_bit(STATUS_EXIT_PENDING, &priv->status)) {
5786 IWL_WARNING("Exit pending; will not bring the NIC up\n"); 5787 IWL_WARN(priv, "Exit pending; will not bring the NIC up\n");
5787 return -EIO; 5788 return -EIO;
5788 } 5789 }
5789 5790
5790 if (test_bit(STATUS_RF_KILL_SW, &priv->status)) { 5791 if (test_bit(STATUS_RF_KILL_SW, &priv->status)) {
5791 IWL_WARNING("Radio disabled by SW RF kill (module " 5792 IWL_WARN(priv, "Radio disabled by SW RF kill (module "
5792 "parameter)\n"); 5793 "parameter)\n");
5793 return -ENODEV; 5794 return -ENODEV;
5794 } 5795 }
@@ -5805,7 +5806,7 @@ static int __iwl3945_up(struct iwl_priv *priv)
5805 else { 5806 else {
5806 set_bit(STATUS_RF_KILL_HW, &priv->status); 5807 set_bit(STATUS_RF_KILL_HW, &priv->status);
5807 if (!test_bit(STATUS_IN_SUSPEND, &priv->status)) { 5808 if (!test_bit(STATUS_IN_SUSPEND, &priv->status)) {
5808 IWL_WARNING("Radio disabled by HW RF Kill switch\n"); 5809 IWL_WARN(priv, "Radio disabled by HW RF Kill switch\n");
5809 return -ENODEV; 5810 return -ENODEV;
5810 } 5811 }
5811 } 5812 }
@@ -5929,7 +5930,7 @@ static void iwl3945_bg_rf_kill(struct work_struct *work)
5929 IWL_DEBUG_RF_KILL("Can not turn radio back on - " 5930 IWL_DEBUG_RF_KILL("Can not turn radio back on - "
5930 "disabled by SW switch\n"); 5931 "disabled by SW switch\n");
5931 else 5932 else
5932 IWL_WARNING("Radio Frequency Kill Switch is On:\n" 5933 IWL_WARN(priv, "Radio Frequency Kill Switch is On:\n"
5933 "Kill switch must be turned off for " 5934 "Kill switch must be turned off for "
5934 "wireless networking to work.\n"); 5935 "wireless networking to work.\n");
5935 } 5936 }
@@ -5982,7 +5983,7 @@ static void iwl3945_bg_request_scan(struct work_struct *data)
5982 mutex_lock(&priv->mutex); 5983 mutex_lock(&priv->mutex);
5983 5984
5984 if (!iwl3945_is_ready(priv)) { 5985 if (!iwl3945_is_ready(priv)) {
5985 IWL_WARNING("request scan called when driver not ready.\n"); 5986 IWL_WARN(priv, "request scan called when driver not ready.\n");
5986 goto done; 5987 goto done;
5987 } 5988 }
5988 5989
@@ -6107,7 +6108,7 @@ static void iwl3945_bg_request_scan(struct work_struct *data)
6107 scan->good_CRC_th = IWL_GOOD_CRC_TH; 6108 scan->good_CRC_th = IWL_GOOD_CRC_TH;
6108 band = IEEE80211_BAND_5GHZ; 6109 band = IEEE80211_BAND_5GHZ;
6109 } else { 6110 } else {
6110 IWL_WARNING("Invalid scan band count\n"); 6111 IWL_WARN(priv, "Invalid scan band count\n");
6111 goto done; 6112 goto done;
6112 } 6113 }
6113 6114
@@ -6228,7 +6229,7 @@ static void iwl3945_post_associate(struct iwl_priv *priv)
6228 rc = iwl3945_send_cmd_pdu(priv, REPLY_RXON_TIMING, 6229 rc = iwl3945_send_cmd_pdu(priv, REPLY_RXON_TIMING,
6229 sizeof(priv->rxon_timing), &priv->rxon_timing); 6230 sizeof(priv->rxon_timing), &priv->rxon_timing);
6230 if (rc) 6231 if (rc)
6231 IWL_WARNING("REPLY_RXON_TIMING failed - " 6232 IWL_WARN(priv, "REPLY_RXON_TIMING failed - "
6232 "Attempting to continue.\n"); 6233 "Attempting to continue.\n");
6233 6234
6234 priv->staging39_rxon.filter_flags |= RXON_FILTER_ASSOC_MSK; 6235 priv->staging39_rxon.filter_flags |= RXON_FILTER_ASSOC_MSK;
@@ -6608,7 +6609,7 @@ static void iwl3945_config_ap(struct iwl_priv *priv)
6608 rc = iwl3945_send_cmd_pdu(priv, REPLY_RXON_TIMING, 6609 rc = iwl3945_send_cmd_pdu(priv, REPLY_RXON_TIMING,
6609 sizeof(priv->rxon_timing), &priv->rxon_timing); 6610 sizeof(priv->rxon_timing), &priv->rxon_timing);
6610 if (rc) 6611 if (rc)
6611 IWL_WARNING("REPLY_RXON_TIMING failed - " 6612 IWL_WARN(priv, "REPLY_RXON_TIMING failed - "
6612 "Attempting to continue.\n"); 6613 "Attempting to continue.\n");
6613 6614
6614 /* FIXME: what should be the assoc_id for AP? */ 6615 /* FIXME: what should be the assoc_id for AP? */
@@ -6709,7 +6710,7 @@ static int iwl3945_mac_config_interface(struct ieee80211_hw *hw,
6709 /* If there is currently a HW scan going on in the background 6710 /* If there is currently a HW scan going on in the background
6710 * then we need to cancel it else the RXON below will fail. */ 6711 * then we need to cancel it else the RXON below will fail. */
6711 if (iwl3945_scan_cancel_timeout(priv, 100)) { 6712 if (iwl3945_scan_cancel_timeout(priv, 100)) {
6712 IWL_WARNING("Aborted scan still in progress " 6713 IWL_WARN(priv, "Aborted scan still in progress "
6713 "after 100ms\n"); 6714 "after 100ms\n");
6714 IWL_DEBUG_MAC80211("leaving - scan abort failed.\n"); 6715 IWL_DEBUG_MAC80211("leaving - scan abort failed.\n");
6715 mutex_unlock(&priv->mutex); 6716 mutex_unlock(&priv->mutex);
@@ -7260,7 +7261,7 @@ static ssize_t store_flags(struct device *d,
7260 if (le32_to_cpu(priv->staging39_rxon.flags) != flags) { 7261 if (le32_to_cpu(priv->staging39_rxon.flags) != flags) {
7261 /* Cancel any currently running scans... */ 7262 /* Cancel any currently running scans... */
7262 if (iwl3945_scan_cancel_timeout(priv, 100)) 7263 if (iwl3945_scan_cancel_timeout(priv, 100))
7263 IWL_WARNING("Could not cancel scan.\n"); 7264 IWL_WARN(priv, "Could not cancel scan.\n");
7264 else { 7265 else {
7265 IWL_DEBUG_INFO("Committing rxon.flags = 0x%04X\n", 7266 IWL_DEBUG_INFO("Committing rxon.flags = 0x%04X\n",
7266 flags); 7267 flags);
@@ -7295,7 +7296,7 @@ static ssize_t store_filter_flags(struct device *d,
7295 if (le32_to_cpu(priv->staging39_rxon.filter_flags) != filter_flags) { 7296 if (le32_to_cpu(priv->staging39_rxon.filter_flags) != filter_flags) {
7296 /* Cancel any currently running scans... */ 7297 /* Cancel any currently running scans... */
7297 if (iwl3945_scan_cancel_timeout(priv, 100)) 7298 if (iwl3945_scan_cancel_timeout(priv, 100))
7298 IWL_WARNING("Could not cancel scan.\n"); 7299 IWL_WARN(priv, "Could not cancel scan.\n");
7299 else { 7300 else {
7300 IWL_DEBUG_INFO("Committing rxon.filter_flags = " 7301 IWL_DEBUG_INFO("Committing rxon.filter_flags = "
7301 "0x%04X\n", filter_flags); 7302 "0x%04X\n", filter_flags);
@@ -8104,7 +8105,7 @@ static int iwl3945_rfkill_soft_rf_kill(void *data, enum rfkill_state state)
8104 iwl3945_radio_kill_sw(priv, 1); 8105 iwl3945_radio_kill_sw(priv, 1);
8105 break; 8106 break;
8106 default: 8107 default:
8107 IWL_WARNING("we received unexpected RFKILL state %d\n", state); 8108 IWL_WARN(priv, "received unexpected RFKILL state %d\n", state);
8108 break; 8109 break;
8109 } 8110 }
8110out_unlock: 8111out_unlock: