1 files changed, 53 insertions, 74 deletions

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 1cd752f9a6e1..304fe78ff60e 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -324,7 +324,7 @@ struct hso_device {
 /* Prototypes                                                                */
 /*****************************************************************************/
 /* Serial driver functions */
-static int hso_serial_tiocmset(struct tty_struct *tty, struct file *file,
+static int hso_serial_tiocmset(struct tty_struct *tty,
                                unsigned int set, unsigned int clear);
 static void ctrl_callback(struct urb *urb);
 static int put_rxbuf_data(struct urb *urb, struct hso_serial *serial);
@@ -843,16 +843,7 @@ static netdev_tx_t hso_net_start_xmit(struct sk_buff *skb,
         return NETDEV_TX_OK;
 }
 
-static void hso_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *info)
-{
-        struct hso_net *odev = netdev_priv(net);
-
-        strncpy(info->driver, driver_name, ETHTOOL_BUSINFO_LEN);
-        usb_make_path(odev->parent->usb, info->bus_info, sizeof info->bus_info);
-}
-
 static const struct ethtool_ops ops = {
-        .get_drvinfo = hso_get_drvinfo,
         .get_link = ethtool_op_get_link
 };
 
@@ -967,10 +958,6 @@ static void packetizeRx(struct hso_net *odev, unsigned char *ip_pkt,
                                 /* Packet is complete. Inject into stack. */
                                 /* We have IP packet here */
                                 odev->skb_rx_buf->protocol = cpu_to_be16(ETH_P_IP);
-                                /* don't check it */
-                                odev->skb_rx_buf->ip_summed =
-                                        CHECKSUM_UNNECESSARY;
-
                                 skb_reset_mac_header(odev->skb_rx_buf);
 
                                 /* Ship it off to the kernel */
@@ -1010,6 +997,18 @@ static void packetizeRx(struct hso_net *odev, unsigned char *ip_pkt,
         }
 }
 
+static void fix_crc_bug(struct urb *urb, __le16 max_packet_size)
+{
+        static const u8 crc_check[4] = { 0xDE, 0xAD, 0xBE, 0xEF };
+        u32 rest = urb->actual_length % le16_to_cpu(max_packet_size);
+
+        if (((rest == 5) || (rest == 6)) &&
+            !memcmp(((u8 *)urb->transfer_buffer) + urb->actual_length - 4,
+                    crc_check, 4)) {
+                urb->actual_length -= 4;
+        }
+}
+
 /* Moving data from usb to kernel (in interrupt state) */
 static void read_bulk_callback(struct urb *urb)
 {
@@ -1038,17 +1037,8 @@ static void read_bulk_callback(struct urb *urb)
                 return;
         }
 
-        if (odev->parent->port_spec & HSO_INFO_CRC_BUG) {
-                u32 rest;
-                u8 crc_check[4] = { 0xDE, 0xAD, 0xBE, 0xEF };
-                rest = urb->actual_length %
-                        le16_to_cpu(odev->in_endp->wMaxPacketSize);
-                if (((rest == 5) || (rest == 6)) &&
-                    !memcmp(((u8 *) urb->transfer_buffer) +
-                            urb->actual_length - 4, crc_check, 4)) {
-                        urb->actual_length -= 4;
-                }
-        }
+        if (odev->parent->port_spec & HSO_INFO_CRC_BUG)
+                fix_crc_bug(urb, odev->in_endp->wMaxPacketSize);
 
         /* do we even have a packet? */
         if (urb->actual_length) {
@@ -1240,18 +1230,8 @@ static void hso_std_serial_read_bulk_callback(struct urb *urb)
                 return;
 
         if (status == 0) {
-                if (serial->parent->port_spec & HSO_INFO_CRC_BUG) {
-                        u32 rest;
-                        u8 crc_check[4] = { 0xDE, 0xAD, 0xBE, 0xEF };
-                        rest =
-                            urb->actual_length %
-                            le16_to_cpu(serial->in_endp->wMaxPacketSize);
-                        if (((rest == 5) || (rest == 6)) &&
-                            !memcmp(((u8 *) urb->transfer_buffer) +
-                                    urb->actual_length - 4, crc_check, 4)) {
-                                urb->actual_length -= 4;
-                        }
-                }
+                if (serial->parent->port_spec & HSO_INFO_CRC_BUG)
+                        fix_crc_bug(urb, serial->in_endp->wMaxPacketSize);
                 /* Valid data, handle RX data */
                 spin_lock(&serial->serial_lock);
                 serial->rx_urb_filled[hso_urb_to_index(serial, urb)] = 1;
@@ -1355,7 +1335,7 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp)
 
         /* done */
         if (result)
-                hso_serial_tiocmset(tty, NULL, TIOCM_RTS | TIOCM_DTR, 0);
+                hso_serial_tiocmset(tty, TIOCM_RTS | TIOCM_DTR, 0);
 err_out:
         mutex_unlock(&serial->parent->mutex);
         return result;
@@ -1645,11 +1625,11 @@ hso_wait_modem_status(struct hso_serial *serial, unsigned long arg)
  * NB: both 1->0 and 0->1 transitions are counted except for
  *     RI where only 0->1 is counted.
  */
-static int hso_get_count(struct hso_serial *serial,
-                          struct serial_icounter_struct __user *icnt)
+static int hso_get_count(struct tty_struct *tty,
+                  struct serial_icounter_struct *icount)
 {
-        struct serial_icounter_struct icount;
         struct uart_icount cnow;
+        struct hso_serial *serial = get_serial_by_tty(tty);
         struct hso_tiocmget  *tiocmget = serial->tiocmget;
 
         memset(&icount, 0, sizeof(struct serial_icounter_struct));
@@ -1660,23 +1640,23 @@ static int hso_get_count(struct hso_serial *serial,
         memcpy(&cnow, &tiocmget->icount, sizeof(struct uart_icount));
         spin_unlock_irq(&serial->serial_lock);
 
-        icount.cts         = cnow.cts;
-        icount.dsr         = cnow.dsr;
-        icount.rng         = cnow.rng;
-        icount.dcd         = cnow.dcd;
-        icount.rx          = cnow.rx;
-        icount.tx          = cnow.tx;
-        icount.frame       = cnow.frame;
-        icount.overrun     = cnow.overrun;
-        icount.parity      = cnow.parity;
-        icount.brk         = cnow.brk;
-        icount.buf_overrun = cnow.buf_overrun;
+        icount->cts         = cnow.cts;
+        icount->dsr         = cnow.dsr;
+        icount->rng         = cnow.rng;
+        icount->dcd         = cnow.dcd;
+        icount->rx          = cnow.rx;
+        icount->tx          = cnow.tx;
+        icount->frame       = cnow.frame;
+        icount->overrun     = cnow.overrun;
+        icount->parity      = cnow.parity;
+        icount->brk         = cnow.brk;
+        icount->buf_overrun = cnow.buf_overrun;
 
-        return copy_to_user(icnt, &icount, sizeof(icount)) ? -EFAULT : 0;
+        return 0;
 }
 
 
-static int hso_serial_tiocmget(struct tty_struct *tty, struct file *file)
+static int hso_serial_tiocmget(struct tty_struct *tty)
 {
         int retval;
         struct hso_serial *serial = get_serial_by_tty(tty);
@@ -1707,7 +1687,7 @@ static int hso_serial_tiocmget(struct tty_struct *tty, struct file *file)
         return retval;
 }
 
-static int hso_serial_tiocmset(struct tty_struct *tty, struct file *file,
+static int hso_serial_tiocmset(struct tty_struct *tty,
                                unsigned int set, unsigned int clear)
 {
         int val = 0;
@@ -1750,11 +1730,10 @@ static int hso_serial_tiocmset(struct tty_struct *tty, struct file *file,
                                USB_CTRL_SET_TIMEOUT);
 }
 
-static int hso_serial_ioctl(struct tty_struct *tty, struct file *file,
+static int hso_serial_ioctl(struct tty_struct *tty,
                             unsigned int cmd, unsigned long arg)
 {
         struct hso_serial *serial =  get_serial_by_tty(tty);
-        void __user *uarg = (void __user *)arg;
         int ret = 0;
         D4("IOCTL cmd: %d, arg: %ld", cmd, arg);
 
@@ -1764,10 +1743,6 @@ static int hso_serial_ioctl(struct tty_struct *tty, struct file *file,
         case TIOCMIWAIT:
                 ret = hso_wait_modem_status(serial, arg);
                 break;
-
-        case TIOCGICOUNT:
-                ret = hso_get_count(serial, uarg);
-                break;
         default:
                 ret = -ENOIOCTLCMD;
                 break;
@@ -2446,10 +2421,8 @@ static void hso_free_net_device(struct hso_device *hso_dev)
 
         remove_net_device(hso_net->parent);
 
-        if (hso_net->net) {
+        if (hso_net->net)
                 unregister_netdev(hso_net->net);
-                free_netdev(hso_net->net);
-        }
 
         /* start freeing */
         for (i = 0; i < MUX_BULK_RX_BUF_COUNT; i++) {
@@ -2461,6 +2434,9 @@ static void hso_free_net_device(struct hso_device *hso_dev)
         kfree(hso_net->mux_bulk_tx_buf);
         hso_net->mux_bulk_tx_buf = NULL;
 
+        if (hso_net->net)
+                free_netdev(hso_net->net);
+
         kfree(hso_dev);
 }
 
@@ -2653,15 +2629,15 @@ exit:
 
 static void hso_free_tiomget(struct hso_serial *serial)
 {
-        struct hso_tiocmget *tiocmget = serial->tiocmget;
+        struct hso_tiocmget *tiocmget;
+        if (!serial)
+                return;
+        tiocmget = serial->tiocmget;
         if (tiocmget) {
-                if (tiocmget->urb) {
-                        usb_free_urb(tiocmget->urb);
-                        tiocmget->urb = NULL;
-                }
+                usb_free_urb(tiocmget->urb);
+                tiocmget->urb = NULL;
                 serial->tiocmget = NULL;
                 kfree(tiocmget);
-
         }
 }
 
@@ -3007,12 +2983,14 @@ static int hso_probe(struct usb_interface *interface,
 
         case HSO_INTF_BULK:
                 /* It's a regular bulk interface */
-                if (((port_spec & HSO_PORT_MASK) == HSO_PORT_NETWORK) &&
-                    !disable_net)
-                        hso_dev = hso_create_net_device(interface, port_spec);
-                else
+                if ((port_spec & HSO_PORT_MASK) == HSO_PORT_NETWORK) {
+                        if (!disable_net)
+                                hso_dev =
+                                    hso_create_net_device(interface, port_spec);
+                } else {
                         hso_dev =
                             hso_create_bulk_serial_device(interface, port_spec);
+                }
                 if (!hso_dev)
                         goto exit;
                 break;
@@ -3300,6 +3278,7 @@ static const struct tty_operations hso_serial_ops = {
         .chars_in_buffer = hso_serial_chars_in_buffer,
         .tiocmget = hso_serial_tiocmget,
         .tiocmset = hso_serial_tiocmset,
+        .get_icount = hso_get_count,
         .unthrottle = hso_unthrottle
 };