1 files changed, 76 insertions, 44 deletions

diff --git a/drivers/net/jme.c b/drivers/net/jme.c
index 1d2a32544ed2..b705ad3a53a7 100644
--- a/drivers/net/jme.c
+++ b/drivers/net/jme.c
@@ -37,6 +37,7 @@
 #include <linux/tcp.h>
 #include <linux/udp.h>
 #include <linux/if_vlan.h>
+#include <linux/slab.h>
 #include <net/ip6_checksum.h>
 #include "jme.h"
 
@@ -288,7 +289,7 @@ jme_set_rx_pcc(struct jme_adapter *jme, int p)
         wmb();
 
         if (!(test_bit(JME_FLAG_POLL, &jme->flags)))
-                msg_rx_status(jme, "Switched to PCC_P%d\n", p);
+                netif_info(jme, rx_status, jme->dev, "Switched to PCC_P%d\n", p);
 }
 
 static void
@@ -483,13 +484,13 @@ jme_check_link(struct net_device *netdev, int testonly)
                 strcat(linkmsg, (phylink & PHY_LINK_MDI_STAT) ?
                                         "MDI-X" :
                                         "MDI");
-                msg_link(jme, "Link is up at %s.\n", linkmsg);
+                netif_info(jme, link, jme->dev, "Link is up at %s.\n", linkmsg);
                 netif_carrier_on(netdev);
         } else {
                 if (testonly)
                         goto out;
 
-                msg_link(jme, "Link is down.\n");
+                netif_info(jme, link, jme->dev, "Link is down.\n");
                 jme->phylink = 0;
                 netif_carrier_off(netdev);
         }
@@ -883,20 +884,20 @@ jme_rxsum_ok(struct jme_adapter *jme, u16 flags)
         if (unlikely((flags & (RXWBFLAG_MF | RXWBFLAG_TCPON | RXWBFLAG_TCPCS))
                         == RXWBFLAG_TCPON)) {
                 if (flags & RXWBFLAG_IPV4)
-                        msg_rx_err(jme, "TCP Checksum error\n");
+                        netif_err(jme, rx_err, jme->dev, "TCP Checksum error\n");
                 return false;
         }
 
         if (unlikely((flags & (RXWBFLAG_MF | RXWBFLAG_UDPON | RXWBFLAG_UDPCS))
                         == RXWBFLAG_UDPON)) {
                 if (flags & RXWBFLAG_IPV4)
-                        msg_rx_err(jme, "UDP Checksum error.\n");
+                        netif_err(jme, rx_err, jme->dev, "UDP Checksum error.\n");
                 return false;
         }
 
         if (unlikely((flags & (RXWBFLAG_IPV4 | RXWBFLAG_IPCS))
                         == RXWBFLAG_IPV4)) {
-                msg_rx_err(jme, "IPv4 Checksum error.\n");
+                netif_err(jme, rx_err, jme->dev, "IPv4 Checksum error.\n");
                 return false;
         }
 
@@ -946,6 +947,8 @@ jme_alloc_and_feed_skb(struct jme_adapter *jme, int idx)
                                 jme->jme_vlan_rx(skb, jme->vlgrp,
                                         le16_to_cpu(rxdesc->descwb.vlan));
                                 NET_STAT(jme).rx_bytes += 4;
+                        } else {
+                                dev_kfree_skb(skb);
                         }
                 } else {
                         jme->jme_rx(skb);
@@ -1050,8 +1053,8 @@ jme_dynamic_pcc(struct jme_adapter *jme)
 
         if ((NET_STAT(jme).rx_bytes - dpi->last_bytes) > PCC_P3_THRESHOLD)
                 jme_attempt_pcc(dpi, PCC_P3);
-        else if ((NET_STAT(jme).rx_packets - dpi->last_pkts) > PCC_P2_THRESHOLD
-        || dpi->intr_cnt > PCC_INTR_THRESHOLD)
+        else if ((NET_STAT(jme).rx_packets - dpi->last_pkts) > PCC_P2_THRESHOLD ||
+                 dpi->intr_cnt > PCC_INTR_THRESHOLD)
                 jme_attempt_pcc(dpi, PCC_P2);
         else
                 jme_attempt_pcc(dpi, PCC_P1);
@@ -1186,9 +1189,9 @@ jme_link_change_tasklet(unsigned long arg)
 
         while (!atomic_dec_and_test(&jme->link_changing)) {
                 atomic_inc(&jme->link_changing);
-                msg_intr(jme, "Get link change lock failed.\n");
+                netif_info(jme, intr, jme->dev, "Get link change lock failed.\n");
                 while (atomic_read(&jme->link_changing) != 1)
-                        msg_intr(jme, "Waiting link change lock.\n");
+                        netif_info(jme, intr, jme->dev, "Waiting link change lock.\n");
         }
 
         if (jme_check_link(netdev, 1) && jme->old_mtu == netdev->mtu)
@@ -1305,7 +1308,7 @@ jme_rx_empty_tasklet(unsigned long arg)
         if (unlikely(!netif_carrier_ok(jme->dev)))
                 return;
 
-        msg_rx_status(jme, "RX Queue Full!\n");
+        netif_info(jme, rx_status, jme->dev, "RX Queue Full!\n");
 
         jme_rx_clean_tasklet(arg);
 
@@ -1325,7 +1328,7 @@ jme_wake_queue_if_stopped(struct jme_adapter *jme)
         smp_wmb();
         if (unlikely(netif_queue_stopped(jme->dev) &&
         atomic_read(&txring->nr_free) >= (jme->tx_wake_threshold))) {
-                msg_tx_done(jme, "TX Queue Waked.\n");
+                netif_info(jme, tx_done, jme->dev, "TX Queue Waked.\n");
                 netif_wake_queue(jme->dev);
         }
 
@@ -1835,7 +1838,7 @@ jme_tx_csum(struct jme_adapter *jme, struct sk_buff *skb, u8 *flags)
                         *flags |= TXFLAG_UDPCS;
                         break;
                 default:
-                        msg_tx_err(jme, "Error upper layer protocol.\n");
+                        netif_err(jme, tx_err, jme->dev, "Error upper layer protocol.\n");
                         break;
                 }
         }
@@ -1910,12 +1913,12 @@ jme_stop_queue_if_full(struct jme_adapter *jme)
         smp_wmb();
         if (unlikely(atomic_read(&txring->nr_free) < (MAX_SKB_FRAGS+2))) {
                 netif_stop_queue(jme->dev);
-                msg_tx_queued(jme, "TX Queue Paused.\n");
+                netif_info(jme, tx_queued, jme->dev, "TX Queue Paused.\n");
                 smp_wmb();
                 if (atomic_read(&txring->nr_free)
                         >= (jme->tx_wake_threshold)) {
                         netif_wake_queue(jme->dev);
-                        msg_tx_queued(jme, "TX Queue Fast Waked.\n");
+                        netif_info(jme, tx_queued, jme->dev, "TX Queue Fast Waked.\n");
                 }
         }
 
@@ -1923,7 +1926,7 @@ jme_stop_queue_if_full(struct jme_adapter *jme)
                         (jiffies - txbi->start_xmit) >= TX_TIMEOUT &&
                         txbi->skb)) {
                 netif_stop_queue(jme->dev);
-                msg_tx_queued(jme, "TX Queue Stopped %d@%lu.\n", idx, jiffies);
+                netif_info(jme, tx_queued, jme->dev, "TX Queue Stopped %d@%lu.\n", idx, jiffies);
         }
 }
 
@@ -1946,7 +1949,7 @@ jme_start_xmit(struct sk_buff *skb, struct net_device *netdev)
 
         if (unlikely(idx < 0)) {
                 netif_stop_queue(netdev);
-                msg_tx_err(jme, "BUG! Tx ring full when queue awake!\n");
+                netif_err(jme, tx_err, jme->dev, "BUG! Tx ring full when queue awake!\n");
 
                 return NETDEV_TX_BUSY;
         }
@@ -1997,7 +2000,6 @@ jme_set_multi(struct net_device *netdev)
 {
         struct jme_adapter *jme = netdev_priv(netdev);
         u32 mc_hash[2] = {};
-        int i;
 
         spin_lock_bh(&jme->rxmcs_lock);
 
@@ -2012,10 +2014,7 @@ jme_set_multi(struct net_device *netdev)
                 int bit_nr;
 
                 jme->reg_rxmcs |= RXMCS_MULFRAME | RXMCS_MULFILTERED;
-                for (i = 0, mclist = netdev->mc_list;
-                        mclist && i < netdev->mc_count;
-                        ++i, mclist = mclist->next) {
-
+                netdev_for_each_mc_addr(mclist, netdev) {
                         bit_nr = ether_crc(ETH_ALEN, mclist->dmi_addr) & 0x3F;
                         mc_hash[bit_nr >> 5] |= 1 << (bit_nr & 0x1F);
                 }
@@ -2085,12 +2084,45 @@ jme_tx_timeout(struct net_device *netdev)
         jme_reset_link(jme);
 }
 
+static inline void jme_pause_rx(struct jme_adapter *jme)
+{
+        atomic_dec(&jme->link_changing);
+
+        jme_set_rx_pcc(jme, PCC_OFF);
+        if (test_bit(JME_FLAG_POLL, &jme->flags)) {
+                JME_NAPI_DISABLE(jme);
+        } else {
+                tasklet_disable(&jme->rxclean_task);
+                tasklet_disable(&jme->rxempty_task);
+        }
+}
+
+static inline void jme_resume_rx(struct jme_adapter *jme)
+{
+        struct dynpcc_info *dpi = &(jme->dpi);
+
+        if (test_bit(JME_FLAG_POLL, &jme->flags)) {
+                JME_NAPI_ENABLE(jme);
+        } else {
+                tasklet_hi_enable(&jme->rxclean_task);
+                tasklet_hi_enable(&jme->rxempty_task);
+        }
+        dpi->cur                = PCC_P1;
+        dpi->attempt            = PCC_P1;
+        dpi->cnt                = 0;
+        jme_set_rx_pcc(jme, PCC_P1);
+
+        atomic_inc(&jme->link_changing);
+}
+
 static void
 jme_vlan_rx_register(struct net_device *netdev, struct vlan_group *grp)
 {
         struct jme_adapter *jme = netdev_priv(netdev);
 
+        jme_pause_rx(jme);
         jme->vlgrp = grp;
+        jme_resume_rx(jme);
 }
 
 static void
@@ -2199,8 +2231,8 @@ jme_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *ecmd)
         if (netif_running(netdev))
                 return -EBUSY;
 
-        if (ecmd->use_adaptive_rx_coalesce
-        && test_bit(JME_FLAG_POLL, &jme->flags)) {
+        if (ecmd->use_adaptive_rx_coalesce &&
+            test_bit(JME_FLAG_POLL, &jme->flags)) {
                 clear_bit(JME_FLAG_POLL, &jme->flags);
                 jme->jme_rx = netif_rx;
                 jme->jme_vlan_rx = vlan_hwaccel_rx;
@@ -2209,8 +2241,8 @@ jme_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *ecmd)
                 dpi->cnt                = 0;
                 jme_set_rx_pcc(jme, PCC_P1);
                 jme_interrupt_mode(jme);
-        } else if (!(ecmd->use_adaptive_rx_coalesce)
-        && !(test_bit(JME_FLAG_POLL, &jme->flags))) {
+        } else if (!(ecmd->use_adaptive_rx_coalesce) &&
+                   !(test_bit(JME_FLAG_POLL, &jme->flags))) {
                 set_bit(JME_FLAG_POLL, &jme->flags);
                 jme->jme_rx = netif_receive_skb;
                 jme->jme_vlan_rx = vlan_hwaccel_receive_skb;
@@ -2473,7 +2505,7 @@ jme_smb_read(struct jme_adapter *jme, unsigned int addr)
                 val = jread32(jme, JME_SMBCSR);
         }
         if (!to) {
-                msg_hw(jme, "SMB Bus Busy.\n");
+                netif_err(jme, hw, jme->dev, "SMB Bus Busy.\n");
                 return 0xFF;
         }
 
@@ -2489,7 +2521,7 @@ jme_smb_read(struct jme_adapter *jme, unsigned int addr)
                 val = jread32(jme, JME_SMBINTF);
         }
         if (!to) {
-                msg_hw(jme, "SMB Bus Busy.\n");
+                netif_err(jme, hw, jme->dev, "SMB Bus Busy.\n");
                 return 0xFF;
         }
 
@@ -2509,7 +2541,7 @@ jme_smb_write(struct jme_adapter *jme, unsigned int addr, u8 data)
                 val = jread32(jme, JME_SMBCSR);
         }
         if (!to) {
-                msg_hw(jme, "SMB Bus Busy.\n");
+                netif_err(jme, hw, jme->dev, "SMB Bus Busy.\n");
                 return;
         }
 
@@ -2526,7 +2558,7 @@ jme_smb_write(struct jme_adapter *jme, unsigned int addr, u8 data)
                 val = jread32(jme, JME_SMBINTF);
         }
         if (!to) {
-                msg_hw(jme, "SMB Bus Busy.\n");
+                netif_err(jme, hw, jme->dev, "SMB Bus Busy.\n");
                 return;
         }
 
@@ -2764,19 +2796,19 @@ jme_init_one(struct pci_dev *pdev,
         atomic_set(&jme->rx_empty, 1);
 
         tasklet_init(&jme->pcc_task,
-                     &jme_pcc_tasklet,
+                     jme_pcc_tasklet,
                      (unsigned long) jme);
         tasklet_init(&jme->linkch_task,
-                     &jme_link_change_tasklet,
+                     jme_link_change_tasklet,
                      (unsigned long) jme);
         tasklet_init(&jme->txclean_task,
-                     &jme_tx_clean_tasklet,
+                     jme_tx_clean_tasklet,
                      (unsigned long) jme);
         tasklet_init(&jme->rxclean_task,
-                     &jme_rx_clean_tasklet,
+                     jme_rx_clean_tasklet,
                      (unsigned long) jme);
         tasklet_init(&jme->rxempty_task,
-                     &jme_rx_empty_tasklet,
+                     jme_rx_empty_tasklet,
                      (unsigned long) jme);
         tasklet_disable_nosync(&jme->linkch_task);
         tasklet_disable_nosync(&jme->txclean_task);
@@ -2876,14 +2908,14 @@ jme_init_one(struct pci_dev *pdev,
                 goto err_out_unmap;
         }
 
-        msg_probe(jme, "%s%s ver:%x rev:%x macaddr:%pM\n",
-                (jme->pdev->device == PCI_DEVICE_ID_JMICRON_JMC250) ?
-                        "JMC250 Gigabit Ethernet" :
-                        (jme->pdev->device == PCI_DEVICE_ID_JMICRON_JMC260) ?
-                                "JMC260 Fast Ethernet" : "Unknown",
-                (jme->fpgaver != 0) ? " (FPGA)" : "",
-                (jme->fpgaver != 0) ? jme->fpgaver : jme->chiprev,
-                jme->rev, netdev->dev_addr);
+        netif_info(jme, probe, jme->dev, "%s%s ver:%x rev:%x macaddr:%pM\n",
+                   (jme->pdev->device == PCI_DEVICE_ID_JMICRON_JMC250) ?
+                   "JMC250 Gigabit Ethernet" :
+                   (jme->pdev->device == PCI_DEVICE_ID_JMICRON_JMC260) ?
+                   "JMC260 Fast Ethernet" : "Unknown",
+                   (jme->fpgaver != 0) ? " (FPGA)" : "",
+                   (jme->fpgaver != 0) ? jme->fpgaver : jme->chiprev,
+                   jme->rev, netdev->dev_addr);
 
         return 0;
 
@@ -2994,7 +3026,7 @@ jme_resume(struct pci_dev *pdev)
 }
 #endif
 
-static struct pci_device_id jme_pci_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(jme_pci_tbl) = {
         { PCI_VDEVICE(JMICRON, PCI_DEVICE_ID_JMICRON_JMC250) },
         { PCI_VDEVICE(JMICRON, PCI_DEVICE_ID_JMICRON_JMC260) },
         { }