diff options
Diffstat (limited to 'drivers/net/hyperv/netvsc_drv.c')
-rw-r--r-- | drivers/net/hyperv/netvsc_drv.c | 21 |
1 files changed, 8 insertions, 13 deletions
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 524f713f6017..71baeb3ed905 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c | |||
@@ -261,9 +261,7 @@ int netvsc_recv_callback(struct hv_device *device_obj, | |||
261 | struct sk_buff *skb; | 261 | struct sk_buff *skb; |
262 | 262 | ||
263 | net = ((struct netvsc_device *)hv_get_drvdata(device_obj))->ndev; | 263 | net = ((struct netvsc_device *)hv_get_drvdata(device_obj))->ndev; |
264 | if (!net) { | 264 | if (!net || net->reg_state != NETREG_REGISTERED) { |
265 | netdev_err(net, "got receive callback but net device" | ||
266 | " not initialized yet\n"); | ||
267 | packet->status = NVSP_STAT_FAIL; | 265 | packet->status = NVSP_STAT_FAIL; |
268 | return 0; | 266 | return 0; |
269 | } | 267 | } |
@@ -327,7 +325,6 @@ static int netvsc_change_mtu(struct net_device *ndev, int mtu) | |||
327 | return -EINVAL; | 325 | return -EINVAL; |
328 | 326 | ||
329 | nvdev->start_remove = true; | 327 | nvdev->start_remove = true; |
330 | cancel_delayed_work_sync(&ndevctx->dwork); | ||
331 | cancel_work_sync(&ndevctx->work); | 328 | cancel_work_sync(&ndevctx->work); |
332 | netif_tx_disable(ndev); | 329 | netif_tx_disable(ndev); |
333 | rndis_filter_device_remove(hdev); | 330 | rndis_filter_device_remove(hdev); |
@@ -436,19 +433,11 @@ static int netvsc_probe(struct hv_device *dev, | |||
436 | SET_ETHTOOL_OPS(net, ðtool_ops); | 433 | SET_ETHTOOL_OPS(net, ðtool_ops); |
437 | SET_NETDEV_DEV(net, &dev->device); | 434 | SET_NETDEV_DEV(net, &dev->device); |
438 | 435 | ||
439 | ret = register_netdev(net); | ||
440 | if (ret != 0) { | ||
441 | pr_err("Unable to register netdev.\n"); | ||
442 | free_netdev(net); | ||
443 | goto out; | ||
444 | } | ||
445 | |||
446 | /* Notify the netvsc driver of the new device */ | 436 | /* Notify the netvsc driver of the new device */ |
447 | device_info.ring_size = ring_size; | 437 | device_info.ring_size = ring_size; |
448 | ret = rndis_filter_device_add(dev, &device_info); | 438 | ret = rndis_filter_device_add(dev, &device_info); |
449 | if (ret != 0) { | 439 | if (ret != 0) { |
450 | netdev_err(net, "unable to add netvsc device (ret %d)\n", ret); | 440 | netdev_err(net, "unable to add netvsc device (ret %d)\n", ret); |
451 | unregister_netdev(net); | ||
452 | free_netdev(net); | 441 | free_netdev(net); |
453 | hv_set_drvdata(dev, NULL); | 442 | hv_set_drvdata(dev, NULL); |
454 | return ret; | 443 | return ret; |
@@ -457,7 +446,13 @@ static int netvsc_probe(struct hv_device *dev, | |||
457 | 446 | ||
458 | netif_carrier_on(net); | 447 | netif_carrier_on(net); |
459 | 448 | ||
460 | out: | 449 | ret = register_netdev(net); |
450 | if (ret != 0) { | ||
451 | pr_err("Unable to register netdev.\n"); | ||
452 | rndis_filter_device_remove(dev); | ||
453 | free_netdev(net); | ||
454 | } | ||
455 | |||
461 | return ret; | 456 | return ret; |
462 | } | 457 | } |
463 | 458 | ||