1 files changed, 15 insertions, 13 deletions

diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index a19c84cad0e9..70591117051b 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -209,8 +209,8 @@ static int igb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
         /* When SoL/IDER sessions are active, autoneg/speed/duplex
          * cannot be changed */
         if (igb_check_reset_block(hw)) {
-                dev_err(&adapter->pdev->dev, "Cannot change link "
-                        "characteristics when SoL/IDER is active.\n");
+                dev_err(&adapter->pdev->dev,
+                        "Cannot change link characteristics when SoL/IDER is active.\n");
                 return -EINVAL;
         }
 
@@ -1089,8 +1089,8 @@ static bool reg_pattern_test(struct igb_adapter *adapter, u64 *data,
                 wr32(reg, (_test[pat] & write));
                 val = rd32(reg) & mask;
                 if (val != (_test[pat] & write & mask)) {
-                        dev_err(&adapter->pdev->dev, "pattern test reg %04X "
-                                "failed: got 0x%08X expected 0x%08X\n",
+                        dev_err(&adapter->pdev->dev,
+                                "pattern test reg %04X failed: got 0x%08X expected 0x%08X\n",
                                 reg, val, (_test[pat] & write & mask));
                         *data = reg;
                         return 1;
@@ -1108,8 +1108,8 @@ static bool reg_set_and_check(struct igb_adapter *adapter, u64 *data,
         wr32(reg, write & mask);
         val = rd32(reg);
         if ((write & mask) != (val & mask)) {
-                dev_err(&adapter->pdev->dev, "set/check reg %04X test failed:"
-                        " got 0x%08X expected 0x%08X\n", reg,
+                dev_err(&adapter->pdev->dev,
+                        "set/check reg %04X test failed: got 0x%08X expected 0x%08X\n", reg,
                         (val & mask), (write & mask));
                 *data = reg;
                 return 1;
@@ -1171,8 +1171,9 @@ static int igb_reg_test(struct igb_adapter *adapter, u64 *data)
         wr32(E1000_STATUS, toggle);
         after = rd32(E1000_STATUS) & toggle;
         if (value != after) {
-                dev_err(&adapter->pdev->dev, "failed STATUS register test "
-                        "got: 0x%08X expected: 0x%08X\n", after, value);
+                dev_err(&adapter->pdev->dev,
+                        "failed STATUS register test got: 0x%08X expected: 0x%08X\n",
+                        after, value);
                 *data = 1;
                 return 1;
         }
@@ -1497,6 +1498,9 @@ static int igb_integrated_phy_loopback(struct igb_adapter *adapter)
                 break;
         }
 
+        /* add small delay to avoid loopback test failure */
+        msleep(50);
+
         /* force 1000, set loopback */
         igb_write_phy_reg(hw, PHY_CONTROL, 0x4140);
 
@@ -1777,16 +1781,14 @@ static int igb_loopback_test(struct igb_adapter *adapter, u64 *data)
          * sessions are active */
         if (igb_check_reset_block(&adapter->hw)) {
                 dev_err(&adapter->pdev->dev,
-                        "Cannot do PHY loopback test "
-                        "when SoL/IDER is active.\n");
+                        "Cannot do PHY loopback test when SoL/IDER is active.\n");
                 *data = 0;
                 goto out;
         }
         if ((adapter->hw.mac.type == e1000_i210)
-                || (adapter->hw.mac.type == e1000_i210)) {
+                || (adapter->hw.mac.type == e1000_i211)) {
                 dev_err(&adapter->pdev->dev,
-                        "Loopback test not supported "
-                        "on this part at this time.\n");
+                        "Loopback test not supported on this part at this time.\n");
                 *data = 0;
                 goto out;
         }