10 files changed, 35 insertions, 81 deletions

diff --git a/drivers/net/chelsio/common.h b/drivers/net/chelsio/common.h
index 092f31a126e6..c26d863e1697 100644
--- a/drivers/net/chelsio/common.h
+++ b/drivers/net/chelsio/common.h
@@ -264,11 +264,6 @@ struct adapter {
 
 enum {                                           /* adapter flags */
         FULL_INIT_DONE        = 1 << 0,
-        TSO_CAPABLE           = 1 << 2,
-        TCP_CSUM_CAPABLE      = 1 << 3,
-        UDP_CSUM_CAPABLE      = 1 << 4,
-        VLAN_ACCEL_CAPABLE    = 1 << 5,
-        RX_CSUM_ENABLED       = 1 << 6,
 };
 
 struct mdio_ops;
diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c
index 0f71304e0542..b422d83f5343 100644
--- a/drivers/net/chelsio/cxgb2.c
+++ b/drivers/net/chelsio/cxgb2.c
@@ -192,10 +192,8 @@ static void link_start(struct port_info *p)
 
 static void enable_hw_csum(struct adapter *adapter)
 {
-        if (adapter->flags & TSO_CAPABLE)
+        if (adapter->port[0].dev->hw_features & NETIF_F_TSO)
                 t1_tp_set_ip_checksum_offload(adapter->tp, 1);  /* for TSO only */
-        if (adapter->flags & UDP_CSUM_CAPABLE)
-                t1_tp_set_udp_checksum_offload(adapter->tp, 1);
         t1_tp_set_tcp_checksum_offload(adapter->tp, 1);
 }
 
@@ -579,10 +577,10 @@ static int get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
         cmd->advertising = p->link_config.advertising;
 
         if (netif_carrier_ok(dev)) {
-                cmd->speed = p->link_config.speed;
+                ethtool_cmd_speed_set(cmd, p->link_config.speed);
                 cmd->duplex = p->link_config.duplex;
         } else {
-                cmd->speed = -1;
+                ethtool_cmd_speed_set(cmd, -1);
                 cmd->duplex = -1;
         }
 
@@ -640,11 +638,12 @@ static int set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
                 return -EOPNOTSUPP;             /* can't change speed/duplex */
 
         if (cmd->autoneg == AUTONEG_DISABLE) {
-                int cap = speed_duplex_to_caps(cmd->speed, cmd->duplex);
+                u32 speed = ethtool_cmd_speed(cmd);
+                int cap = speed_duplex_to_caps(speed, cmd->duplex);
 
-                if (!(lc->supported & cap) || cmd->speed == SPEED_1000)
+                if (!(lc->supported & cap) || (speed == SPEED_1000))
                         return -EINVAL;
-                lc->requested_speed = cmd->speed;
+                lc->requested_speed = speed;
                 lc->requested_duplex = cmd->duplex;
                 lc->advertising = 0;
         } else {
@@ -705,33 +704,6 @@ static int set_pauseparam(struct net_device *dev,
         return 0;
 }
 
-static u32 get_rx_csum(struct net_device *dev)
-{
-        struct adapter *adapter = dev->ml_priv;
-
-        return (adapter->flags & RX_CSUM_ENABLED) != 0;
-}
-
-static int set_rx_csum(struct net_device *dev, u32 data)
-{
-        struct adapter *adapter = dev->ml_priv;
-
-        if (data)
-                adapter->flags |= RX_CSUM_ENABLED;
-        else
-                adapter->flags &= ~RX_CSUM_ENABLED;
-        return 0;
-}
-
-static int set_tso(struct net_device *dev, u32 value)
-{
-        struct adapter *adapter = dev->ml_priv;
-
-        if (!(adapter->flags & TSO_CAPABLE))
-                return value ? -EOPNOTSUPP : 0;
-        return ethtool_op_set_tso(dev, value);
-}
-
 static void get_sge_param(struct net_device *dev, struct ethtool_ringparam *e)
 {
         struct adapter *adapter = dev->ml_priv;
@@ -831,17 +803,12 @@ static const struct ethtool_ops t1_ethtool_ops = {
         .get_eeprom        = get_eeprom,
         .get_pauseparam    = get_pauseparam,
         .set_pauseparam    = set_pauseparam,
-        .get_rx_csum       = get_rx_csum,
-        .set_rx_csum       = set_rx_csum,
-        .set_tx_csum       = ethtool_op_set_tx_csum,
-        .set_sg            = ethtool_op_set_sg,
         .get_link          = ethtool_op_get_link,
         .get_strings       = get_strings,
         .get_sset_count    = get_sset_count,
         .get_ethtool_stats = get_stats,
         .get_regs_len      = get_regs_len,
         .get_regs          = get_regs,
-        .set_tso           = set_tso,
 };
 
 static int t1_ioctl(struct net_device *dev, struct ifreq *req, int cmd)
@@ -1105,28 +1072,28 @@ static int __devinit init_one(struct pci_dev *pdev,
                 netdev->mem_start = mmio_start;
                 netdev->mem_end = mmio_start + mmio_len - 1;
                 netdev->ml_priv = adapter;
-                netdev->features |= NETIF_F_SG | NETIF_F_IP_CSUM;
-                netdev->features |= NETIF_F_LLTX;
+                netdev->hw_features |= NETIF_F_SG | NETIF_F_IP_CSUM |
+                        NETIF_F_RXCSUM;
+                netdev->features |= NETIF_F_SG | NETIF_F_IP_CSUM |
+                        NETIF_F_RXCSUM | NETIF_F_LLTX;
 
-                adapter->flags |= RX_CSUM_ENABLED | TCP_CSUM_CAPABLE;
                 if (pci_using_dac)
                         netdev->features |= NETIF_F_HIGHDMA;
                 if (vlan_tso_capable(adapter)) {
 #if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
-                        adapter->flags |= VLAN_ACCEL_CAPABLE;
                         netdev->features |=
                                 NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
 #endif
 
                         /* T204: disable TSO */
                         if (!(is_T2(adapter)) || bi->port_number != 4) {
-                                adapter->flags |= TSO_CAPABLE;
+                                netdev->hw_features |= NETIF_F_TSO;
                                 netdev->features |= NETIF_F_TSO;
                         }
                 }
 
                 netdev->netdev_ops = &cxgb_netdev_ops;
-                netdev->hard_header_len += (adapter->flags & TSO_CAPABLE) ?
+                netdev->hard_header_len += (netdev->hw_features & NETIF_F_TSO) ?
                         sizeof(struct cpl_tx_pkt_lso) : sizeof(struct cpl_tx_pkt);
 
                 netif_napi_add(netdev, &adapter->napi, t1_poll, 64);
diff --git a/drivers/net/chelsio/mv88e1xxx.c b/drivers/net/chelsio/mv88e1xxx.c
index 809047a99e96..71018a4fdf15 100644
--- a/drivers/net/chelsio/mv88e1xxx.c
+++ b/drivers/net/chelsio/mv88e1xxx.c
@@ -41,7 +41,7 @@ static void mdio_clear_bit(struct cphy *cphy, int reg, u32 bitval)
  *
  * PARAMS: cphy     - Pointer to PHY instance data.
  *
- * RETURN:  0 - Successfull reset.
+ * RETURN:  0 - Successful reset.
  *         -1 - Timeout.
  */
 static int mv88e1xxx_reset(struct cphy *cphy, int wait)
diff --git a/drivers/net/chelsio/my3126.c b/drivers/net/chelsio/my3126.c
index 4c6028512d10..a683fd3bb624 100644
--- a/drivers/net/chelsio/my3126.c
+++ b/drivers/net/chelsio/my3126.c
@@ -22,7 +22,7 @@ static int my3126_interrupt_enable(struct cphy *cphy)
 
 static int my3126_interrupt_disable(struct cphy *cphy)
 {
-        cancel_rearming_delayed_work(&cphy->phy_update);
+        cancel_delayed_work_sync(&cphy->phy_update);
         return 0;
 }
 
diff --git a/drivers/net/chelsio/pm3393.c b/drivers/net/chelsio/pm3393.c
index 7dbb16d36fff..40c7b93ababc 100644
--- a/drivers/net/chelsio/pm3393.c
+++ b/drivers/net/chelsio/pm3393.c
@@ -293,7 +293,7 @@ static int pm3393_enable_port(struct cmac *cmac, int which)
         pm3393_enable(cmac, which);
 
         /*
-         * XXX This should be done by the PHY and preferrably not at all.
+         * XXX This should be done by the PHY and preferably not at all.
          * The PHY doesn't give us link status indication on its own so have
          * the link management code query it instead.
          */
diff --git a/drivers/net/chelsio/sge.c b/drivers/net/chelsio/sge.c
index f01cfdb995de..58380d240619 100644
--- a/drivers/net/chelsio/sge.c
+++ b/drivers/net/chelsio/sge.c
@@ -54,6 +54,7 @@
 #include <linux/in.h>
 #include <linux/if_arp.h>
 #include <linux/slab.h>
+#include <linux/prefetch.h>
 
 #include "cpl5_cmd.h"
 #include "sge.h"
@@ -273,6 +274,10 @@ struct sge {
         struct cmdQ cmdQ[SGE_CMDQ_N] ____cacheline_aligned_in_smp;
 };
 
+static const u8 ch_mac_addr[ETH_ALEN] = {
+        0x0, 0x7, 0x43, 0x0, 0x0, 0x0
+};
+
 /*
  * stop tasklet and free all pending skb's
  */
@@ -925,7 +930,7 @@ void t1_sge_intr_enable(struct sge *sge)
         u32 en = SGE_INT_ENABLE;
         u32 val = readl(sge->adapter->regs + A_PL_ENABLE);
 
-        if (sge->adapter->flags & TSO_CAPABLE)
+        if (sge->adapter->port[0].dev->hw_features & NETIF_F_TSO)
                 en &= ~F_PACKET_TOO_BIG;
         writel(en, sge->adapter->regs + A_SG_INT_ENABLE);
         writel(val | SGE_PL_INTR_MASK, sge->adapter->regs + A_PL_ENABLE);
@@ -948,7 +953,7 @@ int t1_sge_intr_error_handler(struct sge *sge)
         struct adapter *adapter = sge->adapter;
         u32 cause = readl(adapter->regs + A_SG_INT_CAUSE);
 
-        if (adapter->flags & TSO_CAPABLE)
+        if (adapter->port[0].dev->hw_features & NETIF_F_TSO)
                 cause &= ~F_PACKET_TOO_BIG;
         if (cause & F_RESPQ_EXHAUSTED)
                 sge->stats.respQ_empty++;
@@ -1365,6 +1370,7 @@ static void sge_rx(struct sge *sge, struct freelQ *fl, unsigned int len)
         const struct cpl_rx_pkt *p;
         struct adapter *adapter = sge->adapter;
         struct sge_port_stats *st;
+        struct net_device *dev;
 
         skb = get_packet(adapter->pdev, fl, len - sge->rx_pkt_pad);
         if (unlikely(!skb)) {
@@ -1380,15 +1386,16 @@ static void sge_rx(struct sge *sge, struct freelQ *fl, unsigned int len)
         __skb_pull(skb, sizeof(*p));
 
         st = this_cpu_ptr(sge->port_stats[p->iff]);
+        dev = adapter->port[p->iff].dev;
 
-        skb->protocol = eth_type_trans(skb, adapter->port[p->iff].dev);
-        if ((adapter->flags & RX_CSUM_ENABLED) && p->csum == 0xffff &&
+        skb->protocol = eth_type_trans(skb, dev);
+        if ((dev->features & NETIF_F_RXCSUM) && p->csum == 0xffff &&
             skb->protocol == htons(ETH_P_IP) &&
             (skb->data[9] == IPPROTO_TCP || skb->data[9] == IPPROTO_UDP)) {
                 ++st->rx_cso_good;
                 skb->ip_summed = CHECKSUM_UNNECESSARY;
         } else
-                skb->ip_summed = CHECKSUM_NONE;
+                skb_checksum_none_assert(skb);
 
         if (unlikely(adapter->vlan_grp && p->vlan_valid)) {
                 st->vlan_xtract++;
@@ -1551,7 +1558,7 @@ static inline int responses_pending(const struct adapter *adapter)
         const struct respQ *Q = &adapter->sge->respQ;
         const struct respQ_e *e = &Q->entries[Q->cidx];
 
-        return (e->GenerationBit == Q->genbit);
+        return e->GenerationBit == Q->genbit;
 }
 
 /*
@@ -1658,7 +1665,7 @@ irqreturn_t t1_interrupt(int irq, void *data)
  * The code figures out how many entries the sk_buff will require in the
  * cmdQ and updates the cmdQ data structure with the state once the enqueue
  * has complete. Then, it doesn't access the global structure anymore, but
- * uses the corresponding fields on the stack. In conjuction with a spinlock
+ * uses the corresponding fields on the stack. In conjunction with a spinlock
  * around that code, we can make the function reentrant without holding the
  * lock when we actually enqueue (which might be expensive, especially on
  * architectures with IO MMUs).
@@ -1834,8 +1841,7 @@ netdev_tx_t t1_start_xmit(struct sk_buff *skb, struct net_device *dev)
                         return NETDEV_TX_OK;
                 }
 
-                if (!(adapter->flags & UDP_CSUM_CAPABLE) &&
-                    skb->ip_summed == CHECKSUM_PARTIAL &&
+                if (skb->ip_summed == CHECKSUM_PARTIAL &&
                     ip_hdr(skb)->protocol == IPPROTO_UDP) {
                         if (unlikely(skb_checksum_help(skb))) {
                                 pr_debug("%s: unable to do udp checksum\n", dev->name);
@@ -1870,7 +1876,7 @@ netdev_tx_t t1_start_xmit(struct sk_buff *skb, struct net_device *dev)
         cpl->iff = dev->if_port;
 
 #if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
-        if (adapter->vlan_grp && vlan_tx_tag_present(skb)) {
+        if (vlan_tx_tag_present(skb)) {
                 cpl->vlan_valid = 1;
                 cpl->vlan = htons(vlan_tx_tag_get(skb));
                 st->vlan_insert++;
@@ -2012,10 +2018,6 @@ static void espibug_workaround_t204(unsigned long data)
                                 continue;
 
                         if (!skb->cb[0]) {
-                                u8 ch_mac_addr[ETH_ALEN] = {
-                                        0x0, 0x7, 0x43, 0x0, 0x0, 0x0
-                                };
-
                                 skb_copy_to_linear_data_offset(skb,
                                                     sizeof(struct cpl_tx_pkt),
                                                                ch_mac_addr,
@@ -2048,8 +2050,6 @@ static void espibug_workaround(unsigned long data)
 
                 if ((seop & 0xfff0fff) == 0xfff && skb) {
                         if (!skb->cb[0]) {
-                                u8 ch_mac_addr[ETH_ALEN] =
-                                    {0x0, 0x7, 0x43, 0x0, 0x0, 0x0};
                                 skb_copy_to_linear_data_offset(skb,
                                                      sizeof(struct cpl_tx_pkt),
                                                                ch_mac_addr,
diff --git a/drivers/net/chelsio/subr.c b/drivers/net/chelsio/subr.c
index 599d178df62d..8a43c7e19701 100644
--- a/drivers/net/chelsio/subr.c
+++ b/drivers/net/chelsio/subr.c
@@ -314,14 +314,12 @@ static int mi1_mdio_write(struct net_device *dev, int phy_addr, int mmd_addr,
         return 0;
 }
 
-#if defined(CONFIG_CHELSIO_T1_1G)
 static const struct mdio_ops mi1_mdio_ops = {
         .init = mi1_mdio_init,
         .read = mi1_mdio_read,
         .write = mi1_mdio_write,
         .mode_support = MDIO_SUPPORTS_C22
 };
-#endif
 
 #endif
 
@@ -558,7 +556,7 @@ struct chelsio_vpd_t {
 #define EEPROM_MAX_POLL   4
 
 /*
- * Read SEEPROM. A zero is written to the flag register when the addres is
+ * Read SEEPROM. A zero is written to the flag register when the address is
  * written to the Control register. The hardware device will set the flag to a
  * one when 4B have been transferred to the Data register.
  */
diff --git a/drivers/net/chelsio/tp.c b/drivers/net/chelsio/tp.c
index 6222d585e447..8bed4a59e65f 100644
--- a/drivers/net/chelsio/tp.c
+++ b/drivers/net/chelsio/tp.c
@@ -152,11 +152,6 @@ void t1_tp_set_ip_checksum_offload(struct petp *tp, int enable)
         set_csum_offload(tp, F_IP_CSUM, enable);
 }
 
-void t1_tp_set_udp_checksum_offload(struct petp *tp, int enable)
-{
-        set_csum_offload(tp, F_UDP_CSUM, enable);
-}
-
 void t1_tp_set_tcp_checksum_offload(struct petp *tp, int enable)
 {
         set_csum_offload(tp, F_TCP_CSUM, enable);
diff --git a/drivers/net/chelsio/tp.h b/drivers/net/chelsio/tp.h
index 32fc71e58913..dfd8ce25106a 100644
--- a/drivers/net/chelsio/tp.h
+++ b/drivers/net/chelsio/tp.h
@@ -65,7 +65,6 @@ void t1_tp_intr_clear(struct petp *tp);
 int t1_tp_intr_handler(struct petp *tp);
 
 void t1_tp_get_mib_statistics(adapter_t *adap, struct tp_mib_statistics *tps);
-void t1_tp_set_udp_checksum_offload(struct petp *tp, int enable);
 void t1_tp_set_tcp_checksum_offload(struct petp *tp, int enable);
 void t1_tp_set_ip_checksum_offload(struct petp *tp, int enable);
 int t1_tp_set_coalescing_size(struct petp *tp, unsigned int size);
diff --git a/drivers/net/chelsio/vsc7326.c b/drivers/net/chelsio/vsc7326.c
index c844111cffeb..b0cb388f5e12 100644
--- a/drivers/net/chelsio/vsc7326.c
+++ b/drivers/net/chelsio/vsc7326.c
@@ -255,7 +255,7 @@ static int bist_rd(adapter_t *adapter, int moduleid, int address)
         else if ((result & (1 << 8)) != 0x0)
                 pr_err("bist read error: 0x%x\n", result);
 
-        return (result & 0xff);
+        return result & 0xff;
 }
 
 static int bist_wr(adapter_t *adapter, int moduleid, int address, int value)
@@ -566,7 +566,7 @@ static int mac_disable(struct cmac *mac, int which)
         for (i = 0; i <= 0x3a; ++i)
                 vsc_write(mac->adapter, CRA(4, port, i), 0);
 
-        /* Clear sofware counters */
+        /* Clear software counters */
         memset(&mac->stats, 0, sizeof(struct cmac_statistics));
 
         return 0;