1 files changed, 7 insertions, 35 deletions

diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
index f67ae285a35a..a2f29a38798a 100644
--- a/drivers/net/can/at91_can.c
+++ b/drivers/net/can/at91_can.c
@@ -221,38 +221,6 @@ static inline void set_mb_mode(const struct at91_priv *priv, unsigned int mb,
         set_mb_mode_prio(priv, mb, mode, 0);
 }
 
-static struct sk_buff *alloc_can_skb(struct net_device *dev,
-                struct can_frame **cf)
-{
-        struct sk_buff *skb;
-
-        skb = netdev_alloc_skb(dev, sizeof(struct can_frame));
-        if (unlikely(!skb))
-                return NULL;
-
-        skb->protocol = htons(ETH_P_CAN);
-        skb->ip_summed = CHECKSUM_UNNECESSARY;
-        *cf = (struct can_frame *)skb_put(skb, sizeof(struct can_frame));
-
-        return skb;
-}
-
-static struct sk_buff *alloc_can_err_skb(struct net_device *dev,
-                struct can_frame **cf)
-{
-        struct sk_buff *skb;
-
-        skb = alloc_can_skb(dev, cf);
-        if (unlikely(!skb))
-                return NULL;
-
-        memset(*cf, 0, sizeof(struct can_frame));
-        (*cf)->can_id = CAN_ERR_FLAG;
-        (*cf)->can_dlc = CAN_ERR_DLC;
-
-        return skb;
-}
-
 /*
  * Swtich transceiver on or off
  */
@@ -374,6 +342,9 @@ static netdev_tx_t at91_start_xmit(struct sk_buff *skb, struct net_device *dev)
         unsigned int mb, prio;
         u32 reg_mid, reg_mcr;
 
+        if (can_dropped_invalid_skb(dev, skb))
+                return NETDEV_TX_OK;
+
         mb = get_tx_next_mb(priv);
         prio = get_tx_next_prio(priv);
 
@@ -506,7 +477,7 @@ static void at91_read_mb(struct net_device *dev, unsigned int mb,
         reg_msr = at91_read(priv, AT91_MSR(mb));
         if (reg_msr & AT91_MSR_MRTR)
                 cf->can_id |= CAN_RTR_FLAG;
-        cf->can_dlc = min_t(__u8, (reg_msr >> 16) & 0xf, 8);
+        cf->can_dlc = get_can_dlc((reg_msr >> 16) & 0xf);
 
         *(u32 *)(cf->data + 0) = at91_read(priv, AT91_MDL(mb));
         *(u32 *)(cf->data + 4) = at91_read(priv, AT91_MDH(mb));
@@ -1069,7 +1040,7 @@ static int __init at91_can_probe(struct platform_device *pdev)
 
         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
         irq = platform_get_irq(pdev, 0);
-        if (!res || !irq) {
+        if (!res || irq <= 0) {
                 err = -ENODEV;
                 goto exit_put;
         }
@@ -1087,7 +1058,7 @@ static int __init at91_can_probe(struct platform_device *pdev)
                 goto exit_release;
         }
 
-        dev = alloc_candev(sizeof(struct at91_priv));
+        dev = alloc_candev(sizeof(struct at91_priv), AT91_MB_TX_NUM);
         if (!dev) {
                 err = -ENOMEM;
                 goto exit_iounmap;
@@ -1102,6 +1073,7 @@ static int __init at91_can_probe(struct platform_device *pdev)
         priv->can.bittiming_const = &at91_bittiming_const;
         priv->can.do_set_bittiming = at91_set_bittiming;
         priv->can.do_set_mode = at91_set_mode;
+        priv->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES;
         priv->reg_base = addr;
         priv->dev = dev;
         priv->clk = clk;