1 files changed, 10 insertions, 7 deletions

diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c
index ab688862093f..54662f24f9bb 100644
--- a/drivers/net/atlx/atl2.c
+++ b/drivers/net/atlx/atl2.c
@@ -39,6 +39,7 @@
 #include <linux/pci_ids.h>
 #include <linux/pm.h>
 #include <linux/skbuff.h>
+#include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/string.h>
 #include <linux/tcp.h>
@@ -63,7 +64,7 @@ MODULE_VERSION(ATL2_DRV_VERSION);
 /*
  * atl2_pci_tbl - PCI Device ID Table
  */
-static struct pci_device_id atl2_pci_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(atl2_pci_tbl) = {
         {PCI_DEVICE(PCI_VENDOR_ID_ATTANSIC, PCI_DEVICE_ID_ATTANSIC_L2)},
         /* required last entry */
         {0,}
@@ -157,7 +158,7 @@ static void atl2_set_multi(struct net_device *netdev)
         ATL2_WRITE_REG_ARRAY(hw, REG_RX_HASH_TABLE, 1, 0);
 
         /* comoute mc addresses' hash value ,and put it into hash table */
-        for (mc_ptr = netdev->mc_list; mc_ptr; mc_ptr = mc_ptr->next) {
+        netdev_for_each_mc_addr(mc_ptr, netdev) {
                 hash_value = atl2_hash_mc_addr(hw, mc_ptr->dmi_addr);
                 atl2_hash_set(hw, hash_value);
         }
@@ -409,7 +410,7 @@ static void atl2_intr_rx(struct atl2_adapter *adapter)
                 if (rxd->status.ok && rxd->status.pkt_size >= 60) {
                         int rx_size = (int)(rxd->status.pkt_size - 4);
                         /* alloc new buffer */
-                        skb = netdev_alloc_skb(netdev, rx_size + NET_IP_ALIGN);
+                        skb = netdev_alloc_skb_ip_align(netdev, rx_size);
                         if (NULL == skb) {
                                 printk(KERN_WARNING
                                         "%s: Mem squeeze, deferring packet.\n",
@@ -421,7 +422,6 @@ static void atl2_intr_rx(struct atl2_adapter *adapter)
                                 netdev->stats.rx_dropped++;
                                 break;
                         }
-                        skb_reserve(skb, NET_IP_ALIGN);
                         skb->dev = netdev;
                         memcpy(skb->data, rxd->packet, rx_size);
                         skb_put(skb, rx_size);
@@ -652,7 +652,7 @@ static int atl2_request_irq(struct atl2_adapter *adapter)
         if (adapter->have_msi)
                 flags &= ~IRQF_SHARED;
 
-        return request_irq(adapter->pdev->irq, &atl2_intr, flags, netdev->name,
+        return request_irq(adapter->pdev->irq, atl2_intr, flags, netdev->name,
                 netdev);
 }
 
@@ -1960,12 +1960,15 @@ static int atl2_get_eeprom(struct net_device *netdev,
                 return -ENOMEM;
 
         for (i = first_dword; i < last_dword; i++) {
-                if (!atl2_read_eeprom(hw, i*4, &(eeprom_buff[i-first_dword])))
-                        return -EIO;
+                if (!atl2_read_eeprom(hw, i*4, &(eeprom_buff[i-first_dword]))) {
+                        ret_val = -EIO;
+                        goto free;
+                }
         }
 
         memcpy(bytes, (u8 *)eeprom_buff + (eeprom->offset & 3),
                 eeprom->len);
+free:
         kfree(eeprom_buff);
 
         return ret_val;