aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mtd/spi-nor/fsl-quadspi.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/mtd/spi-nor/fsl-quadspi.c')
-rw-r--r--drivers/mtd/spi-nor/fsl-quadspi.c11
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index 1c7308c2c77d..5d5d36272bb5 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -460,8 +460,7 @@ fsl_qspi_runcmd(struct fsl_qspi *q, u8 cmd, unsigned int addr, int len)
460 writel((seqid << QUADSPI_IPCR_SEQID_SHIFT) | len, base + QUADSPI_IPCR); 460 writel((seqid << QUADSPI_IPCR_SEQID_SHIFT) | len, base + QUADSPI_IPCR);
461 461
462 /* Wait for the interrupt. */ 462 /* Wait for the interrupt. */
463 err = wait_for_completion_timeout(&q->c, msecs_to_jiffies(1000)); 463 if (!wait_for_completion_timeout(&q->c, msecs_to_jiffies(1000))) {
464 if (!err) {
465 dev_err(q->dev, 464 dev_err(q->dev,
466 "cmd 0x%.2x timeout, addr@%.8x, FR:0x%.8x, SR:0x%.8x\n", 465 "cmd 0x%.2x timeout, addr@%.8x, FR:0x%.8x, SR:0x%.8x\n",
467 cmd, addr, readl(base + QUADSPI_FR), 466 cmd, addr, readl(base + QUADSPI_FR),
@@ -830,27 +829,27 @@ static int fsl_qspi_probe(struct platform_device *pdev)
830 829
831 ret = clk_prepare_enable(q->clk_en); 830 ret = clk_prepare_enable(q->clk_en);
832 if (ret) { 831 if (ret) {
833 dev_err(dev, "can not enable the qspi_en clock\n"); 832 dev_err(dev, "cannot enable the qspi_en clock: %d\n", ret);
834 return ret; 833 return ret;
835 } 834 }
836 835
837 ret = clk_prepare_enable(q->clk); 836 ret = clk_prepare_enable(q->clk);
838 if (ret) { 837 if (ret) {
839 dev_err(dev, "can not enable the qspi clock\n"); 838 dev_err(dev, "cannot enable the qspi clock: %d\n", ret);
840 goto clk_failed; 839 goto clk_failed;
841 } 840 }
842 841
843 /* find the irq */ 842 /* find the irq */
844 ret = platform_get_irq(pdev, 0); 843 ret = platform_get_irq(pdev, 0);
845 if (ret < 0) { 844 if (ret < 0) {
846 dev_err(dev, "failed to get the irq\n"); 845 dev_err(dev, "failed to get the irq: %d\n", ret);
847 goto irq_failed; 846 goto irq_failed;
848 } 847 }
849 848
850 ret = devm_request_irq(dev, ret, 849 ret = devm_request_irq(dev, ret,
851 fsl_qspi_irq_handler, 0, pdev->name, q); 850 fsl_qspi_irq_handler, 0, pdev->name, q);
852 if (ret) { 851 if (ret) {
853 dev_err(dev, "failed to request irq.\n"); 852 dev_err(dev, "failed to request irq: %d\n", ret);
854 goto irq_failed; 853 goto irq_failed;
855 } 854 }
856 855