1 files changed, 33 insertions, 28 deletions

diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index 2df5e47d1f5c..97e9b7892d29 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -17,8 +17,9 @@
  *      02-May-2005  BJD  Reduced hwcontrol decode
  *      20-Jun-2005  BJD  Updated s3c2440 support, fixed timing bug
  *      08-Jul-2005  BJD  Fix OOPS when no platform data supplied
+ *      20-Oct-2005  BJD  Fix timing calculation bug
  *
- * $Id: s3c2410.c,v 1.14 2005/07/06 20:05:06 bjd Exp $
+ * $Id: s3c2410.c,v 1.20 2005/11/07 11:14:31 gleixner Exp $
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -136,13 +137,13 @@ static struct s3c2410_platform_nand *to_nand_plat(struct device *dev)
 
 /* timing calculations */
 
-#define NS_IN_KHZ 10000000
+#define NS_IN_KHZ 1000000
 
 static int s3c2410_nand_calc_rate(int wanted, unsigned long clk, int max)
 {
         int result;
 
-        result = (wanted * NS_IN_KHZ) / clk;
+        result = (wanted * clk) / NS_IN_KHZ;
         result++;
 
         pr_debug("result %d from %ld, %d\n", result, clk, wanted);
@@ -159,20 +160,22 @@ static int s3c2410_nand_calc_rate(int wanted, unsigned long clk, int max)
         return result;
 }
 
-#define to_ns(ticks,clk) (((clk) * (ticks)) / NS_IN_KHZ)
+#define to_ns(ticks,clk) (((ticks) * NS_IN_KHZ) / (unsigned int)(clk))
 
 /* controller setup */
 
-static int s3c2410_nand_inithw(struct s3c2410_nand_info *info, 
+static int s3c2410_nand_inithw(struct s3c2410_nand_info *info,
                                struct device *dev)
 {
         struct s3c2410_platform_nand *plat = to_nand_plat(dev);
-        unsigned int tacls, twrph0, twrph1;
         unsigned long clkrate = clk_get_rate(info->clk);
+        int tacls, twrph0, twrph1;
         unsigned long cfg;
 
         /* calculate the timing information for the controller */
 
+        clkrate /= 1000;        /* turn clock into kHz for ease of use */
+
         if (plat != NULL) {
                 tacls  = s3c2410_nand_calc_rate(plat->tacls, clkrate, 4);
                 twrph0 = s3c2410_nand_calc_rate(plat->twrph0, clkrate, 8);
@@ -183,16 +186,16 @@ static int s3c2410_nand_inithw(struct s3c2410_nand_info *info,
                 twrph0 = 8;
                 twrph1 = 8;
         }
-        
+
         if (tacls < 0 || twrph0 < 0 || twrph1 < 0) {
                 printk(KERN_ERR PFX "cannot get timings suitable for board\n");
                 return -EINVAL;
         }
 
-        printk(KERN_INFO PFX "timing: Tacls %ldns, Twrph0 %ldns, Twrph1 %ldns\n",
-               to_ns(tacls, clkrate),
-               to_ns(twrph0, clkrate),
-               to_ns(twrph1, clkrate));
+        printk(KERN_INFO PFX "Tacls=%d, %dns Twrph0=%d %dns, Twrph1=%d %dns\n",
+               tacls, to_ns(tacls, clkrate),
+               twrph0, to_ns(twrph0, clkrate),
+               twrph1, to_ns(twrph1, clkrate));
 
         if (!info->is_s3c2440) {
                 cfg  = S3C2410_NFCONF_EN;
@@ -216,7 +219,7 @@ static int s3c2410_nand_inithw(struct s3c2410_nand_info *info,
 static void s3c2410_nand_select_chip(struct mtd_info *mtd, int chip)
 {
         struct s3c2410_nand_info *info;
-        struct s3c2410_nand_mtd *nmtd; 
+        struct s3c2410_nand_mtd *nmtd;
         struct nand_chip *this = mtd->priv;
         void __iomem *reg;
         unsigned long cur;
@@ -249,7 +252,7 @@ static void s3c2410_nand_select_chip(struct mtd_info *mtd, int chip)
         writel(cur, reg);
 }
 
-/* command and control functions 
+/* command and control functions
  *
  * Note, these all use tglx's method of changing the IO_ADDR_W field
  * to make the code simpler, and use the nand layer's code to issue the
@@ -321,7 +324,7 @@ static void s3c2440_nand_hwcontrol(struct mtd_info *mtd, int cmd)
 static int s3c2410_nand_devready(struct mtd_info *mtd)
 {
         struct s3c2410_nand_info *info = s3c2410_nand_mtd_toinfo(mtd);
-        
+
         if (info->is_s3c2440)
                 return readb(info->regs + S3C2440_NFSTAT) & S3C2440_NFSTAT_READY;
         return readb(info->regs + S3C2410_NFSTAT) & S3C2410_NFSTAT_BUSY;
@@ -342,7 +345,7 @@ static int s3c2410_nand_correct_data(struct mtd_info *mtd, u_char *dat,
 
         if (read_ecc[0] == calc_ecc[0] &&
             read_ecc[1] == calc_ecc[1] &&
-            read_ecc[2] == calc_ecc[2]) 
+            read_ecc[2] == calc_ecc[2])
                 return 0;
 
         /* we curently have no method for correcting the error */
@@ -433,14 +436,14 @@ static int s3c2410_nand_remove(struct device *dev)
 
         dev_set_drvdata(dev, NULL);
 
-        if (info == NULL) 
+        if (info == NULL)
                 return 0;
 
         /* first thing we need to do is release all our mtds
          * and their partitions, then go through freeing the
-         * resources used 
+         * resources used
          */
-        
+
         if (info->mtds != NULL) {
                 struct s3c2410_nand_mtd *ptr = info->mtds;
                 int mtdno;
@@ -504,7 +507,7 @@ static int s3c2410_nand_add_partition(struct s3c2410_nand_info *info,
 
 /* s3c2410_nand_init_chip
  *
- * init a single instance of an chip 
+ * init a single instance of an chip
 */
 
 static void s3c2410_nand_init_chip(struct s3c2410_nand_info *info,
@@ -576,7 +579,7 @@ static int s3c24xx_nand_probe(struct device *dev, int is_s3c2440)
 
         info = kmalloc(sizeof(*info), GFP_KERNEL);
         if (info == NULL) {
-                printk(KERN_ERR PFX "no memory for flash info\n");
+                dev_err(dev, "no memory for flash info\n");
                 err = -ENOMEM;
                 goto exit_error;
         }
@@ -591,7 +594,7 @@ static int s3c24xx_nand_probe(struct device *dev, int is_s3c2440)
 
         info->clk = clk_get(dev, "nand");
         if (IS_ERR(info->clk)) {
-                printk(KERN_ERR PFX "failed to get clock");
+                dev_err(dev, "failed to get clock");
                 err = -ENOENT;
                 goto exit_error;
         }
@@ -608,7 +611,7 @@ static int s3c24xx_nand_probe(struct device *dev, int is_s3c2440)
         info->area = request_mem_region(res->start, size, pdev->name);
 
         if (info->area == NULL) {
-                printk(KERN_ERR PFX "cannot reserve register region\n");
+                dev_err(dev, "cannot reserve register region\n");
                 err = -ENOENT;
                 goto exit_error;
         }
@@ -619,12 +622,12 @@ static int s3c24xx_nand_probe(struct device *dev, int is_s3c2440)
         info->is_s3c2440 = is_s3c2440;
 
         if (info->regs == NULL) {
-                printk(KERN_ERR PFX "cannot reserve register region\n");
+                dev_err(dev, "cannot reserve register region\n");
                 err = -EIO;
                 goto exit_error;
-        }               
+        }
 
-        printk(KERN_INFO PFX "mapped registers at %p\n", info->regs);
+        dev_dbg(dev, "mapped registers at %p\n", info->regs);
 
         /* initialise the hardware */
 
@@ -642,7 +645,7 @@ static int s3c24xx_nand_probe(struct device *dev, int is_s3c2440)
         size = nr_sets * sizeof(*info->mtds);
         info->mtds = kmalloc(size, GFP_KERNEL);
         if (info->mtds == NULL) {
-                printk(KERN_ERR PFX "failed to allocate mtd storage\n");
+                dev_err(dev, "failed to allocate mtd storage\n");
                 err = -ENOMEM;
                 goto exit_error;
         }
@@ -656,7 +659,7 @@ static int s3c24xx_nand_probe(struct device *dev, int is_s3c2440)
         for (setno = 0; setno < nr_sets; setno++, nmtd++) {
                 pr_debug("initialising set %d (%p, info %p)\n",
                          setno, nmtd, info);
-                
+
                 s3c2410_nand_init_chip(info, nmtd, sets);
 
                 nmtd->scan_res = nand_scan(&nmtd->mtd,
@@ -669,7 +672,7 @@ static int s3c24xx_nand_probe(struct device *dev, int is_s3c2440)
                 if (sets != NULL)
                         sets++;
         }
-        
+
         pr_debug("initialised ok\n");
         return 0;
 
@@ -695,6 +698,7 @@ static int s3c2440_nand_probe(struct device *dev)
 
 static struct device_driver s3c2410_nand_driver = {
         .name           = "s3c2410-nand",
+        .owner          = THIS_MODULE,
         .bus            = &platform_bus_type,
         .probe          = s3c2410_nand_probe,
         .remove         = s3c2410_nand_remove,
@@ -702,6 +706,7 @@ static struct device_driver s3c2410_nand_driver = {
 
 static struct device_driver s3c2440_nand_driver = {
         .name           = "s3c2440-nand",
+        .owner          = THIS_MODULE,
         .bus            = &platform_bus_type,
         .probe          = s3c2440_nand_probe,
         .remove         = s3c2410_nand_remove,